Re: [PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs

[Rob Herring]

On Fri, Apr 06, 2018 at 04:16:42PM -0700, Stephen Boyd wrote:
> Quoting Lina Iyer (2018-04-06 08:13:56)
> > From: Mahesh Sivasubramanian 
> > 
> > Command DB provides information on shared resources like clocks,
> > regulators etc., probed at boot by the remote subsytem and made
> > available in shared memory.
> > 
> > Cc: devicet...@vger.kernel.org
> > Signed-off-by: Mahesh Sivasubramanian 
> > Signed-off-by: Lina Iyer 
> > Reviewed-by: Bjorn Andersson 
> > ---
> > 
> 
> Reviewed-by: Stephen Boyd 
> 
> > +   reserved-memory {
> > +   [...]
> > +   qcom,cmd-db@85fe {
> 
> Nitpick: This may want to be called 'memory@85fe' because we prefer
> generic node names.

Well, "memory" is for nodes of memory that aren't reserved. So 
"reserved-memory@..." would be better.

Otherwise,

Reviewed-by: Rob Herring 

Re: [PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs

[Rob Herring]

On Fri, Apr 06, 2018 at 04:16:42PM -0700, Stephen Boyd wrote:
> Quoting Lina Iyer (2018-04-06 08:13:56)
> > From: Mahesh Sivasubramanian 
> > 
> > Command DB provides information on shared resources like clocks,
> > regulators etc., probed at boot by the remote subsytem and made
> > available in shared memory.
> > 
> > Cc: devicet...@vger.kernel.org
> > Signed-off-by: Mahesh Sivasubramanian 
> > Signed-off-by: Lina Iyer 
> > Reviewed-by: Bjorn Andersson 
> > ---
> > 
> 
> Reviewed-by: Stephen Boyd 
> 
> > +   reserved-memory {
> > +   [...]
> > +   qcom,cmd-db@85fe {
> 
> Nitpick: This may want to be called 'memory@85fe' because we prefer
> generic node names.

Well, "memory" is for nodes of memory that aren't reserved. So 
"reserved-memory@..." would be better.

Otherwise,

Reviewed-by: Rob Herring 

Re: [PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs

[Evan Green]

On Fri, Apr 6, 2018 at 4:16 PM Stephen Boyd  wrote:

> Quoting Lina Iyer (2018-04-06 08:13:56)
> > From: Mahesh Sivasubramanian 
> >
> > Command DB provides information on shared resources like clocks,
> > regulators etc., probed at boot by the remote subsytem and made
> > available in shared memory.
> >
> > Cc: devicet...@vger.kernel.org
> > Signed-off-by: Mahesh Sivasubramanian 
> > Signed-off-by: Lina Iyer 
> > Reviewed-by: Bjorn Andersson 
> > ---
> >

> Reviewed-by: Stephen Boyd 

> > +   reserved-memory {
> > +   [...]
> > +   qcom,cmd-db@85fe {

> Nitpick: This may want to be called 'memory@85fe' because we prefer
> generic node names.

Another nit: the cmd-db region seems to need "no-map" to make the example
actually work.

Reviewed-by: Evan Green 

-Evan

Re: [PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs

[Evan Green]

On Fri, Apr 6, 2018 at 4:16 PM Stephen Boyd  wrote:

> Quoting Lina Iyer (2018-04-06 08:13:56)
> > From: Mahesh Sivasubramanian 
> >
> > Command DB provides information on shared resources like clocks,
> > regulators etc., probed at boot by the remote subsytem and made
> > available in shared memory.
> >
> > Cc: devicet...@vger.kernel.org
> > Signed-off-by: Mahesh Sivasubramanian 
> > Signed-off-by: Lina Iyer 
> > Reviewed-by: Bjorn Andersson 
> > ---
> >

> Reviewed-by: Stephen Boyd 

> > +   reserved-memory {
> > +   [...]
> > +   qcom,cmd-db@85fe {

> Nitpick: This may want to be called 'memory@85fe' because we prefer
> generic node names.

Another nit: the cmd-db region seems to need "no-map" to make the example
actually work.

Reviewed-by: Evan Green 

-Evan

Re: [PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs

[Stephen Boyd]

Quoting Lina Iyer (2018-04-06 08:13:56)
> From: Mahesh Sivasubramanian 
> 
> Command DB provides information on shared resources like clocks,
> regulators etc., probed at boot by the remote subsytem and made
> available in shared memory.
> 
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Mahesh Sivasubramanian 
> Signed-off-by: Lina Iyer 
> Reviewed-by: Bjorn Andersson 
> ---
> 

Reviewed-by: Stephen Boyd 

> +   reserved-memory {
> +   [...]
> +   qcom,cmd-db@85fe {

Nitpick: This may want to be called 'memory@85fe' because we prefer
generic node names.

Re: [PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs

[Stephen Boyd]

Quoting Lina Iyer (2018-04-06 08:13:56)
> From: Mahesh Sivasubramanian 
> 
> Command DB provides information on shared resources like clocks,
> regulators etc., probed at boot by the remote subsytem and made
> available in shared memory.
> 
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Mahesh Sivasubramanian 
> Signed-off-by: Lina Iyer 
> Reviewed-by: Bjorn Andersson 
> ---
> 

Reviewed-by: Stephen Boyd 

> +   reserved-memory {
> +   [...]
> +   qcom,cmd-db@85fe {

Nitpick: This may want to be called 'memory@85fe' because we prefer
generic node names.

[PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs

[Lina Iyer]

From: Mahesh Sivasubramanian 

Command DB provides information on shared resources like clocks,
regulators etc., probed at boot by the remote subsytem and made
available in shared memory.

Cc: devicet...@vger.kernel.org
Signed-off-by: Mahesh Sivasubramanian 
Signed-off-by: Lina Iyer 
Reviewed-by: Bjorn Andersson 
---

Changes in v7:
- Fix description of 'reg' property

Changes in v6:
- Move to bindings/reserved-memory
- Remove indirection address and use only the actual reserved
  memory

Changes in v4:
- Fix unwanted capitalization
- Add reg property
---
 .../bindings/reserved-memory/qcom,cmd-db.txt   | 36 ++
 1 file changed, 36 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt

diff --git a/Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt 
b/Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt
new file mode 100644
index ..1390cd3a7f0e
--- /dev/null
+++ b/Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt
@@ -0,0 +1,36 @@
+Command DB
+-
+
+Command DB is a database that provides a mapping between resource key and the
+resource address for a system resource managed by a remote processor. The data
+is stored in a shared memory region and is loaded by the remote processor.
+
+Some of the Qualcomm Technologies Inc SoC's have hardware accelerators for
+controlling shared resources. Depending on the board configuration the shared
+resource properties may change. These properties are dynamically probed by the
+remote processor and made available in the shared memory.
+
+The bindings for Command DB is specified in the reserved-memory section in
+devicetree. The devicetree representation of the command DB driver should be:
+
+Properties:
+- compatible:
+   Usage: required
+   Value type: 
+   Definition: Should be "qcom,cmd-db"
+
+- reg:
+   Usage: required
+   Value type: 
+   Definition: The register address that points to the actual location of
+   the Command DB in memory.
+
+Example:
+
+   reserved-memory {
+   [...]
+   qcom,cmd-db@85fe {
+   reg = <0x0 0x85fe 0x0 0x2>;
+   compatible = "qcom,cmd-db";
+   };
+   };
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

[PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs

[Lina Iyer]

From: Mahesh Sivasubramanian 

Command DB provides information on shared resources like clocks,
regulators etc., probed at boot by the remote subsytem and made
available in shared memory.

Cc: devicet...@vger.kernel.org
Signed-off-by: Mahesh Sivasubramanian 
Signed-off-by: Lina Iyer 
Reviewed-by: Bjorn Andersson 
---

Changes in v7:
- Fix description of 'reg' property

Changes in v6:
- Move to bindings/reserved-memory
- Remove indirection address and use only the actual reserved
  memory

Changes in v4:
- Fix unwanted capitalization
- Add reg property
---
 .../bindings/reserved-memory/qcom,cmd-db.txt   | 36 ++
 1 file changed, 36 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt

diff --git a/Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt 
b/Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt
new file mode 100644
index ..1390cd3a7f0e
--- /dev/null
+++ b/Documentation/devicetree/bindings/reserved-memory/qcom,cmd-db.txt
@@ -0,0 +1,36 @@
+Command DB
+-
+
+Command DB is a database that provides a mapping between resource key and the
+resource address for a system resource managed by a remote processor. The data
+is stored in a shared memory region and is loaded by the remote processor.
+
+Some of the Qualcomm Technologies Inc SoC's have hardware accelerators for
+controlling shared resources. Depending on the board configuration the shared
+resource properties may change. These properties are dynamically probed by the
+remote processor and made available in the shared memory.
+
+The bindings for Command DB is specified in the reserved-memory section in
+devicetree. The devicetree representation of the command DB driver should be:
+
+Properties:
+- compatible:
+   Usage: required
+   Value type: 
+   Definition: Should be "qcom,cmd-db"
+
+- reg:
+   Usage: required
+   Value type: 
+   Definition: The register address that points to the actual location of
+   the Command DB in memory.
+
+Example:
+
+   reserved-memory {
+   [...]
+   qcom,cmd-db@85fe {
+   reg = <0x0 0x85fe 0x0 0x2>;
+   compatible = "qcom,cmd-db";
+   };
+   };
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project