Re: [v7,1/3] arm64: dts: mt8183: add thermal zone node

[Daniel Lezcano]

On 16/03/2021 08:01, Michael Kao wrote:
> From: "michael.kao" 
> 
> Add thermal zone node to Mediatek MT8183 dts file.
> 
> Evaluate the thermal zone every 500ms while not cooling
> and every 100ms when passive cooling is performed.
> 
> Signed-off-by: Matthias Kaehlcke 
> Signed-off-by: Michael Kao 
> ---
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 85 
>  1 file changed, 85 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi 
> b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 5b782a4769e7..d3550af06408 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -657,6 +657,87 @@
>   status = "disabled";
>   };
>  
> + thermal: thermal@1100b000 {
> + #thermal-sensor-cells = <1>;
> + compatible = "mediatek,mt8183-thermal";
> + reg = <0 0x1100b000 0 0x1000>;
> + clocks = < CLK_INFRA_THERM>,
> +  < CLK_INFRA_AUXADC>;
> + clock-names = "therm", "auxadc";
> + resets = <  MT8183_INFRACFG_AO_THERM_SW_RST>;
> + interrupts = <0 76 IRQ_TYPE_LEVEL_LOW>;
> + mediatek,auxadc = <>;
> + mediatek,apmixedsys = <>;
> + nvmem-cells = <_calibration>;
> + nvmem-cell-names = "calibration-data";
> + };
> +
> + thermal-zones {
> + cpu_thermal: cpu_thermal {
> + polling-delay-passive = <100>;
> + polling-delay = <500>;
> + thermal-sensors = < 0>;
> + sustainable-power = <5000>;
> + };
> +
> + /* The tzts1 ~ tzts6 don't need to polling */
> + /* The tzts1 ~ tzts6 don't need to thermal throttle */
> +
> + tzts1: tzts1 {
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
> + thermal-sensors = < 1>;
> + sustainable-power = <5000>;
> + trips {};
> + cooling-maps {};
> + };

What is the point of defining the sustainable power with no cooling
device associated ?



-- 
 Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

Re: [v7,1/3] arm64: dts: mt8183: add thermal zone node

[Matthias Brugger]

On 22/03/2021 12:20, Hsin-Yi Wang wrote:
> On Tue, Mar 16, 2021 at 3:02 PM Michael Kao  wrote:
>>
>> From: "michael.kao" 
>>
>> Add thermal zone node to Mediatek MT8183 dts file.
>>
>> Evaluate the thermal zone every 500ms while not cooling
>> and every 100ms when passive cooling is performed.
>>
>> Signed-off-by: Matthias Kaehlcke 
>> Signed-off-by: Michael Kao 
> 
> Tested-by: Hsin-Yi Wang 
> 

Applied to v5.12-next/dts64

Thanks!

> Tested this patch on mt8183 devices.
> 
>> ---
>>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 85 
>>  1 file changed, 85 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi 
>> b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index 5b782a4769e7..d3550af06408 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -657,6 +657,87 @@
>> status = "disabled";
>> };
>>
>> +   thermal: thermal@1100b000 {
>> +   #thermal-sensor-cells = <1>;
>> +   compatible = "mediatek,mt8183-thermal";
>> +   reg = <0 0x1100b000 0 0x1000>;
>> +   clocks = < CLK_INFRA_THERM>,
>> +< CLK_INFRA_AUXADC>;
>> +   clock-names = "therm", "auxadc";
>> +   resets = <  
>> MT8183_INFRACFG_AO_THERM_SW_RST>;
>> +   interrupts = <0 76 IRQ_TYPE_LEVEL_LOW>;
>> +   mediatek,auxadc = <>;
>> +   mediatek,apmixedsys = <>;
>> +   nvmem-cells = <_calibration>;
>> +   nvmem-cell-names = "calibration-data";
>> +   };
>> +
>> +   thermal-zones {
>> +   cpu_thermal: cpu_thermal {
>> +   polling-delay-passive = <100>;
>> +   polling-delay = <500>;
>> +   thermal-sensors = < 0>;
>> +   sustainable-power = <5000>;
>> +   };
>> +
>> +   /* The tzts1 ~ tzts6 don't need to polling */
>> +   /* The tzts1 ~ tzts6 don't need to thermal throttle 
>> */
>> +
>> +   tzts1: tzts1 {
>> +   polling-delay-passive = <0>;
>> +   polling-delay = <0>;
>> +   thermal-sensors = < 1>;
>> +   sustainable-power = <5000>;
>> +   trips {};
>> +   cooling-maps {};
>> +   };
>> +
>> +   tzts2: tzts2 {
>> +   polling-delay-passive = <0>;
>> +   polling-delay = <0>;
>> +   thermal-sensors = < 2>;
>> +   sustainable-power = <5000>;
>> +   trips {};
>> +   cooling-maps {};
>> +   };
>> +
>> +   tzts3: tzts3 {
>> +   polling-delay-passive = <0>;
>> +   polling-delay = <0>;
>> +   thermal-sensors = < 3>;
>> +   sustainable-power = <5000>;
>> +   trips {};
>> +   cooling-maps {};
>> +   };
>> +
>> +   tzts4: tzts4 {
>> +   polling-delay-passive = <0>;
>> +   polling-delay = <0>;
>> +   thermal-sensors = < 4>;
>> +   sustainable-power = <5000>;
>> +   trips {};
>> +   cooling-maps {};
>> +   };
>> +
>> +   tzts5: tzts5 {
>> +   polling-delay-passive = <0>;
>> +   polling-delay = <0>;
>> +   thermal-sensors = < 5>;
>> +   sustainable-power = <5000>;
>> +   trips {};
>> +   cooling-maps {};
>> +   };
>> +
>> +   tztsABB: tztsABB {
>> +   polling-delay-passive = <0>;
>> +   polling-delay = <0>;
>> +   thermal-sensors = < 6>;
>> +   sustainable-power = <5000>;
>> +   trips {};
>> +   cooling-maps {};
>> +   };
>> +   };
>> +
>> pwm0: pwm@1100e000 {
>> compatible = "mediatek,mt8183-disp-pwm";
>> reg = <0 0x1100e000 0 0x1000>;
>> @@ -926,6 +1007,10 @@
>>

Re: [v7,1/3] arm64: dts: mt8183: add thermal zone node

[Hsin-Yi Wang]

On Tue, Mar 16, 2021 at 3:02 PM Michael Kao  wrote:
>
> From: "michael.kao" 
>
> Add thermal zone node to Mediatek MT8183 dts file.
>
> Evaluate the thermal zone every 500ms while not cooling
> and every 100ms when passive cooling is performed.
>
> Signed-off-by: Matthias Kaehlcke 
> Signed-off-by: Michael Kao 

Tested-by: Hsin-Yi Wang 

Tested this patch on mt8183 devices.

> ---
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 85 
>  1 file changed, 85 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi 
> b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 5b782a4769e7..d3550af06408 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -657,6 +657,87 @@
> status = "disabled";
> };
>
> +   thermal: thermal@1100b000 {
> +   #thermal-sensor-cells = <1>;
> +   compatible = "mediatek,mt8183-thermal";
> +   reg = <0 0x1100b000 0 0x1000>;
> +   clocks = < CLK_INFRA_THERM>,
> +< CLK_INFRA_AUXADC>;
> +   clock-names = "therm", "auxadc";
> +   resets = <  MT8183_INFRACFG_AO_THERM_SW_RST>;
> +   interrupts = <0 76 IRQ_TYPE_LEVEL_LOW>;
> +   mediatek,auxadc = <>;
> +   mediatek,apmixedsys = <>;
> +   nvmem-cells = <_calibration>;
> +   nvmem-cell-names = "calibration-data";
> +   };
> +
> +   thermal-zones {
> +   cpu_thermal: cpu_thermal {
> +   polling-delay-passive = <100>;
> +   polling-delay = <500>;
> +   thermal-sensors = < 0>;
> +   sustainable-power = <5000>;
> +   };
> +
> +   /* The tzts1 ~ tzts6 don't need to polling */
> +   /* The tzts1 ~ tzts6 don't need to thermal throttle */
> +
> +   tzts1: tzts1 {
> +   polling-delay-passive = <0>;
> +   polling-delay = <0>;
> +   thermal-sensors = < 1>;
> +   sustainable-power = <5000>;
> +   trips {};
> +   cooling-maps {};
> +   };
> +
> +   tzts2: tzts2 {
> +   polling-delay-passive = <0>;
> +   polling-delay = <0>;
> +   thermal-sensors = < 2>;
> +   sustainable-power = <5000>;
> +   trips {};
> +   cooling-maps {};
> +   };
> +
> +   tzts3: tzts3 {
> +   polling-delay-passive = <0>;
> +   polling-delay = <0>;
> +   thermal-sensors = < 3>;
> +   sustainable-power = <5000>;
> +   trips {};
> +   cooling-maps {};
> +   };
> +
> +   tzts4: tzts4 {
> +   polling-delay-passive = <0>;
> +   polling-delay = <0>;
> +   thermal-sensors = < 4>;
> +   sustainable-power = <5000>;
> +   trips {};
> +   cooling-maps {};
> +   };
> +
> +   tzts5: tzts5 {
> +   polling-delay-passive = <0>;
> +   polling-delay = <0>;
> +   thermal-sensors = < 5>;
> +   sustainable-power = <5000>;
> +   trips {};
> +   cooling-maps {};
> +   };
> +
> +   tztsABB: tztsABB {
> +   polling-delay-passive = <0>;
> +   polling-delay = <0>;
> +   thermal-sensors = < 6>;
> +   sustainable-power = <5000>;
> +   trips {};
> +   cooling-maps {};
> +   };
> +   };
> +
> pwm0: pwm@1100e000 {
> compatible = "mediatek,mt8183-disp-pwm";
> reg = <0 0x1100e000 0 0x1000>;
> @@ -926,6 +1007,10 @@
> reg = <0 0x11f1 0 0x1000>;
> #address-cells = <1>;
> #size-cells = <1>;
> +   thermal_calibration: calib@180 {
> + 

[v7,1/3] arm64: dts: mt8183: add thermal zone node

[Michael Kao]

From: "michael.kao" 

Add thermal zone node to Mediatek MT8183 dts file.

Evaluate the thermal zone every 500ms while not cooling
and every 100ms when passive cooling is performed.

Signed-off-by: Matthias Kaehlcke 
Signed-off-by: Michael Kao 
---
 arch/arm64/boot/dts/mediatek/mt8183.dtsi | 85 
 1 file changed, 85 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi 
b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 5b782a4769e7..d3550af06408 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -657,6 +657,87 @@
status = "disabled";
};
 
+   thermal: thermal@1100b000 {
+   #thermal-sensor-cells = <1>;
+   compatible = "mediatek,mt8183-thermal";
+   reg = <0 0x1100b000 0 0x1000>;
+   clocks = < CLK_INFRA_THERM>,
+< CLK_INFRA_AUXADC>;
+   clock-names = "therm", "auxadc";
+   resets = <  MT8183_INFRACFG_AO_THERM_SW_RST>;
+   interrupts = <0 76 IRQ_TYPE_LEVEL_LOW>;
+   mediatek,auxadc = <>;
+   mediatek,apmixedsys = <>;
+   nvmem-cells = <_calibration>;
+   nvmem-cell-names = "calibration-data";
+   };
+
+   thermal-zones {
+   cpu_thermal: cpu_thermal {
+   polling-delay-passive = <100>;
+   polling-delay = <500>;
+   thermal-sensors = < 0>;
+   sustainable-power = <5000>;
+   };
+
+   /* The tzts1 ~ tzts6 don't need to polling */
+   /* The tzts1 ~ tzts6 don't need to thermal throttle */
+
+   tzts1: tzts1 {
+   polling-delay-passive = <0>;
+   polling-delay = <0>;
+   thermal-sensors = < 1>;
+   sustainable-power = <5000>;
+   trips {};
+   cooling-maps {};
+   };
+
+   tzts2: tzts2 {
+   polling-delay-passive = <0>;
+   polling-delay = <0>;
+   thermal-sensors = < 2>;
+   sustainable-power = <5000>;
+   trips {};
+   cooling-maps {};
+   };
+
+   tzts3: tzts3 {
+   polling-delay-passive = <0>;
+   polling-delay = <0>;
+   thermal-sensors = < 3>;
+   sustainable-power = <5000>;
+   trips {};
+   cooling-maps {};
+   };
+
+   tzts4: tzts4 {
+   polling-delay-passive = <0>;
+   polling-delay = <0>;
+   thermal-sensors = < 4>;
+   sustainable-power = <5000>;
+   trips {};
+   cooling-maps {};
+   };
+
+   tzts5: tzts5 {
+   polling-delay-passive = <0>;
+   polling-delay = <0>;
+   thermal-sensors = < 5>;
+   sustainable-power = <5000>;
+   trips {};
+   cooling-maps {};
+   };
+
+   tztsABB: tztsABB {
+   polling-delay-passive = <0>;
+   polling-delay = <0>;
+   thermal-sensors = < 6>;
+   sustainable-power = <5000>;
+   trips {};
+   cooling-maps {};
+   };
+   };
+
pwm0: pwm@1100e000 {
compatible = "mediatek,mt8183-disp-pwm";
reg = <0 0x1100e000 0 0x1000>;
@@ -926,6 +1007,10 @@
reg = <0 0x11f1 0 0x1000>;
#address-cells = <1>;
#size-cells = <1>;
+   thermal_calibration: calib@180 {
+   reg = <0x180 0xc>;
+   };
+
mipi_tx_calibration: calib@190 {
reg = <0x190 0xc>;
};
-- 
2.18.0