RE: [PATCH] thermal: qoriq: add thermal monitor unit version 2 support
Hi Anson, Points are taken. Will send out the next version. Thanks, Andy > -Original Message- > From: Anson Huang > Sent: 2019年9月24日 10:11 > To: Andy Tang ; Zhang Rui ; > edubez...@gmail.com > Cc: daniel.lezc...@linaro.org; Leo Li ; > linux...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit version 2 > support > > Hi, Andy > > > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit version > > 2 support > > > > Hi Anson, > > > > Thanks for your review. Please see my reply inline. > > > > > -Original Message- > > > From: Anson Huang > > > Sent: 2019年9月24日 9:17 > > > To: Zhang Rui ; Andy Tang ; > > > edubez...@gmail.com > > > Cc: daniel.lezc...@linaro.org; Leo Li ; > > > linux...@vger.kernel.org; linux-kernel@vger.kernel.org > > > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit > > > version > > > 2 support > > > > > > Hi, Andy > > > > > > > > > > On Mon, 2019-09-23 at 09:24 +, Andy Tang wrote: > > > > > Hi Rui, Edubezval, > > > > > > > > > > Would you please review this patch? > > > > > > > > > CC Anson Huang. > > > > I'd prefer all the qoriq thermal patches go through his review first. > > > > > > > > thanks, > > > > rui > > > > > > > > > BR, > > > > > Andy > > > > > > > > > > > -Original Message- > > > > > > From: Andy Tang > > > > > > Sent: 2019年8月29日 16:38 > > > > > > To: 'edubez...@gmail.com' ; > > > > > > 'rui.zh...@intel.com' > > > > > > > > > > > > Cc: 'daniel.lezc...@linaro.org' ; > > > > > > Leo Li ; 'linux...@vger.kernel.org' > > > > > > ; 'linux-kernel@vger.kernel.org' > > > > > > > > > > > > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit > > > > > > version 2 support > > > > > > > > > > > > Hi Rui, Edubezval, > > > > > > > > > > > > Almost three monthes passed, I have not got your comments from > > you. > > > > > > Could you please take a look at this patch? > > > > > > > > > > > > BR, > > > > > > Andy > > > > > > > > > > > > > -Original Message- > > > > > > > From: Andy Tang > > > > > > > Sent: 2019年8月6日 10:57 > > > > > > > To: edubez...@gmail.com; rui.zh...@intel.com > > > > > > > Cc: daniel.lezc...@linaro.org; Leo Li ; > > > > > > > linux...@vger.kernel.org; linux-kernel@vger.kernel.org > > > > > > > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor > > > > > > > unit version > > > > > > > 2 support > > > > > > > > > > > > > > Any comments? > > > > > > > > > > > > > > BR, > > > > > > > Andy > > > > > > > > > > > > > > > -Original Message- > > > > > > > > From: Yuantian Tang > > > > > > > > Sent: 2019年6月4日 10:51 > > > > > > > > To: edubez...@gmail.com; rui.zh...@intel.com > > > > > > > > Cc: daniel.lezc...@linaro.org; Leo Li > > > > > > > > ; linux...@vger.kernel.org; > > > > > > > > linux-kernel@vger.kernel.org; Andy Tang > > > > > > > > > > > > > > > > Subject: [PATCH] thermal: qoriq: add thermal monitor unit > > > > > > > > version 2 support > > > > > > > > > > > > > > > > Thermal Monitor Unit v2 is introduced on new Layscape SoC. > > > > > > > > Compared to v1, TMUv2 has a little different register > > > > > > > > layout and digital output is fairly linear. > > > > > > > > > > > > > > > > Signed-off-by: Yuantian Tang > > > > > > > > --- > > > > > > > > drivers/thermal/qoriq_thermal.c | 122 > > > > > > > > +--- > > > > > > > > 1 file changed, 98 ins
RE: [PATCH] thermal: qoriq: add thermal monitor unit version 2 support
Hi, Andy > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit version 2 > support > > Hi Anson, > > Thanks for your review. Please see my reply inline. > > > -Original Message- > > From: Anson Huang > > Sent: 2019年9月24日 9:17 > > To: Zhang Rui ; Andy Tang ; > > edubez...@gmail.com > > Cc: daniel.lezc...@linaro.org; Leo Li ; > > linux...@vger.kernel.org; linux-kernel@vger.kernel.org > > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit version > > 2 support > > > > Hi, Andy > > > > > > > On Mon, 2019-09-23 at 09:24 +, Andy Tang wrote: > > > > Hi Rui, Edubezval, > > > > > > > > Would you please review this patch? > > > > > > > CC Anson Huang. > > > I'd prefer all the qoriq thermal patches go through his review first. > > > > > > thanks, > > > rui > > > > > > > BR, > > > > Andy > > > > > > > > > -Original Message- > > > > > From: Andy Tang > > > > > Sent: 2019年8月29日 16:38 > > > > > To: 'edubez...@gmail.com' ; > > > > > 'rui.zh...@intel.com' > > > > > > > > > > Cc: 'daniel.lezc...@linaro.org' ; Leo > > > > > Li ; 'linux...@vger.kernel.org' > > > > > ; 'linux-kernel@vger.kernel.org' > > > > > > > > > > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit > > > > > version 2 support > > > > > > > > > > Hi Rui, Edubezval, > > > > > > > > > > Almost three monthes passed, I have not got your comments from > you. > > > > > Could you please take a look at this patch? > > > > > > > > > > BR, > > > > > Andy > > > > > > > > > > > -Original Message- > > > > > > From: Andy Tang > > > > > > Sent: 2019年8月6日 10:57 > > > > > > To: edubez...@gmail.com; rui.zh...@intel.com > > > > > > Cc: daniel.lezc...@linaro.org; Leo Li ; > > > > > > linux...@vger.kernel.org; linux-kernel@vger.kernel.org > > > > > > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit > > > > > > version > > > > > > 2 support > > > > > > > > > > > > Any comments? > > > > > > > > > > > > BR, > > > > > > Andy > > > > > > > > > > > > > -Original Message- > > > > > > > From: Yuantian Tang > > > > > > > Sent: 2019年6月4日 10:51 > > > > > > > To: edubez...@gmail.com; rui.zh...@intel.com > > > > > > > Cc: daniel.lezc...@linaro.org; Leo Li ; > > > > > > > linux...@vger.kernel.org; linux-kernel@vger.kernel.org; Andy > > > > > > > Tang > > > > > > > Subject: [PATCH] thermal: qoriq: add thermal monitor unit > > > > > > > version 2 support > > > > > > > > > > > > > > Thermal Monitor Unit v2 is introduced on new Layscape SoC. > > > > > > > Compared to v1, TMUv2 has a little different register layout > > > > > > > and digital output is fairly linear. > > > > > > > > > > > > > > Signed-off-by: Yuantian Tang > > > > > > > --- > > > > > > > drivers/thermal/qoriq_thermal.c | 122 > > > > > > > +--- > > > > > > > 1 file changed, 98 insertions(+), 24 deletions(-) > > > > > > > > > > > > > > diff --git a/drivers/thermal/qoriq_thermal.c > > > > > > > b/drivers/thermal/qoriq_thermal.c index > > > > > > > 3b5f5b3fb1bc..0df6dfddf804 > > > > > > > 100644 > > > > > > > --- a/drivers/thermal/qoriq_thermal.c > > > > > > > +++ b/drivers/thermal/qoriq_thermal.c > > > > > > > @@ -13,6 +13,15 @@ > > > > > > > #include "thermal_core.h" > > > > > > > > > > > > > > #define SITES_MAX16 > > > > > > > +#define TMR_DISABLE 0x0 > > > > > > > +#define TMR_ME 0x8000 > > > > > > > +#define TMR_ALPF 0x0c00 > > > > > > > +#define
RE: [PATCH] thermal: qoriq: add thermal monitor unit version 2 support
Hi Anson, Thanks for your review. Please see my reply inline. > -Original Message- > From: Anson Huang > Sent: 2019年9月24日 9:17 > To: Zhang Rui ; Andy Tang ; > edubez...@gmail.com > Cc: daniel.lezc...@linaro.org; Leo Li ; > linux...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit version 2 > support > > Hi, Andy > > > > On Mon, 2019-09-23 at 09:24 +, Andy Tang wrote: > > > Hi Rui, Edubezval, > > > > > > Would you please review this patch? > > > > > CC Anson Huang. > > I'd prefer all the qoriq thermal patches go through his review first. > > > > thanks, > > rui > > > > > BR, > > > Andy > > > > > > > -Original Message- > > > > From: Andy Tang > > > > Sent: 2019年8月29日 16:38 > > > > To: 'edubez...@gmail.com' ; > > > > 'rui.zh...@intel.com' > > > > > > > > Cc: 'daniel.lezc...@linaro.org' ; Leo > > > > Li ; 'linux...@vger.kernel.org' > > > > ; 'linux-kernel@vger.kernel.org' > > > > > > > > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit > > > > version 2 support > > > > > > > > Hi Rui, Edubezval, > > > > > > > > Almost three monthes passed, I have not got your comments from you. > > > > Could you please take a look at this patch? > > > > > > > > BR, > > > > Andy > > > > > > > > > -Original Message- > > > > > From: Andy Tang > > > > > Sent: 2019年8月6日 10:57 > > > > > To: edubez...@gmail.com; rui.zh...@intel.com > > > > > Cc: daniel.lezc...@linaro.org; Leo Li ; > > > > > linux...@vger.kernel.org; linux-kernel@vger.kernel.org > > > > > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit > > > > > version > > > > > 2 support > > > > > > > > > > Any comments? > > > > > > > > > > BR, > > > > > Andy > > > > > > > > > > > -Original Message- > > > > > > From: Yuantian Tang > > > > > > Sent: 2019年6月4日 10:51 > > > > > > To: edubez...@gmail.com; rui.zh...@intel.com > > > > > > Cc: daniel.lezc...@linaro.org; Leo Li ; > > > > > > linux...@vger.kernel.org; linux-kernel@vger.kernel.org; Andy > > > > > > Tang > > > > > > Subject: [PATCH] thermal: qoriq: add thermal monitor unit > > > > > > version 2 support > > > > > > > > > > > > Thermal Monitor Unit v2 is introduced on new Layscape SoC. > > > > > > Compared to v1, TMUv2 has a little different register layout > > > > > > and digital output is fairly linear. > > > > > > > > > > > > Signed-off-by: Yuantian Tang > > > > > > --- > > > > > > drivers/thermal/qoriq_thermal.c | 122 > > > > > > +--- > > > > > > 1 file changed, 98 insertions(+), 24 deletions(-) > > > > > > > > > > > > diff --git a/drivers/thermal/qoriq_thermal.c > > > > > > b/drivers/thermal/qoriq_thermal.c index > > > > > > 3b5f5b3fb1bc..0df6dfddf804 > > > > > > 100644 > > > > > > --- a/drivers/thermal/qoriq_thermal.c > > > > > > +++ b/drivers/thermal/qoriq_thermal.c > > > > > > @@ -13,6 +13,15 @@ > > > > > > #include "thermal_core.h" > > > > > > > > > > > > #define SITES_MAX 16 > > > > > > +#define TMR_DISABLE0x0 > > > > > > +#define TMR_ME 0x8000 > > > > > > +#define TMR_ALPF 0x0c00 > > > > > > +#define TMR_ALPF_V20x0300 > > > > > > +#define TMTMIR_DEFAULT 0x000f > > > > > > +#define TIER_DISABLE 0x0 > > > > > > +#define TEUMR0_V2 0x51009C00 > > Better to use either lower case or capital letter for all macro definitions, > some are lower case and some are capital letter look like NOT aligned. I always use capital letter to define a macro. Did I use lower letter somewhere? > > > > > > > +#define TMU_VER1 0x1 > > > > > > +#define TMU_VER2 0x2 > > > > > > >
RE: [PATCH] thermal: qoriq: add thermal monitor unit version 2 support
Hi, Andy
> On Mon, 2019-09-23 at 09:24 +, Andy Tang wrote:
> > Hi Rui, Edubezval,
> >
> > Would you please review this patch?
> >
> CC Anson Huang.
> I'd prefer all the qoriq thermal patches go through his review first.
>
> thanks,
> rui
>
> > BR,
> > Andy
> >
> > > -Original Message-
> > > From: Andy Tang
> > > Sent: 2019年8月29日 16:38
> > > To: 'edubez...@gmail.com' ;
> > > 'rui.zh...@intel.com'
> > >
> > > Cc: 'daniel.lezc...@linaro.org' ; Leo Li
> > > ; 'linux...@vger.kernel.org'
> > > ; 'linux-kernel@vger.kernel.org'
> > >
> > > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit
> > > version 2 support
> > >
> > > Hi Rui, Edubezval,
> > >
> > > Almost three monthes passed, I have not got your comments from you.
> > > Could you please take a look at this patch?
> > >
> > > BR,
> > > Andy
> > >
> > > > -----Original Message-----
> > > > From: Andy Tang
> > > > Sent: 2019年8月6日 10:57
> > > > To: edubez...@gmail.com; rui.zh...@intel.com
> > > > Cc: daniel.lezc...@linaro.org; Leo Li ;
> > > > linux...@vger.kernel.org; linux-kernel@vger.kernel.org
> > > > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit
> > > > version
> > > > 2 support
> > > >
> > > > Any comments?
> > > >
> > > > BR,
> > > > Andy
> > > >
> > > > > -Original Message-
> > > > > From: Yuantian Tang
> > > > > Sent: 2019年6月4日 10:51
> > > > > To: edubez...@gmail.com; rui.zh...@intel.com
> > > > > Cc: daniel.lezc...@linaro.org; Leo Li ;
> > > > > linux...@vger.kernel.org; linux-kernel@vger.kernel.org; Andy
> > > > > Tang
> > > > > Subject: [PATCH] thermal: qoriq: add thermal monitor unit
> > > > > version 2 support
> > > > >
> > > > > Thermal Monitor Unit v2 is introduced on new Layscape SoC.
> > > > > Compared to v1, TMUv2 has a little different register layout and
> > > > > digital output is fairly linear.
> > > > >
> > > > > Signed-off-by: Yuantian Tang
> > > > > ---
> > > > > drivers/thermal/qoriq_thermal.c | 122
> > > > > +---
> > > > > 1 file changed, 98 insertions(+), 24 deletions(-)
> > > > >
> > > > > diff --git a/drivers/thermal/qoriq_thermal.c
> > > > > b/drivers/thermal/qoriq_thermal.c index
> > > > > 3b5f5b3fb1bc..0df6dfddf804
> > > > > 100644
> > > > > --- a/drivers/thermal/qoriq_thermal.c
> > > > > +++ b/drivers/thermal/qoriq_thermal.c
> > > > > @@ -13,6 +13,15 @@
> > > > > #include "thermal_core.h"
> > > > >
> > > > > #define SITES_MAX16
> > > > > +#define TMR_DISABLE 0x0
> > > > > +#define TMR_ME 0x8000
> > > > > +#define TMR_ALPF 0x0c00
> > > > > +#define TMR_ALPF_V2 0x0300
> > > > > +#define TMTMIR_DEFAULT 0x000f
> > > > > +#define TIER_DISABLE 0x0
> > > > > +#define TEUMR0_V20x51009C00
Better to use either lower case or capital letter for all macro definitions,
some are lower case and some are capital letter look like NOT aligned.
> > > > > +#define TMU_VER1 0x1
> > > > > +#define TMU_VER2 0x2
> > > > >
> > > > > /*
> > > > > * QorIQ TMU Registers
> > > > > @@ -23,17 +32,55 @@ struct qoriq_tmu_site_regs {
> > > > > u8 res0[0x8];
> > > > > };
> > > > >
> > > > > -struct qoriq_tmu_regs {
> > > > > +struct qoriq_tmu_regs_v2 {
> > > > > + u32 tmr;/* Mode Register */
> > > > > + u32 tsr;/* Status Register */
> > > > > + u32 tmsr; /* monitor site register */
> > > > > + u32 tmtmir; /* Temperature measurement
> > > > > interval Register
> > >
> > > */
> > > > > + u8 res0[0x10];
> > > > > + u32 tier; /* Interrupt Enable Register */
> > > > > + u32 tidr; /* Interrupt Detect Register */
> > &g
Re: [PATCH] thermal: qoriq: add thermal monitor unit version 2 support
On Mon, 2019-09-23 at 09:24 +, Andy Tang wrote:
> Hi Rui, Edubezval,
>
> Would you please review this patch?
>
CC Anson Huang.
I'd prefer all the qoriq thermal patches go through his review first.
thanks,
rui
> BR,
> Andy
>
> > -Original Message-
> > From: Andy Tang
> > Sent: 2019年8月29日 16:38
> > To: 'edubez...@gmail.com' ;
> > 'rui.zh...@intel.com'
> >
> > Cc: 'daniel.lezc...@linaro.org' ; Leo Li
> > ; 'linux...@vger.kernel.org'
> > ; 'linux-kernel@vger.kernel.org'
> >
> > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit
> > version 2
> > support
> >
> > Hi Rui, Edubezval,
> >
> > Almost three monthes passed, I have not got your comments from you.
> > Could you please take a look at this patch?
> >
> > BR,
> > Andy
> >
> > > -Original Message-
> > > From: Andy Tang
> > > Sent: 2019年8月6日 10:57
> > > To: edubez...@gmail.com; rui.zh...@intel.com
> > > Cc: daniel.lezc...@linaro.org; Leo Li ;
> > > linux...@vger.kernel.org; linux-kernel@vger.kernel.org
> > > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit
> > > version
> > > 2 support
> > >
> > > Any comments?
> > >
> > > BR,
> > > Andy
> > >
> > > > -Original Message-
> > > > From: Yuantian Tang
> > > > Sent: 2019年6月4日 10:51
> > > > To: edubez...@gmail.com; rui.zh...@intel.com
> > > > Cc: daniel.lezc...@linaro.org; Leo Li ;
> > > > linux...@vger.kernel.org; linux-kernel@vger.kernel.org; Andy
> > > > Tang
> > > >
> > > > Subject: [PATCH] thermal: qoriq: add thermal monitor unit
> > > > version 2
> > > > support
> > > >
> > > > Thermal Monitor Unit v2 is introduced on new Layscape SoC.
> > > > Compared to v1, TMUv2 has a little different register layout
> > > > and
> > > > digital output is fairly linear.
> > > >
> > > > Signed-off-by: Yuantian Tang
> > > > ---
> > > > drivers/thermal/qoriq_thermal.c | 122
> > > > +---
> > > > 1 file changed, 98 insertions(+), 24 deletions(-)
> > > >
> > > > diff --git a/drivers/thermal/qoriq_thermal.c
> > > > b/drivers/thermal/qoriq_thermal.c index
> > > > 3b5f5b3fb1bc..0df6dfddf804
> > > > 100644
> > > > --- a/drivers/thermal/qoriq_thermal.c
> > > > +++ b/drivers/thermal/qoriq_thermal.c
> > > > @@ -13,6 +13,15 @@
> > > > #include "thermal_core.h"
> > > >
> > > > #define SITES_MAX 16
> > > > +#define TMR_DISABLE0x0
> > > > +#define TMR_ME 0x8000
> > > > +#define TMR_ALPF 0x0c00
> > > > +#define TMR_ALPF_V20x0300
> > > > +#define TMTMIR_DEFAULT 0x000f
> > > > +#define TIER_DISABLE 0x0
> > > > +#define TEUMR0_V2 0x51009C00
> > > > +#define TMU_VER1 0x1
> > > > +#define TMU_VER2 0x2
> > > >
> > > > /*
> > > > * QorIQ TMU Registers
> > > > @@ -23,17 +32,55 @@ struct qoriq_tmu_site_regs {
> > > > u8 res0[0x8];
> > > > };
> > > >
> > > > -struct qoriq_tmu_regs {
> > > > +struct qoriq_tmu_regs_v2 {
> > > > + u32 tmr;/* Mode Register */
> > > > + u32 tsr;/* Status Register */
> > > > + u32 tmsr; /* monitor site register */
> > > > + u32 tmtmir; /* Temperature measurement
> > > > interval Register
> >
> > */
> > > > + u8 res0[0x10];
> > > > + u32 tier; /* Interrupt Enable Register */
> > > > + u32 tidr; /* Interrupt Detect Register */
> > > > + u8 res1[0x8];
> > > > + u32 tiiscr; /* interrupt immediate site
> > > > capture register */
> > > > + u32 tiascr; /* interrupt average site
> > > > capture register */
> > > > + u32 ticscr; /* Interrupt Critical Site
> > > > Capture Register */
> > > > + u32 res2;
> > > > + u32 tmhtcr; /* monitor high temperature
> > > > capture register */
> > > > + u32 tmltcr
Re: [PATCH] thermal: qoriq: add thermal monitor unit version 2 support
On 23/09/2019 11:24, Andy Tang wrote:
> Hi Rui, Edubezval,
>
> Would you please review this patch?
Eduardo,
can you give an update about the thermal maintenance discussion we had
at LPC2019?
Thanks
-- Daniel
>> -Original Message-
>> From: Andy Tang
>> Sent: 2019年8月29日 16:38
>> To: 'edubez...@gmail.com' ; 'rui.zh...@intel.com'
>>
>> Cc: 'daniel.lezc...@linaro.org' ; Leo Li
>> ; 'linux...@vger.kernel.org'
>> ; 'linux-kernel@vger.kernel.org'
>>
>> Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit version 2
>> support
>>
>> Hi Rui, Edubezval,
>>
>> Almost three monthes passed, I have not got your comments from you.
>> Could you please take a look at this patch?
>>
>> BR,
>> Andy
>>
>>> -Original Message-
>>> From: Andy Tang
>>> Sent: 2019年8月6日 10:57
>>> To: edubez...@gmail.com; rui.zh...@intel.com
>>> Cc: daniel.lezc...@linaro.org; Leo Li ;
>>> linux...@vger.kernel.org; linux-kernel@vger.kernel.org
>>> Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit version
>>> 2 support
>>>
>>> Any comments?
>>>
>>> BR,
>>> Andy
>>>
>>>> -Original Message-
>>>> From: Yuantian Tang
>>>> Sent: 2019年6月4日 10:51
>>>> To: edubez...@gmail.com; rui.zh...@intel.com
>>>> Cc: daniel.lezc...@linaro.org; Leo Li ;
>>>> linux...@vger.kernel.org; linux-kernel@vger.kernel.org; Andy Tang
>>>>
>>>> Subject: [PATCH] thermal: qoriq: add thermal monitor unit version 2
>>>> support
>>>>
>>>> Thermal Monitor Unit v2 is introduced on new Layscape SoC.
>>>> Compared to v1, TMUv2 has a little different register layout and
>>>> digital output is fairly linear.
>>>>
>>>> Signed-off-by: Yuantian Tang
>>>> ---
>>>> drivers/thermal/qoriq_thermal.c | 122
>>>> +---
>>>> 1 file changed, 98 insertions(+), 24 deletions(-)
>>>>
>>>> diff --git a/drivers/thermal/qoriq_thermal.c
>>>> b/drivers/thermal/qoriq_thermal.c index 3b5f5b3fb1bc..0df6dfddf804
>>>> 100644
>>>> --- a/drivers/thermal/qoriq_thermal.c
>>>> +++ b/drivers/thermal/qoriq_thermal.c
>>>> @@ -13,6 +13,15 @@
>>>> #include "thermal_core.h"
>>>>
>>>> #define SITES_MAX 16
>>>> +#define TMR_DISABLE 0x0
>>>> +#define TMR_ME0x8000
>>>> +#define TMR_ALPF 0x0c00
>>>> +#define TMR_ALPF_V2 0x0300
>>>> +#define TMTMIR_DEFAULT0x000f
>>>> +#define TIER_DISABLE 0x0
>>>> +#define TEUMR0_V2 0x51009C00
>>>> +#define TMU_VER1 0x1
>>>> +#define TMU_VER2 0x2
>>>>
>>>> /*
>>>> * QorIQ TMU Registers
>>>> @@ -23,17 +32,55 @@ struct qoriq_tmu_site_regs {
>>>>u8 res0[0x8];
>>>> };
>>>>
>>>> -struct qoriq_tmu_regs {
>>>> +struct qoriq_tmu_regs_v2 {
>>>> + u32 tmr;/* Mode Register */
>>>> + u32 tsr;/* Status Register */
>>>> + u32 tmsr; /* monitor site register */
>>>> + u32 tmtmir; /* Temperature measurement interval Register
>> */
>>>> + u8 res0[0x10];
>>>> + u32 tier; /* Interrupt Enable Register */
>>>> + u32 tidr; /* Interrupt Detect Register */
>>>> + u8 res1[0x8];
>>>> + u32 tiiscr; /* interrupt immediate site capture register */
>>>> + u32 tiascr; /* interrupt average site capture register */
>>>> + u32 ticscr; /* Interrupt Critical Site Capture Register */
>>>> + u32 res2;
>>>> + u32 tmhtcr; /* monitor high temperature capture register */
>>>> + u32 tmltcr; /* monitor low temperature capture register */
>>>> + u32 tmrtrcr;/* monitor rising temperature rate capture register
>> */
>>>> + u32 tmftrcr;/* monitor falling temperature rate capture register
>> */
>>>> + u32 tmhtitr;/* High Temperature Immediate Threshold */
>>>> + u32 tmhtatr;/* High Temperature Average Threshold */
>>>> + u32 tmhtactr; /* High Temperature Average Crit Threshold */
>>>> + u32 res3;
>>>> + u32 tmltitr;/* monito
RE: [PATCH] thermal: qoriq: add thermal monitor unit version 2 support
Hi Rui, Edubezval,
Would you please review this patch?
BR,
Andy
> -Original Message-
> From: Andy Tang
> Sent: 2019年8月29日 16:38
> To: 'edubez...@gmail.com' ; 'rui.zh...@intel.com'
>
> Cc: 'daniel.lezc...@linaro.org' ; Leo Li
> ; 'linux...@vger.kernel.org'
> ; 'linux-kernel@vger.kernel.org'
>
> Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit version 2
> support
>
> Hi Rui, Edubezval,
>
> Almost three monthes passed, I have not got your comments from you.
> Could you please take a look at this patch?
>
> BR,
> Andy
>
> > -Original Message-
> > From: Andy Tang
> > Sent: 2019年8月6日 10:57
> > To: edubez...@gmail.com; rui.zh...@intel.com
> > Cc: daniel.lezc...@linaro.org; Leo Li ;
> > linux...@vger.kernel.org; linux-kernel@vger.kernel.org
> > Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit version
> > 2 support
> >
> > Any comments?
> >
> > BR,
> > Andy
> >
> > > -Original Message-
> > > From: Yuantian Tang
> > > Sent: 2019年6月4日 10:51
> > > To: edubez...@gmail.com; rui.zh...@intel.com
> > > Cc: daniel.lezc...@linaro.org; Leo Li ;
> > > linux...@vger.kernel.org; linux-kernel@vger.kernel.org; Andy Tang
> > >
> > > Subject: [PATCH] thermal: qoriq: add thermal monitor unit version 2
> > > support
> > >
> > > Thermal Monitor Unit v2 is introduced on new Layscape SoC.
> > > Compared to v1, TMUv2 has a little different register layout and
> > > digital output is fairly linear.
> > >
> > > Signed-off-by: Yuantian Tang
> > > ---
> > > drivers/thermal/qoriq_thermal.c | 122
> > > +---
> > > 1 file changed, 98 insertions(+), 24 deletions(-)
> > >
> > > diff --git a/drivers/thermal/qoriq_thermal.c
> > > b/drivers/thermal/qoriq_thermal.c index 3b5f5b3fb1bc..0df6dfddf804
> > > 100644
> > > --- a/drivers/thermal/qoriq_thermal.c
> > > +++ b/drivers/thermal/qoriq_thermal.c
> > > @@ -13,6 +13,15 @@
> > > #include "thermal_core.h"
> > >
> > > #define SITES_MAX16
> > > +#define TMR_DISABLE 0x0
> > > +#define TMR_ME 0x8000
> > > +#define TMR_ALPF 0x0c00
> > > +#define TMR_ALPF_V2 0x0300
> > > +#define TMTMIR_DEFAULT 0x000f
> > > +#define TIER_DISABLE 0x0
> > > +#define TEUMR0_V20x51009C00
> > > +#define TMU_VER1 0x1
> > > +#define TMU_VER2 0x2
> > >
> > > /*
> > > * QorIQ TMU Registers
> > > @@ -23,17 +32,55 @@ struct qoriq_tmu_site_regs {
> > > u8 res0[0x8];
> > > };
> > >
> > > -struct qoriq_tmu_regs {
> > > +struct qoriq_tmu_regs_v2 {
> > > + u32 tmr;/* Mode Register */
> > > + u32 tsr;/* Status Register */
> > > + u32 tmsr; /* monitor site register */
> > > + u32 tmtmir; /* Temperature measurement interval Register
> */
> > > + u8 res0[0x10];
> > > + u32 tier; /* Interrupt Enable Register */
> > > + u32 tidr; /* Interrupt Detect Register */
> > > + u8 res1[0x8];
> > > + u32 tiiscr; /* interrupt immediate site capture register */
> > > + u32 tiascr; /* interrupt average site capture register */
> > > + u32 ticscr; /* Interrupt Critical Site Capture Register */
> > > + u32 res2;
> > > + u32 tmhtcr; /* monitor high temperature capture register */
> > > + u32 tmltcr; /* monitor low temperature capture register */
> > > + u32 tmrtrcr;/* monitor rising temperature rate capture register
> */
> > > + u32 tmftrcr;/* monitor falling temperature rate capture register
> */
> > > + u32 tmhtitr;/* High Temperature Immediate Threshold */
> > > + u32 tmhtatr;/* High Temperature Average Threshold */
> > > + u32 tmhtactr; /* High Temperature Average Crit Threshold */
> > > + u32 res3;
> > > + u32 tmltitr;/* monitor low temperature immediate threshold */
> > > + u32 tmltatr;/* monitor low temperature average threshold
> register */
> > > + u32 tmltactr; /* monitor low temperature average critical
> threshold */
> > > + u32 res4;
> > > + u32 tmrtrctr; /* monitor rising temperature rate critical threshold
> */
> > > + u32 tmftrctr; /* monitor falling temperature rate critical
> threshold*/
>
RE: [PATCH] thermal: qoriq: add thermal monitor unit version 2 support
Hi Rui, Edubezval,
Almost three monthes passed, I have not got your comments from you.
Could you please take a look at this patch?
BR,
Andy
> -Original Message-
> From: Andy Tang
> Sent: 2019年8月6日 10:57
> To: edubez...@gmail.com; rui.zh...@intel.com
> Cc: daniel.lezc...@linaro.org; Leo Li ;
> linux...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: RE: [PATCH] thermal: qoriq: add thermal monitor unit version 2
> support
>
> Any comments?
>
> BR,
> Andy
>
> > -Original Message-
> > From: Yuantian Tang
> > Sent: 2019年6月4日 10:51
> > To: edubez...@gmail.com; rui.zh...@intel.com
> > Cc: daniel.lezc...@linaro.org; Leo Li ;
> > linux...@vger.kernel.org; linux-kernel@vger.kernel.org; Andy Tang
> >
> > Subject: [PATCH] thermal: qoriq: add thermal monitor unit version 2
> > support
> >
> > Thermal Monitor Unit v2 is introduced on new Layscape SoC.
> > Compared to v1, TMUv2 has a little different register layout and
> > digital output is fairly linear.
> >
> > Signed-off-by: Yuantian Tang
> > ---
> > drivers/thermal/qoriq_thermal.c | 122
> > +---
> > 1 file changed, 98 insertions(+), 24 deletions(-)
> >
> > diff --git a/drivers/thermal/qoriq_thermal.c
> > b/drivers/thermal/qoriq_thermal.c index 3b5f5b3fb1bc..0df6dfddf804
> > 100644
> > --- a/drivers/thermal/qoriq_thermal.c
> > +++ b/drivers/thermal/qoriq_thermal.c
> > @@ -13,6 +13,15 @@
> > #include "thermal_core.h"
> >
> > #define SITES_MAX 16
> > +#define TMR_DISABLE0x0
> > +#define TMR_ME 0x8000
> > +#define TMR_ALPF 0x0c00
> > +#define TMR_ALPF_V20x0300
> > +#define TMTMIR_DEFAULT 0x000f
> > +#define TIER_DISABLE 0x0
> > +#define TEUMR0_V2 0x51009C00
> > +#define TMU_VER1 0x1
> > +#define TMU_VER2 0x2
> >
> > /*
> > * QorIQ TMU Registers
> > @@ -23,17 +32,55 @@ struct qoriq_tmu_site_regs {
> > u8 res0[0x8];
> > };
> >
> > -struct qoriq_tmu_regs {
> > +struct qoriq_tmu_regs_v2 {
> > + u32 tmr;/* Mode Register */
> > + u32 tsr;/* Status Register */
> > + u32 tmsr; /* monitor site register */
> > + u32 tmtmir; /* Temperature measurement interval Register */
> > + u8 res0[0x10];
> > + u32 tier; /* Interrupt Enable Register */
> > + u32 tidr; /* Interrupt Detect Register */
> > + u8 res1[0x8];
> > + u32 tiiscr; /* interrupt immediate site capture register */
> > + u32 tiascr; /* interrupt average site capture register */
> > + u32 ticscr; /* Interrupt Critical Site Capture Register */
> > + u32 res2;
> > + u32 tmhtcr; /* monitor high temperature capture register */
> > + u32 tmltcr; /* monitor low temperature capture register */
> > + u32 tmrtrcr;/* monitor rising temperature rate capture register */
> > + u32 tmftrcr;/* monitor falling temperature rate capture register */
> > + u32 tmhtitr;/* High Temperature Immediate Threshold */
> > + u32 tmhtatr;/* High Temperature Average Threshold */
> > + u32 tmhtactr; /* High Temperature Average Crit Threshold */
> > + u32 res3;
> > + u32 tmltitr;/* monitor low temperature immediate threshold */
> > + u32 tmltatr;/* monitor low temperature average threshold register */
> > + u32 tmltactr; /* monitor low temperature average critical threshold */
> > + u32 res4;
> > + u32 tmrtrctr; /* monitor rising temperature rate critical threshold */
> > + u32 tmftrctr; /* monitor falling temperature rate critical threshold*/
> > + u8 res5[0x8];
> > + u32 ttcfgr; /* Temperature Configuration Register */
> > + u32 tscfgr; /* Sensor Configuration Register */
> > + u8 res6[0x78];
> > + struct qoriq_tmu_site_regs site[SITES_MAX];
> > + u8 res7[0x9f8];
> > + u32 ipbrr0; /* IP Block Revision Register 0 */
> > + u32 ipbrr1; /* IP Block Revision Register 1 */
> > + u8 res8[0x300];
> > + u32 teumr0;
> > + u32 teumr1;
> > + u32 teumr2;
> > + u32 res9;
> > + u32 ttrcr[4]; /* Temperature Range Control Register */
> > +};
> > +
> > +struct qoriq_tmu_regs_v1 {
> > u32 tmr;/* Mode Register */
> > -#define TMR_DISABLE0x0
> > -#define TMR_ME 0x8000
> > -#define TMR_ALPF 0x0c00
> &
RE: [PATCH] thermal: qoriq: add thermal monitor unit version 2 support
Any comments?
BR,
Andy
> -Original Message-
> From: Yuantian Tang
> Sent: 2019年6月4日 10:51
> To: edubez...@gmail.com; rui.zh...@intel.com
> Cc: daniel.lezc...@linaro.org; Leo Li ;
> linux...@vger.kernel.org; linux-kernel@vger.kernel.org; Andy Tang
>
> Subject: [PATCH] thermal: qoriq: add thermal monitor unit version 2 support
>
> Thermal Monitor Unit v2 is introduced on new Layscape SoC.
> Compared to v1, TMUv2 has a little different register layout and digital
> output is fairly linear.
>
> Signed-off-by: Yuantian Tang
> ---
> drivers/thermal/qoriq_thermal.c | 122 +---
> 1 file changed, 98 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/thermal/qoriq_thermal.c
> b/drivers/thermal/qoriq_thermal.c index 3b5f5b3fb1bc..0df6dfddf804 100644
> --- a/drivers/thermal/qoriq_thermal.c
> +++ b/drivers/thermal/qoriq_thermal.c
> @@ -13,6 +13,15 @@
> #include "thermal_core.h"
>
> #define SITES_MAX16
> +#define TMR_DISABLE 0x0
> +#define TMR_ME 0x8000
> +#define TMR_ALPF 0x0c00
> +#define TMR_ALPF_V2 0x0300
> +#define TMTMIR_DEFAULT 0x000f
> +#define TIER_DISABLE 0x0
> +#define TEUMR0_V20x51009C00
> +#define TMU_VER1 0x1
> +#define TMU_VER2 0x2
>
> /*
> * QorIQ TMU Registers
> @@ -23,17 +32,55 @@ struct qoriq_tmu_site_regs {
> u8 res0[0x8];
> };
>
> -struct qoriq_tmu_regs {
> +struct qoriq_tmu_regs_v2 {
> + u32 tmr;/* Mode Register */
> + u32 tsr;/* Status Register */
> + u32 tmsr; /* monitor site register */
> + u32 tmtmir; /* Temperature measurement interval Register */
> + u8 res0[0x10];
> + u32 tier; /* Interrupt Enable Register */
> + u32 tidr; /* Interrupt Detect Register */
> + u8 res1[0x8];
> + u32 tiiscr; /* interrupt immediate site capture register */
> + u32 tiascr; /* interrupt average site capture register */
> + u32 ticscr; /* Interrupt Critical Site Capture Register */
> + u32 res2;
> + u32 tmhtcr; /* monitor high temperature capture register */
> + u32 tmltcr; /* monitor low temperature capture register */
> + u32 tmrtrcr;/* monitor rising temperature rate capture register */
> + u32 tmftrcr;/* monitor falling temperature rate capture register */
> + u32 tmhtitr;/* High Temperature Immediate Threshold */
> + u32 tmhtatr;/* High Temperature Average Threshold */
> + u32 tmhtactr; /* High Temperature Average Crit Threshold */
> + u32 res3;
> + u32 tmltitr;/* monitor low temperature immediate threshold */
> + u32 tmltatr;/* monitor low temperature average threshold register */
> + u32 tmltactr; /* monitor low temperature average critical threshold */
> + u32 res4;
> + u32 tmrtrctr; /* monitor rising temperature rate critical threshold */
> + u32 tmftrctr; /* monitor falling temperature rate critical threshold*/
> + u8 res5[0x8];
> + u32 ttcfgr; /* Temperature Configuration Register */
> + u32 tscfgr; /* Sensor Configuration Register */
> + u8 res6[0x78];
> + struct qoriq_tmu_site_regs site[SITES_MAX];
> + u8 res7[0x9f8];
> + u32 ipbrr0; /* IP Block Revision Register 0 */
> + u32 ipbrr1; /* IP Block Revision Register 1 */
> + u8 res8[0x300];
> + u32 teumr0;
> + u32 teumr1;
> + u32 teumr2;
> + u32 res9;
> + u32 ttrcr[4]; /* Temperature Range Control Register */
> +};
> +
> +struct qoriq_tmu_regs_v1 {
> u32 tmr;/* Mode Register */
> -#define TMR_DISABLE 0x0
> -#define TMR_ME 0x8000
> -#define TMR_ALPF 0x0c00
> u32 tsr;/* Status Register */
> u32 tmtmir; /* Temperature measurement interval Register */
> -#define TMTMIR_DEFAULT 0x000f
> u8 res0[0x14];
> u32 tier; /* Interrupt Enable Register */
> -#define TIER_DISABLE 0x0
> u32 tidr; /* Interrupt Detect Register */
> u32 tiscr; /* Interrupt Site Capture Register */
> u32 ticscr; /* Interrupt Critical Site Capture Register */
> @@ -53,10 +100,7 @@ struct qoriq_tmu_regs {
> u32 ipbrr0; /* IP Block Revision Register 0 */
> u32 ipbrr1; /* IP Block Revision Register 1 */
> u8 res6[0x310];
> - u32 ttr0cr; /* Temperature Range 0 Control Register */
> - u32 ttr1cr; /* Temperature Range 1 Control Register */
> - u32 ttr2cr; /* Temperature Range 2 Control Register */
> - u32 ttr3cr; /* Temperature Range 3 Control Register */
> + u32 ttrcr[4]; /* Temperature Range Control Register */
> };
>
> struct qoriq_tmu_data;
> @@ -71,7 +115,9 @@ struct qoriq_sensor { };
>
> struct
