Re: [PATCH V12 1/5] dt-bindings: fsl: scu: add thermal binding
On Tue, 16 Apr 2019 03:22:09 +, Anson Huang wrote: > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > system controller, the system controller is in charge of system > power, clock and thermal sensors etc. management, Linux kernel > has to communicate with system controller via MU (message unit) > IPC to get temperature from thermal sensors, this patch adds > binding doc for i.MX system controller thermal driver. > > Signed-off-by: Anson Huang > --- > No changes. > --- > .../devicetree/bindings/arm/freescale/fsl,scu.txt| 16 > > 1 file changed, 16 insertions(+) > Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply. If a tag was not added on purpose, please state why and what changed.
RE: [PATCH V12 1/5] dt-bindings: fsl: scu: add thermal binding
Best Regards! Anson Huang > -Original Message- > From: Aisheng Dong > Sent: Wednesday, April 17, 2019 11:32 AM > To: Anson Huang ; robh...@kernel.org; > mark.rutl...@arm.com; shawn...@kernel.org; s.ha...@pengutronix.de; > ker...@pengutronix.de; feste...@gmail.com; catalin.mari...@arm.com; > will.dea...@arm.com; rui.zh...@intel.com; edubez...@gmail.com; > daniel.lezc...@linaro.org; ulf.hans...@linaro.org; Daniel Baluta > ; Peng Fan ; > he...@sntech.de; horms+rene...@verge.net.au; agr...@kernel.org; > o...@lixom.net; bjorn.anders...@linaro.org; ja...@amarulasolutions.com; > enric.balle...@collabora.com; marc.w.gonza...@free.fr; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; linux...@vger.kernel.org > Cc: dl-linux-imx > Subject: RE: [PATCH V12 1/5] dt-bindings: fsl: scu: add thermal binding > > > From: Anson Huang > > Sent: Tuesday, April 16, 2019 11:22 AM > > > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > > controller, the system controller is in charge of system power, clock > > and thermal sensors etc. management, Linux kernel has to communicate > > with system controller via MU (message unit) IPC to get temperature > > from thermal sensors, this patch adds binding doc for i.MX system > controller thermal driver. > > > > Signed-off-by: Anson Huang > > --- > > No changes. > > --- > > .../devicetree/bindings/arm/freescale/fsl,scu.txt| 16 > > > > 1 file changed, 16 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > index 5d7dbab..f4fb6d5 100644 > > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > > @@ -133,6 +133,17 @@ RTC bindings based on SCU Message Protocol > > Required properties: > > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > > > +Thermal bindings based on SCU Message Protocol > > + > > + > > +Required properties: > > +- compatible: Should be : > > + "fsl,imx8qxp-sc-thermal" > > + followed by "fsl,imx-sc-thermal"; > > + > > +- #thermal-sensor-cells: See > > Documentation/devicetree/bindings/thermal/thermal.txt > > + for a description. > > Better to have an explicit value here. > e.g. > Must be 1. See xxx for a description. OK, will add it in next version. Anson. > > Otherwise: > Reviewed-by: Dong Aisheng > > Regards > Dong Aisheng
RE: [PATCH V12 1/5] dt-bindings: fsl: scu: add thermal binding
> From: Anson Huang > Sent: Tuesday, April 16, 2019 11:22 AM > > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system > controller, the system controller is in charge of system power, clock and > thermal sensors etc. management, Linux kernel has to communicate with > system controller via MU (message unit) IPC to get temperature from thermal > sensors, this patch adds binding doc for i.MX system controller thermal > driver. > > Signed-off-by: Anson Huang > --- > No changes. > --- > .../devicetree/bindings/arm/freescale/fsl,scu.txt| 16 > > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > index 5d7dbab..f4fb6d5 100644 > --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt > @@ -133,6 +133,17 @@ RTC bindings based on SCU Message Protocol > Required properties: > - compatible: should be "fsl,imx8qxp-sc-rtc"; > > +Thermal bindings based on SCU Message Protocol > + > + > +Required properties: > +- compatible:Should be : > + "fsl,imx8qxp-sc-thermal" > + followed by "fsl,imx-sc-thermal"; > + > +- #thermal-sensor-cells: See > Documentation/devicetree/bindings/thermal/thermal.txt > + for a description. Better to have an explicit value here. e.g. Must be 1. See xxx for a description. Otherwise: Reviewed-by: Dong Aisheng Regards Dong Aisheng
