Re: Re(2): fix u32 vs. pm message t in usb
Hi! > > Okay, you obviously have easy access to usb development trees... > > Do you think you could just take this patch as a basis and fix > > remaining u32 vs pm-message-t in usb? --p > > Fixing the "sparse -Wbitwise" messages, and addressing some other > behavior changes/bugs that crept in, was the idea. That's already > done, but _without_ taking this as a basis (or breaking the sysfs > support etc). Okay, if you fixed -Wbitwise, it should be all fixed... > The patches I sent fix everything I had time to test (just a subset > of the dozens of cases previously tested, probably covering the main > stuff that got broken) except the non-PCI platform_bus drivers where > pm_message_t has discarded essential functionality. (Notably, info > about whether device clocks and/or power must be turned off.) At what places is essential functionality lost? I thought that u32 state is pretty much always 3 ;-). Is there platform where it is not the case? Could you push also trivial bits that you could not test? I'd like to get rid of all "u32 state"s... > p.s. PCI-express patches don't belong with USB patches. :) Oops, sorry. Same maintainer, though ;-). Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Re(2): fix u32 vs. pm message t in usb
On Sunday 03 April 2005 12:31 pm, [EMAIL PROTECTED] wrote: > Okay, you obviously have easy access to usb development trees... > Do you think you could just take this patch as a basis and fix > remaining u32 vs pm-message-t in usb? --p Fixing the "sparse -Wbitwise" messages, and addressing some other behavior changes/bugs that crept in, was the idea. That's already done, but _without_ taking this as a basis (or breaking the sysfs support etc). The patches I sent fix everything I had time to test (just a subset of the dozens of cases previously tested, probably covering the main stuff that got broken) except the non-PCI platform_bus drivers where pm_message_t has discarded essential functionality. (Notably, info about whether device clocks and/or power must be turned off.) Fixing those will be more work than seems reasonable for 2.6.12 kernels. Among other things, there's still a lot of stuff that needs to percolate out to arch trees; designing and testing such fixes takes time, as does percolating it back. - Dave p.s. PCI-express patches don't belong with USB patches. :) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Re(2): fix u32 vs. pm message t in usb
On Sunday 03 April 2005 12:31 pm, [EMAIL PROTECTED] wrote: Okay, you obviously have easy access to usb development trees... Do you think you could just take this patch as a basis and fix remaining u32 vs pm-message-t in usb? --p Fixing the sparse -Wbitwise messages, and addressing some other behavior changes/bugs that crept in, was the idea. That's already done, but _without_ taking this as a basis (or breaking the sysfs support etc). The patches I sent fix everything I had time to test (just a subset of the dozens of cases previously tested, probably covering the main stuff that got broken) except the non-PCI platform_bus drivers where pm_message_t has discarded essential functionality. (Notably, info about whether device clocks and/or power must be turned off.) Fixing those will be more work than seems reasonable for 2.6.12 kernels. Among other things, there's still a lot of stuff that needs to percolate out to arch trees; designing and testing such fixes takes time, as does percolating it back. - Dave p.s. PCI-express patches don't belong with USB patches. :) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Re(2): fix u32 vs. pm message t in usb
Hi! Okay, you obviously have easy access to usb development trees... Do you think you could just take this patch as a basis and fix remaining u32 vs pm-message-t in usb? --p Fixing the sparse -Wbitwise messages, and addressing some other behavior changes/bugs that crept in, was the idea. That's already done, but _without_ taking this as a basis (or breaking the sysfs support etc). Okay, if you fixed -Wbitwise, it should be all fixed... The patches I sent fix everything I had time to test (just a subset of the dozens of cases previously tested, probably covering the main stuff that got broken) except the non-PCI platform_bus drivers where pm_message_t has discarded essential functionality. (Notably, info about whether device clocks and/or power must be turned off.) At what places is essential functionality lost? I thought that u32 state is pretty much always 3 ;-). Is there platform where it is not the case? Could you push also trivial bits that you could not test? I'd like to get rid of all u32 states... p.s. PCI-express patches don't belong with USB patches. :) Oops, sorry. Same maintainer, though ;-). Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
