Re: Re: [PATCH] extcon-max8997: remove usage of ret in max8997_muic_handle_charger_type_detach
On Tue, Sep 4, 2012 at 11:17 AM, MyungJoo Ham wrote: >> any comments ? >> > > Sorry for replying late. > > It has been applied to the extcon-for-next tree at > http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next > , which will appear in hours. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Re: [PATCH] extcon-max8997: remove usage of ret in max8997_muic_handle_charger_type_detach
On Tue, Sep 4, 2012 at 11:17 AM, MyungJoo Ham myungjoo@samsung.com wrote: any comments ? Sorry for replying late. It has been applied to the extcon-for-next tree at http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next , which will appear in hours. Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Re: [PATCH] extcon-max8997: remove usage of ret in max8997_muic_handle_charger_type_detach
> any comments ?
>
Sorry for replying late.
It has been applied to the extcon-for-next tree at
http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next
, which will appear in hours.
> On Wed, Aug 15, 2012 at 12:19 PM, Devendra Naga
> wrote:
> > actually we can do returns with error or success with out ret in this
> > function,
> > so remove the ret variable, and reduce a very little (4byte) space on stack
> > of this function
> >
> > Signed-off-by: Devendra Naga
> > ---
> > compile tested.
> >
> > drivers/extcon/extcon-max8997.c | 6 ++
> > 1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/extcon/extcon-max8997.c
> > b/drivers/extcon/extcon-max8997.c
> > index ef9090a..77b66b0 100644
> > --- a/drivers/extcon/extcon-max8997.c
> > +++ b/drivers/extcon/extcon-max8997.c
> > @@ -271,8 +271,6 @@ out:
> > static int max8997_muic_handle_charger_type_detach(
> > struct max8997_muic_info *info)
> > {
> > - int ret = 0;
> > -
> > switch (info->pre_charger_type) {
> > case MAX8997_CHARGER_TYPE_USB:
> > extcon_set_cable_state(info->edev, "USB", false);
> > @@ -290,11 +288,11 @@ static int max8997_muic_handle_charger_type_detach(
> > extcon_set_cable_state(info->edev, "Fast-charger", false);
> > break;
> > default:
> > - ret = -EINVAL;
> > + return -EINVAL;
> > break;
> > }
> >
> > - return ret;
> > + return 0;
> > }
> >
> > static int max8997_muic_handle_charger_type(struct max8997_muic_info *info,
> > --
> > 1.7.12.rc2
> >
>
>
>
>
>
>
N떑꿩�r툤y鉉싕b쾊Ф푤v�^�)頻{.n�+돴쪐{콗喩zX㎍썳變}찠꼿쟺�:+v돣�쳭喩zZ+�+zf＂톒쉱�~넮녬i鎬z� 췿ⅱ�?솳鈺�&�)刪f뷌^j푹y쬶끷@A첺뛴
0띠h��뭝
Re: Re: [PATCH] extcon-max8997: remove usage of ret in max8997_muic_handle_charger_type_detach
any comments ?
Sorry for replying late.
It has been applied to the extcon-for-next tree at
http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next
, which will appear in hours.
On Wed, Aug 15, 2012 at 12:19 PM, Devendra Naga
develkernel412...@gmail.com wrote:
actually we can do returns with error or success with out ret in this
function,
so remove the ret variable, and reduce a very little (4byte) space on stack
of this function
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
compile tested.
drivers/extcon/extcon-max8997.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/extcon/extcon-max8997.c
b/drivers/extcon/extcon-max8997.c
index ef9090a..77b66b0 100644
--- a/drivers/extcon/extcon-max8997.c
+++ b/drivers/extcon/extcon-max8997.c
@@ -271,8 +271,6 @@ out:
static int max8997_muic_handle_charger_type_detach(
struct max8997_muic_info *info)
{
- int ret = 0;
-
switch (info-pre_charger_type) {
case MAX8997_CHARGER_TYPE_USB:
extcon_set_cable_state(info-edev, USB, false);
@@ -290,11 +288,11 @@ static int max8997_muic_handle_charger_type_detach(
extcon_set_cable_state(info-edev, Fast-charger, false);
break;
default:
- ret = -EINVAL;
+ return -EINVAL;
break;
}
- return ret;
+ return 0;
}
static int max8997_muic_handle_charger_type(struct max8997_muic_info *info,
--
1.7.12.rc2
N떑꿩�r툤y鉉싕b쾊Ф푤v�^�)頻{.n�+돴쪐{콗喩zX㎍썳變}찠꼿쟺�j:+v돣�쳭喩zZ+�+zf＂톒쉱�~넮녬i鎬z� 췿ⅱ�?솳鈺��)刪f뷌^j푹y쬶끷@A첺뛴
0띠h��뭝
Re: [PATCH] extcon-max8997: remove usage of ret in max8997_muic_handle_charger_type_detach
any comments ?
On Wed, Aug 15, 2012 at 12:19 PM, Devendra Naga
wrote:
> actually we can do returns with error or success with out ret in this
> function,
> so remove the ret variable, and reduce a very little (4byte) space on stack
> of this function
>
> Signed-off-by: Devendra Naga
> ---
> compile tested.
>
> drivers/extcon/extcon-max8997.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index ef9090a..77b66b0 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -271,8 +271,6 @@ out:
> static int max8997_muic_handle_charger_type_detach(
> struct max8997_muic_info *info)
> {
> - int ret = 0;
> -
> switch (info->pre_charger_type) {
> case MAX8997_CHARGER_TYPE_USB:
> extcon_set_cable_state(info->edev, "USB", false);
> @@ -290,11 +288,11 @@ static int max8997_muic_handle_charger_type_detach(
> extcon_set_cable_state(info->edev, "Fast-charger", false);
> break;
> default:
> - ret = -EINVAL;
> + return -EINVAL;
> break;
> }
>
> - return ret;
> + return 0;
> }
>
> static int max8997_muic_handle_charger_type(struct max8997_muic_info *info,
> --
> 1.7.12.rc2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] extcon-max8997: remove usage of ret in max8997_muic_handle_charger_type_detach
any comments ?
On Wed, Aug 15, 2012 at 12:19 PM, Devendra Naga
develkernel412...@gmail.com wrote:
actually we can do returns with error or success with out ret in this
function,
so remove the ret variable, and reduce a very little (4byte) space on stack
of this function
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
compile tested.
drivers/extcon/extcon-max8997.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index ef9090a..77b66b0 100644
--- a/drivers/extcon/extcon-max8997.c
+++ b/drivers/extcon/extcon-max8997.c
@@ -271,8 +271,6 @@ out:
static int max8997_muic_handle_charger_type_detach(
struct max8997_muic_info *info)
{
- int ret = 0;
-
switch (info-pre_charger_type) {
case MAX8997_CHARGER_TYPE_USB:
extcon_set_cable_state(info-edev, USB, false);
@@ -290,11 +288,11 @@ static int max8997_muic_handle_charger_type_detach(
extcon_set_cable_state(info-edev, Fast-charger, false);
break;
default:
- ret = -EINVAL;
+ return -EINVAL;
break;
}
- return ret;
+ return 0;
}
static int max8997_muic_handle_charger_type(struct max8997_muic_info *info,
--
1.7.12.rc2
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
