Re: [PATCH] x86: Unify printk strings in fault_32|64.c
On Sat, 2008-01-19 at 09:13 +0100, Ingo Molnar wrote: > * Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > #ifdef CONFIG_X86_32 > > - "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error > > %lx\n", > > + "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx", > > #else > > > #ifdef CONFIG_X86_32 > > - "%s%s[%d]: segfault at %08lx ip %08lx sp %08lx error > > %lx\n", > > + "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx", > > #else > > thanks, applied. > > Ingo I'm just looking at some of the other printks in do+page_fault right now in the oops code. What do you prefer: "Unable to handle kernel NULL pointer dereference" or "BUG: unable to handle kernel NULL pointer dereference" Other than that, I think for the most part, the shorter X86_64 strings are better. This does change user-visible output however, but would be nice to have a similar format. Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] x86: Unify printk strings in fault_32|64.c
* Harvey Harrison <[EMAIL PROTECTED]> wrote: > #ifdef CONFIG_X86_32 > - "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error > %lx\n", > + "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx", > #else > #ifdef CONFIG_X86_32 > - "%s%s[%d]: segfault at %08lx ip %08lx sp %08lx error > %lx\n", > + "%s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx", > #else thanks, applied. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] x86: Unify printk strings in fault_32|64.c
* Harvey Harrison [EMAIL PROTECTED] wrote: #ifdef CONFIG_X86_32 - %s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx\n, + %s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx, #else #ifdef CONFIG_X86_32 - %s%s[%d]: segfault at %08lx ip %08lx sp %08lx error %lx\n, + %s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx, #else thanks, applied. Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] x86: Unify printk strings in fault_32|64.c
On Sat, 2008-01-19 at 09:13 +0100, Ingo Molnar wrote: * Harvey Harrison [EMAIL PROTECTED] wrote: #ifdef CONFIG_X86_32 - %s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx\n, + %s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx, #else #ifdef CONFIG_X86_32 - %s%s[%d]: segfault at %08lx ip %08lx sp %08lx error %lx\n, + %s%s[%d]: segfault at %lx ip %08lx sp %08lx error %lx, #else thanks, applied. Ingo I'm just looking at some of the other printks in do+page_fault right now in the oops code. What do you prefer: Unable to handle kernel NULL pointer dereference or BUG: unable to handle kernel NULL pointer dereference Other than that, I think for the most part, the shorter X86_64 strings are better. This does change user-visible output however, but would be nice to have a similar format. Harvey -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] x86: Unify printk strings in fault_32|64.c
On Sat, 2008-01-19 at 06:08 +0100, Andi Kleen wrote: > On Saturday 19 January 2008 05:22:29 Harvey Harrison wrote: > > Adding the address of the faulting library missed removing a > > line ending from X86_32. > > > > Also update the shorter printk format for X86_32 in fault_64.c > > to make it easier to se the remaining differences. > > Thanks. I think it was correct initially, but one of the merge steps > with the changing git-x86 caused some hunks to be dropped and the patch > never quite recovered from that. No worries, hoping to get them unified this weekend, should make this easier going forward. Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] x86: Unify printk strings in fault_32|64.c
On Saturday 19 January 2008 05:22:29 Harvey Harrison wrote: > Adding the address of the faulting library missed removing a > line ending from X86_32. > > Also update the shorter printk format for X86_32 in fault_64.c > to make it easier to se the remaining differences. Thanks. I think it was correct initially, but one of the merge steps with the changing git-x86 caused some hunks to be dropped and the patch never quite recovered from that. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] x86: Unify printk strings in fault_32|64.c
On Saturday 19 January 2008 05:22:29 Harvey Harrison wrote: Adding the address of the faulting library missed removing a line ending from X86_32. Also update the shorter printk format for X86_32 in fault_64.c to make it easier to se the remaining differences. Thanks. I think it was correct initially, but one of the merge steps with the changing git-x86 caused some hunks to be dropped and the patch never quite recovered from that. -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] x86: Unify printk strings in fault_32|64.c
On Sat, 2008-01-19 at 06:08 +0100, Andi Kleen wrote: On Saturday 19 January 2008 05:22:29 Harvey Harrison wrote: Adding the address of the faulting library missed removing a line ending from X86_32. Also update the shorter printk format for X86_32 in fault_64.c to make it easier to se the remaining differences. Thanks. I think it was correct initially, but one of the merge steps with the changing git-x86 caused some hunks to be dropped and the patch never quite recovered from that. No worries, hoping to get them unified this weekend, should make this easier going forward. Harvey -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
