Re: [PATCH 00/33] ARM: at91: Switch remaining SoCs and boards to CCF
On Tuesday 01 July 2014 19:56:01 Alexandre Belloni wrote: > On 01/07/2014 at 19:01:12 +0200, Arnd Bergmann wrote : > > On Tuesday 01 July 2014 18:48:51 Alexandre Belloni wrote: > > > On 01/07/2014 at 18:35:50 +0200, Arnd Bergmann wrote : > > > > If I read this right, disabling 'USE_OF' results in still using > > > > the old clock interface. Is that intentional? If you want to always > > > > use COMMON_CLK now, the above can probably be simplified to > > > > > > > > config AT91_PMC_UNIT > > > > def_bool !ARCH_AT91X40 > > > > select COMMON_CLK > > > > > > > > and all references to AT91_USE_OLD_CLK, COMMON_CLK_AT91 and > > > > OLD_CLK_AT91 be removed. > > > > > > Yeah, this is intentional we still have 30 or so boards that we have to > > > migrate to DT. Until then, we want to be able to boot a kernel without > > > CCF. The next step in the migration is to switch those boards to DT, > > > possibly using an hybrid DT/pdata approach until we can get rid of the > > > board files. Then, we will be able to get rid of the old clk > > > implementation (and a few other drivers still living in mach-at91). > > > > Ok, I see. Do you expect those 30 boards to work if COMMON_CLK_AT91 > > is enabled, or are there known problems with that? > > > > If you have reason to believe it doesn't work, maybe you can expose > > the selection of the clock interface to users, e.g. like > > > > We actually do the opposite, when a board without DT support is > selected, the old clock support is also selected even when also > selecting CONFIG_OF. Ok, got it now. Yes, that makes sense. I guess we can start doing the actual multiplatform enablement now, which would be only for the DT-enabled boards -- all of Kconfig.non_dt still has to depend on !ARCH_MULTIPLATFORM but we can make at91 either be built standalone (with board files) or multiplatform and still support all SAM9 and RM9200 SoCs but without board files. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/33] ARM: at91: Switch remaining SoCs and boards to CCF
On 01/07/2014 at 19:01:12 +0200, Arnd Bergmann wrote : > On Tuesday 01 July 2014 18:48:51 Alexandre Belloni wrote: > > On 01/07/2014 at 18:35:50 +0200, Arnd Bergmann wrote : > > > If I read this right, disabling 'USE_OF' results in still using > > > the old clock interface. Is that intentional? If you want to always > > > use COMMON_CLK now, the above can probably be simplified to > > > > > > config AT91_PMC_UNIT > > > def_bool !ARCH_AT91X40 > > > select COMMON_CLK > > > > > > and all references to AT91_USE_OLD_CLK, COMMON_CLK_AT91 and > > > OLD_CLK_AT91 be removed. > > > > Yeah, this is intentional we still have 30 or so boards that we have to > > migrate to DT. Until then, we want to be able to boot a kernel without > > CCF. The next step in the migration is to switch those boards to DT, > > possibly using an hybrid DT/pdata approach until we can get rid of the > > board files. Then, we will be able to get rid of the old clk > > implementation (and a few other drivers still living in mach-at91). > > Ok, I see. Do you expect those 30 boards to work if COMMON_CLK_AT91 > is enabled, or are there known problems with that? > > If you have reason to believe it doesn't work, maybe you can expose > the selection of the clock interface to users, e.g. like > We actually do the opposite, when a board without DT support is selected, the old clock support is also selected even when also selecting CONFIG_OF. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/33] ARM: at91: Switch remaining SoCs and boards to CCF
On Tuesday 01 July 2014 18:48:51 Alexandre Belloni wrote: > On 01/07/2014 at 18:35:50 +0200, Arnd Bergmann wrote : > > If I read this right, disabling 'USE_OF' results in still using > > the old clock interface. Is that intentional? If you want to always > > use COMMON_CLK now, the above can probably be simplified to > > > > config AT91_PMC_UNIT > > def_bool !ARCH_AT91X40 > > select COMMON_CLK > > > > and all references to AT91_USE_OLD_CLK, COMMON_CLK_AT91 and > > OLD_CLK_AT91 be removed. > > Yeah, this is intentional we still have 30 or so boards that we have to > migrate to DT. Until then, we want to be able to boot a kernel without > CCF. The next step in the migration is to switch those boards to DT, > possibly using an hybrid DT/pdata approach until we can get rid of the > board files. Then, we will be able to get rid of the old clk > implementation (and a few other drivers still living in mach-at91). Ok, I see. Do you expect those 30 boards to work if COMMON_CLK_AT91 is enabled, or are there known problems with that? If you have reason to believe it doesn't work, maybe you can expose the selection of the clock interface to users, e.g. like config COMMON_CLK_AT91 bool "Use common clock infrastructure" depends on AT91_PMC_UNIT default USE_OF select COMMON_CLK help The at91 platform is migrating to use the common clk infrastructure for all boards, but this has not been tested on some of the older machines that do not use DT yet. If you encounter problems on legacy boards, try disabling this option and report the problem to linux-arm-ker...@lists.infradead.org. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/33] ARM: at91: Switch remaining SoCs and boards to CCF
Hi, On 01/07/2014 at 18:35:50 +0200, Arnd Bergmann wrote : > On Tuesday 01 July 2014 16:12:09 Alexandre Belloni wrote: > Looks good overall, but I think this Kconfig snippet should be cleaned > up a little now: > > config AT91_USE_OLD_CLK > bool > > config AT91_PMC_UNIT > bool > default !ARCH_AT91X40 > > config COMMON_CLK_AT91 > bool > default AT91_PMC_UNIT && USE_OF && !AT91_USE_OLD_CLK > select COMMON_CLK > > config OLD_CLK_AT91 > bool > default AT91_PMC_UNIT && AT91_USE_OLD_CLK > > > If I read this right, disabling 'USE_OF' results in still using > the old clock interface. Is that intentional? If you want to always > use COMMON_CLK now, the above can probably be simplified to > > config AT91_PMC_UNIT > def_bool !ARCH_AT91X40 > select COMMON_CLK > > and all references to AT91_USE_OLD_CLK, COMMON_CLK_AT91 and > OLD_CLK_AT91 be removed. Yeah, this is intentional we still have 30 or so boards that we have to migrate to DT. Until then, we want to be able to boot a kernel without CCF. The next step in the migration is to switch those boards to DT, possibly using an hybrid DT/pdata approach until we can get rid of the board files. Then, we will be able to get rid of the old clk implementation (and a few other drivers still living in mach-at91). -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/33] ARM: at91: Switch remaining SoCs and boards to CCF
On Tuesday 01 July 2014 16:12:09 Alexandre Belloni wrote: > This patch set adds support for the common clock framwork to the remaining > atml > SoCs: at91rm9200, at91sam9260, at91sam9263, at91sam9g45. > > It also defines the necessary main crystal and slow crystal frequencies. > > I couldn't find datasheets for the following boards: > - mpa1600 > - ge863-pro3 > - animeo_ip > - tny_a9260 > > For those, I assumed the 32kHz crystal is present on the board as this is the > most common implementation (only one board doesn't have it). Please correct me > if this is wrong. > > I could not test at91rm9200 as I don't own any board with that chip. Looks good overall, but I think this Kconfig snippet should be cleaned up a little now: config AT91_USE_OLD_CLK bool config AT91_PMC_UNIT bool default !ARCH_AT91X40 config COMMON_CLK_AT91 bool default AT91_PMC_UNIT && USE_OF && !AT91_USE_OLD_CLK select COMMON_CLK config OLD_CLK_AT91 bool default AT91_PMC_UNIT && AT91_USE_OLD_CLK If I read this right, disabling 'USE_OF' results in still using the old clock interface. Is that intentional? If you want to always use COMMON_CLK now, the above can probably be simplified to config AT91_PMC_UNIT def_bool !ARCH_AT91X40 select COMMON_CLK and all references to AT91_USE_OLD_CLK, COMMON_CLK_AT91 and OLD_CLK_AT91 be removed. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
