Re: [PATCH 1/2] pinctrl: add sleep mode management for hogs
On 12/12/2012 08:31 PM, Linus Walleij wrote: On Tue, Dec 11, 2012 at 10:11 PM, Stephen Warren wrote: Since I assume those function are only supposed to be used by pinctrl drivers themselves, should the prototypes go into drivers/pinctrl/core.h or similar, rather than something in include/linux/pinctrl? Good point, Julien can you fix this? Sure, I will. Hm, maybe pinctrl_force_sleep()/default() isn't such a good name, maybe it should be pinctrl_hogs_sleep()/pinctrl_hogs_default() intead? Oh, and don't you need EXPORT_SYMBOL in case the pinctrl driver is a module? True. I will do it too. Aside from that, Reviewed-by: Stephen Warren Thanks. Yours, Linus Walleij Thanks a lot. Regards, Julien -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] pinctrl: add sleep mode management for hogs
On Tue, Dec 11, 2012 at 10:11 PM, Stephen Warren wrote: > Since I assume those function are only supposed to be used by pinctrl > drivers themselves, should the prototypes go into drivers/pinctrl/core.h > or similar, rather than something in include/linux/pinctrl? Good point, Julien can you fix this? Hm, maybe pinctrl_force_sleep()/default() isn't such a good name, maybe it should be pinctrl_hogs_sleep()/pinctrl_hogs_default() intead? > Oh, and don't you need EXPORT_SYMBOL in case the pinctrl driver is a module? True. > Aside from that, > > Reviewed-by: Stephen Warren Thanks. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] pinctrl: add sleep mode management for hogs
On 12/11/2012 06:59 AM, Linus Walleij wrote: > From: Julien Delacou > > This fix allows handling sleep mode for hogged > pins in pinctrl. It provides functions to set pins > to sleep/default configurations according to their > current state from the individual pinctrl drivers. > diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h > +extern int pinctrl_force_sleep(struct pinctrl_dev *pctldev); > +extern int pinctrl_force_default(struct pinctrl_dev *pctldev); Since I assume those function are only supposed to be used by pinctrl drivers themselves, should the prototypes go into drivers/pinctrl/core.h or similar, rather than something in include/linux/pinctrl? Oh, and don't you need EXPORT_SYMBOL in case the pinctrl driver is a module? Aside from that, Reviewed-by: Stephen Warren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
