Re: [PATCH v2] sc16is7xx: spi interface is added
On Thu, 14 May 2015 14:45:47 +0530, ram kiran wrote: > > I know little about kbuild but I'm worried that someone doing oldconfig > > can still get SERIAL_SC16IS7XX selected while saying no to all the > > others. > > > > Other option would be to swap the names between SERIAL_SC16IS7XX and > > SERIAL_SC16IS7XX_SELECT, oldconfig would run smoother. > I think, with the above, there would need a configuration change for sure. > It should be okay, as I2C is default Y. Exactly, but with what you proposed we need a configuration change as well, no? SERIAL_SC16IS7XX_SELECT is new so users would have to know that it's what SERIAL_SC16IS7XX used to be. > Swap names would need Makefile changes, i was just thinking to avoid this. > obj-$(CONFIG_SERIAL_SC16IS7XX) += sc16is7xx.o > would be > obj-$(CONFIG_SERIAL_SC16IS7XX_SELECT) += sc16is7xx.o > > I think its some that need not be there. Do suggest.. Perhaps *_SELECT is not the best name then but we could use something like *_CORE or *_BASE. Changes to the Makefile are not user-visible so no worries. It would be nice if people who run oldconfig by default got the same behaviour as they did so far (i2c if SC16IS7XX was enabled in previous config). I think with names swapped and modification of Makefile we would get exactly that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] sc16is7xx: spi interface is added
On Thu, 14 May 2015 14:45:47 +0530, ram kiran wrote: > > I know little about kbuild but I'm worried that someone doing oldconfig > > can still get SERIAL_SC16IS7XX selected while saying no to all the > > others. > > > > Other option would be to swap the names between SERIAL_SC16IS7XX and > > SERIAL_SC16IS7XX_SELECT, oldconfig would run smoother. > I think, with the above, there would need a configuration change for sure. > It should be okay, as I2C is default Y. Exactly, but with what you proposed we need a configuration change as well, no? SERIAL_SC16IS7XX_SELECT is new so users would have to know that it's what SERIAL_SC16IS7XX used to be. > Swap names would need Makefile changes, i was just thinking to avoid this. > obj-$(CONFIG_SERIAL_SC16IS7XX) += sc16is7xx.o > would be > obj-$(CONFIG_SERIAL_SC16IS7XX_SELECT) += sc16is7xx.o > > I think its some that need not be there. Do suggest.. Perhaps *_SELECT is not the best name then but we could use something like *_CORE or *_BASE. Changes to the Makefile are not user-visible so no worries. It would be nice if people who run oldconfig by default got the same behaviour as they did so far (i2c if SC16IS7XX was enabled in previous config). I think with names swapped and modification of Makefile we would get exactly that. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2] sc16is7xx: spi interface is added
> On Thu, 14 May 2015 13:16:20 +0530, ram kiran wrote: >>> On Wed, 13 May 2015 16:27:58 +0530, ram.i hcltech wrote: spi interface for sc16is7xx is added along with Kconfig flag to enable spi or i2c, thus in a instance we can have either spi or i2c or both, in sync to the hw. Signed-off-by: ram.i hcltech --- Changes in v2: -Added seprate flags for i2c and spi -Added space in the comments lines -Added MODULE_ALIAS for spi interface --- drivers/tty/serial/Kconfig | 27 +++-- drivers/tty/serial/sc16is7xx.c | 69 +- 2 files changed, 92 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index f8120c1..8c505b2 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1181,13 +1181,34 @@ config SERIAL_SCCNXP_CONSOLE >> To avoid error or warning on build, i think this would be the probable >> solution. >> I thinking to go with this, any comments on this please. >> >> config SERIAL_SC16IS7XX >> bool >> >> config SERIAL_SC16IS7XX_SELECT >> tristate "SC16IS7xx serial support" >> select SERIAL_CORE >> depends on I2C || SPI_MASTER >> select REGMAP_I2C if I2C >> select REGMAP_SPI if SPI_MASTER >> help >> This selects support for SC16IS7xx serial ports. >> Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, >> SC16IS760 and SC16IS762. Select supported buses using options below. >> >> config SERIAL_SC16IS7XX_I2C >> bool "SC16IS7xx for I2C interface" >> depends on SERIAL_SC16IS7XX_SELECT >> select SERIAL_SC16IS7XX >> default y >> help >> Enable SC16IS7xx driver on I2C bus. >> >> config SERIAL_SC16IS7XX_SPI >> bool "SC16IS7xx for spi interface" >> depends on SERIAL_SC16IS7XX_SELECT >> select SERIAL_SC16IS7XX >> help >> Enable SC16IS7xx driver on SPI bus. >> > > This looks quite elegant! Should we aslo make SERIAL_SC16IS7XX depend > on SERIAL_SC16IS7XX_I2C || SERIAL_SC16IS7XX_SPI? Would that work? > This would be additional protection, need to check if that is too much to do or would be good to go. > I know little about kbuild but I'm worried that someone doing oldconfig > can still get SERIAL_SC16IS7XX selected while saying no to all the > others. > > Other option would be to swap the names between SERIAL_SC16IS7XX and > SERIAL_SC16IS7XX_SELECT, oldconfig would run smoother. I think, with the above, there would need a configuration change for sure. It should be okay, as I2C is default Y. Swap names would need Makefile changes, i was just thinking to avoid this. obj-$(CONFIG_SERIAL_SC16IS7XX) += sc16is7xx.o would be obj-$(CONFIG_SERIAL_SC16IS7XX_SELECT) += sc16is7xx.o I think its some that need not be there. Do suggest.. Thanks > > Thanks! > -- > To unsubscribe from this list: send the line "unsubscribe linux-serial" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] sc16is7xx: spi interface is added
On Thu, 14 May 2015 13:16:20 +0530, ram kiran wrote: > > On Wed, 13 May 2015 16:27:58 +0530, ram.i hcltech wrote: > >> spi interface for sc16is7xx is added along with Kconfig flag > >> to enable spi or i2c, thus in a instance we can have either > >> spi or i2c or both, in sync to the hw. > >> > >> Signed-off-by: ram.i hcltech > >> --- > >> > >> Changes in v2: > >> -Added seprate flags for i2c and spi > >> -Added space in the comments lines > >> -Added MODULE_ALIAS for spi interface > >> --- > >> drivers/tty/serial/Kconfig | 27 +++-- > >> drivers/tty/serial/sc16is7xx.c | 69 > >> +- > >> 2 files changed, 92 insertions(+), 4 deletions(-) > >> > >> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > >> index f8120c1..8c505b2 100644 > >> --- a/drivers/tty/serial/Kconfig > >> +++ b/drivers/tty/serial/Kconfig > >> @@ -1181,13 +1181,34 @@ config SERIAL_SCCNXP_CONSOLE > >> > To avoid error or warning on build, i think this would be the probable > solution. > I thinking to go with this, any comments on this please. > > config SERIAL_SC16IS7XX > bool > > config SERIAL_SC16IS7XX_SELECT > tristate "SC16IS7xx serial support" > select SERIAL_CORE > depends on I2C || SPI_MASTER > select REGMAP_I2C if I2C > select REGMAP_SPI if SPI_MASTER > help > This selects support for SC16IS7xx serial ports. > Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, > SC16IS760 and SC16IS762. Select supported buses using options below. > > config SERIAL_SC16IS7XX_I2C > bool "SC16IS7xx for I2C interface" > depends on SERIAL_SC16IS7XX_SELECT > select SERIAL_SC16IS7XX > default y > help > Enable SC16IS7xx driver on I2C bus. > > config SERIAL_SC16IS7XX_SPI > bool "SC16IS7xx for spi interface" > depends on SERIAL_SC16IS7XX_SELECT > select SERIAL_SC16IS7XX > help > Enable SC16IS7xx driver on SPI bus. > This looks quite elegant! Should we aslo make SERIAL_SC16IS7XX depend on SERIAL_SC16IS7XX_I2C || SERIAL_SC16IS7XX_SPI? Would that work? I know little about kbuild but I'm worried that someone doing oldconfig can still get SERIAL_SC16IS7XX selected while saying no to all the others. Other option would be to swap the names between SERIAL_SC16IS7XX and SERIAL_SC16IS7XX_SELECT, oldconfig would run smoother. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2] sc16is7xx: spi interface is added
> On Wed, 13 May 2015 16:27:58 +0530, ram.i hcltech wrote: >> spi interface for sc16is7xx is added along with Kconfig flag >> to enable spi or i2c, thus in a instance we can have either >> spi or i2c or both, in sync to the hw. >> >> Signed-off-by: ram.i hcltech >> --- >> >> Changes in v2: >> -Added seprate flags for i2c and spi >> -Added space in the comments lines >> -Added MODULE_ALIAS for spi interface >> --- >> drivers/tty/serial/Kconfig | 27 +++-- >> drivers/tty/serial/sc16is7xx.c | 69 >> +- >> 2 files changed, 92 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig >> index f8120c1..8c505b2 100644 >> --- a/drivers/tty/serial/Kconfig >> +++ b/drivers/tty/serial/Kconfig >> @@ -1181,13 +1181,34 @@ config SERIAL_SCCNXP_CONSOLE >> To avoid error or warning on build, i think this would be the probable solution. I thinking to go with this, any comments on this please. config SERIAL_SC16IS7XX bool config SERIAL_SC16IS7XX_SELECT tristate "SC16IS7xx serial support" select SERIAL_CORE depends on I2C || SPI_MASTER select REGMAP_I2C if I2C select REGMAP_SPI if SPI_MASTER help This selects support for SC16IS7xx serial ports. Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, SC16IS760 and SC16IS762. Select supported buses using options below. config SERIAL_SC16IS7XX_I2C bool "SC16IS7xx for I2C interface" depends on SERIAL_SC16IS7XX_SELECT select SERIAL_SC16IS7XX default y help Enable SC16IS7xx driver on I2C bus. config SERIAL_SC16IS7XX_SPI bool "SC16IS7xx for spi interface" depends on SERIAL_SC16IS7XX_SELECT select SERIAL_SC16IS7XX help Enable SC16IS7xx driver on SPI bus. >> config SERIAL_SC16IS7XX >> tristate "SC16IS7xx serial support" >> - depends on I2C > > Please keep the dependency like this: > depends on I2C || SPI_MASTER > > (or SPI, I don't know what's the difference. SPI seems fine.) > >> select SERIAL_CORE >> - select REGMAP_I2C if I2C >> help >> This selects support for SC16IS7xx serial ports. >> Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, >> - SC16IS760 and SC16IS762. >> + SC16IS760 and SC16IS762, over i2c or spi. >> + select at least one of the i2c or spi interface. > > I would phrase the help message like this: > > This selects support for SC16IS7xx serial ports. > Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, > SC16IS760 and SC16IS762. Select supported buses using options below. > >> +config SERIAL_SC16IS7XX_I2C >> + bool "SC16IS7xx for I2C interface" > > Please add "default y" to minimize oldconfig pain for those already > using the driver. > >> + depends on SERIAL_SC16IS7XX=y > > Why =y? > >> + depends on I2C >> + select REGMAP_I2C if I2C >> + help >> + to enable i2c interface for SC16IS7XX, say Y, >> + Otherwise, for i2c say N. >> + this would make the driver to interface over SPI and I2C would >> + be diabled. > > I would phrase it simply like this: > > Enable SC16IS7xx driver on I2C bus. > >> +config SERIAL_SC16IS7XX_SPI >> + bool "SC16IS7xx for spi interface" >> + depends on SERIAL_SC16IS7XX >> + depends on SPI_MASTER > > Right now it is possible to select the driver without any bus-specific > option being set. I don't see an easy way to avoid this but please > make sure that there are no build failures/warnings in this scenario. > > You should also extend the binding information to include the new SPI > interface (Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt) > > > Thanks! > -- > To unsubscribe from this list: send the line "unsubscribe linux-serial" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2] sc16is7xx: spi interface is added
On Wed, 13 May 2015 16:27:58 +0530, ram.i hcltech wrote: spi interface for sc16is7xx is added along with Kconfig flag to enable spi or i2c, thus in a instance we can have either spi or i2c or both, in sync to the hw. Signed-off-by: ram.i hcltech indrakanti_...@hotmail.com --- Changes in v2: -Added seprate flags for i2c and spi -Added space in the comments lines -Added MODULE_ALIAS for spi interface --- drivers/tty/serial/Kconfig | 27 +++-- drivers/tty/serial/sc16is7xx.c | 69 +- 2 files changed, 92 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index f8120c1..8c505b2 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1181,13 +1181,34 @@ config SERIAL_SCCNXP_CONSOLE To avoid error or warning on build, i think this would be the probable solution. I thinking to go with this, any comments on this please. config SERIAL_SC16IS7XX bool config SERIAL_SC16IS7XX_SELECT tristate SC16IS7xx serial support select SERIAL_CORE depends on I2C || SPI_MASTER select REGMAP_I2C if I2C select REGMAP_SPI if SPI_MASTER help This selects support for SC16IS7xx serial ports. Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, SC16IS760 and SC16IS762. Select supported buses using options below. config SERIAL_SC16IS7XX_I2C bool SC16IS7xx for I2C interface depends on SERIAL_SC16IS7XX_SELECT select SERIAL_SC16IS7XX default y help Enable SC16IS7xx driver on I2C bus. config SERIAL_SC16IS7XX_SPI bool SC16IS7xx for spi interface depends on SERIAL_SC16IS7XX_SELECT select SERIAL_SC16IS7XX help Enable SC16IS7xx driver on SPI bus. config SERIAL_SC16IS7XX tristate SC16IS7xx serial support - depends on I2C Please keep the dependency like this: depends on I2C || SPI_MASTER (or SPI, I don't know what's the difference. SPI seems fine.) select SERIAL_CORE - select REGMAP_I2C if I2C help This selects support for SC16IS7xx serial ports. Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, - SC16IS760 and SC16IS762. + SC16IS760 and SC16IS762, over i2c or spi. + select at least one of the i2c or spi interface. I would phrase the help message like this: This selects support for SC16IS7xx serial ports. Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, SC16IS760 and SC16IS762. Select supported buses using options below. +config SERIAL_SC16IS7XX_I2C + bool SC16IS7xx for I2C interface Please add default y to minimize oldconfig pain for those already using the driver. + depends on SERIAL_SC16IS7XX=y Why =y? + depends on I2C + select REGMAP_I2C if I2C + help + to enable i2c interface for SC16IS7XX, say Y, + Otherwise, for i2c say N. + this would make the driver to interface over SPI and I2C would + be diabled. I would phrase it simply like this: Enable SC16IS7xx driver on I2C bus. +config SERIAL_SC16IS7XX_SPI + bool SC16IS7xx for spi interface + depends on SERIAL_SC16IS7XX + depends on SPI_MASTER Right now it is possible to select the driver without any bus-specific option being set. I don't see an easy way to avoid this but please make sure that there are no build failures/warnings in this scenario. You should also extend the binding information to include the new SPI interface (Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt) Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-serial in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2] sc16is7xx: spi interface is added
On Thu, 14 May 2015 13:16:20 +0530, ram kiran wrote: On Wed, 13 May 2015 16:27:58 +0530, ram.i hcltech wrote: spi interface for sc16is7xx is added along with Kconfig flag to enable spi or i2c, thus in a instance we can have either spi or i2c or both, in sync to the hw. Signed-off-by: ram.i hcltech indrakanti_...@hotmail.com --- Changes in v2: -Added seprate flags for i2c and spi -Added space in the comments lines -Added MODULE_ALIAS for spi interface --- drivers/tty/serial/Kconfig | 27 +++-- drivers/tty/serial/sc16is7xx.c | 69 +- 2 files changed, 92 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index f8120c1..8c505b2 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1181,13 +1181,34 @@ config SERIAL_SCCNXP_CONSOLE To avoid error or warning on build, i think this would be the probable solution. I thinking to go with this, any comments on this please. config SERIAL_SC16IS7XX bool config SERIAL_SC16IS7XX_SELECT tristate SC16IS7xx serial support select SERIAL_CORE depends on I2C || SPI_MASTER select REGMAP_I2C if I2C select REGMAP_SPI if SPI_MASTER help This selects support for SC16IS7xx serial ports. Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, SC16IS760 and SC16IS762. Select supported buses using options below. config SERIAL_SC16IS7XX_I2C bool SC16IS7xx for I2C interface depends on SERIAL_SC16IS7XX_SELECT select SERIAL_SC16IS7XX default y help Enable SC16IS7xx driver on I2C bus. config SERIAL_SC16IS7XX_SPI bool SC16IS7xx for spi interface depends on SERIAL_SC16IS7XX_SELECT select SERIAL_SC16IS7XX help Enable SC16IS7xx driver on SPI bus. This looks quite elegant! Should we aslo make SERIAL_SC16IS7XX depend on SERIAL_SC16IS7XX_I2C || SERIAL_SC16IS7XX_SPI? Would that work? This would be additional protection, need to check if that is too much to do or would be good to go. I know little about kbuild but I'm worried that someone doing oldconfig can still get SERIAL_SC16IS7XX selected while saying no to all the others. Other option would be to swap the names between SERIAL_SC16IS7XX and SERIAL_SC16IS7XX_SELECT, oldconfig would run smoother. I think, with the above, there would need a configuration change for sure. It should be okay, as I2C is default Y. Swap names would need Makefile changes, i was just thinking to avoid this. obj-$(CONFIG_SERIAL_SC16IS7XX) += sc16is7xx.o would be obj-$(CONFIG_SERIAL_SC16IS7XX_SELECT) += sc16is7xx.o I think its some that need not be there. Do suggest.. Thanks Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-serial in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] sc16is7xx: spi interface is added
On Thu, 14 May 2015 13:16:20 +0530, ram kiran wrote: On Wed, 13 May 2015 16:27:58 +0530, ram.i hcltech wrote: spi interface for sc16is7xx is added along with Kconfig flag to enable spi or i2c, thus in a instance we can have either spi or i2c or both, in sync to the hw. Signed-off-by: ram.i hcltech indrakanti_...@hotmail.com --- Changes in v2: -Added seprate flags for i2c and spi -Added space in the comments lines -Added MODULE_ALIAS for spi interface --- drivers/tty/serial/Kconfig | 27 +++-- drivers/tty/serial/sc16is7xx.c | 69 +- 2 files changed, 92 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index f8120c1..8c505b2 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1181,13 +1181,34 @@ config SERIAL_SCCNXP_CONSOLE To avoid error or warning on build, i think this would be the probable solution. I thinking to go with this, any comments on this please. config SERIAL_SC16IS7XX bool config SERIAL_SC16IS7XX_SELECT tristate SC16IS7xx serial support select SERIAL_CORE depends on I2C || SPI_MASTER select REGMAP_I2C if I2C select REGMAP_SPI if SPI_MASTER help This selects support for SC16IS7xx serial ports. Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, SC16IS760 and SC16IS762. Select supported buses using options below. config SERIAL_SC16IS7XX_I2C bool SC16IS7xx for I2C interface depends on SERIAL_SC16IS7XX_SELECT select SERIAL_SC16IS7XX default y help Enable SC16IS7xx driver on I2C bus. config SERIAL_SC16IS7XX_SPI bool SC16IS7xx for spi interface depends on SERIAL_SC16IS7XX_SELECT select SERIAL_SC16IS7XX help Enable SC16IS7xx driver on SPI bus. This looks quite elegant! Should we aslo make SERIAL_SC16IS7XX depend on SERIAL_SC16IS7XX_I2C || SERIAL_SC16IS7XX_SPI? Would that work? I know little about kbuild but I'm worried that someone doing oldconfig can still get SERIAL_SC16IS7XX selected while saying no to all the others. Other option would be to swap the names between SERIAL_SC16IS7XX and SERIAL_SC16IS7XX_SELECT, oldconfig would run smoother. Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] sc16is7xx: spi interface is added
On Thu, 14 May 2015 14:45:47 +0530, ram kiran wrote: I know little about kbuild but I'm worried that someone doing oldconfig can still get SERIAL_SC16IS7XX selected while saying no to all the others. Other option would be to swap the names between SERIAL_SC16IS7XX and SERIAL_SC16IS7XX_SELECT, oldconfig would run smoother. I think, with the above, there would need a configuration change for sure. It should be okay, as I2C is default Y. Exactly, but with what you proposed we need a configuration change as well, no? SERIAL_SC16IS7XX_SELECT is new so users would have to know that it's what SERIAL_SC16IS7XX used to be. Swap names would need Makefile changes, i was just thinking to avoid this. obj-$(CONFIG_SERIAL_SC16IS7XX) += sc16is7xx.o would be obj-$(CONFIG_SERIAL_SC16IS7XX_SELECT) += sc16is7xx.o I think its some that need not be there. Do suggest.. Perhaps *_SELECT is not the best name then but we could use something like *_CORE or *_BASE. Changes to the Makefile are not user-visible so no worries. It would be nice if people who run oldconfig by default got the same behaviour as they did so far (i2c if SC16IS7XX was enabled in previous config). I think with names swapped and modification of Makefile we would get exactly that. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] sc16is7xx: spi interface is added
On Thu, 14 May 2015 14:45:47 +0530, ram kiran wrote: I know little about kbuild but I'm worried that someone doing oldconfig can still get SERIAL_SC16IS7XX selected while saying no to all the others. Other option would be to swap the names between SERIAL_SC16IS7XX and SERIAL_SC16IS7XX_SELECT, oldconfig would run smoother. I think, with the above, there would need a configuration change for sure. It should be okay, as I2C is default Y. Exactly, but with what you proposed we need a configuration change as well, no? SERIAL_SC16IS7XX_SELECT is new so users would have to know that it's what SERIAL_SC16IS7XX used to be. Swap names would need Makefile changes, i was just thinking to avoid this. obj-$(CONFIG_SERIAL_SC16IS7XX) += sc16is7xx.o would be obj-$(CONFIG_SERIAL_SC16IS7XX_SELECT) += sc16is7xx.o I think its some that need not be there. Do suggest.. Perhaps *_SELECT is not the best name then but we could use something like *_CORE or *_BASE. Changes to the Makefile are not user-visible so no worries. It would be nice if people who run oldconfig by default got the same behaviour as they did so far (i2c if SC16IS7XX was enabled in previous config). I think with names swapped and modification of Makefile we would get exactly that. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2] sc16is7xx: spi interface is added
> On Wed, 13 May 2015 16:27:58 +0530, ram.i hcltech wrote: >> spi interface for sc16is7xx is added along with Kconfig flag >> to enable spi or i2c, thus in a instance we can have either >> spi or i2c or both, in sync to the hw. >> >> Signed-off-by: ram.i hcltech >> --- >> >> Changes in v2: >> -Added seprate flags for i2c and spi >> -Added space in the comments lines >> -Added MODULE_ALIAS for spi interface >> --- >> drivers/tty/serial/Kconfig | 27 +++-- >> drivers/tty/serial/sc16is7xx.c | 69 >> +- >> 2 files changed, 92 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig >> index f8120c1..8c505b2 100644 >> --- a/drivers/tty/serial/Kconfig >> +++ b/drivers/tty/serial/Kconfig >> @@ -1181,13 +1181,34 @@ config SERIAL_SCCNXP_CONSOLE >> >> config SERIAL_SC16IS7XX >> tristate "SC16IS7xx serial support" >> - depends on I2C > > Please keep the dependency like this: > depends on I2C || SPI_MASTER > > (or SPI, I don't know what's the difference. SPI seems fine.) > The depends on is pushed to the interface selection... i think that would be better as it be collated accordingly. >> select SERIAL_CORE >> - select REGMAP_I2C if I2C >> help >> This selects support for SC16IS7xx serial ports. >> Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, >> - SC16IS760 and SC16IS762. >> + SC16IS760 and SC16IS762, over i2c or spi. >> + select at least one of the i2c or spi interface. > > I would phrase the help message like this: > > This selects support for SC16IS7xx serial ports. > Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, > SC16IS760 and SC16IS762. Select supported buses using options below. > Yeah a better one..will take it... >> +config SERIAL_SC16IS7XX_I2C >> + bool "SC16IS7xx for I2C interface" > > Please add "default y" to minimize oldconfig pain for those already > using the driver. > yes, missed this. >> + depends on SERIAL_SC16IS7XX=y > > Why =y? > >> + depends on I2C >> + select REGMAP_I2C if I2C >> + help >> + to enable i2c interface for SC16IS7XX, say Y, >> + Otherwise, for i2c say N. >> + this would make the driver to interface over SPI and I2C would >> + be diabled. > > I would phrase it simply like this: > > Enable SC16IS7xx driver on I2C bus. short description for the flags fails in checkpatch.pl and hence the text.. > >> +config SERIAL_SC16IS7XX_SPI >> + bool "SC16IS7xx for spi interface" >> + depends on SERIAL_SC16IS7XX >> + depends on SPI_MASTER > > Right now it is possible to select the driver without any bus-specific > option being set. I don't see an easy way to avoid this but please > make sure that there are no build failures/warnings in this scenario. > Yes, that being the reason, and for the driver to work, there should be any one the interfaces to be enabled by default. > You should also extend the binding information to include the new SPI > interface (Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt) > Yes, this needs to be updated, i think that shall be a separate patch... > > Thanks! > -- > To unsubscribe from this list: send the line "unsubscribe linux-serial" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] sc16is7xx: spi interface is added
On Wed, 13 May 2015 16:27:58 +0530, ram.i hcltech wrote: > spi interface for sc16is7xx is added along with Kconfig flag > to enable spi or i2c, thus in a instance we can have either > spi or i2c or both, in sync to the hw. > > Signed-off-by: ram.i hcltech > --- > > Changes in v2: > -Added seprate flags for i2c and spi > -Added space in the comments lines > -Added MODULE_ALIAS for spi interface > --- > drivers/tty/serial/Kconfig | 27 +++-- > drivers/tty/serial/sc16is7xx.c | 69 > +- > 2 files changed, 92 insertions(+), 4 deletions(-) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index f8120c1..8c505b2 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -1181,13 +1181,34 @@ config SERIAL_SCCNXP_CONSOLE > > config SERIAL_SC16IS7XX > tristate "SC16IS7xx serial support" > - depends on I2C Please keep the dependency like this: depends on I2C || SPI_MASTER (or SPI, I don't know what's the difference. SPI seems fine.) > select SERIAL_CORE > - select REGMAP_I2C if I2C > help > This selects support for SC16IS7xx serial ports. > Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, > - SC16IS760 and SC16IS762. > + SC16IS760 and SC16IS762, over i2c or spi. > + select at least one of the i2c or spi interface. I would phrase the help message like this: This selects support for SC16IS7xx serial ports. Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, SC16IS760 and SC16IS762. Select supported buses using options below. > +config SERIAL_SC16IS7XX_I2C > + bool "SC16IS7xx for I2C interface" Please add "default y" to minimize oldconfig pain for those already using the driver. > + depends on SERIAL_SC16IS7XX=y Why =y? > + depends on I2C > + select REGMAP_I2C if I2C > + help > + to enable i2c interface for SC16IS7XX, say Y, > + Otherwise, for i2c say N. > + this would make the driver to interface over SPI and I2C would > + be diabled. I would phrase it simply like this: Enable SC16IS7xx driver on I2C bus. > +config SERIAL_SC16IS7XX_SPI > + bool "SC16IS7xx for spi interface" > + depends on SERIAL_SC16IS7XX > + depends on SPI_MASTER Right now it is possible to select the driver without any bus-specific option being set. I don't see an easy way to avoid this but please make sure that there are no build failures/warnings in this scenario. You should also extend the binding information to include the new SPI interface (Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt) Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v2] sc16is7xx: spi interface is added
not sure why is not available on mailing list...
> From: indrakanti_...@hotmail.com
> To: linux-ser...@vger.kernel.org; linux-kernel@vger.kernel.org;
> jsl...@suse.cz; gre...@linuxfoundation.org
> CC: moorr...@wp.pl; indrakanti@gmail.com; indrakanti_...@hotmail.com
> Subject: [PATCH v2] sc16is7xx: spi interface is added
> Date: Wed, 13 May 2015 16:27:58 +0530
>
> spi interface for sc16is7xx is added along with Kconfig flag
> to enable spi or i2c, thus in a instance we can have either
> spi or i2c or both, in sync to the hw.
>
> Signed-off-by: ram.i hcltech
> ---
>
> Changes in v2:
> -Added seprate flags for i2c and spi
> -Added space in the comments lines
> -Added MODULE_ALIAS for spi interface
> ---
> drivers/tty/serial/Kconfig | 27 +++--
> drivers/tty/serial/sc16is7xx.c | 69 +-
> 2 files changed, 92 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index f8120c1..8c505b2 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1181,13 +1181,34 @@ config SERIAL_SCCNXP_CONSOLE
>
> config SERIAL_SC16IS7XX
> tristate "SC16IS7xx serial support"
> - depends on I2C
> select SERIAL_CORE
> - select REGMAP_I2C if I2C
> help
> This selects support for SC16IS7xx serial ports.
> Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752,
> - SC16IS760 and SC16IS762.
> + SC16IS760 and SC16IS762, over i2c or spi.
> + select at least one of the i2c or spi interface.
> +
> +config SERIAL_SC16IS7XX_I2C
> + bool "SC16IS7xx for I2C interface"
> + depends on SERIAL_SC16IS7XX=y
> + depends on I2C
> + select REGMAP_I2C if I2C
> + help
> + to enable i2c interface for SC16IS7XX, say Y,
> + Otherwise, for i2c say N.
> + this would make the driver to interface over SPI and I2C would
> + be diabled.
> +
> +config SERIAL_SC16IS7XX_SPI
> + bool "SC16IS7xx for spi interface"
> + depends on SERIAL_SC16IS7XX
> + depends on SPI_MASTER
> + select REGMAP_SPI if SPI_MASTER
> + help
> + to enable spi interface for SC16IS7XX, say Y,
> + Otherwise, for i2c say N.
> + this would make the driver to interface over SPI and I2C would
> + be diabled.
>
> config SERIAL_BFIN_SPORT
> tristate "Blackfin SPORT emulate UART"
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index 468354e..ca6a838 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -25,6 +25,7 @@
> #include
> #include
> #include
> +#include
> #include
>
> #define SC16IS7XX_NAME "sc16is7xx"
> @@ -1203,7 +1204,73 @@ static struct regmap_config regcfg = {
> .volatile_reg = sc16is7xx_regmap_volatile,
> .precious_reg = sc16is7xx_regmap_precious,
> };
> +#ifdef CONFIG_SERIAL_SC16IS7XX_SPI
> +static int sc16is7xx_spi_probe(struct spi_device *spi)
> +{
> + struct sc16is7xx_devtype *devtype;
> + unsigned long flags = 0;
> + struct regmap *regmap;
> + int ret;
> +
> + /* Setup SPI bus */
> + spi->bits_per_word = 8;
> + /* only supports mode 0 on SC16IS762 */
> + spi->mode = spi->mode ? : SPI_MODE_0;
> + spi->max_speed_hz = spi->max_speed_hz ? : 1500;
> + ret = spi_setup(spi);
> + if (ret)
> + return ret;
> +
> + if (spi->dev.of_node) {
> + const struct of_device_id *of_id =
> + of_match_device(sc16is7xx_dt_ids, >dev);
> +
> + devtype = (struct sc16is7xx_devtype *)of_id->data;
> + } else {
> + const struct spi_device_id *id_entry = spi_get_device_id(spi);
> +
> + devtype = (struct sc16is7xx_devtype *)id_entry->driver_data;
> + flags = IRQF_TRIGGER_FALLING;
> + }
> +
> + regcfg.max_register = (0xf << SC16IS7XX_REG_SHIFT) |
> + (devtype->nr_uart - 1);
> + regmap = devm_regmap_init_spi(spi, );
> +
> + return sc16is7xx_probe(>dev, devtype, regmap, spi->irq, flags);
> +}
> +
> +static int sc16is7xx_spi_remove(struct spi_device *spi)
> +{
> + return sc16is7xx_remove(>dev);
> +}
>
> +static const struct spi_device_id sc16is7xx_spi_id_table[] = {
> + { "sc16is74x", (kernel_ulong_t)_devtype, },
> + { "sc16is750", (kernel_ulong_t)_devtype, },
> + { "sc16is752", (kernel_ulong_t)_devtype, },
> + { "sc16is760", (kernel_ulong_t)_devtype, },
> + { "sc16is762", (kernel_ulong_t)_devtype, },
> + { }
> +};
> +
> +MODULE_DEVICE_TABLE(spi, sc16is7xx_spi_id_table);
> +
> +static struct spi_driver sc16is7xx_spi_uart_driver = {
> + .driver = {
> + .name = SC16IS7XX_NAME,
> + .owner = THIS_MODULE,
> + .of_match_table = of_match_ptr(sc16is7xx_dt_ids),
> + },
> + .probe = sc16is7xx_spi_probe,
> + .remove = sc16is7xx_spi_remove,
> + .id_table = sc16is7xx_spi_id_table,
> +};
> +module_spi_driver(sc16is7xx_spi_uart_driver);
> +MODULE_ALIAS("spi:sc16is7xx");
> +#endif
> +
> +#ifdef CONFIG_SERIAL_SC16IS7XX_I2C
> static int sc16is7xx_i2c_probe(struct i2c_client *i2c,
> const struct i2c_device_id *id)
> {
> @@ -1255,7 +1322,7 @@ static struct i2c_driver sc16is7xx_i2c_uart_driver = {
> };
> module_i2c_driver(sc16is7xx_i2c_uart_driver);
> MODULE_ALIAS("i2c:sc16is7xx");
> -
>
RE: [PATCH v2] sc16is7xx: spi interface is added
not sure why is not available on mailing list...
From: indrakanti_...@hotmail.com
To: linux-ser...@vger.kernel.org; linux-kernel@vger.kernel.org;
jsl...@suse.cz; gre...@linuxfoundation.org
CC: moorr...@wp.pl; indrakanti@gmail.com; indrakanti_...@hotmail.com
Subject: [PATCH v2] sc16is7xx: spi interface is added
Date: Wed, 13 May 2015 16:27:58 +0530
spi interface for sc16is7xx is added along with Kconfig flag
to enable spi or i2c, thus in a instance we can have either
spi or i2c or both, in sync to the hw.
Signed-off-by: ram.i hcltech indrakanti_...@hotmail.com
---
Changes in v2:
-Added seprate flags for i2c and spi
-Added space in the comments lines
-Added MODULE_ALIAS for spi interface
---
drivers/tty/serial/Kconfig | 27 +++--
drivers/tty/serial/sc16is7xx.c | 69 +-
2 files changed, 92 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index f8120c1..8c505b2 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1181,13 +1181,34 @@ config SERIAL_SCCNXP_CONSOLE
config SERIAL_SC16IS7XX
tristate SC16IS7xx serial support
- depends on I2C
select SERIAL_CORE
- select REGMAP_I2C if I2C
help
This selects support for SC16IS7xx serial ports.
Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752,
- SC16IS760 and SC16IS762.
+ SC16IS760 and SC16IS762, over i2c or spi.
+ select at least one of the i2c or spi interface.
+
+config SERIAL_SC16IS7XX_I2C
+ bool SC16IS7xx for I2C interface
+ depends on SERIAL_SC16IS7XX=y
+ depends on I2C
+ select REGMAP_I2C if I2C
+ help
+ to enable i2c interface for SC16IS7XX, say Y,
+ Otherwise, for i2c say N.
+ this would make the driver to interface over SPI and I2C would
+ be diabled.
+
+config SERIAL_SC16IS7XX_SPI
+ bool SC16IS7xx for spi interface
+ depends on SERIAL_SC16IS7XX
+ depends on SPI_MASTER
+ select REGMAP_SPI if SPI_MASTER
+ help
+ to enable spi interface for SC16IS7XX, say Y,
+ Otherwise, for i2c say N.
+ this would make the driver to interface over SPI and I2C would
+ be diabled.
config SERIAL_BFIN_SPORT
tristate Blackfin SPORT emulate UART
diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index 468354e..ca6a838 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -25,6 +25,7 @@
#include linux/serial.h
#include linux/tty.h
#include linux/tty_flip.h
+#include linux/spi/spi.h
#include linux/uaccess.h
#define SC16IS7XX_NAME sc16is7xx
@@ -1203,7 +1204,73 @@ static struct regmap_config regcfg = {
.volatile_reg = sc16is7xx_regmap_volatile,
.precious_reg = sc16is7xx_regmap_precious,
};
+#ifdef CONFIG_SERIAL_SC16IS7XX_SPI
+static int sc16is7xx_spi_probe(struct spi_device *spi)
+{
+ struct sc16is7xx_devtype *devtype;
+ unsigned long flags = 0;
+ struct regmap *regmap;
+ int ret;
+
+ /* Setup SPI bus */
+ spi-bits_per_word = 8;
+ /* only supports mode 0 on SC16IS762 */
+ spi-mode = spi-mode ? : SPI_MODE_0;
+ spi-max_speed_hz = spi-max_speed_hz ? : 1500;
+ ret = spi_setup(spi);
+ if (ret)
+ return ret;
+
+ if (spi-dev.of_node) {
+ const struct of_device_id *of_id =
+ of_match_device(sc16is7xx_dt_ids, spi-dev);
+
+ devtype = (struct sc16is7xx_devtype *)of_id-data;
+ } else {
+ const struct spi_device_id *id_entry = spi_get_device_id(spi);
+
+ devtype = (struct sc16is7xx_devtype *)id_entry-driver_data;
+ flags = IRQF_TRIGGER_FALLING;
+ }
+
+ regcfg.max_register = (0xf SC16IS7XX_REG_SHIFT) |
+ (devtype-nr_uart - 1);
+ regmap = devm_regmap_init_spi(spi, regcfg);
+
+ return sc16is7xx_probe(spi-dev, devtype, regmap, spi-irq, flags);
+}
+
+static int sc16is7xx_spi_remove(struct spi_device *spi)
+{
+ return sc16is7xx_remove(spi-dev);
+}
+static const struct spi_device_id sc16is7xx_spi_id_table[] = {
+ { sc16is74x, (kernel_ulong_t)sc16is74x_devtype, },
+ { sc16is750, (kernel_ulong_t)sc16is750_devtype, },
+ { sc16is752, (kernel_ulong_t)sc16is752_devtype, },
+ { sc16is760, (kernel_ulong_t)sc16is760_devtype, },
+ { sc16is762, (kernel_ulong_t)sc16is762_devtype, },
+ { }
+};
+
+MODULE_DEVICE_TABLE(spi, sc16is7xx_spi_id_table);
+
+static struct spi_driver sc16is7xx_spi_uart_driver = {
+ .driver = {
+ .name = SC16IS7XX_NAME,
+ .owner = THIS_MODULE,
+ .of_match_table = of_match_ptr(sc16is7xx_dt_ids),
+ },
+ .probe = sc16is7xx_spi_probe,
+ .remove = sc16is7xx_spi_remove,
+ .id_table = sc16is7xx_spi_id_table,
+};
+module_spi_driver(sc16is7xx_spi_uart_driver);
+MODULE_ALIAS(spi:sc16is7xx);
+#endif
+
+#ifdef CONFIG_SERIAL_SC16IS7XX_I2C
static int sc16is7xx_i2c_probe(struct i2c_client *i2c,
const struct i2c_device_id *id)
{
@@ -1255,7 +1322,7 @@ static struct i2c_driver sc16is7xx_i2c_uart_driver = {
};
module_i2c_driver(sc16is7xx_i2c_uart_driver);
MODULE_ALIAS(i2c:sc16is7xx);
-
+#endif
MODULE_LICENSE(GPL);
RE: [PATCH v2] sc16is7xx: spi interface is added
On Wed, 13 May 2015 16:27:58 +0530, ram.i hcltech wrote: spi interface for sc16is7xx is added along with Kconfig flag to enable spi or i2c, thus in a instance we can have either spi or i2c or both, in sync to the hw. Signed-off-by: ram.i hcltech indrakanti_...@hotmail.com --- Changes in v2: -Added seprate flags for i2c and spi -Added space in the comments lines -Added MODULE_ALIAS for spi interface --- drivers/tty/serial/Kconfig | 27 +++-- drivers/tty/serial/sc16is7xx.c | 69 +- 2 files changed, 92 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index f8120c1..8c505b2 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1181,13 +1181,34 @@ config SERIAL_SCCNXP_CONSOLE config SERIAL_SC16IS7XX tristate SC16IS7xx serial support - depends on I2C Please keep the dependency like this: depends on I2C || SPI_MASTER (or SPI, I don't know what's the difference. SPI seems fine.) The depends on is pushed to the interface selection... i think that would be better as it be collated accordingly. select SERIAL_CORE - select REGMAP_I2C if I2C help This selects support for SC16IS7xx serial ports. Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, - SC16IS760 and SC16IS762. + SC16IS760 and SC16IS762, over i2c or spi. + select at least one of the i2c or spi interface. I would phrase the help message like this: This selects support for SC16IS7xx serial ports. Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, SC16IS760 and SC16IS762. Select supported buses using options below. Yeah a better one..will take it... +config SERIAL_SC16IS7XX_I2C + bool SC16IS7xx for I2C interface Please add default y to minimize oldconfig pain for those already using the driver. yes, missed this. + depends on SERIAL_SC16IS7XX=y Why =y? + depends on I2C + select REGMAP_I2C if I2C + help + to enable i2c interface for SC16IS7XX, say Y, + Otherwise, for i2c say N. + this would make the driver to interface over SPI and I2C would + be diabled. I would phrase it simply like this: Enable SC16IS7xx driver on I2C bus. short description for the flags fails in checkpatch.pl and hence the text.. +config SERIAL_SC16IS7XX_SPI + bool SC16IS7xx for spi interface + depends on SERIAL_SC16IS7XX + depends on SPI_MASTER Right now it is possible to select the driver without any bus-specific option being set. I don't see an easy way to avoid this but please make sure that there are no build failures/warnings in this scenario. Yes, that being the reason, and for the driver to work, there should be any one the interfaces to be enabled by default. You should also extend the binding information to include the new SPI interface (Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt) Yes, this needs to be updated, i think that shall be a separate patch... Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-serial in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] sc16is7xx: spi interface is added
On Wed, 13 May 2015 16:27:58 +0530, ram.i hcltech wrote: spi interface for sc16is7xx is added along with Kconfig flag to enable spi or i2c, thus in a instance we can have either spi or i2c or both, in sync to the hw. Signed-off-by: ram.i hcltech indrakanti_...@hotmail.com --- Changes in v2: -Added seprate flags for i2c and spi -Added space in the comments lines -Added MODULE_ALIAS for spi interface --- drivers/tty/serial/Kconfig | 27 +++-- drivers/tty/serial/sc16is7xx.c | 69 +- 2 files changed, 92 insertions(+), 4 deletions(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index f8120c1..8c505b2 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1181,13 +1181,34 @@ config SERIAL_SCCNXP_CONSOLE config SERIAL_SC16IS7XX tristate SC16IS7xx serial support - depends on I2C Please keep the dependency like this: depends on I2C || SPI_MASTER (or SPI, I don't know what's the difference. SPI seems fine.) select SERIAL_CORE - select REGMAP_I2C if I2C help This selects support for SC16IS7xx serial ports. Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, - SC16IS760 and SC16IS762. + SC16IS760 and SC16IS762, over i2c or spi. + select at least one of the i2c or spi interface. I would phrase the help message like this: This selects support for SC16IS7xx serial ports. Supported ICs are SC16IS740, SC16IS741, SC16IS750, SC16IS752, SC16IS760 and SC16IS762. Select supported buses using options below. +config SERIAL_SC16IS7XX_I2C + bool SC16IS7xx for I2C interface Please add default y to minimize oldconfig pain for those already using the driver. + depends on SERIAL_SC16IS7XX=y Why =y? + depends on I2C + select REGMAP_I2C if I2C + help + to enable i2c interface for SC16IS7XX, say Y, + Otherwise, for i2c say N. + this would make the driver to interface over SPI and I2C would + be diabled. I would phrase it simply like this: Enable SC16IS7xx driver on I2C bus. +config SERIAL_SC16IS7XX_SPI + bool SC16IS7xx for spi interface + depends on SERIAL_SC16IS7XX + depends on SPI_MASTER Right now it is possible to select the driver without any bus-specific option being set. I don't see an easy way to avoid this but please make sure that there are no build failures/warnings in this scenario. You should also extend the binding information to include the new SPI interface (Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt) Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
