Re: [PATCH v2 3/3] i2c: xilinx: Use devm_* functions
> > First register the handler, then activate interrupts. You are right, > > this needs to be fixed, too. > > Do you want me to create separate patch just about moving request irq in > front of > xiic_reinit()? And then devm_ conversion? Yes, seperate, please. signature.asc Description: Digital signature
Re: [PATCH v2 3/3] i2c: xilinx: Use devm_* functions
On 10/04/2013 01:58 PM, Wolfram Sang wrote:
> On Fri, Oct 04, 2013 at 11:16:20AM +0200, Michal Simek wrote:
>> On 10/04/2013 07:33 AM, Wolfram Sang wrote:
>>>
+ i2c->base = devm_ioremap_resource(&pdev->dev, res);
+ if (IS_ERR(i2c->base)) {
+ dev_err(&pdev->dev, "Could not allocate iomem\n");
>>>
>>> devm_ioremap_resource already prints error messages.
>>
>> you are right.
>>
>>>
+ ret = devm_request_irq(&pdev->dev, irq, xiic_isr, 0, pdev->name, i2c);
>>>
>>> This is too early. Can you find out why?
>>
>> Why do you think that it is too early?
>
> The ISR uses spinlocks which are not initialized by then.
And waitqueue too. Ok I will keep that request irq in current location
and I will add xiic_reinit() below this code.
>> I am looking at origin code again and I think that the code
>> is also problematic because in xiic_reinit() interrupts are enabled
>> but they are requested later.
>> Shouldn't be there a logic that interrupts should be enabled when
>> interrupts are registered by the kernel?
>
> First register the handler, then activate interrupts. You are right,
> this needs to be fixed, too.
Do you want me to create separate patch just about moving request irq in front
of
xiic_reinit()? And then devm_ conversion?
Thanks,
Michal
signature.asc
Description: OpenPGP digital signature
Re: [PATCH v2 3/3] i2c: xilinx: Use devm_* functions
On Fri, Oct 04, 2013 at 11:16:20AM +0200, Michal Simek wrote:
> On 10/04/2013 07:33 AM, Wolfram Sang wrote:
> >
> >> + i2c->base = devm_ioremap_resource(&pdev->dev, res);
> >> + if (IS_ERR(i2c->base)) {
> >> + dev_err(&pdev->dev, "Could not allocate iomem\n");
> >
> > devm_ioremap_resource already prints error messages.
>
> you are right.
>
> >
> >> + ret = devm_request_irq(&pdev->dev, irq, xiic_isr, 0, pdev->name, i2c);
> >
> > This is too early. Can you find out why?
>
> Why do you think that it is too early?
The ISR uses spinlocks which are not initialized by then.
> I am looking at origin code again and I think that the code
> is also problematic because in xiic_reinit() interrupts are enabled
> but they are requested later.
> Shouldn't be there a logic that interrupts should be enabled when
> interrupts are registered by the kernel?
First register the handler, then activate interrupts. You are right,
this needs to be fixed, too.
Regards,
Wolfram
signature.asc
Description: Digital signature
Re: [PATCH v2 3/3] i2c: xilinx: Use devm_* functions
On 10/04/2013 07:33 AM, Wolfram Sang wrote:
>
>> +i2c->base = devm_ioremap_resource(&pdev->dev, res);
>> +if (IS_ERR(i2c->base)) {
>> +dev_err(&pdev->dev, "Could not allocate iomem\n");
>
> devm_ioremap_resource already prints error messages.
you are right.
>
>> +ret = devm_request_irq(&pdev->dev, irq, xiic_isr, 0, pdev->name, i2c);
>
> This is too early. Can you find out why?
Why do you think that it is too early?
I am looking at origin code again and I think that the code
is also problematic because in xiic_reinit() interrupts are enabled
but they are requested later.
Shouldn't be there a logic that interrupts should be enabled when
interrupts are registered by the kernel?
>> +pdata = (struct xiic_i2c_platform_data *)dev_get_platdata(&pdev->dev);
>
> Casting a void pointer?
No problem with that.
Thanks,
Michal
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
signature.asc
Description: OpenPGP digital signature
Re: [PATCH v2 3/3] i2c: xilinx: Use devm_* functions
> + i2c->base = devm_ioremap_resource(&pdev->dev, res);
> + if (IS_ERR(i2c->base)) {
> + dev_err(&pdev->dev, "Could not allocate iomem\n");
devm_ioremap_resource already prints error messages.
> + ret = devm_request_irq(&pdev->dev, irq, xiic_isr, 0, pdev->name, i2c);
This is too early. Can you find out why?
> + pdata = (struct xiic_i2c_platform_data *)dev_get_platdata(&pdev->dev);
Casting a void pointer?
signature.asc
Description: Digital signature
