Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-06 Thread Mark Brown 
On Fri, Nov 06, 2015 at 03:00:04PM +0900, Masahiro Yamada wrote:
> 2015-11-06 0:05 GMT+09:00 Mark Brown :

> > Your changelog needs to say this clearly, right now what it's saying
> > clearly doesn't correspond to what the change does.

> OK.

> This series is RFC and my main focus in on the 1/7.
> I will wait for more comments against the first one.

You didn't send that patch to most of the recipients so I've no idea
what that is...


signature.asc
Description: PGP signature

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-06 Thread Mark Brown 
On Fri, Nov 06, 2015 at 03:00:04PM +0900, Masahiro Yamada wrote:
> 2015-11-06 0:05 GMT+09:00 Mark Brown :

> > Your changelog needs to say this clearly, right now what it's saying
> > clearly doesn't correspond to what the change does.

> OK.

> This series is RFC and my main focus in on the 1/7.
> I will wait for more comments against the first one.

You didn't send that patch to most of the recipients so I've no idea
what that is...


signature.asc
Description: PGP signature

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Masahiro Yamada 
2015-11-06 0:05 GMT+09:00 Mark Brown :
> On Thu, Nov 05, 2015 at 09:32:15PM +0900, Masahiro Yamada wrote:
>
>> For compile test, right, "depends on RESET_CONTROLLER" is
>> redundant in the first place.
>
>> For run-time on real SoCs,the driver failed at the following point
>> without the reset-controller sub-system.
>
> Your changelog needs to say this clearly, right now what it's saying
> clearly doesn't correspond to what the change does.

OK.

This series is RFC and my main focus in on the 1/7.
I will wait for more comments against the first one.


-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Mark Brown 
On Thu, Nov 05, 2015 at 09:32:15PM +0900, Masahiro Yamada wrote:

> For compile test, right, "depends on RESET_CONTROLLER" is
> redundant in the first place.

> For run-time on real SoCs,the driver failed at the following point
> without the reset-controller sub-system.

Your changelog needs to say this clearly, right now what it's saying
clearly doesn't correspond to what the change does.


signature.asc
Description: PGP signature

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Masahiro Yamada 
2015-11-05 21:20 GMT+09:00 Mark Brown :
> On Thu, Nov 05, 2015 at 09:11:47PM +0900, Masahiro Yamada wrote:
>> 2015-11-05 20:28 GMT+09:00 Mark Brown :
>
>> > The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as
>> > ARCH_SUNXI.
>
>> The compile test of this driver should pass even if RESET_CONTROLLER
>> is not defined.
>> So, it does not matter for COMPILE_TEST.
>
> If that is the case then the change here is that the dependency on
> RESET_CONTROLLER is just redundant which isn't what the commit message
> says.

For compile test, right, "depends on RESET_CONTROLLER" is
redundant in the first place.

For run-time on real SoCs,the driver failed at the following point
without the reset-controller sub-system.


sspi->rstc = devm_reset_control_get(>dev, NULL);
if (IS_ERR(sspi->rstc)) {
dev_err(>dev, "Couldn't get reset controller\n");
ret = PTR_ERR(sspi->rstc);
goto err_free_master;
}




-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Mark Brown 
On Thu, Nov 05, 2015 at 09:11:47PM +0900, Masahiro Yamada wrote:
> 2015-11-05 20:28 GMT+09:00 Mark Brown :

> > The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as
> > ARCH_SUNXI.

> The compile test of this driver should pass even if RESET_CONTROLLER
> is not defined.
> So, it does not matter for COMPILE_TEST.

If that is the case then the change here is that the dependency on
RESET_CONTROLLER is just redundant which isn't what the commit message
says.


signature.asc
Description: PGP signature

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Masahiro Yamada 
2015-11-05 20:28 GMT+09:00 Mark Brown :
> On Thu, Nov 05, 2015 at 08:15:23PM +0900, Masahiro Yamada wrote:
>> ARCH_SUNXI selects RESET_CONTROLLER.
>> The dependency "depends on RESET_CONTROLLER" is already met.
>
> No, it isn't.
>
>>  config SPI_SUN6I
>>   tristate "Allwinner A31 SPI controller"
>>   depends on ARCH_SUNXI || COMPILE_TEST
>> - depends on RESET_CONTROLLER
>
> The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as
> ARCH_SUNXI.


The compile test of this driver should pass even if RESET_CONTROLLER
is not defined.
So, it does not matter for COMPILE_TEST.




-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Mark Brown 
On Thu, Nov 05, 2015 at 08:15:23PM +0900, Masahiro Yamada wrote:
> ARCH_SUNXI selects RESET_CONTROLLER.
> The dependency "depends on RESET_CONTROLLER" is already met.

No, it isn't.

>  config SPI_SUN6I
>   tristate "Allwinner A31 SPI controller"
>   depends on ARCH_SUNXI || COMPILE_TEST
> - depends on RESET_CONTROLLER

The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as
ARCH_SUNXI.


signature.asc
Description: PGP signature

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Masahiro Yamada 
2015-11-05 20:28 GMT+09:00 Mark Brown :
> On Thu, Nov 05, 2015 at 08:15:23PM +0900, Masahiro Yamada wrote:
>> ARCH_SUNXI selects RESET_CONTROLLER.
>> The dependency "depends on RESET_CONTROLLER" is already met.
>
> No, it isn't.
>
>>  config SPI_SUN6I
>>   tristate "Allwinner A31 SPI controller"
>>   depends on ARCH_SUNXI || COMPILE_TEST
>> - depends on RESET_CONTROLLER
>
> The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as
> ARCH_SUNXI.


The compile test of this driver should pass even if RESET_CONTROLLER
is not defined.
So, it does not matter for COMPILE_TEST.




-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Masahiro Yamada 
2015-11-05 21:20 GMT+09:00 Mark Brown :
> On Thu, Nov 05, 2015 at 09:11:47PM +0900, Masahiro Yamada wrote:
>> 2015-11-05 20:28 GMT+09:00 Mark Brown :
>
>> > The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as
>> > ARCH_SUNXI.
>
>> The compile test of this driver should pass even if RESET_CONTROLLER
>> is not defined.
>> So, it does not matter for COMPILE_TEST.
>
> If that is the case then the change here is that the dependency on
> RESET_CONTROLLER is just redundant which isn't what the commit message
> says.

For compile test, right, "depends on RESET_CONTROLLER" is
redundant in the first place.

For run-time on real SoCs,the driver failed at the following point
without the reset-controller sub-system.


sspi->rstc = devm_reset_control_get(>dev, NULL);
if (IS_ERR(sspi->rstc)) {
dev_err(>dev, "Couldn't get reset controller\n");
ret = PTR_ERR(sspi->rstc);
goto err_free_master;
}




-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Mark Brown 
On Thu, Nov 05, 2015 at 08:15:23PM +0900, Masahiro Yamada wrote:
> ARCH_SUNXI selects RESET_CONTROLLER.
> The dependency "depends on RESET_CONTROLLER" is already met.

No, it isn't.

>  config SPI_SUN6I
>   tristate "Allwinner A31 SPI controller"
>   depends on ARCH_SUNXI || COMPILE_TEST
> - depends on RESET_CONTROLLER

The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as
ARCH_SUNXI.


signature.asc
Description: PGP signature

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Mark Brown 
On Thu, Nov 05, 2015 at 09:11:47PM +0900, Masahiro Yamada wrote:
> 2015-11-05 20:28 GMT+09:00 Mark Brown :

> > The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as
> > ARCH_SUNXI.

> The compile test of this driver should pass even if RESET_CONTROLLER
> is not defined.
> So, it does not matter for COMPILE_TEST.

If that is the case then the change here is that the dependency on
RESET_CONTROLLER is just redundant which isn't what the commit message
says.


signature.asc
Description: PGP signature

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Masahiro Yamada 
2015-11-06 0:05 GMT+09:00 Mark Brown :
> On Thu, Nov 05, 2015 at 09:32:15PM +0900, Masahiro Yamada wrote:
>
>> For compile test, right, "depends on RESET_CONTROLLER" is
>> redundant in the first place.
>
>> For run-time on real SoCs,the driver failed at the following point
>> without the reset-controller sub-system.
>
> Your changelog needs to say this clearly, right now what it's saying
> clearly doesn't correspond to what the change does.

OK.

This series is RFC and my main focus in on the 1/7.
I will wait for more comments against the first one.


-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Mark Brown 
On Thu, Nov 05, 2015 at 09:32:15PM +0900, Masahiro Yamada wrote:

> For compile test, right, "depends on RESET_CONTROLLER" is
> redundant in the first place.

> For run-time on real SoCs,the driver failed at the following point
> without the reset-controller sub-system.

Your changelog needs to say this clearly, right now what it's saying
clearly doesn't correspond to what the change does.


signature.asc
Description: PGP signature