Re: compile error about do_softirq in 2.4.5-ac21

2001-06-30 Thread Byeong-ryeol Kim

On Sun, 1 Jul 2001, Byeong-ryeol Kim wrote:

>On Sat, 30 Jun 2001, Keith Owens wrote:
>
>>On Sat, 30 Jun 2001 10:07:20 +0900 (KST),
>>Byeong-ryeol Kim <[EMAIL PROTECTED]> wrote:
>background.c:57: `do_softirq_Rf0a529b7' undeclared (first use in \
>this function)
>>
>>Missing include in fs/jffs2/background.c.  spin_unlock_bh() needs the
>>definition of do_softirq().  Against 2.4.5-ac21, will fit -ac22 as well.
>>
>>Index: 5.52/fs/jffs2/background.c
>>--- 5.52/fs/jffs2/background.c Sun, 22 Apr 2001 07:25:55 +1000 kaos 
>(linux-2.4/Z/d/7_background 1.1 644)
>>+++ 5.52(w)/fs/jffs2/background.c Sat, 30 Jun 2001 14:13:12 +1000 kaos 
>(linux-2.4/Z/d/7_background 1.1 644)
>>@@ -43,6 +43,7 @@
>> #include 
>> #include 
>>+#include 
>> #include 
>> #include "nodelist.h"
>...
>
>Thank you.
>But, it is proved to be that jffs2/background.c includes 'linux/smp_lock.h',
>'linux/smp_lock.h' includes 'asm/smplock.h' and 'asm/smplock.h' includes
>'linux/interrupt.h'.
>Is it correct to put 'linux/interrupt.h' into jffs2/background.c in this
>situation?
...

Please, ignore my previous mail about 'linux/interrupt.h'.
I bypassed the '#ifndef CONFIG_SMP ... #endif' wrapper in linux/smp_lock.h.

...
#ifndef CONFIG_SMP

#define lock_kernel()   do { } while(0)
#define unlock_kernel() do { } while(0)
#define release_kernel_lock(task, cpu)  do { } while(0)
#define reacquire_kernel_lock(task) do { } while(0)
#define kernel_locked() 1

#else

#include 

#endif /* CONFIG_SMP */
...

Thanks,

-- 
Where there is a will, there is a way.   [EMAIL PROTECTED]
  For the future of you and me!  [EMAIL PROTECTED]
fingerprint = 1429 8AAF 8A2C 6043 DA2E  BD4C 964C 2698 687D 4B7D

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



Re: compile error about do_softirq in 2.4.5-ac21

2001-06-30 Thread Byeong-ryeol Kim

On Sat, 30 Jun 2001, Keith Owens wrote:

>On Sat, 30 Jun 2001 10:07:20 +0900 (KST),
>Byeong-ryeol Kim <[EMAIL PROTECTED]> wrote:
background.c:57: `do_softirq_Rf0a529b7' undeclared (first use in \
this function)
>
>Missing include in fs/jffs2/background.c.  spin_unlock_bh() needs the
>definition of do_softirq().  Against 2.4.5-ac21, will fit -ac22 as well.
>
>Index: 5.52/fs/jffs2/background.c
>--- 5.52/fs/jffs2/background.c Sun, 22 Apr 2001 07:25:55 +1000 kaos 
>(linux-2.4/Z/d/7_background 1.1 644)
>+++ 5.52(w)/fs/jffs2/background.c Sat, 30 Jun 2001 14:13:12 +1000 kaos 
>(linux-2.4/Z/d/7_background 1.1 644)
>@@ -43,6 +43,7 @@
> #include 
> #include 
>+#include 
> #include 
> #include "nodelist.h"
...

Thank you.
But, it is proved to be that jffs2/background.c includes 'linux/smp_lock.h',
'linux/smp_lock.h' includes 'asm/smplock.h' and 'asm/smplock.h' includes
'linux/interrupt.h'.
Is it correct to put 'linux/interrupt.h' into jffs2/background.c in this
situation?

-- 
Where there is a will, there is a way.   [EMAIL PROTECTED]
  For the future of you and me!  [EMAIL PROTECTED]
fingerprint = 1429 8AAF 8A2C 6043 DA2E  BD4C 964C 2698 687D 4B7D

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



Re: compile error about do_softirq in 2.4.5-ac21

2001-06-30 Thread Byeong-ryeol Kim

On Sat, 30 Jun 2001, Keith Owens wrote:

On Sat, 30 Jun 2001 10:07:20 +0900 (KST),
Byeong-ryeol Kim [EMAIL PROTECTED] wrote:
background.c:57: `do_softirq_Rf0a529b7' undeclared (first use in \
this function)

Missing include in fs/jffs2/background.c.  spin_unlock_bh() needs the
definition of do_softirq().  Against 2.4.5-ac21, will fit -ac22 as well.

Index: 5.52/fs/jffs2/background.c
--- 5.52/fs/jffs2/background.c Sun, 22 Apr 2001 07:25:55 +1000 kaos 
(linux-2.4/Z/d/7_background 1.1 644)
+++ 5.52(w)/fs/jffs2/background.c Sat, 30 Jun 2001 14:13:12 +1000 kaos 
(linux-2.4/Z/d/7_background 1.1 644)
@@ -43,6 +43,7 @@
 #include linux/jffs2.h
 #include linux/mtd/mtd.h
+#include linux/interrupt.h
 #include linux/smp_lock.h
 #include nodelist.h
...

Thank you.
But, it is proved to be that jffs2/background.c includes 'linux/smp_lock.h',
'linux/smp_lock.h' includes 'asm/smplock.h' and 'asm/smplock.h' includes
'linux/interrupt.h'.
Is it correct to put 'linux/interrupt.h' into jffs2/background.c in this
situation?

-- 
Where there is a will, there is a way.   [EMAIL PROTECTED]
  For the future of you and me!  [EMAIL PROTECTED]
fingerprint = 1429 8AAF 8A2C 6043 DA2E  BD4C 964C 2698 687D 4B7D

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



Re: compile error about do_softirq in 2.4.5-ac21

2001-06-30 Thread Byeong-ryeol Kim

On Sun, 1 Jul 2001, Byeong-ryeol Kim wrote:

On Sat, 30 Jun 2001, Keith Owens wrote:

On Sat, 30 Jun 2001 10:07:20 +0900 (KST),
Byeong-ryeol Kim [EMAIL PROTECTED] wrote:
background.c:57: `do_softirq_Rf0a529b7' undeclared (first use in \
this function)

Missing include in fs/jffs2/background.c.  spin_unlock_bh() needs the
definition of do_softirq().  Against 2.4.5-ac21, will fit -ac22 as well.

Index: 5.52/fs/jffs2/background.c
--- 5.52/fs/jffs2/background.c Sun, 22 Apr 2001 07:25:55 +1000 kaos 
(linux-2.4/Z/d/7_background 1.1 644)
+++ 5.52(w)/fs/jffs2/background.c Sat, 30 Jun 2001 14:13:12 +1000 kaos 
(linux-2.4/Z/d/7_background 1.1 644)
@@ -43,6 +43,7 @@
 #include linux/jffs2.h
 #include linux/mtd/mtd.h
+#include linux/interrupt.h
 #include linux/smp_lock.h
 #include nodelist.h
...

Thank you.
But, it is proved to be that jffs2/background.c includes 'linux/smp_lock.h',
'linux/smp_lock.h' includes 'asm/smplock.h' and 'asm/smplock.h' includes
'linux/interrupt.h'.
Is it correct to put 'linux/interrupt.h' into jffs2/background.c in this
situation?
...

Please, ignore my previous mail about 'linux/interrupt.h'.
I bypassed the '#ifndef CONFIG_SMP ... #endif' wrapper in linux/smp_lock.h.

...
#ifndef CONFIG_SMP

#define lock_kernel()   do { } while(0)
#define unlock_kernel() do { } while(0)
#define release_kernel_lock(task, cpu)  do { } while(0)
#define reacquire_kernel_lock(task) do { } while(0)
#define kernel_locked() 1

#else

#include asm/smplock.h

#endif /* CONFIG_SMP */
...

Thanks,

-- 
Where there is a will, there is a way.   [EMAIL PROTECTED]
  For the future of you and me!  [EMAIL PROTECTED]
fingerprint = 1429 8AAF 8A2C 6043 DA2E  BD4C 964C 2698 687D 4B7D

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



compile error about do_softirq in 2.4.5-ac21

2001-06-29 Thread Byeong-ryeol Kim

I met following error while compiling 2.4.5-ac21:

I know, of course, this error was reported several times as the
compile problem of 2.4.6-preX, and there posted a patch about it
by Mr. Keith Owens. I confirmed It had been applied to
include/asm-i386/softirq.h of 2.4.5-ac21).
But I see this in 2.4.5-ac21 again, and confused so much.

I use Red Hat 7.1 (with up to latest errata updates + kernel-2.4.5-ac19,
glibc-2.2.3, gcc-2.96-88, binutils-2.11.90.0.15, etc.)
BTW, this error ocurred on both K6-II+ desktop(no-name) and Pentium III
500 MHZ noteboot(IBM ThkinPad 600X), and compiler was the same on both
machines.

Before trying to compile, I applied a patch about drivers/net/Config.in
posted to this list by Mr. Keith Owens.

Long lines were wrapped by me.

...
make[2]: Leaving directory `/usr/src/linux-2.4.5-ac21/fs/jffs'
make -C jffs2 modules
...
gcc -D__KERNEL__ -I/usr/src/linux-2.4.5-ac21/include -Wall \
   -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer \
   -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 \
   -march=k6 -DMODULE -DMODVERSIONS \
   -include /usr/src/linux-2.4.5-ac21/include/linux/modversions.h \
   -c -o background.o background.c
background.c: In function `jffs2_garbage_collect_trigger':
background.c:57: `do_softirq_Rf0a529b7' undeclared (first use in \
this function)
background.c:57: (Each undeclared identifier is reported only once
background.c:57: for each function it appears in.)
background.c: In function `jffs2_stop_garbage_collect_thread':
background.c:87: `do_softirq_Rf0a529b7' undeclared (first use in this \
function)
background.c: In function `jffs2_garbage_collect_thread':
background.c:141: `do_softirq_Rf0a529b7' undeclared (first use in this \
function)
make[2]: *** [background.o] Error 1
make[2]: Leaving directory `/usr/src/linux-2.4.5-ac21/fs/jffs2'
make[1]: *** [_modsubdir_jffs2] Error 2
make[1]: Leaving directory `/usr/src/linux-2.4.5-ac21/fs'
make: *** [_mod_fs] Error 2

-- 
Where there is a will, there is a way.   [EMAIL PROTECTED]
  For the future of you and me!  [EMAIL PROTECTED]
fingerprint = 1429 8AAF 8A2C 6043 DA2E  BD4C 964C 2698 687D 4B7D

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/



compile error about do_softirq in 2.4.5-ac21

2001-06-29 Thread Byeong-ryeol Kim

I met following error while compiling 2.4.5-ac21:

I know, of course, this error was reported several times as the
compile problem of 2.4.6-preX, and there posted a patch about it
by Mr. Keith Owens. I confirmed It had been applied to
include/asm-i386/softirq.h of 2.4.5-ac21).
But I see this in 2.4.5-ac21 again, and confused so much.

I use Red Hat 7.1 (with up to latest errata updates + kernel-2.4.5-ac19,
glibc-2.2.3, gcc-2.96-88, binutils-2.11.90.0.15, etc.)
BTW, this error ocurred on both K6-II+ desktop(no-name) and Pentium III
500 MHZ noteboot(IBM ThkinPad 600X), and compiler was the same on both
machines.

Before trying to compile, I applied a patch about drivers/net/Config.in
posted to this list by Mr. Keith Owens.

Long lines were wrapped by me.

...
make[2]: Leaving directory `/usr/src/linux-2.4.5-ac21/fs/jffs'
make -C jffs2 modules
...
gcc -D__KERNEL__ -I/usr/src/linux-2.4.5-ac21/include -Wall \
   -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer \
   -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 \
   -march=k6 -DMODULE -DMODVERSIONS \
   -include /usr/src/linux-2.4.5-ac21/include/linux/modversions.h \
   -c -o background.o background.c
background.c: In function `jffs2_garbage_collect_trigger':
background.c:57: `do_softirq_Rf0a529b7' undeclared (first use in \
this function)
background.c:57: (Each undeclared identifier is reported only once
background.c:57: for each function it appears in.)
background.c: In function `jffs2_stop_garbage_collect_thread':
background.c:87: `do_softirq_Rf0a529b7' undeclared (first use in this \
function)
background.c: In function `jffs2_garbage_collect_thread':
background.c:141: `do_softirq_Rf0a529b7' undeclared (first use in this \
function)
make[2]: *** [background.o] Error 1
make[2]: Leaving directory `/usr/src/linux-2.4.5-ac21/fs/jffs2'
make[1]: *** [_modsubdir_jffs2] Error 2
make[1]: Leaving directory `/usr/src/linux-2.4.5-ac21/fs'
make: *** [_mod_fs] Error 2

-- 
Where there is a will, there is a way.   [EMAIL PROTECTED]
  For the future of you and me!  [EMAIL PROTECTED]
fingerprint = 1429 8AAF 8A2C 6043 DA2E  BD4C 964C 2698 687D 4B7D

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/