Re: [PATCH 00/32] perf and kconfig kbuild (2nd try)
On Wed, Jun 4, 2014 at 3:59 AM, David Ahern wrote: > On 6/3/14, 4:05 PM, Alexis Berlemont wrote: >> >> Alexis Berlemont (29): >>kbuild: add support of custom paths for "auto.conf*" files >>perf kbuild: fix recursive invocation of config/features-checks >>perf kbuild: store in config-detected missing variables (libdir, ...) >>perf kbuild: remove useless #ifdef directives >>perf kbuild: fix a link issue if BUILTIN_TRACE is disabled >>perf kbuild: add missing files and missing flags in Kbuild files >>perf kbuild: update kbuild files according to last changes >>perf kbuild: remove legacy slang-related build variables >>perf kbuild: remove legacy libaudit-related build variables >>perf kbuild: remove legacy libgtk2-related build variables >>perf kbuild: remove legacy libperl-related build variables >>perf kbuild: remove legacy timerfd-related build variable >>perf kbuild: remove legacy demangle-related build variables >>perf kbuild: remove legacy on_exit-related build variable >>perf kbuild: remove legacy backtrace-related build variable >>perf kbuild: remove legacy numa-related build variable >>perf kbuild: remove legacy bionic-related build variable >>perf kbuild: remove legacy libelf-related build variables (1st part) >>perf kbuild: remove legacy libelf-related build variables (2nd part) >>perf kbuild: remove legacy libdwarf-related build variables >>perf kbuild: remove legacy libpython-related build variable >>perf kbuild: add generated Kconfig build-test cases >>perf kbuild: fix installation of traceevent plugins >>perf kbuild: fix tarpkg target in tests/make >>perf kbuild: update Kbuild files with new and removed sources >>perf kbuild: update build test configurations >>perf kbuild: relocate the configs generating script >>perf kbuild: minor changes >>perf kbuild: remove Makefile.perf > > > > In general you are missing commit messages that explain why the patch is > needed -- what does it do, what is changed. The code should evolve from > where it is to where you want it to be in small focused patches that do not > break compiles or features (important for git-bisect). OK. I will gather the various commits in less large set of patches. > > For patches that you are leveraging from Jiri odds are they need to be > updated for what has happened over the past year since Jiri's last effort on > this. I suggest doing the updates in line with Jiri's patch and add a > comment of what was added to Jiri's patch. > OK. Let's try again. Many thanks for your answer. > Also add Namhyung Kim to your CC list. > > Thanks, > David Alexis. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/32] perf and kconfig kbuild (2nd try)
On Wed, Jun 4, 2014 at 3:59 AM, David Ahern dsah...@gmail.com wrote: On 6/3/14, 4:05 PM, Alexis Berlemont wrote: Alexis Berlemont (29): kbuild: add support of custom paths for auto.conf* files perf kbuild: fix recursive invocation of config/features-checks perf kbuild: store in config-detected missing variables (libdir, ...) perf kbuild: remove useless #ifdef directives perf kbuild: fix a link issue if BUILTIN_TRACE is disabled perf kbuild: add missing files and missing flags in Kbuild files perf kbuild: update kbuild files according to last changes perf kbuild: remove legacy slang-related build variables perf kbuild: remove legacy libaudit-related build variables perf kbuild: remove legacy libgtk2-related build variables perf kbuild: remove legacy libperl-related build variables perf kbuild: remove legacy timerfd-related build variable perf kbuild: remove legacy demangle-related build variables perf kbuild: remove legacy on_exit-related build variable perf kbuild: remove legacy backtrace-related build variable perf kbuild: remove legacy numa-related build variable perf kbuild: remove legacy bionic-related build variable perf kbuild: remove legacy libelf-related build variables (1st part) perf kbuild: remove legacy libelf-related build variables (2nd part) perf kbuild: remove legacy libdwarf-related build variables perf kbuild: remove legacy libpython-related build variable perf kbuild: add generated Kconfig build-test cases perf kbuild: fix installation of traceevent plugins perf kbuild: fix tarpkg target in tests/make perf kbuild: update Kbuild files with new and removed sources perf kbuild: update build test configurations perf kbuild: relocate the configs generating script perf kbuild: minor changes perf kbuild: remove Makefile.perf In general you are missing commit messages that explain why the patch is needed -- what does it do, what is changed. The code should evolve from where it is to where you want it to be in small focused patches that do not break compiles or features (important for git-bisect). OK. I will gather the various commits in less large set of patches. For patches that you are leveraging from Jiri odds are they need to be updated for what has happened over the past year since Jiri's last effort on this. I suggest doing the updates in line with Jiri's patch and add a comment of what was added to Jiri's patch. OK. Let's try again. Many thanks for your answer. Also add Namhyung Kim namhy...@kernel.org to your CC list. Thanks, David Alexis. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/32] perf and kconfig kbuild (2nd try)
On 6/3/14, 4:05 PM, Alexis Berlemont wrote: Alexis Berlemont (29): kbuild: add support of custom paths for "auto.conf*" files perf kbuild: fix recursive invocation of config/features-checks perf kbuild: store in config-detected missing variables (libdir, ...) perf kbuild: remove useless #ifdef directives perf kbuild: fix a link issue if BUILTIN_TRACE is disabled perf kbuild: add missing files and missing flags in Kbuild files perf kbuild: update kbuild files according to last changes perf kbuild: remove legacy slang-related build variables perf kbuild: remove legacy libaudit-related build variables perf kbuild: remove legacy libgtk2-related build variables perf kbuild: remove legacy libperl-related build variables perf kbuild: remove legacy timerfd-related build variable perf kbuild: remove legacy demangle-related build variables perf kbuild: remove legacy on_exit-related build variable perf kbuild: remove legacy backtrace-related build variable perf kbuild: remove legacy numa-related build variable perf kbuild: remove legacy bionic-related build variable perf kbuild: remove legacy libelf-related build variables (1st part) perf kbuild: remove legacy libelf-related build variables (2nd part) perf kbuild: remove legacy libdwarf-related build variables perf kbuild: remove legacy libpython-related build variable perf kbuild: add generated Kconfig build-test cases perf kbuild: fix installation of traceevent plugins perf kbuild: fix tarpkg target in tests/make perf kbuild: update Kbuild files with new and removed sources perf kbuild: update build test configurations perf kbuild: relocate the configs generating script perf kbuild: minor changes perf kbuild: remove Makefile.perf In general you are missing commit messages that explain why the patch is needed -- what does it do, what is changed. The code should evolve from where it is to where you want it to be in small focused patches that do not break compiles or features (important for git-bisect). For patches that you are leveraging from Jiri odds are they need to be updated for what has happened over the past year since Jiri's last effort on this. I suggest doing the updates in line with Jiri's patch and add a comment of what was added to Jiri's patch. Also add Namhyung Kim to your CC list. Thanks, David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 00/32] perf and kconfig kbuild (2nd try)
Hello,
Sorry the delay between my answers.
Here is another draft proposal. The changes are few:
* checkpatch.pl is ok with these patches (Kconfig documentation added,
style-related issues fixed, ... sorry)
* Sam Ravnborg and Michal Marek made some comments on the introduction
of the variables KBUILD_AUTOCONF and KCONFIG_AUTOCONFIGDEP
variables. I updated the first two patches according to their ideas:
$KCONFIG_AUTOCONFIG replaces $KBUILD_AUTOCONF and
$KCONFIG_AUTOCONFIGDEP was replaced by ${KCONFIG_AUTOCONFIG}.cmd
(confdata.c was updated accordingly).
Alexis.
Alexis Berlemont (29):
kbuild: add support of custom paths for "auto.conf*" files
perf kbuild: fix recursive invocation of config/features-checks
perf kbuild: store in config-detected missing variables (libdir, ...)
perf kbuild: remove useless #ifdef directives
perf kbuild: fix a link issue if BUILTIN_TRACE is disabled
perf kbuild: add missing files and missing flags in Kbuild files
perf kbuild: update kbuild files according to last changes
perf kbuild: remove legacy slang-related build variables
perf kbuild: remove legacy libaudit-related build variables
perf kbuild: remove legacy libgtk2-related build variables
perf kbuild: remove legacy libperl-related build variables
perf kbuild: remove legacy timerfd-related build variable
perf kbuild: remove legacy demangle-related build variables
perf kbuild: remove legacy on_exit-related build variable
perf kbuild: remove legacy backtrace-related build variable
perf kbuild: remove legacy numa-related build variable
perf kbuild: remove legacy bionic-related build variable
perf kbuild: remove legacy libelf-related build variables (1st part)
perf kbuild: remove legacy libelf-related build variables (2nd part)
perf kbuild: remove legacy libdwarf-related build variables
perf kbuild: remove legacy libpython-related build variable
perf kbuild: add generated Kconfig build-test cases
perf kbuild: fix installation of traceevent plugins
perf kbuild: fix tarpkg target in tests/make
perf kbuild: update Kbuild files with new and removed sources
perf kbuild: update build test configurations
perf kbuild: relocate the configs generating script
perf kbuild: minor changes
perf kbuild: remove Makefile.perf
Jiri Olsa (3):
perf tools: Kbuild builtin source related fixies
perf tools: Kbuild source related fixies
perf tools: Add kbuild support into Makefile.kbuild
scripts/Makefile.build | 3 +-
scripts/kconfig/confdata.c | 27 +-
scripts/kconfig/lkc.h | 1 +
tools/perf/Kbuild | 47 ++
tools/perf/Kconfig | 390 +++++
tools/perf/MANIFEST| 1 +
tools/perf/Makefile| 2 +-
tools/perf/Makefile.kbuild | 409 +
tools/perf/Makefile.perf | 930 -
tools/perf/arch/Kbuild | 3 +
tools/perf/arch/arm/Makefile | 4 +-
tools/perf/arch/powerpc/Makefile | 2 +-
tools/perf/arch/s390/Makefile | 2 +-
tools/perf/arch/sh/Makefile| 2 +-
tools/perf/arch/sparc/Makefile | 2 +-
tools/perf/arch/x86/Kbuild | 2 +
tools/perf/arch/x86/Makefile | 8 +-
tools/perf/arch/x86/tests/Kbuild | 2 +
tools/perf/arch/x86/util/Kbuild| 5 +
tools/perf/bench/Kbuild| 12 +
tools/perf/builtin-annotate.c | 8 +-
tools/perf/builtin-bench.c | 5 +-
tools/perf/builtin-cmds.h | 31 +
tools/perf/builtin-help.c | 1 +
tools/perf/builtin-inject.c| 2 +-
tools/perf/builtin-kvm.c | 32 +-
tools/perf/builtin-lock.c | 4 +-
tools/perf/builtin-mem.c | 1 +
tools/perf/builtin-probe.c | 15 +-
tools/perf/builtin-record.c| 14 +-
tools/perf/builtin-report.c| 3 +
tools/perf/builtin-sched.c | 2 +
tools/perf/builtin-script.c| 6 +-
tools/perf/builtin-top.c | 19 +-
tools/perf/config/Makefile | 397 +
tools/perf/config/defconfig| 54 ++
tools/perf/perf.c | 53 +-
tools/perf/perf.h | 2 +
tools/perf/scripts/perl/Perf-Trace-Util/Kbuild | 3 +
tools/perf/scripts/python/Perf-Trace-Util/Kbuild | 5 +
tools/perf/tests/Kbuild| 34 +
[PATCH 00/32] perf and kconfig kbuild (2nd try)
Hello,
Sorry the delay between my answers.
Here is another draft proposal. The changes are few:
* checkpatch.pl is ok with these patches (Kconfig documentation added,
style-related issues fixed, ... sorry)
* Sam Ravnborg and Michal Marek made some comments on the introduction
of the variables KBUILD_AUTOCONF and KCONFIG_AUTOCONFIGDEP
variables. I updated the first two patches according to their ideas:
$KCONFIG_AUTOCONFIG replaces $KBUILD_AUTOCONF and
$KCONFIG_AUTOCONFIGDEP was replaced by ${KCONFIG_AUTOCONFIG}.cmd
(confdata.c was updated accordingly).
Alexis.
Alexis Berlemont (29):
kbuild: add support of custom paths for auto.conf* files
perf kbuild: fix recursive invocation of config/features-checks
perf kbuild: store in config-detected missing variables (libdir, ...)
perf kbuild: remove useless #ifdef directives
perf kbuild: fix a link issue if BUILTIN_TRACE is disabled
perf kbuild: add missing files and missing flags in Kbuild files
perf kbuild: update kbuild files according to last changes
perf kbuild: remove legacy slang-related build variables
perf kbuild: remove legacy libaudit-related build variables
perf kbuild: remove legacy libgtk2-related build variables
perf kbuild: remove legacy libperl-related build variables
perf kbuild: remove legacy timerfd-related build variable
perf kbuild: remove legacy demangle-related build variables
perf kbuild: remove legacy on_exit-related build variable
perf kbuild: remove legacy backtrace-related build variable
perf kbuild: remove legacy numa-related build variable
perf kbuild: remove legacy bionic-related build variable
perf kbuild: remove legacy libelf-related build variables (1st part)
perf kbuild: remove legacy libelf-related build variables (2nd part)
perf kbuild: remove legacy libdwarf-related build variables
perf kbuild: remove legacy libpython-related build variable
perf kbuild: add generated Kconfig build-test cases
perf kbuild: fix installation of traceevent plugins
perf kbuild: fix tarpkg target in tests/make
perf kbuild: update Kbuild files with new and removed sources
perf kbuild: update build test configurations
perf kbuild: relocate the configs generating script
perf kbuild: minor changes
perf kbuild: remove Makefile.perf
Jiri Olsa (3):
perf tools: Kbuild builtin source related fixies
perf tools: Kbuild source related fixies
perf tools: Add kbuild support into Makefile.kbuild
scripts/Makefile.build | 3 +-
scripts/kconfig/confdata.c | 27 +-
scripts/kconfig/lkc.h | 1 +
tools/perf/Kbuild | 47 ++
tools/perf/Kconfig | 390 +
tools/perf/MANIFEST| 1 +
tools/perf/Makefile| 2 +-
tools/perf/Makefile.kbuild | 409 +
tools/perf/Makefile.perf | 930 -
tools/perf/arch/Kbuild | 3 +
tools/perf/arch/arm/Makefile | 4 +-
tools/perf/arch/powerpc/Makefile | 2 +-
tools/perf/arch/s390/Makefile | 2 +-
tools/perf/arch/sh/Makefile| 2 +-
tools/perf/arch/sparc/Makefile | 2 +-
tools/perf/arch/x86/Kbuild | 2 +
tools/perf/arch/x86/Makefile | 8 +-
tools/perf/arch/x86/tests/Kbuild | 2 +
tools/perf/arch/x86/util/Kbuild| 5 +
tools/perf/bench/Kbuild| 12 +
tools/perf/builtin-annotate.c | 8 +-
tools/perf/builtin-bench.c | 5 +-
tools/perf/builtin-cmds.h | 31 +
tools/perf/builtin-help.c | 1 +
tools/perf/builtin-inject.c| 2 +-
tools/perf/builtin-kvm.c | 32 +-
tools/perf/builtin-lock.c | 4 +-
tools/perf/builtin-mem.c | 1 +
tools/perf/builtin-probe.c | 15 +-
tools/perf/builtin-record.c| 14 +-
tools/perf/builtin-report.c| 3 +
tools/perf/builtin-sched.c | 2 +
tools/perf/builtin-script.c| 6 +-
tools/perf/builtin-top.c | 19 +-
tools/perf/config/Makefile | 397 +
tools/perf/config/defconfig| 54 ++
tools/perf/perf.c | 53 +-
tools/perf/perf.h | 2 +
tools/perf/scripts/perl/Perf-Trace-Util/Kbuild | 3 +
tools/perf/scripts/python/Perf-Trace-Util/Kbuild | 5 +
tools/perf/tests/Kbuild| 34 +
tools/perf
Re: [PATCH 00/32] perf and kconfig kbuild (2nd try)
On 6/3/14, 4:05 PM, Alexis Berlemont wrote: Alexis Berlemont (29): kbuild: add support of custom paths for auto.conf* files perf kbuild: fix recursive invocation of config/features-checks perf kbuild: store in config-detected missing variables (libdir, ...) perf kbuild: remove useless #ifdef directives perf kbuild: fix a link issue if BUILTIN_TRACE is disabled perf kbuild: add missing files and missing flags in Kbuild files perf kbuild: update kbuild files according to last changes perf kbuild: remove legacy slang-related build variables perf kbuild: remove legacy libaudit-related build variables perf kbuild: remove legacy libgtk2-related build variables perf kbuild: remove legacy libperl-related build variables perf kbuild: remove legacy timerfd-related build variable perf kbuild: remove legacy demangle-related build variables perf kbuild: remove legacy on_exit-related build variable perf kbuild: remove legacy backtrace-related build variable perf kbuild: remove legacy numa-related build variable perf kbuild: remove legacy bionic-related build variable perf kbuild: remove legacy libelf-related build variables (1st part) perf kbuild: remove legacy libelf-related build variables (2nd part) perf kbuild: remove legacy libdwarf-related build variables perf kbuild: remove legacy libpython-related build variable perf kbuild: add generated Kconfig build-test cases perf kbuild: fix installation of traceevent plugins perf kbuild: fix tarpkg target in tests/make perf kbuild: update Kbuild files with new and removed sources perf kbuild: update build test configurations perf kbuild: relocate the configs generating script perf kbuild: minor changes perf kbuild: remove Makefile.perf In general you are missing commit messages that explain why the patch is needed -- what does it do, what is changed. The code should evolve from where it is to where you want it to be in small focused patches that do not break compiles or features (important for git-bisect). For patches that you are leveraging from Jiri odds are they need to be updated for what has happened over the past year since Jiri's last effort on this. I suggest doing the updates in line with Jiri's patch and add a comment of what was added to Jiri's patch. Also add Namhyung Kim namhy...@kernel.org to your CC list. Thanks, David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/34] perf and kconfig / kbuild
Hello, Sorry for the late reply, On Wed, May 14, 2014 at 4:15 AM, David Ahern wrote: > On 5/13/14, 4:02 PM, Alexis Berlemont wrote: >> >> Hello, >> >> A few months ago, I tried to make a proposal to introduce Kconfig in >> perf's generation procedure. >> (cf. https://lkml.org/lkml/2013/12/20/511) >> >> I started from David Ahern's work; I was not aware that Jiri Olsa >> pushed further the idea and proposed an alternative which integrated >> kbuild too. >> >> So, here is another proposal based on Jiri Olsa work (from April 2013). >> * Most of the NO_* and HAVE_* makefile variables were removed on >>behalf of Kconfig's ones (CONFIG_*); perf source code was modified >>accordingly; >> * These changes make the glue files tools/perf/config/Makefile.fix-* >> useless >> * The build test cases now relies on generated configuration files (in >>tools/perf/tests/configs); >> > > Thanks for picking this up. I skimmed through all of the patches and > conceptually looks good. I doubt I will have time for a detailed review any > time soon. > > Looks like they apply to Linus' top of tree but with a few errors -- see > below. You should always run checkpatch.pl before sending out: Sorry, I indeed did not run checkpatch. I will come back with a cleaner version. > > Applying: kbuild: Introduce KBUILD_AUTOCONF variable for auto.conf include > Applying: kbuild: Introduce KCONFIG_AUTOCONFIGDEP variable for conf tool > Applying: perf tools: Kbuild builtin source related fixies > Applying: perf tools: Kbuild source related fixies > Applying: perf tools: Add kbuild support into Makefile.kbuild > Applying: perf kbuild: fix recursive invocation of config/features-checks > Applying: perf kbuild: store in config-detected missing variables (libdir, > ...) > Applying: perf kbuild: remove useless #ifdef directives > Applying: perf kbuild: fix a link issue if BUILTIN_TRACE is disabled > Applying: perf kbuild: add missing files and missing flags in Kbuild files > /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:30: trailing > whitespace. > CFLAGS_Context.o += -Wno-redundant-decls -Wno-strict-prototypes > /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:137: trailing > whitespace. > CFLAGS_trace-event-perl.o += -Wno-redundant-decls -Wno-strict-prototypes > /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:138: trailing > whitespace. > CFLAGS_trace-event-perl.o += -Wno-unused-parameter -Wno-shadow -Wno-undef > /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:143: trailing > whitespace. > CFLAGS_trace-event-python.o += -Wno-redundant-decls -Wno-strict-prototypes > warning: 4 lines applied after fixing whitespace errors. > Applying: perf kbuild: update kbuild files according to last changes > Applying: perf kbuild: remove legacy slang-related build variables > Applying: perf kbuild: remove legacy libaudit-related build variables > Applying: perf kbuild: remove legacy libgtk2-related build variables > /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:204: trailing > whitespace. > #else > warning: 1 line applied after fixing whitespace errors. > Applying: perf kbuild: remove legacy libperl-related build variables > Applying: perf kbuild: remove legacy timerfd-related build variable > Applying: perf kbuild: remove legacy demangle-related build variables > Applying: perf kbuild: remove legacy on_exit-related build variable > Applying: perf kbuild: remove legacy backtrace-related build variable > Applying: perf kbuild: remove legacy numa-related build variable > Applying: perf kbuild: remove legacy bionic-related build variable > Applying: perf kbuild: remove legacy libelf-related build variables (1st > part) > Applying: perf kbuild: remove legacy libelf-related build variables (2nd > part) > Applying: perf kbuild: remove legacy libdwarf-related build variables > /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:342: trailing > whitespace. > endif # CONFIG_LIBDWARF_UNWIND > warning: 1 line applied after fixing whitespace errors. > Applying: perf kbuild: remove legacy libunwind-related build variables > Applying: perf kbuild: remove legacy libpython-related build variable > Applying: perf kbuild: add generated Kconfig build-test cases > Applying: perf kbuild: fix installation of traceevent plugins > /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:74: trailing > whitespace. > make_pure := > warning: 1 line applied after fixing whitespace errors. > Applying: perf kbuild: fix tarpkg target in tests/make > Applying: perf kbuild: update Kbuild files with new and removed sources > Applying: perf kbuild: update build test configurations > /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:773: trailing > whitespace. > > warning: 1 line applied after fixing whitespace errors. > Applying: perf kbuild: relocate the configs generating script > Applying: perf kbuild: minor changes > Applying: perf kbuild: remove Makefile.perf > > David > Alexis. -- To unsubscribe from this list: send the line
Re: [PATCH 00/34] perf and kconfig / kbuild
Hello, Sorry for the late reply, On Wed, May 14, 2014 at 4:15 AM, David Ahern dsah...@gmail.com wrote: On 5/13/14, 4:02 PM, Alexis Berlemont wrote: Hello, A few months ago, I tried to make a proposal to introduce Kconfig in perf's generation procedure. (cf. https://lkml.org/lkml/2013/12/20/511) I started from David Ahern's work; I was not aware that Jiri Olsa pushed further the idea and proposed an alternative which integrated kbuild too. So, here is another proposal based on Jiri Olsa work (from April 2013). * Most of the NO_* and HAVE_* makefile variables were removed on behalf of Kconfig's ones (CONFIG_*); perf source code was modified accordingly; * These changes make the glue files tools/perf/config/Makefile.fix-* useless * The build test cases now relies on generated configuration files (in tools/perf/tests/configs); Thanks for picking this up. I skimmed through all of the patches and conceptually looks good. I doubt I will have time for a detailed review any time soon. Looks like they apply to Linus' top of tree but with a few errors -- see below. You should always run checkpatch.pl before sending out: Sorry, I indeed did not run checkpatch. I will come back with a cleaner version. Applying: kbuild: Introduce KBUILD_AUTOCONF variable for auto.conf include Applying: kbuild: Introduce KCONFIG_AUTOCONFIGDEP variable for conf tool Applying: perf tools: Kbuild builtin source related fixies Applying: perf tools: Kbuild source related fixies Applying: perf tools: Add kbuild support into Makefile.kbuild Applying: perf kbuild: fix recursive invocation of config/features-checks Applying: perf kbuild: store in config-detected missing variables (libdir, ...) Applying: perf kbuild: remove useless #ifdef directives Applying: perf kbuild: fix a link issue if BUILTIN_TRACE is disabled Applying: perf kbuild: add missing files and missing flags in Kbuild files /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:30: trailing whitespace. CFLAGS_Context.o += -Wno-redundant-decls -Wno-strict-prototypes /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:137: trailing whitespace. CFLAGS_trace-event-perl.o += -Wno-redundant-decls -Wno-strict-prototypes /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:138: trailing whitespace. CFLAGS_trace-event-perl.o += -Wno-unused-parameter -Wno-shadow -Wno-undef /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:143: trailing whitespace. CFLAGS_trace-event-python.o += -Wno-redundant-decls -Wno-strict-prototypes warning: 4 lines applied after fixing whitespace errors. Applying: perf kbuild: update kbuild files according to last changes Applying: perf kbuild: remove legacy slang-related build variables Applying: perf kbuild: remove legacy libaudit-related build variables Applying: perf kbuild: remove legacy libgtk2-related build variables /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:204: trailing whitespace. #else warning: 1 line applied after fixing whitespace errors. Applying: perf kbuild: remove legacy libperl-related build variables Applying: perf kbuild: remove legacy timerfd-related build variable Applying: perf kbuild: remove legacy demangle-related build variables Applying: perf kbuild: remove legacy on_exit-related build variable Applying: perf kbuild: remove legacy backtrace-related build variable Applying: perf kbuild: remove legacy numa-related build variable Applying: perf kbuild: remove legacy bionic-related build variable Applying: perf kbuild: remove legacy libelf-related build variables (1st part) Applying: perf kbuild: remove legacy libelf-related build variables (2nd part) Applying: perf kbuild: remove legacy libdwarf-related build variables /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:342: trailing whitespace. endif # CONFIG_LIBDWARF_UNWIND warning: 1 line applied after fixing whitespace errors. Applying: perf kbuild: remove legacy libunwind-related build variables Applying: perf kbuild: remove legacy libpython-related build variable Applying: perf kbuild: add generated Kconfig build-test cases Applying: perf kbuild: fix installation of traceevent plugins /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:74: trailing whitespace. make_pure := warning: 1 line applied after fixing whitespace errors. Applying: perf kbuild: fix tarpkg target in tests/make Applying: perf kbuild: update Kbuild files with new and removed sources Applying: perf kbuild: update build test configurations /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:773: trailing whitespace. warning: 1 line applied after fixing whitespace errors. Applying: perf kbuild: relocate the configs generating script Applying: perf kbuild: minor changes Applying: perf kbuild: remove Makefile.perf David Alexis. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at
Re: [PATCH 00/34] perf and kconfig / kbuild
On Wed, May 14, 2014 at 12:02:55AM +0200, Alexis Berlemont wrote: > Hello, > > A few months ago, I tried to make a proposal to introduce Kconfig in > perf's generation procedure. > (cf. https://lkml.org/lkml/2013/12/20/511) > > I started from David Ahern's work; I was not aware that Jiri Olsa > pushed further the idea and proposed an alternative which integrated > kbuild too. hi, I'll try to review this till end of the week thanks, jirka > > So, here is another proposal based on Jiri Olsa work (from April 2013). > * Most of the NO_* and HAVE_* makefile variables were removed on > behalf of Kconfig's ones (CONFIG_*); perf source code was modified > accordingly; > * These changes make the glue files tools/perf/config/Makefile.fix-* useless > * The build test cases now relies on generated configuration files (in > tools/perf/tests/configs); > > Hope this helps, > > Alexis. > > Alexis Berlemont (29): > perf kbuild: fix recursive invocation of config/features-checks > perf kbuild: store in config-detected missing variables (libdir, ...) > perf kbuild: remove useless #ifdef directives > perf kbuild: fix a link issue if BUILTIN_TRACE is disabled > perf kbuild: add missing files and missing flags in Kbuild files > perf kbuild: update kbuild files according to last changes > perf kbuild: remove legacy slang-related build variables > perf kbuild: remove legacy libaudit-related build variables > perf kbuild: remove legacy libgtk2-related build variables > perf kbuild: remove legacy libperl-related build variables > perf kbuild: remove legacy timerfd-related build variable > perf kbuild: remove legacy demangle-related build variables > perf kbuild: remove legacy on_exit-related build variable > perf kbuild: remove legacy backtrace-related build variable > perf kbuild: remove legacy numa-related build variable > perf kbuild: remove legacy bionic-related build variable > perf kbuild: remove legacy libelf-related build variables (1st part) > perf kbuild: remove legacy libelf-related build variables (2nd part) > perf kbuild: remove legacy libdwarf-related build variables > perf kbuild: remove legacy libunwind-related build variables > perf kbuild: remove legacy libpython-related build variable > perf kbuild: add generated Kconfig build-test cases > perf kbuild: fix installation of traceevent plugins > perf kbuild: fix tarpkg target in tests/make > perf kbuild: update Kbuild files with new and removed sources > perf kbuild: update build test configurations > perf kbuild: relocate the configs generating script > perf kbuild: minor changes > perf kbuild: remove Makefile.perf > > Jiri Olsa (5): > kbuild: Introduce KBUILD_AUTOCONF variable for auto.conf include > kbuild: Introduce KCONFIG_AUTOCONFIGDEP variable for conf tool > perf tools: Kbuild builtin source related fixies > perf tools: Kbuild source related fixies > perf tools: Add kbuild support into Makefile.kbuild > > scripts/Makefile.build | 3 +- > scripts/kconfig/confdata.c | 11 +- > scripts/kconfig/lkc.h | 1 + > tools/perf/Kbuild | 47 ++ > tools/perf/Kconfig | 370 > tools/perf/MANIFEST| 1 + > tools/perf/Makefile| 2 +- > tools/perf/Makefile.kbuild | 414 + > tools/perf/Makefile.perf | 930 > - > tools/perf/arch/Kbuild | 3 + > tools/perf/arch/arm/Makefile | 4 +- > tools/perf/arch/powerpc/Makefile | 2 +- > tools/perf/arch/s390/Makefile | 2 +- > tools/perf/arch/sh/Makefile| 2 +- > tools/perf/arch/sparc/Makefile | 2 +- > tools/perf/arch/x86/Kbuild | 2 + > tools/perf/arch/x86/Makefile | 8 +- > tools/perf/arch/x86/tests/Kbuild | 2 + > tools/perf/arch/x86/util/Kbuild| 5 + > tools/perf/bench/Kbuild| 12 + > tools/perf/builtin-annotate.c | 8 +- > tools/perf/builtin-bench.c | 5 +- > tools/perf/builtin-cmds.h | 31 + > tools/perf/builtin-help.c | 1 + > tools/perf/builtin-inject.c| 2 +- > tools/perf/builtin-kvm.c | 32 +- > tools/perf/builtin-lock.c | 4 +- > to
Re: [PATCH 00/34] perf and kconfig / kbuild
On Wed, May 14, 2014 at 12:02:55AM +0200, Alexis Berlemont wrote: Hello, A few months ago, I tried to make a proposal to introduce Kconfig in perf's generation procedure. (cf. https://lkml.org/lkml/2013/12/20/511) I started from David Ahern's work; I was not aware that Jiri Olsa pushed further the idea and proposed an alternative which integrated kbuild too. hi, I'll try to review this till end of the week thanks, jirka So, here is another proposal based on Jiri Olsa work (from April 2013). * Most of the NO_* and HAVE_* makefile variables were removed on behalf of Kconfig's ones (CONFIG_*); perf source code was modified accordingly; * These changes make the glue files tools/perf/config/Makefile.fix-* useless * The build test cases now relies on generated configuration files (in tools/perf/tests/configs); Hope this helps, Alexis. Alexis Berlemont (29): perf kbuild: fix recursive invocation of config/features-checks perf kbuild: store in config-detected missing variables (libdir, ...) perf kbuild: remove useless #ifdef directives perf kbuild: fix a link issue if BUILTIN_TRACE is disabled perf kbuild: add missing files and missing flags in Kbuild files perf kbuild: update kbuild files according to last changes perf kbuild: remove legacy slang-related build variables perf kbuild: remove legacy libaudit-related build variables perf kbuild: remove legacy libgtk2-related build variables perf kbuild: remove legacy libperl-related build variables perf kbuild: remove legacy timerfd-related build variable perf kbuild: remove legacy demangle-related build variables perf kbuild: remove legacy on_exit-related build variable perf kbuild: remove legacy backtrace-related build variable perf kbuild: remove legacy numa-related build variable perf kbuild: remove legacy bionic-related build variable perf kbuild: remove legacy libelf-related build variables (1st part) perf kbuild: remove legacy libelf-related build variables (2nd part) perf kbuild: remove legacy libdwarf-related build variables perf kbuild: remove legacy libunwind-related build variables perf kbuild: remove legacy libpython-related build variable perf kbuild: add generated Kconfig build-test cases perf kbuild: fix installation of traceevent plugins perf kbuild: fix tarpkg target in tests/make perf kbuild: update Kbuild files with new and removed sources perf kbuild: update build test configurations perf kbuild: relocate the configs generating script perf kbuild: minor changes perf kbuild: remove Makefile.perf Jiri Olsa (5): kbuild: Introduce KBUILD_AUTOCONF variable for auto.conf include kbuild: Introduce KCONFIG_AUTOCONFIGDEP variable for conf tool perf tools: Kbuild builtin source related fixies perf tools: Kbuild source related fixies perf tools: Add kbuild support into Makefile.kbuild scripts/Makefile.build | 3 +- scripts/kconfig/confdata.c | 11 +- scripts/kconfig/lkc.h | 1 + tools/perf/Kbuild | 47 ++ tools/perf/Kconfig | 370 tools/perf/MANIFEST| 1 + tools/perf/Makefile| 2 +- tools/perf/Makefile.kbuild | 414 + tools/perf/Makefile.perf | 930 - tools/perf/arch/Kbuild | 3 + tools/perf/arch/arm/Makefile | 4 +- tools/perf/arch/powerpc/Makefile | 2 +- tools/perf/arch/s390/Makefile | 2 +- tools/perf/arch/sh/Makefile| 2 +- tools/perf/arch/sparc/Makefile | 2 +- tools/perf/arch/x86/Kbuild | 2 + tools/perf/arch/x86/Makefile | 8 +- tools/perf/arch/x86/tests/Kbuild | 2 + tools/perf/arch/x86/util/Kbuild| 5 + tools/perf/bench/Kbuild| 12 + tools/perf/builtin-annotate.c | 8 +- tools/perf/builtin-bench.c | 5 +- tools/perf/builtin-cmds.h | 31 + tools/perf/builtin-help.c | 1 + tools/perf/builtin-inject.c| 2 +- tools/perf/builtin-kvm.c | 32 +- tools/perf/builtin-lock.c | 4 +- tools/perf/builtin-mem.c | 3 +- tools/perf/builtin-probe.c | 15 +- tools/perf/builtin-record.c| 14 +- tools/perf/builtin-report.c| 3 + tools/perf/builtin-sched.c | 2 + tools/perf/builtin-script.c| 6
Re: [PATCH 00/34] perf and kconfig / kbuild
On 5/13/14, 4:02 PM, Alexis Berlemont wrote: Hello, A few months ago, I tried to make a proposal to introduce Kconfig in perf's generation procedure. (cf. https://lkml.org/lkml/2013/12/20/511) I started from David Ahern's work; I was not aware that Jiri Olsa pushed further the idea and proposed an alternative which integrated kbuild too. So, here is another proposal based on Jiri Olsa work (from April 2013). * Most of the NO_* and HAVE_* makefile variables were removed on behalf of Kconfig's ones (CONFIG_*); perf source code was modified accordingly; * These changes make the glue files tools/perf/config/Makefile.fix-* useless * The build test cases now relies on generated configuration files (in tools/perf/tests/configs); Thanks for picking this up. I skimmed through all of the patches and conceptually looks good. I doubt I will have time for a detailed review any time soon. Looks like they apply to Linus' top of tree but with a few errors -- see below. You should always run checkpatch.pl before sending out: Applying: kbuild: Introduce KBUILD_AUTOCONF variable for auto.conf include Applying: kbuild: Introduce KCONFIG_AUTOCONFIGDEP variable for conf tool Applying: perf tools: Kbuild builtin source related fixies Applying: perf tools: Kbuild source related fixies Applying: perf tools: Add kbuild support into Makefile.kbuild Applying: perf kbuild: fix recursive invocation of config/features-checks Applying: perf kbuild: store in config-detected missing variables (libdir, ...) Applying: perf kbuild: remove useless #ifdef directives Applying: perf kbuild: fix a link issue if BUILTIN_TRACE is disabled Applying: perf kbuild: add missing files and missing flags in Kbuild files /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:30: trailing whitespace. CFLAGS_Context.o += -Wno-redundant-decls -Wno-strict-prototypes /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:137: trailing whitespace. CFLAGS_trace-event-perl.o += -Wno-redundant-decls -Wno-strict-prototypes /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:138: trailing whitespace. CFLAGS_trace-event-perl.o += -Wno-unused-parameter -Wno-shadow -Wno-undef /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:143: trailing whitespace. CFLAGS_trace-event-python.o += -Wno-redundant-decls -Wno-strict-prototypes warning: 4 lines applied after fixing whitespace errors. Applying: perf kbuild: update kbuild files according to last changes Applying: perf kbuild: remove legacy slang-related build variables Applying: perf kbuild: remove legacy libaudit-related build variables Applying: perf kbuild: remove legacy libgtk2-related build variables /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:204: trailing whitespace. #else warning: 1 line applied after fixing whitespace errors. Applying: perf kbuild: remove legacy libperl-related build variables Applying: perf kbuild: remove legacy timerfd-related build variable Applying: perf kbuild: remove legacy demangle-related build variables Applying: perf kbuild: remove legacy on_exit-related build variable Applying: perf kbuild: remove legacy backtrace-related build variable Applying: perf kbuild: remove legacy numa-related build variable Applying: perf kbuild: remove legacy bionic-related build variable Applying: perf kbuild: remove legacy libelf-related build variables (1st part) Applying: perf kbuild: remove legacy libelf-related build variables (2nd part) Applying: perf kbuild: remove legacy libdwarf-related build variables /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:342: trailing whitespace. endif # CONFIG_LIBDWARF_UNWIND warning: 1 line applied after fixing whitespace errors. Applying: perf kbuild: remove legacy libunwind-related build variables Applying: perf kbuild: remove legacy libpython-related build variable Applying: perf kbuild: add generated Kconfig build-test cases Applying: perf kbuild: fix installation of traceevent plugins /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:74: trailing whitespace. make_pure := warning: 1 line applied after fixing whitespace errors. Applying: perf kbuild: fix tarpkg target in tests/make Applying: perf kbuild: update Kbuild files with new and removed sources Applying: perf kbuild: update build test configurations /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:773: trailing whitespace. warning: 1 line applied after fixing whitespace errors. Applying: perf kbuild: relocate the configs generating script Applying: perf kbuild: minor changes Applying: perf kbuild: remove Makefile.perf David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 00/34] perf and kconfig / kbuild
Hello, A few months ago, I tried to make a proposal to introduce Kconfig in perf's generation procedure. (cf. https://lkml.org/lkml/2013/12/20/511) I started from David Ahern's work; I was not aware that Jiri Olsa pushed further the idea and proposed an alternative which integrated kbuild too. So, here is another proposal based on Jiri Olsa work (from April 2013). * Most of the NO_* and HAVE_* makefile variables were removed on behalf of Kconfig's ones (CONFIG_*); perf source code was modified accordingly; * These changes make the glue files tools/perf/config/Makefile.fix-* useless * The build test cases now relies on generated configuration files (in tools/perf/tests/configs); Hope this helps, Alexis. Alexis Berlemont (29): perf kbuild: fix recursive invocation of config/features-checks perf kbuild: store in config-detected missing variables (libdir, ...) perf kbuild: remove useless #ifdef directives perf kbuild: fix a link issue if BUILTIN_TRACE is disabled perf kbuild: add missing files and missing flags in Kbuild files perf kbuild: update kbuild files according to last changes perf kbuild: remove legacy slang-related build variables perf kbuild: remove legacy libaudit-related build variables perf kbuild: remove legacy libgtk2-related build variables perf kbuild: remove legacy libperl-related build variables perf kbuild: remove legacy timerfd-related build variable perf kbuild: remove legacy demangle-related build variables perf kbuild: remove legacy on_exit-related build variable perf kbuild: remove legacy backtrace-related build variable perf kbuild: remove legacy numa-related build variable perf kbuild: remove legacy bionic-related build variable perf kbuild: remove legacy libelf-related build variables (1st part) perf kbuild: remove legacy libelf-related build variables (2nd part) perf kbuild: remove legacy libdwarf-related build variables perf kbuild: remove legacy libunwind-related build variables perf kbuild: remove legacy libpython-related build variable perf kbuild: add generated Kconfig build-test cases perf kbuild: fix installation of traceevent plugins perf kbuild: fix tarpkg target in tests/make perf kbuild: update Kbuild files with new and removed sources perf kbuild: update build test configurations perf kbuild: relocate the configs generating script perf kbuild: minor changes perf kbuild: remove Makefile.perf Jiri Olsa (5): kbuild: Introduce KBUILD_AUTOCONF variable for auto.conf include kbuild: Introduce KCONFIG_AUTOCONFIGDEP variable for conf tool perf tools: Kbuild builtin source related fixies perf tools: Kbuild source related fixies perf tools: Add kbuild support into Makefile.kbuild scripts/Makefile.build | 3 +- scripts/kconfig/confdata.c | 11 +- scripts/kconfig/lkc.h | 1 + tools/perf/Kbuild | 47 ++ tools/perf/Kconfig | 370 tools/perf/MANIFEST| 1 + tools/perf/Makefile| 2 +- tools/perf/Makefile.kbuild | 414 + tools/perf/Makefile.perf | 930 - tools/perf/arch/Kbuild | 3 + tools/perf/arch/arm/Makefile | 4 +- tools/perf/arch/powerpc/Makefile | 2 +- tools/perf/arch/s390/Makefile | 2 +- tools/perf/arch/sh/Makefile| 2 +- tools/perf/arch/sparc/Makefile | 2 +- tools/perf/arch/x86/Kbuild | 2 + tools/perf/arch/x86/Makefile | 8 +- tools/perf/arch/x86/tests/Kbuild | 2 + tools/perf/arch/x86/util/Kbuild| 5 + tools/perf/bench/Kbuild| 12 + tools/perf/builtin-annotate.c | 8 +- tools/perf/builtin-bench.c | 5 +- tools/perf/builtin-cmds.h | 31 + tools/perf/builtin-help.c | 1 + tools/perf/builtin-inject.c| 2 +- tools/perf/builtin-kvm.c | 32 +- tools/perf/builtin-lock.c | 4 +- tools/perf/builtin-mem.c | 3 +- tools/perf/builtin-probe.c | 15 +- tools/perf/builtin-record.c| 14 +- tools/perf/builtin-report.c| 3 + tools/perf/builtin-sched.c | 2 + tools/perf/builtin-script.c| 6 +- tools/perf/builtin-top.c | 15 +- tools/perf/config/Makefile | 397 + tools/perf/config/defconfig| 54 ++ tools/perf/perf.c
[PATCH 00/34] perf and kconfig / kbuild
Hello, A few months ago, I tried to make a proposal to introduce Kconfig in perf's generation procedure. (cf. https://lkml.org/lkml/2013/12/20/511) I started from David Ahern's work; I was not aware that Jiri Olsa pushed further the idea and proposed an alternative which integrated kbuild too. So, here is another proposal based on Jiri Olsa work (from April 2013). * Most of the NO_* and HAVE_* makefile variables were removed on behalf of Kconfig's ones (CONFIG_*); perf source code was modified accordingly; * These changes make the glue files tools/perf/config/Makefile.fix-* useless * The build test cases now relies on generated configuration files (in tools/perf/tests/configs); Hope this helps, Alexis. Alexis Berlemont (29): perf kbuild: fix recursive invocation of config/features-checks perf kbuild: store in config-detected missing variables (libdir, ...) perf kbuild: remove useless #ifdef directives perf kbuild: fix a link issue if BUILTIN_TRACE is disabled perf kbuild: add missing files and missing flags in Kbuild files perf kbuild: update kbuild files according to last changes perf kbuild: remove legacy slang-related build variables perf kbuild: remove legacy libaudit-related build variables perf kbuild: remove legacy libgtk2-related build variables perf kbuild: remove legacy libperl-related build variables perf kbuild: remove legacy timerfd-related build variable perf kbuild: remove legacy demangle-related build variables perf kbuild: remove legacy on_exit-related build variable perf kbuild: remove legacy backtrace-related build variable perf kbuild: remove legacy numa-related build variable perf kbuild: remove legacy bionic-related build variable perf kbuild: remove legacy libelf-related build variables (1st part) perf kbuild: remove legacy libelf-related build variables (2nd part) perf kbuild: remove legacy libdwarf-related build variables perf kbuild: remove legacy libunwind-related build variables perf kbuild: remove legacy libpython-related build variable perf kbuild: add generated Kconfig build-test cases perf kbuild: fix installation of traceevent plugins perf kbuild: fix tarpkg target in tests/make perf kbuild: update Kbuild files with new and removed sources perf kbuild: update build test configurations perf kbuild: relocate the configs generating script perf kbuild: minor changes perf kbuild: remove Makefile.perf Jiri Olsa (5): kbuild: Introduce KBUILD_AUTOCONF variable for auto.conf include kbuild: Introduce KCONFIG_AUTOCONFIGDEP variable for conf tool perf tools: Kbuild builtin source related fixies perf tools: Kbuild source related fixies perf tools: Add kbuild support into Makefile.kbuild scripts/Makefile.build | 3 +- scripts/kconfig/confdata.c | 11 +- scripts/kconfig/lkc.h | 1 + tools/perf/Kbuild | 47 ++ tools/perf/Kconfig | 370 tools/perf/MANIFEST| 1 + tools/perf/Makefile| 2 +- tools/perf/Makefile.kbuild | 414 + tools/perf/Makefile.perf | 930 - tools/perf/arch/Kbuild | 3 + tools/perf/arch/arm/Makefile | 4 +- tools/perf/arch/powerpc/Makefile | 2 +- tools/perf/arch/s390/Makefile | 2 +- tools/perf/arch/sh/Makefile| 2 +- tools/perf/arch/sparc/Makefile | 2 +- tools/perf/arch/x86/Kbuild | 2 + tools/perf/arch/x86/Makefile | 8 +- tools/perf/arch/x86/tests/Kbuild | 2 + tools/perf/arch/x86/util/Kbuild| 5 + tools/perf/bench/Kbuild| 12 + tools/perf/builtin-annotate.c | 8 +- tools/perf/builtin-bench.c | 5 +- tools/perf/builtin-cmds.h | 31 + tools/perf/builtin-help.c | 1 + tools/perf/builtin-inject.c| 2 +- tools/perf/builtin-kvm.c | 32 +- tools/perf/builtin-lock.c | 4 +- tools/perf/builtin-mem.c | 3 +- tools/perf/builtin-probe.c | 15 +- tools/perf/builtin-record.c| 14 +- tools/perf/builtin-report.c| 3 + tools/perf/builtin-sched.c | 2 + tools/perf/builtin-script.c| 6 +- tools/perf/builtin-top.c | 15 +- tools/perf/config/Makefile | 397 + tools/perf/config/defconfig| 54 ++ tools/perf/perf.c
Re: [PATCH 00/34] perf and kconfig / kbuild
On 5/13/14, 4:02 PM, Alexis Berlemont wrote: Hello, A few months ago, I tried to make a proposal to introduce Kconfig in perf's generation procedure. (cf. https://lkml.org/lkml/2013/12/20/511) I started from David Ahern's work; I was not aware that Jiri Olsa pushed further the idea and proposed an alternative which integrated kbuild too. So, here is another proposal based on Jiri Olsa work (from April 2013). * Most of the NO_* and HAVE_* makefile variables were removed on behalf of Kconfig's ones (CONFIG_*); perf source code was modified accordingly; * These changes make the glue files tools/perf/config/Makefile.fix-* useless * The build test cases now relies on generated configuration files (in tools/perf/tests/configs); Thanks for picking this up. I skimmed through all of the patches and conceptually looks good. I doubt I will have time for a detailed review any time soon. Looks like they apply to Linus' top of tree but with a few errors -- see below. You should always run checkpatch.pl before sending out: Applying: kbuild: Introduce KBUILD_AUTOCONF variable for auto.conf include Applying: kbuild: Introduce KCONFIG_AUTOCONFIGDEP variable for conf tool Applying: perf tools: Kbuild builtin source related fixies Applying: perf tools: Kbuild source related fixies Applying: perf tools: Add kbuild support into Makefile.kbuild Applying: perf kbuild: fix recursive invocation of config/features-checks Applying: perf kbuild: store in config-detected missing variables (libdir, ...) Applying: perf kbuild: remove useless #ifdef directives Applying: perf kbuild: fix a link issue if BUILTIN_TRACE is disabled Applying: perf kbuild: add missing files and missing flags in Kbuild files /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:30: trailing whitespace. CFLAGS_Context.o += -Wno-redundant-decls -Wno-strict-prototypes /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:137: trailing whitespace. CFLAGS_trace-event-perl.o += -Wno-redundant-decls -Wno-strict-prototypes /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:138: trailing whitespace. CFLAGS_trace-event-perl.o += -Wno-unused-parameter -Wno-shadow -Wno-undef /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:143: trailing whitespace. CFLAGS_trace-event-python.o += -Wno-redundant-decls -Wno-strict-prototypes warning: 4 lines applied after fixing whitespace errors. Applying: perf kbuild: update kbuild files according to last changes Applying: perf kbuild: remove legacy slang-related build variables Applying: perf kbuild: remove legacy libaudit-related build variables Applying: perf kbuild: remove legacy libgtk2-related build variables /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:204: trailing whitespace. #else warning: 1 line applied after fixing whitespace errors. Applying: perf kbuild: remove legacy libperl-related build variables Applying: perf kbuild: remove legacy timerfd-related build variable Applying: perf kbuild: remove legacy demangle-related build variables Applying: perf kbuild: remove legacy on_exit-related build variable Applying: perf kbuild: remove legacy backtrace-related build variable Applying: perf kbuild: remove legacy numa-related build variable Applying: perf kbuild: remove legacy bionic-related build variable Applying: perf kbuild: remove legacy libelf-related build variables (1st part) Applying: perf kbuild: remove legacy libelf-related build variables (2nd part) Applying: perf kbuild: remove legacy libdwarf-related build variables /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:342: trailing whitespace. endif # CONFIG_LIBDWARF_UNWIND warning: 1 line applied after fixing whitespace errors. Applying: perf kbuild: remove legacy libunwind-related build variables Applying: perf kbuild: remove legacy libpython-related build variable Applying: perf kbuild: add generated Kconfig build-test cases Applying: perf kbuild: fix installation of traceevent plugins /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:74: trailing whitespace. make_pure := warning: 1 line applied after fixing whitespace errors. Applying: perf kbuild: fix tarpkg target in tests/make Applying: perf kbuild: update Kbuild files with new and removed sources Applying: perf kbuild: update build test configurations /Users/dsa/sw/perf/ahern.git/.git/rebase-apply/patch:773: trailing whitespace. warning: 1 line applied after fixing whitespace errors. Applying: perf kbuild: relocate the configs generating script Applying: perf kbuild: minor changes Applying: perf kbuild: remove Makefile.perf David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v4 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
Signed-off-by: Cody P Schafer --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/pseries/Kconfig | 12 2 files changed, 14 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..f9c083a 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o + obj-$(CONFIG_PPC64)+= $(obj64-y) obj-$(CONFIG_PPC32)+= $(obj32-y) diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig index 80b1d57..2cb8b77 100644 --- a/arch/powerpc/platforms/pseries/Kconfig +++ b/arch/powerpc/platforms/pseries/Kconfig @@ -111,6 +111,18 @@ config CMM will be reused for other LPARs. The interface allows firmware to balance memory across many LPARs. +config HV_PERF_CTRS + bool "Hypervisor supplied PMU events (24x7 & GPCI)" + default y + depends on PERF_EVENTS && PPC_PSERIES + help + Enable access to hypervisor supplied counters in perf. Currently, + this enables code that uses the hcall GetPerfCounterInfo and 24x7 + interfaces to retrieve counters. GPCI exists on Power 6 and later + systems. 24x7 is available on Power 8 systems. + + If unsure, select Y. + config DTL bool "Dispatch Trace Log" depends on PPC_SPLPAR && DEBUG_FS -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v4 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/pseries/Kconfig | 12 2 files changed, 14 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..f9c083a 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o + obj-$(CONFIG_PPC64)+= $(obj64-y) obj-$(CONFIG_PPC32)+= $(obj32-y) diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig index 80b1d57..2cb8b77 100644 --- a/arch/powerpc/platforms/pseries/Kconfig +++ b/arch/powerpc/platforms/pseries/Kconfig @@ -111,6 +111,18 @@ config CMM will be reused for other LPARs. The interface allows firmware to balance memory across many LPARs. +config HV_PERF_CTRS + bool Hypervisor supplied PMU events (24x7 GPCI) + default y + depends on PERF_EVENTS PPC_PSERIES + help + Enable access to hypervisor supplied counters in perf. Currently, + this enables code that uses the hcall GetPerfCounterInfo and 24x7 + interfaces to retrieve counters. GPCI exists on Power 6 and later + systems. 24x7 is available on Power 8 systems. + + If unsure, select Y. + config DTL bool Dispatch Trace Log depends on PPC_SPLPAR DEBUG_FS -- 1.9.0 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
Signed-off-by: Cody P Schafer --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/pseries/Kconfig | 12 2 files changed, 14 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..f9c083a 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o + obj-$(CONFIG_PPC64)+= $(obj64-y) obj-$(CONFIG_PPC32)+= $(obj32-y) diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig index 80b1d57..2cb8b77 100644 --- a/arch/powerpc/platforms/pseries/Kconfig +++ b/arch/powerpc/platforms/pseries/Kconfig @@ -111,6 +111,18 @@ config CMM will be reused for other LPARs. The interface allows firmware to balance memory across many LPARs. +config HV_PERF_CTRS + bool "Hypervisor supplied PMU events (24x7 & GPCI)" + default y + depends on PERF_EVENTS && PPC_PSERIES + help + Enable access to hypervisor supplied counters in perf. Currently, + this enables code that uses the hcall GetPerfCounterInfo and 24x7 + interfaces to retrieve counters. GPCI exists on Power 6 and later + systems. 24x7 is available on Power 8 systems. + + If unsure, select Y. + config DTL bool "Dispatch Trace Log" depends on PPC_SPLPAR && DEBUG_FS -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v3 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/pseries/Kconfig | 12 2 files changed, 14 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..f9c083a 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o + obj-$(CONFIG_PPC64)+= $(obj64-y) obj-$(CONFIG_PPC32)+= $(obj32-y) diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig index 80b1d57..2cb8b77 100644 --- a/arch/powerpc/platforms/pseries/Kconfig +++ b/arch/powerpc/platforms/pseries/Kconfig @@ -111,6 +111,18 @@ config CMM will be reused for other LPARs. The interface allows firmware to balance memory across many LPARs. +config HV_PERF_CTRS + bool Hypervisor supplied PMU events (24x7 GPCI) + default y + depends on PERF_EVENTS PPC_PSERIES + help + Enable access to hypervisor supplied counters in perf. Currently, + this enables code that uses the hcall GetPerfCounterInfo and 24x7 + interfaces to retrieve counters. GPCI exists on Power 6 and later + systems. 24x7 is available on Power 8 systems. + + If unsure, select Y. + config DTL bool Dispatch Trace Log depends on PPC_SPLPAR DEBUG_FS -- 1.9.0 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
On Tue, 2014-02-25 at 13:31 -0800, Cody P Schafer wrote: > On 02/24/2014 07:33 PM, Michael Ellerman wrote: > > On Fri, 2014-14-02 at 22:02:14 UTC, Cody P Schafer wrote: > >> Signed-off-by: Cody P Schafer > >> --- > >> arch/powerpc/perf/Makefile | 2 ++ > >> arch/powerpc/platforms/Kconfig.cputype | 6 ++ > >> 2 files changed, 8 insertions(+) > >> > >> diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile > >> index 60d71ee..f9c083a 100644 > >> --- a/arch/powerpc/perf/Makefile > >> +++ b/arch/powerpc/perf/Makefile > >> @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS)+= mpc7450-pmu.o > >> obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o > >> obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o > >> > >> +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o > >> + > >> obj-$(CONFIG_PPC64) += $(obj64-y) > >> obj-$(CONFIG_PPC32) += $(obj32-y) > >> diff --git a/arch/powerpc/platforms/Kconfig.cputype > >> b/arch/powerpc/platforms/Kconfig.cputype > >> index 434fda3..dcc67cd 100644 > >> --- a/arch/powerpc/platforms/Kconfig.cputype > >> +++ b/arch/powerpc/platforms/Kconfig.cputype > >> @@ -364,6 +364,12 @@ config PPC_PERF_CTRS > >> help > >>This enables the powerpc-specific perf_event back-end. > >> > >> +config HV_PERF_CTRS > >> + def_bool y > > > > This was bool, why did you change it? > > No, it wasn't. v1 also had def_bool. https://lkml.org/lkml/2014/1/16/518 > Maybe you're confusing v2.1 and v2 of this patch? Er yes. Point releases of a patch series confuse me :) > >> + depends on PERF_EVENTS && PPC_HAVE_PMU_SUPPORT > > > > Should be: > > > > depends on PERF_EVENTS && PPC_PSERIES > > > >> + help > >> + Enable access to perf counters provided by the hypervisor > >> + > > Yep, the v2.1 patch (which I bungled and labeled as 9/11) already > changes both of these. > It'll end up rolled into v3. Yes please. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
On 02/24/2014 07:33 PM, Michael Ellerman wrote: On Fri, 2014-14-02 at 22:02:14 UTC, Cody P Schafer wrote: Signed-off-by: Cody P Schafer --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/Kconfig.cputype | 6 ++ 2 files changed, 8 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..f9c083a 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o + obj-$(CONFIG_PPC64) += $(obj64-y) obj-$(CONFIG_PPC32) += $(obj32-y) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 434fda3..dcc67cd 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -364,6 +364,12 @@ config PPC_PERF_CTRS help This enables the powerpc-specific perf_event back-end. +config HV_PERF_CTRS + def_bool y This was bool, why did you change it? No, it wasn't. v1 also had def_bool. https://lkml.org/lkml/2014/1/16/518 Maybe you're confusing v2.1 and v2 of this patch? + depends on PERF_EVENTS && PPC_HAVE_PMU_SUPPORT Should be: depends on PERF_EVENTS && PPC_PSERIES + help + Enable access to perf counters provided by the hypervisor + Yep, the v2.1 patch (which I bungled and labeled as 9/11) already changes both of these. It'll end up rolled into v3. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
On 02/24/2014 07:33 PM, Michael Ellerman wrote: On Fri, 2014-14-02 at 22:02:14 UTC, Cody P Schafer wrote: Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/Kconfig.cputype | 6 ++ 2 files changed, 8 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..f9c083a 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o + obj-$(CONFIG_PPC64) += $(obj64-y) obj-$(CONFIG_PPC32) += $(obj32-y) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 434fda3..dcc67cd 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -364,6 +364,12 @@ config PPC_PERF_CTRS help This enables the powerpc-specific perf_event back-end. +config HV_PERF_CTRS + def_bool y This was bool, why did you change it? No, it wasn't. v1 also had def_bool. https://lkml.org/lkml/2014/1/16/518 Maybe you're confusing v2.1 and v2 of this patch? + depends on PERF_EVENTS PPC_HAVE_PMU_SUPPORT Should be: depends on PERF_EVENTS PPC_PSERIES + help + Enable access to perf counters provided by the hypervisor + Yep, the v2.1 patch (which I bungled and labeled as 9/11) already changes both of these. It'll end up rolled into v3. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
On Tue, 2014-02-25 at 13:31 -0800, Cody P Schafer wrote: On 02/24/2014 07:33 PM, Michael Ellerman wrote: On Fri, 2014-14-02 at 22:02:14 UTC, Cody P Schafer wrote: Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/Kconfig.cputype | 6 ++ 2 files changed, 8 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..f9c083a 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS)+= mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o + obj-$(CONFIG_PPC64) += $(obj64-y) obj-$(CONFIG_PPC32) += $(obj32-y) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 434fda3..dcc67cd 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -364,6 +364,12 @@ config PPC_PERF_CTRS help This enables the powerpc-specific perf_event back-end. +config HV_PERF_CTRS + def_bool y This was bool, why did you change it? No, it wasn't. v1 also had def_bool. https://lkml.org/lkml/2014/1/16/518 Maybe you're confusing v2.1 and v2 of this patch? Er yes. Point releases of a patch series confuse me :) + depends on PERF_EVENTS PPC_HAVE_PMU_SUPPORT Should be: depends on PERF_EVENTS PPC_PSERIES + help + Enable access to perf counters provided by the hypervisor + Yep, the v2.1 patch (which I bungled and labeled as 9/11) already changes both of these. It'll end up rolled into v3. Yes please. cheers -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
On Fri, 2014-14-02 at 22:02:14 UTC, Cody P Schafer wrote: > Signed-off-by: Cody P Schafer > --- > arch/powerpc/perf/Makefile | 2 ++ > arch/powerpc/platforms/Kconfig.cputype | 6 ++ > 2 files changed, 8 insertions(+) > > diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile > index 60d71ee..f9c083a 100644 > --- a/arch/powerpc/perf/Makefile > +++ b/arch/powerpc/perf/Makefile > @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o > obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o > obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o > > +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o > + > obj-$(CONFIG_PPC64) += $(obj64-y) > obj-$(CONFIG_PPC32) += $(obj32-y) > diff --git a/arch/powerpc/platforms/Kconfig.cputype > b/arch/powerpc/platforms/Kconfig.cputype > index 434fda3..dcc67cd 100644 > --- a/arch/powerpc/platforms/Kconfig.cputype > +++ b/arch/powerpc/platforms/Kconfig.cputype > @@ -364,6 +364,12 @@ config PPC_PERF_CTRS > help > This enables the powerpc-specific perf_event back-end. > > +config HV_PERF_CTRS > + def_bool y This was bool, why did you change it? > + depends on PERF_EVENTS && PPC_HAVE_PMU_SUPPORT Should be: depends on PERF_EVENTS && PPC_PSERIES > + help > + Enable access to perf counters provided by the hypervisor > + cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
On Fri, 2014-14-02 at 22:02:14 UTC, Cody P Schafer wrote: Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/Kconfig.cputype | 6 ++ 2 files changed, 8 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..f9c083a 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o + obj-$(CONFIG_PPC64) += $(obj64-y) obj-$(CONFIG_PPC32) += $(obj32-y) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 434fda3..dcc67cd 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -364,6 +364,12 @@ config PPC_PERF_CTRS help This enables the powerpc-specific perf_event back-end. +config HV_PERF_CTRS + def_bool y This was bool, why did you change it? + depends on PERF_EVENTS PPC_HAVE_PMU_SUPPORT Should be: depends on PERF_EVENTS PPC_PSERIES + help + Enable access to perf counters provided by the hypervisor + cheers -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2.1 9/11] powerpc/perf: add kconfig option for hypervisor provided counters
Whoops, should be "[Patch v2.1 10/11]" -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2.1 9/11] powerpc/perf: add kconfig option for hypervisor provided counters
Signed-off-by: Cody P Schafer --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/pseries/Kconfig | 12 2 files changed, 14 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..f9c083a 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o + obj-$(CONFIG_PPC64)+= $(obj64-y) obj-$(CONFIG_PPC32)+= $(obj32-y) diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig index 80b1d57..2cb8b77 100644 --- a/arch/powerpc/platforms/pseries/Kconfig +++ b/arch/powerpc/platforms/pseries/Kconfig @@ -111,6 +111,18 @@ config CMM will be reused for other LPARs. The interface allows firmware to balance memory across many LPARs. +config HV_PERF_CTRS + bool "Hypervisor supplied PMU events (24x7 & GPCI)" + default y + depends on PERF_EVENTS && PPC_PSERIES + help + Enable access to hypervisor supplied counters in perf. Currently, + this enables code that uses the hcall GetPerfCounterInfo and 24x7 + interfaces to retrieve counters. GPCI exists on Power 6 and later + systems. 24x7 is available on Power 8 systems. + + If unsure, select Y. + config DTL bool "Dispatch Trace Log" depends on PPC_SPLPAR && DEBUG_FS -- 1.9.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2.1 9/11] powerpc/perf: add kconfig option for hypervisor provided counters
Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/pseries/Kconfig | 12 2 files changed, 14 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..f9c083a 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o + obj-$(CONFIG_PPC64)+= $(obj64-y) obj-$(CONFIG_PPC32)+= $(obj32-y) diff --git a/arch/powerpc/platforms/pseries/Kconfig b/arch/powerpc/platforms/pseries/Kconfig index 80b1d57..2cb8b77 100644 --- a/arch/powerpc/platforms/pseries/Kconfig +++ b/arch/powerpc/platforms/pseries/Kconfig @@ -111,6 +111,18 @@ config CMM will be reused for other LPARs. The interface allows firmware to balance memory across many LPARs. +config HV_PERF_CTRS + bool Hypervisor supplied PMU events (24x7 GPCI) + default y + depends on PERF_EVENTS PPC_PSERIES + help + Enable access to hypervisor supplied counters in perf. Currently, + this enables code that uses the hcall GetPerfCounterInfo and 24x7 + interfaces to retrieve counters. GPCI exists on Power 6 and later + systems. 24x7 is available on Power 8 systems. + + If unsure, select Y. + config DTL bool Dispatch Trace Log depends on PPC_SPLPAR DEBUG_FS -- 1.9.0 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2.1 9/11] powerpc/perf: add kconfig option for hypervisor provided counters
Whoops, should be [Patch v2.1 10/11] -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
On 02/16/2014 11:11 PM, Michael Ellerman wrote: On Fri, 2014-02-14 at 16:25 -0800, Cody P Schafer wrote: On Fri, Feb 14, 2014 at 04:32:13PM -0600, Scott Wood wrote: On Fri, 2014-02-14 at 14:02 -0800, Cody P Schafer wrote: diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 434fda3..dcc67cd 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -364,6 +364,12 @@ config PPC_PERF_CTRS help This enables the powerpc-specific perf_event back-end. +config HV_PERF_CTRS + def_bool y + depends on PERF_EVENTS && PPC_HAVE_PMU_SUPPORT + help + Enable access to perf counters provided by the hypervisor Please don't add default-y stuff that is platform-specific, and definitely point out that platform dependency in the config description -- I have to look elsewhere in the patchset to determine that this is for "Power Hypervisor". PPC_HAVE_PMU_SUPPORT is enabled by all 6xx builds, even for hardware like e300 that doesn't have PMU at all (it has the FSL embedded perfmon instead), much less this hv interface. And yes, PPC_PERF_CTRS has the same problem and should be fixed. :-) Yep, I just based this one on what PPC_PERF_CTRS was doing. How about the following: +config HV_PERF_CTRS + bool "Perf Hypervisor supplied counters" "Support for Hypervisor supplied PMU events (24x7 & GPCI)" ? Sounds good to me. + default y + depends on PERF_EVENTS && PPC_HAVE_PMU_SUPPORT && PPC_PSERIES I think you just want: depends on PERF_EVENTS && PPC_PSERIES Because you're adding two completely new PMUs, they're not a "struct power_pmu" backend for the existing powerpc PMU implementation. Ack. I'll fix this up in v3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
On 02/16/2014 11:11 PM, Michael Ellerman wrote: On Fri, 2014-02-14 at 16:25 -0800, Cody P Schafer wrote: On Fri, Feb 14, 2014 at 04:32:13PM -0600, Scott Wood wrote: On Fri, 2014-02-14 at 14:02 -0800, Cody P Schafer wrote: diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 434fda3..dcc67cd 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -364,6 +364,12 @@ config PPC_PERF_CTRS help This enables the powerpc-specific perf_event back-end. +config HV_PERF_CTRS + def_bool y + depends on PERF_EVENTS PPC_HAVE_PMU_SUPPORT + help + Enable access to perf counters provided by the hypervisor Please don't add default-y stuff that is platform-specific, and definitely point out that platform dependency in the config description -- I have to look elsewhere in the patchset to determine that this is for Power Hypervisor. PPC_HAVE_PMU_SUPPORT is enabled by all 6xx builds, even for hardware like e300 that doesn't have PMU at all (it has the FSL embedded perfmon instead), much less this hv interface. And yes, PPC_PERF_CTRS has the same problem and should be fixed. :-) Yep, I just based this one on what PPC_PERF_CTRS was doing. How about the following: +config HV_PERF_CTRS + bool Perf Hypervisor supplied counters Support for Hypervisor supplied PMU events (24x7 GPCI) ? Sounds good to me. + default y + depends on PERF_EVENTS PPC_HAVE_PMU_SUPPORT PPC_PSERIES I think you just want: depends on PERF_EVENTS PPC_PSERIES Because you're adding two completely new PMUs, they're not a struct power_pmu backend for the existing powerpc PMU implementation. Ack. I'll fix this up in v3 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
On Fri, 2014-02-14 at 16:25 -0800, Cody P Schafer wrote: > On Fri, Feb 14, 2014 at 04:32:13PM -0600, Scott Wood wrote: > > On Fri, 2014-02-14 at 14:02 -0800, Cody P Schafer wrote: > > > diff --git a/arch/powerpc/platforms/Kconfig.cputype > > > b/arch/powerpc/platforms/Kconfig.cputype > > > index 434fda3..dcc67cd 100644 > > > --- a/arch/powerpc/platforms/Kconfig.cputype > > > +++ b/arch/powerpc/platforms/Kconfig.cputype > > > @@ -364,6 +364,12 @@ config PPC_PERF_CTRS > > > help > > > This enables the powerpc-specific perf_event back-end. > > > > > > +config HV_PERF_CTRS > > > + def_bool y > > > + depends on PERF_EVENTS && PPC_HAVE_PMU_SUPPORT > > > + help > > > + Enable access to perf counters provided by the hypervisor > > > > Please don't add default-y stuff that is platform-specific, and > > definitely point out that platform dependency in the config description > > -- I have to look elsewhere in the patchset to determine that this is > > for "Power Hypervisor". PPC_HAVE_PMU_SUPPORT is enabled by all 6xx > > builds, even for hardware like e300 that doesn't have PMU at all (it has > > the FSL embedded perfmon instead), much less this hv interface. > > > > And yes, PPC_PERF_CTRS has the same problem and should be fixed. :-) > > Yep, I just based this one on what PPC_PERF_CTRS was doing. > > How about the following: > > +config HV_PERF_CTRS > + bool "Perf Hypervisor supplied counters" "Support for Hypervisor supplied PMU events (24x7 & GPCI)" ? > + default y > + depends on PERF_EVENTS && PPC_HAVE_PMU_SUPPORT && PPC_PSERIES I think you just want: depends on PERF_EVENTS && PPC_PSERIES Because you're adding two completely new PMUs, they're not a "struct power_pmu" backend for the existing powerpc PMU implementation. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
On Fri, 2014-02-14 at 16:25 -0800, Cody P Schafer wrote: On Fri, Feb 14, 2014 at 04:32:13PM -0600, Scott Wood wrote: On Fri, 2014-02-14 at 14:02 -0800, Cody P Schafer wrote: diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 434fda3..dcc67cd 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -364,6 +364,12 @@ config PPC_PERF_CTRS help This enables the powerpc-specific perf_event back-end. +config HV_PERF_CTRS + def_bool y + depends on PERF_EVENTS PPC_HAVE_PMU_SUPPORT + help + Enable access to perf counters provided by the hypervisor Please don't add default-y stuff that is platform-specific, and definitely point out that platform dependency in the config description -- I have to look elsewhere in the patchset to determine that this is for Power Hypervisor. PPC_HAVE_PMU_SUPPORT is enabled by all 6xx builds, even for hardware like e300 that doesn't have PMU at all (it has the FSL embedded perfmon instead), much less this hv interface. And yes, PPC_PERF_CTRS has the same problem and should be fixed. :-) Yep, I just based this one on what PPC_PERF_CTRS was doing. How about the following: +config HV_PERF_CTRS + bool Perf Hypervisor supplied counters Support for Hypervisor supplied PMU events (24x7 GPCI) ? + default y + depends on PERF_EVENTS PPC_HAVE_PMU_SUPPORT PPC_PSERIES I think you just want: depends on PERF_EVENTS PPC_PSERIES Because you're adding two completely new PMUs, they're not a struct power_pmu backend for the existing powerpc PMU implementation. cheers -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
On Fri, Feb 14, 2014 at 04:32:13PM -0600, Scott Wood wrote: > On Fri, 2014-02-14 at 14:02 -0800, Cody P Schafer wrote: > > Signed-off-by: Cody P Schafer > > --- > > arch/powerpc/perf/Makefile | 2 ++ > > arch/powerpc/platforms/Kconfig.cputype | 6 ++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile > > index 60d71ee..f9c083a 100644 > > --- a/arch/powerpc/perf/Makefile > > +++ b/arch/powerpc/perf/Makefile > > @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o > > obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o > > obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o > > > > +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o > > + > > obj-$(CONFIG_PPC64)+= $(obj64-y) > > obj-$(CONFIG_PPC32)+= $(obj32-y) > > diff --git a/arch/powerpc/platforms/Kconfig.cputype > > b/arch/powerpc/platforms/Kconfig.cputype > > index 434fda3..dcc67cd 100644 > > --- a/arch/powerpc/platforms/Kconfig.cputype > > +++ b/arch/powerpc/platforms/Kconfig.cputype > > @@ -364,6 +364,12 @@ config PPC_PERF_CTRS > > help > > This enables the powerpc-specific perf_event back-end. > > > > +config HV_PERF_CTRS > > + def_bool y > > + depends on PERF_EVENTS && PPC_HAVE_PMU_SUPPORT > > + help > > + Enable access to perf counters provided by the hypervisor > > Please don't add default-y stuff that is platform-specific, and > definitely point out that platform dependency in the config description > -- I have to look elsewhere in the patchset to determine that this is > for "Power Hypervisor". PPC_HAVE_PMU_SUPPORT is enabled by all 6xx > builds, even for hardware like e300 that doesn't have PMU at all (it has > the FSL embedded perfmon instead), much less this hv interface. > > And yes, PPC_PERF_CTRS has the same problem and should be fixed. :-) Yep, I just based this one on what PPC_PERF_CTRS was doing. How about the following: +config HV_PERF_CTRS + bool "Perf Hypervisor supplied counters" + default y + depends on PERF_EVENTS && PPC_HAVE_PMU_SUPPORT && PPC_PSERIES + help + Enable access to hypervisor supplied counters in perf. Currently, + this enables code that uses the hcall GetPerfCounterInfo and 24x7 + interfaces to retrieve counters. GPCI exists on Power 6 and later + systems. 24x7 is available on Power 8 systems. + + If unsure, select Y. And relocated to arch/powerpc/platforms/Kconfig (as this isn't really strictly "cputype" related). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
Signed-off-by: Cody P Schafer --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/Kconfig.cputype | 6 ++ 2 files changed, 8 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..f9c083a 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o + obj-$(CONFIG_PPC64)+= $(obj64-y) obj-$(CONFIG_PPC32)+= $(obj32-y) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 434fda3..dcc67cd 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -364,6 +364,12 @@ config PPC_PERF_CTRS help This enables the powerpc-specific perf_event back-end. +config HV_PERF_CTRS + def_bool y + depends on PERF_EVENTS && PPC_HAVE_PMU_SUPPORT + help + Enable access to perf counters provided by the hypervisor + config SMP depends on PPC_BOOK3S || PPC_BOOK3E || FSL_BOOKE || PPC_47x bool "Symmetric multi-processing support" -- 1.8.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/Kconfig.cputype | 6 ++ 2 files changed, 8 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..f9c083a 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o + obj-$(CONFIG_PPC64)+= $(obj64-y) obj-$(CONFIG_PPC32)+= $(obj32-y) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 434fda3..dcc67cd 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -364,6 +364,12 @@ config PPC_PERF_CTRS help This enables the powerpc-specific perf_event back-end. +config HV_PERF_CTRS + def_bool y + depends on PERF_EVENTS PPC_HAVE_PMU_SUPPORT + help + Enable access to perf counters provided by the hypervisor + config SMP depends on PPC_BOOK3S || PPC_BOOK3E || FSL_BOOKE || PPC_47x bool Symmetric multi-processing support -- 1.8.5.4 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 10/11] powerpc/perf: add kconfig option for hypervisor provided counters
On Fri, Feb 14, 2014 at 04:32:13PM -0600, Scott Wood wrote: On Fri, 2014-02-14 at 14:02 -0800, Cody P Schafer wrote: Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/Kconfig.cputype | 6 ++ 2 files changed, 8 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..f9c083a 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o hv-common.o + obj-$(CONFIG_PPC64)+= $(obj64-y) obj-$(CONFIG_PPC32)+= $(obj32-y) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 434fda3..dcc67cd 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -364,6 +364,12 @@ config PPC_PERF_CTRS help This enables the powerpc-specific perf_event back-end. +config HV_PERF_CTRS + def_bool y + depends on PERF_EVENTS PPC_HAVE_PMU_SUPPORT + help + Enable access to perf counters provided by the hypervisor Please don't add default-y stuff that is platform-specific, and definitely point out that platform dependency in the config description -- I have to look elsewhere in the patchset to determine that this is for Power Hypervisor. PPC_HAVE_PMU_SUPPORT is enabled by all 6xx builds, even for hardware like e300 that doesn't have PMU at all (it has the FSL embedded perfmon instead), much less this hv interface. And yes, PPC_PERF_CTRS has the same problem and should be fixed. :-) Yep, I just based this one on what PPC_PERF_CTRS was doing. How about the following: +config HV_PERF_CTRS + bool Perf Hypervisor supplied counters + default y + depends on PERF_EVENTS PPC_HAVE_PMU_SUPPORT PPC_PSERIES + help + Enable access to hypervisor supplied counters in perf. Currently, + this enables code that uses the hcall GetPerfCounterInfo and 24x7 + interfaces to retrieve counters. GPCI exists on Power 6 and later + systems. 24x7 is available on Power 8 systems. + + If unsure, select Y. And relocated to arch/powerpc/platforms/Kconfig (as this isn't really strictly cputype related). -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 8/8] powerpc/perf: add kconfig option for hypervisor provided counters
Signed-off-by: Cody P Schafer --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/Kconfig.cputype | 6 ++ 2 files changed, 8 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..5e5fcd2 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o + obj-$(CONFIG_PPC64)+= $(obj64-y) obj-$(CONFIG_PPC32)+= $(obj32-y) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index bca2465..f98ec61 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -363,6 +363,12 @@ config PPC_PERF_CTRS help This enables the powerpc-specific perf_event back-end. +config HV_PERF_CTRS + def_bool y + depends on PERF_EVENTS && PPC_HAVE_PMU_SUPPORT + help + Enable access to perf counters provided by the hypervisor + config SMP depends on PPC_BOOK3S || PPC_BOOK3E || FSL_BOOKE || PPC_47x bool "Symmetric multi-processing support" -- 1.8.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 8/8] powerpc/perf: add kconfig option for hypervisor provided counters
Signed-off-by: Cody P Schafer c...@linux.vnet.ibm.com --- arch/powerpc/perf/Makefile | 2 ++ arch/powerpc/platforms/Kconfig.cputype | 6 ++ 2 files changed, 8 insertions(+) diff --git a/arch/powerpc/perf/Makefile b/arch/powerpc/perf/Makefile index 60d71ee..5e5fcd2 100644 --- a/arch/powerpc/perf/Makefile +++ b/arch/powerpc/perf/Makefile @@ -11,5 +11,7 @@ obj32-$(CONFIG_PPC_PERF_CTRS) += mpc7450-pmu.o obj-$(CONFIG_FSL_EMB_PERF_EVENT) += core-fsl-emb.o obj-$(CONFIG_FSL_EMB_PERF_EVENT_E500) += e500-pmu.o e6500-pmu.o +obj-$(CONFIG_HV_PERF_CTRS) += hv-24x7.o hv-gpci.o + obj-$(CONFIG_PPC64)+= $(obj64-y) obj-$(CONFIG_PPC32)+= $(obj32-y) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index bca2465..f98ec61 100644 --- a/arch/powerpc/platforms/Kconfig.cputype +++ b/arch/powerpc/platforms/Kconfig.cputype @@ -363,6 +363,12 @@ config PPC_PERF_CTRS help This enables the powerpc-specific perf_event back-end. +config HV_PERF_CTRS + def_bool y + depends on PERF_EVENTS PPC_HAVE_PMU_SUPPORT + help + Enable access to perf counters provided by the hypervisor + config SMP depends on PPC_BOOK3S || PPC_BOOK3E || FSL_BOOKE || PPC_47x bool Symmetric multi-processing support -- 1.8.5.2 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: perf and Kconfig
Hi, I just checked your branch perf/kbuild9. Your work is far more elaborate than mine. In my branch, I just reused the *config targets so as to generate the files .config include/config/auto.conf(.cmd), ...; after that, I manually modified Makefile.perf with the variables CONFIG_* instead of using the whole Kbuild system. Thank you for your mail, it helped me a lot. Alexis. On Mon, Dec 23, 2013 at 12:54 PM, Jiri Olsa wrote: > On Fri, Dec 20, 2013 at 06:00:05PM -0700, David Ahern wrote: >> [adding perf maintainers] >> >> On 12/20/13, 5:39 PM, Alexis Berlemont wrote: >> >Hi, >> > >> >Here is a proposal of a small contribution which tries to fulfill the >> >task "Use Kconfig to allow selecting features and build minimal >> >version of perf,..." displayed on the todo page of the perf >> >wiki (https://perf.wiki.kernel.org/index.php/Todo). >> > >> >I tried to continue the work started by David Ahern >> >(https://github.com/dsahern/linux.git branch:perf-config). This >> >version relies on the features detection tests available in >> >linux/tools/perf/config/feature-checks so as to enable some >> >configuration options (at least by default). >> > >> >This little task is not complete; more Kconfig options should be added >> >for each perf tool (top, record, report, ...). >> > >> >I just wanted to ask whether you consider this proposal as interesting >> >enough for inclusion and if you are ok with the way it is implemented. >> > >> >The code is available here: https://github.com/aberlemont/linux.git >> >- branch: perf-config. >> >> I know Jiri has an attempt in his tree and there have been a few >> discussions since then as well. I'll take a look at it next week. I >> would like to see it completed; I just don't have the time to do it. > > hi, > my latest branch (out of sync for long time) for kbuild: > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git > perf/kbuild9 > > I'll check your changes ;-) > > jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: perf and Kconfig
Hi, I just checked your branch perf/kbuild9. Your work is far more elaborate than mine. In my branch, I just reused the *config targets so as to generate the files .config include/config/auto.conf(.cmd), ...; after that, I manually modified Makefile.perf with the variables CONFIG_* instead of using the whole Kbuild system. Thank you for your mail, it helped me a lot. Alexis. On Mon, Dec 23, 2013 at 12:54 PM, Jiri Olsa jo...@redhat.com wrote: On Fri, Dec 20, 2013 at 06:00:05PM -0700, David Ahern wrote: [adding perf maintainers] On 12/20/13, 5:39 PM, Alexis Berlemont wrote: Hi, Here is a proposal of a small contribution which tries to fulfill the task Use Kconfig to allow selecting features and build minimal version of perf,... displayed on the todo page of the perf wiki (https://perf.wiki.kernel.org/index.php/Todo). I tried to continue the work started by David Ahern (https://github.com/dsahern/linux.git branch:perf-config). This version relies on the features detection tests available in linux/tools/perf/config/feature-checks so as to enable some configuration options (at least by default). This little task is not complete; more Kconfig options should be added for each perf tool (top, record, report, ...). I just wanted to ask whether you consider this proposal as interesting enough for inclusion and if you are ok with the way it is implemented. The code is available here: https://github.com/aberlemont/linux.git - branch: perf-config. I know Jiri has an attempt in his tree and there have been a few discussions since then as well. I'll take a look at it next week. I would like to see it completed; I just don't have the time to do it. hi, my latest branch (out of sync for long time) for kbuild: git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/kbuild9 I'll check your changes ;-) jirka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: perf and Kconfig
On Fri, Dec 20, 2013 at 06:00:05PM -0700, David Ahern wrote: > [adding perf maintainers] > > On 12/20/13, 5:39 PM, Alexis Berlemont wrote: > >Hi, > > > >Here is a proposal of a small contribution which tries to fulfill the > >task "Use Kconfig to allow selecting features and build minimal > >version of perf,..." displayed on the todo page of the perf > >wiki (https://perf.wiki.kernel.org/index.php/Todo). > > > >I tried to continue the work started by David Ahern > >(https://github.com/dsahern/linux.git branch:perf-config). This > >version relies on the features detection tests available in > >linux/tools/perf/config/feature-checks so as to enable some > >configuration options (at least by default). > > > >This little task is not complete; more Kconfig options should be added > >for each perf tool (top, record, report, ...). > > > >I just wanted to ask whether you consider this proposal as interesting > >enough for inclusion and if you are ok with the way it is implemented. > > > >The code is available here: https://github.com/aberlemont/linux.git > >- branch: perf-config. > > I know Jiri has an attempt in his tree and there have been a few > discussions since then as well. I'll take a look at it next week. I > would like to see it completed; I just don't have the time to do it. hi, my latest branch (out of sync for long time) for kbuild: git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/kbuild9 I'll check your changes ;-) jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: perf and Kconfig
On Fri, Dec 20, 2013 at 06:00:05PM -0700, David Ahern wrote: [adding perf maintainers] On 12/20/13, 5:39 PM, Alexis Berlemont wrote: Hi, Here is a proposal of a small contribution which tries to fulfill the task Use Kconfig to allow selecting features and build minimal version of perf,... displayed on the todo page of the perf wiki (https://perf.wiki.kernel.org/index.php/Todo). I tried to continue the work started by David Ahern (https://github.com/dsahern/linux.git branch:perf-config). This version relies on the features detection tests available in linux/tools/perf/config/feature-checks so as to enable some configuration options (at least by default). This little task is not complete; more Kconfig options should be added for each perf tool (top, record, report, ...). I just wanted to ask whether you consider this proposal as interesting enough for inclusion and if you are ok with the way it is implemented. The code is available here: https://github.com/aberlemont/linux.git - branch: perf-config. I know Jiri has an attempt in his tree and there have been a few discussions since then as well. I'll take a look at it next week. I would like to see it completed; I just don't have the time to do it. hi, my latest branch (out of sync for long time) for kbuild: git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/kbuild9 I'll check your changes ;-) jirka -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: perf and Kconfig
On 12/20/13 16:39, Alexis Berlemont wrote: > Hi, > > Here is a proposal of a small contribution which tries to fulfill the > task "Use Kconfig to allow selecting features and build minimal > version of perf,..." displayed on the todo page of the perf > wiki (https://perf.wiki.kernel.org/index.php/Todo). > > I tried to continue the work started by David Ahern > (https://github.com/dsahern/linux.git branch:perf-config). This > version relies on the features detection tests available in > linux/tools/perf/config/feature-checks so as to enable some > configuration options (at least by default). > > This little task is not complete; more Kconfig options should be added > for each perf tool (top, record, report, ...). > > I just wanted to ask whether you consider this proposal as interesting > enough for inclusion and if you are ok with the way it is implemented. > > The code is available here: https://github.com/aberlemont/linux.git > - branch: perf-config. Hi, The correct way to have any code reviewed is to post the code (not a link to it) on the mailing list. thanks, -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: perf and Kconfig
[adding perf maintainers] On 12/20/13, 5:39 PM, Alexis Berlemont wrote: Hi, Here is a proposal of a small contribution which tries to fulfill the task "Use Kconfig to allow selecting features and build minimal version of perf,..." displayed on the todo page of the perf wiki (https://perf.wiki.kernel.org/index.php/Todo). I tried to continue the work started by David Ahern (https://github.com/dsahern/linux.git branch:perf-config). This version relies on the features detection tests available in linux/tools/perf/config/feature-checks so as to enable some configuration options (at least by default). This little task is not complete; more Kconfig options should be added for each perf tool (top, record, report, ...). I just wanted to ask whether you consider this proposal as interesting enough for inclusion and if you are ok with the way it is implemented. The code is available here: https://github.com/aberlemont/linux.git - branch: perf-config. I know Jiri has an attempt in his tree and there have been a few discussions since then as well. I'll take a look at it next week. I would like to see it completed; I just don't have the time to do it. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
perf and Kconfig
Hi, Here is a proposal of a small contribution which tries to fulfill the task "Use Kconfig to allow selecting features and build minimal version of perf,..." displayed on the todo page of the perf wiki (https://perf.wiki.kernel.org/index.php/Todo). I tried to continue the work started by David Ahern (https://github.com/dsahern/linux.git branch:perf-config). This version relies on the features detection tests available in linux/tools/perf/config/feature-checks so as to enable some configuration options (at least by default). This little task is not complete; more Kconfig options should be added for each perf tool (top, record, report, ...). I just wanted to ask whether you consider this proposal as interesting enough for inclusion and if you are ok with the way it is implemented. The code is available here: https://github.com/aberlemont/linux.git - branch: perf-config. Alexis. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
perf and Kconfig
Hi, Here is a proposal of a small contribution which tries to fulfill the task Use Kconfig to allow selecting features and build minimal version of perf,... displayed on the todo page of the perf wiki (https://perf.wiki.kernel.org/index.php/Todo). I tried to continue the work started by David Ahern (https://github.com/dsahern/linux.git branch:perf-config). This version relies on the features detection tests available in linux/tools/perf/config/feature-checks so as to enable some configuration options (at least by default). This little task is not complete; more Kconfig options should be added for each perf tool (top, record, report, ...). I just wanted to ask whether you consider this proposal as interesting enough for inclusion and if you are ok with the way it is implemented. The code is available here: https://github.com/aberlemont/linux.git - branch: perf-config. Alexis. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: perf and Kconfig
[adding perf maintainers] On 12/20/13, 5:39 PM, Alexis Berlemont wrote: Hi, Here is a proposal of a small contribution which tries to fulfill the task Use Kconfig to allow selecting features and build minimal version of perf,... displayed on the todo page of the perf wiki (https://perf.wiki.kernel.org/index.php/Todo). I tried to continue the work started by David Ahern (https://github.com/dsahern/linux.git branch:perf-config). This version relies on the features detection tests available in linux/tools/perf/config/feature-checks so as to enable some configuration options (at least by default). This little task is not complete; more Kconfig options should be added for each perf tool (top, record, report, ...). I just wanted to ask whether you consider this proposal as interesting enough for inclusion and if you are ok with the way it is implemented. The code is available here: https://github.com/aberlemont/linux.git - branch: perf-config. I know Jiri has an attempt in his tree and there have been a few discussions since then as well. I'll take a look at it next week. I would like to see it completed; I just don't have the time to do it. David -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: perf and Kconfig
On 12/20/13 16:39, Alexis Berlemont wrote: Hi, Here is a proposal of a small contribution which tries to fulfill the task Use Kconfig to allow selecting features and build minimal version of perf,... displayed on the todo page of the perf wiki (https://perf.wiki.kernel.org/index.php/Todo). I tried to continue the work started by David Ahern (https://github.com/dsahern/linux.git branch:perf-config). This version relies on the features detection tests available in linux/tools/perf/config/feature-checks so as to enable some configuration options (at least by default). This little task is not complete; more Kconfig options should be added for each perf tool (top, record, report, ...). I just wanted to ask whether you consider this proposal as interesting enough for inclusion and if you are ok with the way it is implemented. The code is available here: https://github.com/aberlemont/linux.git - branch: perf-config. Hi, The correct way to have any code reviewed is to post the code (not a link to it) on the mailing list. thanks, -- ~Randy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
