Re: [PATCH 1/3] kbuild, deb-pkg: Try to determine distribution
On Wed, Feb 27, 2013 at 02:55:45PM +0100, Michal Marek wrote: > Sorry I missed this series. Max, can you have a look? I don't know the > policies for debian package changelogs. The full series is at > http://lkml.indiana.edu/hypermail/linux/kernel/1204.2/index.html#04252, > but the remaining two patches are obvious. the two remaining ones are trivial, should have pushed them a long time ago and will do so this weekend in a combined version going up to 2013 (sitting in my queue to send). > On 24.4.2012 00:16, Sedat Dilek wrote: > > Signed-off-by: Sedat Dilek > > --- > > scripts/package/builddeb | 15 ++- > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > diff --git a/scripts/package/builddeb b/scripts/package/builddeb > > index eee5f8e..f5b56ac 100644 > > --- a/scripts/package/builddeb > > +++ b/scripts/package/builddeb > > @@ -172,9 +172,22 @@ else > > fi > > maintainer="$name <$email>" > > > > +# Try to determine distribution > > +if [ -e $(which lsb_release) ]; then > > + codename=$(lsb_release --codename --short) > > + if [ "$codename" != "" ]; then > > + distribution=$codename > > + else > > + distribution="UNRELEASED" > > + echo "WARNING: The distribution could NOT be determined!" > > + fi > > +else > > + echo "HINT: Install lsb_release binary, this helps to identify your > > distribution!" > > +fi > > + > > # Generate a simple changelog template > > cat < debian/changelog > > -linux-upstream ($packageversion) unstable; urgency=low > > +linux-upstream ($packageversion) $distribution; urgency=low > > > >* Custom built Linux kernel. this is pretty useless. Nack, in adding a this additional lsb dep. I know it should be installed by default, but in practise it is often not. If you'd really care about the changelog you'd generate it out of your git repo with Debian's git dch in order to have something meaningful. -- maks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Bug#464962: immediate crash on boot on TM5800
On Tue, Feb 12, 2008 at 01:14:04PM -0800, H. Peter Anvin wrote: > > Are you sure that build matches the bug report? urrgs right sorry, the posted vmlinux is a newer 2.6.24-git22 and not Version: 2.6.24-3 > The EIP given falls inside the .data segment of that kernel, > specifically inside the symbol init_task. > > -hpa will rebuild aboves. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Bug#464962: immediate crash on boot on TM5800
On Tue, Feb 12, 2008 at 12:32:27PM -0800, H. Peter Anvin wrote: > > INT 6 is #UD, undefined instruction. > > If you could send me a copy of your vmlinux file (not bzImage), it would > speed things up. cp -l src/linux-2.6-2.6.24/debian/build/build_i386_none_686/vmlinux ~/public_html/ http://charm.itp.tuwien.ac.at/~mattems/ > I happen to have an old TM5800-based machine sitting around, so I can > probably reproduce it. > > -hpa cool -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Bug#464962: immediate crash on boot on TM5800
On Tue, Feb 12, 2008 at 02:52:54PM -0500, Joey Hess wrote: > maximilian attems wrote: > > thanks for quick feedback, have prebuild 2.6.25-rc1-git2 > > (they contain the security fix, but don't seem to suspend here) > > anyway please test for boot > > -> http://charm.itp.tuwien.ac.at/~mattems/2.6.25-rc1-git2/ > > Still fails the same. > > > if those again don't boot please file info upstream on > > bugzilla.kernel.org so that relevant new x86 arch maintainer > > fix that up. > > Um, could the kernel team forward this bug? well we have no automated way to do so as we are underpowered in terms of bug nrs, it is routine to ask to file upstream. the debian kernel does not carry any x86 specific patch. also it is often much easier if upstream speaks directly with the person that has the hardware at hand. > * I don't have an account on this bugzilla, or actually, on any bugzilla > on earth. > * I don't know exactly what versions you've had me test. > * I guess they'll want to know things about compile options that I don't > know. sure, ack. so i'll circumvent bugzilla and add the new x86 maintainers on cc to let them know about the 2.6.24 and 2.6.25-rc1 boot error on shiny fujitsu p700 lifebook, with a Crusoe processor. http://bugs.debian.org/464962 686 config attached. config-2.6.24-1-686.bz2 Description: Binary data
Re: Huawei E220 and usb storage
> Ok, did new tests with 2.6.24-rc2: > - with plain kernel the usb-storage modules attaches and detaches > permanently a virtual cd drive, I stopped after 30+ iterations. afais this is caused by hal. when i stop hal this bouncy behaviour stops. also it doesn't happen if you put your huawei on before boot. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] builddeb: remove unneeded explicit Architecture
On Wed, 05 Sep 2012, Michal Marek wrote: > On 5.9.2012 15:05, Tzafrir Cohen wrote: > > Hi, > > > > Thanks for your reply, > > > > On Fri, Aug 31, 2012 at 03:50:10PM +0200, Michal Marek wrote: > >> Adding Max to CC. > >> > >> On 14.8.2012 12:44, Tzafrir Cohen wrote: > >>> Architecture was set explicitly in debian/control for one of the three > >>> packages (linux-libc-dev) but not for the other two. When cross-building > >>> it gives me an error: > >>> > >>> dpkg-gencontrol: error: current host architecture 'armhf' does not > >>> appear in package's architecture list (amd64) > >>> > >>> Also note that if used, dpkg --print-architecture should have been > >>> replaced with dpkg-architecture. > >>> > >>> Signed-off-by: Tzafrir Cohen > >>> --- > >>> scripts/package/builddeb |3 +-- > >>> 1 file changed, 1 insertion(+), 2 deletions(-) > >>> > >>> diff --git a/scripts/package/builddeb b/scripts/package/builddeb > >>> index acb8650..d9c71a6 100644 > >>> --- a/scripts/package/builddeb > >>> +++ b/scripts/package/builddeb > >>> @@ -252,13 +252,12 @@ mkdir -p "$destdir" > >>> (cd $objtree; tar -c -f - -T "$objtree/debian/hdrobjfiles") | (cd > >>> $destdir; tar -xf -) > >>> ln -sf "/usr/src/linux-headers-$version" > >>> "$kernel_headers_dir/lib/modules/$version/build" > >>> rm -f "$objtree/debian/hdrsrcfiles" "$objtree/debian/hdrobjfiles" > >>> -arch=$(dpkg --print-architecture) > >>> > >>> cat <> debian/control > >>> > >>> Package: $kernel_headers_packagename > >>> Provides: linux-headers, linux-headers-2.6 > >>> -Architecture: $arch > >>> +Architecture: any > >>> Description: Linux kernel headers for $KERNELRELEASE on $arch > >>> This package provides kernel header files for $KERNELRELEASE on $arch > >>> . > >> > >> As the package contains files from arch/$SRCARCH/include, I doubt that > >> this is a valid change. > > > > But you optionally force the Architecture later on in build_package. > > "Arhcitecture: any" in the source package states that the binary package > > will be the one stated by the build system. > > Ah, OK. I don't know much about Debian packaging in fact. Max, could you > have a look? The original thread is here: > http://lkml.org/lkml/2012/8/14/133. I meant to add you to CC before, > but apparently I forgot. yes indeed it is an invalid change. Cross building shouldn't need it, what did you exactly try? -- maks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] Add mach-specific includes
On Wed, 05 Sep 2012, Tzafrir Cohen wrote: > When building a deb package, the linux-headers package should also > add arch/$ARCH/mach-*/include Required for arm and probably some > other architectures: avr32 and blackfin. > > This is needed to allow building modules using the headers package. > > Signed-off-by: Tzafrir Cohen > --- > scripts/package/builddeb |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/scripts/package/builddeb b/scripts/package/builddeb > index acb8650..811a53a 100644 > --- a/scripts/package/builddeb > +++ b/scripts/package/builddeb > @@ -245,6 +245,9 @@ fi > # Build header package > (cd $srctree; find . -name Makefile\* -o -name Kconfig\* -o -name \*.pl > > "$objtree/debian/hdrsrcfiles") > (cd $srctree; find arch/$SRCARCH/include include scripts -type f >> > "$objtree/debian/hdrsrcfiles") > +if echo arch/$SRCARCH/mach-*/include | grep -v '*' >/dev/null; then > + (cd $srctree; find arch/$SRCARCH/mach-*/include -type f >> > "$objtree/debian/hdrsrcfiles") > +fi > (cd $objtree; find arch/$SRCARCH/include .config Module.symvers include > scripts -type f >> "$objtree/debian/hdrobjfiles") > destdir=$kernel_headers_dir/usr/src/linux-headers-$version > mkdir -p "$destdir" no, please redirect find directly to stderr. thank you. -- maks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] builddeb: remove unneeded explicit Architecture
On Wed, Sep 05, 2012 at 07:40:09PM +0300, Tzafrir Cohen wrote: > On Wed, Sep 05, 2012 at 05:14:22PM +0200, maximilian attems wrote: > > On Wed, 05 Sep 2012, Michal Marek wrote: > > > > > On 5.9.2012 15:05, Tzafrir Cohen wrote: > > > > Hi, > > > > > > > > Thanks for your reply, > > > > > > > > On Fri, Aug 31, 2012 at 03:50:10PM +0200, Michal Marek wrote: > > > >> Adding Max to CC. > > > >> > > > >> On 14.8.2012 12:44, Tzafrir Cohen wrote: > > > >>> Architecture was set explicitly in debian/control for one of the three > > > >>> packages (linux-libc-dev) but not for the other two. When > > > >>> cross-building > > > >>> it gives me an error: > > > >>> > > > >>> dpkg-gencontrol: error: current host architecture 'armhf' does not > > > >>> appear in package's architecture list (amd64) > > > >>> > > > >>> Also note that if used, dpkg --print-architecture should have been > > > >>> replaced with dpkg-architecture. > > > >>> > > > >>> Signed-off-by: Tzafrir Cohen > > > >>> --- > > > >>> scripts/package/builddeb |3 +-- > > > >>> 1 file changed, 1 insertion(+), 2 deletions(-) > > > >>> > > > >>> diff --git a/scripts/package/builddeb b/scripts/package/builddeb > > > >>> index acb8650..d9c71a6 100644 > > > >>> --- a/scripts/package/builddeb > > > >>> +++ b/scripts/package/builddeb > > > >>> @@ -252,13 +252,12 @@ mkdir -p "$destdir" > > > >>> (cd $objtree; tar -c -f - -T "$objtree/debian/hdrobjfiles") | (cd > > > >>> $destdir; tar -xf -) > > > >>> ln -sf "/usr/src/linux-headers-$version" > > > >>> "$kernel_headers_dir/lib/modules/$version/build" > > > >>> rm -f "$objtree/debian/hdrsrcfiles" "$objtree/debian/hdrobjfiles" > > > >>> -arch=$(dpkg --print-architecture) > > > >>> > > > >>> cat <> debian/control > > > >>> > > > >>> Package: $kernel_headers_packagename > > > >>> Provides: linux-headers, linux-headers-2.6 > > > >>> -Architecture: $arch > > > >>> +Architecture: any > > > >>> Description: Linux kernel headers for $KERNELRELEASE on $arch > > > >>> This package provides kernel header files for $KERNELRELEASE on > > > >>> $arch > > > >>> . > > > >> > > > >> As the package contains files from arch/$SRCARCH/include, I doubt that > > > >> this is a valid change. > > > > > > > > But you optionally force the Architecture later on in build_package. > > > > "Arhcitecture: any" in the source package states that the binary package > > > > will be the one stated by the build system. > > > > > > Ah, OK. I don't know much about Debian packaging in fact. Max, could you > > > have a look? The original thread is here: > > > http://lkml.org/lkml/2012/8/14/133. I meant to add you to CC before, > > > but apparently I forgot. > > > > yes indeed it is an invalid change. > > Cross building shouldn't need it, what did you exactly try? > > $ grep CROSS_COMPILE .config > CONFIG_CROSS_COMPILE="arm-linux-gnueabihf-" > > Command: > > KBUILD_DEBARCH=armhf make ARCH=arm KBUILD_IMAGE=uImage deb-pkg > > Error I get: > > dpkg-gencontrol: error: current host architecture 'armhf' does not > appear in package's architecture list (amd64) > > It seems I have to use KBUILD_DEBARCH, as the kernel build system can't > really tell if I want armel or armhf (If I built the same kernel for a > Squeeze system I would have been forced to use armel). well, obviously the dpkg call in -arch=$(dpkg --print-architecture) is wrong please fix that. thanks. -- maks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] builddeb: remove unneeded explicit Architecture
On Wed, Sep 05, 2012 at 08:26:05PM +, maximilian attems wrote: > On Wed, Sep 05, 2012 at 07:40:09PM +0300, Tzafrir Cohen wrote: > > > > $ grep CROSS_COMPILE .config > > CONFIG_CROSS_COMPILE="arm-linux-gnueabihf-" > > > > Command: > > > > KBUILD_DEBARCH=armhf make ARCH=arm KBUILD_IMAGE=uImage deb-pkg > > > > Error I get: > > > > dpkg-gencontrol: error: current host architecture 'armhf' does not > > appear in package's architecture list (amd64) > > > > It seems I have to use KBUILD_DEBARCH, as the kernel build system can't > > really tell if I want armel or armhf (If I built the same kernel for a > > Squeeze system I would have been forced to use armel). > > well, obviously the dpkg call in > -arch=$(dpkg --print-architecture) > is wrong please fix that. > care to test belows: >From e12defa4ad57cdb34c14031f104db6df8962 Mon Sep 17 00:00:00 2001 From: maximilian attems Date: Thu, 6 Sep 2012 15:22:02 +0200 Subject: [PATCH] deb-pkg: Simplify architecture matching for cross building No point in invoking dpkg to get the archticture of the host we build on. Instead directly use the logic implemented in create_package(). No need anymore to override arch. While at it fix the linux images to be for the specific built arch. Signed-off-by: maximilian attems --- scripts/package/builddeb | 82 ++ 1 file changed, 39 insertions(+), 43 deletions(-) diff --git a/scripts/package/builddeb b/scripts/package/builddeb index acb8650..07792d6 100644 --- a/scripts/package/builddeb +++ b/scripts/package/builddeb @@ -14,6 +14,7 @@ set -e create_package() { local pname="$1" pdir="$2" + local forcearch="" cp debian/copyright "$pdir/usr/share/doc/$pname/" cp debian/changelog "$pdir/usr/share/doc/$pname/changelog.Debian" @@ -25,44 +26,8 @@ create_package() { chown -R root:root "$pdir" chmod -R go-w "$pdir" - # Attempt to find the correct Debian architecture - local forcearch="" debarch="" - case "$UTS_MACHINE" in - i386|ia64|alpha) - debarch="$UTS_MACHINE" ;; - x86_64) - debarch=amd64 ;; - sparc*) - debarch=sparc ;; - s390*) - debarch=s390 ;; - ppc*) - debarch=powerpc ;; - parisc*) - debarch=hppa ;; - mips*) - debarch=mips$(grep -q CPU_LITTLE_ENDIAN=y .config && echo el) ;; - arm*) - debarch=arm$(grep -q CONFIG_AEABI=y .config && echo el) ;; - *) - echo "" >&2 - echo "** ** ** WARNING ** ** **" >&2 - echo "" >&2 - echo "Your architecture doesn't have it's equivalent" >&2 - echo "Debian userspace architecture defined!" >&2 - echo "Falling back to using your current userspace instead!" >&2 - echo "Please add support for $UTS_MACHINE to ${0} ..." >&2 - echo "" >&2 - esac - if [ -n "$KBUILD_DEBARCH" ] ; then - debarch="$KBUILD_DEBARCH" - fi - if [ -n "$debarch" ] ; then - forcearch="-DArchitecture=$debarch" - fi - # Create the package - dpkg-gencontrol -isp $forcearch -p$pname -P"$pdir" + dpkg-gencontrol -p$pname -P"$pdir" dpkg --build "$pdir" .. } @@ -83,6 +48,38 @@ fwpackagename=linux-firmware-image kernel_headers_packagename=linux-headers-$version libc_headers_packagename=linux-libc-dev +# Attempt to find the correct Debian architecture +case "$UTS_MACHINE" in +i386|ia64|alpha) + debarch="$UTS_MACHINE" ;; +x86_64) + debarch=amd64 ;; +sparc*) + debarch=sparc ;; +s390*) + debarch=s390 ;; +ppc*) + debarch=powerpc ;; +parisc*) + debarch=hppa ;; +mips*) + debarch=mips$(grep -q CPU_LITTLE_ENDIAN=y .config && echo el) ;; +arm*) + debarch=arm$(grep -q CONFIG_AEABI=y .config && echo el) ;; +*) + echo "" >&2 + echo "** ** ** WARNING ** ** **" >&2 + echo "" >&2 + echo "Your architecture doesn't have it's equivalent" >&2 + echo "Debian userspace architecture defined!" >&2 + echo "Falling back to using your current userspace instead!" >&2 + echo "Please add support for $UTS_MACHINE to ${0} ..." >&2 +
Re: [PATCH] builddeb: remove unneeded explicit Architecture
On Thu, Sep 06, 2012 at 02:00:04PM +, maximilian attems wrote: > On Wed, Sep 05, 2012 at 08:26:05PM +0000, maximilian attems wrote: > > On Wed, Sep 05, 2012 at 07:40:09PM +0300, Tzafrir Cohen wrote: > > > > > > $ grep CROSS_COMPILE .config > > > CONFIG_CROSS_COMPILE="arm-linux-gnueabihf-" > > > > > > Command: > > > > > > KBUILD_DEBARCH=armhf make ARCH=arm KBUILD_IMAGE=uImage deb-pkg > > > > > > Error I get: > > > > > > dpkg-gencontrol: error: current host architecture 'armhf' does not > > > appear in package's architecture list (amd64) > > > > > > It seems I have to use KBUILD_DEBARCH, as the kernel build system can't > > > really tell if I want armel or armhf (If I built the same kernel for a > > > Squeeze system I would have been forced to use armel). > > > > well, obviously the dpkg call in > > -arch=$(dpkg --print-architecture) > > is wrong please fix that. > > > > care to test belows: > without a useless snippet about the lost forcearch v2: >From f78afbe0b7fa7c49656f4ed1cf404e915f3c325b Mon Sep 17 00:00:00 2001 From: maximilian attems Date: Thu, 6 Sep 2012 15:22:02 +0200 Subject: [PATCH v2] deb-pkg: Simplify architecture matching for cross building No point in invoking dpkg to get the archticture of the host we build on. Instead directly use the logic implemented in create_package(). No need anymore to override arch. While at it fix the linux images to be for the specific built arch. Signed-off-by: maximilian attems --- scripts/package/builddeb | 81 ++ 1 file changed, 38 insertions(+), 43 deletions(-) diff --git a/scripts/package/builddeb b/scripts/package/builddeb index acb8650..a5f197b 100644 --- a/scripts/package/builddeb +++ b/scripts/package/builddeb @@ -25,44 +25,8 @@ create_package() { chown -R root:root "$pdir" chmod -R go-w "$pdir" - # Attempt to find the correct Debian architecture - local forcearch="" debarch="" - case "$UTS_MACHINE" in - i386|ia64|alpha) - debarch="$UTS_MACHINE" ;; - x86_64) - debarch=amd64 ;; - sparc*) - debarch=sparc ;; - s390*) - debarch=s390 ;; - ppc*) - debarch=powerpc ;; - parisc*) - debarch=hppa ;; - mips*) - debarch=mips$(grep -q CPU_LITTLE_ENDIAN=y .config && echo el) ;; - arm*) - debarch=arm$(grep -q CONFIG_AEABI=y .config && echo el) ;; - *) - echo "" >&2 - echo "** ** ** WARNING ** ** **" >&2 - echo "" >&2 - echo "Your architecture doesn't have it's equivalent" >&2 - echo "Debian userspace architecture defined!" >&2 - echo "Falling back to using your current userspace instead!" >&2 - echo "Please add support for $UTS_MACHINE to ${0} ..." >&2 - echo "" >&2 - esac - if [ -n "$KBUILD_DEBARCH" ] ; then - debarch="$KBUILD_DEBARCH" - fi - if [ -n "$debarch" ] ; then - forcearch="-DArchitecture=$debarch" - fi - # Create the package - dpkg-gencontrol -isp $forcearch -p$pname -P"$pdir" + dpkg-gencontrol -p$pname -P"$pdir" dpkg --build "$pdir" .. } @@ -83,6 +47,38 @@ fwpackagename=linux-firmware-image kernel_headers_packagename=linux-headers-$version libc_headers_packagename=linux-libc-dev +# Attempt to find the correct Debian architecture +case "$UTS_MACHINE" in +i386|ia64|alpha) + debarch="$UTS_MACHINE" ;; +x86_64) + debarch=amd64 ;; +sparc*) + debarch=sparc ;; +s390*) + debarch=s390 ;; +ppc*) + debarch=powerpc ;; +parisc*) + debarch=hppa ;; +mips*) + debarch=mips$(grep -q CPU_LITTLE_ENDIAN=y .config && echo el) ;; +arm*) + debarch=arm$(grep -q CONFIG_AEABI=y .config && echo el) ;; +*) + echo "" >&2 + echo "** ** ** WARNING ** ** **" >&2 + echo "" >&2 + echo "Your architecture doesn't have it's equivalent" >&2 + echo "Debian userspace architecture defined!" >&2 + echo "Falling back to using your current userspace instead!" >&2 + echo "Please add support for $UTS_MACHINE to ${0} ..." >&2 + echo "" >&2 +esac
Re: [PATCH] builddeb: remove unneeded explicit Architecture
On Thu, 06 Sep 2012, Tzafrir Cohen wrote: > > Works for the case I presented. Michal please care to queue previous v2 patch with Tested-by: Tzafrir Cohen to kope with that cross building regression since the linux headers got added to deb-pkg target. > Now I remove the explicit setting of KBUILD_DEBRCH: and here lies the error. > $ rm -rf debian > $ make ARCH=arm KBUILD_IMAGE=uImage deb-pkg > > ... > > dpkg-gencontrol: error: current host architecture 'armhf' does not > appear in package's architecture list (armel) > > My host architecture is amd64. This is actually the build architecture. > dpkg-gencontrol uses Dpkg::Arch::get_host_arch(). > > $ perl -MDpkg::Arch -e 'print Dpkg::Arch::get_host_arch()."\n"' > amd64 > > $ CC=/usr/bin/arm-linux-gnueabi-gcc perl -MDpkg::Arch -e 'print > Dpkg::Arch::get_host_arch()."\n"' > armel > > $ CC=/usr/bin/arm-linux-gnueabihf-gcc perl -MDpkg::Arch -e 'print > Dpkg::Arch::get_host_arch()."\n"' > armhf > > $ DEB_HOST_ARCH=whatever perl -MDpkg::Arch -e 'print > Dpkg::Arch::get_host_arch()."\n"' > whatever > > Is it OK to use that perl one-liner as the default instead of the > architecture guessing case? In any case that would be a follow up, but I'm not fond of that perl/dpkg magic plus supporting DEB_ variables. I think for linux it is preferable to have it based on UTS_MACHINE. Thus I think your testcases aren't valid, and also you neglected the following one: make KBUILD_DEBARCH=i386 deb-pkg # i386 userland with amd64 linux Best. -- maks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 2/3] hd eliminate bad section references
On Mon, 04 Apr 2005, Randy.Dunlap wrote: > >-static int parse_hd_setup (char *line) { > >+static int __init parse_hd_setup (char *line) { .. > This one is fairly interesting and needs some resolution by someone > who knows thanks a lot for your quick and profund feedback. > On the surface, the patch is correct. > > Rusty, can you explain when __setup functions are called relative > to in-kernel init functions? or put another way, can a __setup > function safely call in __init function? > > Here's the function in question: > > static int parse_hd_setup (char *line) { > int ints[6]; > > (void) get_options(line, ARRAY_SIZE(ints), ints); > hd_setup(NULL, ints); > > return 1; > } > __setup("hd=", parse_hd_setup); > > > > Should we make parse_hd_setup() __init, > or make hd_setup() non-__init, or something else? > > {time passes, he looks] > > OK, I looked at include/linux/init.h. From what I can see > there, __setup() causes an .init.setup section to be emitted, > so marking __setup() function as __init would make sense. > I think that this patch is good. i saw that ide_setup() is __init as a bunch of lots others. yes init.h confirms that. :) -- maks kernel janitor http://janitor.kernelnewbies.org/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: klibc ipconfig misbehavior in a network with DHCP snooping
[ added klibc ml to cc ] > I found a problem with klibc's "ipconfig" program, or at least, behavior > that breaks DHCP on my thin clients (LTSP 5.0). It has to do with setting > the giaddr field on dhcp_send in dhcp_proto.c, line 164. thank you for digging into it. > Otherwise, the relay agent SHALL forward any received DHCP packet > with a valid non-zero giaddr WITHOUT adding any relay agent options. > Per RFC 2131 < > ;http://www.faqs.org/rfcs /rfc2131.html>, it shall also NOT modify the > giaddr value. got also a single klibc Debian bug report on it: -> http://bugs.debian.org/432977 i'm adding the patch to my branch and will submit it to hpa asap. -- maks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
e1000e oops
Linux tau 2.6.23-rc8-mm2-686 #1 SMP Wed Oct 3 23:56:32 CEST 2007 i686 GNU/Linux eth0 renamed to eth1 sysfs: duplicate filename 'eth1' can not be created WARNING: at fs/sysfs/dir.c:433 sysfs_add_one() [] dump_trace+0x68/0x1d5 [] show_trace_log_lvl+0x18/0x2c [] show_trace+0xf/0x11 [] dump_stack+0x12/0x14 [] sysfs_add_one+0x54/0xb8 [] sysfs_create_link+0xb3/0x125 [] device_rename+0x13d/0x196 [] dev_change_name+0x137/0x205 [] dev_ioctl+0x357/0x44f [] do_ioctl+0x1f/0x62 [] vfs_ioctl+0x237/0x249 [] sys_ioctl+0x45/0x5d [] syscall_call+0x7/0xb [] 0xb7edbde4 === net eth1: device_rename: sysfs_create_symlink failed (-17) 00:19.0 Ethernet controller [0200]: Intel Corporation 82801I (ICH9 Family) Gigabit Ethernet Controller [8086:294c] (rev 02) Subsystem: Intel Corporation Unknown device [8086:0001] Flags: bus master, fast devsel, latency 0, IRQ 218 Memory at 5038 (32-bit, non-prefetchable) [size=128K] Memory at 503a4000 (32-bit, non-prefetchable) [size=4K] I/O ports at 20e0 [size=32] Capabilities: [c8] Power Management version 2 Capabilities: [d0] Message Signalled Interrupts: Mask- 64bit+ Queue=0/0 Enable+ Capabilities: [e0] Vendor Specific Information no idea if aboves belongs to netdev or sysfs dep. -- maks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] w6692 eliminate bad section references
Fix w6692 section references: convert __initdata to __devinitdata. Error: ./drivers/isdn/hisax/w6692.o .text refers to 002f R_386_32 .init.data Signed-off-by: maximilian attems <[EMAIL PROTECTED]> diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c --- linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c 2005-03-02 08:38:25.0 +0100 +++ linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c 2005-03-13 23:36:34.0 +0100 @@ -45,7 +45,7 @@ const char *w6692_revision = "$Revision: #define DBUSY_TIMER_VALUE 80 -static char *W6692Ver[] __initdata = +static char *W6692Ver[] __devinitdata = {"W6692 V00", "W6692 V01", "W6692 V10", "W6692 V11"}; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] teles3 eliminate bad section references
Fix teles3 section references: convert __initdata to __devinitdata. Error: ./drivers/isdn/hisax/teles3.o .text refers to 11ab R_386_32 .init.data Error: ./drivers/isdn/hisax/teles3.o .text refers to 11ba R_386_32 .init.data Error: ./drivers/isdn/hisax/teles3.o .text refers to 11e0 R_386_32 .init.data Error: ./drivers/isdn/hisax/teles3.o .text refers to 11fd R_386_32 .init.data Error: ./drivers/isdn/hisax/teles3.o .text refers to 128c R_386_32 .init.data Error: ./drivers/isdn/hisax/teles3.o .text refers to 1294 R_386_32 .init.data Error: ./drivers/isdn/hisax/teles3.o .text refers to 12a6 R_386_32 .init.data Signed-off-by: maximilian attems <[EMAIL PROTECTED]> diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/teles3.c linux-2.6.11-bk8-max/drivers/isdn/hisax/teles3.c --- linux-2.6.11-bk8/drivers/isdn/hisax/teles3.c2005-03-02 08:38:33.0 +0100 +++ linux-2.6.11-bk8-max/drivers/isdn/hisax/teles3.c2005-03-14 00:47:32.0 +0100 @@ -254,7 +254,7 @@ Teles_card_msg(struct IsdnCardState *cs, #ifdef __ISAPNP__ -static struct isapnp_device_id teles_ids[] __initdata = { +static struct isapnp_device_id teles_ids[] __devinitdata = { { ISAPNP_VENDOR('T', 'A', 'G'), ISAPNP_FUNCTION(0x2110), ISAPNP_VENDOR('T', 'A', 'G'), ISAPNP_FUNCTION(0x2110), (unsigned long) "Teles 16.3 PnP" }, @@ -267,7 +267,7 @@ static struct isapnp_device_id teles_ids { 0, } }; -static struct isapnp_device_id *ipid __initdata = &teles_ids[0]; +static struct isapnp_device_id *ipid __devinitdata = &teles_ids[0]; static struct pnp_card *pnp_c __devinitdata = NULL; #endif - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] elsa eliminate bad section references
Fix elsa section references: convert __initdata to __devinitdata. Error: ./drivers/isdn/hisax/elsa.o .text refers to 3d28 R_386_32 .init.data Error: ./drivers/isdn/hisax/elsa.o .text refers to 3d37 R_386_32 .init.data Error: ./drivers/isdn/hisax/elsa.o .text refers to 3d56 R_386_32 .init.data Error: ./drivers/isdn/hisax/elsa.o .text refers to 3d77 R_386_32 .init.data Error: ./drivers/isdn/hisax/elsa.o .text refers to 3ddb R_386_32 .init.data Error: ./drivers/isdn/hisax/elsa.o .text refers to 3e0e R_386_32 .init.data Error: ./drivers/isdn/hisax/elsa.o .text refers to 3e20 R_386_32 .init.data Signed-off-by: maximilian attems <[EMAIL PROTECTED]> diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/elsa.c linux-2.6.11-bk8-max/drivers/isdn/hisax/elsa.c --- linux-2.6.11-bk8/drivers/isdn/hisax/elsa.c 2005-03-02 08:37:49.0 +0100 +++ linux-2.6.11-bk8-max/drivers/isdn/hisax/elsa.c 2005-03-14 01:04:02.0 +0100 @@ -838,7 +838,7 @@ static struct pci_dev *dev_qs1000 __dev static struct pci_dev *dev_qs3000 __devinitdata = NULL; #ifdef __ISAPNP__ -static struct isapnp_device_id elsa_ids[] __initdata = { +static struct isapnp_device_id elsa_ids[] __devinitdata = { { ISAPNP_VENDOR('E', 'L', 'S'), ISAPNP_FUNCTION(0x0133), ISAPNP_VENDOR('E', 'L', 'S'), ISAPNP_FUNCTION(0x0133), (unsigned long) "Elsa QS1000" }, @@ -848,7 +848,7 @@ static struct isapnp_device_id elsa_ids[ { 0, } }; -static struct isapnp_device_id *ipid __initdata = &elsa_ids[0]; +static struct isapnp_device_id *ipid __devinitdata = &elsa_ids[0]; static struct pnp_card *pnp_c __devinitdata = NULL; #endif - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] sedlbauer eliminate bad section references
Fix sedlbauer section references: convert __initdata to __devinitdata. Error: ./drivers/isdn/hisax/sedlbauer.o .text refers to 235f R_386_32 .init.data Error: ./drivers/isdn/hisax/sedlbauer.o .text refers to 236e R_386_32 .init.data Error: ./drivers/isdn/hisax/sedlbauer.o .text refers to 238d R_386_32 .init.data Error: ./drivers/isdn/hisax/sedlbauer.o .text refers to 23b2 R_386_32 .init.data Error: ./drivers/isdn/hisax/sedlbauer.o .text refers to 2417 R_386_32 .init.data Error: ./drivers/isdn/hisax/sedlbauer.o .text refers to 244c R_386_32 .init.data Signed-off-by: maximilian attems <[EMAIL PROTECTED]> diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/sedlbauer.c linux-2.6.11-bk8-max/drivers/isdn/hisax/sedlbauer.c --- linux-2.6.11-bk8/drivers/isdn/hisax/sedlbauer.c 2005-03-02 08:38:32.0 +0100 +++ linux-2.6.11-bk8-max/drivers/isdn/hisax/sedlbauer.c 2005-03-14 01:03:14.0 +0100 @@ -516,7 +516,7 @@ Sedl_card_msg(struct IsdnCardState *cs, static struct pci_dev *dev_sedl __devinitdata = NULL; #ifdef __ISAPNP__ -static struct isapnp_device_id sedl_ids[] __initdata = { +static struct isapnp_device_id sedl_ids[] __devinitdata = { { ISAPNP_VENDOR('S', 'A', 'G'), ISAPNP_FUNCTION(0x01), ISAPNP_VENDOR('S', 'A', 'G'), ISAPNP_FUNCTION(0x01), (unsigned long) "Speed win" }, @@ -526,7 +526,7 @@ static struct isapnp_device_id sedl_ids[ { 0, } }; -static struct isapnp_device_id *ipid __initdata = &sedl_ids[0]; +static struct isapnp_device_id *ipid __devinitdata = &sedl_ids[0]; static struct pnp_card *pnp_c __devinitdata = NULL; #endif - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] hfc_sx eliminate bad section references
Fix hfc_sx section references: convert __initdata to __devinitdata. Error: ./drivers/isdn/hisax/hfc_sx.o .text refers to 204d R_386_32 .init.data Error: ./drivers/isdn/hisax/hfc_sx.o .text refers to 205c R_386_32 .init.data Error: ./drivers/isdn/hisax/hfc_sx.o .text refers to 2082 R_386_32 .init.data Error: ./drivers/isdn/hisax/hfc_sx.o .text refers to 209f R_386_32 .init.data Error: ./drivers/isdn/hisax/hfc_sx.o .text refers to 2114 R_386_32 .init.data Error: ./drivers/isdn/hisax/hfc_sx.o .text refers to 211c R_386_32 .init.data Error: ./drivers/isdn/hisax/hfc_sx.o .text refers to 212e R_386_32 .init.data Signed-off-by: maximilian attems <[EMAIL PROTECTED]> diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/hfc_sx.c linux-2.6.11-bk8-max/drivers/isdn/hisax/hfc_sx.c --- linux-2.6.11-bk8/drivers/isdn/hisax/hfc_sx.c2005-03-02 08:37:48.0 +0100 +++ linux-2.6.11-bk8-max/drivers/isdn/hisax/hfc_sx.c2005-03-14 01:03:42.0 +0100 @@ -1382,14 +1382,14 @@ hfcsx_card_msg(struct IsdnCardState *cs, } #ifdef __ISAPNP__ -static struct isapnp_device_id hfc_ids[] __initdata = { +static struct isapnp_device_id hfc_ids[] __devinitdata = { { ISAPNP_VENDOR('T', 'A', 'G'), ISAPNP_FUNCTION(0x2620), ISAPNP_VENDOR('T', 'A', 'G'), ISAPNP_FUNCTION(0x2620), (unsigned long) "Teles 16.3c2" }, { 0, } }; -static struct isapnp_device_id *ipid __initdata = &hfc_ids[0]; +static struct isapnp_device_id *ipid __devinitdata = &hfc_ids[0]; static struct pnp_card *pnp_c __devinitdata = NULL; #endif - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch trivial] as-iosched fix path to Documentation
On Tue, 15 Mar 2005, Adrian Bunk wrote: > On Thu, Mar 10, 2005 at 12:42:23AM +0100, maximilian attems wrote: > > > From: Klaus Ita <[EMAIL PROTECTED]> > > > > subject says all, patch still applies. > >... > > Fix is already in -mm for some time. > > cu > Adrian yup saw it lately. great. thanks for your mail. -- maks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] w6692 eliminate bad section references
On Mon, 14 Mar 2005, Randy.Dunlap wrote: > maximilian attems wrote: > >Fix w6692 section references: > > convert __initdata to __devinitdata. > > > >Error: ./drivers/isdn/hisax/w6692.o .text refers to 002f R_386_32 > >.init.data > > > I think the correct fix is to make W6692Version() be __init ... > What do you think of that? > > -- > ~Randy thanks a lot for your review! you are right much better, added __init to W6692Version(). #Signed-off-by: maximilian attems <[EMAIL PROTECTED]> diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c --- linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c 2005-03-02 08:38:25.0 +0100 +++ linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c 2005-03-15 14:01:14.0 +0100 @@ -49,7 +49,7 @@ static char *W6692Ver[] __initdata = {"W6692 V00", "W6692 V01", "W6692 V10", "W6692 V11"}; -static void +static void __init W6692Version(struct IsdnCardState *cs, char *s) { int val; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 2.6.11-mm4
>+w6692-eliminate-bad-section-references.patch thanks for updating the patch. the txt has still the old content, please change it to: added __init to W6692Version(). -- maks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch trivial] as-iosched fix path to Documentation
From: Klaus Ita <[EMAIL PROTECTED]> subject says all, patch still applies. #signed-off-by: maximilian attems <[EMAIL PROTECTED]> diff --unified --recursive --new-file linux-2.6.9/drivers/block/as-iosched.c linux-2.6.9_klaus/drivers/block/as-iosched.c --- linux-2.6.9/drivers/block/as-iosched.c 2004-10-18 23:53:06.0 +0200 +++ linux-2.6.9_klaus/drivers/block/as-iosched.c2004-12-09 20:00:34.0 +0100 @@ -25,7 +25,7 @@ #define REQ_ASYNC 0 /* - * See Documentation/as-iosched.txt + * See Documentation/block/as-iosched.txt */ /* - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] cyrix eliminate bad section references
Fix cyrix section references: convert __initdata to __devinitdata. Error: ./arch/i386/kernel/cpu/mtrr/cyrix.o .text refers to 0379 R_386_32 .init.data Error: ./arch/i386/kernel/cpu/mtrr/cyrix.o .text refers to 0399 R_386_32 .init.data Error: ./arch/i386/kernel/cpu/mtrr/cyrix.o .text refers to 03b3 R_386_32 .init.data Error: ./arch/i386/kernel/cpu/mtrr/cyrix.o .text refers to 03b9 R_386_32 .init.data Error: ./arch/i386/kernel/cpu/mtrr/cyrix.o .text refers to 03bf R_386_32 .init.data not many left on my .config, thanks Randy! signed-of-by: maximilian attems <[EMAIL PROTECTED]> diff -pruN -X dontdiff linux-2.6.11-bk6/arch/i386/kernel/cpu/mtrr/cyrix.c linux-2.6.11-bk6-max/arch/i386/kernel/cpu/mtrr/cyrix.c --- linux-2.6.11-bk6/arch/i386/kernel/cpu/mtrr/cyrix.c 2005-03-11 09:28:05.0 +0100 +++ linux-2.6.11-bk6-max/arch/i386/kernel/cpu/mtrr/cyrix.c 2005-03-11 14:15:33.0 +0100 @@ -218,12 +218,12 @@ typedef struct { mtrr_type type; } arr_state_t; -static arr_state_t arr_state[8] __initdata = { +static arr_state_t arr_state[8] __devinitdata = { {0UL, 0UL, 0UL}, {0UL, 0UL, 0UL}, {0UL, 0UL, 0UL}, {0UL, 0UL, 0UL}, {0UL, 0UL, 0UL}, {0UL, 0UL, 0UL}, {0UL, 0UL, 0UL}, {0UL, 0UL, 0UL} }; -static unsigned char ccr_state[7] __initdata = { 0, 0, 0, 0, 0, 0, 0 }; +static unsigned char ccr_state[7] __devinitdata = { 0, 0, 0, 0, 0, 0, 0 }; static void cyrix_set_all(void) { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Bug#270376: PCMCIA Nic stops working after upgrading to 2.6.6/7/8
cc'ing the pcmcia maintainer and the author of the patch for interrupt routing for TI bridges. concerning a bug report about non working irq routing since 2.6.6-rc1 up until 2.6.12-rc1-mm3 http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=270376 (lspci, dmesg) hope you can help to resolve that issue. i volountary test build kernels for bug reporter with proposed patches. On Thu, 31 Mar 2005, Jefferson Cowart wrote: > (For reference my primary card is a 3C574. My secondary is a 3C589.) .. > > > (I put that card into a Windows XP laptop and it worked fine there so the > card itself is fine.) > > Now I'm trying to see if I have these same problems on 2.5.5 > > First, Booting with the secondary card plugged in had the same failure as > above. > Next booting with the primary plugged in. It worked (as expected). Then I > was able to pull and re-insert the card without problems. However pulling > the primary and inserting the secondary killed the network (as expected). > > Now I'm going back to 2.4.27 to figure out if my secondary card will work > there. It failed. I got a hard lock when I inserted the card. (Reboot button > needed.) > > I'm 99.9% certain that my testing of 2.6.6-2.6.10 was using my primary nic, > but I'm booting 2.6.10 now to be sure. (I know the kernels I tested for you > yesterday used my primary nic.) As expected no networking. > > It looks like we may have 2 different bugs here: one in the yenta_socket > driver starting somewhere after 2.6.5-bk1 and before 2.6.6-rc1 and one in > the 3c589 driver in I don't know what versions. (I seem to remember that > 2.4.18 worked, but I'm not sure. If you want me to try that nic under and > older kernel let me know, however I think fixing the first bug is more > important.) If you need any further log info let me know. indeed there is a change in the irq handling in the yenta code. it went in after 2.6.5-bk2 and is in 2.6.6-rc1. in the context could you send please the ouput of a pre 2.6.6-rc1 kernel on your box: cat /proc/interrupts regarding your other pcmcia i don't know if it's supported. thanks for your feedback. -- maks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch 2/3] hd eliminate bad section references
Fix hd section references: make parse_hd_setup() __init Error: ./drivers/ide/legacy/hd.o .text refers to 0943 R_386_PC32 .init.text Signed-off-by: maximilian attems <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-bk5/drivers/ide/legacy/hd.c.orig 2005-04-04 18:39:04.0 +0200 +++ linux-2.6.12-rc1-bk5/drivers/ide/legacy/hd.c2005-04-04 19:02:57.908576221 +0200 @@ -851,7 +851,7 @@ goto out; } -static int parse_hd_setup (char *line) { +static int __init parse_hd_setup (char *line) { int ints[6]; (void) get_options(line, ARRAY_SIZE(ints), ints); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch 1/3] pnpbios eliminate bad section references
one of the last buildcheck errors on i386, thanks Randy again for double checking. Fix pnpbios section references: make dmi_system_id pnpbios_dmi_table __initdata Error: ./drivers/pnp/pnpbios/core.o .data refers to 0100 R_386_32 .init.text Error: ./drivers/pnp/pnpbios/core.o .data refers to 012c R_386_32 .init.text Signed-off-by: maximilian attems <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c.orig2005-04-04 19:11:37.814477672 +0200 +++ linux-2.6.12-rc1-bk5/drivers/pnp/pnpbios/core.c 2005-04-04 19:25:50.074402365 +0200 @@ -512,7 +512,7 @@ return 0; } -static struct dmi_system_id pnpbios_dmi_table[] = { +static struct dmi_system_id pnpbios_dmi_table[] __initdata = { { /* PnPBIOS GPF on boot */ .callback = exploding_pnp_bios, .ident = "Higraded P14H", - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch 3/3] efi eliminate bad section references
Randy please double check especially this one. there may be a better solution. Fix efi section references: remove __initdata for struct efi efi_phys and struct efi_memory_map memmap Error: ./arch/i386/kernel/efi.o .text refers to 00d3 R_386_32 .init.data Error: ./arch/i386/kernel/efi.o .text refers to 00ff R_386_32 .init.data efi_memmap_walk (which is not __init nor static) accesses both efi_phys and memmap. Signed-off-by: maximilian attems <[EMAIL PROTECTED]> --- linux-2.6.12-rc1-bk5/arch/i386/kernel/efi.c.orig2005-04-04 19:41:13.109877906 +0200 +++ linux-2.6.12-rc1-bk5/arch/i386/kernel/efi.c 2005-04-04 19:34:23.886343763 +0200 @@ -46,8 +46,8 @@ struct efi efi; EXPORT_SYMBOL(efi); -static struct efi efi_phys __initdata; -struct efi_memory_map memmap __initdata; +static struct efi efi_phys; +struct efi_memory_map memmap; /* * We require an early boot_ioremap mapping mechanism initially - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ANN] Squashfs 3.3 released
On Mon, Nov 05, 2007 at 11:13:14AM +, Phillip Lougher wrote: > I'm pleased to announce another release of Squashfs. This is the 22nd > release in just over five years. Squashfs 3.3 has lots of nice > improvements, > both to the filesystem itself (bigger blocks and sparse files), but > also to the Squashfs-tools Mksquashfs and Unsquashfs. > > The next stage after this release is to fix the one remaining blocking issue > (filesystem endianness), and then try to get Squashfs mainlined into the > Linux kernel again. > that would be very cool! with my hat as debian kernel maintainer i'd be very relieved to see it mainlined. i don't know of any major distro that doesn't ship it. thanks -- maks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 2.6.19 file content corruption on ext3
> On Thu, Dec 28, 2006 at 11:21:21AM -0800, Linus Torvalds wrote: > > > > > > On Thu, 28 Dec 2006, Petri Kaukasoina wrote: > > > > me up), and that seems to show the corruption going way way back (ie > going > > > > back to Linux-2.6.5 at least, according to one tester). > > > > > > That was a Fedora kernel. Has anyone seen the corruption in vanilla > 2.6.18 > > > (or older)? > > > > Well, that was a really _old_ fedora kernel. I guarantee you it didn't > > have the page throttling patches in it, those were written this summer. So > > it would either have to be Fedora carrying around another patch that just > > happens to result in the same corruption for _years_, or it's the same > > bug. > > The only notable VM patch in Fedora kernels of that vintage that I recall > was Ingo's 4g/4g thing. > > Dave no the fedora 2.6.18 kernel is affected. it carries the same -mm patches that Debian backported for LSB 3.1 compliance. -- maks ps sorry for stripping cc, only downloaded that message raw. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 2.6.19 file content corruption on ext3
On Fri, Dec 29, 2006 at 10:02:53AM -0500, Dave Jones wrote: > On Fri, Dec 29, 2006 at 10:23:14AM +0100, maximilian attems wrote: > > > On Thu, Dec 28, 2006 at 11:21:21AM -0800, Linus Torvalds wrote: > > > > > That was a Fedora kernel. Has anyone seen the corruption in vanilla > 2.6.18 > > > > > (or older)? > > > > > > > > Well, that was a really _old_ fedora kernel. I guarantee you it > didn't > > > > have the page throttling patches in it, those were written this > summer. So > > > > it would either have to be Fedora carrying around another patch that > just > > > > happens to result in the same corruption for _years_, or it's the > same > > > > bug. > > > > > > The only notable VM patch in Fedora kernels of that vintage that I recall > > > was Ingo's 4g/4g thing. > > > > no the fedora 2.6.18 kernel is affected. > > I wasn't denying that, but Linus was talking about a 2.6.5 Fedora kernel. > > > it carries the same -mm patches that Debian backported > > for LSB 3.1 compliance. > > The only -mm stuff I recall being in the Fedora 2.6.18 is > the inode-diet stuff which ended up in 2.6.19, though the xmas > break has left my head somewhat empty so I may be forgetting something. > What patch in particular are you talking about? it's no longer visible in the FC6 cvs, due to rebase but it's name was linux-2.6-mm-tracking-dirty-pages.patch it is an earlier almagame of the merged patch serie: - mm: tracking shared dirty pages - mm: balance dirty pages - mm: optimize the new mprotect() code a bit - mm: small cleanup of install_page() - mm: fixup do_wp_page() - mm: msync() cleanup (closes: #394392) -- maks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: RFC: removing the dgrs net driver
On Sat, Dec 02, 2006 at 06:19:32PM +0100, Adrian Bunk wrote: > Based on the information in the email forwarded below I'd remove the > dgrs net driver (this wasn't the first driver shipped with the kernel > without any hardware ever produced...). > > Is this OK or is there any doubt whether this information is true? > > cu > Adrian ok thanks for doing this, as the reporter was to lazy to cook up a proper patch for that. there is zero bug report for dgrs on the debian bts nor did i find one in bugzilla.kernel.org. redhat guys might want to verify on their side. > - Forwarded message from Nathanael Nerode <[EMAIL PROTECTED]> - > > Date: Sun, 24 Sep 2006 13:00:12 -0400 > From: Nathanael Nerode <[EMAIL PROTECTED]> > To: netdev@vger.kernel.org > Subject: Please remove useless dgrs driver > > An official email from digi.com to Andres Salomon <[EMAIL PROTECTED]> > explained: > > Dear Andres: > > After further research, we found that this product was killed in place > and never reached the market. We would like to request that this not be > included. > > Copy at http://wiki.debian.org/KernelFirmwareLicensing (this was discovered > during research into firmware licensing). > > The drgs driver is useless (no hardware to drive) and should be removed. > The files which should be deleted from the tree are: > drivers/net/dgrs.c > drivers/net/dgrs.h > drivers/net/dgrs_es4h.h > drivers/net/dgrs_plx9060.h > drivers/net/dgrs_i82596.h > drivers/net/dgrs_ether.h > drivers/net/dgrs_asstruct.h > drivers/net/dgrs_bcomm.h > drivers/net/dgrs_firmware.c > > It will probably also be necessary to delete some stuff from > drivers/net/Kconfig > and drivers/net/Makefile, but I assume that this will be trivial for any > net maintainer. > > Thanks in advance for doing this. > > -- > Nathanael Nerode <[EMAIL PROTECTED]> > > "(Instead, we front-load the flamewars and grudges in > the interest of efficiency.)" --Steve Lanagasek, > http://lists.debian.org/debian-devel/2005/09/msg01056.html > - > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > > - End forwarded message - -- maks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] Kconfig.debug DEBUG_PREEMPT dependency
allow to set DEBUG_PREEMPT on PREEMPT_BKL, but !PREEMPT purpose is to get bonus of debug_smp_processor_id(). Signed-off-by: maximilian attems <[EMAIL PROTECTED]> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index da95e10..1d4ab66 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -145,7 +145,7 @@ config DEBUG_SLAB_LEAK config DEBUG_PREEMPT bool "Debug preemptible kernel" - depends on DEBUG_KERNEL && PREEMPT && TRACE_IRQFLAGS_SUPPORT + depends on DEBUG_KERNEL && (PREEMPT || PREEMPT_BKL) && TRACE_IRQFLAGS_SUPPORT default y help If you say Y here then the kernel will use a debug variant of the - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] Kconfig.debug DEBUG_PREEMPT dependency
On Wed, 06 Jun 2007, maximilian attems wrote: > - depends on DEBUG_KERNEL && PREEMPT && TRACE_IRQFLAGS_SUPPORT > + depends on DEBUG_KERNEL && (PREEMPT || PREEMPT_BKL) && > TRACE_IRQFLAGS_SUPPORT upps please discard needs more work: arch/i386/kernel/built-in.o: In function `show_registers': (.text+0x2e8e): undefined reference to `add_preempt_count' arch/i386/kernel/built-in.o: In function `show_registers': (.text+0x2e9c): undefined reference to `sub_preempt_count' arch/i386/kernel/built-in.o: In function `show_registers': (.text+0x2ef2): undefined reference to `add_preempt_count' arch/i386/kernel/built-in.o: In function `show_registers': (.text+0x2f02): undefined reference to `sub_preempt_count' arch/i386/kernel/built-in.o: In function `is_valid_bugaddr': (.text+0x366c): undefined reference to `add_preempt_count' arch/i386/kernel/built-in.o: In function `is_valid_bugaddr': (.text+0x367b): undefined reference to `sub_preempt_count' arch/i386/kernel/built-in.o: In function `romchecksum': ... -- maks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] MAINTAINERS new kernel janitors ml
davem kindly moved the list from osdl to vger. Signed-of-by: maximilian attems <[EMAIL PROTECTED]> Cc: Alexey Dobriyan <[EMAIL PROTECTED]> Cc: Randy Dunlap <[EMAIL PROTECTED]> diff --git a/MAINTAINERS b/MAINTAINERS index 0fee879..b9e767b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2095,7 +2095,7 @@ S:Maintained KERNEL JANITORS P: Several -L: [EMAIL PROTECTED] +L: [EMAIL PROTECTED] W: http://www.kerneljanitors.org/ S: Maintained - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: bnx2 dirver's firmware images
On Tue, 18 Sep 2007, Michael Chan wrote: > The bnx2 firmware changes quite frequently. A new driver quite often > requires new firmware to work correctly. Splitting them up makes things > difficult for the user. sorry didn't check, what's the license of the firmware? > The firmware in tg3 is a lot more mature and I don't expect it to > change. I think tg3 is better suited for using request_firmware(). well thanks that would help us a lot, we have to strip the firmware for Debian for the upcoming Lenny release. as the shipping exception for the previous 2 releases will not be granted again. so a separate firmware would be great. also afaik only some boards need it. it is a pressing need for us as tg3 with stripped firmware of course doesn't build. -- maks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: bnx2 dirver's firmware images
hello dave, i appreciate a lot your opinon, but please cool down. this is not a four spin on your beloved pipe. :) On Wed, Sep 19, 2007 at 09:38:32AM -0700, David Miller wrote: > From: maximilian attems <[EMAIL PROTECTED]> > Date: Wed, 19 Sep 2007 18:33:18 +0200 > > > we have to strip the firmware for Debian for the upcoming Lenny release. > > Why do you "have to"? The vendor has given you explicit rights > to distribute it: > > * Firmware is: > *Derived from proprietary unpublished source code, > *Copyright (C) 2000-2003 Broadcom Corporation. > * > *Permission is hereby granted for the distribution of this firmware > *data in hexadecimal or equivalent format, provided this copyright > *notice is accompanying it. afair the trouble is that it does not give permission to change unlike some other gpl or bsd licensed blob. so it is dfsg non-free and not suitable for main distribution. > This whole firmware stripping thing in debian is beyond rediculious > and only serves to hurt users. i'm not of the d-legal department, but seeing free firmwares would be cool. -- maks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: bnx2 dirver's firmware images
On Tue, 18 Sep 2007, Sam Ravnborg wrote: > Anyway - if we again consider klibc I will do my best to make the > build stuff as smooth as possible. > > Sam currently klibc has tendency to rebuild a bit too much if you touch some part of it, seen in usr/utils for the main klibc i agree that it makes sense -- maks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: bnx2 dirver's firmware images
On Wed, Sep 19, 2007 at 10:12:38AM -0700, H. Peter Anvin wrote: > > Could you give a concrete example? > > -hpa [EMAIL PROTECTED]:~/src/klibc$ touch usr/utils/mount_main.c [EMAIL PROTECTED]:~/src/klibc$ make KLIBCCC usr/utils/mount_main.o KLIBCLD usr/utils/static/halt LN usr/utils/static/reboot LN usr/utils/static/poweroff KLIBCLD usr/utils/shared/halt LN usr/utils/shared/reboot LN usr/utils/shared/poweroff KLIBCLD usr/utils/static/chroot KLIBCLD usr/utils/static/dd -- maks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] bnx2: factor out gzip unpacker
On Fri, Sep 21, 2007 at 11:48:05PM +0100, Alan Cox wrote: > > According to an earlier thread, dgrs was never really maintained, > > written for hardware that was never really distributed widely, and very > > likely hasn't had users in years... if ever. > > > > If that picture is accurate (it's a story I was told), then I am > > definitely queueing up a deletion patch. > > I think thats sensible. If someone whines it can be put back but I really > don't think anyone will nobody did yet, please yell if you need a rebased patch. -- maks - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] builddeb: fix stripped module signatures if CONFIG_DEBUG_INFO and CONFIG_MODULE_SIG_ALL are set
On Tue, Apr 21, 2015 at 03:58:48PM +0200, Michal Marek wrote: > (added Max to Cc) > > On 2015-03-16 09:20, Andrey Skvortsov wrote: > > If CONFIG_MODULE_SIG_ALL is set, then user expects that all modules are > > automatically signed in the result package, as it's for rpm-pkg, binrpm-pkg, > > tar, tar-*. For deb-pkg this is correct only if CONFIG_DEBUG_INFO > > is NOT set. In that case deb-package contains signed modules. > > > > But if CONFIG_DEBUG_INFO is set, builddeb creates separate package with > > debug information. To do that, debug information from all modules > > is copied into separate files by objcopy. And loadable kernel modules are > > stripped afterwards. Stripping removes previously (during modules_install) > > added signatures from loadable kernel modules. Therefore final deb-package > > contains unsigned modules despite of set option CONFIG_MODULE_SIG_ALL. > > > > This patch resigns all stripped modules if CONFIG_MODULE_SIG_ALL is set > > to solve this problem. > > > > Signed-off-by: Andrey Skvortsov > > Max, Ben, are you fine with this patch? It looks OK to me, the > modules_sign target has been added for this very purpose. > Ben seems busy with the release, so jumping in. The patch looks perfect to me. Acked-by: maximilian attems -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] scripts/package/builddeb: upgrade to current practices
On Tue, Jul 17, 2012 at 10:46:23PM +0300, Martin-Éric Racine wrote: > 2012/7/17 Jonathan Nieder : > >> > >> Package: $fwpackagename > >> Architecture: all > >> +Conflicts: firmware-linux-free, firmware-linux-nonfree > >> +Provides: firmware-linux-free, firmware-linux-nonfree > >> +Replaces: firmware-linux-free, firmware-linux-nonfree > > > > I assume you mean Breaks+Replaces. Do the files actually overlap, > > or is this change being overly cautious? I would expect the files > > not to overlap because the package build with deb-pkg puts firmware > > in a versioned subdirectory "/lib/firmware/". > > AFAIK they would overlap, hence the Conflicts. This is wrong and properly fixed in -next. -- maks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] kexec.h: stop exporting kexec_load() to userspace
On Wed, Jan 15, 2014 at 02:17:04PM +0100, Paul Bolle wrote: > Since v3.5 kexec.h is exported to userspace. That includes its > declaration of kexec_load(): > extern int kexec_load(void *, size_t, struct kexec_segment *, >unsigned long int); > > This declaration isn't very useful to userspace programs on itself. They > still have to define a matching function (which basically wraps the > kexec_load syscall). I'm not aware of programs or libraries that actually > do that. > > It can be removed. The programs that actually use it, if there > are any, should then provide their own declaration to keep compiling. > Already compiled binaries will not be affected. nack, klibc uses the header and there was some discussion that glibc could/should use it too. I didn't follow kexec git, but there is/was a version that just uses the kexec_load() if the c library provides it. Until Santa Claus materialises in form of a direct kernel user-space API, see follow ups on http://lwn.net/Articles/534682/ and proposal by hpa > This gets rid of the headers_check warning that can be seen ever since > this header was exported: > [...]/usr/include/linux/kexec.h:49: userspace cannot reference function > or variable defined in the kernel > this is the wrong way of fix. -- maks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] builddeb: fix stripped module signatures if CONFIG_DEBUG_INFO and CONFIG_MODULE_SIG_ALL are set
Hello Michal, On Wed, May 06, 2015 at 03:30:28PM +0200, Michal Marek wrote: > > I applied the patch to kbuild.git#misc now, after fixing the whitespace. > Andrey, please use tabs for indentation, especially when the surrounding > code is already using this style. please apply this arm thingy too: - [PATCHv4 1/1] deb-pkg: Add device tree blobs to the package reviewed by ben and acked by me. 20150203121648.046396...@rtp-net.org thanks, -- maks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/