date:20120730

Re: [PATCH] Fix VIDIOC_TRY_EXT_CTRLS regression

2012-07-30 Thread Hans Verkuil

On Mon July 30 2012 03:25:58 Mauro Carvalho Chehab wrote:
 Em 18-07-2012 10:34, Hans Verkuil escreveu:
  Hi all,
  
  This patch fixes an omission in the new v4l2_ioctls table: 
  VIDIOC_TRY_EXT_CTRLS
  must get the INFO_FL_CTRL flag, just like all the other control related 
  ioctls.
  
  Otherwise the ioctl core won't know it also has to check whether 
  v4l2_fh-ctrl_handler
  is non-zero before it can decide that this ioctl is not implemented.
  
  Caught by v4l2-compliance while I was testing the mem2mem_testdev driver.
 
 Missing SOB. It seems Steven asked for this fix. Did he test? If so, it would 
 be
 nice to get his tested-by:.

Oops!

Here it is:

Signed-off-by: Hans Verkuil hans.verk...@cisco.com

Welcome back!

Regards,

Hans

 
 Regards,
 Mauro
  
  Regards,
  
  Hans
  
  diff --git a/drivers/media/video/v4l2-ioctl.c 
  b/drivers/media/video/v4l2-ioctl.c
  index 70e0efb..17dff31 100644
  --- a/drivers/media/video/v4l2-ioctl.c
  +++ b/drivers/media/video/v4l2-ioctl.c
  @@ -1900,7 +1900,7 @@ static struct v4l2_ioctl_info v4l2_ioctls[] = {
  IOCTL_INFO_FNC(VIDIOC_LOG_STATUS, v4l_log_status, v4l_print_newline, 0),
  IOCTL_INFO_FNC(VIDIOC_G_EXT_CTRLS, v4l_g_ext_ctrls, 
  v4l_print_ext_controls, INFO_FL_CTRL),
  IOCTL_INFO_FNC(VIDIOC_S_EXT_CTRLS, v4l_s_ext_ctrls, 
  v4l_print_ext_controls, INFO_FL_PRIO | INFO_FL_CTRL),
  -   IOCTL_INFO_FNC(VIDIOC_TRY_EXT_CTRLS, v4l_try_ext_ctrls, 
  v4l_print_ext_controls, 0),
  +   IOCTL_INFO_FNC(VIDIOC_TRY_EXT_CTRLS, v4l_try_ext_ctrls, 
  v4l_print_ext_controls, INFO_FL_CTRL),
  IOCTL_INFO_STD(VIDIOC_ENUM_FRAMESIZES, vidioc_enum_framesizes, 
  v4l_print_frmsizeenum, INFO_FL_CLEAR(v4l2_frmsizeenum, pixel_format)),
  IOCTL_INFO_STD(VIDIOC_ENUM_FRAMEINTERVALS, vidioc_enum_frameintervals, 
  v4l_print_frmivalenum, INFO_FL_CLEAR(v4l2_frmivalenum, height)),
  IOCTL_INFO_STD(VIDIOC_G_ENC_INDEX, vidioc_g_enc_index, 
  v4l_print_enc_idx, 0),
  --
  To unsubscribe from this list: send the line unsubscribe linux-media in
  the body of a message to majord...@vger.kernel.org
  More majordomo info at  http://vger.kernel.org/majordomo-info.html
  
 
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 2/2] Initial version of RDS Control utility Signed-off-by: Konke Radlow krad...@cisco.com

2012-07-30 Thread Hans Verkuil

On Sat July 28 2012 13:11:13 Hans de Goede wrote:
 Hi,
 
 Overall this looks good, but some of the code, for example the set/get freq 
 and
 get/set tuner stuff seems to be a 1 on 1 copy of code from v4l2-ctrl, please
 factor this out into a common file which can be shared between both
 utilities (I think Hans V's recent work on splitting v4l2-ctl into multiple
 files comes a long way towards this).

I'm not sure how valuable this is. If we do this, then that means a fair amount
of work in v4l2-ctl (although the split was a major step forward in that 
direction).

There are a bunch of utilities that all share some common code in that respect.
But they are all stand-alone and I would have to think carefully how to organize
the code if you want to make it easy to share code.

Bottom-line: let's keep this as a separate project and not mix it with rds-ctl.

Regards,

Hans

 
 Regards,
 
 Hans
 
 On 07/25/2012 07:44 PM, Konke Radlow wrote:
  ---
Makefile.am   |3 +-
configure.ac  |1 +
utils/rds-ctl/Makefile.am |5 +
utils/rds-ctl/rds-ctl.cpp |  978 
  +
4 files changed, 986 insertions(+), 1 deletion(-)
create mode 100644 utils/rds-ctl/Makefile.am
create mode 100644 utils/rds-ctl/rds-ctl.cpp
 
  diff --git a/Makefile.am b/Makefile.am
  index 6707f5f..47103a1 100644
  --- a/Makefile.am
  +++ b/Makefile.am
  @@ -18,7 +18,8 @@ SUBDIRS += \
  utils/v4l2-compliance \
  utils/v4l2-ctl \
  utils/v4l2-dbg \
  -   utils/v4l2-sysfs-path
  +   utils/v4l2-sysfs-path \
  +   utils/rds-ctl
 
if LINUX_OS
SUBDIRS += \
  diff --git a/configure.ac b/configure.ac
  index 1d7eb29..1ad99e6 100644
  --- a/configure.ac
  +++ b/configure.ac
  @@ -28,6 +28,7 @@ AC_CONFIG_FILES([Makefile
  utils/v4l2-sysfs-path/Makefile
  utils/xc3028-firmware/Makefile
  utils/qv4l2/Makefile
  +   utils/rds-ctl/Makefile
 
  contrib/freebsd/Makefile
  contrib/test/Makefile
  diff --git a/utils/rds-ctl/Makefile.am b/utils/rds-ctl/Makefile.am
  new file mode 100644
  index 000..9a84257
  --- /dev/null
  +++ b/utils/rds-ctl/Makefile.am
  @@ -0,0 +1,5 @@
  +bin_PROGRAMS = rds-ctl
  +
  +rds_ctl_SOURCES = rds-ctl.cpp
  +rds_ctl_LDADD = ../../lib/libv4l2/libv4l2.la 
  ../../lib/libv4l2rds/libv4l2rds.la
  +
  diff --git a/utils/rds-ctl/rds-ctl.cpp b/utils/rds-ctl/rds-ctl.cpp
  new file mode 100644
  index 000..8ddb969
  --- /dev/null
  +++ b/utils/rds-ctl/rds-ctl.cpp
  @@ -0,0 +1,978 @@
  +/*
  + * rds-ctl.cpp is based on v4l2-ctl.cpp
  + *
  + * the following applies for all RDS related parts:
  + * Copyright 2012 Cisco Systems, Inc. and/or its affiliates. All rights 
  reserved.
  + * Author: Konke Radlow korad...@gmail.com
  + *
  + * This program is free software; you can redistribute it and/or modify
  + * it under the terms of the GNU Lesser General Public License as 
  published by
  + * the Free Software Foundation; either version 2.1 of the License, or
  + * (at your option) any later version.
  + *
  + * This program is distributed in the hope that it will be useful,
  + * but WITHOUT ANY WARRANTY; without even the implied warranty of
  + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  + * GNU General Public License for more details.
  + *
  + * You should have received a copy of the GNU General Public License
  + * along with this program; if not, write to the Free Software
  + * Foundation, Inc., 51 Franklin Street, Suite 500, Boston, MA  02110-1335 
   USA
  + */
  +
  +#include unistd.h
  +#include stdlib.h
  +#include stdio.h
  +#include string.h
  +#include wchar.h
  +#include locale.h
  +#include inttypes.h
  +#include getopt.h
  +#include sys/types.h
  +#include fcntl.h
  +#include errno.h
  +#include sys/ioctl.h
  +#include sys/time.h
  +#include dirent.h
  +#include config.h
  +#include signal.h
  +
  +#ifdef HAVE_SYS_KLOG_H
  +#include sys/klog.h
  +#endif
  +
  +#include linux/videodev2.h
  +#include libv4l2.h
  +#include libv4l2rds.h
  +
  +#include list
  +#include vector
  +#include map
  +#include string
  +#include algorithm
  +
  +#define ARRAY_SIZE(arr) ((int)(sizeof(arr) / sizeof((arr)[0])))
  +
  +typedef std::vectorstd::string dev_vec;
  +typedef std::mapstd::string, std::string dev_map;
  +
  +/* Short option list
  +
  +   Please keep in alphabetical order.
  +   That makes it easier to see which short options are still free.
  +
  +   In general the lower case is used to set something and the upper
  +   case is used to retrieve a setting. */
  +enum Option {
  +   OptSetDevice = 'd',
  +   OptGetDriverInfo = 'D',
  +   OptGetFreq = 'F',
  +   OptSetFreq = 'f',
  +   OptHelp = 'h',
  +   OptReadRds = 'R',
  +   OptGetTuner = 'T',
  +   OptSetTuner = 't',
  +   OptUseWrapper = 'w',
  +   OptAll = 128,
  +   OptFreqSeek,
  +   OptListDevices,
  +   OptOpenFile,
  +   OptPrintBlock,
  +   OptSilent,
  +   OptTunerIndex,
  +   OptVerbose,
  +

Re: rtl28xxu - rtl2832 frontend attach

2012-07-30 Thread poma

On 06/27/2012 07:21 AM, Thomas Mair wrote:
On 26.06.2012 19:17, poma wrote:
On 05/28/2012 04:48 PM, Thomas Mair wrote:
On 28.05.2012 08:58, Thomas Mair wrote:
On 26.05.2012 04:47, poma wrote:
On 05/20/2012 11:12 PM, Thomas Mair wrote:
On 20.05.2012 22:08, Antti Palosaari wrote:
On 20.05.2012 20:04, poma wrote:
After hard/cold boot:

DVB: register adapter0/net0 @ minor: 2 (0x02)
rtl2832u_frontend_attach:
rtl28xxu_ctrl_msg: failed=-32
rtl28xxu_ctrl_msg: failed=-32
rtl28xxu_ctrl_msg: failed=-32
rtl28xxu_ctrl_msg: failed=-32
rtl28xxu_ctrl_msg: failed=-32
rtl28xxu_ctrl_msg: failed=-32
rtl28xxu_ctrl_msg: failed=-32
rtl28xxu_ctrl_msg: failed=-32
rtl28xxu_ctrl_msg: failed=-32
rtl28xxu_ctrl_msg: failed=-32
No compatible tuner found

These errors are coming from tuner probe. As it still goes to probing
and did not jump out earlier when gate is opened it means that demod is
answering commands but tuner are not.

My guess is that tuner is still on the reset or not powered at all. It
is almost 100% sure error is wrong tuner GPIO.

There is an issue with GPIO, as FC0012 tuner callback will set
the value of one of the GPIO outputs. However fixing that, will
not resolve the issue. So I need to debug the problem further.

True. Whatever a value is changed - 'rtl2832u_power_ctrl', it brakes
even more.
Precisely, what breaks a tuner on next soft [re]boot are apps/utils
which engage tzap/scan[dvb].

To reproduce the bug it is not necessary to reboot the machine. Simply
unload and load of the dvb_usb_rtl28xxu module will lead to the same
situation.

I suspect, that when power is turned off, the tuner power is not
switched on correctly. The mistake is not related to the OUTPUT_VAL
registers but probably to the OUTPUT_DIR or OUTPUT_EN registers.

What makes me wonder is if no tuning operation is performed before
reboot, the driver does work correctly after that, as poma already
noticed.

I have some spare time today and will investigate the problem further.

I tried a few things regarding the problem today and could find out a
few more details, but could not resolve the issue.

The GPIO pin configuration for the devices with the fc0012 (and probably
also with the fc0013) tuner is the following:

GPIO0: demod power
GPIO3: tuner power? (the realtek driver puts this to 1 and never touches it
again)
GPIO4: tuner power? (maybe antenna power?)
GPIO5: tuner reset
GPIO6: UHF/VHF band selection

All of these GPIOs are configured as output. When the device is plugged in
the tuner is powered up correctly, but I am not able to power it up when
a reboot is performed. What I tried was the following:

- on rtl28xxu_power_ctrl off:
- GPIO4 = 1 (off)
- GPIO5 = 0
- GPIO6 = 0 (default state)

- on rtl28xxu_power_ctrl on:
- GPIO3 = 1
- GPIO4 = 0 (on)
- GPIO5 = 0
- GPIO6 = 0 (default state)

- on rtl2832_frontend_attach:
- GPIO5 = 1
- GPIO5 = 0

This sequence should ensure that the tuner is powered on when the frontend
is attached, and a tuner reset is being performed before the tuner is
probed.
However this sequence fails the same way as it did before. I tried to add
timeouts to be sure that the tuner is not probed while it is reset but that
did not help either.

Right now I really don't know where I should look for the solution of
the problem. It seems that the tuner reset does not have any effect on the
tuner whatsoever.

Is there anybody who could look at the code, or maybe knows what could be
the cause of the problem? I suspect I am just too blind to see my own
mistakes.

Regards
Thomas

Cheers Thomas, Hans-Frieder, Antti, Mauro!
Hans-Frieder, are you having the same issue with fc0011af9035?
Antti, no tricks up your sleeve?
Senhor Mauro, is rtl2832 demod going to be merged?

regards,
poma

Hi all,

I will try to solve the issue as soon as I have some spare time. In the
meantime I
asked Realtek if they knew of any problems with the hardware, and I got a GPIO
list which might help me to solve the problem.

Regrads
Thomas

This is correspondent code by dbasden - fc0012 for rtl-sdr GPIOs
https://gist.github.com/2171926#120
David, can you help with this tuner issue?
http://git.linuxtv.org/anttip/media_tree.git/blob/3efd26330fda97e06279cbca170ae4a0dee53220:/drivers/media/dvb/dvb-usb/rtl28xxu.c#l898

Cheers,
poma

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: GPIO interface between DVB sub-drivers (bridge, demod, tuner)

2012-07-30 Thread Antti Palosaari


On 07/30/2012 12:21 AM, poma wrote:

On 07/20/2012 03:43 AM, Antti Palosaari wrote:

On 07/13/2012 12:07 AM, Steven Toth wrote:

On Thu, Jul 12, 2012 at 4:49 PM, Steven Toth st...@kernellabs.com
wrote:

Nobody understands the relationship between the bridge and the
sub-component as well as the bridge driver. The current interfaces are
limiting in many ways. We solve that today with rather ugly 'attach'
structures that are inflexible, for example to set gpios to a default
state.
Then, once that interface is attached, the bridge effectively loses
most of
the control to the tuner and/or demod. The result is a large disconnect
between the bridge and subcomponents.

Why limit any interface extension to GPIOs? Why not make something a
little more flexible so we can pass custom messages around?



What did you ever decide about the enable/disable of the LNA? And, how
would the bridge do that in your proposed solution? Via the proposed
GPIO
interface?


GPIO / LNA is ready, see following patches:
add LNA support for DVB API
cxd2820r: use Kernel GPIO for GPIO access
em28xx: implement FE set_lna() callback

from:
http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/dvb_core

Kernel GPIOs were quite easy to implement and use - when needed
knowledge was gathered after all the testing and study. I wonder why
none was done that earlier for DVB...

It also offer nice debug/devel feature as you can mount those GPIOs via
sysfs and use directly.



Above mentioned GPIO functionality must be implemented in driver itself
to use /sys/class/gpio/… sysfs interface, right?
It is not enough to build kernel with CONFIG_GENERIC_GPIO=y,
CONFIG_GPIOLIB=y, CONFIG_GPIO_SYSFS, right?


You will need to implement callbacks for gpiolib. sysfs interface is 
then get for free.


regards
Antti

--
http://palosaari.fi/
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH v2 3/4] media: videobuf2-dma-contig: use dma_mmap_coherent if available

2012-07-30 Thread Marek Szyprowski

Hello,

On Thursday, July 26, 2012 1:13 PM Hideki EIRAKU wrote:

 Previously the vb2_dma_contig_mmap() function was using a dma_addr_t as a
 physical address.  The two addressses are not necessarily the same.
 For example, when using the IOMMU funtion on certain platforms, dma_addr_t
 addresses are not directly mappable physical address.
 dma_mmap_coherent() maps the address correctly.
 It is available on ARM platforms.
 
 Signed-off-by: Hideki EIRAKU h...@igel.co.jp
 ---
  drivers/media/video/videobuf2-dma-contig.c |   18 ++
  1 files changed, 18 insertions(+), 0 deletions(-)
 
 diff --git a/drivers/media/video/videobuf2-dma-contig.c 
 b/drivers/media/video/videobuf2-dma-
 contig.c
 index 4b71326..4dc85ab 100644
 --- a/drivers/media/video/videobuf2-dma-contig.c
 +++ b/drivers/media/video/videobuf2-dma-contig.c
 @@ -101,14 +101,32 @@ static unsigned int vb2_dma_contig_num_users(void 
 *buf_priv)
  static int vb2_dma_contig_mmap(void *buf_priv, struct vm_area_struct *vma)
  {
   struct vb2_dc_buf *buf = buf_priv;
 +#ifdef ARCH_HAS_DMA_MMAP_COHERENT
 + int ret;
 +#endif
 
   if (!buf) {
   printk(KERN_ERR No buffer to map\n);
   return -EINVAL;
   }
 
 +#ifdef ARCH_HAS_DMA_MMAP_COHERENT
 + vma-vm_page_prot = pgprot_noncached(vma-vm_page_prot);

The above line is not needed. It is up to dma_mmap_coherent() / 
dma_mmap_attrs() to set page
protection bits which match requested type of dma buffer mapping.

 + ret = dma_mmap_coherent(buf-conf-dev, vma, buf-vaddr, buf-dma_addr,
 + buf-size);
 + if (ret) {
 + pr_err(Remapping memory failed, error: %d\n, ret);
 + return ret;
 + }
 + vma-vm_flags |= VM_DONTEXPAND | VM_RESERVED;
 + vma-vm_private_data = buf-handler;
 + vma-vm_ops = vb2_common_vm_ops;
 + vma-vm_ops-open(vma);
 + return 0;
 +#else
   return vb2_mmap_pfn_range(vma, buf-dma_addr, buf-size,
 vb2_common_vm_ops, buf-handler);
 +#endif
  }
 
  static void *vb2_dma_contig_get_userptr(void *alloc_ctx, unsigned long vaddr,

Best regards
-- 
Marek Szyprowski
Samsung Poland RD Center


--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] media: i.MX27: Fix mx2_emmaprp mem2mem driver clocks.

2012-07-30 Thread Javier Martin

This driver wasn't converted to the new clock framework
(e038ed50a4a767add205094c035b6943e7b30140).

Signed-off-by: Javier Martin javier.mar...@vista-silicon.com
---
 This is broken in current stable 3.5 too. So it should be applied
 to both stable and 3.6.

---
 drivers/media/video/mx2_emmaprp.c |   27 ---
 1 file changed, 16 insertions(+), 11 deletions(-)

diff --git a/drivers/media/video/mx2_emmaprp.c 
b/drivers/media/video/mx2_emmaprp.c
index 0bd5815..2614a89 100644
--- a/drivers/media/video/mx2_emmaprp.c
+++ b/drivers/media/video/mx2_emmaprp.c
@@ -209,7 +209,7 @@ struct emmaprp_dev {
 
int irq_emma;
void __iomem*base_emma;
-   struct clk  *clk_emma;
+   struct clk  *clk_emma_ahb, *clk_emma_ipg;
struct resource *res_emma;
 
struct v4l2_m2m_dev *m2m_dev;
@@ -800,7 +800,8 @@ static int emmaprp_open(struct file *file)
return ret;
}
 
-   clk_enable(pcdev-clk_emma);
+   clk_prepare_enable(pcdev-clk_emma_ipg);
+   clk_prepare_enable(pcdev-clk_emma_ahb);
ctx-q_data[V4L2_M2M_SRC].fmt = formats[1];
ctx-q_data[V4L2_M2M_DST].fmt = formats[0];
 
@@ -816,7 +817,8 @@ static int emmaprp_release(struct file *file)
 
dprintk(pcdev, Releasing instance %p\n, ctx);
 
-   clk_disable(pcdev-clk_emma);
+   clk_disable_unprepare(pcdev-clk_emma_ahb);
+   clk_disable_unprepare(pcdev-clk_emma_ipg);
v4l2_m2m_ctx_release(ctx-m2m_ctx);
kfree(ctx);
 
@@ -876,9 +878,15 @@ static int emmaprp_probe(struct platform_device *pdev)
 
spin_lock_init(pcdev-irqlock);
 
-   pcdev-clk_emma = clk_get(pdev-dev, NULL);
-   if (IS_ERR(pcdev-clk_emma)) {
-   ret = PTR_ERR(pcdev-clk_emma);
+   pcdev-clk_emma_ipg = devm_clk_get(pdev-dev, ipg);
+   if (IS_ERR(pcdev-clk_emma_ipg)) {
+   ret = PTR_ERR(pcdev-clk_emma_ipg);
+   goto free_dev;
+   }
+
+   pcdev-clk_emma_ahb = devm_clk_get(pdev-dev, ahb);
+   if (IS_ERR(pcdev-clk_emma_ipg)) {
+   ret = PTR_ERR(pcdev-clk_emma_ahb);
goto free_dev;
}
 
@@ -887,12 +895,12 @@ static int emmaprp_probe(struct platform_device *pdev)
if (irq_emma  0 || res_emma == NULL) {
dev_err(pdev-dev, Missing platform resources data\n);
ret = -ENODEV;
-   goto free_clk;
+   goto free_dev;
}
 
ret = v4l2_device_register(pdev-dev, pcdev-v4l2_dev);
if (ret)
-   goto free_clk;
+   goto free_dev;
 
mutex_init(pcdev-dev_mutex);
 
@@ -965,8 +973,6 @@ rel_vdev:
video_device_release(vfd);
 unreg_dev:
v4l2_device_unregister(pcdev-v4l2_dev);
-free_clk:
-   clk_put(pcdev-clk_emma);
 free_dev:
kfree(pcdev);
 
@@ -983,7 +989,6 @@ static int emmaprp_remove(struct platform_device *pdev)
v4l2_m2m_release(pcdev-m2m_dev);
vb2_dma_contig_cleanup_ctx(pcdev-alloc_ctx);
v4l2_device_unregister(pcdev-v4l2_dev);
-   clk_put(pcdev-clk_emma);
kfree(pcdev);
 
return 0;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] media: i.MX27: Fix mx2_emmaprp mem2mem driver clocks.

2012-07-30 Thread Sylwester Nawrocki

Hi,

On 07/30/2012 10:37 AM, Javier Martin wrote:
 This driver wasn't converted to the new clock framework
 (e038ed50a4a767add205094c035b6943e7b30140).
 
 Signed-off-by: Javier Martin javier.mar...@vista-silicon.com
 ---
  This is broken in current stable 3.5 too. So it should be applied
  to both stable and 3.6.

The you should add Cc: sta...@vger.kernel.org line along with
your sign-off, ideally mentioning in the patch description to
what stable kernels it applies, and it would all be handled
automatically.
I guess Mauro is going to add that missing Cc, when applying the
patch though.

--

Regards,
Sylwester
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/1] v4l: Add missing compatibility definitions for bounds rectangles

2012-07-30 Thread Sakari Ailus

Compatibility defines for ACTUAL subdev selection rectangles were added and
also the name of the BOUNDS rectangles was changed in the process, which,
alas, went unnoticed until now. Add compatibility definitions for these
rectangles.

Signed-off-by: Sakari Ailus sakari.ai...@iki.fi
---
 include/linux/v4l2-common.h |8 
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/linux/v4l2-common.h b/include/linux/v4l2-common.h
index 0fa8b64..4f0667e 100644
--- a/include/linux/v4l2-common.h
+++ b/include/linux/v4l2-common.h
@@ -53,10 +53,10 @@
 /* Backward compatibility target definitions --- to be removed. */
 #define V4L2_SEL_TGT_CROP_ACTIVE   V4L2_SEL_TGT_CROP
 #define V4L2_SEL_TGT_COMPOSE_ACTIVEV4L2_SEL_TGT_COMPOSE
-#define V4L2_SUBDEV_SEL_TGT_CROP_ACTUAL \
-   V4L2_SEL_TGT_CROP
-#define V4L2_SUBDEV_SEL_TGT_COMPOSE_ACTUAL \
-   V4L2_SEL_TGT_COMPOSE
+#define V4L2_SUBDEV_SEL_TGT_CROP_ACTUALV4L2_SEL_TGT_CROP
+#define V4L2_SUBDEV_SEL_TGT_COMPOSE_ACTUAL V4L2_SEL_TGT_COMPOSE
+#define V4L2_SUBDEV_SEL_TGT_CROP_BOUNDSV4L2_SEL_TGT_CROP_BOUNDS
+#define V4L2_SUBDEV_SEL_TGT_COMPOSE_BOUNDS V4L2_SEL_TGT_COMPOSE_BOUNDS
 
 /* Selection flags */
 #define V4L2_SEL_FLAG_GE   (1  0)
-- 
1.7.2.5

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] v4l: Add missing compatibility definitions for bounds rectangles

2012-07-30 Thread Laurent Pinchart

Hi Sakari,

Thanks for the patch.

On Monday 30 July 2012 12:08:47 Sakari Ailus wrote:
 Compatibility defines for ACTUAL subdev selection rectangles were added and
 also the name of the BOUNDS rectangles was changed in the process, which,
 alas, went unnoticed until now. Add compatibility definitions for these
 rectangles.
 
 Signed-off-by: Sakari Ailus sakari.ai...@iki.fi

Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

 ---
  include/linux/v4l2-common.h |8 
  1 files changed, 4 insertions(+), 4 deletions(-)
 
 diff --git a/include/linux/v4l2-common.h b/include/linux/v4l2-common.h
 index 0fa8b64..4f0667e 100644
 --- a/include/linux/v4l2-common.h
 +++ b/include/linux/v4l2-common.h
 @@ -53,10 +53,10 @@
  /* Backward compatibility target definitions --- to be removed. */
  #define V4L2_SEL_TGT_CROP_ACTIVE V4L2_SEL_TGT_CROP
  #define V4L2_SEL_TGT_COMPOSE_ACTIVE  V4L2_SEL_TGT_COMPOSE
 -#define V4L2_SUBDEV_SEL_TGT_CROP_ACTUAL \
 - V4L2_SEL_TGT_CROP
 -#define V4L2_SUBDEV_SEL_TGT_COMPOSE_ACTUAL \
 - V4L2_SEL_TGT_COMPOSE
 +#define V4L2_SUBDEV_SEL_TGT_CROP_ACTUAL  V4L2_SEL_TGT_CROP
 +#define V4L2_SUBDEV_SEL_TGT_COMPOSE_ACTUAL V4L2_SEL_TGT_COMPOSE
 +#define V4L2_SUBDEV_SEL_TGT_CROP_BOUNDS  V4L2_SEL_TGT_CROP_BOUNDS
 +#define V4L2_SUBDEV_SEL_TGT_COMPOSE_BOUNDS V4L2_SEL_TGT_COMPOSE_BOUNDS
 
  /* Selection flags */
  #define V4L2_SEL_FLAG_GE (1  0)

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[GIT PULL FOR 3.6] Selection API compatibility fix, small SMIA++ correction

2012-07-30 Thread Sakari Ailus

Hi Mauro,

This pull request contains an important for for the compatibility
definitions of the bounds rectangles. They were missing from the original
patches changing the selection rectangles.

There's an one-liner to fix double include in the SMIA++ driver, too.

Please pull:

The following changes since commit 931efdf58bd83af8d0578a6cc53421675daf6d41:
  
  Merge branch 'v4l_for_linus' into staging/for_v3.6 (2012-07-14 15:45:44 -0300)

are available in the git repository at:
  
  ssh://linuxtv.org/git/sailus/media_tree.git media-for-3.6

Duan Jiong (1):
  smiapp: remove duplicated include

Sakari Ailus (1):
  v4l: Add missing compatibility definitions for bounds rectangles
 
 drivers/media/video/smiapp/smiapp-core.c |1 -
 include/linux/v4l2-common.h  |8 
 2 files changed, 4 insertions(+), 5 deletions(-)

Kind regards,

-- 
Sakari Ailus
e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 0/2] Add support for RDS decoding

2012-07-30 Thread Konke Radlow

thank you for the info, it's working now
(I went for the include solution)
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: rtl28xxu - rtl2832 frontend attach

2012-07-30 Thread David Basden

On Mon, Jul 30, 2012 at 09:06:54AM +0200, poma wrote:
On 06/27/2012 07:21 AM, Thomas Mair wrote:
On 26.06.2012 19:17, poma wrote:
On 05/28/2012 04:48 PM, Thomas Mair wrote:
On 28.05.2012 08:58, Thomas Mair wrote:
On 26.05.2012 04:47, poma wrote:
On 05/20/2012 11:12 PM, Thomas Mair wrote:
On 20.05.2012 22:08, Antti Palosaari wrote:
On 20.05.2012 20:04, poma wrote:
After hard/cold boot:

These errors are coming from tuner probe. As it still goes to probing
and did not jump out earlier when gate is opened it means that demod
is answering commands but tuner are not.

My guess is that tuner is still on the reset or not powered at all.
It is almost 100% sure error is wrong tuner GPIO.