Re: [RFC/PATCH 0/5] v4l: New camera controls

2011-12-10 Thread Sakari Ailus
Hi, all!

On Wed, Dec 07, 2011 at 11:32:38AM +0100, Sylwester Nawrocki wrote:
 Hi Laurent,
 
 On 12/06/2011 01:34 PM, Laurent Pinchart wrote:
  On Sunday 04 December 2011 16:16:11 Sylwester Nawrocki wrote:
  Hi All,
 
  I put some effort in preparing a documentation for a couple of new controls
  in the camera control class. It's a preeliminary work, it's mainly just
  documentation. There is yet no patches for any driver using these controls.
  I just wanted to get some possible feedback on them, if this sort of stuff
  is welcome and what might need to be done differently.
  
  Thanks for the patches.
  
  Regarding patches 3/5, 4/5 and 5/5, we should perhaps try to brainstorm 
  this a 
  bit. There's more to exposure setting than just those controls, maybe it's 
  time to think about a proper exposure API. We could start by gathering 
  requirements on the list, and maybe have an IRC meeting if needed.
 
 Certainly the existing support for exposure setting in V4L2 is not sufficient
 even for mobile camera control. I'll try to prepare a list of requirements.
 It would be great to have a brainstorming session with more people experienced
 in this field.

IRC meeting?

The proposed controls seem useful for high level control --- for example,
ISO means a combination of digital and analog gain, and also the unit is
different. In general, I think that even if the three are concerned with
similar issues, the ISO control definitely should belong to a different
class: it requires making policy decisions rather than just providing access
to the sensor features.

Cheers,

-- 
Sakari Ailus
e-mail: sakari.ai...@iki.fi jabber/XMPP/Gmail: sai...@retiisi.org.uk
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC/PATCH 0/5] v4l: New camera controls

2011-12-07 Thread Sylwester Nawrocki
Hi Laurent,

On 12/06/2011 01:34 PM, Laurent Pinchart wrote:
 On Sunday 04 December 2011 16:16:11 Sylwester Nawrocki wrote:
 Hi All,

 I put some effort in preparing a documentation for a couple of new controls
 in the camera control class. It's a preeliminary work, it's mainly just
 documentation. There is yet no patches for any driver using these controls.
 I just wanted to get some possible feedback on them, if this sort of stuff
 is welcome and what might need to be done differently.
 
 Thanks for the patches.
 
 Regarding patches 3/5, 4/5 and 5/5, we should perhaps try to brainstorm this 
 a 
 bit. There's more to exposure setting than just those controls, maybe it's 
 time to think about a proper exposure API. We could start by gathering 
 requirements on the list, and maybe have an IRC meeting if needed.

Certainly the existing support for exposure setting in V4L2 is not sufficient
even for mobile camera control. I'll try to prepare a list of requirements.
It would be great to have a brainstorming session with more people experienced
in this field.


Regards,
-- 
Sylwester Nawrocki
Samsung Poland RD Center
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC/PATCH 0/5] v4l: New camera controls

2011-12-06 Thread Laurent Pinchart
Hi Sylwester,

On Sunday 04 December 2011 16:16:11 Sylwester Nawrocki wrote:
 Hi All,
 
 I put some effort in preparing a documentation for a couple of new controls
 in the camera control class. It's a preeliminary work, it's mainly just
 documentation. There is yet no patches for any driver using these controls.
 I just wanted to get some possible feedback on them, if this sort of stuff
 is welcome and what might need to be done differently.

Thanks for the patches.

Regarding patches 3/5, 4/5 and 5/5, we should perhaps try to brainstorm this a 
bit. There's more to exposure setting than just those controls, maybe it's 
time to think about a proper exposure API. We could start by gathering 
requirements on the list, and maybe have an IRC meeting if needed.

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[RFC/PATCH 0/5] v4l: New camera controls

2011-12-04 Thread Sylwester Nawrocki
Hi All,

I put some effort in preparing a documentation for a couple of new controls
in the camera control class. It's a preeliminary work, it's mainly just
documentation. There is yet no patches for any driver using these controls.
I just wanted to get some possible feedback on them, if this sort of stuff
is welcome and what might need to be done differently.


Thanks,
Sylwester


Heungjun Kim (1):
  uvc: Adapt the driver to new type of V4L2_CID_FOCUS_AUTO control

Sylwester Nawrocki (4):
  v4l: Convert V4L2_CID_FOCUS_AUTO control to a menu control
  v4l: Add V4L2_CID_METERING_MODE camera control
  v4l: Add V4L2_CID_EXPOSURE_BIAS camera control
  v4l: Add V4L2_CID_ISO and V4L2_CID_ISO_AUTO controls

 Documentation/DocBook/media/v4l/biblio.xml   |   11 +++
 Documentation/DocBook/media/v4l/controls.xml |  122 -
 drivers/media/video/uvc/uvc_ctrl.c   |9 ++-
 drivers/media/video/v4l2-ctrls.c |   19 -
 include/linux/videodev2.h|   19 
 5 files changed, 173 insertions(+), 7 deletions(-)

--
1.7.4.1

--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html