Re: Build fails Ubuntu 17.04 / "error: implicit declaration of function"
On Tue, May 30, 2017 at 09:35:03PM +0200, Karl Wallin wrote: > Hi! > > Sorry for not replying earlier, work. > I came so far as to download the patches (via n00bishly pasting the > actual content of the .patch-files into .patch-files since my git > cherry-pick command didn't work) but then after trying to apply them I > got a prompt with specifying the path of the file and didn't research > that further. > > I downloaded the latest release from GIT and now it actually builds!!! :D :D > > However it does not install :( > > "root@nuc-d54250wyk:/home/ubuntu/media_build# make install > make -C /home/ubuntu/media_build/v4l install > make[1]: Entering directory '/home/ubuntu/media_build/v4l' > make[1]: *** No rule to make target 'media-install', needed by 'install'. > Stop. > make[1]: Leaving directory '/home/ubuntu/media_build/v4l' > Makefile:15: recipe for target 'install' failed > make: *** [install] Error 2" > > I've gone into "v4l" and looked for a "media-install" file but haven't > found any. > > Perhaps this is something I've misunderstood and easy to fix so I > finally can install it? This was also noticed by Olli Salonen (see thread "media_build: fails to install"). I note there what the problem is but I don't know how to fix it. Vince
Re: Build fails Ubuntu 17.04 / "error: implicit declaration of function"
Oh and it is the same running as my normal user as well as "root". Med vänlig hälsning / Best Regards - Karl Wallin karl.wallin...@gmail.com P.S. Om mitt mail bör vidarebefodras, vänligen gör detta istället för att återkomma med en email-adress i ett svar till mig. / If my mail should be forwarded then please forward it instead of replying to me with an email address. P.S. 2017-05-30 21:35 GMT+02:00 Karl Wallin : > Hi! > > Sorry for not replying earlier, work. > I came so far as to download the patches (via n00bishly pasting the > actual content of the .patch-files into .patch-files since my git > cherry-pick command didn't work) but then after trying to apply them I > got a prompt with specifying the path of the file and didn't research > that further. > > I downloaded the latest release from GIT and now it actually builds!!! :D :D > > However it does not install :( > > "root@nuc-d54250wyk:/home/ubuntu/media_build# make install > make -C /home/ubuntu/media_build/v4l install > make[1]: Entering directory '/home/ubuntu/media_build/v4l' > make[1]: *** No rule to make target 'media-install', needed by 'install'. > Stop. > make[1]: Leaving directory '/home/ubuntu/media_build/v4l' > Makefile:15: recipe for target 'install' failed > make: *** [install] Error 2" > > I've gone into "v4l" and looked for a "media-install" file but haven't > found any. > > Perhaps this is something I've misunderstood and easy to fix so I > finally can install it? > > Best Regards - Karl > Med vänlig hälsning / Best Regards - Karl Wallin > > karl.wallin...@gmail.com > > P.S. Om mitt mail bör vidarebefodras, vänligen gör detta istället för > att återkomma med en email-adress i ett svar till mig. / If my mail > should be forwarded then please forward it instead of replying to me > with an email address. P.S. > > > 2017-05-28 23:42 GMT+02:00 Daniel Scheller : >> Am Sun, 28 May 2017 21:06:33 +0200 >> schrieb Karl Wallin : >> >> All, >> >>> In "/home/ubuntu/media_build/v4l/cec-core.c" changed row 142 from: >>> "ret = cdev_device_add(&devnode->cdev, &devnode->dev);" to: >>> "ret = device_add(&devnode->dev);" >>> and row 186 from: >>> "cdev_device_del(&devnode->cdev, &devnode->dev);" to: >>> "device_del(&devnode->dev);" >> >> Until the upstream media_build repository gets the neccessary backport >> patch treatment, you can apply [1] and [2] to media_build which should >> fix all build issues. >> >> Best regards, >> Daniel >> >> [1] >> https://github.com/herrnst/media_build/commit/4766a716c629707d58d625c6cdfd8c395fd6ed61 >> [2] >> https://github.com/herrnst/media_build/commit/01507a9c32a301c8fc021dcaf1b943799ff3da51
Re: Build fails Ubuntu 17.04 / "error: implicit declaration of function"
Hi! Sorry for not replying earlier, work. I came so far as to download the patches (via n00bishly pasting the actual content of the .patch-files into .patch-files since my git cherry-pick command didn't work) but then after trying to apply them I got a prompt with specifying the path of the file and didn't research that further. I downloaded the latest release from GIT and now it actually builds!!! :D :D However it does not install :( "root@nuc-d54250wyk:/home/ubuntu/media_build# make install make -C /home/ubuntu/media_build/v4l install make[1]: Entering directory '/home/ubuntu/media_build/v4l' make[1]: *** No rule to make target 'media-install', needed by 'install'. Stop. make[1]: Leaving directory '/home/ubuntu/media_build/v4l' Makefile:15: recipe for target 'install' failed make: *** [install] Error 2" I've gone into "v4l" and looked for a "media-install" file but haven't found any. Perhaps this is something I've misunderstood and easy to fix so I finally can install it? Best Regards - Karl Med vänlig hälsning / Best Regards - Karl Wallin karl.wallin...@gmail.com P.S. Om mitt mail bör vidarebefodras, vänligen gör detta istället för att återkomma med en email-adress i ett svar till mig. / If my mail should be forwarded then please forward it instead of replying to me with an email address. P.S. 2017-05-28 23:42 GMT+02:00 Daniel Scheller : > Am Sun, 28 May 2017 21:06:33 +0200 > schrieb Karl Wallin : > > All, > >> In "/home/ubuntu/media_build/v4l/cec-core.c" changed row 142 from: >> "ret = cdev_device_add(&devnode->cdev, &devnode->dev);" to: >> "ret = device_add(&devnode->dev);" >> and row 186 from: >> "cdev_device_del(&devnode->cdev, &devnode->dev);" to: >> "device_del(&devnode->dev);" > > Until the upstream media_build repository gets the neccessary backport > patch treatment, you can apply [1] and [2] to media_build which should > fix all build issues. > > Best regards, > Daniel > > [1] > https://github.com/herrnst/media_build/commit/4766a716c629707d58d625c6cdfd8c395fd6ed61 > [2] > https://github.com/herrnst/media_build/commit/01507a9c32a301c8fc021dcaf1b943799ff3da51
Re: Build fails Ubuntu 17.04 / "error: implicit declaration of function"
Am Sun, 28 May 2017 21:06:33 +0200 schrieb Karl Wallin : All, > In "/home/ubuntu/media_build/v4l/cec-core.c" changed row 142 from: > "ret = cdev_device_add(&devnode->cdev, &devnode->dev);" to: > "ret = device_add(&devnode->dev);" > and row 186 from: > "cdev_device_del(&devnode->cdev, &devnode->dev);" to: > "device_del(&devnode->dev);" Until the upstream media_build repository gets the neccessary backport patch treatment, you can apply [1] and [2] to media_build which should fix all build issues. Best regards, Daniel [1] https://github.com/herrnst/media_build/commit/4766a716c629707d58d625c6cdfd8c395fd6ed61 [2] https://github.com/herrnst/media_build/commit/01507a9c32a301c8fc021dcaf1b943799ff3da51
Re: Build fails Ubuntu 17.04 / "error: implicit declaration of function"
On 28.05.2017 21:33, Karl Wallin wrote: Thanks for such a quick reply :) Of course *facepalm* should have thought of that "./build" downloads everything again and of course replaces my modified "cec-core.c". I ran "make" and ran into new problems: Ok so using logic I should do the same changes in "/home/ubuntu/media_build/v4l/media-devnode.c": In ""/home/ubuntu/media_build/v4l/media-devnode.c" changed row 257 from: "ret = cdev_device_add(&devnode->cdev, &devnode->dev);" to: "ret = device_add(&devnode->dev);" and row 293 from: "cdev_device_del(&devnode->cdev, &devnode->dev);" to: "device_del(&devnode->dev);" and then run "make" However it fails again :( CC [M] /home/ubuntu/media_build/v4l/serial_ir.o /home/ubuntu/media_build/v4l/serial_ir.c:837:21: error: expected ')' before 'int' module_param_hw(io, int, ioport, 0444); ^~~ /home/ubuntu/media_build/v4l/serial_ir.c:841:25: error: expected ')' before 'ulong' module_param_hw(iommap, ulong, other, 0444); ^ /home/ubuntu/media_build/v4l/serial_ir.c:849:26: error: expected ')' before 'int' module_param_hw(ioshift, int, other, 0444); ^~~ /home/ubuntu/media_build/v4l/serial_ir.c:852:22: error: expected ')' before 'int' module_param_hw(irq, int, irq, 0444); ^~~ /home/ubuntu/media_build/v4l/serial_ir.c:855:28: error: expected ')' before 'bool' module_param_hw(share_irq, bool, other, 0444); ^~~~ scripts/Makefile.build:301: recipe for target '/home/ubuntu/media_build/v4l/serial_ir.o' failed make[3]: *** [/home/ubuntu/media_build/v4l/serial_ir.o] Error 1 Makefile:1524: recipe for target '_module_/home/ubuntu/media_build/v4l' failed make[2]: *** [_module_/home/ubuntu/media_build/v4l] Error 2 make[2]: Leaving directory '/usr/src/linux-headers-4.10.0-21-generic' Makefile:51: recipe for target 'default' failed make[1]: *** [default] Error 2 make[1]: Leaving directory '/home/ubuntu/media_build/v4l' Makefile:26: recipe for target 'all' failed make: *** [all] Error 2 So I'm guessing that "/home/ubuntu/media_build/v4l/serial_ir.c" needs to be modified since it expects a ")" before the integer (numerical) value? /Karl Hi Karl I compiled only the ddbridge driver. So I did not have to compile these files you have problems with. Therefor I don't know what is going on here, sorry. Thomas
Re: Build fails Ubuntu 17.04 / "error: implicit declaration of function"
On 28.05.2017 21:06, Karl Wallin wrote: Hi Thomas, Thanks for the help (and to Vincent as well) :) In "/home/ubuntu/media_build/v4l/cec-core.c" changed row 142 from: "ret = cdev_device_add(&devnode->cdev, &devnode->dev);" to: "ret = device_add(&devnode->dev);" and row 186 from: "cdev_device_del(&devnode->cdev, &devnode->dev);" to: "device_del(&devnode->dev);" Even if I do that when I try to build it again (using ./build) it seems to reload / revert the cec-core.c to the original file since I still get these errors even though I saved the changes in Notepadqq: "/home/ubuntu/media_build/v4l/cec-core.c:142:8: error: implicit declaration of function 'cdev_device_add' [-Werror=implicit-function-declaration] ret = cdev_device_add(&devnode->cdev, &devnode->dev);" and "/home/ubuntu/media_build/v4l/cec-core.c:186:2: error: implicit declaration of function 'cdev_device_del' [-Werror=implicit-function-declaration] cdev_device_del(&devnode->cdev, &devnode->dev);" I am probably missing something here since it worked for you, would be grateful for your help :) /Karl Med vänlig hälsning / Best Regards - Karl Wallin Hi Karl The build downloads the latest source and overwrites your change (I think?) I used "make" to compile. After your have run the build script. Do the changes as you have described above. Run "make" to compile and "sudo make install" to install. This should do the trick. Thomas
Re: Build fails Ubuntu 17.04 / "error: implicit declaration of function"
Thanks for such a quick reply :) Of course *facepalm* should have thought of that "./build" downloads everything again and of course replaces my modified "cec-core.c". I ran "make" and ran into new problems: "Make" log: ubuntu@nuc-d54250wyk:~/media_build$ make make -C /home/ubuntu/media_build/v4l make[1]: Entering directory '/home/ubuntu/media_build/v4l' creating symbolic links... make -C firmware prep make[2]: Entering directory '/home/ubuntu/media_build/v4l/firmware' make[2]: Leaving directory '/home/ubuntu/media_build/v4l/firmware' make -C firmware make[2]: Entering directory '/home/ubuntu/media_build/v4l/firmware' make[2]: Nothing to be done for 'default'. make[2]: Leaving directory '/home/ubuntu/media_build/v4l/firmware' Kernel build directory is /lib/modules/4.10.0-21-generic/build make -C ../linux apply_patches make[2]: Entering directory '/home/ubuntu/media_build/linux' Patches for 4.10.0-21-generic already applied. make[2]: Leaving directory '/home/ubuntu/media_build/linux' make -C /lib/modules/4.10.0-21-generic/build SUBDIRS=/home/ubuntu/media_build/v4l modules make[2]: Entering directory '/usr/src/linux-headers-4.10.0-21-generic' CC [M] /home/ubuntu/media_build/v4l/cec-core.o CC [M] /home/ubuntu/media_build/v4l/cec-adap.o CC [M] /home/ubuntu/media_build/v4l/cec-api.o CC [M] /home/ubuntu/media_build/v4l/cec-edid.o CC [M] /home/ubuntu/media_build/v4l/cec-notifier.o LD [M] /home/ubuntu/media_build/v4l/cec.o CC [M] /home/ubuntu/media_build/v4l/msp3400-driver.o CC [M] /home/ubuntu/media_build/v4l/msp3400-kthreads.o LD [M] /home/ubuntu/media_build/v4l/msp3400.o CC [M] /home/ubuntu/media_build/v4l/smiapp-core.o CC [M] /home/ubuntu/media_build/v4l/smiapp-regs.o CC [M] /home/ubuntu/media_build/v4l/smiapp-quirk.o CC [M] /home/ubuntu/media_build/v4l/smiapp-limits.o LD [M] /home/ubuntu/media_build/v4l/smiapp.o CC [M] /home/ubuntu/media_build/v4l/et8ek8_mode.o CC [M] /home/ubuntu/media_build/v4l/et8ek8_driver.o /home/ubuntu/media_build/v4l/et8ek8_driver.c: In function 'et8ek8_i2c_buffered_write_regs': /home/ubuntu/media_build/v4l/et8ek8_driver.c:256:1: warning: the frame size of 1104 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ LD [M] /home/ubuntu/media_build/v4l/et8ek8.o CC [M] /home/ubuntu/media_build/v4l/cx25840-core.o CC [M] /home/ubuntu/media_build/v4l/cx25840-audio.o CC [M] /home/ubuntu/media_build/v4l/cx25840-firmware.o CC [M] /home/ubuntu/media_build/v4l/cx25840-vbi.o CC [M] /home/ubuntu/media_build/v4l/cx25840-ir.o LD [M] /home/ubuntu/media_build/v4l/cx25840.o CC [M] /home/ubuntu/media_build/v4l/m5mols_core.o CC [M] /home/ubuntu/media_build/v4l/m5mols_controls.o CC [M] /home/ubuntu/media_build/v4l/m5mols_capture.o LD [M] /home/ubuntu/media_build/v4l/m5mols.o CC [M] /home/ubuntu/media_build/v4l/imx074.o CC [M] /home/ubuntu/media_build/v4l/mt9m001.o CC [M] /home/ubuntu/media_build/v4l/mt9t031.o CC [M] /home/ubuntu/media_build/v4l/mt9t112.o CC [M] /home/ubuntu/media_build/v4l/mt9v022.o CC [M] /home/ubuntu/media_build/v4l/ov5642.o CC [M] /home/ubuntu/media_build/v4l/ov6650.o CC [M] /home/ubuntu/media_build/v4l/ov772x.o CC [M] /home/ubuntu/media_build/v4l/ov9640.o CC [M] /home/ubuntu/media_build/v4l/ov9740.o CC [M] /home/ubuntu/media_build/v4l/rj54n1cb0c.o CC [M] /home/ubuntu/media_build/v4l/tw9910.o CC [M] /home/ubuntu/media_build/v4l/aptina-pll.o CC [M] /home/ubuntu/media_build/v4l/tvaudio.o CC [M] /home/ubuntu/media_build/v4l/tda7432.o CC [M] /home/ubuntu/media_build/v4l/saa6588.o CC [M] /home/ubuntu/media_build/v4l/tda9840.o CC [M] /home/ubuntu/media_build/v4l/tea6415c.o CC [M] /home/ubuntu/media_build/v4l/tea6420.o CC [M] /home/ubuntu/media_build/v4l/saa7110.o CC [M] /home/ubuntu/media_build/v4l/saa7115.o CC [M] /home/ubuntu/media_build/v4l/saa717x.o CC [M] /home/ubuntu/media_build/v4l/saa7127.o CC [M] /home/ubuntu/media_build/v4l/saa7185.o CC [M] /home/ubuntu/media_build/v4l/saa6752hs.o CC [M] /home/ubuntu/media_build/v4l/ad5820.o CC [M] /home/ubuntu/media_build/v4l/adv7170.o CC [M] /home/ubuntu/media_build/v4l/adv7175.o CC [M] /home/ubuntu/media_build/v4l/adv7180.o CC [M] /home/ubuntu/media_build/v4l/adv7183.o CC [M] /home/ubuntu/media_build/v4l/adv7343.o CC [M] /home/ubuntu/media_build/v4l/adv7393.o CC [M] /home/ubuntu/media_build/v4l/adv7604.o CC [M] /home/ubuntu/media_build/v4l/adv7842.o CC [M] /home/ubuntu/media_build/v4l/ad9389b.o CC [M] /home/ubuntu/media_build/v4l/adv7511.o CC [M] /home/ubuntu/media_build/v4l/vpx3220.o CC [M] /home/ubuntu/media_build/v4l/vs6624.o CC [M] /home/ubuntu/media_build/v4l/bt819.o CC [M] /home/ubuntu/media_build/v4l/bt856.o CC [M] /home/ubuntu/media_build/v4l/bt866.o CC [M] /home/ubuntu/media_build/v4l/ks0127.o CC [M] /home/ubuntu/media_build/v4l/ths7303.o CC [M] /home/ubuntu/media_build/v4l/ths8200.o CC [M] /home/ubuntu/media_build/v
Re: Build fails Ubuntu 17.04 / "error: implicit declaration of function"
Hi Thomas, Thanks for the help (and to Vincent as well) :) In "/home/ubuntu/media_build/v4l/cec-core.c" changed row 142 from: "ret = cdev_device_add(&devnode->cdev, &devnode->dev);" to: "ret = device_add(&devnode->dev);" and row 186 from: "cdev_device_del(&devnode->cdev, &devnode->dev);" to: "device_del(&devnode->dev);" Even if I do that when I try to build it again (using ./build) it seems to reload / revert the cec-core.c to the original file since I still get these errors even though I saved the changes in Notepadqq: "/home/ubuntu/media_build/v4l/cec-core.c:142:8: error: implicit declaration of function 'cdev_device_add' [-Werror=implicit-function-declaration] ret = cdev_device_add(&devnode->cdev, &devnode->dev);" and "/home/ubuntu/media_build/v4l/cec-core.c:186:2: error: implicit declaration of function 'cdev_device_del' [-Werror=implicit-function-declaration] cdev_device_del(&devnode->cdev, &devnode->dev);" I am probably missing something here since it worked for you, would be grateful for your help :) /Karl Med vänlig hälsning / Best Regards - Karl Wallin karl.wallin...@gmail.com P.S. Om mitt mail bör vidarebefodras, vänligen gör detta istället för att återkomma med en email-adress i ett svar till mig. / If my mail should be forwarded then please forward it instead of replying to me with an email address. P.S. 2017-05-28 14:28 GMT+02:00 Thomas Kaiser : > On 27.05.2017 21:28, Karl Wallin wrote: >> >> Hi! >> >> Sorry if this is something I should have figured out, I am bit >> experienced with Linux but not at all a pro. >> >> Trying to build v4l-dvb on Ubuntu 17.04 (kernel 4.10.0-21-generic) and >> get build errors. >> >> Dependencies are met: >> >> make[2]: Entering directory '/usr/src/linux-headers-4.10.0-21-generic' >>CC [M] /home/ubuntu/media_build/v4l/cec-core.o >> /home/ubuntu/media_build/v4l/cec-core.c: In function >> 'cec_devnode_register': >> /home/ubuntu/media_build/v4l/cec-core.c:142:8: error: implicit >> declaration of function 'cdev_device_add' >> [-Werror=implicit-function-declaration] >>ret = cdev_device_add(&devnode->cdev, &devnode->dev); >> ^~~ >> /home/ubuntu/media_build/v4l/cec-core.c: In function >> 'cec_devnode_unregister': >> /home/ubuntu/media_build/v4l/cec-core.c:186:2: error: implicit >> declaration of function 'cdev_device_del' >> [-Werror=implicit-function-declaration] >>cdev_device_del(&devnode->cdev, &devnode->dev); >>^~~ > > > Hi Karl > > I changed in cec-core.c cdev_device_add(&devnode->cdev, &devnode->dev) and > cdev_device_del(&devnode->cdev, &devnode->dev) to device_add(&devnode->dev) > and device_del(&devnode->dev). > > I can compile now and the driver runs with kernel 4.10.0-21-generic on > Ubuntu 17.04. > > Thomas >
Re: Build fails Ubuntu 17.04 / "error: implicit declaration of function"
I saw this too, ([regression] Build failure on ubuntu 16.04 LTS) 857313e51006ff51524579bcd8808b70f9a80812 media: utilize new cdev_device_add helper function introduced these in March this year. More backport patches are needed.