Re: [ndctl PATCH 0/7] introduce 'daxctl list', and 'ndctl list' updates

[Verma, Vishal L]

On Mon, 2017-01-09 at 14:00 -0800, Dan Williams wrote:
> On Mon, Jan 9, 2017 at 1:56 PM, Vishal Verma  > wrote:
> > On 01/06, Dan Williams wrote:
> > > * The 'ndctl list' command awkwardly prints out all the
> > > corresponding
> > >   device-dax information when a namespace is in 'dax' mode.
> > > Conversely if
> > >   someone is only interested in listing device-dax information
> > > they need to
> > >   contend with libnvdimm data.
> > > 
> > >   Introduce a separate daxctl utility with its own 'list' command
> > > for this
> > >   purpose, and make the listing of device-dax data through 'ndctl
> > > list'
> > >   optional (new --device-dax option).
> > 
> > the 'rpmbuild' script was failing as the new daxctl utility wasn't
> > included in %files in the spec. The following patch fixes that.
> > 
> > 8<-
> > 
> > From d26a582b4ae9e69a22e52908a5d4bbae0a79717f Mon Sep 17 00:00:00
> > 2001
> > From: Vishal Verma 
> > Date: Mon, 9 Jan 2017 14:52:34 -0700
> > Subject: [PATCH] spec: add the new daxctl binary to the spec file
> > 
> > The missing binary was triggering the "installed but unpackaged file
> > found" check for rpmbuild. Add daxctl to the %files section as we do
> > want it to be packaged.
> 
> Yes, we do want it packaged, but in it's own rpm. I have patch to add
> that as well as a daxctl man page.

Ah ok - I thought it would just get installed as a part of the ndctl
rpm.
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [ndctl PATCH 0/7] introduce 'daxctl list', and 'ndctl list' updates

[Vishal Verma]

On 01/06, Dan Williams wrote:
> * The 'ndctl list' command awkwardly prints out all the corresponding
>   device-dax information when a namespace is in 'dax' mode. Conversely if
>   someone is only interested in listing device-dax information they need to
>   contend with libnvdimm data.
> 
>   Introduce a separate daxctl utility with its own 'list' command for this
>   purpose, and make the listing of device-dax data through 'ndctl list'
>   optional (new --device-dax option).

the 'rpmbuild' script was failing as the new daxctl utility wasn't
included in %files in the spec. The following patch fixes that.

8<-

>From d26a582b4ae9e69a22e52908a5d4bbae0a79717f Mon Sep 17 00:00:00 2001
From: Vishal Verma 
Date: Mon, 9 Jan 2017 14:52:34 -0700
Subject: [PATCH] spec: add the new daxctl binary to the spec file

The missing binary was triggering the "installed but unpackaged file
found" check for rpmbuild. Add daxctl to the %files section as we do
want it to be packaged.

Signed-off-by: Vishal Verma 
---
 ndctl.spec.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ndctl.spec.in b/ndctl.spec.in
index 6453edd..4a22597 100644
--- a/ndctl.spec.in
+++ b/ndctl.spec.in
@@ -114,6 +114,7 @@ make check
 %defattr(-,root,root)
 %license util/COPYING licenses/BSD-MIT licenses/CC0
 %{_bindir}/ndctl
+%{_bindir}/daxctl
 %{_mandir}/man1/*
 %{bashcompdir}/
 
-- 
2.9.3


___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

Re: [ndctl PATCH 0/7] introduce 'daxctl list', and 'ndctl list' updates

[Dan Williams]

On Mon, Jan 9, 2017 at 1:56 PM, Vishal Verma  wrote:
> On 01/06, Dan Williams wrote:
>> * The 'ndctl list' command awkwardly prints out all the corresponding
>>   device-dax information when a namespace is in 'dax' mode. Conversely if
>>   someone is only interested in listing device-dax information they need to
>>   contend with libnvdimm data.
>>
>>   Introduce a separate daxctl utility with its own 'list' command for this
>>   purpose, and make the listing of device-dax data through 'ndctl list'
>>   optional (new --device-dax option).
>
> the 'rpmbuild' script was failing as the new daxctl utility wasn't
> included in %files in the spec. The following patch fixes that.
>
> 8<-
>
> From d26a582b4ae9e69a22e52908a5d4bbae0a79717f Mon Sep 17 00:00:00 2001
> From: Vishal Verma 
> Date: Mon, 9 Jan 2017 14:52:34 -0700
> Subject: [PATCH] spec: add the new daxctl binary to the spec file
>
> The missing binary was triggering the "installed but unpackaged file
> found" check for rpmbuild. Add daxctl to the %files section as we do
> want it to be packaged.

Yes, we do want it packaged, but in it's own rpm. I have patch to add
that as well as a daxctl man page.
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

[ndctl PATCH 0/7] introduce 'daxctl list', and 'ndctl list' updates

[Dan Williams]

* The 'ndctl list' command awkwardly prints out all the corresponding
  device-dax information when a namespace is in 'dax' mode. Conversely if
  someone is only interested in listing device-dax information they need to
  contend with libnvdimm data.

  Introduce a separate daxctl utility with its own 'list' command for this
  purpose, and make the listing of device-dax data through 'ndctl list'
  optional (new --device-dax option).

* Enhance 'ndctl list' with the option to filter by namespace mode (new
  --mode option).

* Allow 'ndctl {enable,disable}-region' to limit itself to regions
  matching a given type (blk or pmem).

* Fix 'ndctl list' to trim region mapping data (i.e. the dimms in a
  region), when a specific dimm is indicated with --dimm.

---

Dan Williams (7):
  ndctl, daxctl: refactor main boilerplate for a new 'daxctl' utility
  ndctl, daxctl: move json helpers to be available across both utilities
  ndctl, list: add option to filter namespace by mode
  ndctl, list: add '--device-dax' option
  daxctl: add list command
  ndctl, {enable,disable}-region: filter by type
  ndctl, list: limit mappings when --dimm is specified


 Makefile.am   |4 +
 builtin.h |   31 +++
 configure.ac  |1 
 daxctl/Makefile.am|   13 +++
 daxctl/daxctl.c   |   91 +
 daxctl/lib/Makefile.am|3 +
 daxctl/libdaxctl.h|1 
 daxctl/list.c |  112 ++
 ndctl.spec.in |   12 +++
 ndctl/Makefile.am |3 -
 ndctl/builtin-bat.c   |2 
 ndctl/builtin-create-nfit.c   |2 
 ndctl/builtin-dimm.c  |   14 ++-
 ndctl/builtin-list.c  |   45 ++
 ndctl/builtin-test.c  |2 
 ndctl/builtin-xable-region.c  |   35 +++-
 ndctl/builtin-xaction-namespace.c |   10 +-
 ndctl/builtin.h   |   33 
 ndctl/libndctl.h.in   |1 
 ndctl/ndctl.c |  160 +
 test/Makefile.am  |4 -
 test/device-dax.c |4 -
 test/multi-pmem.c |2 
 util/filter.c |   21 +
 util/filter.h |6 +
 util/help.c   |   44 ++
 util/json.c   |  121 ++--
 util/json.h   |8 ++
 util/main.c   |  123 
 util/main.h   |   10 ++
 30 files changed, 671 insertions(+), 247 deletions(-)
 create mode 100644 builtin.h
 create mode 100644 daxctl/Makefile.am
 create mode 100644 daxctl/daxctl.c
 create mode 100644 daxctl/list.c
 delete mode 100644 ndctl/builtin.h
 rename ndctl/builtin-help.c => util/help.c
 rename ndctl/util/json.c => util/json.c
 rename ndctl/util/json.h => util/json.h
 create mode 100644 util/main.c
 create mode 100644 util/main.h
___
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm