Re: [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card
- Original Message -
From: David Brownell [EMAIL PROTECTED]
To: Kumar, Purushotam [EMAIL PROTECTED]
Cc: Tony Lindgren [EMAIL PROTECTED]; Purushotam Kumar [EMAIL
PROTECTED]; linux-omap@vger.kernel.org; Gole, Anant [EMAIL PROTECTED]
Sent: Tuesday, August 05, 2008 12:40 PM
Subject: Re: [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card
On Monday 14 July 2008, Kumar, Purushotam wrote:
if (cpu_is_omap2430() || cpu_is_omap34xx()) {
- if (mmc-enabled)
+ if (mmc-enabled) {
+ mmc1_data.conf = *mmc;
(void) platform_device_register(mmc_omap_device1);
+ }
I don't get it. OMAP3 uses the hsmmc code, which uses
a struct omap_mmc_platform_data to configure itself.
But this patch updates a struct omap_mmc_conf as used
by the non-hsmmc code.
So ... it's a NOP, at least for OMAP3. Right?
Hi Dave,
I think there is no difference between hsmmc code vs non-hsmmc code with
respect to platform specific structure initializations.
Both of them use omap_mmc_platform_data as well as omap_mmc_config
structures. I had a quick look at board-h4-mmc.c
and board-h4.c to verify this.
What this patch does is to add the missing initializtion line mmc1_data.conf =
*mmc; for 2430 or 3430 which was present for platforms other
than these. Without this line the below condition in the hsmmc driver will not
evaluate to true.
if (pdata-conf.wire4)
mmc-caps |= MMC_CAP_4_BIT_DATA;
The header include/asm-arm/arch-omap/mmc.h is used by both hsmmc and
non-hsmmc code.
Regards,
Madhu
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card
On Monday 14 July 2008, Kumar, Purushotam wrote:
if (cpu_is_omap2430() || cpu_is_omap34xx()) {
- if (mmc-enabled)
+ if (mmc-enabled) {
+ mmc1_data.conf = *mmc;
(void)
platform_device_register(mmc_omap_device1);
+ }
I don't get it. OMAP3 uses the hsmmc code, which uses
a struct omap_mmc_platform_data to configure itself.
But this patch updates a struct omap_mmc_conf as used
by the non-hsmmc code.
So ... it's a NOP, at least for OMAP3. Right?
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card
Tony,
I updated patch for MMC1 and MMC2 and also refreshed the patch.
I am attaching patch with this mail.
Regards,
Purushotam
-Original Message-
From: Kumar, Purushotam
Sent: Wednesday, June 25, 2008 3:34 PM
To: Tony Lindgren; Purushotam Kumar
Cc: linux-omap@vger.kernel.org; Gole, Anant
Subject: RE: [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card
-Original Message-
From: Tony Lindgren [mailto:[EMAIL PROTECTED]
Sent: Monday, June 23, 2008 6:17 PM
To: Purushotam Kumar
Cc: linux-omap@vger.kernel.org; Gole, Anant
Subject: Re: [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card
* Purushotam Kumar [EMAIL PROTECTED] [080616 16:03]:
OMAP3:devices.c:Enabling 4-bit for SD card
SD card was working in 1-bit mode.This patch will configure SD card in
4-bit mode and hence performance will increase.
Signed-off-by: Purushotam Kumar [EMAIL PROTECTED]
Acked-by: Madhusudhan Chikkature Rajashekar [EMAIL PROTECTED]
---
arch/arm/plat-omap/devices.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux-omap-2.6/arch/arm/plat-omap/devices.c
===
--- linux-omap-2.6.orig/arch/arm/plat-omap/devices.c
+++ linux-omap-2.6/arch/arm/plat-omap/devices.c
@@ -292,8 +292,10 @@ static void __init omap_init_mmc(void)
mmc = mmc_conf-mmc[0];
if (cpu_is_omap2430() || cpu_is_omap34xx()) {
- if (mmc-enabled)
+ if (mmc-enabled) {
+ mmc1_data.conf = *mmc;
(void) platform_device_register(mmc_omap_device1);
+ }
#if defined(CONFIG_ARCH_OMAP2430) || defined(CONFIG_ARCH_OMAP34XX)
mmc = mmc_conf-mmc[1];
I guess this should be also done for mmc2_data.conf?
Tony
I agree with you that it is required to be done for MMC2 as well.
Please push this patch for MMC1 and I will submit other patch latter for MMC2.
Regards,
Purushotam
enable_sd_4bit.patch
Description: enable_sd_4bit.patch
RE: [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card
-Original Message-
From: Tony Lindgren [mailto:[EMAIL PROTECTED]
Sent: Monday, June 23, 2008 6:17 PM
To: Purushotam Kumar
Cc: linux-omap@vger.kernel.org; Gole, Anant
Subject: Re: [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card
* Purushotam Kumar [EMAIL PROTECTED] [080616 16:03]:
OMAP3:devices.c:Enabling 4-bit for SD card
SD card was working in 1-bit mode.This patch will configure SD card in
4-bit mode and hence performance will increase.
Signed-off-by: Purushotam Kumar [EMAIL PROTECTED]
Acked-by: Madhusudhan Chikkature Rajashekar [EMAIL PROTECTED]
---
arch/arm/plat-omap/devices.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux-omap-2.6/arch/arm/plat-omap/devices.c
===
--- linux-omap-2.6.orig/arch/arm/plat-omap/devices.c
+++ linux-omap-2.6/arch/arm/plat-omap/devices.c
@@ -292,8 +292,10 @@ static void __init omap_init_mmc(void)
mmc = mmc_conf-mmc[0];
if (cpu_is_omap2430() || cpu_is_omap34xx()) {
- if (mmc-enabled)
+ if (mmc-enabled) {
+ mmc1_data.conf = *mmc;
(void) platform_device_register(mmc_omap_device1);
+ }
#if defined(CONFIG_ARCH_OMAP2430) || defined(CONFIG_ARCH_OMAP34XX)
mmc = mmc_conf-mmc[1];
I guess this should be also done for mmc2_data.conf?
Tony
I agree with you that it is required to be done for MMC2 as well.
Please push this patch for MMC1 and I will submit other patch latter for MMC2.
Regards,
Purushotam
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] OMAP3:devices.c: Enabling 4-bit for SD card
* Purushotam Kumar [EMAIL PROTECTED] [080616 16:03]:
OMAP3:devices.c:Enabling 4-bit for SD card
SD card was working in 1-bit mode.This patch will configure SD card in
4-bit mode and hence performance will increase.
Signed-off-by: Purushotam Kumar [EMAIL PROTECTED]
Acked-by: Madhusudhan Chikkature Rajashekar [EMAIL PROTECTED]
---
arch/arm/plat-omap/devices.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux-omap-2.6/arch/arm/plat-omap/devices.c
===
--- linux-omap-2.6.orig/arch/arm/plat-omap/devices.c
+++ linux-omap-2.6/arch/arm/plat-omap/devices.c
@@ -292,8 +292,10 @@ static void __init omap_init_mmc(void)
mmc = mmc_conf-mmc[0];
if (cpu_is_omap2430() || cpu_is_omap34xx()) {
- if (mmc-enabled)
+ if (mmc-enabled) {
+ mmc1_data.conf = *mmc;
(void) platform_device_register(mmc_omap_device1);
+ }
#if defined(CONFIG_ARCH_OMAP2430) || defined(CONFIG_ARCH_OMAP34XX)
mmc = mmc_conf-mmc[1];
I guess this should be also done for mmc2_data.conf?
Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] OMAP3:devices.c: Enabling 4-bit for SD card
OMAP3:devices.c:Enabling 4-bit for SD card
SD card was working in 1-bit mode.This patch will configure SD card in
4-bit mode and hence performance will increase.
Signed-off-by: Purushotam Kumar [EMAIL PROTECTED]
Acked-by: Madhusudhan Chikkature Rajashekar [EMAIL PROTECTED]
---
arch/arm/plat-omap/devices.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux-omap-2.6/arch/arm/plat-omap/devices.c
===
--- linux-omap-2.6.orig/arch/arm/plat-omap/devices.c
+++ linux-omap-2.6/arch/arm/plat-omap/devices.c
@@ -292,8 +292,10 @@ static void __init omap_init_mmc(void)
mmc = mmc_conf-mmc[0];
if (cpu_is_omap2430() || cpu_is_omap34xx()) {
- if (mmc-enabled)
+ if (mmc-enabled) {
+ mmc1_data.conf = *mmc;
(void) platform_device_register(mmc_omap_device1);
+ }
#if defined(CONFIG_ARCH_OMAP2430) || defined(CONFIG_ARCH_OMAP34XX)
mmc = mmc_conf-mmc[1];
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
