Re: [RESENDING][PATCH 1/2]OMAP3 NAND: Add NAND support on OMAP3430
On Monday 06 October 2008, Tony Lindgren wrote: --- linux-omap-2.6_27_08_2008.orig/include/linux/mtd/nand.h +++ linux-omap-2.6_27_08_2008/include/linux/mtd/nand.h @@ -45,7 +45,7 @@ */ #define NAND_MAX_OOBSIZE 64 #define NAND_MAX_PAGESIZE2048 - +#define NAND_BLOCK_SIZE SZ_128K /* This is specific to 3430 SDP though ... there are plenty of other NAND block sizes in the world. Suggest moving this definition to board-3430sdp-flash.c where it's relevant. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [RESENDING][PATCH 1/2]OMAP3 NAND: Add NAND support on OMAP3430
On Modday 06 October 2008, Devid Brownell wrote: On Monday 06 October 2008, Tony Lindgren wrote: --- linux-omap-2.6_27_08_2008.orig/include/linux/mtd/nand.h +++ linux-omap-2.6_27_08_2008/include/linux/mtd/nand.h @@ -45,7 +45,7 @@ */ #define NAND_MAX_OOBSIZE 64 #define NAND_MAX_PAGESIZE2048 - +#define NAND_BLOCK_SIZE SZ_128K /* This is specific to 3430 SDP though ... there are plenty of other NAND block sizes in the world. Suggest moving this definition to board-3430sdp-flash.c where it's relevant. Agree. I will send a patch to move it. ... vimal-- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESENDING][PATCH 1/2]OMAP3 NAND: Add NAND support on OMAP3430
On Thursday 11 September 2008, Singh, Vimal wrote: I will define NAND_BLOCK_SIZE as: #define NAND_BLOCK_SIZE 64 * NAND_MAX_PAGESIZE Never define such things without parentheses ... Also, that looks wrong as well as sub-optimal. Current NAND chips can have page sizes up to 4 KB (right?), so I think MAX isn't what you would want (even if it never grows again). I'd just use SZ_128K for NAND_BLOCK_SIZE, and avoid the confusion. -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RESENDING][PATCH 1/2]OMAP3 NAND: Add NAND support on OMAP3430
* vimal singh [EMAIL PROTECTED] [080826 03:42]:
From: Teerth Reddy [EMAIL PROTECTED]
This patch adds NAND support on 3430sdp board
Signed-off-by: Teerth Reddy [EMAIL PROTECTED]
---
arch/arm/mach-omap2/board-3430sdp-flash.c | 88
--
arch/arm/plat-omap/include/mach/gpmc.h| 10 +++
2 files changed, 93 insertions(+), 5 deletions(-)
Index: linux-omap-2.6/arch/arm/mach-omap2/board-3430sdp-flash.c
===
--- linux-omap-2.6.orig/arch/arm/mach-omap2/board-3430sdp-flash.c
+++ linux-omap-2.6/arch/arm/mach-omap2/board-3430sdp-flash.c
@@ -24,6 +24,7 @@
#include mach/onenand.h
#include mach/board.h
#include mach/gpmc.h
+#include mach/nand.h
static struct mtd_partition sdp_nor_partitions[] = {
/* bootloader (U-Boot, etc) in first sector */
@@ -137,6 +138,61 @@ static int sdp_onenand_setup(void __iome
/* Onenand setup does nothing at present */
return 0;
}
+
+static struct mtd_partition sdp_nand_partitions[] = {
+ /* All the partition sizes are listed in terms of NAND block size */
+ {
+ .name = X-Loader-NAND,
+ .offset = 0,
+ .size = 4 * (64 * 2048),
+ .mask_flags = MTD_WRITEABLE,/* force read-only */
+ },
+ {
+ .name = U-Boot-NAND,
+ .offset = MTDPART_OFS_APPEND, /* Offset = 0x8 */
+ .size = 4 * (64 * 2048),
+ .mask_flags = MTD_WRITEABLE,/* force read-only */
+ },
+ {
+ .name = Boot Env-NAND,
+ .offset = MTDPART_OFS_APPEND, /* Offset = 0x10 */
+ .size = 2 * (64 * 2048),
+ },
+ {
+ .name = Kernel-NAND,
+ .offset = MTDPART_OFS_APPEND, /* Offset = 0x14 */
+ .size = 32 * (64 * 2048),
+ },
+ {
+ .name = File System - NAND,
+ .size = MTDPART_SIZ_FULL,
+ .offset = MTDPART_OFS_APPEND, /* Offset = 0x54 */
+ },
+};
+
Can you please update this to use the SZ_.. defines for .size as done
now for sdp_nor_partitions?
Thanks,
Tony
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
