[PATCH] siw_cm: use to_sockaddr_in() also within dprint() statements

[Stefan Metzmacher]

Signed-off-by: Stefan Metzmacher me...@samba.org
---
 softiwarp/siw_cm.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/softiwarp/siw_cm.c b/softiwarp/siw_cm.c
index ad3d617..e4d97bb 100644
--- a/softiwarp/siw_cm.c
+++ b/softiwarp/siw_cm.c
@@ -1303,10 +1303,10 @@ int siw_connect(struct iw_cm_id *id, struct 
iw_cm_conn_param *params)
id, QP_ID(qp), sdev-ofa_dev.name, sdev-netdev-name);
dprint(DBG_CM, (id=0x%p, QP%d): laddr=(0x%x,%d), raddr=(0x%x,%d)\n,
id, QP_ID(qp),
-   ntohl(id-local_addr.sin_addr.s_addr),
-   ntohs(id-local_addr.sin_port),
-   ntohl(id-remote_addr.sin_addr.s_addr),
-   ntohs(id-remote_addr.sin_port));
+   ntohl(to_sockaddr_in(id-local_addr).sin_addr.s_addr),
+   ntohs(to_sockaddr_in(id-local_addr).sin_port),
+   ntohl(to_sockaddr_in(id-remote_addr).sin_addr.s_addr),
+   ntohs(to_sockaddr_in(id-remote_addr).sin_port));
 
laddr = (struct sockaddr *)id-local_addr;
raddr = (struct sockaddr *)id-remote_addr;
@@ -1832,9 +1832,9 @@ int siw_create_listen(struct iw_cm_id *id, int backlog)
raddr(id)  : ipv4=%d.%d.%d.%d, port=%d\n,
id,
l_ip[0], l_ip[1], l_ip[2], l_ip[3],
-   ntohs(id-local_addr.sin_port),
+   ntohs(to_sockaddr_in(id-local_addr).sin_port),
r_ip[0], r_ip[1], r_ip[2], r_ip[3],
-   ntohs(id-remote_addr.sin_port));
+   ntohs(to_sockaddr_in(id-remote_addr).sin_port));
 
in_dev = in_dev_get(sdev-netdev);
if (!in_dev) {
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: SoftiWARP: new patchset

[Stefan Metzmacher]

Hi Bernard,

 many thanks for commenting on the software iWARP RDMA
 driver code is sent about 5 weeks ago. I hope I now
 incorporated all recent suggestions and fixes.
 
 These are the main changes:
 
 o changing siw device attachment to be dynamic based on
   netlink events
 o enabling inline data for kernel clients
   (now inline data are stored within wqe structure)
 o bitmask access to packet headers removing the
   '#if defined(__LITTLE_ENDIAN_BITFIELD)' style
 o moving debug stuff to debugfs
 o shrinking the stack size of the core tx
   function
 o updates to documentation
 
 
 Due to the number of lines of code changed, it might be
 appropriate if I send a complete new patchset. I'll
 keep patch packaging as before.
 
 I made the current siw code available at
 www.gitorious.org/softiwarp
 and will keep it up-to-date. This code is now free
 of kernel version dependencies. It has been tested
 on different kernel versions from version 2.6.36.2
 up to 3.0.0-rc1+. I tested on both big an little
 endian machines.
 
 I would be very happy to get further input. I work on
 this project only part of my time - all your input speeds
 up code maturing. I would be happy if the code reaches an
 acceptable status soon. Thank you.

I'm wondering what the status of this patchset is?

Do you get any feedback?

It would be very good if the softiwarp module could be
included in the mainline kernel.

Hopefully Samba will get support for SMB-Direct (SMB2 over RDMA) support
in future. And having RDMA support without hardware support would be very
good for testing and also for usage on the client side against a server
which has hardware RDMA support.

For me at least rping tests work fine using siw.ko on a 3.2.x kernel on
Ubuntu 12.04.

metze


--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html