[PATCH/RFT v3 0/3] thermal: add support for r8a77995
This series adds thermal support for r8a77995. R-Car D3 (r8a77995) have a thermal sensor module which is similar to Gen2. Therefore this series adds r8a77995 support to rcar_thermal driver not rcar_gen3_thermal driver. This series is based on the next branch of Zhang Rui's linux tree. v3 [Yoshihiro Kaneko] * As suggested by Geert Uytterhoeven rcar_thermal.c: - make use_of_thermal in structure rcar_thermal_chip a single bit - add feature bits to rcar_thermal_chip - add the number of interrupts to rcar_thermal_chip - remove rcar_thermal_type in rcar_thermal_cip - make variable chip in rcar_thermal_probe() a const rcar-thermal.txt: * No change r8a77995.dtsi: * No change v2 [Yoshihiro Kaneko] * As suggested by Geert Uytterhoeven rcar_thermal.c: - remove rcar_of_data macro - store a pointer to rcar_thermal_chip in rcar_thermal_priv - remove unnecessary cast in rcar_thermal_dt_ids rcar-thermal.txt: - drop the fallback for D3 - update the paragraph about interrupts r8a77995.dtsi: - fix the base address and the register addresses - drop the fallback Yoshihiro Kaneko (3): thermal: rcar_thermal: add r8a77995 support dt-bindings: thermal: rcar-thermal: add R8A77995 support arm64: dts: renesas: r8a77995: add thermal device support .../devicetree/bindings/thermal/rcar-thermal.txt | 7 +- arch/arm64/boot/dts/renesas/r8a77995.dtsi | 30 drivers/thermal/rcar_thermal.c | 154 - 3 files changed, 157 insertions(+), 34 deletions(-) -- 1.9.1
Re: [PATCH/RFT v3 0/3] thermal: add support for r8a77995
Hello Kaneko-san On Tue, Apr 03, 2018 at 09:43:02PM +0900, Yoshihiro Kaneko wrote: > This series adds thermal support for r8a77995. > R-Car D3 (r8a77995) have a thermal sensor module which is similar to Gen2. > Therefore this series adds r8a77995 support to rcar_thermal driver not > rcar_gen3_thermal driver. > > This series is based on the next branch of Zhang Rui's linux tree. Seems like I cannot find Zhang's tree anywhere. My google-fu is surely bad, but can you paste a link to the tree here below, please? Thanks j > > v3 [Yoshihiro Kaneko] > * As suggested by Geert Uytterhoeven > rcar_thermal.c: > - make use_of_thermal in structure rcar_thermal_chip a single bit > - add feature bits to rcar_thermal_chip > - add the number of interrupts to rcar_thermal_chip > - remove rcar_thermal_type in rcar_thermal_cip > - make variable chip in rcar_thermal_probe() a const > > rcar-thermal.txt: > * No change > > r8a77995.dtsi: > * No change > > > v2 [Yoshihiro Kaneko] > * As suggested by Geert Uytterhoeven > rcar_thermal.c: > - remove rcar_of_data macro > - store a pointer to rcar_thermal_chip in rcar_thermal_priv > - remove unnecessary cast in rcar_thermal_dt_ids > > rcar-thermal.txt: > - drop the fallback for D3 > - update the paragraph about interrupts > > r8a77995.dtsi: > - fix the base address and the register addresses > - drop the fallback > > Yoshihiro Kaneko (3): > thermal: rcar_thermal: add r8a77995 support > dt-bindings: thermal: rcar-thermal: add R8A77995 support > arm64: dts: renesas: r8a77995: add thermal device support > > .../devicetree/bindings/thermal/rcar-thermal.txt | 7 +- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 30 > drivers/thermal/rcar_thermal.c | 154 > - > 3 files changed, 157 insertions(+), 34 deletions(-) > > -- > 1.9.1 > signature.asc Description: PGP signature
Re: [PATCH/RFT v3 0/3] thermal: add support for r8a77995
I am sorry On Wed, Apr 11, 2018 at 10:12:58AM +0200, jacopo mondi wrote: > Hello Kaneko-san > > On Tue, Apr 03, 2018 at 09:43:02PM +0900, Yoshihiro Kaneko wrote: > > This series adds thermal support for r8a77995. > > R-Car D3 (r8a77995) have a thermal sensor module which is similar to Gen2. > > Therefore this series adds r8a77995 support to rcar_thermal driver not > > rcar_gen3_thermal driver. > > > > This series is based on the next branch of Zhang Rui's linux tree. > > Seems like I cannot find Zhang's tree anywhere. My google-fu is surely > bad, but can you paste a link to the tree here below, please? It is clearly this one https://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git/ Sorry for the noise :) > > Thanks >j > > > > > v3 [Yoshihiro Kaneko] > > * As suggested by Geert Uytterhoeven > > rcar_thermal.c: > > - make use_of_thermal in structure rcar_thermal_chip a single bit > > - add feature bits to rcar_thermal_chip > > - add the number of interrupts to rcar_thermal_chip > > - remove rcar_thermal_type in rcar_thermal_cip > > - make variable chip in rcar_thermal_probe() a const > > > > rcar-thermal.txt: > > * No change > > > > r8a77995.dtsi: > > * No change > > > > > > v2 [Yoshihiro Kaneko] > > * As suggested by Geert Uytterhoeven > > rcar_thermal.c: > > - remove rcar_of_data macro > > - store a pointer to rcar_thermal_chip in rcar_thermal_priv > > - remove unnecessary cast in rcar_thermal_dt_ids > > > > rcar-thermal.txt: > > - drop the fallback for D3 > > - update the paragraph about interrupts > > > > r8a77995.dtsi: > > - fix the base address and the register addresses > > - drop the fallback > > > > Yoshihiro Kaneko (3): > > thermal: rcar_thermal: add r8a77995 support > > dt-bindings: thermal: rcar-thermal: add R8A77995 support > > arm64: dts: renesas: r8a77995: add thermal device support > > > > .../devicetree/bindings/thermal/rcar-thermal.txt | 7 +- > > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 30 > > drivers/thermal/rcar_thermal.c | 154 > > - > > 3 files changed, 157 insertions(+), 34 deletions(-) > > > > -- > > 1.9.1 > > signature.asc Description: PGP signature
Re: [PATCH/RFT v3 0/3] thermal: add support for r8a77995
Hi Jacopo > > This series adds thermal support for r8a77995. > > R-Car D3 (r8a77995) have a thermal sensor module which is similar to Gen2. > > Therefore this series adds r8a77995 support to rcar_thermal driver not > > rcar_gen3_thermal driver. > > > > This series is based on the next branch of Zhang Rui's linux tree. > > Seems like I cannot find Zhang's tree anywhere. My google-fu is surely > bad, but can you paste a link to the tree here below, please? I don't know detail, but in general you can find maintainer git repository from kernel.org https://www.kernel.org/ you can find "Cgit" link, and find Zhang's one ? Maybe you want is this ? kernel/git/rzhang/linux.git Thermal Management rzhang Best regards --- Kuninori Morimoto
Re: [PATCH/RFT v3 0/3] thermal: add support for r8a77995
Hi Jacopo,
On Wed, Apr 11, 2018 at 10:12 AM, jacopo mondi wrote:
> On Tue, Apr 03, 2018 at 09:43:02PM +0900, Yoshihiro Kaneko wrote:
>> This series adds thermal support for r8a77995.
>> R-Car D3 (r8a77995) have a thermal sensor module which is similar to Gen2.
>> Therefore this series adds r8a77995 support to rcar_thermal driver not
>> rcar_gen3_thermal driver.
>>
>> This series is based on the next branch of Zhang Rui's linux tree.
>
> Seems like I cannot find Zhang's tree anywhere. My google-fu is surely
> bad, but can you paste a link to the tree here below, please?
That tree is included in renesas-drivers:
- git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git#next
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH/RFT v3 0/3] thermal: add support for r8a77995
Hello Kaneko-san, On Tue, Apr 03, 2018 at 09:43:02PM +0900, Yoshihiro Kaneko wrote: > This series adds thermal support for r8a77995. > R-Car D3 (r8a77995) have a thermal sensor module which is similar to Gen2. > Therefore this series adds r8a77995 support to rcar_thermal driver not > rcar_gen3_thermal driver. I tested this on D3 Draak. I generated load expecting the detected temperature to rise. It took a while, and I only see a slight increase of the temperature reported by the 'temp' attribute. # cat /sys/class/thermal/thermal_zone0/temp 3 # while :; do cat /dev/urandom > /dev/null; done ...(wait 2 minutes) # cat /sys/class/thermal/thermal_zone0/temp 35000 (wait 30 seconds) # cat /sys/class/thermal/thermal_zone0/temp 3 Is this result ok for your testing? Thanks j > > This series is based on the next branch of Zhang Rui's linux tree. > > v3 [Yoshihiro Kaneko] > * As suggested by Geert Uytterhoeven > rcar_thermal.c: > - make use_of_thermal in structure rcar_thermal_chip a single bit > - add feature bits to rcar_thermal_chip > - add the number of interrupts to rcar_thermal_chip > - remove rcar_thermal_type in rcar_thermal_cip > - make variable chip in rcar_thermal_probe() a const > > rcar-thermal.txt: > * No change > > r8a77995.dtsi: > * No change > > > v2 [Yoshihiro Kaneko] > * As suggested by Geert Uytterhoeven > rcar_thermal.c: > - remove rcar_of_data macro > - store a pointer to rcar_thermal_chip in rcar_thermal_priv > - remove unnecessary cast in rcar_thermal_dt_ids > > rcar-thermal.txt: > - drop the fallback for D3 > - update the paragraph about interrupts > > r8a77995.dtsi: > - fix the base address and the register addresses > - drop the fallback > > Yoshihiro Kaneko (3): > thermal: rcar_thermal: add r8a77995 support > dt-bindings: thermal: rcar-thermal: add R8A77995 support > arm64: dts: renesas: r8a77995: add thermal device support > > .../devicetree/bindings/thermal/rcar-thermal.txt | 7 +- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 30 > drivers/thermal/rcar_thermal.c | 154 > - > 3 files changed, 157 insertions(+), 34 deletions(-) > > -- > 1.9.1 > signature.asc Description: PGP signature
Re: [PATCH/RFT v3 0/3] thermal: add support for r8a77995
On Wed, Apr 11, 2018 at 11:01 AM, jacopo mondi wrote: > Hello Kaneko-san, > > On Tue, Apr 03, 2018 at 09:43:02PM +0900, Yoshihiro Kaneko wrote: >> This series adds thermal support for r8a77995. >> R-Car D3 (r8a77995) have a thermal sensor module which is similar to Gen2. >> Therefore this series adds r8a77995 support to rcar_thermal driver not >> rcar_gen3_thermal driver. > > I tested this on D3 Draak. > > I generated load expecting the detected temperature to rise. > > It took a while, and I only see a slight increase of the temperature > reported by the 'temp' attribute. Pointing a heat gun at the SoC, I managed to get the temperature up to 8, and it went back to 4 when I removed it. I'd say this works. Tested-By: Ulrich Hecht CU Uli
Re: [PATCH/RFT v3 0/3] thermal: add support for r8a77995
Hi Ulrich, On 2018-05-16 15:07:01 +0200, Ulrich Hecht wrote: > On Wed, Apr 11, 2018 at 11:01 AM, jacopo mondi wrote: > > Hello Kaneko-san, > > > > On Tue, Apr 03, 2018 at 09:43:02PM +0900, Yoshihiro Kaneko wrote: > >> This series adds thermal support for r8a77995. > >> R-Car D3 (r8a77995) have a thermal sensor module which is similar to Gen2. > >> Therefore this series adds r8a77995 support to rcar_thermal driver not > >> rcar_gen3_thermal driver. > > > > I tested this on D3 Draak. > > > > I generated load expecting the detected temperature to rise. > > > > It took a while, and I only see a slight increase of the temperature > > reported by the 'temp' attribute. > > Pointing a heat gun at the SoC, I managed to get the temperature up to > 8, and it went back to 4 when I removed it. I'd say this > works. I like your style! I contemplated using a hairdryer when testing some Gen3 thermal work but decided against it. Good too see others are not as weak minded as my self :-) > > Tested-By: Ulrich Hecht > > CU > Uli -- Regards, Niklas Söderlund
Re: [PATCH/RFT v3 0/3] thermal: add support for r8a77995
On Wed, May 16, 2018 at 09:08:06PM +0200, Niklas Söderlund wrote: > Hi Ulrich, > > On 2018-05-16 15:07:01 +0200, Ulrich Hecht wrote: > > On Wed, Apr 11, 2018 at 11:01 AM, jacopo mondi wrote: > > > Hello Kaneko-san, > > > > > > On Tue, Apr 03, 2018 at 09:43:02PM +0900, Yoshihiro Kaneko wrote: > > >> This series adds thermal support for r8a77995. > > >> R-Car D3 (r8a77995) have a thermal sensor module which is similar to > > >> Gen2. > > >> Therefore this series adds r8a77995 support to rcar_thermal driver not > > >> rcar_gen3_thermal driver. > > > > > > I tested this on D3 Draak. > > > > > > I generated load expecting the detected temperature to rise. > > > > > > It took a while, and I only see a slight increase of the temperature > > > reported by the 'temp' attribute. > > > > Pointing a heat gun at the SoC, I managed to get the temperature up to > > 8, and it went back to 4 when I removed it. I'd say this > > works. > > I like your style! I contemplated using a hairdryer when testing some > Gen3 thermal work but decided against it. Good too see others are not as > weak minded as my self :-) I think that we may need some new tags to differentiate between weak and awesome tests. > > Tested-By: Ulrich Hecht > > > > CU > > Uli > > -- > Regards, > Niklas Söderlund >
