Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
Hi Fabrizio, Hi Geert, On Wed, Sep 19, 2018 at 10:21:13AM +, Fabrizio Castro wrote: > Hello Geert, > > Thank you for your feedback. > > > Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU > > core > > > > Perhaps "ARM: dts: r8a77470: Add SMP support"? > > Your proposal is with me, Simon do you want me to send a v2 for this? Thanks, I have applied this for v4.20 with the updated subject and Geert's review tag. > > > > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro > > wrote: > > > Add DT node for the Advanced Power Management Unit (APMU), add the > > > second CPU core, and use "renesas,apmu" as "enable-method". > > > > > > Signed-off-by: Fabrizio Castro > > > Reviewed-by: Biju Das > > > > Reviewed-by: Geert Uytterhoeven ... On Wed, Sep 19, 2018 at 10:24:00AM +0000, Fabrizio Castro wrote: > Hello Simon, > > Thank you for your feedback. > > > Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU > > core > > > > On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote: > > > Perhaps "ARM: dts: r8a77470: Add SMP support"? > > > > > > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro > > > wrote: > > > > Add DT node for the Advanced Power Management Unit (APMU), add the > > > > second CPU core, and use "renesas,apmu" as "enable-method". > > > > > > > > Signed-off-by: Fabrizio Castro > > > > Reviewed-by: Biju Das > > > > > > Reviewed-by: Geert Uytterhoeven > > > > I would like to ask to what extent this has been tested with respect to > > CPU hotplug, suspend to RAM, and combinations thereof. > > Both CPU hotplug and STR were tested on their own and combined, I haven't > encountered any issue so far. On Wed, Sep 19, 2018 at 10:32:24AM +, Fabrizio Castro wrote: > Hello Simon, > > Thank you for your feedback. > > > Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU > > core > > > > On Wed, Sep 19, 2018 at 10:25:42AM +0200, Simon Horman wrote: > > > On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote: > > > > Perhaps "ARM: dts: r8a77470: Add SMP support"? > > > > > > > > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro > > > > wrote: > > > > > Add DT node for the Advanced Power Management Unit (APMU), add the > > > > > second CPU core, and use "renesas,apmu" as "enable-method". > > > > > > > > > > Signed-off-by: Fabrizio Castro > > > > > Reviewed-by: Biju Das > > > > > > > > Reviewed-by: Geert Uytterhoeven > > > > > > I would like to ask to what extent this has been tested with respect to > > > CPU hotplug, suspend to RAM, and combinations thereof. > > > > And any details of firmware, bootloader, ... version stacks where this is > > supported. > > iW-RainboW-G23S SPI_LOADER(DDR3) V1.00 2016.03.25 > U-Boot 2013.01.01-gaa28b1d-dirty (Feb 01 2018 - 22:55:39) > > # cat /sys/devices/soc0/revision > ES2.0 > > I hope this helps. Thanks for your follow-up on the testing and environment, it does indeed help to give me confidence when applying this patch. ...
RE: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
Hello Simon, Thank you for your feedback. > Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core > > On Wed, Sep 19, 2018 at 10:25:42AM +0200, Simon Horman wrote: > > On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote: > > > Perhaps "ARM: dts: r8a77470: Add SMP support"? > > > > > > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro > > > wrote: > > > > Add DT node for the Advanced Power Management Unit (APMU), add the > > > > second CPU core, and use "renesas,apmu" as "enable-method". > > > > > > > > Signed-off-by: Fabrizio Castro > > > > Reviewed-by: Biju Das > > > > > > Reviewed-by: Geert Uytterhoeven > > > > I would like to ask to what extent this has been tested with respect to > > CPU hotplug, suspend to RAM, and combinations thereof. > > And any details of firmware, bootloader, ... version stacks where this is > supported. iW-RainboW-G23S SPI_LOADER(DDR3) V1.00 2016.03.25 U-Boot 2013.01.01-gaa28b1d-dirty (Feb 01 2018 - 22:55:39) # cat /sys/devices/soc0/revision ES2.0 I hope this helps. Thanks, Fab Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
RE: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
Hello Simon, Thank you for your feedback. > Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core > > On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote: > > Perhaps "ARM: dts: r8a77470: Add SMP support"? > > > > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro > > wrote: > > > Add DT node for the Advanced Power Management Unit (APMU), add the > > > second CPU core, and use "renesas,apmu" as "enable-method". > > > > > > Signed-off-by: Fabrizio Castro > > > Reviewed-by: Biju Das > > > > Reviewed-by: Geert Uytterhoeven > > I would like to ask to what extent this has been tested with respect to > CPU hotplug, suspend to RAM, and combinations thereof. Both CPU hotplug and STR were tested on their own and combined, I haven't encountered any issue so far. Thanks, Fab Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
RE: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
Hello Geert,
Thank you for your feedback.
> Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
>
> Perhaps "ARM: dts: r8a77470: Add SMP support"?
Your proposal is with me, Simon do you want me to send a v2 for this?
Thanks,
Fab
>
> On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
> wrote:
> > Add DT node for the Advanced Power Management Unit (APMU), add the
> > second CPU core, and use "renesas,apmu" as "enable-method".
> >
> > Signed-off-by: Fabrizio Castro
> > Reviewed-by: Biju Das
>
> Reviewed-by: Geert Uytterhoeven
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 --
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End,
Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered
No. 04586709.
Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
On Wed, Sep 19, 2018 at 10:25:42AM +0200, Simon Horman wrote: > On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote: > > Perhaps "ARM: dts: r8a77470: Add SMP support"? > > > > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro > > wrote: > > > Add DT node for the Advanced Power Management Unit (APMU), add the > > > second CPU core, and use "renesas,apmu" as "enable-method". > > > > > > Signed-off-by: Fabrizio Castro > > > Reviewed-by: Biju Das > > > > Reviewed-by: Geert Uytterhoeven > > I would like to ask to what extent this has been tested with respect to > CPU hotplug, suspend to RAM, and combinations thereof. And any details of firmware, bootloader, ... version stacks where this is supported.
Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote: > Perhaps "ARM: dts: r8a77470: Add SMP support"? > > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro > wrote: > > Add DT node for the Advanced Power Management Unit (APMU), add the > > second CPU core, and use "renesas,apmu" as "enable-method". > > > > Signed-off-by: Fabrizio Castro > > Reviewed-by: Biju Das > > Reviewed-by: Geert Uytterhoeven I would like to ask to what extent this has been tested with respect to CPU hotplug, suspend to RAM, and combinations thereof.
Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
Perhaps "ARM: dts: r8a77470: Add SMP support"?
On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
wrote:
> Add DT node for the Advanced Power Management Unit (APMU), add the
> second CPU core, and use "renesas,apmu" as "enable-method".
>
> Signed-off-by: Fabrizio Castro
> Reviewed-by: Biju Das
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
[PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
Add DT node for the Advanced Power Management Unit (APMU), add the
second CPU core, and use "renesas,apmu" as "enable-method".
Signed-off-by: Fabrizio Castro
Reviewed-by: Biju Das
---
arch/arm/boot/dts/r8a77470.dtsi | 16
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
index c053a28..9aba350 100644
--- a/arch/arm/boot/dts/r8a77470.dtsi
+++ b/arch/arm/boot/dts/r8a77470.dtsi
@@ -17,6 +17,7 @@
cpus {
#address-cells = <1>;
#size-cells = <0>;
+ enable-method = "renesas,apmu";
cpu0: cpu@0 {
device_type = "cpu";
@@ -28,6 +29,15 @@
next-level-cache = <_CA7>;
};
+ cpu1: cpu@1 {
+ device_type = "cpu";
+ compatible = "arm,cortex-a7";
+ reg = <1>;
+ clock-frequency = <10>;
+ clocks = < CPG_CORE R8A77470_CLK_Z2>;
+ power-domains = < R8A77470_PD_CA7_CPU1>;
+ next-level-cache = <_CA7>;
+ };
L2_CA7: cache-controller-0 {
compatible = "cache";
@@ -167,6 +177,12 @@
#reset-cells = <1>;
};
+ apmu@e6151000 {
+ compatible = "renesas,r8a77470-apmu", "renesas,apmu";
+ reg = <0 0xe6151000 0 0x188>;
+ cpus = < >;
+ };
+
rst: reset-controller@e616 {
compatible = "renesas,r8a77470-rst";
reg = <0 0xe616 0 0x100>;
--
2.7.4
