[PATCH 2/6] i2c: add identifier in declarations for i2c_bus_recovery

2017-12-04 Thread Wolfram Sang 
No reason to have them undefined, so let's add them.

Cc: Phil Reid 
Cc: Andy Shevchenko 
Cc: Jarkko Nikula 
Cc: Claudio Foellmi 
Cc: Andrzej Hajda 
Signed-off-by: Wolfram Sang 
---
 include/linux/i2c.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index f8a9d81e911e52..8a020617b4e780 100644
--- a/include/linux/i2c.h
+++ b/include/linux/i2c.h
@@ -561,9 +561,9 @@ struct i2c_timings {
 struct i2c_bus_recovery_info {
int (*recover_bus)(struct i2c_adapter *);
 
-   int (*get_scl)(struct i2c_adapter *);
-   void (*set_scl)(struct i2c_adapter *, int val);
-   int (*get_sda)(struct i2c_adapter *);
+   int (*get_scl)(struct i2c_adapter *adap);
+   void (*set_scl)(struct i2c_adapter *adap, int val);
+   int (*get_sda)(struct i2c_adapter *adap);
 
void (*prepare_recovery)(struct i2c_adapter *);
void (*unprepare_recovery)(struct i2c_adapter *);
-- 
2.11.0

Re: [PATCH 2/6] i2c: add identifier in declarations for i2c_bus_recovery

2017-12-13 Thread Andy Shevchenko 
On Mon, 2017-12-04 at 13:36 +0100, Wolfram Sang wrote:
> No reason to have them undefined, so let's add them.
> 

>   int (*recover_bus)(struct i2c_adapter *);
>  
> - int (*get_scl)(struct i2c_adapter *);
> - void (*set_scl)(struct i2c_adapter *, int val);
> - int (*get_sda)(struct i2c_adapter *);
> + int (*get_scl)(struct i2c_adapter *adap);
> + void (*set_scl)(struct i2c_adapter *adap, int val);
> + int (*get_sda)(struct i2c_adapter *adap);
>  
>   void (*prepare_recovery)(struct i2c_adapter *);
>   void (*unprepare_recovery)(struct i2c_adapter *);

It seems inconsistent with the rest of the members even from this
visible piece.

-- 
Andy Shevchenko 
Intel Finland Oy

Re: [PATCH 2/6] i2c: add identifier in declarations for i2c_bus_recovery

2018-01-09 Thread Wolfram Sang 
On Wed, Dec 13, 2017 at 05:23:02PM +0200, Andy Shevchenko wrote:
> On Mon, 2017-12-04 at 13:36 +0100, Wolfram Sang wrote:
> > No reason to have them undefined, so let's add them.
> > 
> 
> > int (*recover_bus)(struct i2c_adapter *);
> >  
> > -   int (*get_scl)(struct i2c_adapter *);
> > -   void (*set_scl)(struct i2c_adapter *, int val);
> > -   int (*get_sda)(struct i2c_adapter *);
> > +   int (*get_scl)(struct i2c_adapter *adap);
> > +   void (*set_scl)(struct i2c_adapter *adap, int val);
> > +   int (*get_sda)(struct i2c_adapter *adap);
> >  
> > void (*prepare_recovery)(struct i2c_adapter *);
> > void (*unprepare_recovery)(struct i2c_adapter *);
> 
> It seems inconsistent with the rest of the members even from this
> visible piece.

Agreed. Either overlooked, or lost during rebase. Any way, will fix!



signature.asc
Description: PGP signature