Re: [PATCH v2 0/8] r8a7795/6 Salvator-X PWM enablement

[Simon Horman]

On Fri, May 12, 2017 at 01:00:34PM +0300, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Friday 12 May 2017 11:16:39 Simon Horman wrote:
> > On Thu, Apr 27, 2017 at 04:37:35PM +0200, Ulrich Hecht wrote:
> > > Hi!
> > > 
> > > Here's the revised series enabling PWMs on r8a7795 and r8a7796 Salvator-X
> > > boards.
> > > 
> > > This revision addresses the issues found by Geert and adds Laurent's
> > > backlight support patch, including a version for r8a7796.
> > > 
> > > CU
> > > Uli
> > > 
> > > Changes since v1:
> > > - PWM clock is S0D12, not S3D4
> > > - dts: fix register lengths, add resets
> > > - only enable one set of pins for each PWM
> > > - add backlight support
> > > 
> > > Laurent Pinchart (1):
> > >   arm64: dts: r8a7795: salvator-x: Add panel backlight support
> > > 
> > > Ryo Kodama (2):
> > >   clk: renesas: r8a7796: add PWM clock
> > >   arm64: dts: r8a7796-salvator-x: Add PWM device support
> > > 
> > > Takeshi Kihara (3):
> > >   pinctrl: sh-pfc: r8a7796: Add PWM pins, groups and functions
> > >   arm64: dts: r8a7796: Add PWM device nodes
> > >   arm64: dts: r8a7795-salvator-x: Enable PWM2
> > 
> > I did not notice any regressions on salvator-x/r8a7796 after applying up
> > the dts patches without the clk and pinctrl patches. So I have queued up
> > the dts patches as follows:
> > 
> > * arm64: dts: r8a7796: Add PWM device nodes
> >   -> applied
> > 
> > * arm64: dts: r8a7795: salvator-x: Add panel backlight support
> > * arm64: dts: r8a7795-salvator-x: Enable PWM2
> 
> I've asked Ulrich for a clarification on this patch as I'm not sure it's 
> needed, but he hasn't answered yet. Could we delay merging it until the 
> situation is clarified ?

Sure, I will drop the "Enable PWM2" patch.

> All other patches in this series should be fine.
> 
> >   -> applied to salvator-x.dtsi instead of r8a7796-salvator-x.dts
> > 
> > * arm64: dts: r8a7796: salvator-x: Add panel backlight support
> > * arm64: dts: r8a7796-salvator-x: Add PWM device support
> >   -> not applied as they would be the same changes as those above
> >  applied to salvator-x.dtsi
> > 
> > > Ulrich Hecht (2):
> > >   arm64: dts: r8a7796: salvator-x: Add panel backlight support
> > >   dt-bindings: pwm: Add R-Car M3-W device tree bindings
> > 
> > I took the liberty of reposting the dt-bindings patch with an updated To/Cc
> > list.
> > 
> > >  .../devicetree/bindings/pwm/renesas,pwm-rcar.txt   |   1 +
> > >  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts |  34 +
> > >  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts |  35 +
> > >  arch/arm64/boot/dts/renesas/r8a7796.dtsi   |  70 ++
> > >  drivers/clk/renesas/r8a7796-cpg-mssr.c |   1 +
> > >  drivers/pinctrl/sh-pfc/pfc-r8a7796.c   | 153 
> > >  6 files changed, 294 insertions(+)
> 
> -- 
> Regards,
> 
> Laurent Pinchart
> 

Re: [PATCH v2 0/8] r8a7795/6 Salvator-X PWM enablement

[Laurent Pinchart]

Hi Ulrich,

On Friday 12 May 2017 12:36:50 Ulrich Hecht wrote:
> On Fri, May 12, 2017 at 12:00 PM, Laurent Pinchart wrote:
> >> * arm64: dts: r8a7795-salvator-x: Enable PWM2
> > 
> > I've asked Ulrich for a clarification on this patch as I'm not sure it's
> > needed, but he hasn't answered yet. Could we delay merging it until the
> > situation is clarified ?
> 
> Enabling it allows to control the switching frequency from userspace
> via sysfs. I guess it's a matter of taste whether to do this by
> default, but I see no downside to it.

For PWM signals that are meant to be used by expansion boards, sure, but this 
one is meant to control the PMIC. I'd rather not let userspace mess with it.

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 0/8] r8a7795/6 Salvator-X PWM enablement

[Ulrich Hecht]

On Fri, May 12, 2017 at 12:00 PM, Laurent Pinchart
 wrote:
>> * arm64: dts: r8a7795-salvator-x: Enable PWM2
>
> I've asked Ulrich for a clarification on this patch as I'm not sure it's
> needed, but he hasn't answered yet. Could we delay merging it until the
> situation is clarified ?

Enabling it allows to control the switching frequency from userspace
via sysfs. I guess it's a matter of taste whether to do this by
default, but I see no downside to it.

CU
Uli

Re: [PATCH v2 0/8] r8a7795/6 Salvator-X PWM enablement

[Laurent Pinchart]

Hi Simon,

On Friday 12 May 2017 11:16:39 Simon Horman wrote:
> On Thu, Apr 27, 2017 at 04:37:35PM +0200, Ulrich Hecht wrote:
> > Hi!
> > 
> > Here's the revised series enabling PWMs on r8a7795 and r8a7796 Salvator-X
> > boards.
> > 
> > This revision addresses the issues found by Geert and adds Laurent's
> > backlight support patch, including a version for r8a7796.
> > 
> > CU
> > Uli
> > 
> > Changes since v1:
> > - PWM clock is S0D12, not S3D4
> > - dts: fix register lengths, add resets
> > - only enable one set of pins for each PWM
> > - add backlight support
> > 
> > Laurent Pinchart (1):
> >   arm64: dts: r8a7795: salvator-x: Add panel backlight support
> > 
> > Ryo Kodama (2):
> >   clk: renesas: r8a7796: add PWM clock
> >   arm64: dts: r8a7796-salvator-x: Add PWM device support
> > 
> > Takeshi Kihara (3):
> >   pinctrl: sh-pfc: r8a7796: Add PWM pins, groups and functions
> >   arm64: dts: r8a7796: Add PWM device nodes
> >   arm64: dts: r8a7795-salvator-x: Enable PWM2
> 
> I did not notice any regressions on salvator-x/r8a7796 after applying up
> the dts patches without the clk and pinctrl patches. So I have queued up
> the dts patches as follows:
> 
> * arm64: dts: r8a7796: Add PWM device nodes
>   -> applied
> 
> * arm64: dts: r8a7795: salvator-x: Add panel backlight support
> * arm64: dts: r8a7795-salvator-x: Enable PWM2

I've asked Ulrich for a clarification on this patch as I'm not sure it's 
needed, but he hasn't answered yet. Could we delay merging it until the 
situation is clarified ?

All other patches in this series should be fine.

>   -> applied to salvator-x.dtsi instead of r8a7796-salvator-x.dts
> 
> * arm64: dts: r8a7796: salvator-x: Add panel backlight support
> * arm64: dts: r8a7796-salvator-x: Add PWM device support
>   -> not applied as they would be the same changes as those above
>  applied to salvator-x.dtsi
> 
> > Ulrich Hecht (2):
> >   arm64: dts: r8a7796: salvator-x: Add panel backlight support
> >   dt-bindings: pwm: Add R-Car M3-W device tree bindings
> 
> I took the liberty of reposting the dt-bindings patch with an updated To/Cc
> list.
> 
> >  .../devicetree/bindings/pwm/renesas,pwm-rcar.txt   |   1 +
> >  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts |  34 +
> >  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts |  35 +
> >  arch/arm64/boot/dts/renesas/r8a7796.dtsi   |  70 ++
> >  drivers/clk/renesas/r8a7796-cpg-mssr.c |   1 +
> >  drivers/pinctrl/sh-pfc/pfc-r8a7796.c   | 153 
> >  6 files changed, 294 insertions(+)

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 0/8] r8a7795/6 Salvator-X PWM enablement

[Simon Horman]

On Thu, Apr 27, 2017 at 04:37:35PM +0200, Ulrich Hecht wrote:
> Hi!
> 
> Here's the revised series enabling PWMs on r8a7795 and r8a7796 Salvator-X
> boards.
> 
> This revision addresses the issues found by Geert and adds Laurent's
> backlight support patch, including a version for r8a7796.
> 
> CU
> Uli
> 
> Changes since v1:
> - PWM clock is S0D12, not S3D4
> - dts: fix register lengths, add resets
> - only enable one set of pins for each PWM
> - add backlight support
> 
> 
> Laurent Pinchart (1):
>   arm64: dts: r8a7795: salvator-x: Add panel backlight support
> 
> Ryo Kodama (2):
>   clk: renesas: r8a7796: add PWM clock
>   arm64: dts: r8a7796-salvator-x: Add PWM device support
> 
> Takeshi Kihara (3):
>   pinctrl: sh-pfc: r8a7796: Add PWM pins, groups and functions
>   arm64: dts: r8a7796: Add PWM device nodes
>   arm64: dts: r8a7795-salvator-x: Enable PWM2

I did not notice any regressions on salvator-x/r8a7796 after applying up
the dts patches without the clk and pinctrl patches. So I have queued up
the dts patches as follows:

* arm64: dts: r8a7796: Add PWM device nodes
  -> applied

* arm64: dts: r8a7795: salvator-x: Add panel backlight support
* arm64: dts: r8a7795-salvator-x: Enable PWM2
  -> applied to salvator-x.dtsi instead of r8a7796-salvator-x.dts

* arm64: dts: r8a7796: salvator-x: Add panel backlight support
* arm64: dts: r8a7796-salvator-x: Add PWM device support
  -> not applied as they would be the same changes as those above
 applied to salvator-x.dtsi

> Ulrich Hecht (2):
>   arm64: dts: r8a7796: salvator-x: Add panel backlight support
>   dt-bindings: pwm: Add R-Car M3-W device tree bindings

I took the liberty of reposting the dt-bindings patch with an updated To/Cc
list.

>  .../devicetree/bindings/pwm/renesas,pwm-rcar.txt   |   1 +
>  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts |  34 +
>  arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts |  35 +
>  arch/arm64/boot/dts/renesas/r8a7796.dtsi   |  70 ++
>  drivers/clk/renesas/r8a7796-cpg-mssr.c |   1 +
>  drivers/pinctrl/sh-pfc/pfc-r8a7796.c   | 153 
> +
>  6 files changed, 294 insertions(+)
> 
> -- 
> 2.7.4
> 

Re: [PATCH v2 0/8] r8a7795/6 Salvator-X PWM enablement

[Simon Horman]

On Thu, Apr 27, 2017 at 04:37:35PM +0200, Ulrich Hecht wrote:
> Hi!
> 
> Here's the revised series enabling PWMs on r8a7795 and r8a7796 Salvator-X
> boards.
> 
> This revision addresses the issues found by Geert and adds Laurent's
> backlight support patch, including a version for r8a7796.
> 
> CU
> Uli
> 
> Changes since v1:
> - PWM clock is S0D12, not S3D4
> - dts: fix register lengths, add resets
> - only enable one set of pins for each PWM
> - add backlight support
> 
> 
> Laurent Pinchart (1):
>   arm64: dts: r8a7795: salvator-x: Add panel backlight support
> 
> Ryo Kodama (2):
>   clk: renesas: r8a7796: add PWM clock
>   arm64: dts: r8a7796-salvator-x: Add PWM device support
> 
> Takeshi Kihara (3):
>   pinctrl: sh-pfc: r8a7796: Add PWM pins, groups and functions
>   arm64: dts: r8a7796: Add PWM device nodes
>   arm64: dts: r8a7795-salvator-x: Enable PWM2
> 
> Ulrich Hecht (2):
>   arm64: dts: r8a7796: salvator-x: Add panel backlight support
>   dt-bindings: pwm: Add R-Car M3-W device tree bindings

Hi,

am I correct in thinking that the dts patches do not cause a regression and
their only DT dependency is on the "renesas,pwm-r8a7796" compat string.
If so I am of a mind to quire them up as the nodes that need the new compat
string also make use of the "renesas,pwm-rcar" compat string which is
already present in mainline.

[PATCH v2 0/8] r8a7795/6 Salvator-X PWM enablement

[Ulrich Hecht]

Hi!

Here's the revised series enabling PWMs on r8a7795 and r8a7796 Salvator-X
boards.

This revision addresses the issues found by Geert and adds Laurent's
backlight support patch, including a version for r8a7796.

CU
Uli

Changes since v1:
- PWM clock is S0D12, not S3D4
- dts: fix register lengths, add resets
- only enable one set of pins for each PWM
- add backlight support


Laurent Pinchart (1):
  arm64: dts: r8a7795: salvator-x: Add panel backlight support

Ryo Kodama (2):
  clk: renesas: r8a7796: add PWM clock
  arm64: dts: r8a7796-salvator-x: Add PWM device support

Takeshi Kihara (3):
  pinctrl: sh-pfc: r8a7796: Add PWM pins, groups and functions
  arm64: dts: r8a7796: Add PWM device nodes
  arm64: dts: r8a7795-salvator-x: Enable PWM2

Ulrich Hecht (2):
  arm64: dts: r8a7796: salvator-x: Add panel backlight support
  dt-bindings: pwm: Add R-Car M3-W device tree bindings

 .../devicetree/bindings/pwm/renesas,pwm-rcar.txt   |   1 +
 arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts |  34 +
 arch/arm64/boot/dts/renesas/r8a7796-salvator-x.dts |  35 +
 arch/arm64/boot/dts/renesas/r8a7796.dtsi   |  70 ++
 drivers/clk/renesas/r8a7796-cpg-mssr.c |   1 +
 drivers/pinctrl/sh-pfc/pfc-r8a7796.c   | 153 +
 6 files changed, 294 insertions(+)

-- 
2.7.4