Re: [PATCH] ARM: S5P: Fix compilation error for exynos4_defconfig
Hi Marek, Thanks for your review. On Friday 03 June 2011 11:23 AM, Marek Szyprowski wrote: Hello, On Friday, June 03, 2011 7:07 AM Tushar Behera wrote: EHCI requires that USB support be enabled in kernel config. Selecting USB_SUPPORT with S5P_DEV_USB_EHCI fixes the problem. Signed-off-by: Tushar Beheratushar.beh...@linaro.org --- arch/arm/plat-s5p/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/arm/plat-s5p/Kconfig b/arch/arm/plat-s5p/Kconfig index e98f5c5..c7e7419 100644 --- a/arch/arm/plat-s5p/Kconfig +++ b/arch/arm/plat-s5p/Kconfig @@ -87,6 +87,7 @@ config S5P_DEV_CSIS1 config S5P_DEV_USB_EHCI bool + select USB_SUPPORT IMHO this is not the best way to solve this issue. The main problem is the fact that usb-phy.c file depends on CONFIG_USB_SUPPORT not it's own Kconfig entry. Please check arch/arm/mach-exynos4/Makefile. To match the style of other helper functions, usb-phy.c should be renamed to setup-usb-phy.c and get it's own Kconfig entry like CONFIG_EXYNOS4_SETUP_USB_PHY. Also the machine that uses it should select this new entry. This is really not related to CONFIG_USB_SUPPORT at all (one might want to have a kernel without USB support for some reason). Ok. I will re-submit the patch. help Compile in platform device definition for USB EHCI -- Best regards -- Tushar Behera -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH V2] ARM: S5P: Fix compilation error for exynos4_defconfig
Added Kconfig entry for setup-usb-phy.c on which EHCI support is
dependent on.
Following the naming convention of other setup files, we have following
renaming.
usb-phy.c == setup-usb-phy.c
Signed-off-by: Tushar Behera tushar.beh...@linaro.org
---
arch/arm/mach-exynos4/Kconfig |6 ++
arch/arm/mach-exynos4/Makefile |2 +-
.../mach-exynos4/{usb-phy.c = setup-usb-phy.c}|0
3 files changed, 7 insertions(+), 1 deletions(-)
rename arch/arm/mach-exynos4/{usb-phy.c = setup-usb-phy.c} (100%)
diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
index b92c1e5..a45a022 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig
@@ -91,6 +91,11 @@ config EXYNOS4_SETUP_FIMC
help
Common setup code for the camera interfaces.
+config EXYNOS4_SETUP_USB_PHY
+ bool
+ help
+ Common setup code for USB PHY controller
+
# machine support
menu EXYNOS4 Machines
@@ -176,6 +181,7 @@ config MACH_NURI
select EXYNOS4_SETUP_I2C3
select EXYNOS4_SETUP_I2C5
select EXYNOS4_SETUP_SDHCI
+ select EXYNOS4_SETUP_USB_PHY
select SAMSUNG_DEV_PWM
help
Machine support for Samsung Mobile NURI Board.
diff --git a/arch/arm/mach-exynos4/Makefile b/arch/arm/mach-exynos4/Makefile
index a9bb94f..60fe5ec 100644
--- a/arch/arm/mach-exynos4/Makefile
+++ b/arch/arm/mach-exynos4/Makefile
@@ -56,4 +56,4 @@ obj-$(CONFIG_EXYNOS4_SETUP_KEYPAD)+= setup-keypad.o
obj-$(CONFIG_EXYNOS4_SETUP_SDHCI) += setup-sdhci.o
obj-$(CONFIG_EXYNOS4_SETUP_SDHCI_GPIO) += setup-sdhci-gpio.o
-obj-$(CONFIG_USB_SUPPORT) += usb-phy.o
+obj-$(CONFIG_EXYNOS4_SETUP_USB_PHY)+= setup-usb-phy.o
diff --git a/arch/arm/mach-exynos4/usb-phy.c
b/arch/arm/mach-exynos4/setup-usb-phy.c
similarity index 100%
rename from arch/arm/mach-exynos4/usb-phy.c
rename to arch/arm/mach-exynos4/setup-usb-phy.c
--
1.7.1
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] ARM: S5P: Fix compilation error for exynos4_defconfig
On 2011-06-03 오후 4:04, Tushar Behera wrote:
Added Kconfig entry for setup-usb-phy.c on which EHCI support is
dependent on.
Following the naming convention of other setup files, we have following
renaming.
usb-phy.c == setup-usb-phy.c
Signed-off-by: Tushar Beheratushar.beh...@linaro.org
---
arch/arm/mach-exynos4/Kconfig |6 ++
arch/arm/mach-exynos4/Makefile |2 +-
.../mach-exynos4/{usb-phy.c = setup-usb-phy.c}|0
3 files changed, 7 insertions(+), 1 deletions(-)
rename arch/arm/mach-exynos4/{usb-phy.c = setup-usb-phy.c} (100%)
There is one white space but
Acked-by: Joonyoung Shim jy0922.s...@samsung.com
diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
index b92c1e5..a45a022 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig
@@ -91,6 +91,11 @@ config EXYNOS4_SETUP_FIMC
help
Common setup code for the camera interfaces.
+config EXYNOS4_SETUP_USB_PHY
+ bool
+ help
+ Common setup code for USB PHY controller
White space.
+
# machine support
menu EXYNOS4 Machines
@@ -176,6 +181,7 @@ config MACH_NURI
select EXYNOS4_SETUP_I2C3
select EXYNOS4_SETUP_I2C5
select EXYNOS4_SETUP_SDHCI
+ select EXYNOS4_SETUP_USB_PHY
select SAMSUNG_DEV_PWM
help
Machine support for Samsung Mobile NURI Board.
diff --git a/arch/arm/mach-exynos4/Makefile b/arch/arm/mach-exynos4/Makefile
index a9bb94f..60fe5ec 100644
--- a/arch/arm/mach-exynos4/Makefile
+++ b/arch/arm/mach-exynos4/Makefile
@@ -56,4 +56,4 @@ obj-$(CONFIG_EXYNOS4_SETUP_KEYPAD)+= setup-keypad.o
obj-$(CONFIG_EXYNOS4_SETUP_SDHCI) += setup-sdhci.o
obj-$(CONFIG_EXYNOS4_SETUP_SDHCI_GPIO)+= setup-sdhci-gpio.o
-obj-$(CONFIG_USB_SUPPORT) += usb-phy.o
+obj-$(CONFIG_EXYNOS4_SETUP_USB_PHY)+= setup-usb-phy.o
diff --git a/arch/arm/mach-exynos4/usb-phy.c
b/arch/arm/mach-exynos4/setup-usb-phy.c
similarity index 100%
rename from arch/arm/mach-exynos4/usb-phy.c
rename to arch/arm/mach-exynos4/setup-usb-phy.c
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] ARM: S5P: Fix compilation error for exynos4_defconfig
Acked-by: Jingoo Han jg1@samsung.com
--- Original Message ---
Sender : Tushar Beheratushar.beh...@linaro.org
Date : Jun 03, 2011 16:04 (GMT+09:00)
Title : [PATCH V2] ARM: S5P: Fix compilation error for exynos4_defconfig
Added Kconfig entry for setup-usb-phy.c on which EHCI support is
dependent on.
Following the naming convention of other setup files, we have following
renaming.
usb-phy.c == setup-usb-phy.c
Signed-off-by: Tushar Behera tushar.beh...@linaro.org
---
arch/arm/mach-exynos4/Kconfig |6 ++
arch/arm/mach-exynos4/Makefile |2 +-
.../mach-exynos4/{usb-phy.c = setup-usb-phy.c}|0
3 files changed, 7 insertions(+), 1 deletions(-)
rename arch/arm/mach-exynos4/{usb-phy.c = setup-usb-phy.c} (100%)
diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
index b92c1e5..a45a022 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig
@@ -91,6 +91,11 @@ config EXYNOS4_SETUP_FIMC
help
Common setup code for the camera interfaces.
+config EXYNOS4_SETUP_USB_PHY
+ bool
+ help
+ Common setup code for USB PHY controller
+
# machine support
menu EXYNOS4 Machines
@@ -176,6 +181,7 @@ config MACH_NURI
select EXYNOS4_SETUP_I2C3
select EXYNOS4_SETUP_I2C5
select EXYNOS4_SETUP_SDHCI
+ select EXYNOS4_SETUP_USB_PHY
select SAMSUNG_DEV_PWM
help
Machine support for Samsung Mobile NURI Board.
diff --git a/arch/arm/mach-exynos4/Makefile b/arch/arm/mach-exynos4/Makefile
index a9bb94f..60fe5ec 100644
--- a/arch/arm/mach-exynos4/Makefile
+++ b/arch/arm/mach-exynos4/Makefile
@@ -56,4 +56,4 @@ obj-$(CONFIG_EXYNOS4_SETUP_KEYPAD) += setup-keypad.o
obj-$(CONFIG_EXYNOS4_SETUP_SDHCI)+= setup-sdhci.o
obj-$(CONFIG_EXYNOS4_SETUP_SDHCI_GPIO) += setup-sdhci-gpio.o
-obj-$(CONFIG_USB_SUPPORT)+= usb-phy.o
+obj-$(CONFIG_EXYNOS4_SETUP_USB_PHY) += setup-usb-phy.o
diff --git a/arch/arm/mach-exynos4/usb-phy.c
b/arch/arm/mach-exynos4/setup-usb-phy.c
similarity index 100%
rename from arch/arm/mach-exynos4/usb-phy.c
rename to arch/arm/mach-exynos4/setup-usb-phy.c
N떑꿩�r툤y鉉싕b쾊Ф푤v�^�)頻{.n�+돴쪐{굇ß틏,″㎍썳變}찠꼿쟺�j:+v돣�쳭喩zZ+�+zf＂톒쉱�~넮녬i鎬z� 췿ⅱ�?솳鈺��)刪f
Re: [PATCH V2] ARM: S5P: Fix compilation error for exynos4_defconfig
Hi,
On Friday 03 June 2011 01:20 PM, Joonyoung Shim wrote:
On 2011-06-03 오후 4:04, Tushar Behera wrote:
Added Kconfig entry for setup-usb-phy.c on which EHCI support is
dependent on.
Following the naming convention of other setup files, we have following
renaming.
usb-phy.c == setup-usb-phy.c
Signed-off-by: Tushar Beheratushar.beh...@linaro.org
---
arch/arm/mach-exynos4/Kconfig | 6 ++
arch/arm/mach-exynos4/Makefile | 2 +-
.../mach-exynos4/{usb-phy.c = setup-usb-phy.c} | 0
3 files changed, 7 insertions(+), 1 deletions(-)
rename arch/arm/mach-exynos4/{usb-phy.c = setup-usb-phy.c} (100%)
There is one white space but
Acked-by: Joonyoung Shim jy0922.s...@samsung.com
diff --git a/arch/arm/mach-exynos4/Kconfig
b/arch/arm/mach-exynos4/Kconfig
index b92c1e5..a45a022 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig
@@ -91,6 +91,11 @@ config EXYNOS4_SETUP_FIMC
help
Common setup code for the camera interfaces.
+config EXYNOS4_SETUP_USB_PHY
+ bool
+ help
+ Common setup code for USB PHY controller
White space.
The space was added so that it is formatted in the same way as other
Kconfig entries.
+
# machine support
menu EXYNOS4 Machines
@@ -176,6 +181,7 @@ config MACH_NURI
select EXYNOS4_SETUP_I2C3
select EXYNOS4_SETUP_I2C5
select EXYNOS4_SETUP_SDHCI
+ select EXYNOS4_SETUP_USB_PHY
select SAMSUNG_DEV_PWM
help
Machine support for Samsung Mobile NURI Board.
diff --git a/arch/arm/mach-exynos4/Makefile
b/arch/arm/mach-exynos4/Makefile
index a9bb94f..60fe5ec 100644
--- a/arch/arm/mach-exynos4/Makefile
+++ b/arch/arm/mach-exynos4/Makefile
@@ -56,4 +56,4 @@ obj-$(CONFIG_EXYNOS4_SETUP_KEYPAD) += setup-keypad.o
obj-$(CONFIG_EXYNOS4_SETUP_SDHCI) += setup-sdhci.o
obj-$(CONFIG_EXYNOS4_SETUP_SDHCI_GPIO) += setup-sdhci-gpio.o
-obj-$(CONFIG_USB_SUPPORT) += usb-phy.o
+obj-$(CONFIG_EXYNOS4_SETUP_USB_PHY) += setup-usb-phy.o
diff --git a/arch/arm/mach-exynos4/usb-phy.c
b/arch/arm/mach-exynos4/setup-usb-phy.c
similarity index 100%
rename from arch/arm/mach-exynos4/usb-phy.c
rename to arch/arm/mach-exynos4/setup-usb-phy.c
--
Tushar Behera
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] ARM: S5P: Fix compilation error for exynos4_defconfig
On 2011-06-03 오후 5:44, Tushar Behera wrote:
Hi,
On Friday 03 June 2011 01:20 PM, Joonyoung Shim wrote:
On 2011-06-03 오후 4:04, Tushar Behera wrote:
Added Kconfig entry for setup-usb-phy.c on which EHCI support is
dependent on.
Following the naming convention of other setup files, we have following
renaming.
usb-phy.c == setup-usb-phy.c
Signed-off-by: Tushar Beheratushar.beh...@linaro.org
---
arch/arm/mach-exynos4/Kconfig | 6 ++
arch/arm/mach-exynos4/Makefile | 2 +-
.../mach-exynos4/{usb-phy.c = setup-usb-phy.c} | 0
3 files changed, 7 insertions(+), 1 deletions(-)
rename arch/arm/mach-exynos4/{usb-phy.c = setup-usb-phy.c} (100%)
There is one white space but
Acked-by: Joonyoung Shim jy0922.s...@samsung.com
diff --git a/arch/arm/mach-exynos4/Kconfig
b/arch/arm/mach-exynos4/Kconfig
index b92c1e5..a45a022 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig
@@ -91,6 +91,11 @@ config EXYNOS4_SETUP_FIMC
help
Common setup code for the camera interfaces.
+config EXYNOS4_SETUP_USB_PHY
+ bool
+ help
+ Common setup code for USB PHY controller
White space.
The space was added so that it is formatted in the same way as other
Kconfig entries.
So your patch has 1 error by scripts/checkpatch.pl, it can be removed
using scripts/cleanpatch.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] ARM: S5P: Fix compilation error for exynos4_defconfig
On Friday 03 June 2011 02:28 PM, Joonyoung Shim wrote:
On 2011-06-03 오후 5:44, Tushar Behera wrote:
Hi,
On Friday 03 June 2011 01:20 PM, Joonyoung Shim wrote:
On 2011-06-03 오후 4:04, Tushar Behera wrote:
Added Kconfig entry for setup-usb-phy.c on which EHCI support is
dependent on.
Following the naming convention of other setup files, we have following
renaming.
usb-phy.c == setup-usb-phy.c
Signed-off-by: Tushar Beheratushar.beh...@linaro.org
---
arch/arm/mach-exynos4/Kconfig | 6 ++
arch/arm/mach-exynos4/Makefile | 2 +-
.../mach-exynos4/{usb-phy.c = setup-usb-phy.c} | 0
3 files changed, 7 insertions(+), 1 deletions(-)
rename arch/arm/mach-exynos4/{usb-phy.c = setup-usb-phy.c} (100%)
There is one white space but
Acked-by: Joonyoung Shim jy0922.s...@samsung.com
diff --git a/arch/arm/mach-exynos4/Kconfig
b/arch/arm/mach-exynos4/Kconfig
index b92c1e5..a45a022 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig
@@ -91,6 +91,11 @@ config EXYNOS4_SETUP_FIMC
help
Common setup code for the camera interfaces.
+config EXYNOS4_SETUP_USB_PHY
+ bool
+ help
+ Common setup code for USB PHY controller
White space.
The space was added so that it is formatted in the same way as other
Kconfig entries.
So your patch has 1 error by scripts/checkpatch.pl, it can be removed
using scripts/cleanpatch.
:-( .. I had overseen that error .. thanks for pointing out ...
Kukjin,
If required, I will resubmit again.
--
Tushar Behera
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] ARM: S5P: Fix compilation error for exynos4_defconfig
On 3 June 2011 12:34, Tushar Behera tushar.beh...@linaro.org wrote:
Added Kconfig entry for setup-usb-phy.c on which EHCI support is
dependent on.
Following the naming convention of other setup files, we have following
renaming.
usb-phy.c == setup-usb-phy.c
Signed-off-by: Tushar Behera tushar.beh...@linaro.org
---
arch/arm/mach-exynos4/Kconfig | 6 ++
arch/arm/mach-exynos4/Makefile | 2 +-
.../mach-exynos4/{usb-phy.c = setup-usb-phy.c} | 0
3 files changed, 7 insertions(+), 1 deletions(-)
rename arch/arm/mach-exynos4/{usb-phy.c = setup-usb-phy.c} (100%)
diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
index b92c1e5..a45a022 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig
@@ -91,6 +91,11 @@ config EXYNOS4_SETUP_FIMC
help
Common setup code for the camera interfaces.
+config EXYNOS4_SETUP_USB_PHY
+ bool
+ help
+ Common setup code for USB PHY controller
+
# machine support
menu EXYNOS4 Machines
@@ -176,6 +181,7 @@ config MACH_NURI
select EXYNOS4_SETUP_I2C3
select EXYNOS4_SETUP_I2C5
select EXYNOS4_SETUP_SDHCI
+ select EXYNOS4_SETUP_USB_PHY
select SAMSUNG_DEV_PWM
help
Machine support for Samsung Mobile NURI Board.
diff --git a/arch/arm/mach-exynos4/Makefile b/arch/arm/mach-exynos4/Makefile
index a9bb94f..60fe5ec 100644
--- a/arch/arm/mach-exynos4/Makefile
+++ b/arch/arm/mach-exynos4/Makefile
@@ -56,4 +56,4 @@ obj-$(CONFIG_EXYNOS4_SETUP_KEYPAD) += setup-keypad.o
obj-$(CONFIG_EXYNOS4_SETUP_SDHCI) += setup-sdhci.o
obj-$(CONFIG_EXYNOS4_SETUP_SDHCI_GPIO) += setup-sdhci-gpio.o
-obj-$(CONFIG_USB_SUPPORT) += usb-phy.o
+obj-$(CONFIG_EXYNOS4_SETUP_USB_PHY) += setup-usb-phy.o
Since plat-s5p/dev-ehci.c is the only consumer of setup-usb-phy.c,
could setup-usb-phy.o be made dependent on the S5P_DEV_USB_EHCI config
option? Any particular reason to create a new EXYNOS4_SETUP_USB_PHY
config option in this case? Will there be a case where usb phy
configuration code would be used irrespective of dev-ehci being used?
Thanks,
Thomas.
diff --git a/arch/arm/mach-exynos4/usb-phy.c
b/arch/arm/mach-exynos4/setup-usb-phy.c
similarity index 100%
rename from arch/arm/mach-exynos4/usb-phy.c
rename to arch/arm/mach-exynos4/setup-usb-phy.c
--
1.7.1
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc
in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH V2] ARM: S5P: Fix compilation error for exynos4_defconfig
Hello,
On Friday, June 03, 2011 1:52 PM Thomas Abraham wrote:
On 3 June 2011 12:34, Tushar Behera tushar.beh...@linaro.org wrote:
Added Kconfig entry for setup-usb-phy.c on which EHCI support is
dependent on.
Following the naming convention of other setup files, we have following
renaming.
usb-phy.c == setup-usb-phy.c
Signed-off-by: Tushar Behera tushar.beh...@linaro.org
---
arch/arm/mach-exynos4/Kconfig | 6 ++
arch/arm/mach-exynos4/Makefile | 2 +-
.../mach-exynos4/{usb-phy.c = setup-usb-phy.c} | 0
3 files changed, 7 insertions(+), 1 deletions(-)
rename arch/arm/mach-exynos4/{usb-phy.c = setup-usb-phy.c} (100%)
diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-
exynos4/Kconfig
index b92c1e5..a45a022 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig
@@ -91,6 +91,11 @@ config EXYNOS4_SETUP_FIMC
help
Common setup code for the camera interfaces.
+config EXYNOS4_SETUP_USB_PHY
+ bool
+ help
+ Common setup code for USB PHY controller
+
# machine support
menu EXYNOS4 Machines
@@ -176,6 +181,7 @@ config MACH_NURI
select EXYNOS4_SETUP_I2C3
select EXYNOS4_SETUP_I2C5
select EXYNOS4_SETUP_SDHCI
+ select EXYNOS4_SETUP_USB_PHY
select SAMSUNG_DEV_PWM
help
Machine support for Samsung Mobile NURI Board.
diff --git a/arch/arm/mach-exynos4/Makefile b/arch/arm/mach-
exynos4/Makefile
index a9bb94f..60fe5ec 100644
--- a/arch/arm/mach-exynos4/Makefile
+++ b/arch/arm/mach-exynos4/Makefile
@@ -56,4 +56,4 @@ obj-$(CONFIG_EXYNOS4_SETUP_KEYPAD) += setup-keypad.o
obj-$(CONFIG_EXYNOS4_SETUP_SDHCI) += setup-sdhci.o
obj-$(CONFIG_EXYNOS4_SETUP_SDHCI_GPIO) += setup-sdhci-gpio.o
-obj-$(CONFIG_USB_SUPPORT) += usb-phy.o
+obj-$(CONFIG_EXYNOS4_SETUP_USB_PHY) += setup-usb-phy.o
Since plat-s5p/dev-ehci.c is the only consumer of setup-usb-phy.c,
could setup-usb-phy.o be made dependent on the S5P_DEV_USB_EHCI config
option? Any particular reason to create a new EXYNOS4_SETUP_USB_PHY
config option in this case? Will there be a case where usb phy
configuration code would be used irrespective of dev-ehci being used?
I suggested this solution to keep the consistence in the style. The other reason
is the fact that USB PHY control functions should be also added to usb hs otg
driver so these function will be used by 2 different devices.
Best regards
--
Marek Szyprowski
Samsung Poland RD Center
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2] ARM: S5P: Fix compilation error for exynos4_defconfig
On 06/03/11 00:04, Tushar Behera wrote:
Added Kconfig entry for setup-usb-phy.c on which EHCI support is
dependent on.
Following the naming convention of other setup files, we have following
renaming.
usb-phy.c == setup-usb-phy.c
Signed-off-by: Tushar Beheratushar.beh...@linaro.org
---
arch/arm/mach-exynos4/Kconfig |6 ++
arch/arm/mach-exynos4/Makefile |2 +-
.../mach-exynos4/{usb-phy.c = setup-usb-phy.c}|0
3 files changed, 7 insertions(+), 1 deletions(-)
rename arch/arm/mach-exynos4/{usb-phy.c = setup-usb-phy.c} (100%)
diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
index b92c1e5..a45a022 100644
--- a/arch/arm/mach-exynos4/Kconfig
+++ b/arch/arm/mach-exynos4/Kconfig
@@ -91,6 +91,11 @@ config EXYNOS4_SETUP_FIMC
help
Common setup code for the camera interfaces.
+config EXYNOS4_SETUP_USB_PHY
+ bool
+ help
+ Common setup code for USB PHY controller
+
# machine support
menu EXYNOS4 Machines
@@ -176,6 +181,7 @@ config MACH_NURI
select EXYNOS4_SETUP_I2C3
select EXYNOS4_SETUP_I2C5
select EXYNOS4_SETUP_SDHCI
+ select EXYNOS4_SETUP_USB_PHY
select SAMSUNG_DEV_PWM
help
Machine support for Samsung Mobile NURI Board.
diff --git a/arch/arm/mach-exynos4/Makefile b/arch/arm/mach-exynos4/Makefile
index a9bb94f..60fe5ec 100644
--- a/arch/arm/mach-exynos4/Makefile
+++ b/arch/arm/mach-exynos4/Makefile
@@ -56,4 +56,4 @@ obj-$(CONFIG_EXYNOS4_SETUP_KEYPAD)+= setup-keypad.o
obj-$(CONFIG_EXYNOS4_SETUP_SDHCI) += setup-sdhci.o
obj-$(CONFIG_EXYNOS4_SETUP_SDHCI_GPIO)+= setup-sdhci-gpio.o
-obj-$(CONFIG_USB_SUPPORT) += usb-phy.o
+obj-$(CONFIG_EXYNOS4_SETUP_USB_PHY)+= setup-usb-phy.o
diff --git a/arch/arm/mach-exynos4/usb-phy.c
b/arch/arm/mach-exynos4/setup-usb-phy.c
similarity index 100%
rename from arch/arm/mach-exynos4/usb-phy.c
rename to arch/arm/mach-exynos4/setup-usb-phy.c
I think, basically, the setup-usbphy.c would be in plat-s5p/ because
s5p_usb_phy_{init,exit} is called from plat-s5p/dev-echi.c and need to
separate exynos(mach-) and common s5p(plat-) stuff so that can be used
from other s5p usb to control usb phy.
Since it is not used for others so will apply this to fix build error.
However, we need to sort this out later.
Tushar, you don't need to re-submit this for removing white space :)
But as you know, please make sure that your patch has no problem with
checkpatch.pl before submitting.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim kgene@samsung.com, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Can't compile with exynos4_defconfig
On 06/02/11 19:25, Sangbeom Kim wrote: Hi, Hi Sangbeom Kim, By default exynos4_defconfig, 3.0-rc1 can't compile the code. It seem to have dependency on usb configuration. Error message: arch/arm/plat-s5p/built-in.o: In function `s5p_ehci_set_platdata': /home/cornus/tmp/linux-3.0-rc1/arch/arm/plat-s5p/dev-ehci.c:54: undefined reference to `s5p_usb_phy_init' /home/cornus/tmp/linux-3.0-rc1/arch/arm/plat-s5p/dev-ehci.c:54: undefined reference to `s5p_usb_phy_init' /home/cornus/tmp/linux-3.0-rc1/arch/arm/plat-s5p/dev-ehci.c:56: undefined reference to `s5p_usb_phy_exit' /home/cornus/tmp/linux-3.0-rc1/arch/arm/plat-s5p/dev-ehci.c:56: undefined reference to `s5p_usb_phy_exit' make: *** [.tmp_vmlinux1] Error 1 Thanks for your pointing out. As a note, submitted Thushar's patch(ARM: S5P: Fix compilation error for exynos4_defconfig) can solve this build error. Could you please test kernel 'Linux 3.0-rc1' on SMDKV310 or SMDKC210 with exynos4_defconfig? If any problems, please let me know. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 0/3] Fixes for breakage resulting from syscore_ops patch on s3c24xx
On 06/02/11 03:54, Heiko Stübner wrote: The syscore_ops patch from Rafael J. Wysocki introduced some small glitches for the S3C24XX cpus resulting in compile errors. Changes since v1: add missing Signed-off-by lines Changes since v2: fix mangled tabs Heiko Stuebner (3): Fix missing struct for s3c2410_dma_chan in s3c2410_dma_suspend_chan Move s3c24xx_irq_syscore_ops to plat-s3c24xx/irq.c remove the now empty mach-s3c2410/irq.c arch/arm/mach-s3c2410/Makefile |1 - arch/arm/mach-s3c2410/irq.c| 34 -- arch/arm/plat-s3c24xx/dma.c|2 +- arch/arm/plat-s3c24xx/irq.c|6 ++ 4 files changed, 7 insertions(+), 36 deletions(-) delete mode 100644 arch/arm/mach-s3c2410/irq.c Looks OK, will apply. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
