Re: [PATCH v5 00/13] scsi: core: fix uninit-value access of variable sshdr
On 18/10/2019 15:43, Martin K. Petersen wrote:
[...]
> Johannes: Whatever happened to your efforts at cleaning all this up? Do
> you have a patch series or a working tree we could use as starting
> point?
I'll have to look. I think it's still floating around in some git tree.
Let me search for it.
Johannes
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 Nürnberg
Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v4 02/22] sg: remove typedefs, type+formatting cleanup
Highly appreciated, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE Software Solutions Germany GmbH Maxfeldstr. 5 90409 Nürnberg Germany (HRB 247165, AG München) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6
On Wed, Jul 03, 2019 at 12:36:30AM +0200, Andrea Vai wrote: > On 02/07/19 13:51:17, Johannes Thumshirn wrote: > > On Tue, Jul 02, 2019 at 12:46:45PM +0200, Andrea Vai wrote: > > > Hi, > > > I have a problem writing data to a USB pendrive, and it seems > > > kernel-related. With the help of Greg an Alan (thanks) and some > > > bisect, I found out the offending commit being > > > > > > commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6 > > > > > > [...] > > > > Hi, > > > > Can you please check what IO scheduler you have set for your USB pendrive? > > > > i.e. with: > > cat /sys/block/$DISK/queue/scheduler > > > > # cat /sys/block/sdf/queue/scheduler > [mq-deadline] none One thing you can try as well is building a kernel with CONFIG_IOSCHED_BFQ and use it. Deadline is probably not the best choice for a slow drive. Byte, Johannes -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6
On Tue, Jul 02, 2019 at 12:46:45PM +0200, Andrea Vai wrote: > Hi, > I have a problem writing data to a USB pendrive, and it seems > kernel-related. With the help of Greg an Alan (thanks) and some > bisect, I found out the offending commit being > > commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6 > Author: Jens Axboe > Date: Thu Nov 1 16:36:27 2018 -0600 > > scsi: kill off the legacy IO path > > This removes the legacy (non-mq) IO path for SCSI. > > So, here I am to notify you about the problem and ask you if I can > help in any way to work it out and fix it. > > The problem is that if I copy a file from the internal SATA HD to the > pendrive, it takes ~10 times to complete (in respect of the time > needed with the patch reverted). > > The test script, which I use to detect if the problem triggers or not, > is: > > #!/bin/bash > logfile=... > uname -a | tee -a $logfile > echo -n "Begin: " | tee -a $logfile > date | tee -a $logfile > touch inizio > SECONDS=0 > mount UUID="05141239-4ea5-494d-aa91-acd67db89ce5" /mnt/pendrive > cp /NoBackup/buttare/testfile /mnt/pendrive > umount /mnt/pendrive > tempo=$SECONDS > touch fine > echo -n "...end: " | tee -a $logfile > date | tee -a $logfile > echo "It took $tempo seconds!" | tee -a $logfile > > If I run the test with a 512MB file it takes >10min vs. half a minute. > > The problem is still present in last tested git (cloned today in the > morning). > > You can see the previous discussion that lead to these results at > > https://marc.info/?t=15592223071&r=1&w=2 Hi, Can you please check what IO scheduler you have set for your USB pendrive? i.e. with: cat /sys/block/$DISK/queue/scheduler Thanks, Johannes -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [scsi:misc 301/301] drivers/scsi/fdomain.c:442:12: sparse: sparse: context imbalance in 'fdomain_host_reset' - wrong count at exit
On Tue, Apr 30, 2019 at 04:02:15PM +0800, kbuild test robot wrote:
[...]
> >> drivers/scsi/fdomain.c:442:12: sparse: sparse: context imbalance in
> >> 'fdomain_host_reset' - wrong count at exit
>
> vim +/fdomain_host_reset +442 drivers/scsi/fdomain.c
>
> 92408047 Ondrej Zary 2019-04-29 441
> 92408047 Ondrej Zary 2019-04-29 @442 static int fdomain_host_reset(struct
> scsi_cmnd *cmd)
> 92408047 Ondrej Zary 2019-04-29 443 {
> 92408047 Ondrej Zary 2019-04-29 444 struct Scsi_Host *sh =
> cmd->device->host;
> 92408047 Ondrej Zary 2019-04-29 445 struct fdomain *fd =
> shost_priv(sh);
> 92408047 Ondrej Zary 2019-04-29 446 unsigned long flags;
> 92408047 Ondrej Zary 2019-04-29 447
> 92408047 Ondrej Zary 2019-04-29 448
> spin_lock_irqsave(sh->host_lock, flags);
> 92408047 Ondrej Zary 2019-04-29 449 fdomain_reset(fd->base);
> 92408047 Ondrej Zary 2019-04-29 450
> spin_lock_irqsave(sh->host_lock, flags);
That should be a spin_unlock_irqrestore() here ~^
Otherwise this would end badly.
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] Revert "scsi: fcoe: clear FC_RP_STARTED flags when receiving a LOGO"
This is missing you Signed-off-by -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH V5 2/9] blk-mq: move cancel of requeue_work into blk_mq_release
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH V5 1/9] blk-mq: grab .q_usage_counter when queuing request from plug code path
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 00/10] Improve qla2xxx coding style
On 11/04/2019 23:53, Bart Van Assche wrote: > Hi Martin, > > While preparing a few bug fixes for the qla2xxx driver I noticed several > stylistic issues in that driver. I'm sending the patches with stylistic > improvements ahead to avoid having to post too many patches at once (another > 20 patches will follow at a later time). Please consider these patches for > kernel v5.2. For the whole series, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 01/11] Declare wwn_to_u64() argument const
Fair enough, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [RESEND] [PATCH] Hold back_lock when calling iscsi_complete_task
On 22/02/2019 17:29, Lee Duncan wrote: > From: Lee Duncan > > If there is an error queueing an iscsi command in > iscsi_queuecommand(), for example if the transport fails > to take the command in sessuin->tt->xmit_task(), then > the error path can call iscsi_complete_task() without > first aquiring the back_lock as required. This can > lead to things like ITT pool can get corrupt, resulting > in duplicate ITTs being sent out. > > The solution is to hold the back_lock around > iscsi_complete_task() calls, and to add a little commenting > to help others understand when back_lock must be held. You're missing a S-o-b here. Byte, Johannes -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [LSF/MM TOPIC] : blktests: status, an expansion plan for the storage stack test framework
On 06/02/2019 06:21, Chaitanya Kulkarni wrote: > Hi, > > Since discussion of the storage stack and device driver at the LSFMM 2017 > (https://lwn.net/Articles/717699/), Omar Sandoval introduced a new framework > "blktests" dedicated for Linux Kernel Block layer testing. > (https://lwn.net/Articles/722785/, https://github.com/osandov/blktests). > > As Linux Kernel Block layer is central to the various file systems and > underlying > low-level device drivers it is important to have a centralized testing > framework and > make sure it grows with the latest block layer changed which are being added > based > on the different device features from different device types > (e.g. NVMe devices with Zoned Namespace support). > > Since then blktests has grown and became go-to framework where we have > integrated > different stand-alone test suites like SRP-tests, NVMFTESTS, NVMe Multipath > tests, > zone block device tests, into one central framework, which has made an > overall block layer > testing and development much easier than having to configure and execute > different > test cases for each kernel release for different subsystems such as FS, NVMe, > Zone Block devices, etc). > > Here is the list of the existing test categories:- > > ├── block 28 Tests > ├── loop 07 Tests > ├── meta 12 Tests > ├── nbd 02 Tests > ├── nvme 28 Tests > ├── nvmeof-mp 12 Tests > ├── scsi 06 Tests > ├── srp 13 Tests > └── zbd 05 Tests > >9 Categories ~110 Tests > > This project has gathered much attention and storage stack community is > actively > participating and adding new test cases with different categories to the > framework. > > For storage track, we would like to propose a session dedicated to blktests. > It is a great > opportunity for the storage developers to gather and have a discussion about:- > > 1. Current status of the blktests framework. > 2. Any new/missing features that we want to add in the blktests. > 3. Any new kernel features that could be used to make testing easier? > E.g. Implementing new features in the null_blk.c in order to have device > independent complete test coverage. (e.g. adding discard command for null_blk > or any > other specific REQ_OP). Discussion about having any new tracepoint events in > the block layer. > 4. Any new test cases/categories which are lacking in the blktests framework. One thing I'd love to see is more hardware/driver specific tests. I'm sure Broadcom, Marvell, Huawei and all the others out there do have test suites for their HBA drivers but not a single one of these tests is publicly available. We're also lacking tests for things like ioprio, persistent reservation, bcache and so on. Adding support for collecting gcov information after running a test case would also be awesome (this is missing in xfstests as well). So I think a session on blktests can help us get the gap closed. Byte, Johannes -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
[PATCH] MAINTAINERS: Move FCoE to Hannes Reinecke
I'll be moving on to different things in the storage stack and Hannes agreed to take over FCoE. Cc: Hannes Reinecke Signed-off-by: Johannes Thumshirn --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 9f64f8d3740e..49b829794699 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5855,7 +5855,7 @@ S:Maintained F: drivers/media/tuners/fc2580* FCOE SUBSYSTEM (libfc, libfcoe, fcoe) -M: Johannes Thumshirn +M: Hannes Reinecke L: linux-scsi@vger.kernel.org W: www.Open-FCoE.org S: Supported -- 2.16.4
Re: [PATCH V2 1/3] megaraid_sas: Rework code to get PD and LD list
On 24/01/2019 11:19, Shivasharan S wrote: [...] > +/* > + * megasas_get_device_list - Get the PD and LD device list from FW. > + * @instance:Adapter soft state > + * > + * @return: Success or failure > + * > + * Issue DCMDs to Firmware to update the internal device list in driver. > + * Based on the FW support, driver sends the HOST_DEVICE_LIST or combination > + * of PD_LIST/LD_LIST_QUERY DCMDs to get the device list. > + */ > +static > +int megasas_get_device_list(struct megasas_instance *instance) You have to start your kerneldoc comments with '/**' (i.e. one asterisk is missing on your side). -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] libsas: Remove scsi_to_u32()
Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 2/7] scsi: csiostor: no need to check return value of debugfs_create functions
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] fcoe: make use of fip_mode enum complete
On 12/01/2019 06:34, Lukas Bulwahn wrote:
> commit 1917d42d14b7 ("fcoe: use enum for fip_mode") introduces a separate
> enum for the fip_mode that shall be used during initialisation handling
> until it is passed to fcoe_ctrl_link_up to set the initial fip_state.
> That change was incomplete and gcc quietly converted in various places
> between the fip_mode and the fip_state enum values with implicit enum
> conversions, which fortunately cannot cause any issues in the actual
> code's execution.
>
> clang however warns about these implicit enum conversions in the scsi
> drivers. This commit consolidates the use of the two enums, guided by
> clang's enum-conversion warnings.
>
> This commit now completes the use of the fip_mode:
> It expects and uses fip_mode in {bnx2fc,fcoe}_interface_create and
> fcoe_ctlr_init, and it explicitly converts from fip_mode to fip_state
> only at the single point in fcoe_ctlr_link_up.
>
> To eliminate that adding or removing values from fip_mode or fip_state enum
> break the right mapping of values, all fip_mode values are assigned to
> their fip_state counterparts.
Hi Lukas,
I have to admit, don't like this patch too much.
While it looks technically correct (I haven't tested it yet) it, it
mixes fip_state and fip_mode even more, which I think is bad for the
readability of the code flow.
Maybe you could add a conversion function for it?
Something like (untested):
static inline enum fip_mode fip_state_to_mode(enum fip_state state)
{
switch (state) {
case FIP_ST_AUTO:
return FIP_MODE_AUTO;
case FIP_ST_NON_FIP:
return FIP_MODE_NON_FIP;
case FIP_ST_ENABLED:
return FIP_MODE_FABRIC;
case FIP_ST_VMMP_START:
return FIP_MODE_VN2VN;
default:
WARN(1, "Invalid FIP state");
}
return FIP_ST_AUTO;
}
Byte,
Johannes
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH -next] scsi: fcoe: remove set but not used variable 'port'
I somehow have a deja vu feeling I have already acked it, but anyways: Acked-by: Johannes Thumshirn
Re: [PATCH 1/6] scsi: hpsa: Add function to check if device is a disk or a zoned device
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 1/2] scsi: aacraid: change wait_sem to a completion
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 2/2] scsi: aacraid: change event_wait to a completion
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity
On 07/12/2018 11:07, John Garry wrote: > On 06/12/2018 16:20, Johannes Thumshirn wrote: >> On 06/12/2018 16:37, John Garry wrote: >>> which is important. Let me know if you disagree and I can change it. >> >> Sure, it's your driver. It was just because the patch is even titled >> "Relocate some code to reduce complexity", so I thought of reducing the >> complexity for readers even further (like you don't need the line wrap >> at 80 chars, and so on). >> >> Byte, >> Johannes >> > > I would rather not change if you don't mind. When we say "reduce > complexity", we are talking about moving the DMA mapping code from the > task prep function, as, when we add the DIX-related DMA mapping code, > leaving all the DMA mapping code in the task prep function would make it > a monster. Sure -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 03/10] gdth: remove gdth_{alloc,free}_ioctl
On 06/12/2018 17:50, Johannes Thumshirn wrote: > Why not calling dma_alloc_coherent() directly instead of using the > pci_alloc_consistent() wrapper? Ah should've read the whole series -- Johannes ThumshirnSUSE Labs Filesystems jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 03/10] gdth: remove gdth_{alloc,free}_ioctl
On 06/12/2018 16:57, Christoph Hellwig wrote:
> Out of the three callers once insists on the scratch buffer, and the
> others are fine with a new allocation. Switch those two to juse use
> pci_alloc_consistent directly, and open code the scratch buffer
> allocation in the remaining one. This avoids a case where we might
> be doing a memory allocation under a spinlock with irqs disabled.
Why not calling dma_alloc_coherent() directly instead of using the
pci_alloc_consistent() wrapper?
Johannes
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity
On 06/12/2018 16:37, John Garry wrote:
> which is important. Let me know if you disagree and I can change it.
Sure, it's your driver. It was just because the patch is even titled
"Relocate some code to reduce complexity", so I thought of reducing the
complexity for readers even further (like you don't need the line wrap
at 80 chars, and so on).
Byte,
Johannes
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity
On 06/12/2018 14:34, John Garry wrote:
[...]
> +static void hisi_sas_dma_unmap(struct hisi_hba *hisi_hba,
> +struct sas_task *task, int n_elem,
> +int n_elem_req, int n_elem_resp)
> +{
> + struct device *dev = hisi_hba->dev;
> +
> + if (!sas_protocol_ata(task->task_proto)) {
> + if (task->num_scatter) {
> + if (n_elem)
> + dma_unmap_sg(dev, task->scatter,
> + task->num_scatter,
> + task->data_dir);
> + } else if (task->task_proto & SAS_PROTOCOL_SMP) {
> + if (n_elem_req)
> + dma_unmap_sg(dev, &task->smp_task.smp_req,
> + 1, DMA_TO_DEVICE);
> + if (n_elem_resp)
> + dma_unmap_sg(dev, &task->smp_task.smp_resp,
> + 1, DMA_FROM_DEVICE);
> + }
> + }
if (sas_protocol_ata(task->task_proto))
return;
Would save you a level of indentation and make the above more readable.
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 21/41] scsi: libfc: fc_rport: Mark expected switch fall-through
Acked-by: Johannes Thumshirn
Re: [PATCH -next] scsi: libfc: Remove set but not used variable 'disc'
Looks good, Reviewed-by: Johannes Thumshirn
Re: [PATCH] drivers/scsi/fnic/fnic_trace.c: Use vzalloc
On 13/11/2018 17:22, Sabyasachi Gupta wrote: > On Tue, Nov 13, 2018 at 9:46 PM Johannes Thumshirn wrote: >> >> On 13/11/2018 17:11, James Bottomley wrote: >>> This is incorrect advice: there's no need to cast it to other *pointer* >>> types, but if you cast it to a non-pointer type (which this is doing) >>> the compiler will complain if there is no explicit cast. > shall I leave the typecast as it is? Yes, sorry for not looking at it deeply enough. -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] drivers/scsi/fnic/fnic_trace.c: Use vzalloc
On 13/11/2018 17:11, James Bottomley wrote:
> This is incorrect advice: there's no need to cast it to other *pointer*
> types, but if you cast it to a non-pointer type (which this is doing)
> the compiler will complain if there is no explicit cast.
Right, sorry for that and thanks for spotting it James.
Byte,
Johannes
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] drivers/scsi/fnic/fnic_trace.c: Use vzalloc
On 13/11/2018 16:44, John Garry wrote: > On 13/11/2018 15:08, Sabyasachi Gupta wrote: >> Replaced vmalloc + memset with vzalloc >> >> Signed-off-by: Sabyasachi Gupta >> --- >> drivers/scsi/fnic/fnic_trace.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/scsi/fnic/fnic_trace.c >> b/drivers/scsi/fnic/fnic_trace.c >> index 8271785..129ab27 100644 >> --- a/drivers/scsi/fnic/fnic_trace.c >> +++ b/drivers/scsi/fnic/fnic_trace.c >> @@ -468,14 +468,14 @@ int fnic_trace_buf_init(void) >> fnic_max_trace_entries = (trace_max_pages * PAGE_SIZE)/ >> FNIC_ENTRY_SIZE_BYTES; >> >> - fnic_trace_buf_p = (unsigned long)vmalloc((trace_max_pages * >> PAGE_SIZE)); >> + fnic_trace_buf_p = (unsigned long)vzalloc((trace_max_pages * >> + PAGE_SIZE)); > > If you remove the extra brackets in vzalloc() argument then you may not > spill onto the next line. And remove the unnecessary cast. vzalloc() (just like vmalloc()) returns a void*, so no reason to cast it. -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 7/7] block: remove the BLKPREP_* values.
So long and thanks for all the fish, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 6/7] scsi: return blk_status_t from device handler ->prep_fn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 5/7] scsi: return blk_status_t from scsi_init_io and ->init_command
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 4/7] scsi: clean up error handling in scsi_init_io
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 3/7] scsi: push blk_status_t up into scsi_setup_{fs,scsi}_cmnd
Look good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] scsi: lpfc: fix remoteport access
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 16/28] blk-cgroup: remove legacy queue bypassing
On 29/10/18 15:23, Jens Axboe wrote: > On 10/29/18 5:00 AM, Johannes Thumshirn wrote: >> Hi Jens, >> >> On 25/10/18 23:10, Jens Axboe wrote: >> [...] >>> @@ -1487,8 +1485,6 @@ int blkcg_activate_policy(struct request_queue *q, >>> out_bypass_end: >>> if (q->mq_ops) >>> blk_mq_unfreeze_queue(q); >>> - else >>> - blk_queue_bypass_end(q); >> >>> >>> >> >> Now that we only have mq, do we still need all these checks for q->mq_ops? > > We need it for the cases where we can be passing in a stacked driver > or an mq driver, or for cases where we explicitly register mq attributes, > and that sort of thing. > Ah ok. Guess we'll have to live with it then. Johannes -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 16/28] blk-cgroup: remove legacy queue bypassing
Hi Jens, On 25/10/18 23:10, Jens Axboe wrote: [...] > @@ -1487,8 +1485,6 @@ int blkcg_activate_policy(struct request_queue *q, > out_bypass_end: > if (q->mq_ops) > blk_mq_unfreeze_queue(q); > - else > - blk_queue_bypass_end(q); > > Now that we only have mq, do we still need all these checks for q->mq_ops? -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 12/28] bsg: provide bsg_remove_queue() helper
On 25/10/18 23:10, Jens Axboe wrote:
> All drivers do unregister + cleanup, provide a helper for that.
>
> Cc: Johannes Thumshirn
> Cc: Benjamin Block
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Jens Axboe
> ---
> block/bsg-lib.c | 7 +++
> drivers/scsi/scsi_transport_fc.c| 6 ++
> drivers/scsi/scsi_transport_iscsi.c | 7 +++
> drivers/scsi/scsi_transport_sas.c | 6 ++
> include/linux/bsg-lib.h | 1 +
> 5 files changed, 15 insertions(+), 12 deletions(-)
>
> diff --git a/block/bsg-lib.c b/block/bsg-lib.c
> index 1da011ec04e6..267f965af77a 100644
> --- a/block/bsg-lib.c
> +++ b/block/bsg-lib.c
> @@ -296,6 +296,13 @@ static void bsg_exit_rq(struct request_queue *q, struct
> request *req)
> kfree(job->reply);
> }
>
> +void bsg_remove_queue(struct request_queue *q)
> +{
> + bsg_unregister_queue(q);
> + blk_cleanup_queue(q);
> +}
> +EXPORT_SYMBOL_GPL(bsg_remove_queue);
> +
> /**
> * bsg_setup_queue - Create and add the bsg hooks so we can receive requests
> * @dev: device to attach bsg device to
> diff --git a/drivers/scsi/scsi_transport_fc.c
> b/drivers/scsi/scsi_transport_fc.c
> index 98aaffb4c715..4d64956bb5d3 100644
> --- a/drivers/scsi/scsi_transport_fc.c
> +++ b/drivers/scsi/scsi_transport_fc.c
> @@ -3851,10 +3851,8 @@ fc_bsg_rportadd(struct Scsi_Host *shost, struct
> fc_rport *rport)
> static void
> fc_bsg_remove(struct request_queue *q)
> {
> - if (q) {
> - bsg_unregister_queue(q);
> - blk_cleanup_queue(q);
> - }
> + if (q)
> + bsg_remove_queue(q);
> }
Not sure if I'm too late to the game, but as all callers do a
"if (q)" check, can't we just move it into bsg_remove_queue()?
Otherwise:
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 3/8] sg: split header, expand and correct descriptions
On 19/10/18 08:24, Douglas Gilbert wrote: > +/* Alternate style type names, "..._t" variants preferred */ > +typedef struct sg_io_hdr Sg_io_hdr; > +typedef struct sg_io_vec Sg_io_vec; > +typedef struct sg_scsi_id Sg_scsi_id; > +typedef struct sg_req_info Sg_req_info; There are no _t variants for the above, or am I missing something? -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 4/8] sg: expand request states
Looks good (but the ifdefs are creepy), Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 2/8] sg: introduce sg_log macro
On 19/10/18 08:24, Douglas Gilbert wrote:
[..]
> +/*
> + * Kernel needs to be built with CONFIG_SCSI_LOGGING to see log messages.
> + * 'depth' is a number between 1 (most severe) and 7 (most noisy, most
> + * information). All messages are logged as informational (KERN_INFO). In
> + * the unexpected situation where sdp is NULL the macro reverts to a pr_info
> + * and ignores CONFIG_SCSI_LOGGING and always prints to the log.
> + */
> +#define SG_LOG(depth, sdp, fmt, a...)\
> + do {\
> + if (IS_ERR_OR_NULL(sdp)) { \
> + pr_info("sg: sdp=NULL_or_ERR, " fmt, ##a); \
> + } else {\
> + SCSI_LOG_TIMEOUT(depth, sdev_prefix_printk( \
> + KERN_INFO, (sdp)->device, \
> + (sdp)->disk->disk_name, fmt, \
> + ##a)); \
> + } \
> + } while (0)
Hi Doug,
have you considered using the kernel's dynamic debug infrastructure instead?
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 1/8] sg: types and naming cleanup
On 19/10/18 08:24, Douglas Gilbert wrote: > Remove typedefs and use better type names like bool and u8 where > appropriate. Rename some variables and functions for clarity. > Adjust formatting (e.g. function definitions) to be more > consistent across the driver. Thanks a lot Doug, this is highly appreciated. I have one minor Nit if you need to resend the series, please remove the casts form void* (mostly filp->private_data). Otherwise: Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH -next] advansys: remove set but not used variable 'srb_tag' in adv_isr_callback
On 17/10/18 15:00, Matthew Wilcox wrote:
> On Wed, Oct 17, 2018 at 02:49:50PM +0200, Johannes Thumshirn wrote:
>> On 17/10/18 14:34, YueHaibing wrote:
>>> - srb_tag = le32_to_cpu(scsiqp->srb_tag);
>>> scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag);
>>
>> Shouldn't this be:
>> scp = scsi_host_find_tag(boardp->shost,
>> le32_to_cpu(scsiqp->srb_tag));
>
> I don't think so. Look at how scsiqp->srb_tag is set:
>
> adv_build_req(struct asc_board *boardp, struct scsi_cmnd *scp,
> ADV_SCSI_REQ_Q **adv_scsiqpp)
> {
> + u32 srb_tag = scp->request->tag;
> ...
> + scsiqp->srb_tag = srb_tag;
>
> If we're not converting it to le32 on the way in, we probably don't want
> to convert it back on the way out.
Yeah right, didn't check the submission path. It was just the removed
srb_tag = le32_to_cpu(scsiqp->srb_tag);
that triggered here.
> Please don't make me power up my PA-RISC machine with an Advansys card
> in it, just to find out ...
Now that your saying it...
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH -next] advansys: remove set but not used variable 'srb_tag' in adv_isr_callback
On 17/10/18 14:34, YueHaibing wrote:
> drivers/scsi/advansys.c: In function 'adv_isr_callback':
> drivers/scsi/advansys.c:5952:6: warning:
> variable 'srb_tag' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in
> commit 9c17c62aedb0 ("advansys: use shared host tag map for command lookup")
>
> Signed-off-by: YueHaibing
> ---
> drivers/scsi/advansys.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
> index 44c9619..223ef6f 100644
> --- a/drivers/scsi/advansys.c
> +++ b/drivers/scsi/advansys.c
> @@ -5949,7 +5949,6 @@ static void adv_async_callback(ADV_DVC_VAR
> *adv_dvc_varp, uchar code)
> static void adv_isr_callback(ADV_DVC_VAR *adv_dvc_varp, ADV_SCSI_REQ_Q
> *scsiqp)
> {
> struct asc_board *boardp = adv_dvc_varp->drv_ptr;
> - u32 srb_tag;
> adv_req_t *reqp;
> adv_sgblk_t *sgblkp;
> struct scsi_cmnd *scp;
> @@ -5965,7 +5964,6 @@ static void adv_isr_callback(ADV_DVC_VAR *adv_dvc_varp,
> ADV_SCSI_REQ_Q *scsiqp)
>* completed. The adv_req_t structure actually contains the
>* completed ADV_SCSI_REQ_Q structure.
>*/
> - srb_tag = le32_to_cpu(scsiqp->srb_tag);
> scp = scsi_host_find_tag(boardp->shost, scsiqp->srb_tag);
Shouldn't this be:
scp = scsi_host_find_tag(boardp->shost,
le32_to_cpu(scsiqp->srb_tag));
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 28/28] mesh: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 27/28] ips: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 26/28] smartpqi: fully convert to the generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 25/28] vmw_pscsi: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 24/28] snic: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 23/28] qla4xxx: fully convert to the generic DMA API
On Thu, Oct 11, 2018 at 08:49:58PM +0200, Christoph Hellwig wrote:
> @@ -9026,19 +9026,13 @@ static void qla4xxx_remove_adapter(struct pci_dev
> *pdev)
> */
> static void qla4xxx_config_dma_addressing(struct scsi_qla_host *ha)
> {
> - int retval;
> -
Can you zap that:
At exit, the @ha's flags.enable_64bit_addressing set to indicated
supported addressing method.
Comment in the function description as well? It wasn't even correct
with the initial submission of qla4xxx (according to git blame.
Otherwise,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 22/28] qla2xxx: fully convert to the generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 21/28] qla1280: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 20/28] qedi: fully convert to the generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 19/28] qedf: fully convert to the generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 17/28] nsp32: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 18/28] pm8001: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 16/28] mvsas: fully convert to the generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 15/28] mvumi: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 14/28] mpt3sas: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 13/28] megaraid_sas: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 13/28] megaraid_sas: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 12/28] megaraid_mbox: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 10/28] fnic: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 11/28] hpsa: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 09/28] csiostor: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 08/28] be2iscsi: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 07/28] atp870u: switch to generic DMA API
On Thu, Oct 11, 2018 at 08:49:42PM +0200, Christoph Hellwig wrote:
> Switch from the legacy PCI DMA API to the generic DMA API.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/atp870u.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/atp870u.c b/drivers/scsi/atp870u.c
> index 8996d2329e11..802d15018ec0 100644
> --- a/drivers/scsi/atp870u.c
> +++ b/drivers/scsi/atp870u.c
> @@ -1193,7 +1193,7 @@ static void atp870u_free_tables(struct Scsi_Host *host)
> for (k = 0; k < 16; k++) {
> if (!atp_dev->id[j][k].prd_table)
> continue;
> - pci_free_consistent(atp_dev->pdev, 1024,
> atp_dev->id[j][k].prd_table, atp_dev->id[j][k].prd_bus);
> + dma_free_coherent(&atp_dev->pdev->dev, 1024,
> atp_dev->id[j][k].prd_table, atp_dev->id[j][k].prd_bus);
> atp_dev->id[j][k].prd_table = NULL;
> }
> }
> @@ -1205,7 +1205,7 @@ static int atp870u_init_tables(struct Scsi_Host *host)
> int c,k;
> for(c=0;c < 2;c++) {
> for(k=0;k<16;k++) {
> - atp_dev->id[c][k].prd_table =
> pci_alloc_consistent(atp_dev->pdev, 1024, &(atp_dev->id[c][k].prd_bus));
> + atp_dev->id[c][k].prd_table =
> dma_alloc_coherent(&atp_dev->pdev->dev, 1024, &(atp_dev->id[c][k].prd_bus),
> GFP_KERNEL);
> if (!atp_dev->id[c][k].prd_table) {
> printk("atp870u_init_tables fail\n");
> atp870u_free_tables(host);
This looks ugly, but so does the rest,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 06/28] a100u2w: switch to generic DMA API
On Thu, Oct 11, 2018 at 08:49:41PM +0200, Christoph Hellwig wrote:
> @@ -1124,7 +1124,8 @@ static int inia100_probe_one(struct pci_dev *pdev,
>
> /* Get total memory needed for SCB */
> sz = ORC_MAXQUEUE * sizeof(struct orc_scb);
> - host->scb_virt = pci_zalloc_consistent(pdev, sz, &host->scb_phys);
> + host->scb_virt = dma_zalloc_coherent(&pdev->dev, sz, &host->scb_phys,
> + GFP_KERNEL);
Nit: Indentation looks a bit odd here.
> if (!host->scb_virt) {
> printk("inia100: SCB memory allocation error\n");
> goto out_host_put;
> @@ -1132,7 +1133,8 @@ static int inia100_probe_one(struct pci_dev *pdev,
>
> /* Get total memory needed for ESCB */
> sz = ORC_MAXQUEUE * sizeof(struct orc_extended_scb);
> - host->escb_virt = pci_zalloc_consistent(pdev, sz, &host->escb_phys);
> + host->escb_virt = dma_zalloc_coherent(&pdev->dev, sz, &host->escb_phys,
> + GFP_KERNEL);
and here.
Otherwise,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 05/28] BusLogic: switch to generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 04/28] 3w-sas: fully convert to the generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 03/28] 3w-xxx: fully convert to the generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 01/28] aic94xx: fully convert to the generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 02/28] 3w-9xxx: fully convert to the generic DMA API
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] megaraid_mbox: remove bogus use of pci_dma_sync_sg_* APIs
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] lpfc: remove a bogus pci_dma_sync_single_for_device call
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes ThumshirnSUSE Labs jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] lpfc: fixup crash in lpfc_els_unsol_buffer()
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v2] scsi: sd: don't crash the host on invalid commands
On Tue, Sep 25, 2018 at 08:52:58PM -0400, Martin K. Petersen wrote: > Looks like a bunch of my merge mails didn't make it out last week. > > For the record, I did merge this into 4.19/scsi-fixes and it has made > its way upstream. Thanks for the info. Byte, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] ib_srp: Remove WARN_ON in srp_terminate_io()
On Fri, Sep 21, 2018 at 02:15:05PM +0200, Hannes Reinecke wrote: > The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE > at that time, so no new commands can be submitted via srp_queuecomment() s/srp_queuecomment/srp_queuecommand/ -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
[PATCH v2] scsi: sd: don't crash the host on invalid commands
When sd_init_command() get's a with a unknown req_op() it crashes the system via BUG(). This makes debugging the actual reason for the broken request cmd_flags pretty hard as the system is down before it's able to write out debugging data on the serial console or the trace buffer. Change the BUG() to a WARN_ON() and return BLKPREP_KILL to fail gracefully and return an I/O error to the producer of the request. Signed-off-by: Johannes Thumshirn Cc: Hannes Reinecke Cc: Bart Van Assche Cc: Christoph Hellwig Reviewed-by: Christoph Hellwig --- Changes since v1: - Use WARN_ON_ONCE() (Bart) --- drivers/scsi/sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index b79b366a94f7..f2e41f04e40b 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -1276,7 +1276,8 @@ static int sd_init_command(struct scsi_cmnd *cmd) case REQ_OP_ZONE_RESET: return sd_zbc_setup_reset_cmnd(cmd); default: - BUG(); + WARN_ON_ONCE(1); + return BLKPREP_KILL; } } -- 2.16.4
Re: [PATCH] scsi: sd: don't crash the host on invalid commands
On Thu, Sep 20, 2018 at 11:18:19AM -0700, Bart Van Assche wrote:
> On Thu, 2018-09-20 at 09:19 +0200, Johannes Thumshirn wrote:
>
> Have you considered to use WARN_ON_ONCE() instead of WARN_ON(1)? Otherwise
> this patch looks good to me.
Indeed I did and then forgot to 'git commit --amend' it befroe sending it out.
I'll do so now.
Johannes
--
Johannes Thumshirn Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
[PATCH] scsi: sd: don't crash the host on invalid commands
When sd_init_command() get's a with a unknown req_op() it crashes the system via BUG(). This makes debugging the actual reason for the broken request cmd_flags pretty hard as the system is down before it's able to write out debugging data on the serial console or the trace buffer. Change the BUG() to a WARN_ON() and return BLKPREP_KILL to fail gracefully and return an I/O error to the producer of the request. Signed-off-by: Johannes Thumshirn Cc: Hannes Reinecke Cc: Bart Van Assche Cc: Christoph Hellwig --- Fixed Typo in Bart's mail, sorry for this. drivers/scsi/sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index b79b366a94f7..19f28962d65b 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -1276,7 +1276,8 @@ static int sd_init_command(struct scsi_cmnd *cmd) case REQ_OP_ZONE_RESET: return sd_zbc_setup_reset_cmnd(cmd); default: - BUG(); + WARN_ON(1); + return BLKPREP_KILL; } } -- 2.16.4
[PATCH] scsi: sd: don't crash the host on invalid commands
When sd_init_command() get's a with a unknown req_op() it crashes the system via BUG(). This makes debugging the actual reason for the broken request cmd_flags pretty hard as the system is down before it's able to write out debugging data on the serial console or the trace buffer. Change the BUG() to a WARN_ON() and return BLKPREP_KILL to fail gracefully and return an I/O error to the producer of the request. Signed-off-by: Johannes Thumshirn Cc: Hannes Reinecke Cc: Bart Van Asche Cc: Christoph Hellwig --- drivers/scsi/sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index b79b366a94f7..19f28962d65b 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -1276,7 +1276,8 @@ static int sd_init_command(struct scsi_cmnd *cmd) case REQ_OP_ZONE_RESET: return sd_zbc_setup_reset_cmnd(cmd); default: - BUG(); + WARN_ON(1); + return BLKPREP_KILL; } } -- 2.16.4
Re: [PATCH v2 5/5] scsi: libsas: fix a race condition when smp task timeout
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v2 4/5] scsi: libsas: check the ata device status by ata_dev_enabled()
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v2 2/5] scsi: libsas: check the lldd callback correctly
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH v2 1/5] scsi: libsas: delete dead code in scsi_transport_sas.c
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH -next] scsi: libfc: remove set but not used variable 'rpriv'
Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] libfc: remove unnecessary condition check
Acked-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH 0/3] scsi: fcoe: memleak fixes
gt; rspp type 8 active 1 passive 0 > Aug 7 17:54:30 localhost kernel: [ 15.750570] host10: rport 00c76e: > Received RTV request > Aug 7 17:54:30 localhost kernel: [ 17.758897] host10: rport 00c76e: Port > timeout, state PRLI > Aug 7 17:54:30 localhost kernel: [ 17.764559] host10: rport 00c76e: Port > entered PRLI state from PRLI state > Aug 7 17:54:30 localhost kernel: [ 17.812081] host10: rport 00c76e: > Received a PRLI accept > Aug 7 17:54:31 localhost kernel: [ 17.818809] host10: rport 00c76e: PRLI > spp_flags = 0x21 spp_type 0x8 > Aug 7 17:54:31 localhost kernel: [ 17.826634] host10: rport 00c76e: Port > entered RTV state from PRLI state > Aug 7 17:54:31 localhost kernel: [ 17.878821] host10: rport 00c76e: > Received a RTV accept > Aug 7 17:54:31 localhost kernel: [ 17.885478] host10: rport 00c76e: Port > is Ready > Aug 7 17:54:31 localhost kernel: [ 17.891513] host10: rport 00c76e: work > event 1 > Aug 7 17:54:31 localhost kernel: [ 17.897386] host10: rport 00c76e: No > rport! > Aug 7 17:54:31 localhost kernel: [ 17.903698] host10: rport 00c76e: > callback ev 1 > Aug 7 17:54:31 localhost kernel: [ 17.909081] host10: fip: > vn_rport_callback c76e event 1 > Aug 7 17:54:34 localhost kernel: [ 20.992106] host10: rport 00c76e: > Received ADISC request > > So in the "working" case I see that the other node (4.16 unpatched) accepts > our > PRLI, if I interpret that right, and in the other case it > doesn't. Same system, different boot order though, but I guess > the boot order doesn't matter. > When it doesn't work, it gets or sends a mutual LOGO and gets into a weird > state. > > Anyway: as far as I interpreted it, in the vn2vn situation alle > enodes should know all other rports to prevent a double rport > assignment. I have no experience with FC itself though, so I > don't know what the normal state is but sending a LOGO due to a > failure to set up, is that ok? > Or is the vn2vn rport maintenance on another layer? > > The 4.9 kernel is still to be baked... > I expect it to yield minor kmemleaks, until I start toggling the > FCoE. > > Regards, > Ard van Breemen > > PS: I removed some cross spamming from the Cc:, I hope that's ok. Full quote for reference. This looks like the PRLI rework from Hannes introduced the memleaks here. Hannes can you have a look at it? -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] Remove extra goto label from nvmet_ns_enable
please send this patch to the correct mailing list (linux-n...@lists.infradead.org) -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] Simplify nvmet_init to remove extra out label
please send this patch to the correct mailing list (linux-n...@lists.infradead.org) -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] scsi: aic94xx: fix an error code in aic94xx_init()
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] sr: Avoid that opening a CD-ROM hangs with runtime power management enabled
On Fri, Aug 03, 2018 at 10:28:45AM +0200, Johannes Thumshirn wrote: > On Thu, Aug 02, 2018 at 10:44:42AM -0700, Bart Van Assche wrote: > > Surround scsi_execute() calls with scsi_autopm_get_device() and > > scsi_autopm_put_device(). Note: removing sr_mutex protection from > > the scsi_cd_get() and scsi_cd_put() calls is safe because the > > purpose of sr_mutex is to serialize cdrom_*() calls. > > > [...] > > Hi Bart, > > With this patch I still have the hang on next-20180801: Forget my last email, I didn't have Ming's 'blk-mq: fix blk_mq_tagset_busy_iter' applied. Tested-by: Johannes Thumshirn Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: [PATCH] sr: Avoid that opening a CD-ROM hangs with runtime power management enabled
On Thu, Aug 02, 2018 at 10:44:42AM -0700, Bart Van Assche wrote: > Surround scsi_execute() calls with scsi_autopm_get_device() and > scsi_autopm_put_device(). Note: removing sr_mutex protection from > the scsi_cd_get() and scsi_cd_put() calls is safe because the > purpose of sr_mutex is to serialize cdrom_*() calls. > [...] Hi Bart, With this patch I still have the hang on next-20180801: [ 247.875657] INFO: task swapper/0:1 blocked for more than 120 seconds. [ 247.877560] Not tainted 4.18.0-rc7-next-20180801+ #131 [ 247.878703] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 247.880497] swapper/0 D13496 1 0 0x8000 [ 247.881542] Call Trace: [ 247.882638] ? __schedule+0x253/0x700 [ 247.882898] schedule+0x23/0x80 [ 247.883149] async_synchronize_cookie_domain+0x89/0xd0 [ 247.883509] ? wait_woken+0x80/0x80 [ 247.883712] ? rest_init+0xb0/0xb0 [ 247.883907] kernel_init+0xa/0x100 [ 247.884096] ret_from_fork+0x35/0x40 [ 370.755258] INFO: task swapper/0:1 blocked for more than 120 seconds. [ 370.756735] Not tainted 4.18.0-rc7-next-20180801+ #131 [ 370.757931] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 370.759417] swapper/0 D13496 1 0 0x8000 [ 370.760567] Call Trace: [ 370.761141] ? __schedule+0x253/0x700 [ 370.761982] schedule+0x23/0x80 [ 370.762534] async_synchronize_cookie_domain+0x89/0xd0 [ 370.762818] ? wait_woken+0x80/0x80 [ 370.763020] ? rest_init+0xb0/0xb0 [ 370.763279] kernel_init+0xa/0x100 [ 370.763478] ret_from_fork+0x35/0x40 [ 493.635108] INFO: task swapper/0:1 blocked for more than 120 seconds. [ 493.636403] Not tainted 4.18.0-rc7-next-20180801+ #131 [ 493.637449] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 493.638803] swapper/0 D13496 1 0 0x8000 [ 493.639963] Call Trace: [ 493.640669] ? __schedule+0x253/0x700 [ 493.641446] schedule+0x23/0x80 [ 493.642023] async_synchronize_cookie_domain+0x89/0xd0 [ 493.643114] ? wait_woken+0x80/0x80 [ 493.643923] ? rest_init+0xb0/0xb0 [ 493.644411] kernel_init+0xa/0x100 [ 493.644680] ret_from_fork+0x35/0x40 [ 616.515472] INFO: task swapper/0:1 blocked for more than 120 seconds. [ 616.516773] Not tainted 4.18.0-rc7-next-20180801+ #131 [ 616.517790] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 616.519260] swapper/0 D13496 1 0 0x8000 [ 616.520322] Call Trace: [ 616.520854] ? __schedule+0x253/0x700 [ 616.521662] schedule+0x23/0x80 [ 616.522249] async_synchronize_cookie_domain+0x89/0xd0 [ 616.523402] ? wait_woken+0x80/0x80 [ 616.524002] ? rest_init+0xb0/0xb0 [ 616.524779] kernel_init+0xa/0x100 [ 616.525054] ret_from_fork+0x35/0x40 [ 739.394997] INFO: task swapper/0:1 blocked for more than 120 seconds. [ 739.396351] Not tainted 4.18.0-rc7-next-20180801+ #131 [ 739.397411] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 739.398751] swapper/0 D13496 1 0 0x8000 [ 739.399841] Call Trace: [ 739.400506] ? __schedule+0x253/0x700 [ 739.401152] schedule+0x23/0x80 [ 739.401856] async_synchronize_cookie_domain+0x89/0xd0 [ 739.402527] ? wait_woken+0x80/0x80 [ 739.402773] ? rest_init+0xb0/0xb0 [ 739.402997] kernel_init+0xa/0x100 [ 739.403311] ret_from_fork+0x35/0x40 [ 862.275229] INFO: task swapper/0:1 blocked for more than 120 seconds. [ 862.276636] Not tainted 4.18.0-rc7-next-20180801+ #131 [ 862.277882] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 862.279358] swapper/0 D13496 1 0 0x8000 [ 862.280492] Call Trace: [ 862.281074] ? __schedule+0x253/0x700 [ 862.281958] schedule+0x23/0x80 [ 862.282765] async_synchronize_cookie_domain+0x89/0xd0 [ 862.283921] ? wait_woken+0x80/0x80 [ 862.284836] ? rest_init+0xb0/0xb0 [ 862.285327] kernel_init+0xa/0x100 [ 862.285520] ret_from_fork+0x35/0x40 [ 985.155031] INFO: task swapper/0:1 blocked for more than 120 seconds. [ 985.156626] Not tainted 4.18.0-rc7-next-20180801+ #131 [ 985.157699] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 985.159032] swapper/0 D13496 1 0 0x8000 [ 985.160313] Call Trace: [ 985.160819] ? __schedule+0x253/0x700 [ 985.161303] schedule+0x23/0x80 [ 985.161480] async_synchronize_cookie_domain+0x89/0xd0 [ 985.161734] ? wait_woken+0x80/0x80 [ 985.161914] ? rest_init+0xb0/0xb0 [ 985.162080] kernel_init+0xa/0x100 [ 985.162334] ret_from_fork+0x35/0x40 -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: next/master boot: 179 boots: 11 failed, 167 passed with 1 offline (next-20180731)
On Thu, Aug 02, 2018 at 07:15:30AM +0800, Ming Lei wrote: > I just checked my daily test log, looks this issue is reported 1st time > on next-20180731. >From the diff between next-20180727 and next-20180731 in drivers/scsi nothing really sticks out. $ PAGER= git diff --stat next-20180730..next-20180731 drivers/scsi/ drivers/scsi/3w-9xxx.c | 6 +- drivers/scsi/3w-sas.c| 3 +++ drivers/scsi/3w-.c | 2 ++ drivers/scsi/a100u2w.c | 4 ++-- drivers/scsi/atp870u.c | 16 drivers/scsi/ibmvscsi/ibmvscsi.c | 6 ++ drivers/scsi/libiscsi.c | 2 ++ drivers/scsi/lpfc/lpfc_nvmet.c | 8 +++- drivers/scsi/scsi_debug.c| 47 --- 9 files changed, 59 insertions(+), 35 deletions(-) but drivers/ata has seen some (power management) related changes: $ PAGER= git log --oneline --no-merges next-20180730..next-20180731 drivers/ata/ 11c291461b6e ata: libahci: Allow reconfigure of DEVSLP register 2dbb3ec29a6c ata: libahci: Correct setting of DEVSLP register b1a9585cc396 ata: ahci: Enable DEVSLP by default on x86 with SLP_S0 a5ec5a7bfd1f ata: ahci: Support state with min power but Partial low power state $ PAGER= git diff --stat next-20180730..next-20180731 drivers/ata/ drivers/ata/ahci.c| 38 +- drivers/ata/libahci.c | 25 - drivers/ata/libata-core.c | 1 + drivers/ata/libata-scsi.c | 1 + 4 files changed, 51 insertions(+), 14 deletions(-) I'll be looking into it. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: next/master boot: 179 boots: 11 failed, 167 passed with 1 offline (next-20180731)
On Wed, Aug 01, 2018 at 02:50:40PM +0100, Guillaume Tucker wrote: > > Sure, although it didn't make any apparent difference, still on > next-20180731: > > https://lava.collabora.co.uk/scheduler/job/1215417 > > The .config file I used is available here, with just > CONFIG_BLK_DEV_RAM=y on top of defconfig: > > > https://people.collabora.com/~gtucker/lava/boot/debug/bzImage-85eac382fa06-blk-dev.config OK, this is a deviation from what I see here (on mkp's 4.19/scsi-queue not next though). -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: next/master boot: 179 boots: 11 failed, 167 passed with 1 offline (next-20180731)
On Wed, Aug 01, 2018 at 01:37:17PM +0100, Guillaume Tucker wrote: > The kernel images I used have the git revision in their file name > to make it clear where they came from, they were built with > x86_64_defconfig. The links to the kernel and ramdisks can be > found in the job definition: > > https://lava.collabora.co.uk/scheduler/job/1215154/definition > > Please let me know if you need any more details. I'm happy to > run other boot tests on that same setup if that helps verifying > things (such as enabling some VIRTIO configs...). Yes, can you please enable CONFIG_BLK_DEV_RAM? See my other mails in this thread for details. Thanks, Johannes -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Re: next/master boot: 179 boots: 11 failed, 167 passed with 1 offline (next-20180731)
On Wed, Aug 01, 2018 at 08:00:44PM +0800, Ming Lei wrote: > On Wed, Aug 01, 2018 at 07:52:19PM +0800, Ming Lei wrote: > > On Wed, Aug 01, 2018 at 12:24:00PM +0100, Matt Hart wrote: > > > On 1 August 2018 at 11:59, Mark Brown wrote: > > > > On Wed, Aug 01, 2018 at 06:51:09PM +0800, Ming Lei wrote: > > > > > > > >> You may have to provide some clue, such as dmesg log, boot disk, ... > > > > > > > >> I guess you don't use virtio-scsi/virtio-blk since both run at blk-mq > > > >> mode at default, even though without d5038a13eca72fb. > > > > > > > > Boot logs and so on can be found here: > > > > > > > > https://kernelci.org/boot/id/5b618c9f59b514931f96ba97/ > > > > https://kernelci.org/boot/id/5b618ca359b514904d96bac5/ > > > > https://kernelci.org/boot/id/5b618cbc59b51492e896baad/ > > > > > > > > (these are today's but the symptoms are the same.) The ramdisk is > > > > unfortunately not linked through the UI, though we don't get that far. > > > > > > And a full LAVA boot log from my lab > > > http://lava.streamtester.net/scheduler/job/138067 > > > > > > QEMU command line here: > > > http://lava.streamtester.net/scheduler/job/138067#L75 > > > > > > And a LAVA job definition, which includes the url of the ramdisk and > > > kernel: > > > http://lava.streamtester.net/scheduler/job/138067/definition#defline76 > > > > > > > Thanks for the sharing! > > > > I can reproduce this issue with above script/initrd/kernel config, and looks > > the issue disappeared after 'scsi_mod.use_blk_mq=0' is passed. > > > > Not see such issue with zero-day ktest config. > > > > Looks a bit weird, given SCSI_MQ is nothing related with ramdisk. > > Seems related with sr: > > 1) with scsi-mq > [2.808204] ata2.01: NODEV after polling detection > [2.809807] ata2.00: ATAPI: QEMU DVD-ROM, 2.5+, max UDMA/100 > [2.827377] scsi 1:0:0:0: CD-ROMQEMU QEMU DVD-ROM 2.5+ > PQ: 0 ANSI: 5 > > 2) without scsi_mq > [5.549135] ata2.01: NODEV after polling detection > [5.554404] ata2.00: ATAPI: QEMU DVD-ROM, 2.5+, max UDMA/100 > [5.596143] scsi 1:0:0:0: CD-ROMQEMU QEMU DVD-ROM 2.5+ > PQ: 0 ANSI: 5 > [5.637126] sr 1:0:0:0: [sr0] scsi3-mmc drive: 4x/4x cd/rw xa/form2 tray > [5.637870] cdrom: Uniform CD-ROM driver Revision: 3.20 > [5.648940] sr 1:0:0:0: Attached scsi CD-ROM sr0 > [5.661605] sr 1:0:0:0: Attached scsi generic sg0 type 5 > > > We may need to take a look at recent SCSI change. [2.052168] ata2.01: NODEV after polling detection [2.053690] ata2.00: ATAPI: QEMU DVD-ROM, 2.5+, max UDMA/100 [2.072269] scsi 1:0:0:0: CD-ROMQEMU QEMU DVD-ROM 2.5+ P5 [2.107220] sr 1:0:0:0: [sr0] scsi3-mmc drive: 4x/4x cd/rw xa/form2 tray [2.107675] cdrom: Uniform CD-ROM driver Revision: 3.20 [2.111851] sr 1:0:0:0: Attached scsi CD-ROM sr0 [2.123560] sr 1:0:0:0: Attached scsi generic sg0 type 5 # cat /proc/cmdline console=ttyS0,115200 root=/dev/ram0 debug verbose $ grep SCSI_MQ .config CONFIG_SCSI_MQ_DEFAULT=y on Martin's latest 4.19/scsi-queue. -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
