RE: [PATCH][SCSI] mpt3sas: Paer 1 of MPI API headers

2012-10-02 Thread Nandigama, Nagalakshmi 
On Sat, Sep 29, 2012 at 10:52:50PM +0200, Bj??rn Mork wrote:
>  writes:
> > > This patch contains MPI API headers
> > 
> > Why can't this and the other headers be shared between the mpt2sas and
> > mpt3sas drivers?  Looks like you are duplicating a lot of code already
> > present in drivers/scsi/mpt2sas.  Why?  That's a recipe for maintenance
> > hell...
>
> I would go further and ask why this needs a new driver; why can't mpt2sas
> be enhanced to drive the 12Gbit cards?

A deliberate choice was made to keep the mpt3sas separate from mpt2sas due to 
our 6 GIG product being truly mature with a noticeable ramping down of 
enhancements/releases.   

mpt3sas is at it's initial baseline with a healthy roadmap ahead.  
Architecturally there will be changes to the headers that will be only mpt3sas 
specific. Another reason to keep the source separate.  

The mpt3sas release schedules is on a faster cadence than mpt2sas so keeping 
the source aligned is problematic.

>From a maintenance and test perspective having the source base separate 
>actually reduces the so called maintenance "hell".


-- 
Regards,
Nagalakshmi
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH][SCSI] mpt3sas: Paer 1 of MPI API headers

2012-09-29 Thread Matthew Wilcox 
On Sat, Sep 29, 2012 at 10:52:50PM +0200, Bj??rn Mork wrote:
>  writes:
> > This patch contains MPI API headers
> 
> Why can't this and the other headers be shared between the mpt2sas and
> mpt3sas drivers?  Looks like you are duplicating a lot of code already
> present in drivers/scsi/mpt2sas.  Why?  That's a recipe for maintenance
> hell...

I would go further and ask why this needs a new driver; why can't mpt2sas
be enhanced to drive the 12Gbit cards?

-- 
Matthew Wilcox  Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH][SCSI] mpt3sas: Paer 1 of MPI API headers

2012-09-29 Thread Bjørn Mork 
 writes:

> This patch contains MPI API headers
> This patch is part 1 of MPI API headers.
> Signed-off-by: Sreekanth Reddy 
> Reviewed-by: Nagalakshmi Nandigama 
> ---
>
>
> diff --git a/drivers/scsi/mpt3sas/mpi/mpi2.h b/drivers/scsi/mpt3sas/mpi/mpi2.h
> new file mode 100644
> index 000..03317ff
> --- /dev/null
> +++ b/drivers/scsi/mpt3sas/mpi/mpi2.h
> @@ -0,0 +1,1164 @@

Why can't this and the other headers be shared between the mpt2sas and
mpt3sas drivers?  Looks like you are duplicating a lot of code already
present in drivers/scsi/mpt2sas.  Why?  That's a recipe for maintenance
hell...

And it makes this submission impossible to review.


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH][SCSI] mpt3sas: Paer 1 of MPI API headers

2012-09-29 Thread sreekanth.reddy 
This patch contains MPI API headers
This patch is part 1 of MPI API headers.
Signed-off-by: Sreekanth Reddy 
Reviewed-by: Nagalakshmi Nandigama 
---


diff --git a/drivers/scsi/mpt3sas/mpi/mpi2.h b/drivers/scsi/mpt3sas/mpi/mpi2.h
new file mode 100644
index 000..03317ff
--- /dev/null
+++ b/drivers/scsi/mpt3sas/mpi/mpi2.h
@@ -0,0 +1,1164 @@
+/*
+ * Copyright (c) 2000-2012 LSI Corporation.
+ *
+ *
+ *  Name:  mpi2.h
+ * Title:  MPI Message independent structures and definitions
+ * including System Interface Register Set and
+ * scatter/gather formats.
+ * Creation Date:  June 21, 2006
+ *
+ * mpi2.h Version:  02.00.26
+ *
+ * NOTE: Names (typedefs, defines, etc.) beginning with an MPI25 or Mpi25
+ *   prefix are for use only on MPI v2.5 products, and must not be used
+ *   with MPI v2.0 products. Unless otherwise noted, names beginning with
+ *   MPI2 or Mpi2 are for use with both MPI v2.0 and MPI v2.5 products.
+ *
+ * Version History
+ * ---
+ *
+ * Date  Version   Description
+ *     --
+ * 04-30-07  02.00.00  Corresponds to Fusion-MPT MPI Specification Rev A.
+ * 06-04-07  02.00.01  Bumped MPI2_HEADER_VERSION_UNIT.
+ * 06-26-07  02.00.02  Bumped MPI2_HEADER_VERSION_UNIT.
+ * 08-31-07  02.00.03  Bumped MPI2_HEADER_VERSION_UNIT.
+ * Moved ReplyPostHostIndex register to offset 0x6C of the
+ * MPI2_SYSTEM_INTERFACE_REGS and modified the define for
+ * MPI2_REPLY_POST_HOST_INDEX_OFFSET.
+ * Added union of request descriptors.
+ * Added union of reply descriptors.
+ * 10-31-07  02.00.04  Bumped MPI2_HEADER_VERSION_UNIT.
+ * Added define for MPI2_VERSION_02_00.
+ * Fixed the size of the FunctionDependent5 field in the
+ * MPI2_DEFAULT_REPLY structure.
+ * 12-18-07  02.00.05  Bumped MPI2_HEADER_VERSION_UNIT.
+ * Removed the MPI-defined Fault Codes and extended the
+ * product specific codes up to 0xEFFF.
+ * Added a sixth key value for the WriteSequence register
+ * and changed the flush value to 0x0.
+ * Added message function codes for Diagnostic Buffer Post
+ * and Diagnsotic Release.
+ * New IOCStatus define: MPI2_IOCSTATUS_DIAGNOSTIC_RELEASED
+ * Moved MPI2_VERSION_UNION from mpi2_ioc.h.
+ * 02-29-08  02.00.06  Bumped MPI2_HEADER_VERSION_UNIT.
+ * 03-03-08  02.00.07  Bumped MPI2_HEADER_VERSION_UNIT.
+ * 05-21-08  02.00.08  Bumped MPI2_HEADER_VERSION_UNIT.
+ * Added #defines for marking a reply descriptor as unused.
+ * 06-27-08  02.00.09  Bumped MPI2_HEADER_VERSION_UNIT.
+ * 10-02-08  02.00.10  Bumped MPI2_HEADER_VERSION_UNIT.
+ * Moved LUN field defines from mpi2_init.h.
+ * 01-19-09  02.00.11  Bumped MPI2_HEADER_VERSION_UNIT.
+ * 05-06-09  02.00.12  Bumped MPI2_HEADER_VERSION_UNIT.
+ * In all request and reply descriptors, replaced VF_ID
+ * field with MSIxIndex field.
+ * Removed DevHandle field from
+ * MPI2_SCSI_IO_SUCCESS_REPLY_DESCRIPTOR and made those
+ * bytes reserved.
+ * Added RAID Accelerator functionality.
+ * 07-30-09  02.00.13  Bumped MPI2_HEADER_VERSION_UNIT.
+ * 10-28-09  02.00.14  Bumped MPI2_HEADER_VERSION_UNIT.
+ * Added MSI-x index mask and shift for Reply Post Host
+ * Index register.
+ * Added function code for Host Based Discovery Action.
+ * 02-10-10  02.00.15  Bumped MPI2_HEADER_VERSION_UNIT.
+ * Added define for MPI2_FUNCTION_PWR_MGMT_CONTROL.
+ * Added defines for product-specific range of message
+ * function codes, 0xF0 to 0xFF.
+ * 05-12-10  02.00.16  Bumped MPI2_HEADER_VERSION_UNIT.
+ * Added alternative defines for the SGE Direction bit.
+ * 08-11-10  02.00.17  Bumped MPI2_HEADER_VERSION_UNIT.
+ * 11-10-10  02.00.18  Bumped MPI2_HEADER_VERSION_UNIT.
+ * Added MPI2_IEEE_SGE_FLAGS_SYSTEMPLBCPI_ADDR define.
+ * 02-23-11  02.00.19  Bumped MPI2_HEADER_VERSION_UNIT.
+ * Added MPI2_FUNCTION_SEND_HOST_MESSAGE.
+ * 03-09-11  02.00.20  Bumped MPI2_HEADER_VERSION_UNIT.
+ * 05-25-11  02.00.21  Bumped MPI2_HEADER_VERSION_UNIT.
+ * 08-24-11  02.00.22  Bumped MPI2_HEADER_VERSION_UNIT.
+ * 11-18-11  02.00.23  Bumped MPI2_HEADER_VERSION_UNIT.
+ * Incorporating additions for MPI v2.5.
+ * 02-06-12  02.00.24  Bumped MPI2_HEADER_VERSION_UNIT.
+ * 03-29-12  02.00.25  Bumped MPI2_HEADER_VERSION_UNIT.
+ * Added Hard Reset delay timings.
+ * 07-10-12  02.00.26  Bump