Re: [PATCH] scsi_transport_sas: don't bounce highmem pages for the smp handler

2018-05-01 Thread Martin K. Petersen 

Christoph,

> All three instance of ->smp_handler deal with highmem backed requests
> just fine.

Applied to 4.18/scsi-queue. Thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH] scsi_transport_sas: don't bounce highmem pages for the smp handler

2018-04-30 Thread Johannes Thumshirn 
On Sun, Apr 15, 2018 at 04:52:37PM +0200, Christoph Hellwig wrote:
> All three instance of ->smp_handler deal with highmem backed requests
> just fine.

That's my conclusion as well.

Looks good,
Reviewed-by: Johannes Thumshirn 

-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Re: [PATCH] scsi_transport_sas: don't bounce highmem pages for the smp handler

2018-04-28 Thread Johannes Thumshirn 
On Fri, Apr 27, 2018 at 07:24:18AM +0200, Christoph Hellwig wrote:
> Johannes,
> 
> can you take a look at this?  You are one of the few persons who cared
> about SMP passthrough in the recent past.

I'm sitting at the airport currently, but as soon as I'm back in the office
I'll have a look.

Johannes
-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Re: [PATCH] scsi_transport_sas: don't bounce highmem pages for the smp handler

2018-04-26 Thread Christoph Hellwig 
Johannes,

can you take a look at this?  You are one of the few persons who cared
about SMP passthrough in the recent past.

On Sun, Apr 15, 2018 at 04:52:37PM +0200, Christoph Hellwig wrote:
> All three instance of ->smp_handler deal with highmem backed requests
> just fine.
> 
> Signed-off-by: Christoph Hellwig 
> ---
>  drivers/scsi/scsi_transport_sas.c | 4 
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/scsi/scsi_transport_sas.c 
> b/drivers/scsi/scsi_transport_sas.c
> index 08acbabfae07..a22baf206071 100644
> --- a/drivers/scsi/scsi_transport_sas.c
> +++ b/drivers/scsi/scsi_transport_sas.c
> @@ -223,10 +223,6 @@ static int sas_bsg_initialize(struct Scsi_Host *shost, 
> struct sas_rphy *rphy)
>   to_sas_host_attrs(shost)->q = q;
>   }
>  
> - /*
> -  * by default assume old behaviour and bounce for any highmem page
> -  */
> - blk_queue_bounce_limit(q, BLK_BOUNCE_HIGH);
>   blk_queue_flag_set(QUEUE_FLAG_BIDI, q);
>   return 0;
>  }
> -- 
> 2.17.0
---end quoted text---