Re: [PATCH-next] scsi: libsas: dynamically allocate and free ata host
On 28/06/2018 23:07, Martin K. Petersen wrote: John, OK, but please be aware that there may be a more serious issue fixed here than the WARN, in that we could try to free memory embedded in a structure. We can still get it into 4.18.x. I'm just wary of submitting stuff to Linus that has had zero -next exposure. Hi Martin, I'm wondering if we still plan on adding this to 4.18 stable? I'm getting asked about it again from guys running 4.18.4 . Cheers, John
Re: [PATCH-next] scsi: libsas: dynamically allocate and free ata host
John, > OK, but please be aware that there may be a more serious issue fixed > here than the WARN, in that we could try to free memory embedded in a > structure. We can still get it into 4.18.x. I'm just wary of submitting stuff to Linus that has had zero -next exposure. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH-next] scsi: libsas: dynamically allocate and free ata host
On 26/06/2018 17:40, Martin K. Petersen wrote: John, Took a while for all the prerequisites to materialize. I just rebased 4.19/scsi-queue to v4.18-rc1 and applied your patch. Thanks! Is it possible to add this patch to the 4.18 fixes? I was on the fence on this but felt it was an intricate enough change to warrant a bit of soak time before ending up in a stable release. That's why it went into 4.19. Hi Martin, OK, but please be aware that there may be a more serious issue fixed here than the WARN, in that we could try to free memory embedded in a structure. Thanks, John
Re: [PATCH-next] scsi: libsas: dynamically allocate and free ata host
John, >> Took a while for all the prerequisites to materialize. I just rebased >> 4.19/scsi-queue to v4.18-rc1 and applied your patch. Thanks! > > Is it possible to add this patch to the 4.18 fixes? I was on the fence on this but felt it was an intricate enough change to warrant a bit of soak time before ending up in a stable release. That's why it went into 4.19. -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH-next] scsi: libsas: dynamically allocate and free ata host
On 19/06/2018 03:31, Martin K. Petersen wrote: Jason, So we have to change this embedded static ata host to a dynamically allocated ata host and initialize the ->kref member. To use ata_host_get() and ata_host_put() in libsas, we need to move the declaration of these functions to the public libata.h and export them. Took a while for all the prerequisites to materialize. I just rebased 4.19/scsi-queue to v4.18-rc1 and applied your patch. Thanks! Hi Martin, Is it possible to add this patch to the 4.18 fixes? All the best, John
Re: [PATCH-next] scsi: libsas: dynamically allocate and free ata host
Jason, > So we have to change this embedded static ata host to a dynamically > allocated ata host and initialize the ->kref member. To use > ata_host_get() and ata_host_put() in libsas, we need to move the > declaration of these functions to the public libata.h and export them. Took a while for all the prerequisites to materialize. I just rebased 4.19/scsi-queue to v4.18-rc1 and applied your patch. Thanks! -- Martin K. Petersen Oracle Linux Engineering
Re: [PATCH-next] scsi: libsas: dynamically allocate and free ata host
On Thu, May 10, 2018 at 11:05:16AM +0800, Jason Yan wrote:
> Commit 2623c7a5f2 ("libata: add refcounting to ata_host") v4.17+
> introduced refcounting to ata_host and will increase or decrease the
> refcount when adding or deleting transport ATA port.
libata side looks good to me.
Acked-by: Tejun Heo
Thanks.
--
tejun
Re: [PATCH-next] scsi: libsas: dynamically allocate and free ata host
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on mkp-scsi/for-next] [also build test ERROR on next-20180504] [cannot apply to v4.17-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/linux-kernel-owner-vger-kernel-org/scsi-libsas-dynamically-allocate-and-free-ata-host/20180507-105656 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: x86_64-federa-25 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >> ERROR: "ata_host_put" [drivers/scsi/libsas/libsas.ko] undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
