Re: [PATCH 12/18] usb: typec: ucsi: acpi: Move to the new API
Hi Heikki,
I love your patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[cannot apply to v5.4-rc4 next-20191021]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Heikki-Krogerus/usb-typec-API-improvements/20191022-013906
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
sparse warnings: (new ones prefixed by >>)
>> drivers/usb/typec/ucsi/ucsi_acpi.c:54:9: sparse: sparse: incorrect type in
>> argument 2 (different address spaces) @@expected void const *from @@
>> got void [noderevoid const *from @@
>> drivers/usb/typec/ucsi/ucsi_acpi.c:54:9: sparse:expected void const *from
drivers/usb/typec/ucsi/ucsi_acpi.c:54:9: sparse:got void [noderef]
*
>> drivers/usb/typec/ucsi/ucsi_acpi.c:64:9: sparse: sparse: incorrect type in
>> argument 1 (different address spaces) @@expected void *to @@got void
>> [noderef] > drivers/usb/typec/ucsi/ucsi_acpi.c:64:9: sparse:expected void *to
drivers/usb/typec/ucsi/ucsi_acpi.c:64:9: sparse:got void [noderef]
*
vim +54 drivers/usb/typec/ucsi/ucsi_acpi.c
43
44 static int ucsi_acpi_read(struct ucsi *ucsi, unsigned int offset,
45void *val, size_t val_len)
46 {
47 struct ucsi_acpi *ua = ucsi_get_drvdata(ucsi);
48 int ret;
49
50 ret = ucsi_acpi_dsm(ua, UCSI_DSM_FUNC_READ);
51 if (ret)
52 return ret;
53
> 54 memcpy(val, ua->base + offset, val_len);
55
56 return 0;
57 }
58
59 static int ucsi_acpi_async_write(struct ucsi *ucsi, unsigned int offset,
60 const void *val, size_t val_len)
61 {
62 struct ucsi_acpi *ua = ucsi_get_drvdata(ucsi);
63
> 64 memcpy(ua->base + offset, val, val_len);
65
66 return ucsi_acpi_dsm(ua, UCSI_DSM_FUNC_WRITE);
67 }
68
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH 4/5] USB: Select better matching USB drivers when available
Hi Bastien, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [cannot apply to v5.4-rc2 next-20191010] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Bastien-Nocera/Add-Apple-MFi-fastcharge-USB-device-driver/20191010-155853 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing reproduce: make htmldocs If you fix the issue, kindly add following tag Reported-by: kbuild test robot All warnings (new ones prefixed by >>): Warning: The Sphinx 'sphinx_rtd_theme' HTML theme was not found. Make sure you have the theme installed to produce pretty HTML output. Falling back to the default theme. WARNING: dot(1) not found, for better output quality install graphviz from http://www.graphviz.org WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) include/linux/regulator/machine.h:196: warning: Function parameter or member 'max_uV_step' not described in 'regulation_constraints' include/linux/regulator/driver.h:223: warning: Function parameter or member 'resume' not described in 'regulator_ops' Error: Cannot open file drivers/dma-buf/reservation.c Error: Cannot open file drivers/dma-buf/reservation.c Error: Cannot open file drivers/dma-buf/reservation.c Error: Cannot open file include/linux/reservation.h Error: Cannot open file include/linux/reservation.h include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'quotactl' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'quota_on' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_free_mnt_opts' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_eat_lsm_opts' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_kern_mount' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_show_options' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_add_mnt_opt' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'd_instantiate' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'getprocattr' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'setprocattr' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'locked_down' not described in 'security_list_options' include/linux/spi/spi.h:190: warning: Function parameter or member 'driver_override' not described in 'spi_device' lib/genalloc.c:1: warning: 'gen_pool_add_virt' not found lib/genalloc.c:1: warning: 'gen_pool_alloc' not found lib/genalloc.c:1: warning: 'gen_pool_free' not found lib/genalloc.c:1: warning: 'gen_pool_alloc_algo' not found drivers/gpio/gpiolib-of.c:92: warning: Excess function parameter 'dev' description in 'of_gpio_need_valid_mask' include/linux/i2c.h:337: warning: Function parameter or member 'init_irq' not described in 'i2c_client' drivers/usb/typec/bus.c:1: warning: 'typec_altmode_unregister_driver' not found drivers/usb/typec/bus.c:1: warning: 'typec_altmode_register_driver' not found drivers/usb/typec/class.c:1: warning: 'typec_altmode_unregister_notifier' not found drivers/usb/typec/class.c:1: warning: 'typec_altmode_register_notifier' not found >> include/linux/usb.h:1251: warning: Function parameter or member 'match' not >> described in 'usb_device_driver' >> include/linux/usb.h:1251: warning: Function parameter or member 'id_table' >> not described in 'usb_device_driver' include/linux/usb.h:1251: warning: Function parameter or member 'generic_init' not described in 'usb_device_driver' include/linux/w1.h:277: warning: Function parameter or member 'of_match_table' not described in
Re: [PATCH 2/5] USB: Make it possible to "subclass" usb_device_driver
Hi Bastien, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [cannot apply to v5.4-rc2 next-20191010] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Bastien-Nocera/Add-Apple-MFi-fastcharge-USB-device-driver/20191010-155853 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing reproduce: make htmldocs If you fix the issue, kindly add following tag Reported-by: kbuild test robot All warnings (new ones prefixed by >>): Warning: The Sphinx 'sphinx_rtd_theme' HTML theme was not found. Make sure you have the theme installed to produce pretty HTML output. Falling back to the default theme. WARNING: dot(1) not found, for better output quality install graphviz from http://www.graphviz.org WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) include/linux/regulator/machine.h:196: warning: Function parameter or member 'max_uV_step' not described in 'regulation_constraints' include/linux/regulator/driver.h:223: warning: Function parameter or member 'resume' not described in 'regulator_ops' Error: Cannot open file drivers/dma-buf/reservation.c Error: Cannot open file drivers/dma-buf/reservation.c Error: Cannot open file drivers/dma-buf/reservation.c Error: Cannot open file include/linux/reservation.h Error: Cannot open file include/linux/reservation.h include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'quotactl' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'quota_on' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_free_mnt_opts' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_eat_lsm_opts' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_kern_mount' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_show_options' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'sb_add_mnt_opt' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'd_instantiate' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'getprocattr' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'setprocattr' not described in 'security_list_options' include/linux/lsm_hooks.h:1822: warning: Function parameter or member 'locked_down' not described in 'security_list_options' include/linux/spi/spi.h:190: warning: Function parameter or member 'driver_override' not described in 'spi_device' lib/genalloc.c:1: warning: 'gen_pool_add_virt' not found lib/genalloc.c:1: warning: 'gen_pool_alloc' not found lib/genalloc.c:1: warning: 'gen_pool_free' not found lib/genalloc.c:1: warning: 'gen_pool_alloc_algo' not found drivers/gpio/gpiolib-of.c:92: warning: Excess function parameter 'dev' description in 'of_gpio_need_valid_mask' include/linux/i2c.h:337: warning: Function parameter or member 'init_irq' not described in 'i2c_client' drivers/usb/typec/bus.c:1: warning: 'typec_altmode_unregister_driver' not found drivers/usb/typec/bus.c:1: warning: 'typec_altmode_register_driver' not found drivers/usb/typec/class.c:1: warning: 'typec_altmode_unregister_notifier' not found drivers/usb/typec/class.c:1: warning: 'typec_altmode_register_notifier' not found >> include/linux/usb.h:1247: warning: Function parameter or member >> 'generic_init' not described in 'usb_device_driver' include/linux/w1.h:277: warning: Function parameter or member 'of_match_table' not described in 'w1_family' fs/fs-writeback.c:913: warning: Excess function parameter 'nr_pages' description in 'cgroup_writeback_by_id' fs/direct-io.c:258: warning: Excess function parameter 'offset' description in 'dio_complete' fs/libf
Re: [PATCH v3 2/2] usb: roles: intel: Enable static DRD mode for role switch
Hi Saranya,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc6 next-20190827]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Saranya-Gopal/xhci-ext-caps-c-Add-property-to-disable-Intel-SW-switch/20190829-031957
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-11) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers/usb/roles/intel-xhci-usb-role-switch.c: In function
'intel_xhci_usb_set_role':
>> drivers/usb/roles/intel-xhci-usb-role-switch.c:55:16: warning: 'drd_config'
>> may be used uninitialized in this function [-Wmaybe-uninitialized]
u32 glk, val, drd_config;
^~
vim +/drd_config +55 drivers/usb/roles/intel-xhci-usb-role-switch.c
49
50 static int intel_xhci_usb_set_role(struct device *dev, enum usb_role
role)
51 {
52 struct intel_xhci_usb_data *data = dev_get_drvdata(dev);
53 unsigned long timeout;
54 acpi_status status;
> 55 u32 glk, val, drd_config;
56
57 /*
58 * On many CHT devices ACPI event (_AEI) handlers read / modify
/
59 * write the cfg0 register, just like we do. Take the ACPI lock
60 * to avoid us racing with the AML code.
61 */
62 status = acpi_acquire_global_lock(ACPI_WAIT_FOREVER, &glk);
63 if (ACPI_FAILURE(status) && status != AE_NOT_CONFIGURED) {
64 dev_err(dev, "Error could not acquire lock\n");
65 return -EIO;
66 }
67
68 pm_runtime_get_sync(dev);
69
70 /*
71 * Set idpin value as requested.
72 * Since some devices rely on firmware setting DRD_CONFIG and
73 * SW_SWITCH_EN bits to be zero for role switch,
74 * do not set these bits for those devices.
75 */
76 val = readl(data->base + DUAL_ROLE_CFG0);
77 switch (role) {
78 case USB_ROLE_NONE:
79 val |= SW_IDPIN;
80 val &= ~SW_VBUS_VALID;
81 drd_config = DRD_CONFIG_DYNAMIC;
82 break;
83 case USB_ROLE_HOST:
84 val &= ~SW_IDPIN;
85 val &= ~SW_VBUS_VALID;
86 drd_config = DRD_CONFIG_STATIC_HOST;
87 break;
88 case USB_ROLE_DEVICE:
89 val |= SW_IDPIN;
90 val |= SW_VBUS_VALID;
91 drd_config = DRD_CONFIG_STATIC_DEVICE;
92 break;
93 }
94 val |= SW_IDPIN_EN;
95 if (data->enable_sw_switch) {
96 val &= ~DRD_CONFIG_MASK;
97 val |= SW_SWITCH_EN | drd_config;
98 }
99 writel(val, data->base + DUAL_ROLE_CFG0);
100
101 acpi_release_global_lock(glk);
102
103 /* In most case it takes about 600ms to finish mode switching */
104 timeout = jiffies +
msecs_to_jiffies(DUAL_ROLE_CFG1_POLL_TIMEOUT);
105
106 /* Polling on CFG1 register to confirm mode switch.*/
107 do {
108 val = readl(data->base + DUAL_ROLE_CFG1);
109 if (!!(val & HOST_MODE) == (role == USB_ROLE_HOST)) {
110 pm_runtime_put(dev);
111 return 0;
112 }
113
114 /* Interval for polling is set to about 5 - 10 ms */
115 usleep_range(5000, 1);
116 } while (time_before(jiffies, timeout));
117
118 pm_runtime_put(dev);
119
120 dev_warn(dev, "Timeout waiting for role-switch\n");
121 return -ETIMEDOUT;
122 }
123
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH v3] usb: chipidea: add role switch class support
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc4 next-20190814] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/jun-li-nxp-com/usb-chipidea-add-role-switch-class-support/20190815-040028 config: arm-multi_v5_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=arm If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/usb/chipidea/core.o: In function `ci_hdrc_remove': >> core.c:(.text+0xec4): undefined reference to `usb_role_switch_unregister' drivers/usb/chipidea/core.o: In function `ci_hdrc_probe': core.c:(.text+0x1328): undefined reference to `usb_role_switch_unregister' core.c:(.text+0x14c8): undefined reference to `usb_role_switch_register' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v3] usb: chipidea: add role switch class support
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc4 next-20190814] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/jun-li-nxp-com/usb-chipidea-add-role-switch-class-support/20190815-040028 config: arm-multi_v5_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=arm If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/usb/chipidea/core.o: In function `ci_hdrc_remove': core.c:(.text+0xec4): undefined reference to `usb_role_switch_unregister' drivers/usb/chipidea/core.o: In function `ci_hdrc_probe': core.c:(.text+0x1328): undefined reference to `usb_role_switch_unregister' >> core.c:(.text+0x14c8): undefined reference to `usb_role_switch_register' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [Patch V6 7/8] usb: gadget: Add UDC driver for tegra XUSB device mode controller
Hi Nagarjuna,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc3 next-20190809]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Nagarjuna-Kristam/Tegra-XUSB-gadget-driver-support/20190809-042626
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:332:0,
from include/linux/kernel.h:15,
from include/linux/clk.h:13,
from drivers/usb/gadget/udc/tegra_xudc.c:9:
drivers/usb/gadget/udc/tegra_xudc.c: In function
'tegra_xudc_ep0_standard_req':
>> include/linux/dynamic_debug.h:122:52: warning: this statement may fall
>> through [-Wimplicit-fallthrough=]
#define __dynamic_func_call(id, fmt, func, ...) do { \
^
include/linux/dynamic_debug.h:143:2: note: in expansion of macro
'__dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~
include/linux/dynamic_debug.h:157:2: note: in expansion of macro
'_dynamic_func_call'
_dynamic_func_call(fmt,__dynamic_dev_dbg, \
^~
include/linux/device.h:1509:2: note: in expansion of macro 'dynamic_dev_dbg'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~
>> drivers/usb/gadget/udc/tegra_xudc.c:2394:3: note: in expansion of macro
>> 'dev_dbg'
dev_dbg(xudc->dev, "USB_REQ_SET_CONFIGURATION\n");
^~~
drivers/usb/gadget/udc/tegra_xudc.c:2400:2: note: here
default:
^~~
--
In file included from include/linux/printk.h:332:0,
from include/linux/kernel.h:15,
from include/linux/clk.h:13,
from drivers/usb//gadget/udc/tegra_xudc.c:9:
drivers/usb//gadget/udc/tegra_xudc.c: In function
'tegra_xudc_ep0_standard_req':
>> include/linux/dynamic_debug.h:122:52: warning: this statement may fall
>> through [-Wimplicit-fallthrough=]
#define __dynamic_func_call(id, fmt, func, ...) do { \
^
include/linux/dynamic_debug.h:143:2: note: in expansion of macro
'__dynamic_func_call'
__dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
^~~
include/linux/dynamic_debug.h:157:2: note: in expansion of macro
'_dynamic_func_call'
_dynamic_func_call(fmt,__dynamic_dev_dbg, \
^~
include/linux/device.h:1509:2: note: in expansion of macro 'dynamic_dev_dbg'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~
drivers/usb//gadget/udc/tegra_xudc.c:2394:3: note: in expansion of macro
'dev_dbg'
dev_dbg(xudc->dev, "USB_REQ_SET_CONFIGURATION\n");
^~~
drivers/usb//gadget/udc/tegra_xudc.c:2400:2: note: here
default:
^~~
vim +/dev_dbg +2394 drivers/usb/gadget/udc/tegra_xudc.c
2365
2366 static int tegra_xudc_ep0_standard_req(struct tegra_xudc *xudc,
2367struct usb_ctrlrequest *ctrl)
2368 {
2369 int ret;
2370
2371 switch (ctrl->bRequest) {
2372 case USB_REQ_GET_STATUS:
2373 dev_dbg(xudc->dev, "USB_REQ_GET_STATUS\n");
2374 ret = tegra_xudc_ep0_get_status(xudc, ctrl);
2375 break;
2376 case USB_REQ_SET_ADDRESS:
2377 dev_dbg(xudc->dev, "USB_REQ_SET_ADDRESS\n");
2378 ret = tegra_xudc_ep0_set_address(xudc, ctrl);
2379 break;
2380 case USB_REQ_SET_SEL:
2381 dev_dbg(xudc->dev, "USB_REQ_SET_SEL\n");
2382 ret = tegra_xudc_ep0_set_sel(xudc, ctrl);
2383 break;
2384 case USB_REQ_SET_ISOCH_DELAY:
2385 dev_dbg(xudc->dev, "USB_REQ_SET_ISOCH_DELAY\n");
2386 ret = tegra_xudc_ep0_set_isoch_delay(xudc, ctrl);
2387 break;
2388 case USB_REQ_CLEAR_FEATURE:
2389 case USB_REQ_SET_FEATURE:
2390 dev_dbg(xudc->dev, "USB_REQ_CLEAR/SET_FEATURE\n");
2391
[balbi-usb:testing/next 2/13] drivers/usb/phy/phy-tahvo.c:434:4: error: 'struct device_driver' has no member named 'dev_groups'; did you mean 'groups'?
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/balbi/usb.git
testing/next
head: d06a2c3f683a591efce9d02b2b60ef346df5ae02
commit: 2a714ea6d90d9d1b510ba424652a2e3dfd547267 [2/13] USB: phy: tahvo:
convert platform driver to use dev_groups
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 2a714ea6d90d9d1b510ba424652a2e3dfd547267
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
>> drivers/usb/phy/phy-tahvo.c:434:4: error: 'struct device_driver' has no
>> member named 'dev_groups'; did you mean 'groups'?
.dev_groups = tahvo_groups,
^~
groups
>> drivers/usb/phy/phy-tahvo.c:434:17: error: initialization from incompatible
>> pointer type [-Werror=incompatible-pointer-types]
.dev_groups = tahvo_groups,
^~~~
drivers/usb/phy/phy-tahvo.c:434:17: note: (near initialization for
'tahvo_usb_driver.driver.bus')
cc1: some warnings being treated as errors
vim +434 drivers/usb/phy/phy-tahvo.c
428
429 static struct platform_driver tahvo_usb_driver = {
430 .probe = tahvo_usb_probe,
431 .remove = tahvo_usb_remove,
432 .driver = {
433 .name = "tahvo-usb",
> 434 .dev_groups = tahvo_groups,
435 },
436 };
437 module_platform_driver(tahvo_usb_driver);
438
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH v2 2/2] usb: chipidea: add role switch class support
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc3 next-20190807]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/jun-li-nxp-com/usb-chipidea-replace-ci_role-with-usb_role/20190807-185922
config: x86_64-randconfig-c002-201931 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
ld: drivers/usb/chipidea/core.o: in function `ci_hdrc_remove':
>> drivers/usb/chipidea/core.c:1196: undefined reference to
>> `usb_role_switch_unregister'
ld: drivers/usb/chipidea/core.o: in function `ci_hdrc_probe':
>> drivers/usb/chipidea/core.c:1146: undefined reference to
>> `usb_role_switch_register'
vim +1196 drivers/usb/chipidea/core.c
986
987 static int ci_hdrc_probe(struct platform_device *pdev)
988 {
989 struct device *dev = &pdev->dev;
990 struct ci_hdrc *ci;
991 struct resource *res;
992 void __iomem*base;
993 int ret;
994 enum usb_dr_mode dr_mode;
995
996 if (!dev_get_platdata(dev)) {
997 dev_err(dev, "platform data missing\n");
998 return -ENODEV;
999 }
1000
1001 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
1002 base = devm_ioremap_resource(dev, res);
1003 if (IS_ERR(base))
1004 return PTR_ERR(base);
1005
1006 ci = devm_kzalloc(dev, sizeof(*ci), GFP_KERNEL);
1007 if (!ci)
1008 return -ENOMEM;
1009
1010 spin_lock_init(&ci->lock);
1011 ci->dev = dev;
1012 ci->platdata = dev_get_platdata(dev);
1013 ci->imx28_write_fix = !!(ci->platdata->flags &
1014 CI_HDRC_IMX28_WRITE_FIX);
1015 ci->supports_runtime_pm = !!(ci->platdata->flags &
1016 CI_HDRC_SUPPORTS_RUNTIME_PM);
1017 platform_set_drvdata(pdev, ci);
1018
1019 ret = hw_device_init(ci, base);
1020 if (ret < 0) {
1021 dev_err(dev, "can't initialize hardware\n");
1022 return -ENODEV;
1023 }
1024
1025 ret = ci_ulpi_init(ci);
1026 if (ret)
1027 return ret;
1028
1029 if (ci->platdata->phy) {
1030 ci->phy = ci->platdata->phy;
1031 } else if (ci->platdata->usb_phy) {
1032 ci->usb_phy = ci->platdata->usb_phy;
1033 } else {
1034 /* Look for a generic PHY first */
1035 ci->phy = devm_phy_get(dev->parent, "usb-phy");
1036
1037 if (PTR_ERR(ci->phy) == -EPROBE_DEFER) {
1038 ret = -EPROBE_DEFER;
1039 goto ulpi_exit;
1040 } else if (IS_ERR(ci->phy)) {
1041 ci->phy = NULL;
1042 }
1043
1044 /* Look for a legacy USB PHY from device-tree next */
1045 if (!ci->phy) {
1046 ci->usb_phy =
devm_usb_get_phy_by_phandle(dev->parent,
1047
"phys", 0);
1048
1049 if (PTR_ERR(ci->usb_phy) == -EPROBE_DEFER) {
1050 ret = -EPROBE_DEFER;
1051 goto ulpi_exit;
1052 } else if (IS_ERR(ci->usb_phy)) {
1053 ci->usb_phy = NULL;
1054 }
1055 }
1056
1057 /* Look for any registered legacy USB PHY as last
resort */
1058 if (!ci->phy && !ci->usb_phy) {
1059 ci->usb_phy = devm_usb_get_phy(dev->parent,
1060
USB_PHY_TYPE_USB2);
1061
1062 if (PTR_ERR(ci->usb_phy) == -EPROBE_DEFER) {
1063 ret = -EPROBE_DEFER;
1064 goto ulpi_exit;
1065 } else if (IS_ERR(ci->usb_phy)) {
1066 ci->usb_phy = NULL;
1067 }
1068 }
1069
1070 /* No USB PHY was found
Re: [PATCH v2 2/2] usb: chipidea: add role switch class support
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc3 next-20190807] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/jun-li-nxp-com/usb-chipidea-replace-ci_role-with-usb_role/20190807-185922 config: arm-imx_v6_v7_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=arm If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/usb/chipidea/core.o: In function `ci_hdrc_remove': >> core.c:(.text+0x900): undefined reference to `usb_role_switch_unregister' drivers/usb/chipidea/core.o: In function `ci_hdrc_probe': >> core.c:(.text+0x152c): undefined reference to `usb_role_switch_register' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] usb: storage: sddr55: Fix a possible null-pointer dereference in sddr55_transport()
Hi Jia-Ju,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc2 next-20190729]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jia-Ju-Bai/usb-storage-sddr55-Fix-a-possible-null-pointer-dereference-in-sddr55_transport/20190729-204126
config: x86_64-randconfig-s0-07291935 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10) 7.4.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers/usb/storage/sddr55.c: In function 'sddr55_transport':
>> drivers/usb/storage/sddr55.c:952:4: warning: 'pba' may be used uninitialized
>> in this function [-Wmaybe-uninitialized]
usb_stor_dbg(us, "WRITE_10: write block %04X (LBA %04X) page %01X pages
%d\n",
^~
pba, lba, page, pages);
~~
vim +/pba +952 drivers/usb/storage/sddr55.c
^1da177e4c3f415 Linus Torvalds 2005-04-16 769
^1da177e4c3f415 Linus Torvalds 2005-04-16 770
^1da177e4c3f415 Linus Torvalds 2005-04-16 771 /*
^1da177e4c3f415 Linus Torvalds 2005-04-16 772 * Transport for the Sandisk
SDDR-55
^1da177e4c3f415 Linus Torvalds 2005-04-16 773 */
70fcc0050733a7c Alan Stern 2009-02-12 774 static int
sddr55_transport(struct scsi_cmnd *srb, struct us_data *us)
^1da177e4c3f415 Linus Torvalds 2005-04-16 775 {
^1da177e4c3f415 Linus Torvalds 2005-04-16 776 int result;
^1da177e4c3f415 Linus Torvalds 2005-04-16 777 static unsigned char
inquiry_response[8] = {
^1da177e4c3f415 Linus Torvalds 2005-04-16 778 0x00, 0x80,
0x00, 0x02, 0x1F, 0x00, 0x00, 0x00
^1da177e4c3f415 Linus Torvalds 2005-04-16 779 };
^1da177e4c3f415 Linus Torvalds 2005-04-16 780 // write-protected for
now, no block descriptor support
^1da177e4c3f415 Linus Torvalds 2005-04-16 781 static unsigned char
mode_page_01[20] = {
^1da177e4c3f415 Linus Torvalds 2005-04-16 782 0x0, 0x12,
0x00, 0x80, 0x0, 0x0, 0x0, 0x0,
^1da177e4c3f415 Linus Torvalds 2005-04-16 783 0x01, 0x0A,
^1da177e4c3f415 Linus Torvalds 2005-04-16 784 0x00, 0x00,
0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00
^1da177e4c3f415 Linus Torvalds 2005-04-16 785 };
^1da177e4c3f415 Linus Torvalds 2005-04-16 786 unsigned char *ptr =
us->iobuf;
^1da177e4c3f415 Linus Torvalds 2005-04-16 787 unsigned long capacity;
^1da177e4c3f415 Linus Torvalds 2005-04-16 788 unsigned int lba;
^1da177e4c3f415 Linus Torvalds 2005-04-16 789 unsigned int pba;
^1da177e4c3f415 Linus Torvalds 2005-04-16 790 unsigned int page;
^1da177e4c3f415 Linus Torvalds 2005-04-16 791 unsigned short pages;
^1da177e4c3f415 Linus Torvalds 2005-04-16 792 struct sddr55_card_info
*info;
^1da177e4c3f415 Linus Torvalds 2005-04-16 793
^1da177e4c3f415 Linus Torvalds 2005-04-16 794 if (!us->extra) {
887c2560b6ceb5f Oliver Neukum 2006-01-08 795 us->extra =
kzalloc(
^1da177e4c3f415 Linus Torvalds 2005-04-16 796
sizeof(struct sddr55_card_info), GFP_NOIO);
^1da177e4c3f415 Linus Torvalds 2005-04-16 797 if (!us->extra)
^1da177e4c3f415 Linus Torvalds 2005-04-16 798 return
USB_STOR_TRANSPORT_ERROR;
^1da177e4c3f415 Linus Torvalds 2005-04-16 799
us->extra_destructor = sddr55_card_info_destructor;
^1da177e4c3f415 Linus Torvalds 2005-04-16 800 }
^1da177e4c3f415 Linus Torvalds 2005-04-16 801
^1da177e4c3f415 Linus Torvalds 2005-04-16 802 info = (struct
sddr55_card_info *)(us->extra);
^1da177e4c3f415 Linus Torvalds 2005-04-16 803
^1da177e4c3f415 Linus Torvalds 2005-04-16 804 if (srb->cmnd[0] ==
REQUEST_SENSE) {
191648d03d20229 Joe Perches2013-04-19 805
usb_stor_dbg(us, "request sense %02x/%02x/%02x\n",
191648d03d20229 Joe Perches2013-04-19 806
info->sense_data[2],
191648d03d20229 Joe Perches2013-04-19 807
info->sense_data[12],
191648d03d20229 Joe Perches2013-04-19 808
info->sense_data[13]);
^1da177e4c3f415 Linus Torvalds 2005-04-16 809
^1da177e4c3f415 Linus Torvalds 2005-04-16 810 memcpy (ptr,
info->sense_data, sizeof info->sense_data);
^1da177e4c3f415 Linus Torvalds 2
[balbi-usb:testing/next 33/43] trace.c:undefined reference to `usb_decode_ctrl'
tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: b2357839c56ab7d06bcd4e866ebc2d0e2b7997f3 commit: 3db1b636c07e15ff7410db782832dc2e7ffd2bce [33/43] usb:gadget Separated decoding functions from dwc3 driver. config: arm-multi_v7_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 3db1b636c07e15ff7410db782832dc2e7ffd2bce # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=arm If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): drivers/usb/dwc3/trace.o: In function `trace_raw_output_dwc3_log_ctrl': >> trace.c:(.text+0x11dc): undefined reference to `usb_decode_ctrl' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[usb:usb-testing 46/46] drivers/usb//misc/adutux.c:375:4: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t {aka unsigned int}'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
head: f1ac9f310d6d883b3551f4cb948eb441c780b59d
commit: f1ac9f310d6d883b3551f4cb948eb441c780b59d [46/46] usb: clean up some of
the computations in adu_read
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout f1ac9f310d6d883b3551f4cb948eb441c780b59d
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>):
In file included from include/linux/printk.h:332:0,
from include/linux/kernel.h:15,
from drivers/usb//misc/adutux.c:19:
drivers/usb//misc/adutux.c: In function 'adu_read':
>> drivers/usb//misc/adutux.c:375:4: warning: format '%lu' expects argument of
>> type 'long unsigned int', but argument 5 has type 'size_t {aka unsigned
>> int}' [-Wformat=]
"%s : while, data_in_secondary=%lu, status=%d\n",
^
include/linux/dynamic_debug.h:125:15: note: in definition of macro
'__dynamic_func_call'
func(&id, ##__VA_ARGS__); \
^~~
include/linux/dynamic_debug.h:157:2: note: in expansion of macro
'_dynamic_func_call'
_dynamic_func_call(fmt,__dynamic_dev_dbg, \
^~
include/linux/device.h:1494:2: note: in expansion of macro 'dynamic_dev_dbg'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~
include/linux/device.h:1494:23: note: in expansion of macro 'dev_fmt'
dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
^~~
drivers/usb//misc/adutux.c:374:3: note: in expansion of macro 'dev_dbg'
dev_dbg(&dev->udev->dev,
^~~
vim +375 drivers/usb//misc/adutux.c
339
340 static ssize_t adu_read(struct file *file, __user char *buffer, size_t
count,
341 loff_t *ppos)
342 {
343 struct adu_device *dev;
344 size_t bytes_read = 0;
345 size_t bytes_to_read = count;
346 int retval = 0;
347 int timeout = 0;
348 int should_submit = 0;
349 unsigned long flags;
350 DECLARE_WAITQUEUE(wait, current);
351
352 dev = file->private_data;
353 if (mutex_lock_interruptible(&dev->mtx))
354 return -ERESTARTSYS;
355
356 /* verify that the device wasn't unplugged */
357 if (dev->udev == NULL) {
358 retval = -ENODEV;
359 pr_err("No device or device unplugged %d\n", retval);
360 goto exit;
361 }
362
363 /* verify that some data was requested */
364 if (count == 0) {
365 dev_dbg(&dev->udev->dev, "%s : read request of 0
bytes\n",
366 __func__);
367 goto exit;
368 }
369
370 timeout = COMMAND_TIMEOUT;
371 dev_dbg(&dev->udev->dev, "%s : about to start looping\n",
__func__);
372 while (bytes_to_read) {
373 size_t data_in_secondary = dev->secondary_tail -
dev->secondary_head;
374 dev_dbg(&dev->udev->dev,
> 375 "%s : while, data_in_secondary=%lu,
> status=%d\n",
376 __func__, data_in_secondary,
377 dev->interrupt_in_urb->status);
378
379 if (data_in_secondary) {
380 /* drain secondary buffer */
381 size_t amount = min(bytes_to_read,
data_in_secondary);
382 if (copy_to_user(buffer,
dev->read_buffer_secondary+dev->secondary_head, amount)) {
383 retval = -EFAULT;
384 goto exit;
385 }
386 dev->secondary_head += amount;
387 bytes_read += amount;
388 bytes_to_read -= amount;
389 } else {
390 /* we check the primary buffer */
391 spin_lock_irqsave (&dev->buflock, flags);
392 if (dev->read_buffer_length) {
393 /* we secure access to the primary */
394
[usb:usb-linus 12/16] drivers/usb/host/xhci-ring.c:676:19: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka unsigned int}'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-linus
head: f7fac17ca925faa03fc5eb854c081a24075f8bad
commit: 597c56e372dab2c7f79b8d700aad3a5deebf9d1b [12/16] xhci: update bounce
buffer with correct sg num
config: i386-randconfig-x018-201920 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 597c56e372dab2c7f79b8d700aad3a5deebf9d1b
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All warnings (new ones prefixed by >>):
In file included from include/linux/dma-mapping.h:7:0,
from drivers/usb/host/xhci-ring.c:57:
drivers/usb/host/xhci-ring.c: In function 'xhci_unmap_td_bounce_buffer':
>> drivers/usb/host/xhci-ring.c:676:19: warning: format '%ld' expects argument
>> of type 'long int', but argument 3 has type 'size_t {aka unsigned int}'
>> [-Wformat=]
xhci_warn(xhci, "WARN Wrong bounce buffer read length: %ld != %d\n",
^
include/linux/device.h:1400:22: note: in definition of macro 'dev_fmt'
#define dev_fmt(fmt) fmt
^~~
>> drivers/usb/host/xhci.h:1920:2: note: in expansion of macro 'dev_warn'
dev_warn(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
^~~~
>> drivers/usb/host/xhci-ring.c:676:3: note: in expansion of macro 'xhci_warn'
xhci_warn(xhci, "WARN Wrong bounce buffer read length: %ld != %d\n",
^
drivers/usb/host/xhci-ring.c: In function 'xhci_align_td':
drivers/usb/host/xhci-ring.c:3169:5: warning: format '%ld' expects argument
of type 'long int', but argument 3 has type 'size_t {aka unsigned int}'
[-Wformat=]
"WARN Wrong bounce buffer write length: %ld != %d\n",
^
include/linux/device.h:1400:22: note: in definition of macro 'dev_fmt'
#define dev_fmt(fmt) fmt
^~~
>> drivers/usb/host/xhci.h:1920:2: note: in expansion of macro 'dev_warn'
dev_warn(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
^~~~
drivers/usb/host/xhci-ring.c:3168:4: note: in expansion of macro 'xhci_warn'
xhci_warn(xhci,
^
vim +676 drivers/usb/host/xhci-ring.c
652
653 static void xhci_unmap_td_bounce_buffer(struct xhci_hcd *xhci,
654 struct xhci_ring *ring, struct xhci_td *td)
655 {
656 struct device *dev = xhci_to_hcd(xhci)->self.controller;
657 struct xhci_segment *seg = td->bounce_seg;
658 struct urb *urb = td->urb;
659 size_t len;
660
661 if (!ring || !seg || !urb)
662 return;
663
664 if (usb_urb_dir_out(urb)) {
665 dma_unmap_single(dev, seg->bounce_dma,
ring->bounce_buf_len,
666 DMA_TO_DEVICE);
667 return;
668 }
669
670 dma_unmap_single(dev, seg->bounce_dma, ring->bounce_buf_len,
671 DMA_FROM_DEVICE);
672 /* for in tranfers we need to copy the data from bounce to sg */
673 len = sg_pcopy_from_buffer(urb->sg, urb->num_sgs,
seg->bounce_buf,
674 seg->bounce_len, seg->bounce_offs);
675 if (len != seg->bounce_len)
> 676 xhci_warn(xhci, "WARN Wrong bounce buffer read length:
> %ld != %d\n",
677 len, seg->bounce_len);
678 seg->bounce_len = 0;
679 seg->bounce_offs = 0;
680 }
681
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[usb:usb-linus 3/10] drivers/media//usb/siano/smsusb.c:447:37: warning: 'in_maxp' may be used uninitialized in this function
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-linus
head: 53c7b63f797c96a30c21dd3b781fafaae096a12b
commit: 31e0456de5be379b10fea0fa94a681057114a96e [3/10] media: usb: siano: Fix
general protection fault in smsusb
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 8.1.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 31e0456de5be379b10fea0fa94a681057114a96e
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
drivers/media//usb/siano/smsusb.c: In function 'smsusb_init_device':
>> drivers/media//usb/siano/smsusb.c:447:37: warning: 'in_maxp' may be used
>> uninitialized in this function [-Wmaybe-uninitialized]
dev->response_alignment = in_maxp - sizeof(struct sms_msg_hdr);
^~~~
vim +/in_maxp +447 drivers/media//usb/siano/smsusb.c
396
397 static int smsusb_init_device(struct usb_interface *intf, int board_id)
398 {
399 struct smsdevice_params_t params;
400 struct smsusb_device_t *dev;
401 void *mdev;
402 int i, rc;
403 int in_maxp;
404
405 /* create device object */
406 dev = kzalloc(sizeof(struct smsusb_device_t), GFP_KERNEL);
407 if (!dev)
408 return -ENOMEM;
409
410 memset(¶ms, 0, sizeof(params));
411 usb_set_intfdata(intf, dev);
412 dev->udev = interface_to_usbdev(intf);
413 dev->state = SMSUSB_DISCONNECTED;
414
415 for (i = 0; i < intf->cur_altsetting->desc.bNumEndpoints; i++) {
416 struct usb_endpoint_descriptor *desc =
417 &intf->cur_altsetting->endpoint[i].desc;
418
419 if (desc->bEndpointAddress & USB_DIR_IN) {
420 dev->in_ep = desc->bEndpointAddress;
421 in_maxp = usb_endpoint_maxp(desc);
422 } else {
423 dev->out_ep = desc->bEndpointAddress;
424 }
425 }
426
427 pr_debug("in_ep = %02x, out_ep = %02x\n", dev->in_ep,
dev->out_ep);
428 if (!dev->in_ep || !dev->out_ep) { /* Missing endpoints? */
429 smsusb_term_device(intf);
430 return -ENODEV;
431 }
432
433 params.device_type = sms_get_board(board_id)->type;
434
435 switch (params.device_type) {
436 case SMS_STELLAR:
437 dev->buffer_size = USB1_BUFFER_SIZE;
438
439 params.setmode_handler = smsusb1_setmode;
440 params.detectmode_handler = smsusb1_detectmode;
441 break;
442 case SMS_UNKNOWN_TYPE:
443 pr_err("Unspecified sms device type!\n");
444 /* fall-thru */
445 default:
446 dev->buffer_size = USB2_BUFFER_SIZE;
> 447 dev->response_alignment = in_maxp - sizeof(struct
> sms_msg_hdr);
448
449 params.flags |= SMS_DEVICE_FAMILY2;
450 break;
451 }
452
453 params.device = &dev->udev->dev;
454 params.usb_device = dev->udev;
455 params.buffer_size = dev->buffer_size;
456 params.num_buffers = MAX_BUFFERS;
457 params.sendrequest_handler = smsusb_sendrequest;
458 params.context = dev;
459 usb_make_path(dev->udev, params.devpath,
sizeof(params.devpath));
460
461 mdev = siano_media_device_register(dev, board_id);
462
463 /* register in smscore */
464 rc = smscore_register_device(¶ms, &dev->coredev, 0, mdev);
465 if (rc < 0) {
466 pr_err("smscore_register_device(...) failed, rc %d\n",
rc);
467 smsusb_term_device(intf);
468 #ifdef CONFIG_MEDIA_CONTROLLER_DVB
469 media_device_unregister(mdev);
470 #endif
471 kfree(mdev);
472 return rc;
473 }
474
475 smscore_set_board_id(dev->coredev, board_id);
476
477 dev->coredev->is_usb_device = true;
478
[usb:usb-next 54/62] drivers/usb/misc/usb251xb.c:248:50: error: dereferencing pointer to incomplete type 'struct gpio_chip'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
head: a4d6a2989dc3f2f2bcd25ca53dd187a1de68ffac
commit: 6e3c8beb4f92a18a65e521cc5fe75874b6e2c860 [54/62] usb: usb251xb: Lock
i2c-bus segment the hub resides
config: x86_64-randconfig-s5-04260238 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 6e3c8beb4f92a18a65e521cc5fe75874b6e2c860
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/usb/misc/usb251xb.c: In function 'usb251x_check_gpio_chip':
>> drivers/usb/misc/usb251xb.c:248:50: error: dereferencing pointer to
>> incomplete type 'struct gpio_chip'
ret = usb251xb_check_dev_children(&adap->dev, gc->parent);
^~
vim +248 drivers/usb/misc/usb251xb.c
235
236 static int usb251x_check_gpio_chip(struct usb251xb *hub)
237 {
238 struct gpio_chip *gc = gpiod_to_chip(hub->gpio_reset);
239 struct i2c_adapter *adap = hub->i2c->adapter;
240 int ret;
241
242 if (!hub->gpio_reset)
243 return 0;
244
245 if (!gc)
246 return -EINVAL;
247
> 248 ret = usb251xb_check_dev_children(&adap->dev, gc->parent);
249 if (ret) {
250 dev_err(hub->dev, "Reset GPIO chip is at the same
i2c-bus\n");
251 return -EINVAL;
252 }
253
254 return 0;
255 }
256
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[balbi-usb:testing/next 19/42] drivers/usb/dwc2/core_intr.c:448:25: error: 'struct dwc2_hsotg' has no member named 'phy_reset_work'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
testing/next
head: 2e3cfcbbb1403feeac5949f32dcd2724de3ff40c
commit: a0a493835f9a2e4c690c41145def88223997db2b [19/42] usb: dwc2: optionally
assert phy reset when waking up
config: x86_64-randconfig-x000-201916 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout a0a493835f9a2e4c690c41145def88223997db2b
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot
All errors (new ones prefixed by >>):
drivers/usb/dwc2/core_intr.c: In function 'dwc2_handle_wakeup_detected_intr':
>> drivers/usb/dwc2/core_intr.c:448:25: error: 'struct dwc2_hsotg' has no
>> member named 'phy_reset_work'
schedule_work(&hsotg->phy_reset_work);
^~
vim +448 drivers/usb/dwc2/core_intr.c
388
389 /*
390 * This interrupt indicates that the DWC_otg controller has detected a
391 * resume or remote wakeup sequence. If the DWC_otg controller is in
392 * low power mode, the handler must brings the controller out of low
393 * power mode. The controller automatically begins resume signaling.
394 * The handler schedules a time to stop resume signaling.
395 */
396 static void dwc2_handle_wakeup_detected_intr(struct dwc2_hsotg *hsotg)
397 {
398 int ret;
399
400 /* Clear interrupt */
401 dwc2_writel(hsotg, GINTSTS_WKUPINT, GINTSTS);
402
403 dev_dbg(hsotg->dev, "++Resume or Remote Wakeup Detected
Interrupt++\n");
404 dev_dbg(hsotg->dev, "%s lxstate = %d\n", __func__,
hsotg->lx_state);
405
406 if (hsotg->lx_state == DWC2_L1) {
407 dwc2_wakeup_from_lpm_l1(hsotg);
408 return;
409 }
410
411 if (dwc2_is_device_mode(hsotg)) {
412 dev_dbg(hsotg->dev, "DSTS=0x%0x\n",
413 dwc2_readl(hsotg, DSTS));
414 if (hsotg->lx_state == DWC2_L2) {
415 u32 dctl = dwc2_readl(hsotg, DCTL);
416
417 /* Clear Remote Wakeup Signaling */
418 dctl &= ~DCTL_RMTWKUPSIG;
419 dwc2_writel(hsotg, dctl, DCTL);
420 ret = dwc2_exit_partial_power_down(hsotg, true);
421 if (ret && (ret != -ENOTSUPP))
422 dev_err(hsotg->dev, "exit power_down
failed\n");
423
424 call_gadget(hsotg, resume);
425 }
426 /* Change to L0 state */
427 hsotg->lx_state = DWC2_L0;
428 } else {
429 if (hsotg->params.power_down)
430 return;
431
432 if (hsotg->lx_state != DWC2_L1) {
433 u32 pcgcctl = dwc2_readl(hsotg, PCGCTL);
434
435 /* Restart the Phy Clock */
436 pcgcctl &= ~PCGCTL_STOPPCLK;
437 dwc2_writel(hsotg, pcgcctl, PCGCTL);
438
439 /*
440 * If we've got this quirk then the PHY is
stuck upon
441 * wakeup. Assert reset. This will propagate
out and
442 * eventually we'll re-enumerate the device.
Not great
443 * but the best we can do. We can't call
phy_reset()
444 * at interrupt time but there's no hurry, so
we'll
445 * schedule it for later.
446 */
447 if (hsotg->reset_phy_on_wake)
> 448 schedule_work(&hsotg->phy_reset_work);
449
450 mod_timer(&hsotg->wkp_timer,
451jiffies + msecs_to_jiffies(71));
452 } else {
453 /* Change to L0 state */
454 hsotg->lx_state = DWC2_L0;
455 }
456 }
457 }
458
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH v2 7/7] usb: typec: Add driver for NVIDIA Alt Modes
Hi Heikki, I love your patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on v5.1-rc5 next-20190415] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Heikki-Krogerus/usb-typec-Remaining-changes-for-v5-2/20190416-034644 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: x86_64-randconfig-u0-04160432 (attached as .config) compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >> drivers/usb/typec/altmodes/nvidia.c:10:25: fatal error: displayport.h: No >> such file or directory compilation terminated. vim +10 drivers/usb/typec/altmodes/nvidia.c > 10 #include "displayport.h" 11 --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH 2/4] usb: typec: ucsi: ccg: add firmware flashing support
Hi Heikki,
I love your patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v5.1-rc4 next-20190410]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Heikki-Krogerus/usb-typec-ucsi-Remaining-changes-for-v5-2/20190410-221455
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
sparse warnings: (new ones prefixed by >>)
drivers/usb/typec/ucsi/ucsi_ccg.c:212:24: sparse: expression using
sizeof(void)
drivers/usb/typec/ucsi/ucsi_ccg.c:212:24: sparse: expression using
sizeof(void)
>> drivers/usb/typec/ucsi/ucsi_ccg.c:690:16: sparse: restricted __le16 degrades
>> to integer
drivers/usb/typec/ucsi/ucsi_ccg.c:698:24: sparse: restricted __le16 degrades
to integer
drivers/usb/typec/ucsi/ucsi_ccg.c:735:26: sparse: restricted __le16 degrades
to integer
drivers/usb/typec/ucsi/ucsi_ccg.c:737:33: sparse: restricted __le16 degrades
to integer
drivers/usb/typec/ucsi/ucsi_ccg.c:777:37: sparse: restricted __le16 degrades
to integer
vim +690 drivers/usb/typec/ucsi/ucsi_ccg.c
680
681 static bool ccg_check_vendor_version(struct ucsi_ccg *uc,
682 struct version_format *app,
683 struct fw_config_table *fw_cfg)
684 {
685 struct device *dev = uc->dev;
686
687 /* Check if the fw build is for supported vendors.
688 * Add all supported vendors here.
689 */
> 690 if (app->build != (('n' << 8) | 'v')) {
691 dev_info(dev, "current fw is not from supported
vendor\n");
692 return false;
693 }
694
695 /* Check if the new fw build is for supported vendors
696 * Add all supported vendors here.
697 */
698 if (fw_cfg->app.build != (('n' << 8) | 'v')) {
699 dev_info(dev, "new fw is not from supported vendor\n");
700 return false;
701 }
702 return true;
703 }
704
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Re: [PATCH 2/5] usb: dwc2: Move phy init into core
Hi Jules,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v5.1-rc3 next-20190402]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jules-Maselbas/usb-dwc2-Improve-gadget-phy-init/20190403-103251
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: i386-randconfig-l1-04030817 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/usb/dwc2/hcd.c: In function 'dwc2_core_host_init':
>> drivers/usb/dwc2/hcd.c:2185:2: error: implicit declaration of function
>> 'dwc2_init_fs_ls_pclk_sel' [-Werror=implicit-function-declaration]
dwc2_init_fs_ls_pclk_sel(hsotg);
^
cc1: some warnings being treated as errors
vim +/dwc2_init_fs_ls_pclk_sel +2185 drivers/usb/dwc2/hcd.c
b02038fa John Youn 2016-02-23 2152
b02038fa John Youn 2016-02-23 2153 /**
b02038fa John Youn 2016-02-23 2154 * dwc2_core_host_init() -
Initializes the DWC_otg controller registers for
b02038fa John Youn 2016-02-23 2155 * Host mode
b02038fa John Youn 2016-02-23 2156 *
b02038fa John Youn 2016-02-23 2157 * @hsotg: Programming view of
DWC_otg controller
b02038fa John Youn 2016-02-23 2158 *
b02038fa John Youn 2016-02-23 2159 * This function flushes the Tx
and Rx FIFOs and flushes any entries in the
b02038fa John Youn 2016-02-23 2160 * request queues. Host channels
are reset to ensure that they are ready for
b02038fa John Youn 2016-02-23 2161 * performing transfers.
b02038fa John Youn 2016-02-23 2162 */
b02038fa John Youn 2016-02-23 2163 static void
dwc2_core_host_init(struct dwc2_hsotg *hsotg)
b02038fa John Youn 2016-02-23 2164 {
92a8dd26 Minas Harutyunyan 2018-01-19 2165 u32 hcfg, hfir, otgctl, usbcfg;
b02038fa John Youn 2016-02-23 2166
b02038fa John Youn 2016-02-23 2167 dev_dbg(hsotg->dev, "%s(%p)\n",
__func__, hsotg);
b02038fa John Youn 2016-02-23 2168
92a8dd26 Minas Harutyunyan 2018-01-19 2169 /* Set HS/FS Timeout
Calibration to 7 (max available value).
92a8dd26 Minas Harutyunyan 2018-01-19 2170 * The number of PHY clocks
that the application programs in
92a8dd26 Minas Harutyunyan 2018-01-19 2171 * this field is added to the
high/full speed interpacket timeout
92a8dd26 Minas Harutyunyan 2018-01-19 2172 * duration in the core to
account for any additional delays
92a8dd26 Minas Harutyunyan 2018-01-19 2173 * introduced by the PHY. This
can be required, because the delay
92a8dd26 Minas Harutyunyan 2018-01-19 2174 * introduced by the PHY in
generating the linestate condition
92a8dd26 Minas Harutyunyan 2018-01-19 2175 * can vary from one PHY to
another.
92a8dd26 Minas Harutyunyan 2018-01-19 2176 */
f25c42b8 Gevorg Sahakyan 2018-07-26 2177 usbcfg = dwc2_readl(hsotg,
GUSBCFG);
92a8dd26 Minas Harutyunyan 2018-01-19 2178 usbcfg |= GUSBCFG_TOUTCAL(7);
f25c42b8 Gevorg Sahakyan 2018-07-26 2179 dwc2_writel(hsotg, usbcfg,
GUSBCFG);
92a8dd26 Minas Harutyunyan 2018-01-19 2180
b02038fa John Youn 2016-02-23 2181 /* Restart the Phy Clock */
f25c42b8 Gevorg Sahakyan 2018-07-26 2182 dwc2_writel(hsotg, 0, PCGCTL);
b02038fa John Youn 2016-02-23 2183
b02038fa John Youn 2016-02-23 2184 /* Initialize Host
Configuration Register */
b02038fa John Youn 2016-02-23 @2185 dwc2_init_fs_ls_pclk_sel(hsotg);
38e9002b Vardan Mikayelyan 2016-11-14 2186 if (hsotg->params.speed ==
DWC2_SPEED_PARAM_FULL ||
38e9002b Vardan Mikayelyan 2016-11-14 2187 hsotg->params.speed ==
DWC2_SPEED_PARAM_LOW) {
f25c42b8 Gevorg Sahakyan 2018-07-26 2188 hcfg =
dwc2_readl(hsotg, HCFG);
b02038fa John Youn 2016-02-23 2189 hcfg |= HCFG_FSLSSUPP;
f25c42b8 Gevorg Sahakyan 2018-07-26 2190 dwc2_writel(hsotg,
hcfg, HCFG);
b02038fa John Youn 2016-02-23 2191 }
b02038fa John Youn 2016-02-23 2192
b02038fa John Youn 2016-02-23 2193 /*
b02038fa John Youn 2016-02-23 2194 * This bit allows dynamic
reloading of the HFIR register during
b02038fa John Youn 2016-02-23 2195 * runtime. This bit needs to
be programmed during initial configuration
b02038fa John Youn 2016-02-23 2196 * and its value must not be
changed during runtime.
b02038fa John Youn 2016-02-23 2197 */
95832c00 John Youn 2017-01-23 2198 if (hsotg->params.reload_ctl) {
f25c42b8 Gevorg Sahakyan 2018-07-26 2199 hfir =
dwc2_readl(hsotg, HFIR);
b02038fa John Youn 2016-02-23 2200 hf
Re: [PATCH 2/5] usb: dwc2: Move phy init into core
Hi Jules,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v5.1-rc3 next-20190402]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jules-Maselbas/usb-dwc2-Improve-gadget-phy-init/20190403-103251
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: i386-randconfig-x017-201913 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/usb//dwc2/hcd.c: In function 'dwc2_core_host_init':
>> drivers/usb//dwc2/hcd.c:2185:2: error: implicit declaration of function
>> 'dwc2_init_fs_ls_pclk_sel'; did you mean 'dwc2_init_params'?
>> [-Werror=implicit-function-declaration]
dwc2_init_fs_ls_pclk_sel(hsotg);
^~~~
dwc2_init_params
cc1: some warnings being treated as errors
vim +2185 drivers/usb//dwc2/hcd.c
b02038fa John Youn 2016-02-23 2152
b02038fa John Youn 2016-02-23 2153 /**
b02038fa John Youn 2016-02-23 2154 * dwc2_core_host_init() -
Initializes the DWC_otg controller registers for
b02038fa John Youn 2016-02-23 2155 * Host mode
b02038fa John Youn 2016-02-23 2156 *
b02038fa John Youn 2016-02-23 2157 * @hsotg: Programming view of
DWC_otg controller
b02038fa John Youn 2016-02-23 2158 *
b02038fa John Youn 2016-02-23 2159 * This function flushes the Tx
and Rx FIFOs and flushes any entries in the
b02038fa John Youn 2016-02-23 2160 * request queues. Host channels
are reset to ensure that they are ready for
b02038fa John Youn 2016-02-23 2161 * performing transfers.
b02038fa John Youn 2016-02-23 2162 */
b02038fa John Youn 2016-02-23 2163 static void
dwc2_core_host_init(struct dwc2_hsotg *hsotg)
b02038fa John Youn 2016-02-23 2164 {
92a8dd26 Minas Harutyunyan 2018-01-19 2165 u32 hcfg, hfir, otgctl, usbcfg;
b02038fa John Youn 2016-02-23 2166
b02038fa John Youn 2016-02-23 2167 dev_dbg(hsotg->dev, "%s(%p)\n",
__func__, hsotg);
b02038fa John Youn 2016-02-23 2168
92a8dd26 Minas Harutyunyan 2018-01-19 2169 /* Set HS/FS Timeout
Calibration to 7 (max available value).
92a8dd26 Minas Harutyunyan 2018-01-19 2170 * The number of PHY clocks
that the application programs in
92a8dd26 Minas Harutyunyan 2018-01-19 2171 * this field is added to the
high/full speed interpacket timeout
92a8dd26 Minas Harutyunyan 2018-01-19 2172 * duration in the core to
account for any additional delays
92a8dd26 Minas Harutyunyan 2018-01-19 2173 * introduced by the PHY. This
can be required, because the delay
92a8dd26 Minas Harutyunyan 2018-01-19 2174 * introduced by the PHY in
generating the linestate condition
92a8dd26 Minas Harutyunyan 2018-01-19 2175 * can vary from one PHY to
another.
92a8dd26 Minas Harutyunyan 2018-01-19 2176 */
f25c42b8 Gevorg Sahakyan 2018-07-26 2177 usbcfg = dwc2_readl(hsotg,
GUSBCFG);
92a8dd26 Minas Harutyunyan 2018-01-19 2178 usbcfg |= GUSBCFG_TOUTCAL(7);
f25c42b8 Gevorg Sahakyan 2018-07-26 2179 dwc2_writel(hsotg, usbcfg,
GUSBCFG);
92a8dd26 Minas Harutyunyan 2018-01-19 2180
b02038fa John Youn 2016-02-23 2181 /* Restart the Phy Clock */
f25c42b8 Gevorg Sahakyan 2018-07-26 2182 dwc2_writel(hsotg, 0, PCGCTL);
b02038fa John Youn 2016-02-23 2183
b02038fa John Youn 2016-02-23 2184 /* Initialize Host
Configuration Register */
b02038fa John Youn 2016-02-23 @2185 dwc2_init_fs_ls_pclk_sel(hsotg);
38e9002b Vardan Mikayelyan 2016-11-14 2186 if (hsotg->params.speed ==
DWC2_SPEED_PARAM_FULL ||
38e9002b Vardan Mikayelyan 2016-11-14 2187 hsotg->params.speed ==
DWC2_SPEED_PARAM_LOW) {
f25c42b8 Gevorg Sahakyan 2018-07-26 2188 hcfg =
dwc2_readl(hsotg, HCFG);
b02038fa John Youn 2016-02-23 2189 hcfg |= HCFG_FSLSSUPP;
f25c42b8 Gevorg Sahakyan 2018-07-26 2190 dwc2_writel(hsotg,
hcfg, HCFG);
b02038fa John Youn 2016-02-23 2191 }
b02038fa John Youn 2016-02-23 2192
b02038fa John Youn 2016-02-23 2193 /*
b02038fa John Youn 2016-02-23 2194 * This bit allows dynamic
reloading of the HFIR register during
b02038fa John Youn 2016-02-23 2195 * runtime. This bit needs to
be programmed during initial configuration
b02038fa John Youn 2016-02-23 2196 * and its value must not be
changed during runtime.
b02038fa John Youn 2016-02-23 2197 */
95832c00 John Youn 2017-01-23 2198 if (hsotg->params.reload_ctl) {
f25c42b8 Gevorg Sahakyan 2018-07-26 2199 hfir =
dwc2_readl(hsotg, HFIR);
b02038fa
Re: [PATCH] usb: typec: Registering real device entries for the muxes
Hi Heikki, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on v5.1-rc3 next-20190401] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Heikki-Krogerus/usb-typec-Registering-real-device-entries-for-the-muxes/20190402-030003 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) include/linux/generic-radix-tree.h:1: warning: no structured comments found kernel/rcu/tree_plugin.h:1: warning: no structured comments found kernel/rcu/tree_plugin.h:1: warning: no structured comments found include/linux/firmware/intel/stratix10-svc-client.h:1: warning: no structured comments found include/linux/gpio/driver.h:371: warning: Function parameter or member 'init_valid_mask' not described in 'gpio_chip' include/linux/i2c.h:343: warning: Function parameter or member 'init_irq' not described in 'i2c_client' include/linux/iio/hw-consumer.h:1: warning: no structured comments found include/linux/input/sparse-keymap.h:46: warning: Function parameter or member 'sw' not described in 'key_entry' include/linux/regulator/machine.h:199: warning: Function parameter or member 'max_uV_step' not described in 'regulation_constraints' include/linux/regulator/driver.h:228: warning: Function parameter or member 'resume' not described in 'regulator_ops' drivers/slimbus/stream.c:1: warning: no structured comments found include/linux/spi/spi.h:188: warning: Function parameter or member 'driver_override' not described in 'spi_device' drivers/target/target_core_device.c:1: warning: no structured comments found >> drivers/usb/typec/mux.c:106: warning: Function parameter or member 'parent' >> not described in 'typec_switch_register' >> drivers/usb/typec/mux.c:106: warning: Function parameter or member 'desc' >> not described in 'typec_switch_register' drivers/usb/typec/mux.c:106: warning: Excess function parameter 'sw' description in 'typec_switch_register' >> drivers/usb/typec/mux.c:281: warning: Function parameter or member 'parent' >> not described in 'typec_mux_register' >> drivers/usb/typec/mux.c:281: warning: Function parameter or member 'desc' >> not described in 'typec_mux_register' drivers/usb/typec/mux.c:281: warning: Excess function parameter 'mux' description in 'typec_mux_register' drivers/usb/typec/bus.c:1: warning: no structured comments found drivers/usb/typec/class.c:1: warning: no structured comments found include/linux/w1.h:281: warning: Function parameter or member 'of_match_table' not described in 'w1_family' fs/direct-io.c:257: warning: Excess function parameter 'offset' description in 'dio_complete' fs/file_table.c:1: warning: no structured comments found fs/libfs.c:477: warning: Excess function parameter 'available' description in 'simple_write_end' fs/posix_acl.c:646: warning: Function parameter or member 'inode' not described in 'posix_acl_update_mode' fs/posix_acl.c:646: warning: Function parameter or member 'mode_p' not described in 'posix_acl_update_mode' fs/posix_acl.c:646: warning: Function parameter or member 'acl' not described in 'posix_acl_update_mode' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:294: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:294: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:294: warning: Excess function parameter 'end' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:343: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:343: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:343: warning: Excess function parameter 'end' description in 'amdgpu_mn_invalidate_range_end' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:183: warning: Function parameter or member 'blockable' not described in 'amdgpu_mn_read_lock' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Function parameter or member 'range' not described in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Excess function parameter 'mm' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Excess function parameter 'start' description in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:295: warning: Excess function parameter 'end' description in 'amdgpu
Re: [PATCH] usb: gadget: functions: add ftrace export over USB
Hi Felipe, I love your patch! Yet something to improve: [auto build test ERROR on balbi-usb/next] [also build test ERROR on v5.1-rc1 next-20190321] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Felipe-Balbi/usb-gadget-functions-add-ftrace-export-over-USB/20190322-081552 base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next config: m68k-allyesconfig (attached as .config) compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=m68k All error/warnings (new ones prefixed by >>): >> drivers/usb/gadget/function/f-trace.c:26:22: error: field 'ftrace' has >> incomplete type struct trace_export ftrace; ^~ In file included from include/linux/ioport.h:13:0, from include/linux/device.h:15, from drivers/usb/gadget/function/f-trace.c:13: drivers/usb/gadget/function/f-trace.c: In function 'ftrace_write': >> include/linux/kernel.h:998:32: error: dereferencing pointer to incomplete >> type 'struct trace_export' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^~ include/linux/compiler.h:324:9: note: in definition of macro '__compiletime_assert' if (!(condition)) \ ^ include/linux/compiler.h:344:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^~ include/linux/kernel.h:998:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^~~~ include/linux/kernel.h:998:20: note: in expansion of macro '__same_type' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^~~ >> drivers/usb/gadget/function/f-trace.c:39:29: note: in expansion of macro >> 'container_of' #define ftrace_to_trace(f) (container_of((f), struct usb_ftrace, ftrace)) ^~~~ >> drivers/usb/gadget/function/f-trace.c:175:30: note: in expansion of macro >> 'ftrace_to_trace' struct usb_ftrace *trace = ftrace_to_trace(ftrace); ^~~ drivers/usb/gadget/function/f-trace.c: In function 'ftrace_bind': >> drivers/usb/gadget/function/f-trace.c:295:8: error: implicit declaration of >> function 'register_ftrace_export'; did you mean 'register_chrdev_region'? >> [-Werror=implicit-function-declaration] ret = register_ftrace_export(&trace->ftrace); ^~ register_chrdev_region drivers/usb/gadget/function/f-trace.c: In function 'ftrace_unbind': >> drivers/usb/gadget/function/f-trace.c:323:2: error: implicit declaration of >> function 'unregister_ftrace_export'; did you mean >> 'unregister_chrdev_region'? [-Werror=implicit-function-declaration] unregister_ftrace_export(&trace->ftrace); ^~~~ unregister_chrdev_region cc1: some warnings being treated as errors -- drivers/usb//gadget/function/f-trace.c:26:22: error: field 'ftrace' has incomplete type struct trace_export ftrace; ^~ In file included from include/linux/ioport.h:13:0, from include/linux/device.h:15, from drivers/usb//gadget/function/f-trace.c:13: drivers/usb//gadget/function/f-trace.c: In function 'ftrace_write': >> include/linux/kernel.h:998:32: error: dereferencing pointer to incomplete >> type 'struct trace_export' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^~ include/linux/compiler.h:324:9: note: in definition of macro '__compiletime_assert' if (!(condition)) \ ^ include/linux/compiler.h:344:2: note: in expansion of macro '_compiletime_assert' _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__) ^~~ include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert' #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg) ^~ include/linux/kernel.h:998:2: note: in expansion of macro 'BUILD_BUG_ON_MSG' BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ ^~~~ include/linux/kernel.h:998:20: note: in ex
Re: [PATCH v3 09/12] usb: dwc3: Registering a role switch in the DRD code.
Hi Yu, I love your patch! Perhaps something to improve: [auto build test WARNING on balbi-usb/next] [also build test WARNING on v5.0 next-20190305] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Yu-Chen/Add-support-for-usb-on-Hikey960/20190305-062824 base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) include/linux/rcupdate_wait.h:1: warning: no structured comments found include/linux/rcutree.h:1: warning: no structured comments found kernel/rcu/tree.c:710: warning: Excess function parameter 'irq' description in 'rcu_nmi_exit' include/linux/gfp.h:1: warning: no structured comments found include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.ibss' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.connect' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.keys' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.ie' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.ie_len' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.bssid' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.ssid' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.default_key' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.default_mgmt_key' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev' include/net/mac80211.h:2393: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw' include/net/mac80211.h:2393: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw' include/net/mac80211.h:1004: warning: Function parameter or member 'control.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'status.status_driver_dat
Re: [PATCH v3 04/12] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc
Hi Yu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v5.0 next-20190304]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Yu-Chen/Add-support-for-usb-on-Hikey960/20190305-062824
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-u0-03051004 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/usb/dwc3/core.c:1855:14: error: 'dwc3_complete' undeclared here (not
>> in a function)
.complete = dwc3_complete,
^
vim +/dwc3_complete +1855 drivers/usb/dwc3/core.c
1852
1853 static const struct dev_pm_ops dwc3_dev_pm_ops = {
1854 SET_SYSTEM_SLEEP_PM_OPS(dwc3_suspend, dwc3_resume)
> 1855 .complete = dwc3_complete,
1856 SET_RUNTIME_PM_OPS(dwc3_runtime_suspend, dwc3_runtime_resume,
1857 dwc3_runtime_idle)
1858 };
1859
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH v3 04/12] usb: dwc3: Add splitdisable quirk for Hisilicon Kirin Soc
Hi Yu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v5.0 next-20190304]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Yu-Chen/Add-support-for-usb-on-Hikey960/20190305-062824
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-x010-201909 (attached as .config)
compiler: gcc-8 (Debian 8.2.0-21) 8.2.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/usb/dwc3/core.c:1855:14: error: 'dwc3_complete' undeclared here (not
>> in a function); did you mean 'complete'?
.complete = dwc3_complete,
^
complete
vim +1855 drivers/usb/dwc3/core.c
1852
1853 static const struct dev_pm_ops dwc3_dev_pm_ops = {
1854 SET_SYSTEM_SLEEP_PM_OPS(dwc3_suspend, dwc3_resume)
> 1855 .complete = dwc3_complete,
1856 SET_RUNTIME_PM_OPS(dwc3_runtime_suspend, dwc3_runtime_resume,
1857 dwc3_runtime_idle)
1858 };
1859
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH 3/3] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events
Hi Hans,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20190226]
[cannot apply to v5.0-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Hans-de-Goede/Propagate-DP-over-Type-C-hotplug-events-from-Type-C-subsys-to-drm-drivers/20190226-005334
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-s1-02261802 (attached as .config)
compiler: gcc-6 (Debian 6.5.0-2) 6.5.0 20181026
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
ld: drivers/usb/typec/altmodes/displayport.o: in function
`dp_altmode_remove':
>> drivers/usb/typec/altmodes/displayport.c:570: undefined reference to
>> `drm_kms_call_oob_hotplug_notifier_chain'
ld: drivers/usb/typec/altmodes/displayport.o: in function
`dp_altmode_notify':
drivers/usb/typec/altmodes/displayport.c:79: undefined reference to
`drm_kms_call_oob_hotplug_notifier_chain'
vim +570 drivers/usb/typec/altmodes/displayport.c
562
563 static void dp_altmode_remove(struct typec_altmode *alt)
564 {
565 struct dp_altmode *dp = typec_altmode_get_drvdata(alt);
566
567 sysfs_remove_group(&alt->dev.kobj, &dp_altmode_group);
568 cancel_work_sync(&dp->work);
569
> 570
> drm_kms_call_oob_hotplug_notifier_chain(DRM_OOB_HOTPLUG_TYPE_C_DP);
571 }
572
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH 3/3] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20190225] [cannot apply to v5.0-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Hans-de-Goede/Propagate-DP-over-Type-C-hotplug-events-from-Type-C-subsys-to-drm-drivers/20190226-005334 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-m1-201908 (attached as .config) compiler: gcc-7 (Debian 7.4.0-5) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> ERROR: "drm_kms_call_oob_hotplug_notifier_chain" >> [drivers/usb/typec/altmodes/typec_displayport.ko] undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCHv2] usb: typec: tps6598x: handle block writes separately with plain-I2C adapters
Hi Nikolaus,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v5.0-rc4 next-20190220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Nikolaus-Voss/usb-typec-tps6598x-handle-block-writes-separately-with-plain-I2C-adapters/20190221-165456
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: i386-randconfig-a0-201907 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/usb/typec/tps6598x.c: In function 'tps6598x_block_write':
>> drivers/usb/typec/tps6598x.c:132:2: warning: variable length array 'data' is
>> used [-Wvla]
u8 data[len + 1];
^
vim +/data +132 drivers/usb/typec/tps6598x.c
128
129 static int tps6598x_block_write(struct tps6598x *tps, u8 reg,
130 void *val, size_t len)
131 {
> 132 u8 data[len + 1];
133
134 if (!tps->i2c_protocol)
135 return regmap_raw_write(tps->regmap, reg, val, len);
136
137 data[0] = len;
138 memcpy(&data[1], val, len);
139
140 return regmap_raw_write(tps->regmap, reg, data, sizeof(data));
141 }
142
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[usb:usb-testing 63/64] drivers/usb/typec/mux.c:167 typec_mux_match() warn: unsigned 'nval' is never less than zero.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
head: 09aa11cfda9d8186046bcd1adcd6498b688114f4
commit: 96a6d031ca9930938bd66d0052fc7ed2b56e3583 [63/64] usb: typec: mux: Find
the muxes by also matching against the device node
smatch warnings:
drivers/usb/typec/mux.c:167 typec_mux_match() warn: unsigned 'nval' is never
less than zero.
vim +/nval +167 drivers/usb/typec/mux.c
124
125 static void *typec_mux_match(struct device_connection *con, int ep,
void *data)
126 {
127 const struct typec_altmode_desc *desc = data;
128 struct typec_mux *mux;
129 size_t nval;
130 bool match;
131 u16 *val;
132 int i;
133
134 if (!con->fwnode) {
135 list_for_each_entry(mux, &mux_list, entry)
136 if (!strcmp(con->endpoint[ep],
dev_name(mux->dev)))
137 return mux;
138 return ERR_PTR(-EPROBE_DEFER);
139 }
140
141 /*
142 * Check has the identifier already been "consumed". If it
143 * has, no need to do any extra connection identification.
144 */
145 match = !con->id;
146 if (match)
147 goto find_mux;
148
149 /* Accessory Mode muxes */
150 if (!desc) {
151 match = fwnode_property_present(con->fwnode,
"accessory");
152 if (match)
153 goto find_mux;
154 return NULL;
155 }
156
157 /* Alternate Mode muxes */
158 nval = fwnode_property_read_u16_array(con->fwnode, "svid",
NULL, 0);
159 if (nval <= 0)
160 return NULL;
161
162 val = kcalloc(nval, sizeof(*val), GFP_KERNEL);
163 if (!val)
164 return ERR_PTR(-ENOMEM);
165
166 nval = fwnode_property_read_u16_array(con->fwnode, "svid", val,
nval);
> 167 if (nval < 0) {
168 kfree(val);
169 return ERR_PTR(nval);
170 }
171
172 for (i = 0; i < nval; i++) {
173 match = val[i] == desc->svid;
174 if (match) {
175 kfree(val);
176 goto find_mux;
177 }
178 }
179 kfree(val);
180 return NULL;
181
182 find_mux:
183 list_for_each_entry(mux, &mux_list, entry)
184 if (dev_fwnode(mux->dev) == con->fwnode)
185 return mux;
186
187 return match ? ERR_PTR(-EPROBE_DEFER) : NULL;
188 }
189
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[balbi-usb:testing/next 19/21] drivers/usb//dwc3/gadget.c:2630:3: error: expected expression before '||' token
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
testing/next
head: 72bc0e861a6678b4a36653cd94147a5043959ed2
commit: 5f404e8452cb9ff560e8f2a254e29d1449632a0d [19/21] usb: dwc3: gadget:
don't use resource_index as a flag
config: x86_64-randconfig-x017-201904 (attached as .config)
compiler: gcc-8 (Debian 8.2.0-14) 8.2.0
reproduce:
git checkout 5f404e8452cb9ff560e8f2a254e29d1449632a0d
# save the attached .config to linux build tree
make ARCH=x86_64
Note: the balbi-usb/testing/next HEAD 72bc0e861a6678b4a36653cd94147a5043959ed2
builds fine.
It only hurts bisectibility.
All error/warnings (new ones prefixed by >>):
drivers/usb//dwc3/gadget.c: In function 'dwc3_stop_active_transfer':
>> drivers/usb//dwc3/gadget.c:2630:3: error: expected expression before '||'
>> token
|| !(dep->flags & DWC3_EP_TRANSFER_STARTED))
^~
>> drivers/usb//dwc3/gadget.c:2629:2: warning: this 'if' clause does not
>> guard... [-Wmisleading-indentation]
if (dep->flags & DWC3_EP_END_TRANSFER_PENDING)
^~
drivers/usb//dwc3/gadget.c:2630:46: note: ...this statement, but the latter
is misleadingly indented as if it were guarded by the 'if'
|| !(dep->flags & DWC3_EP_TRANSFER_STARTED))
^
>> drivers/usb//dwc3/gadget.c:2630:46: error: expected statement before ')'
>> token
vim +2630 drivers/usb//dwc3/gadget.c
2621
2622 static void dwc3_stop_active_transfer(struct dwc3_ep *dep, bool force)
2623 {
2624 struct dwc3 *dwc = dep->dwc;
2625 struct dwc3_gadget_ep_cmd_params params;
2626 u32 cmd;
2627 int ret;
2628
> 2629 if (dep->flags & DWC3_EP_END_TRANSFER_PENDING)
> 2630 || !(dep->flags & DWC3_EP_TRANSFER_STARTED))
2631 return;
2632
2633 /*
2634 * NOTICE: We are violating what the Databook says about the
2635 * EndTransfer command. Ideally we would _always_ wait for the
2636 * EndTransfer Command Completion IRQ, but that's causing too
2637 * much trouble synchronizing between us and gadget driver.
2638 *
2639 * We have discussed this with the IP Provider and it was
2640 * suggested to giveback all requests here, but give HW some
2641 * extra time to synchronize with the interconnect. We're using
2642 * an arbitrary 100us delay for that.
2643 *
2644 * Note also that a similar handling was tested by Synopsys
2645 * (thanks a lot Paul) and nothing bad has come out of it.
2646 * In short, what we're doing is:
2647 *
2648 * - Issue EndTransfer WITH CMDIOC bit set
2649 * - Wait 100us
2650 *
2651 * As of IP version 3.10a of the DWC_usb3 IP, the controller
2652 * supports a mode to work around the above limitation. The
2653 * software can poll the CMDACT bit in the DEPCMD register
2654 * after issuing a EndTransfer command. This mode is enabled
2655 * by writing GUCTL2[14]. This polling is already done in the
2656 * dwc3_send_gadget_ep_cmd() function so if the mode is
2657 * enabled, the EndTransfer command will have completed upon
2658 * returning from this function and we don't need to delay for
2659 * 100us.
2660 *
2661 * This mode is NOT available on the DWC_usb31 IP.
2662 */
2663
2664 cmd = DWC3_DEPCMD_ENDTRANSFER;
2665 cmd |= force ? DWC3_DEPCMD_HIPRI_FORCERM : 0;
2666 cmd |= DWC3_DEPCMD_CMDIOC;
2667 cmd |= DWC3_DEPCMD_PARAM(dep->resource_index);
2668 memset(¶ms, 0, sizeof(params));
2669 ret = dwc3_send_gadget_ep_cmd(dep, cmd, ¶ms);
2670 WARN_ON_ONCE(ret);
2671 dep->resource_index = 0;
2672
2673 if (dwc3_is_usb31(dwc) || dwc->revision < DWC3_REVISION_310A) {
2674 dep->flags |= DWC3_EP_END_TRANSFER_PENDING;
2675 udelay(100);
2676 }
2677 }
2678
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH 2/2] usb: dwc3: Add workaround for host mode VBUS glitch when boot
Hi Ran, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on v5.0-rc2 next-20190116] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ran-Wang/usb-dwc3-Add-avoiding-vbus-glitch-happen-during-xhci-reset/20190116-153950 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) include/linux/interrupt.h:268: warning: Function parameter or member 'is_managed' not described in 'irq_affinity_desc' include/linux/rcupdate_wait.h:1: warning: no structured comments found include/linux/rcutree.h:1: warning: no structured comments found kernel/rcu/tree.c:710: warning: Excess function parameter 'irq' description in 'rcu_nmi_exit' include/linux/gfp.h:1: warning: no structured comments found include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.ibss' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.connect' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.keys' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.ie' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.ie_len' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.bssid' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.ssid' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.default_key' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.default_mgmt_key' not described in 'wireless_dev' include/net/cfg80211.h:4687: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev' include/net/mac80211.h:2393: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw' include/net/mac80211.h:2393: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw' include/net/mac80211.h:1004: warning: Function parameter or member 'control.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:1004: warning: Function parameter o
Re: [PATCH 3/3] drivers: usb :fsl: Remove USB Errata checking code
Hi yinbo.zhu, Thank you for the patch! Yet something to improve: [auto build test ERROR on usb/usb-testing] [also build test ERROR on v5.0-rc1 next-20190108] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ran-Wang/usb-kconfig-remove-dependency-FSL_SOC-for-ehci-fsl-driver/20190108-143252 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=arm All errors (new ones prefixed by >>): drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_ioctl': >> phy-fsl-usb.c:(.text+0x444): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_start_srp': phy-fsl-usb.c:(.text+0x4c0): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_set_host': phy-fsl-usb.c:(.text+0x5c0): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_start_hnp': phy-fsl-usb.c:(.text+0x650): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `show_fsl_usb2_otg_state': >> phy-fsl-usb.c:(.text+0x754): undefined reference to `usb_otg_state_string' drivers/usb/phy/phy-fsl-usb.o: In function `a_wait_enum': phy-fsl-usb.c:(.text+0x1064): undefined reference to `otg_statemachine' drivers/usb/phy/phy-fsl-usb.o: In function `fsl_otg_set_peripheral': >> phy-fsl-usb.c:(.text+0x1648): undefined reference to >> `usb_gadget_vbus_disconnect' phy-fsl-usb.c:(.text+0x1658): undefined reference to `otg_statemachine' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH] Add Prolific new chip: PL2303TB & PL2303N(G)
Hi Charles,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on usb-serial/usb-next]
[also build test WARNING on v4.20 next-20181224]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Charles-Yeh/Add-Prolific-new-chip-PL2303TB-PL2303N-G/20181225-220256
base: https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git
usb-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
include/linux/slab.h:332:43: warning: dubious: x & !y
include/linux/slab.h:332:43: warning: dubious: x & !y
>> drivers/usb/serial/pl2303.c:352:36: warning: restricted __le16 degrades to
>> integer
include/linux/slab.h:332:43: warning: dubious: x & !y
include/linux/slab.h:332:43: warning: dubious: x & !y
vim +352 drivers/usb/serial/pl2303.c
324
325 static int pl2303_startup(struct usb_serial *serial)
326 {
327 struct pl2303_serial_private *spriv;
328 enum pl2303_type type = TYPE_01;
329 unsigned char *buf;
330 int res;
331
332 spriv = kzalloc(sizeof(*spriv), GFP_KERNEL);
333 if (!spriv)
334 return -ENOMEM;
335
336 buf = kmalloc(1, GFP_KERNEL);
337 if (!buf) {
338 kfree(spriv);
339 return -ENOMEM;
340 }
341
342 if (serial->dev->descriptor.bDeviceClass == 0x02)
343 type = TYPE_01; /* type 0 */
344 else if (serial->dev->descriptor.bMaxPacketSize0 == 0x40)
345 type = TYPE_HX;
346 else if (serial->dev->descriptor.bDeviceClass == 0x00)
347 type = TYPE_01; /* type 1 */
348 else if (serial->dev->descriptor.bDeviceClass == 0xFF)
349 type = TYPE_01; /* type 1 */
350 dev_dbg(&serial->interface->dev, "device type: %d\n", type);
351
> 352 if (serial->dev->descriptor.bcdUSB == 0x0200) {
353 res = usb_control_msg(serial->dev,
usb_rcvctrlpipe(serial->dev, 0),
354 VENDOR_READ_REQUEST, VENDOR_READ_REQUEST_TYPE,
355 TYPE_HX_READ_OTP_STATUS_REGISTER, 0, buf, 1,
100);
356 if (res != 1)
357 type = TYPE_HXN;
358 }
359
360 spriv->type = &pl2303_type_data[type];
361 spriv->quirks = (unsigned long)usb_get_serial_data(serial);
362 spriv->quirks |= spriv->type->quirks;
363
364 usb_set_serial_data(serial, spriv);
365
366 if (type != TYPE_HXN) {
367 pl2303_vendor_read(serial, 0x8484, buf);
368 pl2303_vendor_write(serial, 0x0404, 0);
369 pl2303_vendor_read(serial, 0x8484, buf);
370 pl2303_vendor_read(serial, 0x8383, buf);
371 pl2303_vendor_read(serial, 0x8484, buf);
372 pl2303_vendor_write(serial, 0x0404, 1);
373 pl2303_vendor_read(serial, 0x8484, buf);
374 pl2303_vendor_read(serial, 0x8383, buf);
375 pl2303_vendor_write(serial, 0, 1);
376 pl2303_vendor_write(serial, 1, 0);
377 if (spriv->quirks & PL2303_QUIRK_LEGACY)
378 pl2303_vendor_write(serial, 2, 0x24);
379 else
380 pl2303_vendor_write(serial, 2, 0x44);
381 }
382
383 kfree(buf);
384
385 return 0;
386 }
387
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH v2 5/5] usb:cdns3 Add Cadence USB3 DRD Driver
Hi Pawel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v4.20-rc7 next-20181221]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Pawel-Laszczak/Introduced-new-Cadence-USBSS-DRD-Driver/20181223-231813
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
>> drivers/usb/common/debug.c:253:25: warning: restricted __le16 degrades to
>> integer
drivers/usb/common/debug.c:254:25: warning: restricted __le16 degrades to
integer
drivers/usb/common/debug.c:255:25: warning: restricted __le16 degrades to
integer
drivers/usb/common/debug.c:256:25: warning: restricted __le16 degrades to
integer
drivers/usb/common/debug.c:257:25: warning: restricted __le16 degrades to
integer
drivers/usb/common/debug.c:258:25: warning: restricted __le16 degrades to
integer
vim +253 drivers/usb/common/debug.c
cefb8b21 Pawel Laszczak 2018-12-23 205
cefb8b21 Pawel Laszczak 2018-12-23 206 /**
cefb8b21 Pawel Laszczak 2018-12-23 207 * usb_decode_ctrl - returns a string
representation of ctrl request
cefb8b21 Pawel Laszczak 2018-12-23 208 */
cefb8b21 Pawel Laszczak 2018-12-23 209 const char *usb_decode_ctrl(char *str,
__u8 bRequestType, __u8 bRequest,
cefb8b21 Pawel Laszczak 2018-12-23 210 __u16
wValue, __u16 wIndex, __u16 wLength)
cefb8b21 Pawel Laszczak 2018-12-23 211 {
cefb8b21 Pawel Laszczak 2018-12-23 212 switch (bRequest) {
cefb8b21 Pawel Laszczak 2018-12-23 213 case USB_REQ_GET_STATUS:
cefb8b21 Pawel Laszczak 2018-12-23 214
usb_decode_get_status(bRequestType, wIndex, wLength, str);
cefb8b21 Pawel Laszczak 2018-12-23 215 break;
cefb8b21 Pawel Laszczak 2018-12-23 216 case USB_REQ_CLEAR_FEATURE:
cefb8b21 Pawel Laszczak 2018-12-23 217 case USB_REQ_SET_FEATURE:
cefb8b21 Pawel Laszczak 2018-12-23 218
usb_decode_set_clear_feature(bRequestType, bRequest, wValue,
cefb8b21 Pawel Laszczak 2018-12-23 219
wIndex, str);
cefb8b21 Pawel Laszczak 2018-12-23 220 break;
cefb8b21 Pawel Laszczak 2018-12-23 221 case USB_REQ_SET_ADDRESS:
cefb8b21 Pawel Laszczak 2018-12-23 222
usb_decode_set_address(wValue, str);
cefb8b21 Pawel Laszczak 2018-12-23 223 break;
cefb8b21 Pawel Laszczak 2018-12-23 224 case USB_REQ_GET_DESCRIPTOR:
cefb8b21 Pawel Laszczak 2018-12-23 225 case USB_REQ_SET_DESCRIPTOR:
cefb8b21 Pawel Laszczak 2018-12-23 226
usb_decode_get_set_descriptor(bRequestType, bRequest, wValue,
cefb8b21 Pawel Laszczak 2018-12-23 227
wIndex, wLength, str);
cefb8b21 Pawel Laszczak 2018-12-23 228 break;
cefb8b21 Pawel Laszczak 2018-12-23 229 case USB_REQ_GET_CONFIGURATION:
cefb8b21 Pawel Laszczak 2018-12-23 230
usb_decode_get_configuration(wLength, str);
cefb8b21 Pawel Laszczak 2018-12-23 231 break;
cefb8b21 Pawel Laszczak 2018-12-23 232 case USB_REQ_SET_CONFIGURATION:
cefb8b21 Pawel Laszczak 2018-12-23 233
usb_decode_set_configuration(wValue, str);
cefb8b21 Pawel Laszczak 2018-12-23 234 break;
cefb8b21 Pawel Laszczak 2018-12-23 235 case USB_REQ_GET_INTERFACE:
cefb8b21 Pawel Laszczak 2018-12-23 236
usb_decode_get_intf(wIndex, wLength, str);
cefb8b21 Pawel Laszczak 2018-12-23 237 break;
cefb8b21 Pawel Laszczak 2018-12-23 238 case USB_REQ_SET_INTERFACE:
cefb8b21 Pawel Laszczak 2018-12-23 239
usb_decode_set_intf(wValue, wIndex, str);
cefb8b21 Pawel Laszczak 2018-12-23 240 break;
cefb8b21 Pawel Laszczak 2018-12-23 241 case USB_REQ_SYNCH_FRAME:
cefb8b21 Pawel Laszczak 2018-12-23 242
usb_decode_synch_frame(wIndex, wLength, str);
cefb8b21 Pawel Laszczak 2018-12-23 243 break;
cefb8b21 Pawel Laszczak 2018-12-23 244 case USB_REQ_SET_SEL:
cefb8b21 Pawel Laszczak 2018-12-23 245
usb_decode_set_sel(wLength, str);
cefb8b21 Pawel Laszczak 2018-12-23 246 break;
cefb8b21 Pawel Laszczak 2018-12-23 247 case USB_REQ_SET_ISOCH_DELAY:
cefb8b21 Pawel Laszczak 2018-12-23 248
usb_decode_set_isoch_delay(wValue, str);
cefb8b21 Pawel Laszczak 2018-12-23 249 break;
cefb8b21 Pawel Laszczak 2018-12-23 250 default:
cefb8b21 Pawel Laszczak 2018-12-23 251 sprintf(str, "%02x %02x
Re: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver
Hi Pawel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v4.20-rc6 next-20181214]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Pawel-Laszczak/dt-bindings-add-binding-for-USBSS-DRD-controller/20181211-025348
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=m68k
All warnings (new ones prefixed by >>):
drivers/usb//cdns3/host.c: In function 'cdns3_host_init':
>> drivers/usb//cdns3/host.c:65:5: warning: "CONFIG_PM" is not defined,
>> evaluates to 0 [-Wundef]
#if CONFIG_PM
^
vim +/CONFIG_PM +65 drivers/usb//cdns3/host.c
53
54 int cdns3_host_init(struct cdns3 *cdns)
55 {
56 struct cdns3_role_driver *rdrv;
57
58 rdrv = devm_kzalloc(cdns->dev, sizeof(*rdrv), GFP_KERNEL);
59 if (!rdrv)
60 return -ENOMEM;
61
62 rdrv->start = __cdns3_host_init;
63 rdrv->stop = cdns3_host_exit;
64 rdrv->state = CDNS3_ROLE_STATE_INACTIVE;
> 65 #if CONFIG_PM
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[balbi-usb:testing/next 50/50] drivers/usb/dwc3/./trace.h:216:449: warning: 's' may be used uninitialized in this function
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: ad7b607f82731eec3ed17d9d22764eb6f09609f9 commit: ad7b607f82731eec3ed17d9d22764eb6f09609f9 [50/50] usb: dwc3: trace: add missing break statement to make compiler happy config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout ad7b607f82731eec3ed17d9d22764eb6f09609f9 # save the attached .config to linux build tree make ARCH=i386 Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings All warnings (new ones prefixed by >>): In file included from include/trace/trace_events.h:394:0, from include/trace/define_trace.h:96, from drivers/usb/dwc3/trace.h:342, from drivers/usb/dwc3/trace.c:11: drivers/usb/dwc3/./trace.h: In function 'trace_raw_output_dwc3_log_trb': >> drivers/usb/dwc3/./trace.h:216:449: warning: 's' may be used uninitialized >> in this function [-Wmaybe-uninitialized] DECLARE_EVENT_CLASS(dwc3_log_trb, ^ drivers/usb/dwc3/./trace.h:216:647: note: 's' was declared here DECLARE_EVENT_CLASS(dwc3_log_trb, ^ vim +/s +216 drivers/usb/dwc3/./trace.h 2c4cbe6e5a Felipe Balbi2014-04-30 215 2c4cbe6e5a Felipe Balbi2014-04-30 @216 DECLARE_EVENT_CLASS(dwc3_log_trb, 2c4cbe6e5a Felipe Balbi2014-04-30 217 TP_PROTO(struct dwc3_ep *dep, struct dwc3_trb *trb), 2c4cbe6e5a Felipe Balbi2014-04-30 218 TP_ARGS(dep, trb), 2c4cbe6e5a Felipe Balbi2014-04-30 219 TP_STRUCT__entry( e42f09b85f Felipe Balbi2017-04-28 220 __string(name, dep->name) 2c4cbe6e5a Felipe Balbi2014-04-30 221 __field(struct dwc3_trb *, trb) 68d34c8a74 Felipe Balbi2016-05-30 222 __field(u32, allocated) 68d34c8a74 Felipe Balbi2016-05-30 223 __field(u32, queued) 4ac4fc9322 Felipe Balbi2014-09-17 224 __field(u32, bpl) 4ac4fc9322 Felipe Balbi2014-09-17 225 __field(u32, bph) 4ac4fc9322 Felipe Balbi2014-09-17 226 __field(u32, size) 4ac4fc9322 Felipe Balbi2014-09-17 227 __field(u32, ctrl) fa8d965d73 Felipe Balbi2016-09-28 228 __field(u32, type) 2c4cbe6e5a Felipe Balbi2014-04-30 229 ), 2c4cbe6e5a Felipe Balbi2014-04-30 230 TP_fast_assign( e42f09b85f Felipe Balbi2017-04-28 231 __assign_str(name, dep->name); 2c4cbe6e5a Felipe Balbi2014-04-30 232 __entry->trb = trb; 4ac4fc9322 Felipe Balbi2014-09-17 233 __entry->bpl = trb->bpl; 4ac4fc9322 Felipe Balbi2014-09-17 234 __entry->bph = trb->bph; 4ac4fc9322 Felipe Balbi2014-09-17 235 __entry->size = trb->size; 4ac4fc9322 Felipe Balbi2014-09-17 236 __entry->ctrl = trb->ctrl; fa8d965d73 Felipe Balbi2016-09-28 237 __entry->type = usb_endpoint_type(dep->endpoint.desc); 2c4cbe6e5a Felipe Balbi2014-04-30 238 ), 0bd0f6
[balbi-usb:testing/next 50/50] drivers/usb/dwc3/./trace.h:239:2: note: in expansion of macro 'TP_printk'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
testing/next
head: ad7b607f82731eec3ed17d9d22764eb6f09609f9
commit: ad7b607f82731eec3ed17d9d22764eb6f09609f9 [50/50] usb: dwc3: trace: add
missing break statement to make compiler happy
config: i386-randconfig-x006-12051027 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout ad7b607f82731eec3ed17d9d22764eb6f09609f9
# save the attached .config to linux build tree
make ARCH=i386
Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings
All warnings (new ones prefixed by >>):
In file included from include/trace/define_trace.h:96:0,
from drivers/usb/dwc3/trace.h:342,
from drivers/usb/dwc3/trace.c:11:
drivers/usb/dwc3/./trace.h: In function 'trace_raw_output_dwc3_log_trb':
>> include/trace/trace_events.h:360:2: warning: 's' may be used uninitialized
>> in this function [-Wmaybe-uninitialized]
trace_seq_printf(s, print); \
^~~~
drivers/usb/dwc3/./trace.h:241:11: note: 's' was declared here
({char *s;
^
include/trace/trace_events.h:360:22: note: in definition of macro
'DECLARE_EVENT_CLASS'
trace_seq_printf(s, print); \
^
>> drivers/usb/dwc3/./trace.h:239:2: note: in expansion of macro 'TP_printk'
TP_printk("%s: trb %p buf %08x%08x size %s%d ctrl %08x (%c%c%c%c:%c%c:%s)",
^
--
In file included from include/trace/define_trace.h:96:0,
from drivers/usb//dwc3/trace.h:342,
from drivers/usb//dwc3/trace.c:11:
drivers/usb//dwc3/./trace.h: In function 'trace_raw_output_dwc3_log_trb':
>> include/trace/trace_events.h:360:2: warning: 's' may be used uninitialized
>> in this function [-Wmaybe-uninitialized]
trace_seq_printf(s, print); \
^~~~
drivers/usb//dwc3/./trace.h:241:11: note: 's' was declared here
({char *s;
^
include/trace/trace_events.h:360:22: note: in definition of macro
'DECLARE_EVENT_CLASS'
trace_seq_printf(s, print); \
^
drivers/usb//dwc3/./trace.h:239:2: note: in expansion of macro 'TP_printk'
TP_printk("%s: trb %p buf %08x%08x size %s%d ctrl %08x (%c%c%c%c:%c%c:%s)",
^
vim +/TP_printk +239 drivers/usb/dwc3/./trace.h
2c4cbe6e5a Felipe Balbi2014-04-30 215
2c4cbe6e5a Felipe Balbi2014-04-30 216 DECLARE_EVENT_CLASS(dwc3_log_trb,
2c4cbe6e5a Felipe Balbi2014-04-30 217 TP_PROTO(struct dwc3_ep *dep,
struct dwc3_trb *trb),
2c4cbe6e5a Felipe Balbi2014-04-30 218 TP_ARGS(dep, trb),
2c4cbe6e5a Felipe Balbi2014-04-30 219 TP_STRUCT__entry(
e42f09b85f Felipe Balbi2017-04-28 220 __string(name,
dep->name)
2c4cbe6e5a Felipe Balbi2014-04-30 221 __field(struct dwc3_trb
*, trb)
68d34c8a74 Felipe Balbi2016-05-30 222 __field(u32, allocated)
68d34c8a74 Felipe Balbi2016-05-30 223 __field(u32, queued)
4ac4fc9322 Felipe Balbi2014-09-17 224 __field(u32, bpl)
4ac4fc9322 Felipe Balbi2014-09-17 225 __field(u32, bph)
4ac4fc9322 Felipe Balbi2014-09-17 226 __field(u32, size)
4ac4fc9322 Felipe Balbi2014-09-17 227 __field(u32, ctrl)
fa8d965d73 Felipe Balbi2016-09-28 228 __field(u32, type)
2c4cbe6e5a Felipe Balbi2014-04-30 229 ),
2c4cbe6e5a Felipe Balbi2014-04-30 230 TP_fast_assign(
e42f09b85f Felipe Balbi2017-04-28 231 __assign_str(name,
dep->name);
2c4cbe6e5a Felipe Balbi2014-04-30 232 __entry->trb = trb;
4ac4fc9322 Felipe Balbi2014-09-17 233 __entry->bpl = trb->bpl;
4ac4fc9322 Felipe Balbi2014-09-17 234 __entry->bph = trb->bph;
4ac4fc9322 Felipe Balbi2014-09-17 235 __entry->size =
trb->size;
4ac4fc9322 Felipe Balbi2014-09-17 236 __entry->ctrl =
trb->ctrl;
fa8d965d73 Felipe Balbi2016-09-28 237 __entry->type =
usb_endpoint_type(dep->endpoint.desc);
2c4cbe6e5a Felipe Balbi2014-04-30 238 ),
0bd0f6d201 Felipe Balbi2018-03-26 @239 TP_printk("%s: trb %p buf
%08x%08x size %s%d ctrl %08x (%c%c%c%c:%c%c:%s)",
0bd0f6d201 Felipe Balbi2018-03-26 240 __get_str(name),
__entry->trb, __entry->bph, __entry->bpl,
fa8d965d73 Felipe Balbi2016-09-28 @241 ({char *s;
fa8d965d73 Felipe Balbi2016-09-28 242 int pcm =
((__entry->size >> 24) & 3) + 1;
fa8d965d73 Felipe Balbi2016-09-28 243 switch (__entry->type) {
fa8d965d73 Felipe Balbi2016-09-28 244 case
USB_ENDPOINT_XFER_INT:
fa8d965d73 Felipe Balbi2016-09-28 245 case
USB_ENDPOINT_XFER_ISOC:
fa8d965d73 Felipe Balbi2016-09-28
[balbi-usb:testing/next 50/50] drivers/usb/gadget/function/f_fs.c:2198:9: error: too few arguments to function 'ffs_do_single_desc'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
testing/next
head: 3591a2f3900e0f93dbd246d979ddd939251cac3e
commit: 3591a2f3900e0f93dbd246d979ddd939251cac3e [50/50] usb: gadget: f_fs: add
the support for alternate interface setting
config: arm-omap2plus_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 3591a2f3900e0f93dbd246d979ddd939251cac3e
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm
All errors (new ones prefixed by >>):
drivers/usb/gadget/function/f_fs.c: In function 'ffs_do_descs_alt_intf':
>> drivers/usb/gadget/function/f_fs.c:2198:9: error: too few arguments to
>> function 'ffs_do_single_desc'
ret = ffs_do_single_desc(data, len, entity, priv);
^~
drivers/usb/gadget/function/f_fs.c:1966:25: note: declared here
static int __must_check ffs_do_single_desc(char *data, unsigned len,
^~
vim +/ffs_do_single_desc +2198 drivers/usb/gadget/function/f_fs.c
2148
2149 static int do_function_enable_interface(enum ffs_entity_type type, u8
*valuep,
2150 struct usb_descriptor_header
*desc,
2151 void *priv);
2152
2153 static int do_function_disable_interface(enum ffs_entity_type type, u8
*valuep,
2154 struct usb_descriptor_header
*desc,
2155 void *priv);
2156
2157 static int __must_check ffs_do_descs_alt_intf(unsigned int count, char
*data,
2158 unsigned int len, unsigned int
intf,
2159 unsigned int alt, void *priv)
2160 {
2161 const unsigned int _len = len;
2162 unsigned long num = 0;
2163 struct usb_descriptor_header *_ds;
2164 struct usb_interface_descriptor *idecs;
2165 ffs_entity_callback entity = NULL;
2166
2167 ENTER();
2168
2169 for (;;) {
2170 int ret;
2171
2172 if (num == count)
2173 data = NULL;
2174
2175 if (!data) {
2176 pr_vdebug("%s Exiting. No more Data\n",
__func__);
2177 return _len - len;
2178 }
2179
2180 _ds = (void *)data;
2181 if (_ds->bDescriptorType == USB_DT_INTERFACE) {
2182 idecs = (void *)_ds;
2183
2184 /*Check the interface no to deal with */
2185 if (idecs->bInterfaceNumber == intf) {
2186 if (idecs->bAlternateSetting == alt)
2187 entity =
do_function_enable_interface;
2188 else
2189 entity =
do_function_disable_interface;
2190 } else if (entity &&
2191 (idecs->bInterfaceNumber !=
intf)) {
2192 pr_vdebug(
2193 "%s Exiting.Moved past the interface
no\n",
2194
__func__);
2195 return _len - len;
2196 }
2197 }
> 2198 ret = ffs_do_single_desc(data, len, entity, priv);
2199 if (unlikely(ret < 0)) {
2200 pr_err("%s Exiting with err %d\n", __func__,
ret);
2201 return ret;
2202 }
2203
2204 len -= ret;
2205 data += ret;
2206 ++num;
2207 }
2208 }
2209
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH v2] usb: chipidea: imx: Allow OC polarity active low
Hi Matthew,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.20-rc4 next-20181130]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Matthew-Starr/usb-chipidea-imx-Allow-OC-polarity-active-low/20181202-132847
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: x86_64-randconfig-x000-201848 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/usb/chipidea/usbmisc_imx.c: In function 'usbmisc_imx7d_init':
>> drivers/usb/chipidea/usbmisc_imx.c:452:2: error: expected '}' before 'else'
else {
^~~~
vim +452 drivers/usb/chipidea/usbmisc_imx.c
434
435 static int usbmisc_imx7d_init(struct imx_usbmisc_data *data)
436 {
437 struct imx_usbmisc *usbmisc = dev_get_drvdata(data->dev);
438 unsigned long flags;
439 u32 reg;
440
441 if (data->index >= 1)
442 return -EINVAL;
443
444 spin_lock_irqsave(&usbmisc->lock, flags);
445 reg = readl(usbmisc->base);
446 if (data->disable_oc) {
447 reg |= MX6_BM_OVER_CUR_DIS;
448 } else if (data->oc_polarity == 1) {
449 /* Low active */
450 reg &= ~(MX6_BM_OVER_CUR_DIS);
451 reg |= MX6_BM_OVER_CUR_POLARITY;
> 452 else {
453 reg &= ~(MX6_BM_OVER_CUR_DIS |
MX6_BM_OVER_CUR_POLARITY);
454 }
455 writel(reg, usbmisc->base);
456
457 reg = readl(usbmisc->base + MX7D_USBNC_USB_CTRL2);
458 reg &= ~MX7D_USB_VBUS_WAKEUP_SOURCE_MASK;
459 writel(reg | MX7D_USB_VBUS_WAKEUP_SOURCE_BVALID,
460 usbmisc->base + MX7D_USBNC_USB_CTRL2);
461 spin_unlock_irqrestore(&usbmisc->lock, flags);
462
463 usbmisc_imx7d_set_wakeup(data, false);
464
465 return 0;
466 }
467
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH 1/2] phy: core: Add phy_pm_runtime_enabled
Hi Tony,
I love your patch! Yet something to improve:
[auto build test ERROR on phy/next]
[also build test ERROR on v4.20-rc3 next-20181119]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Tony-Lindgren/Improve-phy-mapphone-pm/20181119-222603
base: https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git
next
config: riscv-tinyconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 8.1.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=riscv
All errors (new ones prefixed by >>):
In file included from include/linux/usb/otg.h:13,
from include/linux/usb/of.h:12,
from drivers/usb/phy/of.c:9:
include/linux/phy/phy.h: In function 'phy_pm_runtime_enabled':
>> include/linux/phy/phy.h:246:14: error: expected ';' before '}' token
return false
^
;
}
~
vim +246 include/linux/phy/phy.h
243
244 static inline bool phy_pm_runtime_enabled(struct phy *phy)
245 {
> 246 return false
247 }
248
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[balbi-usb:testing/next 17/22] drivers/usb/dwc3/drd.c:604: undefined reference to `usb_role_switch_unregister'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
testing/next
head: bad6c1502dac79c80ad5a7149fa308849c0191dd
commit: 24e2238d8c102f242ece57f45fbeb4014929aad4 [17/22] usb: dwc3: drd:
Register a USB role switch
config: x86_64-randconfig-s4-11151335 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 24e2238d8c102f242ece57f45fbeb4014929aad4
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/usb/dwc3/drd.o: In function `dwc3_drd_exit':
>> drivers/usb/dwc3/drd.c:604: undefined reference to
>> `usb_role_switch_unregister'
drivers/usb/dwc3/drd.o: In function `dwc3_drd_init':
>> drivers/usb/dwc3/drd.c:563: undefined reference to `usb_role_switch_register'
>> drivers/usb/dwc3/drd.c:563: undefined reference to `usb_role_switch_register'
vim +604 drivers/usb/dwc3/drd.c
514
515 int dwc3_drd_init(struct dwc3 *dwc)
516 {
517 int ret, irq;
518
519 dwc->edev = dwc3_get_extcon(dwc);
520 if (IS_ERR(dwc->edev))
521 return PTR_ERR(dwc->edev);
522
523 if (dwc->edev) {
524 dwc->edev_nb.notifier_call = dwc3_drd_notifier;
525 ret = extcon_register_notifier(dwc->edev,
EXTCON_USB_HOST,
526 &dwc->edev_nb);
527 if (ret < 0) {
528 dev_err(dwc->dev, "couldn't register cable
notifier\n");
529 return ret;
530 }
531
532 dwc3_drd_update(dwc);
533 } else {
534 dwc3_set_prtcap(dwc, DWC3_GCTL_PRTCAP_OTG);
535 dwc->current_dr_role = DWC3_GCTL_PRTCAP_OTG;
536
537 /* use OTG block to get ID event */
538 irq = dwc3_otg_get_irq(dwc);
539 if (irq < 0)
540 return irq;
541
542 dwc->otg_irq = irq;
543
544 /* disable all OTG IRQs */
545 dwc3_otg_disable_events(dwc, DWC3_OTG_ALL_EVENTS);
546 /* clear all events */
547 dwc3_otg_clear_events(dwc);
548
549 ret = request_threaded_irq(dwc->otg_irq, dwc3_otg_irq,
550 dwc3_otg_thread_irq,
551 IRQF_SHARED, "dwc3-otg",
dwc);
552 if (ret) {
553 dev_err(dwc->dev, "failed to request irq #%d
--> %d\n",
554 dwc->otg_irq, ret);
555 ret = -ENODEV;
556 return ret;
557 }
558
559 dwc3_otg_init(dwc);
560 dwc3_set_mode(dwc, DWC3_GCTL_PRTCAP_OTG);
561 }
562
> 563 dwc->role_sw = usb_role_switch_register(dwc->dev,
> &dwc3_role_switch);
564 if (ret) {
565 dwc3_drd_exit(dwc);
566 return PTR_ERR(dwc->role_sw);
567 }
568 return 0;
569 }
570
571 void dwc3_drd_exit(struct dwc3 *dwc)
572 {
573 unsigned long flags;
574
575 if (dwc->edev)
576 extcon_unregister_notifier(dwc->edev, EXTCON_USB_HOST,
577 &dwc->edev_nb);
578
579 cancel_work_sync(&dwc->drd_work);
580
581 /* debug user might have changed role, clean based on current
role */
582 switch (dwc->current_dr_role) {
583 case DWC3_GCTL_PRTCAP_HOST:
584 dwc3_host_exit(dwc);
585 break;
586 case DWC3_GCTL_PRTCAP_DEVICE:
587 dwc3_gadget_exit(dwc);
588 dwc3_event_buffers_cleanup(dwc);
589 break;
590 case DWC3_GCTL_PRTCAP_OTG:
591 dwc3_otg_exit(dwc);
592 spin_lock_irqsave(&dwc->lock, flags);
593 dwc->desired_otg_role = DWC3_OTG_ROLE_IDLE;
594 spin_unlock_irqrestore(&dwc->lock, flags);
595 dwc3_otg_update(dwc, 1);
596 break;
597 default:
598 break;
599 }
600
601 if (!dwc->edev)
602 free_irq(dwc->otg_irq, dwc);
603
> 604 usb_role_switch_unregister(dwc->role_sw);
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[balbi-usb:testing/next 17/22] drivers/usb/dwc3/drd.c:491:2-3: Unneeded semicolon
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next head: bad6c1502dac79c80ad5a7149fa308849c0191dd commit: 24e2238d8c102f242ece57f45fbeb4014929aad4 [17/22] usb: dwc3: drd: Register a USB role switch coccinelle warnings: (new ones prefixed by >>) >> drivers/usb/dwc3/drd.c:491:2-3: Unneeded semicolon Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[PATCH] usb: dwc3: drd: fix semicolon.cocci warnings
From: kbuild test robot
drivers/usb/dwc3/drd.c:491:2-3: Unneeded semicolon
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: 24e2238d8c10 ("usb: dwc3: drd: Register a USB role switch")
CC: Heikki Krogerus
Signed-off-by: kbuild test robot
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git
testing/next
head: bad6c1502dac79c80ad5a7149fa308849c0191dd
commit: 24e2238d8c102f242ece57f45fbeb4014929aad4 [17/22] usb: dwc3: drd:
Register a USB role switch
drd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/dwc3/drd.c
+++ b/drivers/usb/dwc3/drd.c
@@ -488,7 +488,7 @@ static int dwc3_usb_role_switch_set(stru
default:
mode = DWC3_GCTL_PRTCAP_OTG;
break;
- };
+ }
dwc3_set_mode(dev_get_drvdata(dev), mode);
return 0;
Re: [PATCH V4 5/5] usb: host: Add ability to build new Broadcom STB USB drivers
Hi Al, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on v4.20-rc1 next-20181109] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Al-Cooper/Add-XHCI-EHCI-and-OHCI-support-for-Broadcom-STB-SoS-s/20181110-065441 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing coccinelle warnings: (new ones prefixed by >>) >> drivers/usb/host/ehci-brcm.c:258:3-8: No need to set .owner here. The core >> will do it. Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
[PATCH] usb: host: fix platform_no_drv_owner.cocci warnings
From: kbuild test robot
drivers/usb/host/ehci-brcm.c:258:3-8: No need to set .owner here. The core will
do it.
Remove .owner field if calls are used which set it automatically
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Fixes: 51b4c79a49f1 ("usb: host: Add ability to build new Broadcom STB USB
drivers")
CC: Al Cooper
Signed-off-by: kbuild test robot
---
url:
https://github.com/0day-ci/linux/commits/Al-Cooper/Add-XHCI-EHCI-and-OHCI-support-for-Broadcom-STB-SoS-s/20181110-065441
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
ehci-brcm.c |1 -
1 file changed, 1 deletion(-)
--- a/drivers/usb/host/ehci-brcm.c
+++ b/drivers/usb/host/ehci-brcm.c
@@ -255,7 +255,6 @@ static struct platform_driver ehci_brcm_
.remove = ehci_brcm_remove,
.shutdown = usb_hcd_platform_shutdown,
.driver = {
- .owner = THIS_MODULE,
.name = "ehci-brcm",
.pm = &ehci_brcm_pm_ops,
.of_match_table = brcm_ehci_of_match,
Re: [PATCH] usb: gadget: f_fs: Allow scatter-gather buffers
Hi Andrzej,
I love your patch! Yet something to improve:
[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.20-rc1 next-20181109]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Andrzej-Pietrasiewicz/usb-gadget-f_fs-Allow-scatter-gather-buffers/20181109-194916
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=sparc64
All error/warnings (new ones prefixed by >>):
drivers/usb/gadget/function/f_fs.c: In function 'ffs_build_sg_list':
>> drivers/usb/gadget/function/f_fs.c:769:10: error: implicit declaration of
>> function 'vmalloc'; did you mean 'kvmalloc'?
>> [-Werror=implicit-function-declaration]
vaddr = vmalloc(size);
^~~
kvmalloc
>> drivers/usb/gadget/function/f_fs.c:769:8: warning: assignment makes pointer
>> from integer without a cast [-Wint-conversion]
vaddr = vmalloc(size);
^
>> drivers/usb/gadget/function/f_fs.c:778:3: error: implicit declaration of
>> function 'vfree'; did you mean 'kvfree'?
>> [-Werror=implicit-function-declaration]
vfree(vaddr);
^
kvfree
cc1: some warnings being treated as errors
vim +769 drivers/usb/gadget/function/f_fs.c
755
756 /*
757 * allocate a virtually contiguous buffer and create a scatterlist
describing it
758 * @sg_table- pointer to a place to be filled with sg_table contents
759 * @size- required buffer size
760 */
761 static void *ffs_build_sg_list(struct sg_table *sg_table, size_t size)
762 {
763 struct page **pages;
764 void *vaddr;
765 unsigned long ptr;
766 unsigned int n_pages;
767 int i;
768
> 769 vaddr = vmalloc(size);
770 if (!vaddr)
771 return NULL;
772
773 n_pages = (PAGE_ALIGN((unsigned long)vaddr + size) -
774 ((unsigned long)vaddr & PAGE_MASK))
775 >> PAGE_SHIFT;
776 pages = kvmalloc_array(n_pages, sizeof(struct page *),
GFP_KERNEL);
777 if (!pages) {
> 778 vfree(vaddr);
779
780 return NULL;
781 }
782 for (i = 0, ptr = (unsigned long)vaddr & PAGE_MASK; i < n_pages;
783 ++i, ptr += PAGE_SIZE)
784 pages[i] = vmalloc_to_page((void *)ptr);
785
786 if (sg_alloc_table_from_pages(sg_table, pages, n_pages,
787 ((unsigned long)vaddr) & ~PAGE_MASK, size, GFP_KERNEL))
{
788 kvfree(pages);
789 vfree(vaddr);
790
791 return NULL;
792 }
793 kvfree(pages);
794
795 return vaddr;
796 }
797
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH 2/3] spi: add FTDI MPSSE SPI controller driver
Hi Anatolij,
I love your patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.20-rc1 next-20181105]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Anatolij-Gustschin/Add-support-for-ARRI-FPGA-configuration/20181106-090458
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
>> drivers//spi/spi-ftdi-mpsse.c:27:2: error: expected identifier before
>> numeric constant
CS = BIT(3),
^~
vim +27 drivers//spi/spi-ftdi-mpsse.c
22
23 enum gpiol {
24 SK = BIT(0),
25 DO = BIT(1),
26 DI = BIT(2),
> 27 CS = BIT(3),
28 };
29
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH 2/3] spi: add FTDI MPSSE SPI controller driver
Hi Anatolij,
I love your patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.20-rc1 next-20181105]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Anatolij-Gustschin/Add-support-for-ARRI-FPGA-configuration/20181106-090458
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
In file included from arch/x86/include/uapi/asm/ptrace.h:6:0,
from arch/x86/include/asm/ptrace.h:7,
from arch/x86/include/asm/math_emu.h:5,
from arch/x86/include/asm/processor.h:12,
from arch/x86/include/asm/cpufeature.h:8,
from arch/x86/include/asm/thread_info.h:53,
from include/linux/thread_info.h:38,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:81,
from include/linux/spinlock.h:51,
from include/linux/seqlock.h:36,
from include/linux/time.h:6,
from include/linux/stat.h:19,
from include/linux/module.h:10,
from drivers/spi/spi-ftdi-mpsse.c:11:
>> arch/x86/include/uapi/asm/ptrace-abi.h:20:13: error: expected identifier
>> before numeric constant
#define CS 13
^
>> drivers/spi/spi-ftdi-mpsse.c:27:2: note: in expansion of macro 'CS'
CS = BIT(3),
^~
vim +/CS +27 drivers/spi/spi-ftdi-mpsse.c
> 11 #include
12 #include
13 #include
14 #include
15 #include
16 #include
17 #include
18 #include
19 #include
20 #include
21 #include
22
23 enum gpiol {
24 SK = BIT(0),
25 DO = BIT(1),
26 DI = BIT(2),
> 27 CS = BIT(3),
28 };
29
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] USB: serial: io_ti: Replaced simple_strtoul with kstrtoul + Formatting issues
Hi Ivan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v4.20-rc1 next-20181105]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ivan-Roman/USB-serial-io_ti-Replaced-simple_strtoul-with-kstrtoul-Formatting-issues/20181105-194308
config: x86_64-randconfig-x018-201844 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In file included from include/uapi/linux/posix_types.h:5:0,
from include/uapi/linux/types.h:14,
from include/linux/compiler.h:163,
from include/linux/export.h:45,
from include/linux/linkage.h:7,
from include/linux/kernel.h:7,
from drivers/usb/serial/io_ti.c:16:
drivers/usb/serial/io_ti.c: In function 'uart_mode_store':
>> include/linux/stddef.h:8:14: warning: passing argument 2 of 'kstrtoul' makes
>> integer from pointer without a cast [-Wint-conversion]
#define NULL ((void *)0)
^
>> drivers/usb/serial/io_ti.c:2656:36: note: in expansion of macro 'NULL'
unsigned int v = kstrtoul(valbuf, NULL, 0);
^~~~
In file included from drivers/usb/serial/io_ti.c:16:0:
include/linux/kernel.h:366:32: note: expected 'unsigned int' but argument is
of type 'void *'
static inline int __must_check kstrtoul(const char *s, unsigned int base,
unsigned long *res)
^~~~
--
In file included from include/uapi/linux/posix_types.h:5:0,
from include/uapi/linux/types.h:14,
from include/linux/compiler.h:163,
from include/linux/export.h:45,
from include/linux/linkage.h:7,
from include/linux/kernel.h:7,
from drivers/usb//serial/io_ti.c:16:
drivers/usb//serial/io_ti.c: In function 'uart_mode_store':
>> include/linux/stddef.h:8:14: warning: passing argument 2 of 'kstrtoul' makes
>> integer from pointer without a cast [-Wint-conversion]
#define NULL ((void *)0)
^
drivers/usb//serial/io_ti.c:2656:36: note: in expansion of macro 'NULL'
unsigned int v = kstrtoul(valbuf, NULL, 0);
^~~~
In file included from drivers/usb//serial/io_ti.c:16:0:
include/linux/kernel.h:366:32: note: expected 'unsigned int' but argument is
of type 'void *'
static inline int __must_check kstrtoul(const char *s, unsigned int base,
unsigned long *res)
^~~~
vim +/NULL +2656 drivers/usb/serial/io_ti.c
2650
2651 static ssize_t uart_mode_store(struct device *dev,
2652 struct device_attribute *attr, const char *valbuf, size_t count)
2653 {
2654 struct usb_serial_port *port = to_usb_serial_port(dev);
2655 struct edgeport_port *edge_port =
usb_get_serial_port_data(port);
> 2656 unsigned int v = kstrtoul(valbuf, NULL, 0);
2657
2658 dev_dbg(dev, "%s: setting uart_mode = %d\n", __func__, v);
2659
2660 if (v < 256)
2661 edge_port->bUartMode = v;
2662 else
2663 dev_err(dev, "%s - uart_mode %d is invalid\n",
__func__, v);
2664
2665 return count;
2666 }
2667 static DEVICE_ATTR_RW(uart_mode);
2668
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] USB: Don't enable LPM if it's already enabled
Hi Kai-Heng,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v4.19 next-20181029]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Kai-Heng-Feng/USB-Don-t-enable-LPM-if-it-s-already-enabled/20181030-135717
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: i386-randconfig-x074-201843 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/usb//core/driver.c: In function 'usb_set_usb2_hardware_lpm':
>> drivers/usb//core/driver.c:1904:13: warning: suggest parentheses around '&&'
>> within '||' [-Wparentheses]
if (enable && !udev->usb2_hw_lpm_allowed ||
~~~^
vim +1904 drivers/usb//core/driver.c
1898
1899 int usb_set_usb2_hardware_lpm(struct usb_device *udev, int enable)
1900 {
1901 struct usb_hcd *hcd = bus_to_hcd(udev->bus);
1902 int ret = -EPERM;
1903
> 1904 if (enable && !udev->usb2_hw_lpm_allowed ||
1905 udev->usb2_hw_lpm_enabled == enable)
1906 return 0;
1907
1908 if (hcd->driver->set_usb2_hw_lpm) {
1909 ret = hcd->driver->set_usb2_hw_lpm(hcd, udev, enable);
1910 if (!ret)
1911 udev->usb2_hw_lpm_enabled = enable;
1912 }
1913
1914 return ret;
1915 }
1916
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] USB: Don't enable LPM if it's already enabled
Hi Kai-Heng,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v4.19 next-20181029]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Kai-Heng-Feng/USB-Don-t-enable-LPM-if-it-s-already-enabled/20181030-135717
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: x86_64-randconfig-x002-201843 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In file included from include/linux/ioport.h:13:0,
from include/linux/device.h:15,
from drivers/usb/core/driver.c:28:
drivers/usb/core/driver.c: In function 'usb_set_usb2_hardware_lpm':
drivers/usb/core/driver.c:1904:13: warning: suggest parentheses around '&&'
within '||' [-Wparentheses]
if (enable && !udev->usb2_hw_lpm_allowed ||
~~~^~~
include/linux/compiler.h:58:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> drivers/usb/core/driver.c:1904:2: note: in expansion of macro 'if'
if (enable && !udev->usb2_hw_lpm_allowed ||
^~
drivers/usb/core/driver.c:1904:13: warning: suggest parentheses around '&&'
within '||' [-Wparentheses]
if (enable && !udev->usb2_hw_lpm_allowed ||
~~~^~~
include/linux/compiler.h:58:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> drivers/usb/core/driver.c:1904:2: note: in expansion of macro 'if'
if (enable && !udev->usb2_hw_lpm_allowed ||
^~
drivers/usb/core/driver.c:1904:13: warning: suggest parentheses around '&&'
within '||' [-Wparentheses]
if (enable && !udev->usb2_hw_lpm_allowed ||
~~~^~~
include/linux/compiler.h:69:16: note: in definition of macro '__trace_if'
__r = !!(cond); \
^~~~
>> drivers/usb/core/driver.c:1904:2: note: in expansion of macro 'if'
if (enable && !udev->usb2_hw_lpm_allowed ||
^~
vim +/if +1904 drivers/usb/core/driver.c
1898
1899 int usb_set_usb2_hardware_lpm(struct usb_device *udev, int enable)
1900 {
1901 struct usb_hcd *hcd = bus_to_hcd(udev->bus);
1902 int ret = -EPERM;
1903
> 1904 if (enable && !udev->usb2_hw_lpm_allowed ||
1905 udev->usb2_hw_lpm_enabled == enable)
1906 return 0;
1907
1908 if (hcd->driver->set_usb2_hw_lpm) {
1909 ret = hcd->driver->set_usb2_hw_lpm(hcd, udev, enable);
1910 if (!ret)
1911 udev->usb2_hw_lpm_enabled = enable;
1912 }
1913
1914 return ret;
1915 }
1916
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH V2 3/6] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's
Hi Al,
I love your patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.19-rc8 next-20181018]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Al-Cooper/Add-XHCI-EHCI-and-OHCI-support-for-Broadcom-STB-SoS-s/20181019-001132
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: i386-randconfig-s2-201841 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
>> drivers/usb/host/xhci-plat.c:117:16: error: 'xhci_plat_brcm_init_quirk'
>> undeclared here (not in a function)
.init_quirk = xhci_plat_brcm_init_quirk
^
vim +/xhci_plat_brcm_init_quirk +117 drivers/usb/host/xhci-plat.c
115
116 static const struct xhci_plat_priv xhci_plat_brcm = {
> 117 .init_quirk = xhci_plat_brcm_init_quirk
118 };
119
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH V2 3/6] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's
Hi Al,
I love your patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.19-rc8 next-20181018]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Al-Cooper/Add-XHCI-EHCI-and-OHCI-support-for-Broadcom-STB-SoS-s/20181019-001132
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: x86_64-randconfig-x017-201841 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
Note: the
linux-review/Al-Cooper/Add-XHCI-EHCI-and-OHCI-support-for-Broadcom-STB-SoS-s/20181019-001132
HEAD 80aedf2037a6c697bfe2193ffbb635e4ab26a0b6 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
>> drivers/usb//host/xhci-plat.c:117:16: error: 'xhci_plat_brcm_init_quirk'
>> undeclared here (not in a function); did you mean 'xhci_brcm_init_quirk'?
.init_quirk = xhci_plat_brcm_init_quirk
^
xhci_brcm_init_quirk
vim +117 drivers/usb//host/xhci-plat.c
115
116 static const struct xhci_plat_priv xhci_plat_brcm = {
> 117 .init_quirk = xhci_plat_brcm_init_quirk
118 };
119
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH 2/4] usb: chipidea: imx: add HSIC support
Hi Peter,
I love your patch! Yet something to improve:
[auto build test ERROR on peter.chen-usb/ci-for-usb-next]
[also build test ERROR on v4.19-rc8 next-20181012]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Peter-Chen/usb-chipidea-imx-add-HSIC-support/20181016-130840
base: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git
ci-for-usb-next
config: x86_64-randconfig-x017-201841 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/usb/chipidea/ci_hdrc_imx.c: In function 'ci_hdrc_imx_notify_event':
>> drivers/usb/chipidea/ci_hdrc_imx.c:261:10: error: implicit declaration of
>> function 'pinctrl_select_state'; did you mean 'inc_node_state'?
>> [-Werror=implicit-function-declaration]
ret = pinctrl_select_state(data->pinctrl,
^~~~
inc_node_state
drivers/usb/chipidea/ci_hdrc_imx.c: In function 'ci_hdrc_imx_probe':
drivers/usb/chipidea/ci_hdrc_imx.c:317:18: error: implicit declaration of
function 'devm_pinctrl_get'; did you mean 'devm_clk_get'?
[-Werror=implicit-function-declaration]
data->pinctrl = devm_pinctrl_get(dev);
^~~~
devm_clk_get
drivers/usb/chipidea/ci_hdrc_imx.c:317:16: warning: assignment makes pointer
from integer without a cast [-Wint-conversion]
data->pinctrl = devm_pinctrl_get(dev);
^
>> drivers/usb/chipidea/ci_hdrc_imx.c:322:23: error: implicit declaration of
>> function 'pinctrl_lookup_state'; did you mean 'inc_node_state'?
>> [-Werror=implicit-function-declaration]
pinctrl_hsic_idle = pinctrl_lookup_state(data->pinctrl, "idle");
^~~~
inc_node_state
drivers/usb/chipidea/ci_hdrc_imx.c:322:21: warning: assignment makes pointer
from integer without a cast [-Wint-conversion]
pinctrl_hsic_idle = pinctrl_lookup_state(data->pinctrl, "idle");
^
drivers/usb/chipidea/ci_hdrc_imx.c:338:29: warning: assignment makes pointer
from integer without a cast [-Wint-conversion]
data->pinctrl_hsic_active = pinctrl_lookup_state(data->pinctrl,
^
cc1: some warnings being treated as errors
vim +261 drivers/usb/chipidea/ci_hdrc_imx.c
250
251 static int ci_hdrc_imx_notify_event(struct ci_hdrc *ci, unsigned int
event)
252 {
253 struct device *dev = ci->dev->parent;
254 struct ci_hdrc_imx_data *data = dev_get_drvdata(dev);
255 int ret = 0;
256
257 switch (event) {
258 case CI_HDRC_IMX_HSIC_ACTIVE_EVENT:
259 if (!IS_ERR(data->pinctrl) &&
260 !IS_ERR(data->pinctrl_hsic_active)) {
> 261 ret = pinctrl_select_state(data->pinctrl,
262 data->pinctrl_hsic_active);
263 if (ret)
264 dev_err(dev,
265 "hsic_active select failed,
err=%d\n",
266 ret);
267 return ret;
268 }
269 break;
270 case CI_HDRC_IMX_HSIC_SUSPEND_EVENT:
271 if (data->usbmisc_data) {
272 ret =
imx_usbmisc_hsic_set_connect(data->usbmisc_data);
273 if (ret)
274 dev_err(dev,
275 "hsic_set_connect failed,
err=%d\n",
276 ret);
277 return ret;
278 }
279 break;
280 default:
281 break;
282 }
283
284 return ret;
285 }
286
287 static int ci_hdrc_imx_probe(struct platform_device *pdev)
288 {
289 struct ci_hdrc_imx_data *data;
290 struct ci_hdrc_platform_data pdata = {
291 .name = dev_name(&pdev->dev),
292 .capoffset = DEF_CAPOFFSET,
293 .notify_event = ci_hdrc_imx_notify_event,
294 };
295 int ret;
296 const struct of_device_id *of_id;
297 const struct ci_hdrc_imx_platform_flag *imx_platform_flag;
298 struct device_node *np = pdev->dev.of_node;
299 struct device *dev = &pdev->dev;
300 struct pinctrl_state *pinctrl_hsic_idle;
301
302 of_id = of_match_device(ci_hdrc_imx_dt_ids, dev);
303 if (!of_id)
304 return -ENODEV
[hid:for-4.20/google 2/3] drivers/hid/hid-google-hammer.c:73: undefined reference to `cros_ec_cmd_xfer_status'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git
for-4.20/google
head: 8f35260e0b6cc09d77bcbbc21554342aa79ceb2f
commit: eb1aac4c8744f75460c34d71b0c73bebf3e8ee5c [2/3] HID: google: add support
tablet mode switch for Whiskers
config: x86_64-randconfig-s3-10092338 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout eb1aac4c8744f75460c34d71b0c73bebf3e8ee5c
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/hid/hid-google-hammer.o: In function `cbas_ec_query_base':
>> drivers/hid/hid-google-hammer.c:73: undefined reference to
>> `cros_ec_cmd_xfer_status'
vim +73 drivers/hid/hid-google-hammer.c
51
52 static int cbas_ec_query_base(struct cros_ec_device *ec_dev, bool
get_state,
53bool *state)
54 {
55 struct ec_params_mkbp_info *params;
56 struct cros_ec_command *msg;
57 int ret;
58
59 msg = kzalloc(sizeof(*msg) + max(sizeof(u32), sizeof(*params)),
60GFP_KERNEL);
61 if (!msg)
62 return -ENOMEM;
63
64 msg->command = EC_CMD_MKBP_INFO;
65 msg->version = 1;
66 msg->outsize = sizeof(*params);
67 msg->insize = sizeof(u32);
68 params = (struct ec_params_mkbp_info *)msg->data;
69 params->info_type = get_state ?
70 EC_MKBP_INFO_CURRENT : EC_MKBP_INFO_SUPPORTED;
71 params->event_type = EC_MKBP_EVENT_SWITCH;
72
> 73 ret = cros_ec_cmd_xfer_status(ec_dev, msg);
74 if (ret >= 0) {
75 if (ret != sizeof(u32)) {
76 dev_warn(ec_dev->dev, "wrong result size: %d !=
%zu\n",
77 ret, sizeof(u32));
78 ret = -EPROTO;
79 } else {
80 *state = cbas_parse_base_state(msg->data);
81 ret = 0;
82 }
83 }
84
85 kfree(msg);
86
87 return ret;
88 }
89
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[hid:for-4.20/google 2/3] ERROR: "cros_ec_cmd_xfer_status" [drivers/hid/hid-google-hammer.ko] undefined!
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-4.20/google head: 8f35260e0b6cc09d77bcbbc21554342aa79ceb2f commit: eb1aac4c8744f75460c34d71b0c73bebf3e8ee5c [2/3] HID: google: add support tablet mode switch for Whiskers config: x86_64-randconfig-s0-10091927 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: git checkout eb1aac4c8744f75460c34d71b0c73bebf3e8ee5c # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): >> ERROR: "cros_ec_cmd_xfer_status" [drivers/hid/hid-google-hammer.ko] >> undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v2] usb: export firmware port location in sysfs
Hi Bjørn,
I love your patch! Perhaps something to improve:
[auto build test WARNING on peter.chen-usb/ci-for-usb-next]
[also build test WARNING on v4.19-rc5 next-20180928]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Bj-rn-Mork/usb-export-firmware-port-location-in-sysfs/20180928-192720
base: https://git.kernel.org/pub/scm/linux/kernel/git/peter.chen/usb.git
ci-for-usb-next
config: i386-randconfig-x005-201838 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
In file included from include/linux/pm_qos.h:10:0,
from drivers/usb//core/port.c:11:
include/linux/device.h:598:26: warning: 'dev_attr_location' defined but not
used [-Wunused-variable]
struct device_attribute dev_attr_##_name = __ATTR_RO(_name)
^
>> drivers/usb//core/port.c:26:8: note: in expansion of macro 'DEVICE_ATTR_RO'
static DEVICE_ATTR_RO(location);
^~
vim +/DEVICE_ATTR_RO +26 drivers/usb//core/port.c
> 11 #include
12
13 #include "hub.h"
14
15 static int usb_port_block_power_off;
16
17 static const struct attribute_group *port_dev_group[];
18
19 static ssize_t location_show(struct device *dev,
20 struct device_attribute *attr, char *buf)
21 {
22 struct usb_port *port_dev = to_usb_port(dev);
23
24 return sprintf(buf, "0x%08x\n", port_dev->location);
25 }
> 26 static DEVICE_ATTR_RO(location);
27
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] usb: dwc2: Disable all EP's on disconnect
Hi Minas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on balbi-usb/next]
[also build test WARNING on v4.19-rc4 next-20180918]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Minas-Harutyunyan/usb-dwc2-Disable-all-EP-s-on-disconnect/20180919-104259
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
>> drivers/usb/dwc2/gadget.c:4053:9: warning: context imbalance in
>> 'dwc2_hsotg_ep_disable' - different lock contexts for basic block
>> drivers/usb/dwc2/gadget.c:4361:28: warning: context imbalance in
>> 'dwc2_hsotg_udc_stop' - different lock contexts for basic block
vim +/dwc2_hsotg_ep_disable +4053 drivers/usb/dwc2/gadget.c
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3993
8b9bc4608 drivers/usb/gadget/s3c-hsotg.c Lukasz Majewski2012-05-04 3994
/**
1f91b4cc0 drivers/usb/dwc2/gadget.c Felipe Balbi 2015-08-06 3995
* dwc2_hsotg_ep_disable - disable given endpoint
8b9bc4608 drivers/usb/gadget/s3c-hsotg.c Lukasz Majewski2012-05-04 3996
* @ep: The endpoint to disable.
8b9bc4608 drivers/usb/gadget/s3c-hsotg.c Lukasz Majewski2012-05-04 3997
*/
1f91b4cc0 drivers/usb/dwc2/gadget.c Felipe Balbi 2015-08-06 3998
static int dwc2_hsotg_ep_disable(struct usb_ep *ep)
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3999 {
1f91b4cc0 drivers/usb/dwc2/gadget.c Felipe Balbi 2015-08-06 4000
struct dwc2_hsotg_ep *hs_ep = our_ep(ep);
941fcce4f drivers/usb/dwc2/gadget.c Dinh Nguyen2014-11-11 4001
struct dwc2_hsotg *hsotg = hs_ep->parent;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 4002
int dir_in = hs_ep->dir_in;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 4003
int index = hs_ep->index;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 4004
unsigned long flags;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 4005
u32 epctrl_reg;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 4006
u32 ctrl;
a4705c3fe drivers/usb/dwc2/gadget.c Minas Harutyunyan 2018-09-18 4007
int locked;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 4008
1e0112937 drivers/usb/dwc2/gadget.c Marek Szyprowski 2014-09-09 4009
dev_dbg(hsotg->dev, "%s(ep %p)\n", __func__, ep);
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 4010
c6f5c050e drivers/usb/dwc2/gadget.c Mian Yousaf Kaukab 2015-01-09 4011
if (ep == &hsotg->eps_out[0]->ep) {
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 4012
dev_err(hsotg->dev, "%s: called for ep0\n", __func__);
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 4013
return -EINVAL;
9b481092c drivers/usb/dwc2/gadget.c John Stultz2017-10-23 4014
}
9b481092c drivers/usb/dwc2/gadget.c John Stultz2017-10-23 4015
9b481092c drivers/usb/dwc2/gadget.c John Stultz2017-10-23 4016
if (hsotg->op_state != OTG_STATE_B_PERIPHERAL) {
9b481092c drivers/usb/dwc2/gadget.c John Stultz2017-10-23 4017
dev_err(hsotg->dev, "%s: called in host mode?\n", __func__);
9b481092c drivers/usb/dwc2/gadget.c John Stultz2017-10-23 4018
return -EINVAL;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 4019
}
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 4020
94cb8fd63 drivers/usb/gadget/s3c-hsotg.c Lukasz Majewski2012-05-04 4021
epctrl_reg = dir_in ? DIEPCTL(index) : DOEPCTL(index);
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 4022
a4705c3fe drivers/usb/dwc2/gadget.c Minas Harutyunyan 2018-09-18 4023
locked = spin_trylock(&hsotg->lock);
a4705c3fe drivers/usb/dwc2/gadget.c Minas Harutyunyan 2018-09-18 4024
spin_unlock(&hsotg->lock);
5ad1d3160 drivers/usb/gadget/s3c-hsotg.c Lukasz Majewski2012-06-14 4025
spin_lock_irqsave(&hsotg->lock, flags);
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 4026
f25c42b8d drivers/usb/dwc2/gadget.c Gevorg Sahakyan2018-07-26 4027
ctrl = dwc2_readl(hsotg, epctrl_reg);
a4f827714 drivers/usb/dwc2/gadget.c Vahram Aharonyan 2016-11-14 4028
a4f827714 drivers/usb/dwc2/gadget.c Vahram Aharonyan 2016-11-14 4029
if (ctrl & DXEPCTL_EPENA)
a4f827714 drivers/usb/dwc2/gadget.c Vahram Aharonyan 2016-11-14 4030
dwc2_hsotg_ep_stop_xfr(hsotg, hs_ep);
a4f
[hid:for-4.20/microsoft 2/3] ERROR: "input_ff_create_memless" [drivers/hid/hid-microsoft.ko] undefined!
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-4.20/microsoft head: 830e82aa48f32518dfa5335c0134f611d4bab4b2 commit: 73c5b254c36529c84c9d19e07905f7103bb32e79 [2/3] HID: microsoft: Add rumble support for Xbox One S controller config: m68k-sun3_defconfig (attached as .config) compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 73c5b254c36529c84c9d19e07905f7103bb32e79 # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=m68k Note: the hid/for-4.20/microsoft HEAD 830e82aa48f32518dfa5335c0134f611d4bab4b2 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): >> ERROR: "input_ff_create_memless" [drivers/hid/hid-microsoft.ko] undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[hid:for-4.20/microsoft 2/2] undefined reference to `input_ff_create_memless'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-4.20/microsoft head: 73c5b254c36529c84c9d19e07905f7103bb32e79 commit: 73c5b254c36529c84c9d19e07905f7103bb32e79 [2/2] HID: microsoft: Add rumble support for Xbox One S controller config: parisc-b180_defconfig (attached as .config) compiler: hppa-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout 73c5b254c36529c84c9d19e07905f7103bb32e79 # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=parisc All errors (new ones prefixed by >>): drivers/hid/hid-microsoft.o: In function `ms_probe': >> (.text+0x324): undefined reference to `input_ff_create_memless' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[hid:for-4.20/microsoft 2/2] hid-microsoft.c:undefined reference to `input_ff_create_memless'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-4.20/microsoft head: 73c5b254c36529c84c9d19e07905f7103bb32e79 commit: 73c5b254c36529c84c9d19e07905f7103bb32e79 [2/2] HID: microsoft: Add rumble support for Xbox One S controller config: i386-alldefconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: git checkout 73c5b254c36529c84c9d19e07905f7103bb32e79 # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): drivers/hid/hid-microsoft.o: In function `ms_probe': >> hid-microsoft.c:(.text+0x2d7): undefined reference to >> `input_ff_create_memless' --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
[hid:for-4.20/multitouch 1/1] drivers/hid/hid-multitouch.c:1327:5: error: 'struct hid_input' has no member named 'application'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git
for-4.20/multitouch
head: 93c61d2e6bc4849a5527e32568479ff67154870e
commit: 93c61d2e6bc4849a5527e32568479ff67154870e [1/1] HID: multitouch:
simplify the application retrieval
config: x86_64-randconfig-x018-201835 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 93c61d2e6bc4849a5527e32568479ff67154870e
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/hid/hid-multitouch.c: In function 'mt_input_mapping':
>> drivers/hid/hid-multitouch.c:1327:5: error: 'struct hid_input' has no member
>> named 'application'
hi->application = HID_DG_STYLUS;
^~
drivers/hid/hid-multitouch.c: In function 'mt_input_configured':
drivers/hid/hid-multitouch.c:1527:12: error: 'struct hid_input' has no
member named 'application'
switch (hi->application) {
^~
vim +1327 drivers/hid/hid-multitouch.c
1257
1258 #define mt_map_key_clear(c) hid_map_usage_clear(hi, usage, bit, \
1259 max, EV_KEY, (c))
1260 static int mt_input_mapping(struct hid_device *hdev, struct hid_input
*hi,
1261 struct hid_field *field, struct hid_usage *usage,
1262 unsigned long **bit, int *max)
1263 {
1264 struct mt_device *td = hid_get_drvdata(hdev);
1265 struct mt_application *application;
1266 struct mt_report_data *rdata;
1267
1268 rdata = mt_find_report_data(td, field->report);
1269 if (!rdata) {
1270 hid_err(hdev, "failed to allocate data for report\n");
1271 return 0;
1272 }
1273
1274 application = rdata->application;
1275
1276 /*
1277 * If mtclass.export_all_inputs is not set, only map fields from
1278 * TouchScreen or TouchPad collections. We need to ignore fields
1279 * that belong to other collections such as Mouse that might
have
1280 * the same GenericDesktop usages.
1281 */
1282 if (!td->mtclass.export_all_inputs &&
1283 field->application != HID_DG_TOUCHSCREEN &&
1284 field->application != HID_DG_PEN &&
1285 field->application != HID_DG_TOUCHPAD &&
1286 field->application != HID_GD_KEYBOARD &&
1287 field->application != HID_GD_SYSTEM_CONTROL &&
1288 field->application != HID_CP_CONSUMER_CONTROL &&
1289 field->application != HID_GD_WIRELESS_RADIO_CTLS &&
1290 field->application != HID_GD_SYSTEM_MULTIAXIS &&
1291 !(field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
1292application->quirks & MT_QUIRK_ASUS_CUSTOM_UP))
1293 return -1;
1294
1295 /*
1296 * Some Asus keyboard+touchpad devices have the hotkeys defined
in the
1297 * touchpad report descriptor. We need to treat these as an
array to
1298 * map usages to input keys.
1299 */
1300 if (field->application == HID_VD_ASUS_CUSTOM_MEDIA_KEYS &&
1301 application->quirks & MT_QUIRK_ASUS_CUSTOM_UP &&
1302 (usage->hid & HID_USAGE_PAGE) == HID_UP_CUSTOM) {
1303 set_bit(EV_REP, hi->input->evbit);
1304 if (field->flags & HID_MAIN_ITEM_VARIABLE)
1305 field->flags &= ~HID_MAIN_ITEM_VARIABLE;
1306 switch (usage->hid & HID_USAGE) {
1307 case 0x10: mt_map_key_clear(KEY_BRIGHTNESSDOWN);
break;
1308 case 0x20: mt_map_key_clear(KEY_BRIGHTNESSUP);
break;
1309 case 0x35: mt_map_key_clear(KEY_DISPLAY_OFF);
break;
1310 case 0x6b: mt_map_key_clear(KEY_F21);
break;
1311 case 0x6c: mt_map_key_clear(KEY_SLEEP);
break;
1312 default:
1313 return -1;
1314 }
1315 return 1;
1316 }
1317
1318 if (rdata->is_mt_collection)
1319 return mt_touch_input_mapping(hdev, hi, field, usage,
bit, max,
1320application);
1321
1322 /*
1323 * some egalax touchscreens have "application == DG_TOUCHSCREEN"
1324 * for the stylus. Overwrite the hid_input application
1325 */
1326 if (field->physical == HID_DG_STYLUS)
> 1327 hi->application = HID_DG_STYLUS;
1328
1329 /* let hid-core decide for the others */
1330 return 0;
1331 }
1332
---
0-DAY kernel test infrastructureOpen Source Technol
Re: [PATCH 2/2] usb: typec: ucsi: add support for Cypress CCGx
Hi Ajay,
I love your patch! Yet something to improve:
[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v4.19-rc1 next-20180831]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ajay-Gupta/i2c-buses-add-i2c-bus-driver-for-NVIDIA-GPU/20180827-092936
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
i2c/for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/usb//typec/ucsi/ucsi_i2c_ccg.c: In function 'ucsi_i2c_ccg_resume':
>> drivers/usb//typec/ucsi/ucsi_i2c_ccg.c:559:8: error: implicit declaration of
>> function 'ucsi_run_command'; did you mean 'ucsi_i2c_ccg_cmd'?
>> [-Werror=implicit-function-declaration]
ret = ucsi_run_command(ui->ucsi, &c, NULL, 0);
^~~~
ucsi_i2c_ccg_cmd
cc1: some warnings being treated as errors
vim +559 drivers/usb//typec/ucsi/ucsi_i2c_ccg.c
544
545 static int ucsi_i2c_ccg_resume(struct device *dev)
546 {
547 struct i2c_client *client = to_i2c_client(dev);
548 struct ucsi_i2c_ccg *ui = i2c_get_clientdata(client);
549 struct ucsi_control c;
550 int ret;
551
552 if (device_may_wakeup(dev) && ui->wake_enabled) {
553 disable_irq_wake(ui->irq);
554 ui->wake_enabled = false;
555 }
556
557 /* restore UCSI notification enable mask */
558 UCSI_CMD_SET_NTFY_ENABLE(c, UCSI_ENABLE_NTFY_ALL);
> 559 ret = ucsi_run_command(ui->ucsi, &c, NULL, 0);
560 if (ret) {
561 dev_err(ui->dev, "%s: failed to set notification enable
- %d\n",
562 __func__, ret);
563 }
564
565 return 0;
566 }
567
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH v2 2/2] usb: typec: ucsi: add support for Cypress CCGx
Hi Ajay,
I love your patch! Yet something to improve:
[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v4.19-rc1 next-20180827]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ajay-Gupta/i2c-buses-add-i2c-bus-driver-for-NVIDIA-GPU/20180827-093218
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
i2c/for-next
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/usb/typec/ucsi/ucsi_i2c_ccg.c: In function 'ucsi_i2c_ccg_resume':
>> drivers/usb/typec/ucsi/ucsi_i2c_ccg.c:559:8: error: implicit declaration of
>> function 'ucsi_run_command'; did you mean 'ucsi_i2c_ccg_cmd'?
>> [-Werror=implicit-function-declaration]
ret = ucsi_run_command(ui->ucsi, &c, NULL, 0);
^~~~
ucsi_i2c_ccg_cmd
cc1: some warnings being treated as errors
vim +559 drivers/usb/typec/ucsi/ucsi_i2c_ccg.c
544
545 static int ucsi_i2c_ccg_resume(struct device *dev)
546 {
547 struct i2c_client *client = to_i2c_client(dev);
548 struct ucsi_i2c_ccg *ui = i2c_get_clientdata(client);
549 struct ucsi_control c;
550 int ret;
551
552 if (device_may_wakeup(dev) && ui->wake_enabled) {
553 disable_irq_wake(ui->irq);
554 ui->wake_enabled = false;
555 }
556
557 /* restore UCSI notification enable mask */
558 UCSI_CMD_SET_NTFY_ENABLE(c, UCSI_ENABLE_NTFY_ALL);
> 559 ret = ucsi_run_command(ui->ucsi, &c, NULL, 0);
560 if (ret) {
561 dev_err(ui->dev, "%s: failed to set notification enable
- %d\n",
562 __func__, ret);
563 }
564
565 return 0;
566 }
567
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[usb:usb-next 36/38] drivers/usb/typec/tcpci.c:549: undefined reference to `__devm_regmap_init_i2c'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
head: aaf3f4e925dc2bdc4715142103660285632a245c
commit: 990da41530b31ed7de29340ce1d78c04bee9670c [36/38] staging: typec: tcpci:
move tcpci drivers out of staging
config: x86_64-randconfig-a0-06290727 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
git checkout 990da41530b31ed7de29340ce1d78c04bee9670c
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/usb/typec/tcpci.o: In function `tcpci_probe':
>> drivers/usb/typec/tcpci.c:549: undefined reference to
>> `__devm_regmap_init_i2c'
drivers/usb/typec/tcpci.o: In function `tcpci_i2c_driver_init':
>> drivers/usb/typec/tcpci.c:609: undefined reference to `i2c_register_driver'
drivers/usb/typec/tcpci.o: In function `tcpci_i2c_driver_exit':
>> drivers/usb/typec/tcpci.c:609: undefined reference to `i2c_del_driver'
drivers/usb/typec/tcpci_rt1711h.o: In function `rt1711h_check_revision':
>> drivers/usb/typec/tcpci_rt1711h.c:218: undefined reference to
>> `i2c_smbus_read_word_data'
drivers/usb/typec/tcpci_rt1711h.c:225: undefined reference to
`i2c_smbus_read_word_data'
drivers/usb/typec/tcpci_rt1711h.o: In function `rt1711h_probe':
>> drivers/usb/typec/tcpci_rt1711h.c:251: undefined reference to
>> `__devm_regmap_init_i2c'
drivers/usb/typec/tcpci_rt1711h.o: In function `rt1711h_i2c_driver_init':
>> drivers/usb/typec/tcpci_rt1711h.c:308: undefined reference to
>> `i2c_register_driver'
drivers/usb/typec/tcpci_rt1711h.o: In function `rt1711h_i2c_driver_exit':
>> drivers/usb/typec/tcpci_rt1711h.c:308: undefined reference to
>> `i2c_del_driver'
vim +549 drivers/usb/typec/tcpci.c
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 537
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 538 static
int tcpci_probe(struct i2c_client *client,
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 539
const struct i2c_device_id *i2c_id)
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 540 {
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 541 struct
tcpci_chip *chip;
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 542 int err;
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 543 u16 val
= 0;
74e656d6b drivers/staging/typec/tcpci.c Guenter Roeck 2017-04-27 544
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 545 chip =
devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 546 if
(!chip)
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 547
return -ENOMEM;
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 548
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 @549
chip->data.regmap = devm_regmap_init_i2c(client, &tcpci_regmap_config);
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 550 if
(IS_ERR(chip->data.regmap))
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 551
return PTR_ERR(chip->data.regmap);
74e656d6b drivers/staging/typec/tcpci.c Guenter Roeck 2017-04-27 552
b28d9be6c drivers/staging/typec/tcpci.c Peter Chen2018-06-27 553
i2c_set_clientdata(client, chip);
b28d9be6c drivers/staging/typec/tcpci.c Peter Chen2018-06-27 554
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 555 /*
Disable chip interrupts before requesting irq */
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 556 err =
regmap_raw_write(chip->data.regmap, TCPC_ALERT_MASK, &val,
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 557
sizeof(u16));
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 558 if (err
< 0)
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 559
return err;
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 560
b28d9be6c drivers/staging/typec/tcpci.c Peter Chen2018-06-27 561
chip->tcpci = tcpci_register_port(&client->dev, &chip->data);
b28d9be6c drivers/staging/typec/tcpci.c Peter Chen2018-06-27 562 if
(IS_ERR(chip->tcpci))
b28d9be6c drivers/staging/typec/tcpci.c Peter Chen2018-06-27 563
return PTR_ERR(chip->tcpci);
b28d9be6c drivers/staging/typec/tcpci.c Peter Chen2018-06-27 564
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 565 err =
devm_request_threaded_irq(&client->dev, client->irq, NULL,
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 566
_tcpci_irq,
74e656d6b drivers/staging/typec/tcpci.c Guenter Roeck 2017-04-27 567
IRQF_ONESHOT | IRQF_TRIGGER_LOW,
8f9439022 drivers/staging/typec/tcpci.c ShuFan Lee2018-03-06 568
Re: [PATCH v4] USB: serial: ftdi_sio: Add MTP NVM support
Hi Loic,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.18-rc2 next-20180625]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Loic-Poulain/USB-serial-ftdi_sio-Add-MTP-NVM-support/20180625-181125
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: x86_64-randconfig-x011-201825 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/usb/serial/ftdi_sio.c: In function 'ftdi_register_eeprom':
>> drivers/usb/serial/ftdi_sio.c:1603:18: error: 'SZ_2K' undeclared (first use
>> in this function)
nvmconf.size = SZ_2K;
^
drivers/usb/serial/ftdi_sio.c:1603:18: note: each undeclared identifier is
reported only once for each function it appears in
>> drivers/usb/serial/ftdi_sio.c:1606:18: error: 'SZ_128' undeclared (first use
>> in this function); did you mean 'SZ_2K'?
nvmconf.size = SZ_128;
^~
SZ_2K
vim +/SZ_2K +1603 drivers/usb/serial/ftdi_sio.c
1594
1595 static int ftdi_register_eeprom(struct usb_serial_port *port)
1596 {
1597 struct ftdi_private *priv = usb_get_serial_port_data(port);
1598 struct usb_device *udev = port->serial->dev;
1599 struct nvmem_config nvmconf = {};
1600
1601 switch (priv->chip_type) {
1602 case FTX:
> 1603 nvmconf.size = SZ_2K;
1604 break;
1605 case FT232RL:
> 1606 nvmconf.size = SZ_128;
1607 break;
1608 default:
1609 return 0;
1610 }
1611
1612 nvmconf.word_size = 2;
1613 nvmconf.stride = 2;
1614 nvmconf.read_only = false;
1615 nvmconf.priv = port;
1616 nvmconf.dev = &udev->dev;
1617 nvmconf.reg_read = ftdi_read_eeprom;
1618 nvmconf.reg_write = ftdi_write_eeprom;
1619 nvmconf.owner = THIS_MODULE;
1620
1621 priv->eeprom = nvmem_register(&nvmconf);
1622 if (IS_ERR(priv->eeprom)) {
1623 dev_err(&udev->dev, "Unable to register FTDI EEPROM\n");
1624 priv->eeprom = NULL;
1625 return -ENOMEM;
1626 }
1627
1628 dev_info(&udev->dev, "Registered %d-byte FTDI EEPROM\n",
nvmconf.size);
1629
1630 return 0;
1631 }
1632
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH v4] USB: serial: ftdi_sio: Add MTP NVM support
Hi Loic,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.18-rc2 next-20180625]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Loic-Poulain/USB-serial-ftdi_sio-Add-MTP-NVM-support/20180625-181125
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: ia64-allyesconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 8.1.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=8.1.0 make.cross ARCH=ia64
All errors (new ones prefixed by >>):
drivers/usb/serial/ftdi_sio.c: In function 'ftdi_register_eeprom':
drivers/usb/serial/ftdi_sio.c:1603:18: error: 'SZ_2K' undeclared (first use
in this function)
nvmconf.size = SZ_2K;
^
drivers/usb/serial/ftdi_sio.c:1603:18: note: each undeclared identifier is
reported only once for each function it appears in
>> drivers/usb/serial/ftdi_sio.c:1606:18: error: 'SZ_128' undeclared (first use
>> in this function)
nvmconf.size = SZ_128;
^~
vim +/SZ_128 +1606 drivers/usb/serial/ftdi_sio.c
1594
1595 static int ftdi_register_eeprom(struct usb_serial_port *port)
1596 {
1597 struct ftdi_private *priv = usb_get_serial_port_data(port);
1598 struct usb_device *udev = port->serial->dev;
1599 struct nvmem_config nvmconf = {};
1600
1601 switch (priv->chip_type) {
1602 case FTX:
> 1603 nvmconf.size = SZ_2K;
1604 break;
1605 case FT232RL:
> 1606 nvmconf.size = SZ_128;
1607 break;
1608 default:
1609 return 0;
1610 }
1611
1612 nvmconf.word_size = 2;
1613 nvmconf.stride = 2;
1614 nvmconf.read_only = false;
1615 nvmconf.priv = port;
1616 nvmconf.dev = &udev->dev;
1617 nvmconf.reg_read = ftdi_read_eeprom;
1618 nvmconf.reg_write = ftdi_write_eeprom;
1619 nvmconf.owner = THIS_MODULE;
1620
1621 priv->eeprom = nvmem_register(&nvmconf);
1622 if (IS_ERR(priv->eeprom)) {
1623 dev_err(&udev->dev, "Unable to register FTDI EEPROM\n");
1624 priv->eeprom = NULL;
1625 return -ENOMEM;
1626 }
1627
1628 dev_info(&udev->dev, "Registered %d-byte FTDI EEPROM\n",
nvmconf.size);
1629
1630 return 0;
1631 }
1632
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] usb: gadget: uvc: configfs: Add bFrameIndex attributes
Hi Joel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.17 next-20180608]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Laurent-Pinchart/usb-gadget-uvc-configfs-Add-bFrameIndex-attributes/20180609-194618
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-x011-201822 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/usb/gadget/function/uvc_configfs.c:994:20: error: expected ')'
>> before numeric constant
noop_conversion, 8);
^
>> drivers/usb/gadget/function/uvc_configfs.c:1141:3: error:
>> 'uvcg_frame_attr_b_frame_index' undeclared here (not in a function); did you
>> mean 'uvcg_frame_attr_dw_frame_interval'?
&uvcg_frame_attr_b_frame_index,
^
uvcg_frame_attr_dw_frame_interval
vim +994 drivers/usb/gadget/function/uvc_configfs.c
992
993 UVCG_FRAME_ATTR_RO(b_frame_index, bFrameIndex, noop_conversion,
> 994 noop_conversion, 8);
995 UVCG_FRAME_ATTR(bm_capabilities, bmCapabilities, noop_conversion,
996 noop_conversion, 8);
997 UVCG_FRAME_ATTR(w_width, wWidth, le16_to_cpu, cpu_to_le16, 16);
998 UVCG_FRAME_ATTR(w_height, wHeight, le16_to_cpu, cpu_to_le16, 16);
999 UVCG_FRAME_ATTR(dw_min_bit_rate, dwMinBitRate, le32_to_cpu,
cpu_to_le32, 32);
1000 UVCG_FRAME_ATTR(dw_max_bit_rate, dwMaxBitRate, le32_to_cpu,
cpu_to_le32, 32);
1001 UVCG_FRAME_ATTR(dw_max_video_frame_buffer_size,
dwMaxVideoFrameBufferSize,
1002 le32_to_cpu, cpu_to_le32, 32);
1003 UVCG_FRAME_ATTR(dw_default_frame_interval, dwDefaultFrameInterval,
1004 le32_to_cpu, cpu_to_le32, 32);
1005
1006 #undef noop_conversion
1007
1008 #undef UVCG_FRAME_ATTR
1009
1010 static ssize_t uvcg_frame_dw_frame_interval_show(struct config_item
*item,
1011 char *page)
1012 {
1013 struct uvcg_frame *frm = to_uvcg_frame(item);
1014 struct f_uvc_opts *opts;
1015 struct config_item *opts_item;
1016 struct mutex *su_mutex =
&frm->item.ci_group->cg_subsys->su_mutex;
1017 int result, i;
1018 char *pg = page;
1019
1020 mutex_lock(su_mutex); /* for navigating configfs hierarchy */
1021
1022 opts_item =
frm->item.ci_parent->ci_parent->ci_parent->ci_parent;
1023 opts = to_f_uvc_opts(opts_item);
1024
1025 mutex_lock(&opts->lock);
1026 for (result = 0, i = 0; i < frm->frame.b_frame_interval_type;
++i) {
1027 result += sprintf(pg, "%d\n",
1028
le32_to_cpu(frm->dw_frame_interval[i]));
1029 pg = page + result;
1030 }
1031 mutex_unlock(&opts->lock);
1032
1033 mutex_unlock(su_mutex);
1034 return result;
1035 }
1036
1037 static inline int __uvcg_count_frm_intrv(char *buf, void *priv)
1038 {
1039 ++*((int *)priv);
1040 return 0;
1041 }
1042
1043 static inline int __uvcg_fill_frm_intrv(char *buf, void *priv)
1044 {
1045 u32 num, **interv;
1046 int ret;
1047
1048 ret = kstrtou32(buf, 0, &num);
1049 if (ret)
1050 return ret;
1051
1052 interv = priv;
1053 **interv = cpu_to_le32(num);
1054 ++*interv;
1055
1056 return 0;
1057 }
1058
1059 static int __uvcg_iter_frm_intrv(const char *page, size_t len,
1060 int (*fun)(char *, void *), void *priv)
1061 {
1062 /* sign, base 2 representation, newline, terminator */
1063 char buf[1 + sizeof(u32) * 8 + 1 + 1];
1064 const char *pg = page;
1065 int i, ret;
1066
1067 if (!fun)
1068 return -EINVAL;
1069
1070 while (pg - page < len) {
1071 i = 0;
1072 while (i < sizeof(buf) && (pg - page < len) &&
1073 *pg != '\0' && *pg != '\n')
1074 buf[i++] = *pg++;
1075 if (i == sizeof(buf))
1076 return -EINVAL;
1077 while ((pg - page < len) && (*pg == '\0' || *pg ==
'\n'))
1078 ++pg;
1079 buf[i] = '\0';
1080 ret = fun(buf, priv);
1081 if (ret)
1082 return ret;
1083 }
1084
1085
Re: [PATCH] usb: gadget: uvc: configfs: Add bFrameIndex attributes
Hi Joel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.17 next-20180608]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Laurent-Pinchart/usb-gadget-uvc-configfs-Add-bFrameIndex-attributes/20180609-194618
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-s0-06091928 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/usb//gadget/function/uvc_configfs.c:994:20: error: expected ')'
before numeric constant
noop_conversion, 8);
^
>> drivers/usb//gadget/function/uvc_configfs.c:1141:3: error:
>> 'uvcg_frame_attr_b_frame_index' undeclared here (not in a function)
&uvcg_frame_attr_b_frame_index,
^
vim +/uvcg_frame_attr_b_frame_index +1141
drivers/usb//gadget/function/uvc_configfs.c
992
993 UVCG_FRAME_ATTR_RO(b_frame_index, bFrameIndex, noop_conversion,
> 994 noop_conversion, 8);
995 UVCG_FRAME_ATTR(bm_capabilities, bmCapabilities, noop_conversion,
996 noop_conversion, 8);
997 UVCG_FRAME_ATTR(w_width, wWidth, le16_to_cpu, cpu_to_le16, 16);
998 UVCG_FRAME_ATTR(w_height, wHeight, le16_to_cpu, cpu_to_le16, 16);
999 UVCG_FRAME_ATTR(dw_min_bit_rate, dwMinBitRate, le32_to_cpu,
cpu_to_le32, 32);
1000 UVCG_FRAME_ATTR(dw_max_bit_rate, dwMaxBitRate, le32_to_cpu,
cpu_to_le32, 32);
1001 UVCG_FRAME_ATTR(dw_max_video_frame_buffer_size,
dwMaxVideoFrameBufferSize,
1002 le32_to_cpu, cpu_to_le32, 32);
1003 UVCG_FRAME_ATTR(dw_default_frame_interval, dwDefaultFrameInterval,
1004 le32_to_cpu, cpu_to_le32, 32);
1005
1006 #undef noop_conversion
1007
1008 #undef UVCG_FRAME_ATTR
1009
1010 static ssize_t uvcg_frame_dw_frame_interval_show(struct config_item
*item,
1011 char *page)
1012 {
1013 struct uvcg_frame *frm = to_uvcg_frame(item);
1014 struct f_uvc_opts *opts;
1015 struct config_item *opts_item;
1016 struct mutex *su_mutex =
&frm->item.ci_group->cg_subsys->su_mutex;
1017 int result, i;
1018 char *pg = page;
1019
1020 mutex_lock(su_mutex); /* for navigating configfs hierarchy */
1021
1022 opts_item =
frm->item.ci_parent->ci_parent->ci_parent->ci_parent;
1023 opts = to_f_uvc_opts(opts_item);
1024
1025 mutex_lock(&opts->lock);
1026 for (result = 0, i = 0; i < frm->frame.b_frame_interval_type;
++i) {
1027 result += sprintf(pg, "%d\n",
1028
le32_to_cpu(frm->dw_frame_interval[i]));
1029 pg = page + result;
1030 }
1031 mutex_unlock(&opts->lock);
1032
1033 mutex_unlock(su_mutex);
1034 return result;
1035 }
1036
1037 static inline int __uvcg_count_frm_intrv(char *buf, void *priv)
1038 {
1039 ++*((int *)priv);
1040 return 0;
1041 }
1042
1043 static inline int __uvcg_fill_frm_intrv(char *buf, void *priv)
1044 {
1045 u32 num, **interv;
1046 int ret;
1047
1048 ret = kstrtou32(buf, 0, &num);
1049 if (ret)
1050 return ret;
1051
1052 interv = priv;
1053 **interv = cpu_to_le32(num);
1054 ++*interv;
1055
1056 return 0;
1057 }
1058
1059 static int __uvcg_iter_frm_intrv(const char *page, size_t len,
1060 int (*fun)(char *, void *), void *priv)
1061 {
1062 /* sign, base 2 representation, newline, terminator */
1063 char buf[1 + sizeof(u32) * 8 + 1 + 1];
1064 const char *pg = page;
1065 int i, ret;
1066
1067 if (!fun)
1068 return -EINVAL;
1069
1070 while (pg - page < len) {
1071 i = 0;
1072 while (i < sizeof(buf) && (pg - page < len) &&
1073 *pg != '\0' && *pg != '\n')
1074 buf[i++] = *pg++;
1075 if (i == sizeof(buf))
1076 return -EINVAL;
1077 while ((pg - page < len) && (*pg == '\0' || *pg ==
'\n'))
1078 ++pg;
1079 buf[i] = '\0';
1080 ret = fun(buf, priv);
1081 if (ret)
1082 return ret;
1083 }
1084
1085 return 0;
1086 }
1087
1088 static ssize_t u
Re: [PATCH v6 05/15] usb: typec: add API to get typec basic port power and data config
Hi Li,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.17-rc7 next-20180529]
[cannot apply to staging/staging-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Li-Jun/staging-typec-tcpci-move-out-of-staging/20180530-110011
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: i386-randconfig-s1-201821 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
In file included from include/linux/linkage.h:7:0,
from include/linux/kernel.h:7,
from include/linux/list.h:9,
from include/linux/kobject.h:19,
from include/linux/device.h:16,
from drivers/usb//typec/class.c:9:
>> drivers/usb//typec/class.c:1274:19: error: 'typec_find_power_type'
>> undeclared here (not in a function)
EXPORT_SYMBOL_GPL(typec_find_power_type);
^
include/linux/export.h:65:16: note: in definition of macro '___EXPORT_SYMBOL'
extern typeof(sym) sym; \
^~~
drivers/usb//typec/class.c:1274:1: note: in expansion of macro
'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(typec_find_power_type);
^
>> drivers/usb//typec/class.c:1288:19: error: 'typec_find_preferred_role'
>> undeclared here (not in a function)
EXPORT_SYMBOL_GPL(typec_find_preferred_role);
^
include/linux/export.h:65:16: note: in definition of macro '___EXPORT_SYMBOL'
extern typeof(sym) sym; \
^~~
drivers/usb//typec/class.c:1288:1: note: in expansion of macro
'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(typec_find_preferred_role);
^
>> drivers/usb//typec/class.c:1303:19: error: 'typec_find_data_type' undeclared
>> here (not in a function)
EXPORT_SYMBOL_GPL(typec_find_data_type);
^
include/linux/export.h:65:16: note: in definition of macro '___EXPORT_SYMBOL'
extern typeof(sym) sym; \
^~~
drivers/usb//typec/class.c:1303:1: note: in expansion of macro
'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(typec_find_data_type);
^
vim +/typec_find_power_type +1274 drivers/usb//typec/class.c
1260
1261 /**
1262 * typec_find_port_power_role - Get the typec port power capability
1263 * @name: port power capability string
1264 *
1265 * This routine is used to find the typec_port_type by its string name.
1266 *
1267 * Returns typec_port_type if success, otherwise negative error code.
1268 */
1269 int typec_find_port_power_role(const char *name)
1270 {
1271 return match_string(typec_port_types,
ARRAY_SIZE(typec_port_types),
1272 name);
1273 }
> 1274 EXPORT_SYMBOL_GPL(typec_find_power_type);
1275
1276 /**
1277 * typec_find_power_role - Find the typec one specific power role
1278 * @name: power role string
1279 *
1280 * This routine is used to find the typec_role by its string name.
1281 *
1282 * Returns typec_role if success, otherwise negative error code.
1283 */
1284 int typec_find_power_role(const char *name)
1285 {
1286 return match_string(typec_roles, ARRAY_SIZE(typec_roles), name);
1287 }
> 1288 EXPORT_SYMBOL_GPL(typec_find_preferred_role);
1289
1290 /**
1291 * typec_find_port_data_role - Get the typec port data capability
1292 * @name: port data capability string
1293 *
1294 * This routine is used to find the typec_port_data by its string name.
1295 *
1296 * Returns typec_port_data if success, otherwise negative error code.
1297 */
1298 int typec_find_port_data_role(const char *name)
1299 {
1300 return match_string(typec_data_caps,
ARRAY_SIZE(typec_data_caps),
1301 name);
1302 }
> 1303 EXPORT_SYMBOL_GPL(typec_find_data_type);
1304
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH v6 05/15] usb: typec: add API to get typec basic port power and data config
Hi Li,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.17-rc7 next-20180529]
[cannot apply to staging/staging-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Li-Jun/staging-typec-tcpci-move-out-of-staging/20180530-110011
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: i386-randconfig-x017-201821 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All error/warnings (new ones prefixed by >>):
In file included from include/linux/linkage.h:7:0,
from include/linux/kernel.h:7,
from include/linux/list.h:9,
from include/linux/kobject.h:19,
from include/linux/device.h:16,
from drivers/usb/typec/class.c:9:
>> drivers/usb/typec/class.c:1274:19: error: 'typec_find_power_type' undeclared
>> here (not in a function); did you mean 'typec_find_power_role'?
EXPORT_SYMBOL_GPL(typec_find_power_type);
^
include/linux/export.h:65:16: note: in definition of macro '___EXPORT_SYMBOL'
extern typeof(sym) sym; \
^~~
>> drivers/usb/typec/class.c:1274:1: note: in expansion of macro
>> 'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(typec_find_power_type);
^
>> drivers/usb/typec/class.c:1288:19: error: 'typec_find_preferred_role'
>> undeclared here (not in a function); did you mean 'typec_find_power_role'?
EXPORT_SYMBOL_GPL(typec_find_preferred_role);
^
include/linux/export.h:65:16: note: in definition of macro '___EXPORT_SYMBOL'
extern typeof(sym) sym; \
^~~
drivers/usb/typec/class.c:1288:1: note: in expansion of macro
'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(typec_find_preferred_role);
^
>> drivers/usb/typec/class.c:1303:19: error: 'typec_find_data_type' undeclared
>> here (not in a function); did you mean 'typec_find_power_type'?
EXPORT_SYMBOL_GPL(typec_find_data_type);
^
include/linux/export.h:65:16: note: in definition of macro '___EXPORT_SYMBOL'
extern typeof(sym) sym; \
^~~
drivers/usb/typec/class.c:1303:1: note: in expansion of macro
'EXPORT_SYMBOL_GPL'
EXPORT_SYMBOL_GPL(typec_find_data_type);
^
vim +1274 drivers/usb/typec/class.c
1260
1261 /**
1262 * typec_find_port_power_role - Get the typec port power capability
1263 * @name: port power capability string
1264 *
1265 * This routine is used to find the typec_port_type by its string name.
1266 *
1267 * Returns typec_port_type if success, otherwise negative error code.
1268 */
1269 int typec_find_port_power_role(const char *name)
1270 {
1271 return match_string(typec_port_types,
ARRAY_SIZE(typec_port_types),
1272 name);
1273 }
> 1274 EXPORT_SYMBOL_GPL(typec_find_power_type);
1275
1276 /**
1277 * typec_find_power_role - Find the typec one specific power role
1278 * @name: power role string
1279 *
1280 * This routine is used to find the typec_role by its string name.
1281 *
1282 * Returns typec_role if success, otherwise negative error code.
1283 */
1284 int typec_find_power_role(const char *name)
1285 {
1286 return match_string(typec_roles, ARRAY_SIZE(typec_roles), name);
1287 }
> 1288 EXPORT_SYMBOL_GPL(typec_find_preferred_role);
1289
1290 /**
1291 * typec_find_port_data_role - Get the typec port data capability
1292 * @name: port data capability string
1293 *
1294 * This routine is used to find the typec_port_data by its string name.
1295 *
1296 * Returns typec_port_data if success, otherwise negative error code.
1297 */
1298 int typec_find_port_data_role(const char *name)
1299 {
1300 return match_string(typec_data_caps,
ARRAY_SIZE(typec_data_caps),
1301 name);
1302 }
> 1303 EXPORT_SYMBOL_GPL(typec_find_data_type);
1304
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[usb:debugfs_cleanup 109/109] drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 'RTL_DEBUGFS_ADD_CORE'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git debugfs_cleanup head: 1c66923f2afb1578348d1f92ce01c1b9f5216dd4 commit: 1c66923f2afb1578348d1f92ce01c1b9f5216dd4 [109/109] usb: debugfs cleanup - try 2 config: i386-allmodconfig (attached as .config) compiler: gcc-8 (Debian 8.1.0-3) 8.1.0 reproduce: git checkout 1c66923f2afb1578348d1f92ce01c1b9f5216dd4 # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): drivers/staging/rtlwifi/debug.c: In function 'rtl_debug_add_one': drivers/staging/rtlwifi/debug.c:534:9: error: invalid operands to binary & (have 'struct dentry *' and 'struct rtl_debugfs_priv') &rtl_debug_priv_ ##name, \ ^ >> drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro >> 'RTL_DEBUGFS_ADD_CORE' RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) ^~~~ >> drivers/staging/rtlwifi/debug.c:565:2: note: in expansion of macro >> 'RTL_DEBUGFS_ADD' RTL_DEBUGFS_ADD(mac_0); ^~~ drivers/staging/rtlwifi/debug.c:535:9: warning: passing argument 4 of 'debugfs_create_file' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] &file_ops_ ##fopname); \ ^~ >> drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro >> 'RTL_DEBUGFS_ADD_CORE' RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) ^~~~ >> drivers/staging/rtlwifi/debug.c:565:2: note: in expansion of macro >> 'RTL_DEBUGFS_ADD' RTL_DEBUGFS_ADD(mac_0); ^~~ In file included from include/net/cfg80211.h:17, from include/net/mac80211.h:24, from drivers/staging/rtlwifi/wifi.h:36, from drivers/staging/rtlwifi/debug.c:25: include/linux/debugfs.h:61:16: note: expected 'void *' but argument is of type 'const struct file_operations *' struct dentry *debugfs_create_file(const char *name, umode_t mode, ^~~ drivers/staging/rtlwifi/debug.c:533:3: error: too few arguments to function 'debugfs_create_file' debugfs_create_file(#name, mode, parent \ ^~~ >> drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro >> 'RTL_DEBUGFS_ADD_CORE' RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) ^~~~ >> drivers/staging/rtlwifi/debug.c:565:2: note: in expansion of macro >> 'RTL_DEBUGFS_ADD' RTL_DEBUGFS_ADD(mac_0); ^~~ In file included from include/net/cfg80211.h:17, from include/net/mac80211.h:24, from drivers/staging/rtlwifi/wifi.h:36, from drivers/staging/rtlwifi/debug.c:25: include/linux/debugfs.h:61:16: note: declared here struct dentry *debugfs_create_file(const char *name, umode_t mode, ^~~ drivers/staging/rtlwifi/debug.c:534:9: error: invalid operands to binary & (have 'struct dentry *' and 'struct rtl_debugfs_priv') &rtl_debug_priv_ ##name, \ ^ >> drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro >> 'RTL_DEBUGFS_ADD_CORE' RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) ^~~~ drivers/staging/rtlwifi/debug.c:566:2: note: in expansion of macro 'RTL_DEBUGFS_ADD' RTL_DEBUGFS_ADD(mac_1); ^~~ drivers/staging/rtlwifi/debug.c:535:9: warning: passing argument 4 of 'debugfs_create_file' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers] &file_ops_ ##fopname); \ ^~ >> drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro >> 'RTL_DEBUGFS_ADD_CORE' RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) ^~~~ drivers/staging/rtlwifi/debug.c:566:2: note: in expansion of macro 'RTL_DEBUGFS_ADD' RTL_DEBUGFS_ADD(mac_1); ^~~ In file included from include/net/cfg80211.h:17, from include/net/mac80211.h:24, from drivers/staging/rtlwifi/wifi.h:36, from drivers/staging/rtlwifi/debug.c:25: include/linux/debugfs.h:61:16: note: expected 'void *' but argument is of type 'const struct file_operations *' struct dentry *debugfs_create_file(const char *name, umode_t mode, ^~~ drivers/staging/rtlwifi/debug.c:533:3: error: too few arguments to function 'debugfs_create_file' debugfs_create_file(#name, mode, parent \ ^~~ >> drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro >> 'RTL_DEBUGFS_ADD_CORE' RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) ^~~~ drivers/staging/rtlwifi/debug.c:566:2: note: in expansion of macro 'RTL_DEBUGFS_ADD' RTL_DEBUGFS_ADD(mac_1);
[usb:debugfs_cleanup 109/109] drivers/staging/rtlwifi/debug.c:534:9: error: invalid operands to binary & (have 'struct dentry *' and 'struct rtl_debugfs_priv')
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git debugfs_cleanup head: 1c66923f2afb1578348d1f92ce01c1b9f5216dd4 commit: 1c66923f2afb1578348d1f92ce01c1b9f5216dd4 [109/109] usb: debugfs cleanup - try 2 config: i386-randconfig-i0-201821 (attached as .config) compiler: gcc-8 (Debian 8.1.0-3) 8.1.0 reproduce: git checkout 1c66923f2afb1578348d1f92ce01c1b9f5216dd4 # save the attached .config to linux build tree make ARCH=i386 All error/warnings (new ones prefixed by >>): drivers/staging/rtlwifi/debug.c: In function 'rtl_debug_add_one': >> drivers/staging/rtlwifi/debug.c:534:9: error: invalid operands to binary & >> (have 'struct dentry *' and 'struct rtl_debugfs_priv') &rtl_debug_priv_ ##name, \ ^ drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 'RTL_DEBUGFS_ADD_CORE' RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) ^~~~ drivers/staging/rtlwifi/debug.c:565:2: note: in expansion of macro 'RTL_DEBUGFS_ADD' RTL_DEBUGFS_ADD(mac_0); ^~~ >> drivers/staging/rtlwifi/debug.c:535:9: warning: passing argument 4 of >> 'debugfs_create_file' discards 'const' qualifier from pointer target type >> [-Wdiscarded-qualifiers] &file_ops_ ##fopname); \ ^~ drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 'RTL_DEBUGFS_ADD_CORE' RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) ^~~~ drivers/staging/rtlwifi/debug.c:565:2: note: in expansion of macro 'RTL_DEBUGFS_ADD' RTL_DEBUGFS_ADD(mac_0); ^~~ In file included from include/net/cfg80211.h:17, from include/net/mac80211.h:24, from drivers/staging/rtlwifi/wifi.h:36, from drivers/staging/rtlwifi/debug.c:25: include/linux/debugfs.h:61:16: note: expected 'void *' but argument is of type 'const struct file_operations *' struct dentry *debugfs_create_file(const char *name, umode_t mode, ^~~ >> drivers/staging/rtlwifi/debug.c:533:3: error: too few arguments to function >> 'debugfs_create_file' debugfs_create_file(#name, mode, parent \ ^~~ drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 'RTL_DEBUGFS_ADD_CORE' RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) ^~~~ drivers/staging/rtlwifi/debug.c:565:2: note: in expansion of macro 'RTL_DEBUGFS_ADD' RTL_DEBUGFS_ADD(mac_0); ^~~ In file included from include/net/cfg80211.h:17, from include/net/mac80211.h:24, from drivers/staging/rtlwifi/wifi.h:36, from drivers/staging/rtlwifi/debug.c:25: include/linux/debugfs.h:61:16: note: declared here struct dentry *debugfs_create_file(const char *name, umode_t mode, ^~~ >> drivers/staging/rtlwifi/debug.c:534:9: error: invalid operands to binary & >> (have 'struct dentry *' and 'struct rtl_debugfs_priv') &rtl_debug_priv_ ##name, \ ^ drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 'RTL_DEBUGFS_ADD_CORE' RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) ^~~~ drivers/staging/rtlwifi/debug.c:566:2: note: in expansion of macro 'RTL_DEBUGFS_ADD' RTL_DEBUGFS_ADD(mac_1); ^~~ >> drivers/staging/rtlwifi/debug.c:535:9: warning: passing argument 4 of >> 'debugfs_create_file' discards 'const' qualifier from pointer target type >> [-Wdiscarded-qualifiers] &file_ops_ ##fopname); \ ^~ drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 'RTL_DEBUGFS_ADD_CORE' RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) ^~~~ drivers/staging/rtlwifi/debug.c:566:2: note: in expansion of macro 'RTL_DEBUGFS_ADD' RTL_DEBUGFS_ADD(mac_1); ^~~ In file included from include/net/cfg80211.h:17, from include/net/mac80211.h:24, from drivers/staging/rtlwifi/wifi.h:36, from drivers/staging/rtlwifi/debug.c:25: include/linux/debugfs.h:61:16: note: expected 'void *' but argument is of type 'const struct file_operations *' struct dentry *debugfs_create_file(const char *name, umode_t mode, ^~~ >> drivers/staging/rtlwifi/debug.c:533:3: error: too few arguments to function >> 'debugfs_create_file' debugfs_create_file(#name, mode, parent \ ^~~ drivers/staging/rtlwifi/debug.c:539:3: note: in expansion of macro 'RTL_DEBUGFS_ADD_CORE' RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) ^~~~ drivers/staging/rtlwifi/debug.c:566:2: note: in expansion of macro 'RTL_DEBUGFS_ADD' RTL_DEBUGFS_ADD(
[usb:debugfs_cleanup 109/109] drivers/usb/typec/tcpm.c:580:9: warning: 'return' with a value, in function returning void
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
debugfs_cleanup
head: 7b3bcbfe0aeedeec64c83cf9655273e8f42f1c54
commit: 7b3bcbfe0aeedeec64c83cf9655273e8f42f1c54 [109/109] usb: debugfs cleanup
config: i386-randconfig-s1-201821 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
git checkout 7b3bcbfe0aeedeec64c83cf9655273e8f42f1c54
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/usb/typec/tcpm.c: In function 'tcpm_debugfs_init':
>> drivers/usb/typec/tcpm.c:580:9: warning: 'return' with a value, in function
>> returning void
return 0;
^
drivers/usb/typec/tcpm.c:569:13: note: declared here
static void tcpm_debugfs_init(struct tcpm_port *port)
^
vim +/return +580 drivers/usb/typec/tcpm.c
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 568
7b3bcbfe drivers/usb/typec/tcpm.c Greg Kroah-Hartman 2018-05-29 569
static void tcpm_debugfs_init(struct tcpm_port *port)
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 570 {
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 571
mutex_init(&port->logbuffer_lock);
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 572
/* /sys/kernel/debug/tcpm/usbcX */
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 573
if (!rootdir)
7b3bcbfe drivers/usb/typec/tcpm.c Greg Kroah-Hartman 2018-05-29 574
rootdir = debugfs_create_dir("tcpm", NULL);
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 575
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 576
port->dentry = debugfs_create_file(dev_name(port->dev),
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 577
S_IFREG | 0444, rootdir,
9e902c59 drivers/usb/typec/tcpm.c Andy Shevchenko2018-02-14 578
port, &tcpm_debug_fops);
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 579
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 @580
return 0;
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 581 }
f0690a25 drivers/staging/typec/tcpm.c Guenter Roeck 2017-04-27 582
:: The code at line 580 was first introduced by commit
:: f0690a25a140b853b1842fa80faf828601bb47e8 staging: typec: USB Type-C Port
Manager (tcpm)
:: TO: Guenter Roeck
:: CC: Greg Kroah-Hartman
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[usb:usb-next 72/107] drivers/usb/host/xhci-mem.c:2250 xhci_create_rhub_port_array() error: potential null dereference 'rhub->ports'. (kcalloc returns null)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
head: 58c38116c6cc5bcb6d952ca72111a7a15d4604a2
commit: bcaa9d5c59005eceed5f2112c13240401f0fb93b [72/107] xhci: Create new
structures to store xhci port information
New smatch warnings:
drivers/usb/host/xhci-mem.c:2250 xhci_create_rhub_port_array() error: potential
null dereference 'rhub->ports'. (kcalloc returns null)
Old smatch warnings:
drivers/usb/host/xhci-mem.c:2280 xhci_setup_port_arrays() error: potential null
dereference 'xhci->hw_ports'. (kcalloc returns null)
vim +2250 drivers/usb/host/xhci-mem.c
2235
2236 static void xhci_create_rhub_port_array(struct xhci_hcd *xhci,
2237 struct xhci_hub *rhub, gfp_t
flags)
2238 {
2239 int port_index = 0;
2240 int i;
2241
2242 if (!rhub->num_ports)
2243 return;
2244 rhub->ports = kcalloc(rhub->num_ports, sizeof(rhub->ports),
flags);
2245 for (i = 0; i < HCS_MAX_PORTS(xhci->hcs_params1); i++) {
2246 if (xhci->hw_ports[i].rhub != rhub ||
2247 xhci->hw_ports[i].hcd_portnum == DUPLICATE_ENTRY)
2248 continue;
2249 xhci->hw_ports[i].hcd_portnum = port_index;
> 2250 rhub->ports[port_index] = &xhci->hw_ports[i];
2251 port_index++;
2252 if (port_index == rhub->num_ports)
2253 break;
2254 }
2255 }
2256
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v1 2/4] usb: dwc2: Modify dwc2_readl/writel functions prototype
Hi Gevorg,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.17-rc6]
[cannot apply to balbi-usb/next next-20180517]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Gevorg-Sahakyan/usb-dwc2-Make-dwc2-endianness-agnostic/20180523-062909
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: i386-randconfig-x078-201820 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/usb/dwc2/gadget.c: In function 'dwc2_hsotg_ep_enable':
>> drivers/usb/dwc2/gadget.c:3943:17: error: too few arguments to function
>> 'dwc2_readl'
u32 gsnpsid = dwc2_readl(hsotg->regs + GSNPSID);
^~
In file included from drivers/usb/dwc2/gadget.c:31:0:
drivers/usb/dwc2/core.h:1085:19: note: declared here
static inline u32 dwc2_readl(struct dwc2_hsotg *hsotg, u32 offset)
^~
vim +/dwc2_readl +3943 drivers/usb/dwc2/gadget.c
a4f827714 drivers/usb/dwc2/gadget.c Vahram Aharonyan 2016-11-14 3769
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3770
/**
1f91b4cc0 drivers/usb/dwc2/gadget.c Felipe Balbi 2015-08-06 3771
* dwc2_hsotg_ep_enable - enable the given endpoint
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3772
* @ep: The USB endpint to configure
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3773
* @desc: The USB endpoint descriptor to configure with.
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3774 *
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3775
* This is called from the USB gadget code's usb_ep_enable().
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3776
*/
1f91b4cc0 drivers/usb/dwc2/gadget.c Felipe Balbi 2015-08-06 3777
static int dwc2_hsotg_ep_enable(struct usb_ep *ep,
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3778
const struct usb_endpoint_descriptor *desc)
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3779 {
1f91b4cc0 drivers/usb/dwc2/gadget.c Felipe Balbi 2015-08-06 3780
struct dwc2_hsotg_ep *hs_ep = our_ep(ep);
941fcce4f drivers/usb/dwc2/gadget.c Dinh Nguyen2014-11-11 3781
struct dwc2_hsotg *hsotg = hs_ep->parent;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3782
unsigned long flags;
ca4c55ad8 drivers/usb/dwc2/gadget.c Mian Yousaf Kaukab 2015-01-09 3783
unsigned int index = hs_ep->index;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3784
u32 epctrl_reg;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3785
u32 epctrl;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3786
u32 mps;
ee2c40de6 drivers/usb/dwc2/gadget.c Vardan Mikayelyan 2016-11-08 3787
u32 mc;
837e9f00b drivers/usb/dwc2/gadget.c Vardan Mikayelyan 2016-05-25 3788
u32 mask;
ca4c55ad8 drivers/usb/dwc2/gadget.c Mian Yousaf Kaukab 2015-01-09 3789
unsigned int dir_in;
ca4c55ad8 drivers/usb/dwc2/gadget.c Mian Yousaf Kaukab 2015-01-09 3790
unsigned int i, val, size;
19c190f9e drivers/usb/gadget/s3c-hsotg.c Julia Lawall 2010-03-29 3791
int ret = 0;
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3792
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3793
dev_dbg(hsotg->dev,
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3794
"%s: ep %s: a 0x%02x, attr 0x%02x, mps 0x%04x, intr %d\n",
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3795
__func__, ep->name, desc->bEndpointAddress, desc->bmAttributes,
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3796
desc->wMaxPacketSize, desc->bInterval);
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3797
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3798
/* not to be called for EP0 */
8c3d60927 drivers/usb/dwc2/gadget.c Vahram Aharonyan 2016-04-27 3799
if (index == 0) {
8c3d60927 drivers/usb/dwc2/gadget.c Vahram Aharonyan 2016-04-27 3800
dev_err(hsotg->dev, "%s: called for EP 0\n", __func__);
8c3d60927 drivers/usb/dwc2/gadget.c Vahram Aharonyan 2016-04-27 3801
return -EINVAL;
8c3d60927 drivers/usb/dwc2/gadget.c Vahram Aharonyan 2016-04-27 3802
}
5b7d70c6d drivers/usb/gadget/s3c-hsotg.c Ben Dooks 2009-06-02 3803
5b7d70c6d dr
Re: [PATCH] NFC: pn533: don't send USB data off of the stack
Hi Greg,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.17-rc5 next-20180517]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Greg-KH/NFC-pn533-don-t-send-USB-data-off-of-the-stack/20180518-100416
config: i386-randconfig-x013-201819 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/nfc/pn533/usb.c: In function 'pn533_usb_send_ack':
>> drivers/nfc/pn533/usb.c:163:15: error: invalid operands to binary | (have
>> 'struct urb *' and 'int')
phy->out_urb |= URB_FREE_BUFFER;
^~
drivers/nfc/pn533/usb.c: In function 'pn533_usb_send_frame':
drivers/nfc/pn533/usb.c:180:15: error: invalid operands to binary & (have
'struct urb *' and 'int')
phy->out_urb &= ~URB_FREE_BUFFER;
^~
drivers/nfc/pn533/usb.c: In function 'pn533_acr122_poweron_rdr':
drivers/nfc/pn533/usb.c:406:15: error: invalid operands to binary | (have
'struct urb *' and 'int')
phy->out_urb |= URB_FREE_BUFFER;
^~
vim +163 drivers/nfc/pn533/usb.c
147
148 static int pn533_usb_send_ack(struct pn533 *dev, gfp_t flags)
149 {
150 struct pn533_usb_phy *phy = dev->phy;
151 static const u8 ack[6] = {0x00, 0x00, 0xff, 0x00, 0xff, 0x00};
152 /* spec 7.1.1.3: Preamble, SoPC (2), ACK Code (2), Postamble */
153 char *buffer;
154 int rc;
155
156 buffer = kmalloc(sizeof(ack), GFP_KERNEL);
157 if (!buffer)
158 return -ENOMEM;
159 memcpy(buffer, ack, sizeof(ack));
160
161 phy->out_urb->transfer_buffer = (u8 *)ack;
162 phy->out_urb->transfer_buffer_length = sizeof(ack);
> 163 phy->out_urb |= URB_FREE_BUFFER;
164 rc = usb_submit_urb(phy->out_urb, flags);
165
166 return rc;
167 }
168
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[linux-next:master 7522/8111] drivers/usb/dwc3/drd.c:443:19: sparse: symbol 'dwc3_get_extcon' was not declared. Should it be static?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: fbbe3b8c2c9c5f84caf668703c26154cb4fbb9d1 commit: 5f0b74e54890c354d6ac0124ea7a96adf22845d0 [7522/8111] USB: dwc3: get extcon device by OF graph bindings reproduce: # apt-get install sparse git checkout 5f0b74e54890c354d6ac0124ea7a96adf22845d0 make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/usb/dwc3/drd.c:443:19: sparse: symbol 'dwc3_get_extcon' was not >> declared. Should it be static? Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[RFC PATCH linux-next] USB: dwc3: dwc3_get_extcon() can be static
Fixes: 5f0b74e54890 ("USB: dwc3: get extcon device by OF graph bindings")
Signed-off-by: kbuild test robot
---
drd.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
index 2706824..218371f 100644
--- a/drivers/usb/dwc3/drd.c
+++ b/drivers/usb/dwc3/drd.c
@@ -440,7 +440,7 @@ static int dwc3_drd_notifier(struct notifier_block *nb,
return NOTIFY_DONE;
}
-struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
+static struct extcon_dev *dwc3_get_extcon(struct dwc3 *dwc)
{
struct device *dev = dwc->dev;
struct device_node *np_phy, *np_conn;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()
Hi Florian, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/of-mdio-Fall-back-to-mdiobus_register-with-np-is-NULL/20180516-203317 config: arm-omap2plus_defconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm All error/warnings (new ones prefixed by >>): drivers/net//ethernet/ti/davinci_mdio.c: In function 'davinci_mdio_probe': >> drivers/net//ethernet/ti/davinci_mdio.c:457:12: error: invalid storage class >> for function 'davinci_mdio_remove' static int davinci_mdio_remove(struct platform_device *pdev) ^~~ >> drivers/net//ethernet/ti/davinci_mdio.c:457:1: warning: ISO C90 forbids >> mixed declarations and code [-Wdeclaration-after-statement] static int davinci_mdio_remove(struct platform_device *pdev) ^~ >> drivers/net//ethernet/ti/davinci_mdio.c:471:12: error: invalid storage class >> for function 'davinci_mdio_runtime_suspend' static int davinci_mdio_runtime_suspend(struct device *dev) ^~~~ >> drivers/net//ethernet/ti/davinci_mdio.c:485:12: error: invalid storage class >> for function 'davinci_mdio_runtime_resume' static int davinci_mdio_runtime_resume(struct device *dev) ^~~ >> drivers/net//ethernet/ti/davinci_mdio.c:495:12: error: invalid storage class >> for function 'davinci_mdio_suspend' static int davinci_mdio_suspend(struct device *dev) ^~~~ >> drivers/net//ethernet/ti/davinci_mdio.c:512:12: error: invalid storage class >> for function 'davinci_mdio_resume' static int davinci_mdio_resume(struct device *dev) ^~~ In file included from include/linux/device.h:23:0, from include/linux/platform_device.h:14, from drivers/net//ethernet/ti/davinci_mdio.c:29: >> drivers/net//ethernet/ti/davinci_mdio.c:527:21: error: initializer element >> is not constant SET_RUNTIME_PM_OPS(davinci_mdio_runtime_suspend, ^ include/linux/pm.h:354:21: note: in definition of macro 'SET_RUNTIME_PM_OPS' .runtime_suspend = suspend_fn, \ ^~ drivers/net//ethernet/ti/davinci_mdio.c:527:21: note: (near initialization for 'davinci_mdio_pm_ops.runtime_suspend') SET_RUNTIME_PM_OPS(davinci_mdio_runtime_suspend, ^ include/linux/pm.h:354:21: note: in definition of macro 'SET_RUNTIME_PM_OPS' .runtime_suspend = suspend_fn, \ ^~ drivers/net//ethernet/ti/davinci_mdio.c:528:7: error: initializer element is not constant davinci_mdio_runtime_resume, NULL) ^ include/linux/pm.h:355:20: note: in definition of macro 'SET_RUNTIME_PM_OPS' .runtime_resume = resume_fn, \ ^ drivers/net//ethernet/ti/davinci_mdio.c:528:7: note: (near initialization for 'davinci_mdio_pm_ops.runtime_resume') davinci_mdio_runtime_resume, NULL) ^ include/linux/pm.h:355:20: note: in definition of macro 'SET_RUNTIME_PM_OPS' .runtime_resume = resume_fn, \ ^ drivers/net//ethernet/ti/davinci_mdio.c:529:31: error: initializer element is not constant SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume) ^ include/linux/pm.h:330:18: note: in definition of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS' .suspend_late = suspend_fn, \ ^~ drivers/net//ethernet/ti/davinci_mdio.c:529:31: note: (near initialization for 'davinci_mdio_pm_ops.suspend_late') SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume) ^ include/linux/pm.h:330:18: note: in definition of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS' .suspend_late = suspend_fn, \ ^~ drivers/net//ethernet/ti/davinci_mdio.c:529:53: error: initializer element is not constant SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume) ^ include/linux/pm.h:331:18: note: in definition of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS' .resume_early = resume_fn, \ ^ drivers/net//ethernet/ti/davinci_mdio.c:529:53: note: (near initialization for 'davinci_mdio_pm_ops.resume_early') SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume) ^ include/linux/pm.h:331:18: note: in definition of macro 'SET_LATE
Re: [PATCH net-next 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()
Hi Florian, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/of-mdio-Fall-back-to-mdiobus_register-with-np-is-NULL/20180516-203317 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=arm All error/warnings (new ones prefixed by >>): .runtime_suspend = suspend_fn, \ ^~ drivers/net//ethernet/ti/davinci_mdio.c:527:21: note: (near initialization for 'davinci_mdio_pm_ops.runtime_suspend') SET_RUNTIME_PM_OPS(davinci_mdio_runtime_suspend, ^ include/linux/pm.h:354:21: note: in definition of macro 'SET_RUNTIME_PM_OPS' .runtime_suspend = suspend_fn, \ ^~ drivers/net//ethernet/ti/davinci_mdio.c:528:7: error: initializer element is not constant davinci_mdio_runtime_resume, NULL) ^ include/linux/pm.h:355:20: note: in definition of macro 'SET_RUNTIME_PM_OPS' .runtime_resume = resume_fn, \ ^ drivers/net//ethernet/ti/davinci_mdio.c:528:7: note: (near initialization for 'davinci_mdio_pm_ops.runtime_resume') davinci_mdio_runtime_resume, NULL) ^ include/linux/pm.h:355:20: note: in definition of macro 'SET_RUNTIME_PM_OPS' .runtime_resume = resume_fn, \ ^ drivers/net//ethernet/ti/davinci_mdio.c:529:31: error: initializer element is not constant SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume) ^ include/linux/pm.h:330:18: note: in definition of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS' .suspend_late = suspend_fn, \ ^~ drivers/net//ethernet/ti/davinci_mdio.c:529:31: note: (near initialization for 'davinci_mdio_pm_ops.suspend_late') SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume) ^ include/linux/pm.h:330:18: note: in definition of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS' .suspend_late = suspend_fn, \ ^~ drivers/net//ethernet/ti/davinci_mdio.c:529:53: error: initializer element is not constant SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume) ^ include/linux/pm.h:331:18: note: in definition of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS' .resume_early = resume_fn, \ ^ drivers/net//ethernet/ti/davinci_mdio.c:529:53: note: (near initialization for 'davinci_mdio_pm_ops.resume_early') SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume) ^ include/linux/pm.h:331:18: note: in definition of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS' .resume_early = resume_fn, \ ^ drivers/net//ethernet/ti/davinci_mdio.c:529:31: error: initializer element is not constant SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume) ^ include/linux/pm.h:332:17: note: in definition of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS' .freeze_late = suspend_fn, \ ^~ drivers/net//ethernet/ti/davinci_mdio.c:529:31: note: (near initialization for 'davinci_mdio_pm_ops.freeze_late') SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume) ^ include/linux/pm.h:332:17: note: in definition of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS' .freeze_late = suspend_fn, \ ^~ drivers/net//ethernet/ti/davinci_mdio.c:529:53: error: initializer element is not constant SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume) ^ include/linux/pm.h:333:16: note: in definition of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS' .thaw_early = resume_fn, \ ^ drivers/net//ethernet/ti/davinci_mdio.c:529:53: note: (near initialization for 'davinci_mdio_pm_ops.thaw_early') SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume) ^ include/linux/pm.h:333:16: note: in definition of macro 'SET_LATE_SYSTEM_SLEEP_PM_OPS' .thaw_early = resume_fn, \ ^ drivers/net//ethernet/ti/davinci_mdio.c:529:31: error: initializer element is not constant SET_LATE_SYSTEM_SLEEP_PM_OPS(davinci_mdio_suspend, davinci_mdio_resume) ^ include/linux/pm
[RFC PATCH] iscsit_wait_for_tag() can be static
Fixes: 5aff7a710f13 ("Convert target drivers to use sbitmap")
Signed-off-by: Fengguang Wu
---
iscsi_target_util.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/iscsi/iscsi_target_util.c
b/drivers/target/iscsi/iscsi_target_util.c
index 28bcffa..e147aef 100644
--- a/drivers/target/iscsi/iscsi_target_util.c
+++ b/drivers/target/iscsi/iscsi_target_util.c
@@ -147,7 +147,7 @@ void iscsit_free_r2ts_from_list(struct iscsi_cmd *cmd)
spin_unlock_bh(&cmd->r2t_lock);
}
-int iscsit_wait_for_tag(struct se_session *se_sess, int state, int *cpup)
+static int iscsit_wait_for_tag(struct se_session *se_sess, int state, int
*cpup)
{
int tag = -1;
DEFINE_WAIT(wait);
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] Convert target drivers to use sbitmap
Hi Matthew, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.17-rc5 next-20180516] [cannot apply to target/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Matthew-Wilcox/Use-sbitmap-instead-of-percpu_ida/20180516-143658 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) >> drivers/target/iscsi/iscsi_target_util.c:150:5: sparse: symbol >> 'iscsit_wait_for_tag' was not declared. Should it be static? drivers/target/iscsi/iscsi_target_util.c:1174:31: sparse: expression using sizeof(void) drivers/target/iscsi/iscsi_target_util.c:1174:31: sparse: expression using sizeof(void) Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[balbi-usb:next 49/82] drivers/usb/dwc3/gadget.c:2375:19: error: 'dwc' undeclared
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
head: 3196f73ff8444f6b8bfce3dce1900b4eae27c324
commit: 0cdab4c202ea0dd241ddaacf1d3a8a282590cb61 [49/82] usb: dwc3: gadget:
remove unnecessary 'dwc' parameter
config: x86_64-randconfig-s2-05161806 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
git checkout 0cdab4c202ea0dd241ddaacf1d3a8a282590cb61
# save the attached .config to linux build tree
make ARCH=x86_64
Note: the balbi-usb/next HEAD 3196f73ff8444f6b8bfce3dce1900b4eae27c324 builds
fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
In file included from arch/x86/include/asm/bug.h:83:0,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/gfp.h:5,
from include/linux/slab.h:15,
from drivers/usb/dwc3/gadget.c:13:
drivers/usb/dwc3/gadget.c: In function
'dwc3_gadget_ep_cleanup_completed_requests':
>> drivers/usb/dwc3/gadget.c:2375:19: error: 'dwc' undeclared (first use in
>> this function)
dev_WARN_ONCE(dwc->dev,
^
include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
^~~
include/asm-generic/bug.h:154:3: note: in expansion of macro 'WARN'
WARN(1, format);\
^~~~
include/linux/device.h:1506:2: note: in expansion of macro 'WARN_ONCE'
WARN_ONCE(condition, "%s %s: " format, \
^
drivers/usb/dwc3/gadget.c:2375:5: note: in expansion of macro 'dev_WARN_ONCE'
dev_WARN_ONCE(dwc->dev,
^
drivers/usb/dwc3/gadget.c:2375:19: note: each undeclared identifier is
reported only once for each function it appears in
dev_WARN_ONCE(dwc->dev,
^
include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
^~~
include/asm-generic/bug.h:154:3: note: in expansion of macro 'WARN'
WARN(1, format);\
^~~~
include/linux/device.h:1506:2: note: in expansion of macro 'WARN_ONCE'
WARN_ONCE(condition, "%s %s: " format, \
^
drivers/usb/dwc3/gadget.c:2375:5: note: in expansion of macro 'dev_WARN_ONCE'
dev_WARN_ONCE(dwc->dev,
^
vim +/dwc +2375 drivers/usb/dwc3/gadget.c
e5ba5ec833 Pratyush Anand 2013-01-14 2316
0cdab4c202 Felipe Balbi 2018-03-27 2317 static int
dwc3_gadget_ep_cleanup_completed_requests(struct dwc3_ep *dep,
0cdab4c202 Felipe Balbi 2018-03-27 2318const struct
dwc3_event_depevt *event, int status)
e5ba5ec833 Pratyush Anand 2013-01-14 2319 {
31162af447 Felipe Balbi 2016-08-11 2320struct dwc3_request
*req, *n;
e5ba5ec833 Pratyush Anand 2013-01-14 2321struct dwc3_trb
*trb;
d6e10bf2ba Arnd Bergmann2016-09-09 2322bool
ioc = false;
e62c5bc573 Felipe Balbi 2016-10-25 2323int
ret = 0;
e5ba5ec833 Pratyush Anand 2013-01-14 2324
31162af447 Felipe Balbi 2016-08-11 2325
list_for_each_entry_safe(req, n, &dep->started_list, list) {
1f512119a0 Felipe Balbi 2016-08-12 2326unsigned length;
e5b36ae2f8 Felipe Balbi 2016-08-10 2327int chain;
e5b36ae2f8 Felipe Balbi 2016-08-10 2328
1f512119a0 Felipe Balbi 2016-08-12 2329length =
req->request.length;
1f512119a0 Felipe Balbi 2016-08-12 2330chain =
req->num_pending_sgs > 0;
31162af447 Felipe Balbi 2016-08-11 2331if (chain) {
1f512119a0 Felipe Balbi 2016-08-12 2332struct
scatterlist *sg = req->sg;
31162af447 Felipe Balbi 2016-08-11 2333struct
scatterlist *s;
1f512119a0 Felipe Balbi 2016-08-12 2334
unsigned int pending = req->num_pending_sgs;
31162af447 Felipe Balbi 2016-08-11 2335
unsigned int i;
ac7bdcc1b3 Felipe Balbi 2015-11-16 2336
1f512119a0 Felipe Balbi 2016-08-12 2337
for_each_sg(sg, s, pending, i) {
737f1ae255 Felipe Balbi 2016-08-11 2338
trb = &dep->trb_pool[dep->trb_dequeue];
c7de573471 Felipe Balbi 2016-07-29 2339
7282c4ef0b Felipe Balbi 2016-10-25 2340
if (trb->ctrl & DWC3_TRB_CTRL_HWO)
7282c4ef0b Felipe Balbi 2016-10-25 2341
break;
7282c4ef0b Felipe Balbi 2016-10-25 2342
1f512119a0
[balbi-usb:next 49/82] drivers/usb/dwc3/gadget.c:2375:19: error: 'dwc' undeclared; did you mean 'dwc3'?
tree: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
head: 3196f73ff8444f6b8bfce3dce1900b4eae27c324
commit: 0cdab4c202ea0dd241ddaacf1d3a8a282590cb61 [49/82] usb: dwc3: gadget:
remove unnecessary 'dwc' parameter
config: x86_64-randconfig-i0-201819 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
git checkout 0cdab4c202ea0dd241ddaacf1d3a8a282590cb61
# save the attached .config to linux build tree
make ARCH=x86_64
Note: the balbi-usb/next HEAD 3196f73ff8444f6b8bfce3dce1900b4eae27c324 builds
fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
In file included from arch/x86/include/asm/bug.h:83:0,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/gfp.h:5,
from include/linux/slab.h:15,
from drivers/usb/dwc3/gadget.c:13:
drivers/usb/dwc3/gadget.c: In function
'dwc3_gadget_ep_cleanup_completed_requests':
>> drivers/usb/dwc3/gadget.c:2375:19: error: 'dwc' undeclared (first use in
>> this function); did you mean 'dwc3'?
dev_WARN_ONCE(dwc->dev,
^
include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
^~~
include/asm-generic/bug.h:154:3: note: in expansion of macro 'WARN'
WARN(1, format);\
^~~~
include/linux/device.h:1506:2: note: in expansion of macro 'WARN_ONCE'
WARN_ONCE(condition, "%s %s: " format, \
^
drivers/usb/dwc3/gadget.c:2375:5: note: in expansion of macro 'dev_WARN_ONCE'
dev_WARN_ONCE(dwc->dev,
^
drivers/usb/dwc3/gadget.c:2375:19: note: each undeclared identifier is
reported only once for each function it appears in
dev_WARN_ONCE(dwc->dev,
^
include/asm-generic/bug.h:98:50: note: in definition of macro '__WARN_printf'
#define __WARN_printf(arg...) do { __warn_printk(arg); __WARN(); } while (0)
^~~
include/asm-generic/bug.h:154:3: note: in expansion of macro 'WARN'
WARN(1, format);\
^~~~
include/linux/device.h:1506:2: note: in expansion of macro 'WARN_ONCE'
WARN_ONCE(condition, "%s %s: " format, \
^
drivers/usb/dwc3/gadget.c:2375:5: note: in expansion of macro 'dev_WARN_ONCE'
dev_WARN_ONCE(dwc->dev,
^
vim +2375 drivers/usb/dwc3/gadget.c
e5ba5ec833 Pratyush Anand 2013-01-14 2316
0cdab4c202 Felipe Balbi 2018-03-27 2317 static int
dwc3_gadget_ep_cleanup_completed_requests(struct dwc3_ep *dep,
0cdab4c202 Felipe Balbi 2018-03-27 2318const struct
dwc3_event_depevt *event, int status)
e5ba5ec833 Pratyush Anand 2013-01-14 2319 {
31162af447 Felipe Balbi 2016-08-11 2320struct dwc3_request
*req, *n;
e5ba5ec833 Pratyush Anand 2013-01-14 2321struct dwc3_trb
*trb;
d6e10bf2ba Arnd Bergmann2016-09-09 2322bool
ioc = false;
e62c5bc573 Felipe Balbi 2016-10-25 2323int
ret = 0;
e5ba5ec833 Pratyush Anand 2013-01-14 2324
31162af447 Felipe Balbi 2016-08-11 2325
list_for_each_entry_safe(req, n, &dep->started_list, list) {
1f512119a0 Felipe Balbi 2016-08-12 2326unsigned length;
e5b36ae2f8 Felipe Balbi 2016-08-10 2327int chain;
e5b36ae2f8 Felipe Balbi 2016-08-10 2328
1f512119a0 Felipe Balbi 2016-08-12 2329length =
req->request.length;
1f512119a0 Felipe Balbi 2016-08-12 2330chain =
req->num_pending_sgs > 0;
31162af447 Felipe Balbi 2016-08-11 2331if (chain) {
1f512119a0 Felipe Balbi 2016-08-12 2332struct
scatterlist *sg = req->sg;
31162af447 Felipe Balbi 2016-08-11 2333struct
scatterlist *s;
1f512119a0 Felipe Balbi 2016-08-12 2334
unsigned int pending = req->num_pending_sgs;
31162af447 Felipe Balbi 2016-08-11 2335
unsigned int i;
ac7bdcc1b3 Felipe Balbi 2015-11-16 2336
1f512119a0 Felipe Balbi 2016-08-12 2337
for_each_sg(sg, s, pending, i) {
737f1ae255 Felipe Balbi 2016-08-11 2338
trb = &dep->trb_pool[dep->trb_dequeue];
c7de573471 Felipe Balbi 2016-07-29 2339
7282c4ef0b Felipe Balbi 2016-10-25 2340
if (trb->ctrl & DWC3_TRB_CTRL_HWO)
7282c4ef0b Felipe Balbi 2016-10-25 2341
break;
7282c4ef0b Felipe Balbi 2016-10-25 2342
1f51
Re: [PATCH v5 1/7] clk: msm8996-gcc: Mark halt check as no-op for USB/PCIE pipe_clk
Hi Manu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on phy/next]
[also build test ERROR on v4.17-rc3 next-20180503]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Manu-Gautam/phy-qcom-Updates-for-USB-PHYs-on-SDM845/20180503-163006
base: https://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git
next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
>> drivers/clk//qcom/gcc-msm8996.c:1421:16: error: 'BRANCH_HALT_SKIP'
>> undeclared here (not in a function); did you mean 'BRANCH_HALT_VOTED'?
.halt_check = BRANCH_HALT_SKIP,
^~~~
BRANCH_HALT_VOTED
vim +1421 drivers/clk//qcom/gcc-msm8996.c
1418
1419 static struct clk_branch gcc_usb3_phy_pipe_clk = {
1420 .halt_reg = 0x50004,
> 1421 .halt_check = BRANCH_HALT_SKIP,
1422 .clkr = {
1423 .enable_reg = 0x50004,
1424 .enable_mask = BIT(0),
1425 .hw.init = &(struct clk_init_data){
1426 .name = "gcc_usb3_phy_pipe_clk",
1427 .parent_names = (const char *[]){
"usb3_phy_pipe_clk_src" },
1428 .num_parents = 1,
1429 .flags = CLK_SET_RATE_PARENT,
1430 .ops = &clk_branch2_ops,
1431 },
1432 },
1433 };
1434
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
[hid:for-4.18/multitouch 7/7] drivers/hid/hid-multitouch.c:1209:9-10: WARNING: return of 0/1 in function 'mt_need_to_apply_feature' with return type bool
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git
for-4.18/multitouch
head: 02946f4b43b11026b1a76857a33b09078b900939
commit: 02946f4b43b11026b1a76857a33b09078b900939 [7/7] HID: multitouch:
implement precision touchpad latency and switches
coccinelle warnings: (new ones prefixed by >>)
>> drivers/hid/hid-multitouch.c:1209:9-10: WARNING: return of 0/1 in function
>> 'mt_need_to_apply_feature' with return type bool
vim +/mt_need_to_apply_feature +1209 drivers/hid/hid-multitouch.c
1161
1162 static bool mt_need_to_apply_feature(struct hid_device *hdev,
1163 struct hid_field *field,
1164 struct hid_usage *usage,
1165 enum latency_mode latency,
1166 bool surface_switch,
1167 bool button_switch)
1168 {
1169 struct mt_device *td = hid_get_drvdata(hdev);
1170 struct mt_class *cls = &td->mtclass;
1171 struct hid_report *report = field->report;
1172 unsigned int index = usage->usage_index;
1173 char *buf;
1174 u32 report_len;
1175 int max;
1176
1177 switch (usage->hid) {
1178 case HID_DG_INPUTMODE:
1179 if (cls->quirks & MT_QUIRK_FORCE_GET_FEATURE) {
1180 report_len = hid_report_len(report);
1181 buf = hid_alloc_report_buf(report, GFP_KERNEL);
1182 if (!buf) {
1183 hid_err(hdev,
1184 "failed to allocate buffer for
report\n");
1185 return false;
1186 }
1187 hid_hw_raw_request(hdev, report->id, buf,
report_len,
1188 HID_FEATURE_REPORT,
1189 HID_REQ_GET_REPORT);
1190 kfree(buf);
1191 }
1192
1193 field->value[index] = td->inputmode_value;
1194 return true;
1195
1196 case HID_DG_CONTACTMAX:
1197 if (td->mtclass.maxcontacts) {
1198 max = min_t(int, field->logical_maximum,
1199 td->mtclass.maxcontacts);
1200 if (field->value[index] != max) {
1201 field->value[index] = max;
1202 return true;
1203 }
1204 }
1205 break;
1206
1207 case HID_DG_LATENCYMODE:
1208 field->value[index] = latency;
> 1209 return 1;
1210
1211 case HID_DG_SURFACESWITCH:
1212 field->value[index] = surface_switch;
1213 return 1;
1214
1215 case HID_DG_BUTTONSWITCH:
1216 field->value[index] = button_switch;
1217 return 1;
1218 }
1219
1220 return false; /* no need to update the report */
1221 }
1222
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] USB: Increment wakeup count on remote wakeup.
Hi Ravi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.17-rc1 next-20180419]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ravi-Chandra-Sadineni/USB-Increment-wakeup-count-on-remote-wakeup/20180419-165317
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: x86_64-randconfig-x013-201815 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/usb//core/hcd.c: In function 'usb_hcd_resume_root_hub':
>> drivers/usb//core/hcd.c:2378:18: error: 'dev' undeclared (first use in this
>> function); did you mean 'cdev'?
pm_wakeup_event(dev, 0);
^~~
cdev
drivers/usb//core/hcd.c:2378:18: note: each undeclared identifier is
reported only once for each function it appears in
vim +2378 drivers/usb//core/hcd.c
2364
2365 /**
2366 * usb_hcd_resume_root_hub - called by HCD to resume its root hub
2367 * @hcd: host controller for this root hub
2368 *
2369 * The USB host controller calls this function when its root hub is
2370 * suspended (with the remote wakeup feature enabled) and a remote
2371 * wakeup request is received. The routine submits a workqueue request
2372 * to resume the root hub (that is, manage its downstream ports again).
2373 */
2374 void usb_hcd_resume_root_hub (struct usb_hcd *hcd)
2375 {
2376 unsigned long flags;
2377
> 2378 pm_wakeup_event(dev, 0);
2379 spin_lock_irqsave (&hcd_root_hub_lock, flags);
2380 if (hcd->rh_registered) {
2381 set_bit(HCD_FLAG_WAKEUP_PENDING, &hcd->flags);
2382 queue_work(pm_wq, &hcd->wakeup_work);
2383 }
2384 spin_unlock_irqrestore (&hcd_root_hub_lock, flags);
2385 }
2386 EXPORT_SYMBOL_GPL(usb_hcd_resume_root_hub);
2387
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] USB: Increment wakeup count on remote wakeup.
Hi Ravi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on v4.17-rc1 next-20180419]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Ravi-Chandra-Sadineni/USB-Increment-wakeup-count-on-remote-wakeup/20180419-165317
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
config: i386-randconfig-s0-201815 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers/usb/core/hcd.c: In function 'usb_hcd_resume_root_hub':
>> drivers/usb/core/hcd.c:2378:18: error: 'dev' undeclared (first use in this
>> function)
pm_wakeup_event(dev, 0);
^~~
drivers/usb/core/hcd.c:2378:18: note: each undeclared identifier is reported
only once for each function it appears in
vim +/dev +2378 drivers/usb/core/hcd.c
2364
2365 /**
2366 * usb_hcd_resume_root_hub - called by HCD to resume its root hub
2367 * @hcd: host controller for this root hub
2368 *
2369 * The USB host controller calls this function when its root hub is
2370 * suspended (with the remote wakeup feature enabled) and a remote
2371 * wakeup request is received. The routine submits a workqueue request
2372 * to resume the root hub (that is, manage its downstream ports again).
2373 */
2374 void usb_hcd_resume_root_hub (struct usb_hcd *hcd)
2375 {
2376 unsigned long flags;
2377
> 2378 pm_wakeup_event(dev, 0);
2379 spin_lock_irqsave (&hcd_root_hub_lock, flags);
2380 if (hcd->rh_registered) {
2381 set_bit(HCD_FLAG_WAKEUP_PENDING, &hcd->flags);
2382 queue_work(pm_wq, &hcd->wakeup_work);
2383 }
2384 spin_unlock_irqrestore (&hcd_root_hub_lock, flags);
2385 }
2386 EXPORT_SYMBOL_GPL(usb_hcd_resume_root_hub);
2387
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] xhci: dump event ring, testpatch for Luciano
Hi Mathias,
I love your patch! Perhaps something to improve:
[auto build test WARNING on v4.16]
[also build test WARNING on next-20180410]
[cannot apply to usb/usb-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Mathias-Nyman/xhci-dump-event-ring-testpatch-for-Luciano/20180410-211241
config: parisc-generic-64bit_defconfig (attached as .config)
compiler: hppa64-linux-gnu-gcc (GCC) 7.3.0
reproduce:
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=parisc
All warnings (new ones prefixed by >>):
In file included from drivers/usb/host/xhci-ring.c:58:0:
drivers/usb/host/xhci-ring.c: In function 'xhci_dump_ev_ring':
>> drivers/usb/host/xhci-ring.c:2272:19: warning: format '%llx' expects
>> argument of type 'long long unsigned int', but argument 3 has type 'long
>> unsigned int' [-Wformat=]
xhci_warn(xhci, "%llx: %s\n", seg->dma + (i * sizeof(union xhci_trb)),
^ ~~~
drivers/usb/host/xhci.h:1900:48: note: in definition of macro 'xhci_warn'
dev_warn(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
^~~
drivers/usb/host/xhci-ring.c:2278:18: warning: format '%llx' expects
argument of type 'long long unsigned int', but argument 3 has type 'dma_addr_t
{aka unsigned int}' [-Wformat=]
xhci_warn(xhci, "dequeue: %llx\n", xhci_trb_virt_to_dma(seg,
xhci->event_ring->dequeue));
^
drivers/usb/host/xhci.h:1900:48: note: in definition of macro 'xhci_warn'
dev_warn(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
^~~
vim +2272 drivers/usb/host/xhci-ring.c
2265
2266 static void xhci_dump_ev_ring(struct xhci_hcd *xhci)
2267 {
2268 int i;
2269 struct xhci_segment *seg = xhci->event_ring->first_seg;
2270
2271 for (i = 0; i < TRBS_PER_SEGMENT; i++) {
> 2272 xhci_warn(xhci, "%llx: %s\n", seg->dma + (i *
> sizeof(union xhci_trb)),
2273 xhci_decode_trb(seg->trbs[i].generic.field[0],
2274 seg->trbs[i].generic.field[1],
2275 seg->trbs[i].generic.field[2],
2276
seg->trbs[i].generic.field[3]));
2277 }
2278 xhci_warn(xhci, "dequeue: %llx\n", xhci_trb_virt_to_dma(seg,
xhci->event_ring->dequeue));
2279 }
2280
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] xhci: dump event ring, testpatch for Luciano
Hi Mathias,
I love your patch! Perhaps something to improve:
[auto build test WARNING on v4.16]
[also build test WARNING on next-20180410]
[cannot apply to usb/usb-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Mathias-Nyman/xhci-dump-event-ring-testpatch-for-Luciano/20180410-211241
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> drivers/usb/host/xhci-ring.c:2272:17: sparse: incorrect type in argument 1
>> (different base types) @@expected unsigned int [unsigned] [usertype]
>> field0 @@got igned] [usertype] field0 @@
drivers/usb/host/xhci-ring.c:2272:17:expected unsigned int [unsigned]
[usertype] field0
drivers/usb/host/xhci-ring.c:2272:17:got restricted __le32
>> drivers/usb/host/xhci-ring.c:2272:17: sparse: incorrect type in argument 2
>> (different base types) @@expected unsigned int [unsigned] [usertype]
>> field1 @@got igned] [usertype] field1 @@
drivers/usb/host/xhci-ring.c:2272:17:expected unsigned int [unsigned]
[usertype] field1
drivers/usb/host/xhci-ring.c:2272:17:got restricted __le32
>> drivers/usb/host/xhci-ring.c:2272:17: sparse: incorrect type in argument 3
>> (different base types) @@expected unsigned int [unsigned] [usertype]
>> field2 @@got igned] [usertype] field2 @@
drivers/usb/host/xhci-ring.c:2272:17:expected unsigned int [unsigned]
[usertype] field2
drivers/usb/host/xhci-ring.c:2272:17:got restricted __le32
>> drivers/usb/host/xhci-ring.c:2272:17: sparse: incorrect type in argument 4
>> (different base types) @@expected unsigned int [unsigned] [usertype]
>> field3 @@got igned] [usertype] field3 @@
drivers/usb/host/xhci-ring.c:2272:17:expected unsigned int [unsigned]
[usertype] field3
drivers/usb/host/xhci-ring.c:2272:17:got restricted __le32
drivers/usb/host/xhci-ring.c:645:9: sparse: context imbalance in
'xhci_giveback_urb_in_irq' - unexpected unlock
vim +2272 drivers/usb/host/xhci-ring.c
2265
2266 static void xhci_dump_ev_ring(struct xhci_hcd *xhci)
2267 {
2268 int i;
2269 struct xhci_segment *seg = xhci->event_ring->first_seg;
2270
2271 for (i = 0; i < TRBS_PER_SEGMENT; i++) {
> 2272 xhci_warn(xhci, "%llx: %s\n", seg->dma + (i *
> sizeof(union xhci_trb)),
2273 xhci_decode_trb(seg->trbs[i].generic.field[0],
2274 seg->trbs[i].generic.field[1],
2275 seg->trbs[i].generic.field[2],
2276
seg->trbs[i].generic.field[3]));
2277 }
2278 xhci_warn(xhci, "dequeue: %llx\n", xhci_trb_virt_to_dma(seg,
xhci->event_ring->dequeue));
2279 }
2280
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] xhci: dump event ring, testpatch for Luciano
Hi Mathias,
I love your patch! Perhaps something to improve:
[auto build test WARNING on v4.16]
[also build test WARNING on next-20180410]
[cannot apply to usb/usb-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Mathias-Nyman/xhci-dump-event-ring-testpatch-for-Luciano/20180410-211241
config: i386-randconfig-x008-201814 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
In file included from drivers/usb/host/xhci-ring.c:58:0:
drivers/usb/host/xhci-ring.c: In function 'xhci_dump_ev_ring':
>> drivers/usb/host/xhci-ring.c:2272:19: warning: format '%llx' expects
>> argument of type 'long long unsigned int', but argument 3 has type
>> 'dma_addr_t {aka unsigned int}' [-Wformat=]
xhci_warn(xhci, "%llx: %s\n", seg->dma + (i * sizeof(union xhci_trb)),
^ ~~~
drivers/usb/host/xhci.h:1900:48: note: in definition of macro 'xhci_warn'
dev_warn(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
^~~
drivers/usb/host/xhci-ring.c:2278:18: warning: format '%llx' expects
argument of type 'long long unsigned int', but argument 3 has type 'dma_addr_t
{aka unsigned int}' [-Wformat=]
xhci_warn(xhci, "dequeue: %llx\n", xhci_trb_virt_to_dma(seg,
xhci->event_ring->dequeue));
^
drivers/usb/host/xhci.h:1900:48: note: in definition of macro 'xhci_warn'
dev_warn(xhci_to_hcd(xhci)->self.controller , fmt , ## args)
^~~
Cyclomatic Complexity 5 include/linux/compiler.h:__read_once_size
Cyclomatic Complexity 5 include/linux/compiler.h:__write_once_size
Cyclomatic Complexity 2 arch/x86/include/asm/bitops.h:set_bit
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:test_and_clear_bit
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:constant_test_bit
Cyclomatic Complexity 1 arch/x86/include/asm/bitops.h:variable_test_bit
Cyclomatic Complexity 1 include/linux/list.h:INIT_LIST_HEAD
Cyclomatic Complexity 2 include/linux/list.h:__list_add
Cyclomatic Complexity 1 include/linux/list.h:list_add_tail
Cyclomatic Complexity 1 include/linux/list.h:__list_del
Cyclomatic Complexity 2 include/linux/list.h:__list_del_entry
Cyclomatic Complexity 1 include/linux/list.h:list_del
Cyclomatic Complexity 1 include/linux/list.h:list_del_init
Cyclomatic Complexity 1 include/linux/list.h:list_empty
Cyclomatic Complexity 3 include/linux/list.h:list_is_singular
Cyclomatic Complexity 2 arch/x86/include/asm/jump_label.h:arch_static_branch
Cyclomatic Complexity 1 include/linux/jump_label.h:static_key_false
Cyclomatic Complexity 6 arch/x86/include/asm/preempt.h:__preempt_count_add
Cyclomatic Complexity 6 arch/x86/include/asm/preempt.h:__preempt_count_sub
Cyclomatic Complexity 1 include/linux/spinlock.h:spinlock_check
Cyclomatic Complexity 1 include/linux/spinlock.h:spin_lock
Cyclomatic Complexity 1 include/linux/spinlock.h:spin_unlock
Cyclomatic Complexity 1 include/linux/spinlock.h:spin_unlock_irqrestore
Cyclomatic Complexity 1 include/linux/jiffies.h:_msecs_to_jiffies
Cyclomatic Complexity 3 include/linux/jiffies.h:msecs_to_jiffies
Cyclomatic Complexity 1 include/linux/rcupdate.h:rcu_read_lock_sched_notrace
Cyclomatic Complexity 1
include/linux/rcupdate.h:rcu_read_unlock_sched_notrace
Cyclomatic Complexity 1 include/linux/timer.h:timer_pending
Cyclomatic Complexity 2 include/linux/workqueue.h:to_delayed_work
Cyclomatic Complexity 1 include/linux/workqueue.h:mod_delayed_work
Cyclomatic Complexity 1 include/linux/mmzone.h:pfn_to_section_nr
Cyclomatic Complexity 2 include/linux/mmzone.h:__nr_to_section
Cyclomatic Complexity 1 include/linux/mmzone.h:__section_mem_map_addr
Cyclomatic Complexity 1 include/linux/mmzone.h:__pfn_to_section
Cyclomatic Complexity 1 include/linux/completion.h:reinit_completion
Cyclomatic Complexity 1 arch/x86/include/asm/io.h:readl
Cyclomatic Complexity 1 arch/x86/include/asm/io.h:writel
Cyclomatic Complexity 1 include/linux/dma-debug.h:debug_dma_map_page
Cyclomatic Complexity 1 include/linux/dma-debug.h:debug_dma_mapping_error
Cyclomatic Complexity 1 include/linux/dma-debug.h:debug_dma_unmap_page
Cyclomatic Complexity 1 include/linux/dma-mapping.h:valid_dma_direction
Cyclomatic Complexity 1 arch/x86/include/asm/dma-mapping.h:get_arch_dma_ops
Cyclomatic Complexity 4 include/linux/dma-mapping.h:get_dma_ops
Cyclomatic Complexity 1 include/linux/dma-mapping.h:dma_map_single_attrs
Cyclomatic Complexity 2 include/linux/dma-mapping.h:dma_unmap_single_attrs
Cyclo
Re: [PATCH] usb: gadget: f_fs: Add compat_ioctl to ep0
Hi Jerry,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.16 next-20180409]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jerry-Zhang/usb-gadget-f_fs-Add-compat_ioctl-to-ep0/20180410-060430
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-x017-201814 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/usb/gadget/function/f_fs.c: In function 'ffs_ep0_compat_ioctl':
>> drivers/usb/gadget/function/f_fs.c:651:13: error: 'gadget' undeclared (first
>> use in this function); did you mean 'bdget'?
} else if (gadget && gadget->ops->compat_ioctl) {
^~
bdget
drivers/usb/gadget/function/f_fs.c:651:13: note: each undeclared identifier
is reported only once for each function it appears in
vim +651 drivers/usb/gadget/function/f_fs.c
643
644 #ifdef CONFIG_COMPAT
645 static long ffs_ep0_compat_ioctl(struct file *file, unsigned code,
unsigned long value)
646 {
647 long ret;
648
649 if (code == FUNCTIONFS_INTERFACE_REVMAP) {
650 ret = ffs_ep0_ioctl(file, code, value);
> 651 } else if (gadget && gadget->ops->compat_ioctl) {
652 ret = gadget->ops->compat_ioctl(gadget, code, value);
653 } else {
654 ret = -ENOTTY;
655 }
656
657 return ret;
658 }
659 #endif
660
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] usb: gadget: f_midi: Add configfs attrs for card and device
Hi Jerry,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.16 next-20180409]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jerry-Zhang/usb-gadget-f_midi-Add-configfs-attrs-for-card-and-device/20180410-061518
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-x011-201814 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/usb/gadget/function/f_midi.c: In function 'f_midi_opts_card_show':
>> drivers/usb/gadget/function/f_midi.c:1188:22: error: 'struct
>> usb_function_instance' has no member named 'f'; did you mean 'fd'?
if (opts->func_inst.f) {
^
fd
drivers/usb/gadget/function/f_midi.c:1189:39: error: 'struct
usb_function_instance' has no member named 'f'; did you mean 'fd'?
midi = func_to_midi(opts->func_inst.f);
^
fd
drivers/usb/gadget/function/f_midi.c: In function 'f_midi_opts_device_show':
drivers/usb/gadget/function/f_midi.c:1206:22: error: 'struct
usb_function_instance' has no member named 'f'; did you mean 'fd'?
if (opts->func_inst.f) {
^
fd
drivers/usb/gadget/function/f_midi.c:1207:39: error: 'struct
usb_function_instance' has no member named 'f'; did you mean 'fd'?
midi = func_to_midi(opts->func_inst.f);
^
fd
vim +1188 drivers/usb/gadget/function/f_midi.c
1181
1182 static ssize_t f_midi_opts_card_show(struct config_item *item, char
*page)
1183 {
1184 struct f_midi_opts *opts = to_f_midi_opts(item);
1185 int card = -1;
1186 struct f_midi *midi;
1187
> 1188 if (opts->func_inst.f) {
1189 midi = func_to_midi(opts->func_inst.f);
1190 if (midi->rmidi && midi->rmidi->card) {
1191 card = midi->rmidi->card->number;
1192 }
1193 }
1194
1195 return sprintf(page, "%d\n", card);
1196 }
1197
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [PATCH] usb: gadget: f_fs: Add compat_ioctl to ep0
Hi Jerry,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on balbi-usb/next]
[also build test ERROR on v4.16 next-20180409]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Jerry-Zhang/usb-gadget-f_fs-Add-compat_ioctl-to-ep0/20180410-060430
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
config: x86_64-randconfig-s3-04100757 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/usb/gadget/function/f_fs.c: In function 'ffs_ep0_compat_ioctl':
>> drivers/usb/gadget/function/f_fs.c:651:13: error: 'gadget' undeclared (first
>> use in this function); did you mean 'dget'?
} else if (gadget && gadget->ops->compat_ioctl) {
^~
dget
drivers/usb/gadget/function/f_fs.c:651:13: note: each undeclared identifier
is reported only once for each function it appears in
vim +651 drivers/usb/gadget/function/f_fs.c
643
644 #ifdef CONFIG_COMPAT
645 static long ffs_ep0_compat_ioctl(struct file *file, unsigned code,
unsigned long value)
646 {
647 long ret;
648
649 if (code == FUNCTIONFS_INTERFACE_REVMAP) {
650 ret = ffs_ep0_ioctl(file, code, value);
> 651 } else if (gadget && gadget->ops->compat_ioctl) {
652 ret = gadget->ops->compat_ioctl(gadget, code, value);
653 } else {
654 ret = -ENOTTY;
655 }
656
657 return ret;
658 }
659 #endif
660
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
Re: [RFT/PATCH 35/38] usb: dwc3: gadget: combine modify & restore into single argument
Hi Felipe, I love your patch! Perhaps something to improve: [auto build test WARNING on balbi-usb/next] [also build test WARNING on next-20180409] [cannot apply to v4.16] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Felipe-Balbi/usb-dwc3-gadget-Rework-Refactoring/20180409-204052 base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next reproduce: make htmldocs All warnings (new ones prefixed by >>): include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > include/net/mac80211.h:2083: warning: bad line: > net/mac80211/sta_info.h:586: warning: Function parameter or member 'rx_stats_avg' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'rx_stats_avg.signal' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'rx_stats_avg.chain_signal' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.filtered' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.retry_failed' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.retry_count' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.lost_packets' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.last_tdls_pkt_time' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.msdu_retries' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.msdu_failed' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.last_ack' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.last_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'status_stats.ack_signal_filled' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:586: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info' kernel/sched/fair.c:3731: warning: Function parameter or member 'flags' not described in 'attach_entity_load_avg' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_excl.cb' not described in 'dma_buf' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_excl.poll' not described in 'dma_buf' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_excl.active' not described in 'dma_buf' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_shared.cb' not described in 'dma_buf' include/linux/dma-buf.h:307: warning: Function parameter or member 'cb_shared.poll' not descri
[usb:usb-next 76/100] ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined!
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next head: 5267c5e09c25e2ee6242b37833a9bdf9d97f54a2 commit: d54f063cdbe414590c97d990111ddff25c6f9593 [76/100] extcon: axp288: Set USB role where necessary config: i386-randconfig-b0-03301441 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: git checkout d54f063cdbe414590c97d990111ddff25c6f9593 # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): >> ERROR: "usb_role_switch_get" [drivers/extcon/extcon-axp288.ko] undefined! >> ERROR: "usb_role_switch_get_role" [drivers/extcon/extcon-axp288.ko] >> undefined! >> ERROR: "usb_role_switch_set_role" [drivers/extcon/extcon-axp288.ko] >> undefined! >> ERROR: "usb_role_switch_put" [drivers/extcon/extcon-axp288.ko] undefined! --- 0-DAY kernel test infrastructureOpen Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation .config.gz Description: application/gzip
Re: [PATCH v3] usb: dwc2: dwc2_vbus_supply_init: fix error check
Hi Tomeu,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on balbi-usb/next]
[also build test WARNING on next-20180323]
[cannot apply to v4.16-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Tomeu-Vizoso/usb-dwc2-dwc2_vbus_supply_init-fix-error-check/20180324-063752
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git next
coccinelle warnings: (new ones prefixed by >>)
>> drivers/usb/dwc2/hcd.c:367:9-16: ERROR: PTR_ERR applied after initialization
>> to constant on line 366
vim +367 drivers/usb/dwc2/hcd.c
358
359 static int dwc2_vbus_supply_init(struct dwc2_hsotg *hsotg)
360 {
361 hsotg->vbus_supply = devm_regulator_get_optional(hsotg->dev,
"vbus");
362 if (PTR_ERR(hsotg->vbus_supply) == -ENODEV) {
363 hsotg->vbus_supply = NULL;
364 return 0;
365 } else if (IS_ERR(hsotg->vbus_supply)) {
> 366 hsotg->vbus_supply = NULL;
> 367 return PTR_ERR(hsotg->vbus_supply);
368 }
369
370 return regulator_enable(hsotg->vbus_supply);
371 }
372
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[hid:for-4.17/upstream 10/10] drivers//hid/hid-multitouch.c:379:8: error: 'struct mt_device' has no member named 'initial_quirks'
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git
for-4.17/upstream
head: f6e9683c937e2246bbc1e7e8582ec71d6494f1f0
commit: f6e9683c937e2246bbc1e7e8582ec71d6494f1f0 [10/10] HID: core: reset the
quirks before calling probe again
config: i386-randconfig-x000-201811 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout f6e9683c937e2246bbc1e7e8582ec71d6494f1f0
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
drivers//hid/hid-multitouch.c: In function 'mt_get_feature':
>> drivers//hid/hid-multitouch.c:379:8: error: 'struct mt_device' has no member
>> named 'initial_quirks'
if (td->initial_quirks & HID_QUIRK_NO_INIT_REPORTS)
^~
vim +379 drivers//hid/hid-multitouch.c
eec29e3d Benjamin Tissoires 2011-11-23 368
6d4f5440 Mika Westerberg2015-10-07 369 static void mt_get_feature(struct
hid_device *hdev, struct hid_report *report)
6d4f5440 Mika Westerberg2015-10-07 370 {
6d4f5440 Mika Westerberg2015-10-07 371 struct mt_device *td =
hid_get_drvdata(hdev);
6d4f5440 Mika Westerberg2015-10-07 372 int ret, size =
hid_report_len(report);
6d4f5440 Mika Westerberg2015-10-07 373 u8 *buf;
6d4f5440 Mika Westerberg2015-10-07 374
6d4f5440 Mika Westerberg2015-10-07 375 /*
b897f6db Benjamin Tissoires 2016-11-25 376 * Do not fetch the feature
report if the device has been explicitly
b897f6db Benjamin Tissoires 2016-11-25 377 * marked as non-capable.
6d4f5440 Mika Westerberg2015-10-07 378 */
b897f6db Benjamin Tissoires 2016-11-25 @379 if (td->initial_quirks &
HID_QUIRK_NO_INIT_REPORTS)
6d4f5440 Mika Westerberg2015-10-07 380 return;
6d4f5440 Mika Westerberg2015-10-07 381
6d4f5440 Mika Westerberg2015-10-07 382 buf =
hid_alloc_report_buf(report, GFP_KERNEL);
6d4f5440 Mika Westerberg2015-10-07 383 if (!buf)
6d4f5440 Mika Westerberg2015-10-07 384 return;
6d4f5440 Mika Westerberg2015-10-07 385
6d4f5440 Mika Westerberg2015-10-07 386 ret = hid_hw_raw_request(hdev,
report->id, buf, size,
6d4f5440 Mika Westerberg2015-10-07 387
HID_FEATURE_REPORT, HID_REQ_GET_REPORT);
6d4f5440 Mika Westerberg2015-10-07 388 if (ret < 0) {
6d4f5440 Mika Westerberg2015-10-07 389 dev_warn(&hdev->dev,
"failed to fetch feature %d\n",
6d4f5440 Mika Westerberg2015-10-07 390 report->id);
6d4f5440 Mika Westerberg2015-10-07 391 } else {
6d4f5440 Mika Westerberg2015-10-07 392 ret =
hid_report_raw_event(hdev, HID_FEATURE_REPORT, buf,
6d4f5440 Mika Westerberg2015-10-07 393
size, 0);
6d4f5440 Mika Westerberg2015-10-07 394 if (ret)
6d4f5440 Mika Westerberg2015-10-07 395
dev_warn(&hdev->dev, "failed to report feature\n");
6d4f5440 Mika Westerberg2015-10-07 396 }
6d4f5440 Mika Westerberg2015-10-07 397
6d4f5440 Mika Westerberg2015-10-07 398 kfree(buf);
6d4f5440 Mika Westerberg2015-10-07 399 }
6d4f5440 Mika Westerberg2015-10-07 400
:: The code at line 379 was first introduced by commit
:: b897f6db3ae2cd9a42377f8b1865450f34ceff0e HID: multitouch: do not
retrieve all reports for all devices
:: TO: Benjamin Tissoires
:: CC: Jiri Kosina
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
