Re: [PATCH v2] usb: dwc3: Set the ClearPendIN bit on Clear Stall EP command

[John Youn]

On 5/31/2016 12:09 AM, Felipe Balbi wrote:
> 
> Hi John,
> 
> John Youn  writes:
>> As of core revision 2.60a the recommended programming model is to set
>> the ClearPendIN bit when issuing a Clear Stall EP command for IN
>> endpoints. This is to prevent an issue where some (non-compliant) hosts
>> may not send ACK TPs for pending IN transfers due to a mishandled error
>> condition. Synopsys STAR 9000614252.
>>
>> Signed-off-by: John Youn 
> 
> this doesn't apply to v4.7-rc1. Care to rebase on testing/fixes, please?
> 

Sure. I'll send an update later today.

Regards,
John

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] usb: dwc3: Set the ClearPendIN bit on Clear Stall EP command

[Felipe Balbi]

Hi John,

John Youn  writes:
> As of core revision 2.60a the recommended programming model is to set
> the ClearPendIN bit when issuing a Clear Stall EP command for IN
> endpoints. This is to prevent an issue where some (non-compliant) hosts
> may not send ACK TPs for pending IN transfers due to a mishandled error
> condition. Synopsys STAR 9000614252.
>
> Signed-off-by: John Youn 

this doesn't apply to v4.7-rc1. Care to rebase on testing/fixes, please?

-- 
balbi


signature.asc
Description: PGP signature

[PATCH v2] usb: dwc3: Set the ClearPendIN bit on Clear Stall EP command

[John Youn]

As of core revision 2.60a the recommended programming model is to set
the ClearPendIN bit when issuing a Clear Stall EP command for IN
endpoints. This is to prevent an issue where some (non-compliant) hosts
may not send ACK TPs for pending IN transfers due to a mishandled error
condition. Synopsys STAR 9000614252.

Signed-off-by: John Youn 
---
v2:
* Removed the call to dwc3_is_usb31(). We set the high bit in the
  version for USB 31 IP so that we can just do a comparison for these
  cases.
* Rewrote the commit message.
* Added comment

 drivers/usb/dwc3/core.h   |  1 +
 drivers/usb/dwc3/gadget.c | 30 --
 2 files changed, 25 insertions(+), 6 deletions(-)

diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h
index 74dff47..dcdba14 100644
--- a/drivers/usb/dwc3/core.h
+++ b/drivers/usb/dwc3/core.h
@@ -417,6 +417,7 @@
 #define DWC3_DEPCMD_GET_RSC_IDX(x) (((x) >> DWC3_DEPCMD_PARAM_SHIFT) & 
0x7f)
 #define DWC3_DEPCMD_STATUS(x)  (((x) >> 12) & 0x0F)
 #define DWC3_DEPCMD_HIPRI_FORCERM  (1 << 11)
+#define DWC3_DEPCMD_CLEARPENDIN(1 << 11)
 #define DWC3_DEPCMD_CMDACT (1 << 10)
 #define DWC3_DEPCMD_CMDIOC (1 << 8)
 
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 5d82ab6..b4779dd 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -334,6 +334,28 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsigned 
cmd,
return ret;
 }
 
+static int dwc3_send_clear_stall_ep_cmd(struct dwc3_ep *dep)
+{
+   struct dwc3 *dwc = dep->dwc;
+   struct dwc3_gadget_ep_cmd_params params;
+   u32 cmd = DWC3_DEPCMD_CLEARSTALL;
+
+   /*
+* As of core revision 2.60a the recommended programming model
+* is to set the ClearPendIN bit when issuing a Clear Stall EP
+* command for IN endpoints. This is to prevent an issue where
+* some (non-compliant) hosts may not send ACK TPs for pending
+* IN transfers due to a mishandled error condition. Synopsys
+* STAR 9000614252.
+*/
+   if (dep->direction && (dwc->revision >= DWC3_REVISION_260A))
+   cmd |= DWC3_DEPCMD_CLEARPENDIN;
+
+   memset(, 0, sizeof(params));
+
+   return dwc3_send_gadget_ep_cmd(dep, cmd, );
+}
+
 static dma_addr_t dwc3_trb_dma_offset(struct dwc3_ep *dep,
struct dwc3_trb *trb)
 {
@@ -1290,8 +1312,7 @@ int __dwc3_gadget_ep_set_halt(struct dwc3_ep *dep, int 
value, int protocol)
else
dep->flags |= DWC3_EP_STALL;
} else {
-   ret = dwc3_send_gadget_ep_cmd(dep, DWC3_DEPCMD_CLEARSTALL,
-   );
+   ret = dwc3_send_clear_stall_ep_cmd(dep);
if (ret)
dev_err(dwc->dev, "failed to clear STALL on %s\n",
dep->name);
@@ -2300,7 +2321,6 @@ static void dwc3_clear_stall_all_ep(struct dwc3 *dwc)
 
for (epnum = 1; epnum < DWC3_ENDPOINTS_NUM; epnum++) {
struct dwc3_ep *dep;
-   struct dwc3_gadget_ep_cmd_params params;
int ret;
 
dep = dwc->eps[epnum];
@@ -2312,9 +2332,7 @@ static void dwc3_clear_stall_all_ep(struct dwc3 *dwc)
 
dep->flags &= ~DWC3_EP_STALL;
 
-   memset(, 0, sizeof(params));
-   ret = dwc3_send_gadget_ep_cmd(dep, DWC3_DEPCMD_CLEARSTALL,
-   );
+   ret = dwc3_send_clear_stall_ep_cmd(dep);
WARN_ON_ONCE(ret);
}
 }
-- 
2.8.2

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html