Re: [PATCH usb v3 00/29] cleanup and fixes on resource check
Hi, On Tue, Nov 04, 2014 at 06:46:16AM +0530, Varka Bhadram wrote: Hi greg k-h, On Tuesday 04 November 2014 05:16 AM, Greg KH wrote: On Fri, Oct 31, 2014 at 05:31:41PM +0300, Sergei Shtylyov wrote: Hello. On 10/31/2014 4:14 AM, Varka Bhadram wrote: This series removes the duplication of sanity check for platform_get_resource() return resource. It will be checked with devm_ioremap_resource() This entire series rebased on testing/fixes of [1]. [1]: http://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git changes since v1: - removed broken patches - added Ack of Alan Stern for all the ehci, ohci, and uhci changes. changes since v2: - addressed Sergei Shtylyov comments Varka Bhadram (29): host: ehci-atmel: remove duplicate check on resource host: ohci-da8xx: remove duplicate check on resource host: ehci-tegra: remove duplicate check on resource host: ehci-w90x900: remove duplicate check on resource host: ohci-at91: remove duplicate check on resource host: ohci-exynos: remove duplicate check on resource host: ohci-jz4740: remove duplicate check on resource host: ohci-octeon: remove duplicate check on resource host: ohci-platform: remove duplicate check on resource host: ohci-pxa27x: remove duplicate check on resource host: ehci-sh: remove duplicate check on resource host: ohci-spear: remove duplicate check on resource host: ehci-msm: remove duplicate check on resource host: ehci-mv: remove duplicate check on resource host: ehci-mxc: remove duplicate check on resource host: ehci-octeon: remove duplicate check on resource host: ehci-orion: remove duplicate check on resource host: ehci-platform: remove duplicate check on resource host: ehci-sead3: fix NULL pointer dereference on resource Mixing fixes and cleanups in one series is not a good idea, generally speaking. I agree. Send me the fixes first in a series, so that I can get them into this kernel release, and older ones. Then send the cleanups in a separate series based on your first one, if needed, and all should be good. I will send the fixes based on [1] usb-next branch first, then cleanup as a separate series. But balbi told that these series should go through his [2] kernel tree. Can i send this entire series based on [1] usb-next branch..? read again my comment. I said that I take care of dwc3, dwc2, renesas, usb gadget, musb, and PHY. I don't have any thing to do with the host side. -- balbi signature.asc Description: Digital signature
Re: [PATCH usb v3 00/29] cleanup and fixes on resource check
On Fri, Oct 31, 2014 at 05:31:41PM +0300, Sergei Shtylyov wrote: Hello. On 10/31/2014 4:14 AM, Varka Bhadram wrote: This series removes the duplication of sanity check for platform_get_resource() return resource. It will be checked with devm_ioremap_resource() This entire series rebased on testing/fixes of [1]. [1]: http://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git changes since v1: - removed broken patches - added Ack of Alan Stern for all the ehci, ohci, and uhci changes. changes since v2: - addressed Sergei Shtylyov comments Varka Bhadram (29): host: ehci-atmel: remove duplicate check on resource host: ohci-da8xx: remove duplicate check on resource host: ehci-tegra: remove duplicate check on resource host: ehci-w90x900: remove duplicate check on resource host: ohci-at91: remove duplicate check on resource host: ohci-exynos: remove duplicate check on resource host: ohci-jz4740: remove duplicate check on resource host: ohci-octeon: remove duplicate check on resource host: ohci-platform: remove duplicate check on resource host: ohci-pxa27x: remove duplicate check on resource host: ehci-sh: remove duplicate check on resource host: ohci-spear: remove duplicate check on resource host: ehci-msm: remove duplicate check on resource host: ehci-mv: remove duplicate check on resource host: ehci-mxc: remove duplicate check on resource host: ehci-octeon: remove duplicate check on resource host: ehci-orion: remove duplicate check on resource host: ehci-platform: remove duplicate check on resource host: ehci-sead3: fix NULL pointer dereference on resource Mixing fixes and cleanups in one series is not a good idea, generally speaking. I agree. Send me the fixes first in a series, so that I can get them into this kernel release, and older ones. Then send the cleanups in a separate series based on your first one, if needed, and all should be good. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH usb v3 00/29] cleanup and fixes on resource check
Hi greg k-h, On Tuesday 04 November 2014 05:16 AM, Greg KH wrote: On Fri, Oct 31, 2014 at 05:31:41PM +0300, Sergei Shtylyov wrote: Hello. On 10/31/2014 4:14 AM, Varka Bhadram wrote: This series removes the duplication of sanity check for platform_get_resource() return resource. It will be checked with devm_ioremap_resource() This entire series rebased on testing/fixes of [1]. [1]: http://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git changes since v1: - removed broken patches - added Ack of Alan Stern for all the ehci, ohci, and uhci changes. changes since v2: - addressed Sergei Shtylyov comments Varka Bhadram (29): host: ehci-atmel: remove duplicate check on resource host: ohci-da8xx: remove duplicate check on resource host: ehci-tegra: remove duplicate check on resource host: ehci-w90x900: remove duplicate check on resource host: ohci-at91: remove duplicate check on resource host: ohci-exynos: remove duplicate check on resource host: ohci-jz4740: remove duplicate check on resource host: ohci-octeon: remove duplicate check on resource host: ohci-platform: remove duplicate check on resource host: ohci-pxa27x: remove duplicate check on resource host: ehci-sh: remove duplicate check on resource host: ohci-spear: remove duplicate check on resource host: ehci-msm: remove duplicate check on resource host: ehci-mv: remove duplicate check on resource host: ehci-mxc: remove duplicate check on resource host: ehci-octeon: remove duplicate check on resource host: ehci-orion: remove duplicate check on resource host: ehci-platform: remove duplicate check on resource host: ehci-sead3: fix NULL pointer dereference on resource Mixing fixes and cleanups in one series is not a good idea, generally speaking. I agree. Send me the fixes first in a series, so that I can get them into this kernel release, and older ones. Then send the cleanups in a separate series based on your first one, if needed, and all should be good. I will send the fixes based on [1] usb-next branch first, then cleanup as a separate series. But balbi told that these series should go through his [2] kernel tree. Can i send this entire series based on [1] usb-next branch..? Thanks for the review. [1]:http://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/ [2]:https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/ -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH usb v3 00/29] cleanup and fixes on resource check
On Tuesday 04 November 2014 06:46 AM, Varka Bhadram wrote: Hi greg k-h, On Tuesday 04 November 2014 05:16 AM, Greg KH wrote: On Fri, Oct 31, 2014 at 05:31:41PM +0300, Sergei Shtylyov wrote: Hello. On 10/31/2014 4:14 AM, Varka Bhadram wrote: This series removes the duplication of sanity check for platform_get_resource() return resource. It will be checked with devm_ioremap_resource() This entire series rebased on testing/fixes of [1]. [1]: http://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git changes since v1: - removed broken patches - added Ack of Alan Stern for all the ehci, ohci, and uhci changes. changes since v2: - addressed Sergei Shtylyov comments Varka Bhadram (29): host: ehci-atmel: remove duplicate check on resource host: ohci-da8xx: remove duplicate check on resource host: ehci-tegra: remove duplicate check on resource host: ehci-w90x900: remove duplicate check on resource host: ohci-at91: remove duplicate check on resource host: ohci-exynos: remove duplicate check on resource host: ohci-jz4740: remove duplicate check on resource host: ohci-octeon: remove duplicate check on resource host: ohci-platform: remove duplicate check on resource host: ohci-pxa27x: remove duplicate check on resource host: ehci-sh: remove duplicate check on resource host: ohci-spear: remove duplicate check on resource host: ehci-msm: remove duplicate check on resource host: ehci-mv: remove duplicate check on resource host: ehci-mxc: remove duplicate check on resource host: ehci-octeon: remove duplicate check on resource host: ehci-orion: remove duplicate check on resource host: ehci-platform: remove duplicate check on resource host: ehci-sead3: fix NULL pointer dereference on resource Mixing fixes and cleanups in one series is not a good idea, generally speaking. I agree. Send me the fixes first in a series, so that I can get them into this kernel release, and older ones. Then send the cleanups in a separate series based on your first one, if needed, and all should be good. I will send the fixes based on [1] usb-next branch first, then cleanup as a separate series. But balbi told that these series should go through his [2] kernel tree. Can i send this entire series based on [1] usb-next branch..? Thanks for the review. [1]:http://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/ [2]:https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/ I divided the entire series into two series's, one for fixes and another for cleanup with version4. I rebased the series on usb-next branch of [1] and send it. Please review it. [1]:https://git.kernel.org/cgit/linux/kernel/git/gregkh/usb.git/ -- Thanks and Regards, Varka Bhadram. -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH usb v3 00/29] cleanup and fixes on resource check
Hello. On 10/31/2014 4:14 AM, Varka Bhadram wrote: This series removes the duplication of sanity check for platform_get_resource() return resource. It will be checked with devm_ioremap_resource() This entire series rebased on testing/fixes of [1]. [1]: http://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git changes since v1: - removed broken patches - added Ack of Alan Stern for all the ehci, ohci, and uhci changes. changes since v2: - addressed Sergei Shtylyov comments Varka Bhadram (29): host: ehci-atmel: remove duplicate check on resource host: ohci-da8xx: remove duplicate check on resource host: ehci-tegra: remove duplicate check on resource host: ehci-w90x900: remove duplicate check on resource host: ohci-at91: remove duplicate check on resource host: ohci-exynos: remove duplicate check on resource host: ohci-jz4740: remove duplicate check on resource host: ohci-octeon: remove duplicate check on resource host: ohci-platform: remove duplicate check on resource host: ohci-pxa27x: remove duplicate check on resource host: ehci-sh: remove duplicate check on resource host: ohci-spear: remove duplicate check on resource host: ehci-msm: remove duplicate check on resource host: ehci-mv: remove duplicate check on resource host: ehci-mxc: remove duplicate check on resource host: ehci-octeon: remove duplicate check on resource host: ehci-orion: remove duplicate check on resource host: ehci-platform: remove duplicate check on resource host: ehci-sead3: fix NULL pointer dereference on resource Mixing fixes and cleanups in one series is not a good idea, generally speaking. host: ehci-spear: remove duplicate check on resource host: uhci-platform: fix NULL pointer dereference on resource host: xhci-plat: remove duplicate check on resource musb: musb_core: remove duplicate check on resource musb: musb_dsps: remove duplicate check on resource phy: phy-rcar-usb: remove duplicate check on resource renesas_usbhs: common: remove duplicate check on resource dwc3: dwc3-keystone: remove duplicate check on resource host: ehci-fsl: remove duplicate check on resource host: ehci-exynos: remove duplicate check on resource [...] WBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
