Re: common code for CDC drivers
On Fri, 2015-06-26 at 22:40 +0300, Tal Shorer wrote: It won't break, but this will make me compile something I don't need and may not want. Wouldn't it make more sense to put this unified code in a new file (maybe drivers/usb/class/cdc.c) and have all related drivers depend on that instead of on usbnet? The less code that is compiled but never runs, the happier I am. It would suck in the common modular case. Each modules needs at least a full page. Sorry Oliver -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: common code for CDC drivers
On Fri, Jun 26, 2015 at 07:47:47PM +0300, Tal Shorer wrote: As someone who has cdc-acm enabled and usbnet disabled on my project, I'd rather you don't break my configuration : configurations will not break, they will be updated to pull in usbnet if needed. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: common code for CDC drivers
As someone who has cdc-acm enabled and usbnet disabled on my project, I'd rather you don't break my configuration : On Fri, Jun 26, 2015 at 4:40 PM, Oliver Neukum oneu...@suse.com wrote: Hi, I am looking at all the CDC drivers. They all have a parser for the extra CDC headers. If I unify this would it be acceptable for cdc-acm to depend on usbnet? Or should I put the code into a header? Regards Oliver -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: common code for CDC drivers
On June 26, 2015 3:40:18 PM CEST, Oliver Neukum oneu...@suse.com wrote: Hi, I am looking at all the CDC drivers. They all have a parser for the extra CDC headers. If I unify this would it be acceptable for cdc-acm to depend on usbnet? Or should I put the code into a header? I don't have any strong feelings. Either way is fine. And thanks for doing this. I've often thought about it, but always been too lazy to actually do anything about it. I believe cdc-wdm also has one of these parsers and should be unified. Bjørn -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: common code for CDC drivers
It won't break, but this will make me compile something I don't need and may not want. Wouldn't it make more sense to put this unified code in a new file (maybe drivers/usb/class/cdc.c) and have all related drivers depend on that instead of on usbnet? The less code that is compiled but never runs, the happier I am. On Fri, Jun 26, 2015 at 7:59 PM, Greg KH g...@kroah.com wrote: On Fri, Jun 26, 2015 at 07:47:47PM +0300, Tal Shorer wrote: As someone who has cdc-acm enabled and usbnet disabled on my project, I'd rather you don't break my configuration : configurations will not break, they will be updated to pull in usbnet if needed. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-usb in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
