Re: [EXT] Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump
Ganapathi Bhat writes: > Hi Kalle, > >> Arend van Spriel writes: >> >> > On 5/23/2018 9:54 AM, Kalle Valo wrote: >> >> Ganapathi Bhat writes: >> >> >> >>> In V2: >> >>> >> >>> return ret; >> >>> } >> >>> +EXPORT_SYMBOL_GPL(mwifiex_send_cmd); >> >>> >> >>> Instead of exporting 'mwifiex_send_cmd' we can prepare a wrapper for >> >>> the command 'MWIFIEX_IFACE_WORK_DEVICE_DUMP' in mwifiex >> module. Let >> >>> me know if we can send a follow up. >> >> >> >> So what's the plan? Can I apply this patch or should I drop it? >> > >> > Sorry. Had to reply that earlier. When adding the export I figured it >> > might not be desirable. If Ganapathi can fix it with a follow up patch >> > that would ok, right? >> >> A follow up patch sounds good to me. > > Sorry for confusions. I assume you will be margining the original > patch and want me to send the follow-up right? Correct. I applied Arend's patch now so you can send your follow-up patch. -- Kalle Valo
RE: [EXT] Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump
Hi Kalle, > Arend van Spriel writes: > > > On 5/23/2018 9:54 AM, Kalle Valo wrote: > >> Ganapathi Bhat writes: > >> > >>> In V2: > >>> > >>> return ret; > >>> } > >>> +EXPORT_SYMBOL_GPL(mwifiex_send_cmd); > >>> > >>> Instead of exporting 'mwifiex_send_cmd' we can prepare a wrapper for > >>> the command 'MWIFIEX_IFACE_WORK_DEVICE_DUMP' in mwifiex > module. Let > >>> me know if we can send a follow up. > >> > >> So what's the plan? Can I apply this patch or should I drop it? > > > > Sorry. Had to reply that earlier. When adding the export I figured it > > might not be desirable. If Ganapathi can fix it with a follow up patch > > that would ok, right? > > A follow up patch sounds good to me. Sorry for confusions. I assume you will be margining the original patch and want me to send the follow-up right? > Regards, Ganapathi
Re: [EXT] Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump
Arend van Spriel writes: > On 5/23/2018 9:54 AM, Kalle Valo wrote: >> Ganapathi Bhat writes: >> >>> In V2: >>> >>> return ret; >>> } >>> +EXPORT_SYMBOL_GPL(mwifiex_send_cmd); >>> >>> Instead of exporting 'mwifiex_send_cmd' we can prepare a wrapper for >>> the command 'MWIFIEX_IFACE_WORK_DEVICE_DUMP' in mwifiex module. Let me >>> know if we can send a follow up. >> >> So what's the plan? Can I apply this patch or should I drop it? > > Sorry. Had to reply that earlier. When adding the export I figured it > might not be desirable. If Ganapathi can fix it with a follow up patch > that would ok, right? A follow up patch sounds good to me. > Than you can apply it, I would say. Good, thanks. -- Kalle Valo
Re: [EXT] Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump
On 5/23/2018 9:54 AM, Kalle Valo wrote: Ganapathi Bhat writes: In V2: return ret; } +EXPORT_SYMBOL_GPL(mwifiex_send_cmd); Instead of exporting 'mwifiex_send_cmd' we can prepare a wrapper for the command 'MWIFIEX_IFACE_WORK_DEVICE_DUMP' in mwifiex module. Let me know if we can send a follow up. So what's the plan? Can I apply this patch or should I drop it? Sorry. Had to reply that earlier. When adding the export I figured it might not be desirable. If Ganapathi can fix it with a follow up patch that would ok, right? Than you can apply it, I would say. Regards, Arend
Re: [EXT] Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump
Ganapathi Bhat writes: > In V2: > > return ret; > } > +EXPORT_SYMBOL_GPL(mwifiex_send_cmd); > > Instead of exporting 'mwifiex_send_cmd' we can prepare a wrapper for > the command 'MWIFIEX_IFACE_WORK_DEVICE_DUMP' in mwifiex module. Let me > know if we can send a follow up. So what's the plan? Can I apply this patch or should I drop it? -- Kalle Valo
RE: [EXT] Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump
Hi arend.vanspriel,
>
> --
> On 5/16/2018 3:50 PM, Kalle Valo wrote:
> > Arend van Spriel writes:
> >
> >> Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops")
> >> it is possible to initiate a device coredump from user-space. This
> >> patch adds support for it adding the .coredump() driver callback.
> >> As there is no longer a need to initiate it through debugfs remove
> >> that code.
> >>
> >> Signed-off-by: Arend van Spriel
> >> ---
> >> V2:
> >>- export mwifiex_send_cmd() needed by mwifiex_usb.ko.
> >> ---
> >> drivers/net/wireless/marvell/mwifiex/cmdevt.c | 1 +
> >> drivers/net/wireless/marvell/mwifiex/debugfs.c | 31
> >> +--
> ---
> >> drivers/net/wireless/marvell/mwifiex/pcie.c| 18 +--
> >> drivers/net/wireless/marvell/mwifiex/sdio.c| 12 ++
> >> drivers/net/wireless/marvell/mwifiex/usb.c | 13 +++
> >> 5 files changed, 43 insertions(+), 32 deletions(-)
> >
> > You forgot to CC mwifiex maintainers, doing it now. Full patch here:
> >
> > https://patchwork.kernel.org/patch/10403717/
>
> Thanks, Kalle
>
> You would almost think I am not used to submit patches for drivers I do not
> actively maintain ;-)
>
> Gr. AvS
In V2:
return ret;
}
+EXPORT_SYMBOL_GPL(mwifiex_send_cmd);
Instead of exporting 'mwifiex_send_cmd' we can prepare a wrapper for the
command 'MWIFIEX_IFACE_WORK_DEVICE_DUMP' in mwifiex module. Let me know if we
can send a follow up.
Thanks,
Ganapathi
Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump
On 5/16/2018 3:50 PM, Kalle Valo wrote:
Arend van Spriel writes:
Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops")
it is possible to initiate a device coredump from user-space. This
patch adds support for it adding the .coredump() driver callback.
As there is no longer a need to initiate it through debugfs remove
that code.
Signed-off-by: Arend van Spriel
---
V2:
- export mwifiex_send_cmd() needed by mwifiex_usb.ko.
---
drivers/net/wireless/marvell/mwifiex/cmdevt.c | 1 +
drivers/net/wireless/marvell/mwifiex/debugfs.c | 31 +-
drivers/net/wireless/marvell/mwifiex/pcie.c| 18 +--
drivers/net/wireless/marvell/mwifiex/sdio.c| 12 ++
drivers/net/wireless/marvell/mwifiex/usb.c | 13 +++
5 files changed, 43 insertions(+), 32 deletions(-)
You forgot to CC mwifiex maintainers, doing it now. Full patch here:
https://patchwork.kernel.org/patch/10403717/
Thanks, Kalle
You would almost think I am not used to submit patches for drivers I do
not actively maintain ;-)
Gr. AvS
Re: [PATCH V2 3/6] mwifiex: support sysfs initiated device coredump
Arend van Spriel writes:
> Since commit 3c47d19ff4dc ("drivers: base: add coredump driver ops")
> it is possible to initiate a device coredump from user-space. This
> patch adds support for it adding the .coredump() driver callback.
> As there is no longer a need to initiate it through debugfs remove
> that code.
>
> Signed-off-by: Arend van Spriel
> ---
> V2:
> - export mwifiex_send_cmd() needed by mwifiex_usb.ko.
> ---
> drivers/net/wireless/marvell/mwifiex/cmdevt.c | 1 +
> drivers/net/wireless/marvell/mwifiex/debugfs.c | 31
> +-
> drivers/net/wireless/marvell/mwifiex/pcie.c| 18 +--
> drivers/net/wireless/marvell/mwifiex/sdio.c| 12 ++
> drivers/net/wireless/marvell/mwifiex/usb.c | 13 +++
> 5 files changed, 43 insertions(+), 32 deletions(-)
You forgot to CC mwifiex maintainers, doing it now. Full patch here:
https://patchwork.kernel.org/patch/10403717/
--
Kalle Valo
