Re: linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874: bad test ?

2015-07-07 Thread Randy Dunlap 
On 07/07/15 04:19, David Binderman wrote:
 Hello there,
 
 [linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874]: (style) A pointer 
 can not be negative so it is either pointless or an error to check if it is.
 
 Source code is
 
  if (wilc_mac_thread  0) {
 
 but
 
 struct task_struct *wilc_mac_thread;


#include linux/err.h


if (IS_ERR(wilc_mac_thread)) {


-- 
~Randy
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874: bad test ?

2015-07-07 Thread David Binderman 
Hello there,

[linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874]: (style) A pointer 
can not be negative so it is either pointless or an error to check if it is.

Source code is

 if (wilc_mac_thread  0) {

but

struct task_struct *wilc_mac_thread;

Regards

David Binderman

  --
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874: bad test ?

2015-07-07 Thread Kim, Johnny 
Hello David.

Thanks for your detail review.
The code is wrong and will be removed because of unused code later.

Regards.
Johnny.

-Original Message-
From: David Binderman [mailto:dcb...@hotmail.com] 
Sent: Tuesday, July 07, 2015 8:19 PM
To: Kim, Johnny; Kim, Rachel; Lee, Dean; Park, Chris; 
linux-wireless@vger.kernel.org
Subject: linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874: bad test ?

Hello there,

[linux-4.2-rc1/drivers/staging/wilc1000/linux_wlan.c:1874]: (style) A pointer 
can not be negative so it is either pointless or an error to check if it is.

Source code is

 if (wilc_mac_thread  0) {

but

struct task_struct *wilc_mac_thread;

Regards

David Binderman

  
--
To unsubscribe from this list: send the line unsubscribe linux-wireless in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html