Re: [linux-yocto] [linux-yocto-4.8][PATCH] mm/workingset.c: fix implicit declaration of __list_lru_init_key

[Paul Gortmaker]

[Re: [linux-yocto-4.8][PATCH] mm/workingset.c: fix implicit declaration of 
__list_lru_init_key] On 28/09/2017 (Thu 10:37) Cal Sullivan wrote:

> 
> 
> On 09/28/2017 07:53 AM, Paul Gortmaker wrote:
> >[[linux-yocto-4.8][PATCH] mm/workingset.c: fix implicit declaration of 
> >__list_lru_init_key] On 22/09/2017 (Fri 15:48) California Sullivan wrote:
> >
> >>__list_lru_init_key does not exist. We're looking for __list_lru_init as
> >>shown in the patch "26690f5 mm: workingset: fix premature shadow node
> >I don't have that commit ID in mainline.  I see this:
> That commit ID won't be in mainline - it was a backport patch to 4.8.

OK, in the future, please list the repo your ID reference is in.

> >
> >commit 0cefabdaf757a6455d75f00cb76874e62703ed18
> >Author: Johannes Weiner <han...@cmpxchg.org>
> >Date:   Fri Mar 31 15:11:52 2017 -0700
> >
> > mm: workingset: fix premature shadow node shrinking with cgroups
> >
> >Did you perhaps rebase or similar?  Since the patch below is identical
> >to the commit above, it is more appropriate to preserve the original
> >commit log and authorship, as per how nearly all stable backports are
> >handled.
> The patch isn't  quite identical: __list_lru_init_key vs list_lru_init_key.
> It somehow got mangled in the merge commit 7f56c636.

If I recall correctly this was one of the functions the rt folks put
leading underscores on, since they changed something about it and didn't
want any "old" call sites to leak through un-audited.  THat probably led
to the merge confusion.

P.
--

> 
> ---
> Cal
> 
> >
> >P.
> >--
> >
> >>shrinking with cgroups".
> >>
> >>Signed-off-by: California Sullivan <california.l.sulli...@intel.com>
> >>---
> >>
> >>This is for the standard/preempt-rt/base branch. Standard/base is OK.
> >>
> >>  mm/workingset.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>diff --git a/mm/workingset.c b/mm/workingset.c
> >>index 1856fdb..5e953eb 100644
> >>--- a/mm/workingset.c
> >>+++ b/mm/workingset.c
> >>@@ -493,7 +493,7 @@ static int __init workingset_init(void)
> >>pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
> >>   timestamp_bits, max_order, bucket_order);
> >>-   ret = __list_lru_init_key(&__workingset_shadow_nodes, true, 
> >>_nodes_key);
> >>+   ret = __list_lru_init(&__workingset_shadow_nodes, true, 
> >>_nodes_key);
> >>if (ret)
> >>goto err;
> >>ret = register_shrinker(_shadow_shrinker);
> >>-- 
> >>2.9.5
> >>
> 
-- 
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto

Re: [linux-yocto] [linux-yocto-4.8][PATCH] mm/workingset.c: fix implicit declaration of __list_lru_init_key

[Cal Sullivan]

On 09/28/2017 07:53 AM, Paul Gortmaker wrote:

[[linux-yocto-4.8][PATCH] mm/workingset.c: fix implicit declaration of 
__list_lru_init_key] On 22/09/2017 (Fri 15:48) California Sullivan wrote:


__list_lru_init_key does not exist. We're looking for __list_lru_init as
shown in the patch "26690f5 mm: workingset: fix premature shadow node

I don't have that commit ID in mainline.  I see this:

That commit ID won't be in mainline - it was a backport patch to 4.8.


commit 0cefabdaf757a6455d75f00cb76874e62703ed18
Author: Johannes Weiner <han...@cmpxchg.org>
Date:   Fri Mar 31 15:11:52 2017 -0700

 mm: workingset: fix premature shadow node shrinking with cgroups

Did you perhaps rebase or similar?  Since the patch below is identical
to the commit above, it is more appropriate to preserve the original
commit log and authorship, as per how nearly all stable backports are
handled.

The patch isn't  quite identical: __list_lru_init_key vs list_lru_init_key.
It somehow got mangled in the merge commit 7f56c636.

---
Cal



P.
--


shrinking with cgroups".

Signed-off-by: California Sullivan <california.l.sulli...@intel.com>
---

This is for the standard/preempt-rt/base branch. Standard/base is OK.

  mm/workingset.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/workingset.c b/mm/workingset.c
index 1856fdb..5e953eb 100644
--- a/mm/workingset.c
+++ b/mm/workingset.c
@@ -493,7 +493,7 @@ static int __init workingset_init(void)
pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
   timestamp_bits, max_order, bucket_order);
  
-	ret = __list_lru_init_key(&__workingset_shadow_nodes, true, _nodes_key);

+   ret = __list_lru_init(&__workingset_shadow_nodes, true, 
_nodes_key);
if (ret)
goto err;
ret = register_shrinker(_shadow_shrinker);
--
2.9.5



--
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto

Re: [linux-yocto] [linux-yocto-4.8][PATCH] mm/workingset.c: fix implicit declaration of __list_lru_init_key

[Paul Gortmaker]

[[linux-yocto-4.8][PATCH] mm/workingset.c: fix implicit declaration of 
__list_lru_init_key] On 22/09/2017 (Fri 15:48) California Sullivan wrote:

> __list_lru_init_key does not exist. We're looking for __list_lru_init as
> shown in the patch "26690f5 mm: workingset: fix premature shadow node

I don't have that commit ID in mainline.  I see this:

commit 0cefabdaf757a6455d75f00cb76874e62703ed18
Author: Johannes Weiner <han...@cmpxchg.org>
Date:   Fri Mar 31 15:11:52 2017 -0700

mm: workingset: fix premature shadow node shrinking with cgroups

Did you perhaps rebase or similar?  Since the patch below is identical
to the commit above, it is more appropriate to preserve the original
commit log and authorship, as per how nearly all stable backports are
handled.

P.
--

> shrinking with cgroups".
> 
> Signed-off-by: California Sullivan <california.l.sulli...@intel.com>
> ---
> 
> This is for the standard/preempt-rt/base branch. Standard/base is OK.
> 
>  mm/workingset.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/workingset.c b/mm/workingset.c
> index 1856fdb..5e953eb 100644
> --- a/mm/workingset.c
> +++ b/mm/workingset.c
> @@ -493,7 +493,7 @@ static int __init workingset_init(void)
>   pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
>  timestamp_bits, max_order, bucket_order);
>  
> - ret = __list_lru_init_key(&__workingset_shadow_nodes, true, 
> _nodes_key);
> + ret = __list_lru_init(&__workingset_shadow_nodes, true, 
> _nodes_key);
>   if (ret)
>   goto err;
>   ret = register_shrinker(_shadow_shrinker);
> -- 
> 2.9.5
> 
-- 
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto

Re: [linux-yocto] [linux-yocto-4.8][PATCH] mm/workingset.c: fix implicit declaration of __list_lru_init_key

[Bruce Ashfield]

On 09/22/2017 07:02 PM, akuster808 wrote:

Cal,


On 09/22/2017 03:48 PM, California Sullivan wrote:

__list_lru_init_key does not exist. We're looking for __list_lru_init as
shown in the patch "26690f5 mm: workingset: fix premature shadow node
shrinking with cgroups".

Signed-off-by: California Sullivan 


I believe this fix is already in latest 4.8 preempt-base.

http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-4.8/commit/mm/workingset.c?h=standard/preempt-rt/base=26690f5a8bdf03966c5db20181089f86f8ca8eef


It was like that, but a merge from standard/base has munged it into
the incorrect form .. and since it is a merge commit, git whatchanged
hides the fact a bit.

I've applied this and pushed it to the -rt branches.

Bruce



I am working on updating morty to the latest versions.

- armin


---

This is for the standard/preempt-rt/base branch. Standard/base is OK.

  mm/workingset.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/workingset.c b/mm/workingset.c
index 1856fdb..5e953eb 100644
--- a/mm/workingset.c
+++ b/mm/workingset.c
@@ -493,7 +493,7 @@ static int __init workingset_init(void)
pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
   timestamp_bits, max_order, bucket_order);
  
-	ret = __list_lru_init_key(&__workingset_shadow_nodes, true, _nodes_key);

+   ret = __list_lru_init(&__workingset_shadow_nodes, true, 
_nodes_key);
if (ret)
goto err;
ret = register_shrinker(_shadow_shrinker);





--
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto

Re: [linux-yocto] [linux-yocto-4.8][PATCH] mm/workingset.c: fix implicit declaration of __list_lru_init_key

[akuster808]

Cal,


On 09/22/2017 03:48 PM, California Sullivan wrote:
> __list_lru_init_key does not exist. We're looking for __list_lru_init as
> shown in the patch "26690f5 mm: workingset: fix premature shadow node
> shrinking with cgroups".
>
> Signed-off-by: California Sullivan 

I believe this fix is already in latest 4.8 preempt-base.

http://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-4.8/commit/mm/workingset.c?h=standard/preempt-rt/base=26690f5a8bdf03966c5db20181089f86f8ca8eef

I am working on updating morty to the latest versions.

- armin

> ---
>
> This is for the standard/preempt-rt/base branch. Standard/base is OK.
>
>  mm/workingset.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/workingset.c b/mm/workingset.c
> index 1856fdb..5e953eb 100644
> --- a/mm/workingset.c
> +++ b/mm/workingset.c
> @@ -493,7 +493,7 @@ static int __init workingset_init(void)
>   pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
>  timestamp_bits, max_order, bucket_order);
>  
> - ret = __list_lru_init_key(&__workingset_shadow_nodes, true, 
> _nodes_key);
> + ret = __list_lru_init(&__workingset_shadow_nodes, true, 
> _nodes_key);
>   if (ret)
>   goto err;
>   ret = register_shrinker(_shadow_shrinker);


-- 
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto

[linux-yocto] [linux-yocto-4.8][PATCH] mm/workingset.c: fix implicit declaration of __list_lru_init_key

[California Sullivan]

__list_lru_init_key does not exist. We're looking for __list_lru_init as
shown in the patch "26690f5 mm: workingset: fix premature shadow node
shrinking with cgroups".

Signed-off-by: California Sullivan 
---

This is for the standard/preempt-rt/base branch. Standard/base is OK.

 mm/workingset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/workingset.c b/mm/workingset.c
index 1856fdb..5e953eb 100644
--- a/mm/workingset.c
+++ b/mm/workingset.c
@@ -493,7 +493,7 @@ static int __init workingset_init(void)
pr_info("workingset: timestamp_bits=%d max_order=%d bucket_order=%u\n",
   timestamp_bits, max_order, bucket_order);
 
-   ret = __list_lru_init_key(&__workingset_shadow_nodes, true, 
_nodes_key);
+   ret = __list_lru_init(&__workingset_shadow_nodes, true, 
_nodes_key);
if (ret)
goto err;
ret = register_shrinker(_shadow_shrinker);
-- 
2.9.5

-- 
___
linux-yocto mailing list
linux-yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/linux-yocto