Re: [PATCH V2] dtc: ensure #line directives don't consume data from the next line
From: Stephen Warren swar...@nvidia.com
Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS}
could match line-break characters. If the #line directive did not contain
the optional flags field at the end, this could cause any integer data on
the next line to be consumed as part of the #line directive parsing. This
could cause syntax errors (i.e. #line parsing consuming the leading 0
from a hex literal 0x1234, leaving x1234 to be parsed as cell data,
which is a syntax error), or invalid compilation results (i.e. simply
consuming literal 1234 as part of the #line processing, thus removing it
from the cell data).
Fix this by replacing {WS} with [ \t] so that it can't match line-breaks.
Convert all instances of {WS}, even though the other instances should be
irrelevant for any well-formed #line directive. This is done for
consistency and ultimate safety.
Reported-by: Ian Campbell ian.campb...@citrix.com
Signed-off-by: Stephen Warren swar...@nvidia.com
---
v2: Convert all instances of {WS} in the regex.
Applied.
Thanks!
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: DTB build failure due to preproccessing
Line 374 is the IDSEL 0x16... line here:
interrupt-map =
/* IRQ mapping for pci slots and ALI M1533
...
* management core also isn't used.
*/
/* IDSEL 0x16 / dev=6, bus=0 / PCI slot 3 */
0x3000 0 0 1 xps_intc_0 3 2
0x3000 0 0 2 xps_intc_0 2 2
0x3000 0 0 3 xps_intc_0 5 2
0x3000 0 0 4 xps_intc_0 4 2
Can you show me the original source without mods here, please?
Or is the ... purely elided comments?
Which gets preprocessed into:
interrupt-map =
# 375 arch/powerpc/boot/dts/virtex440-ml510.dts
0x3000 0 0 1 xps_intc_0 3 2
0x3000 0 0 2 xps_intc_0 2 2
0x3000 0 0 3 xps_intc_0 5 2
0x3000 0 0 4 xps_intc_0 4 2
dtc is only able to track line numbers when the native /include/
directive is used. The #include directive doesn't help it. It should be
added, but until it is the following patch solves the problem:
It's supposed to do better than that, I think.
This, from dtc-lexer.l
*^#(line)?{WS}+[0-9]+{WS}+{STRING}({WS}+[0-9]+)? {
char *line, *tmp, *fn;
/* skip text before line # */
line = yytext;
while (!isdigit(*line))
line++;
/* skip digits in line # */
tmp = line;
while (!isspace(*tmp))
tmp++;
/* NULL-terminate line # */
*tmp = '\0';
/* start of filename */
fn = strchr(tmp + 1, '') + 1;
/* strip trailing from filename */
tmp = strchr(fn, '');
*tmp = 0;
/* -1 since #line is the number of the next line */
srcpos_set_line(xstrdup(fn), atoi(line) - 1);
}
Hrm. Is this a that's not in the kernel's copy yet problem?
Or did this fail to match the offending '# line file' somehow?
(Like, is that '# 375' really in column 1?)
Thanks,
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 1/2] dtc: Implement -d option to write out a dependency file
This will allow callers to rebuild .dtb files when any of the /include/d .dtsi files are modified, not just the top-level .dts file. Signed-off-by: Stephen Warren swar...@nvidia.com --- This patch is against the Linux kernel's copy of dtc, but it applies to upstream dtc with a couple of trivial conflicts. I can post a version for upstream dtc as well if desired. If it does go upstream into Linux proper, we should definitely have it in the main DTC repository. So if you would, please send me a path that applies there. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v2] dtc: Remove unused variable in flat_read_mem_reserve
On Tue, Jun 28, 2011 at 09:47:11AM -0400, Josh Boyer wrote: The *p variable is declared and used to save inb-ptr, however p is later never used. This has been the case since commit 6c0f3676 and can lead to build failures with -Werror=unused-but-set-variable: flattree.c: In function 'flat_read_mem_reserve': flattree.c:700:14: error: variable 'p' set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors make: *** [flattree.o] Error 1 Remove the variable. Signed-off-by: Josh Boyer jwbo...@linux.vnet.ibm.com Acked-by: David Gibson da...@gibson.dropbear.id.au Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] dtc: Remove unused check variable
On Tue, Jun 28, 2011 at 08:47:09AM -0400, Josh Boyer wrote: Commit 376ab6f2 removed the old style check functionality from DTC, however the check option and variable were not removed. This leads to build failures when -Werror=unused-but-set-variable is specified: dtc.c: In function 'main': dtc.c:102:17: error: variable 'check' set but not used [-Werror=unused-but-set-variable] cc1: all warnings being treated as errors make: *** [dtc.o] Error 1 make: *** Waiting for unfinished jobs Remove the check variable. Signed-off-by: Josh Boyer jwbo...@linux.vnet.ibm.com Acked-by: David Gibson da...@gibson.dropbear.id.au Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] Globally s/struct irq_host/struct irq_domain/
For this to make sense, it really needs to also rename irq_host_ops structure, the IRQ_HOST_MAP* #defines, and the irq_*_host functions. It also /should/ adjust the users of irq_domain to rename function local variables and structure members. Otherwise there will be an even worse mismatch in naming. Happy to do so, but last time we talked about this, we decided not to do *that* aspect of the rename with this patch, and that we'd get to it later with follow on patches once this step was done. Your call; just let me know. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH] Globally s/struct irq_host/struct irq_domain/
I always reserve the right to change my mind. }:- Naturally! Sorry about that, No problem. The thought back then was that we'd hit the global piece and then we'd buy the time to hit the local pieces as we could. but I actually applied the patch this morning with the thought that I'd get Linus to pick it up late to avoid collisions in linux-next. Makes sense. However, when I actually looked at the result I realized that at the very least, the irq_host_ops, the #defines, and the irq_*_host functions absolutely have to be renamed at the same time. Not necessarily in the same patch, but definitely at the same time. Will do! jdl ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 1/5] scripts: dtc: Merge in changes from the dtc repository
On Tue, Nov 16, 2010 at 12:49:51PM -0800, John Bonesio wrote: Pull in recent changes from the main dtc repository. These changes primarily allow multiple device trees to be declared which are merged by dtc. This feature allows us to include a basic dts file and then provide more informatio n for the specific system through the merging functionality. Signed-off-by: John Bonesio bo...@secretlab.ca Jon David, I'll need your input on whether or not this is the best way to handle updating the dtc copy in the kernel tree. g. Grant, Yeah, I wondered too. :-) David added it and updated in the kernel last round, so he may have some good notion of what would be best there. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH 1/5] scripts: dtc: Merge in changes from the dtc repository
Hmm, is there some documentation for how to use this feature? Specifically I have a custom board with multiple discrete computers on it which are only very slightly physically different from each other and I'd like to be able to avoid maintaining 2 nearly-exact copies of the same DTS file. Heh. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: DTC sources move
On Fri, Mar 27, 2009 at 8:16 AM, Michal Simek mon...@monstr.eu wrote: Hi Ben, could you please move DTC to any generic location. I would like to use it f or Microblaze cpu too. Michal, David Gibson is the one responsible for the in-tree dtc source, not Ben, and you should prepare the patches yourself to move dtc. And, I might add, please update it from its main repo in the process... jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: Regarding irq_of_parse_and_map
On Thu, 2009-02-19 at 17:21 +0530, Vijay Nikam wrote: Also is it possible to compile device tree on Linux host and genreate dtb for powerpc ? ? ? If yes, then how ? ? ? please let me know ... thanks ... Uh, get a copy of the DTC using: $ git clone git://git.jdl.com/software/dtc.git $ cd dtc $ make HTH, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: Trouble moving custom MPC8548 board to U-boot 1.3
On Tue, 2009-01-06 at 15:28 +0200, Pieter wrote: Hi all, I have spent quite some time trying to move from U-Boot 1.2 to a newer version.. I am stuck at the initialization of the ram. The ram checksum fails and gives me a total memory of 0. (the board has 512MB and work when booting uboot 1.2) can anyone pls. point me in the right direction? My console output is as follows: U-Boot 2008.10-00334-g90665e3-dirty-svn1154 (Jan 6 2009 - 13:40:47) CPU: 8548E, Version: 1.1, (0x80390011) Core: E500, Version: 1.0, (0x80210010) Clock Configuration: CPU:990 MHz, CCB:396 MHz, DDR:198 MHz (396 MT/s data rate), LBC:49.500 MHz L1:D-cache 32 kB enabled I-cache 32 kB enabled Board: Equus MPC8548 PCI1: 64 bit, 66 MHz, sync I2C: ready DRAM: Initializing fsl_ddr_sdram starting at step 1 (STEP_GET_SPD) SPD checksum unexpected. Checksum in SPD = 27, computed SPD = 74 DIMM 0: failed This is your root cause: Unable to get the SPD information for the DDR DIMM in slot 0 of controller 0. What part are you using? Does it support SPD? Is your I2C to it hooked up correctly? Can you dump the SPD information that is read? Does it match the part specs? HTH, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: dtc: Use noinput flex option for convert-dtsv0 to remove warning
The convert-dtsv0 lexer doesn't use lex's input() macro/function. This can result in defined but not used warnings. This patch uses flex's noinput option to prevent this warning (as we already do for dtc-lexer.l). Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: Building dtc etc. for packaging
On Wed, 2008-11-12 at 09:39 +1100, David Gibson wrote: Use the tree from jdl.org. Either the git tree if you really need an up-to-date snahpshot, or one of the actual release tarballs. The tree from jdl.com will work better. :-) jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: libfdt: Fix bug in fdt_subnode_offset_namelen()
There's currently an off-by-one bug in fdt_subnode_offset_namelen() which causes it to keep searching after it's finished the subnodes of the given parent, and into the subnodes of siblings of the original node which come after it in the tree. This patch fixes the bug. It also extends the subnode_offset testcase (updating all of the 'test_tree1' example trees in the process) to catch it. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [RFC 0/6] Proposal for a Generic PWM Device API
On Fri, 2008-10-10 at 09:04 -0500, Bill Gatliff wrote: Jon Smirl wrote: What do the device tree deities have to say about PWM support? Dunno. What lists are they on? :) Perhaps [EMAIL PROTECTED] too. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] Install document convert-dtsv0
Patch against http://www.jdl.com/software/dtc.git Signed-off-by: Niklaus Giger [EMAIL PROTECTED] --- Documentation/manual.txt | 20 Makefile |1 + 2 files changed, 21 insertions(+), 0 deletions(-) Applied. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: libfdt: Add function to explicitly expand aliases
Kumar has already added alias expansion to fdt_path_offset(). However, in some circumstances it may be convenient for the user of libfdt to explicitly get the string expansion of an alias. This patch adds a function to do this, fdt_get_alias(), and uses it to implement fdt_path_offset(). Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] Added preliminary support for Netstal HCU4 board
On Thu, 2008-10-02 at 21:08 +0200, Niklaus Giger wrote: convert-dtsv0 is a small utility program which converts (DTS) Device Tree Source from the obsolete version 0 to version 1. Version 1 DTS files are marked by line /dts-v1/; at the top of the file. Add this remark where, though? Add a small chapter IV Utilities in your Documentation/manual.txt. Patches welcome, of course. :-) And if the http://www.jdl.com/git_repos/ would work again, I think the spiders would pick it up from there. I fetched http://www.jdl.com/software/dtc.git through my firewall at work just this morning. What problem are you seeing? Are you unable to clone git://git.jdl.com/software/dtc/git ? jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] Added preliminary support for Netstal HCU4 board
On Thu, 2008-10-02 at 21:51 +0200, Niklaus Giger wrote: git pull worked perfectly. But in Documentation/manual.txt you promise: -- The gitweb interface is: http://www.jdl.com/git_repos/ And this link does not work. Gah. Thanks. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: libfdt: Fix bugs in fdt_get_path()
The current implementation of fdt_get_path() has a couple of bugs, fixed by this patch. First, contrary to its documentation, on success it returns the length of the node's path, rather than 0. The testcase is correspondingly wrong, and the patch fixes this as well. Second, in some circumstances, it will return -FDT_ERR_BADOFFSET instead of -FDT_ERR_NOSPACE when given insufficient buffer space. Specifically this happens when there is insufficient space even to hold the path's second last component. This behaviour is corrected, and the testcase updated to check it. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] [82xx] powerpc: Add support for mpc8247 based board MGCOGE from keymile.
Kumar Gala wrote: arch/powerpc/boot/dts/mgcoge.dts | 174 +++ arch/powerpc/configs/mgcoge_defconfig | 900 + arch/powerpc/platforms/82xx/Kconfig |8 + arch/powerpc/platforms/82xx/Makefile |1 + arch/powerpc/platforms/82xx/mgcoge.c | 129 + 5 files changed, 1212 insertions(+), 0 deletions(-) create mode 100644 arch/powerpc/boot/dts/mgcoge.dts create mode 100644 arch/powerpc/configs/mgcoge_defconfig create mode 100644 arch/powerpc/platforms/82xx/mgcoge.c applied to powerpc-next. - k This is a bit ambiguous. Do you mean your galak next branch? Or the Ben/Paul powerpc next branch? Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 1/2] powerpc: Board support for GE Fanuc SBC610
Martyn Welch wrote:
Support for the SBC610 VPX Single Board Computer from GE Fanuc (PowerPC
MPC8641D).
This is the basic board support for GE Fanuc's SBC610, a 6U single board
computer, based on Freescale's MPC8641D.
Signed-off-by: Martyn Welch [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/gef_sbc610.dts | 268 ++
arch/powerpc/platforms/86xx/Kconfig |9 +
arch/powerpc/platforms/86xx/Makefile |1
arch/powerpc/platforms/86xx/gef_sbc610.c | 187 +
4 files changed, 464 insertions(+), 1 deletions(-)
create mode 100644 arch/powerpc/boot/dts/gef_sbc610.dts
create mode 100644 arch/powerpc/platforms/86xx/gef_sbc610.c
+ [EMAIL PROTECTED] {
No 8641 in this name, please.
Oh, and drop the 32-bit in the CPU sections too.
+ [EMAIL PROTECTED] {
+ device_type = dram-controller;
Hmmm, I suspect that should be dropped.
+ compatible = mpc86xx;
And that changed to indicate some form of controller thing.
Using mpc86xx here is just not right at all.
+
+serial0: [EMAIL PROTECTED] {
+cell-index = 0;
+device_type = serial;
+compatible = ns16550;
+reg = 0x4500 0x0100;
+ clock-frequency = 0;
+interrupts = 0x2a 0x2;
+interrupt-parent = mpic;
+};
+
+serial1: [EMAIL PROTECTED] {
+cell-index = 1;
+device_type = serial;
+compatible = ns16550;
+reg = 0x4600 0x0100;
+ clock-frequency = 0;
+interrupts = 0x1c 0x2;
+interrupt-parent = mpic;
+};
There's some form of indenting issue there...
+ mpic: [EMAIL PROTECTED] {
+ clock-frequency = 0;
+ interrupt-controller;
+ #address-cells = 0;
+ #interrupt-cells = 2;
+ reg = 0x0004 0x0004;
+ built-in;
+ compatible = chrp,open-pic;
+ device_type = open-pic;
+big-endian;
IIRC, we dropped big-endian too. (?)
diff --git a/arch/powerpc/platforms/86xx/gef_sbc610.c
b/arch/powerpc/platforms/86xx/gef_sbc610.c
new file mode 100644
index 000..6b92876
--- /dev/null
+++ b/arch/powerpc/platforms/86xx/gef_sbc610.c
@@ -0,0 +1,187 @@
+
+/*
+ * Based on: mpc86xx_hpcn.c
+ *
+ * MPC86xx HPCN board specific routines
+ *
+ * Recode: ZHANG WEI [EMAIL PROTECTED]
+ * Initial author: Xianghua Xiao [EMAIL PROTECTED]
+ *
+ * Copyright 2006 Freescale Semiconductor Inc.
+ *
+ */
This seems misleading some. Sure, state your attributions
and derivation sources, but this also still looks like it
is stating that it *is* the MPC86xx HPCN board code.
Thanks,
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc: 85xx: add proper OF bus ids for the TQM85xx
Wolfgang Grandegger wrote: Jon Loeliger wrote: H. While you are there, I think you should drop the 8548 part of soc8548 to get just [EMAIL PROTECTED]. Well, right. I'm going to check the tqm8548.dts file more carefully. Looking into 2.6.27-rc3, I realized that these issues have not yet been fixed :-(. I just sent out a patch for 2.6.27 doing so: http://ozlabs.org/pipermail/linuxppc-dev/2008-August/061725.html Thanks! jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH V2] DTC: Remove support for the legacy DTS source file format.
On Thu, Aug 14, 2008 at 7:29 PM, David Gibson [EMAIL PROTECTED] wrote: On Thu, Aug 14, 2008 at 06:02:43PM -0500, Jon Loeliger wrote: Now that all in-kernel-tree DTS files are properly /dts-v1/, remove direct support for the older, un-numbered DTS source file format. Um.. why? I just don't see a compelling reason to remove this backwards compatibility. It costs us very little to keep it around indefinitely. Because we are going to get rid of the cruft, simplify things, and move forward. Really. This was the plan from the onset. I agree, why are we removing backwards compatibility? The dts-v1 format isn't that old, so I'm sure there are plenty of device trees out there, especially on our BSPs, that haven't been updated yet. They can run the conversion tool and be fine. How about just printing a warning and saying that the device tree should be updated with the conversion tool? How about all the in-tree DTS files are already V1? jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v3] libfdt: Add support for using aliases in fdt_path_offset()
If the path doesn't start with '/' check to see if it matches some alias under /aliases and substitute the matching alias value in the path and retry the lookup. Signed-off-by: Kumar Gala [EMAIL PROTECTED] Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 2/2] port ndfc driver to of platform
Arnd Bergmann wrote: Did we ever come to a conclusion on how this could be done, e.g. with preprocessed dts files or simpler dynamic patching of binary device trees? I am working on it. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
[PATCH] DTC: Remove support for the legacy DTS source file format.
Now that all in-kernel-tree DTS files are properly /dts-v1/,
remove direct support for the older, un-numbered DTS
source file format.
Convert existing tests to /dts-v1/ and remove support
for the conversion tests themselves.
For now, though, the conversion tool still exists.
Signed-off-by: Jon Loeliger [EMAIL PROTECTED]
---
dtc-lexer.l | 15 ---
dtc-parser.y | 28
tests/base01.dts | 24 +---
tests/empty.dts |2 ++
tests/escapes.dts |2 ++
tests/label01.dts | 38 --
tests/references_dts0.dts | 12 +++-
tests/run_tests.sh| 27 +--
tests/test01.dts | 38 --
tests/test_tree1_dts0.dts | 18 ++
10 files changed, 75 insertions(+), 129 deletions(-)
diff --git a/dtc-lexer.l b/dtc-lexer.l
index 6f8b7dd..87380be 100644
--- a/dtc-lexer.l
+++ b/dtc-lexer.l
@@ -110,21 +110,6 @@ static int pop_input_file(void);
return DT_LABEL;
}
-INITIAL[bodh]# {
- yylloc.file = srcpos_file;
- yylloc.first_line = yylineno;
- if (*yytext == 'b')
- yylval.cbase = 2;
- else if (*yytext == 'o')
- yylval.cbase = 8;
- else if (*yytext == 'd')
- yylval.cbase = 10;
- else
- yylval.cbase = 16;
- DPRINT(Base: %d\n, yylval.cbase);
- return DT_BASE;
- }
-
INITIAL[0-9a-fA-F]+ {
yylloc.file = srcpos_file;
yylloc.first_line = yylineno;
diff --git a/dtc-parser.y b/dtc-parser.y
index b2ab562..7f2e00a 100644
--- a/dtc-parser.y
+++ b/dtc-parser.y
@@ -67,8 +67,6 @@ static unsigned long long eval_literal(const char *s, int
base, int bits);
%type data propdataprefix
%type re memreserve
%type re memreserves
-%type re v0_memreserve
-%type re v0_memreserves
%type addr addr
%type data celllist
%type cbase cellbase
@@ -90,10 +88,6 @@ sourcefile:
{
the_boot_info = build_boot_info($3, $4, 0);
}
- | v0_memreserves devicetree
- {
- the_boot_info = build_boot_info($1, $2, 0);
- }
;
memreserves:
@@ -114,28 +108,6 @@ memreserve:
}
;
-v0_memreserves:
- /* empty */
- {
- $$ = NULL;
- }
- | v0_memreserve v0_memreserves
- {
- $$ = chain_reserve_entry($1, $2);
- };
- ;
-
-v0_memreserve:
- memreserve
- {
- $$ = $1;
- }
- | label DT_MEMRESERVE addr '-' addr ';'
- {
- $$ = build_reserve_entry($3, $5 - $3 + 1, $1);
- }
- ;
-
addr:
DT_LITERAL
{
diff --git a/tests/base01.dts b/tests/base01.dts
index f84bc49..97a5dd5 100644
--- a/tests/base01.dts
+++ b/tests/base01.dts
@@ -1,3 +1,5 @@
+/dts-v1/;
+
/ {
model = SomeModel;
compatible = Nothing;
@@ -6,26 +8,26 @@
[EMAIL PROTECTED] {
device_type = memory;
- reg = 2000;
+ reg = 0x 0x 0x 0x2000;
};
cpus {
#address-cells = 1;
#size-cells = 0;
- d10 = d# 10; // hex: 0xa
- d23 = d# 23; // hex: 0x17
- b101 = b# 101;// hex: 0x5
- o17 = o# 17; // hex: 0xf
- hd00d = h# d00d; // hex: 0xd00d
+ d10 = 10;// hex: 0xa
+ d23 = 23;// hex: 0x17
+ b101 = 0x5; // hex: 0x5
+ o17 = 017; // hex: 0xf
+ hd00d = 0xd00d; // hex: 0xd00d
// hex: 0x4d20x163e 0x23340xd80
- stuff = d# 1234d# 5678d# 9012d# 3456;
+ stuff = 1234 5678 9012 3456;
- bad-d-1 = d# abc123; // Hrm. 0
- bad-d-2 = d# 123456789012345;
- bad-o-1 = o# 891;
- bad-o-2 = o# 123456123456;
+ bad-d-1 = 0; // Hrm. 0
+ bad-d-2 = 123456789012345;
+ bad-o-1 = 00;
+ bad-o-2 = 0123456123456;
};
};
diff --git a/tests/empty.dts b/tests/empty.dts
index 336d7a2..e160dad 100644
--- a/tests/empty.dts
+++ b/tests/empty.dts
@@ -1,2 +1,4 @@
+/dts-v1/;
+
/ {
};
diff --git a/tests/escapes.dts b
[PATCH V2] DTC: Remove support for the legacy DTS source file format.
Now that all in-kernel-tree DTS files are properly /dts-v1/,
remove direct support for the older, un-numbered DTS
source file format.
Convert existing tests to /dts-v1/ and remove support
for the conversion tests themselves.
For now, though, the conversion tool still exists.
Signed-off-by: Jon Loeliger [EMAIL PROTECTED]
---
Bah. Forgot to eliminate the legacy BASE and
LITERAL tokens in the first version of this patch.
There's still a bit more improvement possible WRT
the initial dts_versio value and lexer state. Later.
dtc-lexer.l | 23 --
dtc-parser.y | 46 -
tests/base01.dts | 24 --
tests/empty.dts |2 +
tests/escapes.dts |2 +
tests/label01.dts | 38 +++-
tests/references_dts0.dts | 12 ++
tests/run_tests.sh| 27 +-
tests/test01.dts | 38 +++-
tests/test_tree1_dts0.dts | 18 +---
10 files changed, 75 insertions(+), 155 deletions(-)
diff --git a/dtc-lexer.l b/dtc-lexer.l
index 6f8b7dd..e12a4ef 100644
--- a/dtc-lexer.l
+++ b/dtc-lexer.l
@@ -110,29 +110,6 @@ static int pop_input_file(void);
return DT_LABEL;
}
-INITIAL[bodh]# {
- yylloc.file = srcpos_file;
- yylloc.first_line = yylineno;
- if (*yytext == 'b')
- yylval.cbase = 2;
- else if (*yytext == 'o')
- yylval.cbase = 8;
- else if (*yytext == 'd')
- yylval.cbase = 10;
- else
- yylval.cbase = 16;
- DPRINT(Base: %d\n, yylval.cbase);
- return DT_BASE;
- }
-
-INITIAL[0-9a-fA-F]+ {
- yylloc.file = srcpos_file;
- yylloc.first_line = yylineno;
- yylval.literal = strdup(yytext);
- DPRINT(Literal: '%s'\n, yylval.literal);
- return DT_LEGACYLITERAL;
- }
-
V1[0-9]+|0[xX][0-9a-fA-F]+ {
yylloc.file = srcpos_file;
yylloc.first_line = yylineno;
diff --git a/dtc-parser.y b/dtc-parser.y
index b2ab562..3762181 100644
--- a/dtc-parser.y
+++ b/dtc-parser.y
@@ -55,7 +55,6 @@ static unsigned long long eval_literal(const char *s, int
base, int bits);
%token DT_MEMRESERVE
%token propnodename DT_PROPNODENAME
%token literal DT_LITERAL
-%token literal DT_LEGACYLITERAL
%token cbase DT_BASE
%token byte DT_BYTE
%token data DT_STRING
@@ -67,11 +66,8 @@ static unsigned long long eval_literal(const char *s, int
base, int bits);
%type data propdataprefix
%type re memreserve
%type re memreserves
-%type re v0_memreserve
-%type re v0_memreserves
%type addr addr
%type data celllist
-%type cbase cellbase
%type cell cellval
%type data bytestring
%type prop propdef
@@ -90,10 +86,6 @@ sourcefile:
{
the_boot_info = build_boot_info($3, $4, 0);
}
- | v0_memreserves devicetree
- {
- the_boot_info = build_boot_info($1, $2, 0);
- }
;
memreserves:
@@ -114,37 +106,11 @@ memreserve:
}
;
-v0_memreserves:
- /* empty */
- {
- $$ = NULL;
- }
- | v0_memreserve v0_memreserves
- {
- $$ = chain_reserve_entry($1, $2);
- };
- ;
-
-v0_memreserve:
- memreserve
- {
- $$ = $1;
- }
- | label DT_MEMRESERVE addr '-' addr ';'
- {
- $$ = build_reserve_entry($3, $5 - $3 + 1, $1);
- }
- ;
-
addr:
DT_LITERAL
{
$$ = eval_literal($1, 0, 64);
}
- | DT_LEGACYLITERAL
- {
- $$ = eval_literal($1, 16, 64);
- }
;
devicetree:
@@ -269,23 +235,11 @@ celllist:
}
;
-cellbase:
- /* empty */
- {
- $$ = 16;
- }
- | DT_BASE
- ;
-
cellval:
DT_LITERAL
{
$$ = eval_literal($1, 0, 32);
}
- | cellbase DT_LEGACYLITERAL
- {
- $$ = eval_literal($2, $1, 32);
- }
;
bytestring:
diff --git a/tests/base01.dts b/tests/base01.dts
index f84bc49..97a5dd5 100644
--- a/tests/base01.dts
+++ b/tests/base01.dts
@@ -1,3 +1,5 @@
+/dts-v1/;
+
/ {
model = SomeModel
Re: dtc: Make many functions 'static'
This patch marks various functions not shared between c files 'static', as they should be. There are a couple of functions in dtc, and many in the testsuite. This is *almost* enough to enable the -Wmissing-prototypes warning. It's not quite enough, because there's a mess of junk in the flex generated code which triggers that warning which I'm not yet sure how to deal with. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: libfdt: Implement fdt_get_property_namelen() and fdt_getprop_namelen()
As well as fdt_subnode_offset(), libfdt includes an fdt_subnode_offset_namelen() function that takes the subnode name to look up not as a NUL-terminated string, but as a string with an explicit length. This can be useful when the caller has the name as part of a longer string, such as a full path. However, we don't have corresponding 'namelen' versions for fdt_get_property() and fdt_getprop(). There are less obvious use cases for these variants on property names, but there are circumstances where they can be useful e.g. looking up property names which need to be parsed from a longer string buffer such as user input or a configuration file, or looking up an alias in a path with IEEE1275 style aliases. So, since it's very easy to implement such variants, this patch does so. The original NUL-terminated variants are, of course, implemented in terms of the namelen versions. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: libfdt: Forgot one function when cleaning the namespace
In commit b6d80a20fc293f3b995c3ce1a6744a5574192125, we renamed all libfdt functions to be prefixed with fdt_ or _fdt_ to minimise the chance of collisions with things from whatever package libfdt is embedded in, pulled into the libfdt build via that environment's libfdt_env.h. Except... I missed one. This patch applies the same treatment to _stringlist_contains(). While we're at it, also make it static since it's only used in the same file. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: dtc: Remove unused lexer function
dtc does not use the input() function in flex. Apparently on some gcc versions the unused function will cause warnings. Therefore, this patch removes the function by using the 'noinput' option to flex. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] dtc: give advance warning that -S is going away.
The -S option allowed the specification of a minimum size for the blob, however the main reason for caring about the size is so there is enough padding to add a chosen node by u-boot or whoever. In which case, folks don't really care about the absolute size, but rather the size of the padding added for this -- which is what the -p option does. Having the -S just confuses people. Signed-off-by: Paul Gortmaker [EMAIL PROTECTED] Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] dtc: give advance warning that -S is going away.
The -S option allowed the specification of a minimum size for the blob, however the main reason for caring about the size is so there is enough padding to add a chosen node by u-boot or whoever. In which case, folks don't really care about the absolute size, but rather the size of the padding added for this -- which is what the -p option does. Having the -S just confuses people. Signed-off-by: Paul Gortmaker [EMAIL PROTECTED] You rock. + if (minsize) + fprintf(stderr, DTC: Use of \-S\ is deprecated; it will be r emoved soon, use \-p\ instead\n); + Or use a U-boot that handles re-sizing automatically. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] powerpc: 85xx: add proper OF bus ids for the TQM85xx
Wolfgang Grandegger wrote:
Ah, I see. For the TQM8548 adding the following compatible line:
[EMAIL PROTECTED] {
...
compatible = fsl,mpc8548-immr, simple-bus;
H. While you are there, I think you should drop
the 8548 part of soc8548 to get just [EMAIL PROTECTED].
Thanks,
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
DTC v1.2.0 Released
Folks, I have tagged and released DTC version 1.2.0 on jdl.com. git://git.jdl.com/software/dtc.git Problems with it to me, please! Enjoy, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
[PATCH] libfdt: Fix 'make install' target handling of .h files.
The definition of LIBFDT_INCLUDES was accidentally dropped. Put it back and add srcdir prefix handling for it. Signed-off-by: Jon Loeliger [EMAIL PROTECTED] --- Makefile |4 +++- libfdt/Makefile.libfdt |1 + 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index e871855..0222dc0 100644 --- a/Makefile +++ b/Makefile @@ -55,7 +55,7 @@ install: all $(INSTALL) -d $(DESTDIR)$(LIBDIR) $(INSTALL) -m 644 $(LIBFDT_lib) $(DESTDIR)$(LIBDIR) $(INSTALL) -d $(DESTDIR)$(INCLUDEDIR) - $(INSTALL) -m 644 $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_INCLUDES)) $(DESTDIR)$(INCLUDEDIR) + $(INSTALL) -m 644 $(LIBFDT_include) $(DESTDIR)$(INCLUDEDIR) # # Rules for versioning @@ -140,6 +140,8 @@ endif LIBFDT_objdir = libfdt LIBFDT_srcdir = libfdt LIBFDT_lib = $(LIBFDT_objdir)/libfdt.a +LIBFDT_include = $(addprefix $(LIBFDT_srcdir)/,$(LIBFDT_INCLUDES)) + include $(LIBFDT_srcdir)/Makefile.libfdt .PHONY: libfdt diff --git a/libfdt/Makefile.libfdt b/libfdt/Makefile.libfdt index f4f495b..6c42acf 100644 --- a/libfdt/Makefile.libfdt +++ b/libfdt/Makefile.libfdt @@ -3,5 +3,6 @@ # This is not a complete Makefile of itself. Instead, it is designed to # be easily embeddable into other systems of Makefiles. # +LIBFDT_INCLUDES = fdt.h libfdt.h LIBFDT_SRCS = fdt.c fdt_ro.c fdt_wip.c fdt_sw.c fdt_rw.c fdt_strerror.c LIBFDT_OBJS = $(LIBFDT_SRCS:%.c=%.o) -- 1.5.6.3.439.g1e10 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
DTC: libfdt Install Woes
David, Somewhat recently, the DTC commit 6a6c972cdf9e dtc: Clean up included Makefile fragments removed this line LIBFDT_INCLUDES = fdt.h libfdt.h from the libfdt/Makefile.libfdt. As a result, the standalone make install is onw failing. We could put that line back, or remove the top-level Makefile install target that is trying to use this definition. I'm not sure which direction you want to head here. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: dtc: Testcase for /include/ directive
This patch adds a testcase for the /include/ directive. It assembles a sample dts file with many /include/ directives at a variety of different lexical / grammatical contexts. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: dtc: Address an assortment of portability problems
I've recently worked with a FreeBSD developer, getting dtc and libfdt
working on FreeBSD. This showed up a number of portability problems
in the dtc package which this patch addresses. Changes are as
follows:
- the parent_offset and supernode_atdepth_offset testcases
used the glibc extension functions strchrnul() and strndupa(). Those
are removed, using slightly longer coding with standard C functions
instead.
- some other testcases had a #define _GNU_SOURCE for no
particular reason. This is removed.
- run_tests.sh has bash specific constructs removed, and the
interpreter changed to /bin/sh. This apparently now runs fine on
FreeBSD's /bin/sh, and I've also tested it with both ash and dash.
- convert-dtsv0-lexer.l has some extra #includes added. These
must have been included indirectly with Linux and glibc, but aren't on
FreeBSD.
- the endian handling functions in libfdt_env.h, based on
endian.h and byteswap.h are replaced with some portable open-coded
versions. Unfortunately, these result in fairly crappy code when
compiled, but as far as I can determine there doesn't seem to be any
POSIX, SUS or de facto standard way of determining endianness at
compile time, nor standard names for byteswapping functions.
- some more endian handling, from testdata.h using the
problematic endian.h is simply removed, since it wasn't actually being
used anyway.
Signed-off-by: David Gibson [EMAIL PROTECTED]
This patch didn't apply directly.
The problem appeared to be the mysterious and suspect exit 99
in the middle of the following context. I whacked on the patch
directly by-hand, and managed to get it to apply.
Obligatory Not using git grumble.
Applied after all.
jdl
Index: dtc/tests/run_tests.sh
===
--- dtc.orig/tests/run_tests.sh 2008-06-26 10:40:59.0 +1000
+++ dtc/tests/run_tests.sh2008-06-26 10:43:21.0 +1000
@@ -15,19 +15,19 @@
tot_strange=0
base_run_test() {
-tot_tests=$[tot_tests + 1]
+tot_tests=$((tot_tests + 1))
if VALGRIND=$VALGRIND $@; then
- tot_pass=$[tot_pass + 1]
+ tot_pass=$((tot_pass + 1))
else
ret=$?
if [ $ret == 1 ]; then
- tot_config=$[tot_config + 1]
+ tot_config=$((tot_config + 1))
elif [ $ret == 2 ]; then
- tot_fail=$[tot_fail + 1]
+ tot_fail=$((tot_fail + 1))
elif [ $ret == $VGCODE ]; then
- tot_vg=$[tot_vg + 1]
+ tot_vg=$((tot_vg + 1))
else
- tot_strange=$[tot_strange + 1]
+ tot_strange=$((tot_strange + 1))
fi
exit 99
fi
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: dtc: Clean up lexing of include files
Currently we scan the /include/ directive as two tokens, the
/include/ keyword itself, then the string giving the file name to
include. We use a special scanner state to keep the two linked
together, and use the scanner state stack to keep track of the
original state while we're parsing the two /include/ tokens.
This does mean that we need to enable the 'stack' option in flex,
which results in a not-easily-suppressed warning from the flex
boilerplate code. This is mildly irritating.
However, this two-token scanning of the /include/ directive also has
some extremely strange edge cases, because there are a variety of
tokens recognized in all scanner states, including INCLUDE. For
example the following strange dts file:
/include/ /dts-v1/;
/ {
/* ... */
};
Will be processed successfully with the /include/ being effectively
ignored: the '/dts-v1/' and ';' are recognized even in INCLUDE state,
then the ';' transitions us to PROPNODENAME state, throwing away
INCLUDE, and the previous state is never popped off the stack. Or
for another example this construct:
foo /include/ = somefile.dts
will be parsed as though it were:
foo = /include/ somefile.dts
Again, the '=' is scanned without leaving INCLUDE state, then the next
string triggers the include logic.
And finally, we use a different regexp for the string with the
included filename than the normal string regexpt, which is also
potentially weird.
This patch, therefore, cleans up the lexical handling of the /include/
directive. Instead of the INCLUDE state, we instead scan the whole
include directive, both keyword and filename as a single token. This
does mean a bit more complexity in extracting the filename out of
yytext, but I think it's worth it to avoid the strageness described
above. It also means it's no longer possible to put a comment between
the /include/ and the filename, but I'm really not very worried about
breaking files using such a strange construct.
Applied.
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] libfdt: Improve documentation in libfdt.h
Fix a few typos and mistakes. Signed-off-by: Wolfram Sang [EMAIL PROTECTED] Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: libfdt: Increase namespace-pollution paranoia
My (DTC) plan is to apply the single patch with some include file fixes, and release that. I'll line the slew of patches up for the following release. jdl And that's not at all what happened. One of David's patches (BSD portability) was a superset of the include-file fixes supplied as a point-solution in a different patch. So I applied David's more-general patch. In fact, I applied all of David's outstanding patches and have tagged it v1.2.0-rc2 and pushed it out now. Please let me know if you have other fixes before I make and release a non -rc version. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] mpc7448: add alias list to DTS, clean out old chosen node
Scott Wood wrote: Paul Gortmaker wrote: OK, so does that mean that the cuboot wrapper is explicitly not supported for all the 83xx, 85xx, and 86xx boards? No (except 86xx, which doesn't have cuboot, because it never existed in arch/ppc and thus there's no compatibility to maintain), it just means that chosen was never added to those dts files, and thus cuboot has no console output. Also note that nothing stops the causal kernel booter from _starting_ with an arch/powerpc/boot/dts/ file, adding a node to it, and using _that_. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: libfdt: Increase namespace-pollution paranoia
On a slightly unrelated note, are you planning to sync the in-kernel dtc/libfdt version with the upstream version anytime soon? I know jon put an -rc, not sure if he plans to pick up the slew of patches for the next -rc or the next release, but it would be good to resync the in-kernel version for 2.6.27. - k My (DTC) plan is to apply the single patch with some include file fixes, and release that. I'll line the slew of patches up for the following release. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [RFC] Non-numbered ibm iic driver
Sean MacLennan wrote: P.S. Do I need a signed-off-by for an RFC? Signed-off-by: Sean MacLennan [EMAIL PROTECTED] --- Not usually. Some intentionally leave the S-o-b: off of and RFC specifically to ensure that it stays RFC-ish and doesn't slip into patchness. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 12/60] microblaze_v4: Generic dts file for platforms
[EMAIL PROTECTED] wrote:
From: Michal Simek [EMAIL PROTECTED]
Signed-off-by: Michal Simek [EMAIL PROTECTED]
---
arch/microblaze/platform/generic/system.dts | 300 +++
1 files changed, 300 insertions(+), 0 deletions(-)
create mode 100644 arch/microblaze/platform/generic/system.dts
diff --git a/arch/microblaze/platform/generic/system.dts
b/arch/microblaze/platform/generic/system.dts
new file mode 100644
index 000..724a037
--- /dev/null
+++ b/arch/microblaze/platform/generic/system.dts
@@ -0,0 +1,300 @@
+/*
+ * (C) Copyright 2007-2008 Xilinx, Inc.
+ * (C) Copyright 2007-2008 Michal Simek
+ *
+ * Michal SIMEK [EMAIL PROTECTED]
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ *
+ * CAUTION: This file is automatically generated by libgen.
+ * Version: Xilinx EDK 9.2.02 EDK_Jm_SP2.3
+ * Generate by FDT v1.00.a
+ */
+
+/ {
+ #address-cells = 1;
+ #size-cells = 1;
+ compatible = xlnx,microblaze;
+ model = testing;
+ DDR_SDRAM_32Mx16: [EMAIL PROTECTED] {
+ device_type = memory;
+ reg = 2000 200 ;
+ } ;
+ chosen {
+ bootargs = console=ttyUL0,115200 loglevel=15;
+ linux,stdout-path = /[EMAIL PROTECTED]/[EMAIL PROTECTED];
+ } ;
+ cpus {
+ #address-cells = 1;
+ #cpus = 1;
+ #size-cells = 0;
+ microblaze_0: [EMAIL PROTECTED] {
+ clock-frequency = 2faf080;
This should really be using the /dts-v1/ format now.
Thanks,
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 12/60] microblaze_v4: Generic dts file for platforms
Michal Simek wrote: Ok. Thanks for information Steve. Jon: Only for sure the main difference is only in value handling. Am I right? If yes, it is easy to change. M Right. It is essentially C-like now. And has a declarator at the top with /dts-v1/. Essentially all of the DTS files in arch/powerpc/boot/dts should be V1 now. Lots of examples. Except in Byte Arrays: x = [ CA FE BA BE FE ED D0 0D ]; jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 02/14] powerpc: Allow create_branch() to return errors
Michael Ellerman wrote: Currently create_branch() creates a branch instruction for you, and patches it into the call site. In some circumstances it would be nice to be able to create the instruction and patch it later, and also some code might want to check for errors in the branch creation before doing the patching. A future patch will change create_branch() to check for errors. For callers that don't care, replace create_branch() with patch_branch(), which just creates the branch and patches it directly. While we're touching all the callers, change to using unsigned int *, as this seems to match usage better. That allows (and requires) us to remove the volatile in the definition of vector in powermac/smp.c and mpc86xx_smp.c, that's correct because now that we're passing vector as an unsigned int * the compiler knows that it's value might change across the patch_branch() call. Signed-off-by: Michael Ellerman [EMAIL PROTECTED] --- 86xx bits... Acked-by: Jon Loeliger [EMAIL PROTECTED] ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
DTC 1.2.0-rc1 Tagged
Folks, I've pushed out a freshly tagged DTC 1.2.0-rc1 to jdl.com. Please feel free to test it! Thanks, jdl David Gibson (34): libfdt: Add and use a node iteration helper function. libfdt: Fix NOP handling bug in fdt_add_subnode_namelen() dtc: Fold comment handling test into testsuite libfdt: More tests of NOP handling behaviour libfdt: Trivial cleanup for CHECK_HEADER) libfdt: Remove no longer used code from fdt_node_offset_by_compatible() dtc: Fix error reporting in push_input_file() dtc: Implement checks for the format of node and property names dtc: Fix indentation of fixup_phandle_references dtc: Strip redundant name properties dtc: Test and fix conversion to/from old dtb versions dtc: Use for_each_marker_of_type in asm_emit_data() dtc: Make -I dtb mode use fill_fullpaths() dtc: Make eval_literal() static dtc: Assorted improvements to test harness dtc: Testcases for input handling dtc: Make dtc_open_file() die() if unable to open requested file dtc: Remove ugly include stack abuse dtc: Abolish asize field of struct data dtc: Add some documentation for the dts formta dtc: Cleanup \nnn and \xNN string escape handling dtc: Change exit code for usage message dtc: Simplify error handling for unparseable input dtc: Clean up included Makefile fragments dtc: Trivial formatting fixes dtc: Make dt_from_blob() open its own input file, like the other input formats dtc: Rework handling of boot_cpuid_phys dtc: Add program to convert dts files from v0 to v1 dtc: Remove reference to dead Makefile variables libfdt: Several cleanups to parameter checking dtc: Remove some small bashisms from test scripts dtc: Fix some printf() format warnings when compiling 64-bit dtc: Add a testcase for 'reg' or 'ranges' in / dtc: Add support for binary includes. Jon Loeliger (1): Tag Version 1.2.0-rc1 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()
Vitaly Bordug wrote: On Wed, 18 Jun 2008 22:45:57 +0400 Matvejchikov Ilya [EMAIL PROTECTED] wrote: I'm glad that you have corrected it. Half a year ago I pointed out that there was such a mistake: http://patchwork.ozlabs.org/linuxppc/patch?id=10700 You've used -embedded ML, and patch wasn't noticed... *sigh* We should merge the -embedded list into -dev and retire the -embedded list finally. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: Question regarding mpic_assign_isu() in storcenter.c
Eric Witcher wrote: The answer is that mpic_assign_isu(mpic, 1, paddr + 0x11000) places the initial base register for isu 1 on a reserved location in the PIC register map (see *). I guess you can infer from this that no badness occurs when you write to a reserved location on the PIC. See? See Kumar? Didn't you tell me that would come back to haunt us juuust like you said... :-) jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: 4xx support in arch/ppc is going away Real Soon Now
Grant Likely writes: Oh, and we're going try to create the longest acked-by chain in Linux history. Cool :) Paul. So far, I think it looks like this, sorted: Acked-by: Arnd Bergmann [EMAIL PROTECTED] Acked-by: Becky Bruce [EMAIL PROTECTED] Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] Acked-by: Grant Likely [EMAIL PROTECTED] Acked-by: Jochen Friedrich [EMAIL PROTECTED] Acked-by: Jon Loeliger [EMAIL PROTECTED] Acked-by: Josh Boyer [EMAIL PROTECTED] Acked-by: Kumar Gala [EMAIL PROTECTED] Acked-by: Olof Johansson [EMAIL PROTECTED] Acked-by: Peter Korsgaard [EMAIL PROTECTED] Acked-by: Scott Wood [EMAIL PROTECTED] Acked-by: Sean MacLennan [EMAIL PROTECTED] Acked-by: Segher Boessenkool [EMAIL PROTECTED] Acked-by: Stefan Roese [EMAIL PROTECTED] Acked-by: Stephen Neuendorffer [EMAIL PROTECTED] Acked-by: Wolfgang Denk [EMAIL PROTECTED] I'm not sure, but I _think_ there are a few other PowerPC developers out there still... :-) jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: Default flats for running dtc from kernel build
On Fri, 2008-06-06 at 09:51 -0500, Kumar Gala wrote: I will. But wouldn't it make sense to allow at least for some level of compatibility with older versions of U-Boot? Adding these options as default would probably not hurt? Agreed. I didn't realize we could actually do this from the kernel build system. I'm sure others will have their two cents to add. But something like: diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile index c40fb82..52db85a 100644 --- a/arch/powerpc/boot/Makefile +++ b/arch/powerpc/boot/Makefile @@ -29,6 +29,8 @@ ifdef CONFIG_DEBUG_INFO BOOTCFLAGS += -g endif +DTS_FLAGS ?= -R4 -S 0x3000 + ifeq ($(call cc-option-yn, -fstack-protector),y) BOOTCFLAGS += -fno-stack-protector endif Hrm. Should we use -p extra_space instead of -S total_space? Seems someone added this DTC commit last November: commit 2b7dc8dce549ad72ad437b254bf756d7ba4c2a5a Author: Kumar Gala [EMAIL PROTECTED] Date: Wed Nov 28 10:21:12 2007 -0600 Add an option to pad the blob that is generated There are times when we need extra space in the blob and just want to have it added on w/o know the exact size to make it. The padding and min size options are mutually exclusive. Signed-off-by: Kumar Gala [EMAIL PROTECTED] A thought, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: arch/ppc is going away Real Soon Now
On Fri, 2008-06-06 at 13:19 +0200, Wolfgang Denk wrote: In message [EMAIL PROTECTED] Becky Bruce wrote: On Jun 5, 2008, at 3:30 PM, Scott Wood wrote: Olof Johansson wrote: On Jun 5, 2008, at 3:12 PM, Arnd Bergmann wrote: On Thursday 05 June 2008, Stephen Neuendorffer wrote: Grant Likely [EMAIL PROTECTED] wrote: Paulus, Can we just kill all of arch/ppc for .27 right now? Acked-by: Josh Boyer [EMAIL PROTECTED] Acked-by: Stephen Neuendorffer [EMAIL PROTECTED] Acked-by: Arnd Bergmann [EMAIL PROTECTED] Acked-by: Olof Johansson [EMAIL PROTECTED] Acked-by: Scott Wood [EMAIL PROTECTED] Acked-by: Becky Bruce [EMAIL PROTECTED] Acked-by: Wolfgang Denk [EMAIL PROTECTED] Acked-by: Jon Loeliger [EMAIL PROTECTED] ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: Default flats for running dtc from kernel build
On Fri, 2008-06-06 at 10:42 -0500, Kumar Gala wrote: So maybe: DTS_FLAGS ?= -P 0x1000 Lowercase p. 1k seems like more than enough default padding. I would think so. - k jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] Add support for binary includes.
David Gibson wrote: But as I said that can be dealt with in the future without breaking compatibility. Objection withdrawn. And on that note, I officially implore Scott to re-submit his binary include patch! Sorry it's taken this long :(. No problem; no apology needed. [*1*] jdl [*1*] -- Or would this have been better?::-) Darth Vader Voice Apology...accepted. /Darth Vader Voice ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] Add support for binary includes.
On Thu, May 29, 2008 at 09:04:29AM -0500, Jon Loeliger wrote: I believe I am fully caught up at this point. Not quite, this one slipped through the cracks: Rats. dtc: Fix some printf() format warnings when compiling 64-bit Currently, dtc generates a few gcc build warnings if built for a 64-bit target, due to the altered type of uint64_t and size_t. This patch fixes the warnings (without generating new warnings for 32-bit). Signed-off-by: David Gibson [EMAIL PROTECTED] Please use git for your patches. Really. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: dtc: Add a testcase for 'reg' or 'ranges' in /
This patch adds an extra testcase to dtc to ensure that the reg_format and ranges_format checks trigger as they should if a 'reg' or 'ranges' property appears in the root node. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: dtc: Remove reference to dead Makefile variables
Previous cleanups have removed the LIBFDT_CLEANFILES and DTC_CLEANFILES variables from the Makefiles. However, they're still referenced by the Makefile. This patch gets rid of these last vestiges. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: libfdt: Seval cleanups to parameter checking (v3)
Subject: Re: libfdt: Seval cleanups to parameter checking (v3) Please put the (v3) in brackets at the begining of the Subject:. This patch makes a couple of small cleanups to parameter checking of libfdt functions. - In several functions which take a node offset, we use an idiom involving fdt_next_tag() first to check that we have indeed been given a node offset. This patch adds a helper function _fdt_check_node_offset() to encapsulate this usage of fdt_next_tag(). - In fdt_rw.c in several places we have the expanded version of the RW_CHECK_HEADER() macro for no particular reason. This patch replaces those instances with an invocation of the macro; that's what it's for. - In fdt_sw.c we rename the check_header_sw() function to sw_check_header() to match the analgous function in fdt_rw.c, and we provide an SW_CHECK_HEADER() wrapper macro as RW_CHECK_HEADER() functions in fdt_rw.c Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: dtc: Remove some small bashisms from test scripts
Some of the helper scripts used to run testcases contain some constructs that are bashisms. Or at least which don't work on dash, the minimal shell used as /bin/sh on recent Ubuntu systems. This patch removes these constructs so that the testsuite will pass out of the box on systems where /bin/sh is dash. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] Add support for binary includes.
David Gibson wrote: A while back I sent out a spiel explaining more clearly why I didn't like it, and where I thought we should go with this, but I don't think anyone noticed it at the time. I'll resend. Thanks. I started working towards a version of this I liked, but was sidetracked by a combination of my own other work, and the fact that Jon's been busy meaning there's a rather large lag on merging dtc patches. I believe I am fully caught up at this point. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] Add support for binary includes.
Kumar Gala wrote:
On Feb 25, 2008, at 6:39 PM, David Gibson wrote:
On Wed, Feb 20, 2008 at 01:19:41PM -0600, Scott Wood wrote:
A property's data can be populated with a file's contents
as follows:
node {
prop = /incbin/(path/to/data);
};
A subset of a file can be included by passing start and size parameters.
For example, to include bytes 8 through 23:
node {
prop = /incbin/(path/to/data, 8, 16);
};
As with /include/, non-absolute paths are looked for in the directory
of the source file that includes them.
That issue was resolved, I believe.
Well, while I discuss the syntax with Jon, here's some comments on the
implementation.
have we made any progress on the syntax?
My last suggestions garnered a I like that even less. response,
so as far as I know, we're still waiting for a good proposal here.
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
DTC patches
dtc: Simplify error handling for unparseable input [resend] dtc: Clean up included Makefile fragments [resend] dtc: Trivial formatting fixes [resend] dtc: Make dt_from_blob() open its own input file, like the other input formats [resend] dtc: Rework handling of boot_cpuid_phys [resend] All applied and pushed out. dtc: Rework handling of boot_cpuid_phys [resend] ^ | Please don't do this ---+ This forced an edit of each commit message by hand. If you are going to do this, do this instead: Subject: [resend] dtc: Rework handling of boot_cpuid_phys Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: DTC patches
On Mon, May 19, 2008 at 02:22:31PM -0500, Jon Loeliger wrote: This leaves one outstanding dtc patch from me; the v0 to v1 conversion program. Ah, I wasn't sure if we wanted to include that in the mess or not. There's a theory that says we've converted them all and don't need to do it ever again. :-) jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: dtc: Add program to convert dts files from v0 to v1
This patch adds a new utility program, convert-dtsv0, to the dtc sources. This program will convert dts files from v0 to v1, preserving comments and spacing. It also includes some heuristics to guess an appropriate base to use in the v1 output (so it will use hex for the contents of reg properties and decimal for clock-frequency properties, for example). They're limited and imperfect, but not terrible. The guts of the converter program is a modified version of the lexer from dtc itself. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. For the record, I'd like to eventually retire this program as well as support for /dts-v0/. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: mpc86xx - couple of questions...
Hi, I took the latest tree from linux/kernel/git/galak/powerpc.git (2.6.26-rc2), and the latest dtc from linux/kernel/git/galak/dtc.git. Hmm. galak, good. Or paulus. But the latest DTC is found on jdl.com still. After compiling, I am having couple of questions. 1) Doesn't the latest dtc support /memreserve/ on the top before or after /dts-v1/? /dts-v1/ is first as it sets the framework for the rest of the source file. This used to work fine for previous compiler and this is giving an error now. Can you show us the source and the compiler output? jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] devres: support addresses greater than an unsigned long via dev_ioremap
Kumar Gala wrote: Its a pretty trivial patch and would be nice to go into 2.6.26. I would also consider it a bug fix of shorts for any driver Looked like a bugfix of longs to me... :-) jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: dtc: Trivial formatting fixes
This patch fixes some trivial indentation and brace/bracket style
problems.
@@ -179,9 +179,8 @@
arg = argv[optind];
/* minsize and padsize are mutually exclusive */
- if ((minsize) (padsize)) {
+ if (minsize padsize)
die(Can't set both -p and -S\n);
- }
I do not consider extra braces a problem, and will
not be applying those changes. The other indentation
fixes will be applied, of course.
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
DTC Patch Catch Up
Folks, I've applied the following patches from Gibson, in this order, to the DTC and pushed it out to git.jdl.com: dtc: Fix error reporting in push_input_file() dtc: Implement checks for the format of node and property names dtc: Fix indentation of fixup_phandle_references dtc: Strip redundant name properties dtc: Test and fix conversion to/from old dtb versions dtc: Use for_each_marker_of_type in asm_emit_data() dtc: Make -I dtb mode use fill_fullpaths() dtc: Make eval_literal() static dtc: Assorted improvements to test harness dtc: Testcases for input handling dtc: Make dtc_open_file() die() if unable to open requested file dtc: Remove ugly include stack abuse dtc: Abolish asize field of struct data dtc: Add some documentation for the dts formta dtc: Cleanup \nnn and \xNN string escape handling dtc: Change exit code for usage message Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
DTC and Git and MontaVista
Guys, Sorry to bother everyone, but someone at MontaVista who was trying to get the DTC today needs to update their version of git to be something modern. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] Add support for binary includes.
David Gibson wrote:
node {
prop = /incbin/(path/to/data);
};
node {
prop = /incbin/(path/to/data, 8, 16);
};
I still dislike the syntax, but haven't thought of a better one yet.
There are some issues with the implementation too, but I've been a bit
too busy with ePAPR stuff to review properly.
I'm OK with the syntax, but whatever-ish.
Would these be better?:
prop = /call/(incbin, path/to/data, 17, 23);
prop = /call[incbin]/(path/to/data);
prop = /call incbin/(path/to/data, 12, 12+10);
What is the aspect of the syntax that you don't like?
I think we essentially need to stick in the /.../ realm
to be consistent with the other non-standard names being
used, like /include/.
I can see a generalized form that allows other pre-defined
or user-defined functions to be introduced and called
or used in a similar way:
prop = (22 + /fibonacci/(7)) 1000;
prop = /directoryof/(/path/to/some/file.doc);
interrupt-map = /pci_int_map/(8000, 2, 14);
or whatever. We can paint this bikeshed for a long time
if we need to. Or, we can get down to some serious issue
if there are any. Are there?
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] Add support for binary includes.
So, like, the other day Scott Wood mumbled: Can I ask; what is the intended usage of such a thing? How large would a typical binary blob be? I use it for embedding guest device trees in a hypervisor's device tree. Why wouldn't we instead, say, extend the source sytax to allow a sub-tree or an embedded tree, rather than obscuring an opaque form of that guest device tree? Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: libfdt: More tests of NOP handling behaviour
So, like, the other day David Gibson mumbled: In light of the recently discovered bug with NOP handling, this adds some more testcases for NOP handling. Specifically, it adds a helper program which will add a NOP tag after every existing tag in a dtb, and runs the standard battery of tests over trees mangled in this way. For now, this does not add a NOP at the very beginning of the structure block. This causes problems for libfdt at present, because we assume in many places that the root node's BEGIN_NODE tag is at offset 0. I'm still contemplating what to do about this (with one option being simply to declare such dtbs invalid). Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. BTW, declaring DTBs with BEGIN_NODES not at offset 0 as invalid seems like a fine choice to me. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: libfdt: Remove no longer used code from fdt_node_offset_by_compatible()
So, like, the other day David Gibson mumbled: Since fdt_node_offset_by_compatible() was converted to the new fdt_next_node() iterator, a chunk of initialization code became redundant, but was not removed by oversight. This patch cleans it up. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: libfdt: Trivial cleanup for CHECK_HEADER)
So, like, the other day David Gibson mumbled: Currently the CHECK_HEADER() macro is defined local to fdt_ro.c. However, there are a handful of functions (fdt_move, rw_check_header, fdt_open_into) from other files which could also use it (currently they open-code something more-or-less identical). Therefore, this patch moves CHECK_HEADER() to libfdt_internal.h and uses it in those places. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: dtc: Fold comment handling test into testsuite
So, like, the other day David Gibson mumbled: For ages dtc has included a sample dts, comment-test.dts, for checking various lexical corner cases in comment processing. In fact, it predates the automated testsuite, and has never been integrated into it. This patch addresses this oversight, folding the comment handling test in with the rest of the testsuite. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: libfdt: Fix NOP handling bug in fdt_add_subnode_namelen()
So, like, the other day David Gibson mumbled: fdt_add_subnode_namelen() has a bug if asked to add a subnode to a node which has NOP tags interspersed with its properties. In this case fdt_add_subnode_namelen() will put the new subnode before the first NOP tag, even if there are properties after it, which will result in an invalid blob. This patch fixes the bug, and adds a testcase for it. Signed-off-by: David Gibson [EMAIL PROTECTED] Applied. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] [POWERPC] Fix initial lmb add region with a non-zero base
So, like, the other day Kumar Gala mumbled: If we add to an empty lmb region with a non-zero base we will not coalesce the number of regions done to one. This causes problems on ppc32 for the s/done/down memory region as its assumed to only have one region. We can fix this be easily specially casing the initial add to just replace the dummy region. --- Posting this since Dave's looking a pulling the lmb code out into lib/ and sharing it between powerpc and sparc. Did you want to S-o-b: this patch? Or was this just informational? Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: libfdt: Add and use a node iteration helper function.
So, like, the other day David Gibson mumbled: This patch adds an fdt_next_node() function which can be used to iterate through nodes of the tree while keeping track of depth. This function is used to simplify the iteration code in a lot of other functions, and is also exported for use by library users. Signed-off-by: David Gibson [EMAIL PROTECTED] --- I think we're ready to go with this one. I'm still thinking about suitable for_each_* macros, but in the mean time I'm happy with the exported interface here, and it's a code-reducing patch. Applied. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 1/2] powerpc: publish 85xx soc dts entries as of_device
Dave Jiang wrote:
diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ads.c
b/arch/powerpc/platforms/85xx/mpc85xx_ads.c
index 4e03050..024393c 100644
--- a/arch/powerpc/platforms/85xx/mpc85xx_ads.c
+++ b/arch/powerpc/platforms/85xx/mpc85xx_ads.c
@@ -26,6 +26,8 @@
#include asm/mpic.h
#include mm/mmu_decl.h
#include asm/udbg.h
+#include asm/of_device.h
+#include asm/of_platform.h
Please use linux/of_{device,platform}.h throughout instead.
Thanks.
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: Moving from 2.6.14 (ppc) to 2.6.20 (powerpc): problems with PCI-PCI bridge
Johan Borkhuis wrote: Hello, I was using kernel version 2.6.14 (ppc) on a MVME3100 board (MPC8540 processor). We are planning to move to 2.6.20 (powerpc), but I have some problems with the initialization of a PCI-PCI bridge. Connected to the MVME3100 board is a PCI-PCI bridge (HiNT, PCI6150, 3388:0022). When using the 2.6.14 kernel this bridge is initialized correctly: it is setup as bus-master, memory and IO are configured, and the memory allocation on the PCI-bus is correct. When I use 2.6.20 (powerpc) the device is not configured correctly: bus-master, memory and IO are not set, and the memory space of the bridge on the PCI bus is set to the minimum value (0xf). I can correct these settings by modifying the PCI_COMMAND register to set the bus-master, memory and IO. I change the size of the memory space in pci_32.c, by forcing the size to the required setting in pci_relocate_bridge_resource. But to be honest, I don't like this very much: modifying registers like this should not be needed, so I guess there is something wrong in my configuration or setup. How can I fix this problem in a better way? What could be wrong with my configuration? There has been a fair amount of PCI setup reworking done somewhat recently. (.22 and .23, IIRC, and even .24). It might be best if you can try 2.6.24. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
[PATCH] [POWERPC] Fix storcenter DTS typos, feedback, IRQs.
Cleaned up IRQ layout and removed unsused ISU allocations.
Fixed RTC address typo from /dts-v1/ conversion.
Incorporated list suggestions to use an iomega, vendor prefix,
and to use a node reference rather than a hard path.
Signed-off-by: Jon Loeliger jdl@@jdl.com
---
Kumar,
I tried to use one large, linear IRQ block and shift the
IRQs up to, like, around 129 or so, but it did not work.
This patch definitely works, so I suspect some issue trying
to setup (non-)IRQs between 0x5 and 0x51000 or so. Ick.
In any even, this is defintely a valid bug fix. If you
would, please pick up for 2.6.25.
Thanks,
jdl
arch/powerpc/boot/dts/storcenter.dts| 12 +-
arch/powerpc/platforms/embedded6xx/storcenter.c | 25 --
2 files changed, 11 insertions(+), 26 deletions(-)
diff --git a/arch/powerpc/boot/dts/storcenter.dts
b/arch/powerpc/boot/dts/storcenter.dts
index 2204874..5893816 100644
--- a/arch/powerpc/boot/dts/storcenter.dts
+++ b/arch/powerpc/boot/dts/storcenter.dts
@@ -15,7 +15,7 @@
/ {
model = StorCenter;
- compatible = storcenter;
+ compatible = iomega,storcenter;
#address-cells = 1;
#size-cells = 1;
@@ -62,12 +62,12 @@
#size-cells = 0;
compatible = fsl-i2c;
reg = 0x3000 0x100;
- interrupts = 5 2;
+ interrupts = 17 2;
interrupt-parent = mpic;
[EMAIL PROTECTED] {
compatible = dallas,ds1337;
- reg = 68;
+ reg = 0x68;
};
};
@@ -78,7 +78,7 @@
reg = 0x4500 0x20;
clock-frequency = 97553800; /* Hz */
current-speed = 115200;
- interrupts = 9 2;
+ interrupts = 25 2;
interrupt-parent = mpic;
};
@@ -89,7 +89,7 @@
reg = 0x4600 0x20;
clock-frequency = 97553800; /* Hz */
current-speed = 9600;
- interrupts = 10 2;
+ interrupts = 26 2;
interrupt-parent = mpic;
};
@@ -136,6 +136,6 @@
};
chosen {
- linux,stdout-path = /soc/[EMAIL PROTECTED];
+ linux,stdout-path = serial0;
};
};
diff --git a/arch/powerpc/platforms/embedded6xx/storcenter.c
b/arch/powerpc/platforms/embedded6xx/storcenter.c
index e12e9d2..8864e48 100644
--- a/arch/powerpc/platforms/embedded6xx/storcenter.c
+++ b/arch/powerpc/platforms/embedded6xx/storcenter.c
@@ -132,33 +132,18 @@ static void __init storcenter_init_IRQ(void)
paddr = (phys_addr_t)of_translate_address(dnp, prop);
mpic = mpic_alloc(dnp, paddr, MPIC_PRIMARY | MPIC_WANTS_RESET,
- 4, 32, EPIC );
+ 16, 32, OpenPIC );
of_node_put(dnp);
BUG_ON(mpic == NULL);
- /* PCI IRQs */
/*
-* 2.6.12 patch:
-* openpic_set_sources(0, 5, OpenPIC_Addr + 0x10200);
-* openpic_set_sources(5, 2, OpenPIC_Addr + 0x11120);
-* first_irq, num_irqs, __iomem first_ISR
-* o_ss: i, src: 0, fdf50200
-* o_ss: i, src: 1, fdf50220
-* o_ss: i, src: 2, fdf50240
-* o_ss: i, src: 3, fdf50260
-* o_ss: i, src: 4, fdf50280
-* o_ss: i, src: 5, fdf51120
-* o_ss: i, src: 6, fdf51140
+* 16 Serial Interrupts followed by 16 Internal Interrupts.
+* I2C is the second internal, so it is at 17, 0x11020.
*/
mpic_assign_isu(mpic, 0, paddr + 0x10200);
- mpic_assign_isu(mpic, 1, paddr + 0x10220);
- mpic_assign_isu(mpic, 2, paddr + 0x10240);
- mpic_assign_isu(mpic, 3, paddr + 0x10260);
- mpic_assign_isu(mpic, 4, paddr + 0x10280);
- mpic_assign_isu(mpic, 5, paddr + 0x11120);
- mpic_assign_isu(mpic, 6, paddr + 0x11140);
+ mpic_assign_isu(mpic, 1, paddr + 0x11000);
mpic_init(mpic);
}
@@ -178,7 +163,7 @@ static int __init storcenter_probe(void)
{
unsigned long root = of_get_flat_dt_root();
- return of_flat_dt_is_compatible(root, storcenter);
+ return of_flat_dt_is_compatible(root, iomega,storcenter);
}
define_machine(storcenter){
--
1.5.4.rc4.25.g81cc
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 2/4 v4] POWERPC: Add StorCenter DTS first draft.
So, like, the other day David Gibson mumbled:
+/ {
+ model = StorCenter;
+ compatible = storcenter;
This really needs a vendor prefix.
Hey Grant!
Here's how dumb I am: You were thinking Something's wrong here...
and kept saying Needs a model name!, and I kept saying That _is_
the model name! And finally Dave comes along and with the ever-obvious
Needs a vendor prefix!
I'm like, D'oh!
+ chosen {
+ linux,stdout-path = /soc/[EMAIL PROTECTED];
You can now use a path reference here.
Ah, good point. I'll get around to an update patch!
Thanks!
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file
Zhang Wei wrote:
Signed-off-by: Zhang Wei [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/mpc8641_hpcn.dts | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
index 556a9ca..1a0fce5 100644
--- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
+++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
@@ -499,4 +500,16 @@
0 0010;
};
};
+
+ rapidio0: [EMAIL PROTECTED] {
+ #address-cells = 2;
+ #size-cells = 2;
+ compatible = fsl,rapidio-delta;
+ reg = f80c 2;
+ ranges = 0 0 c000 0 2000;
+ interrupt-parent = mpic;
+ /* err_irq bell_outb_irq bell_inb_irq
+ msg1_tx_irq msg1_rx_irq msg2_tx_irq msg2_rx_irq */
+ interrupts = 30 2 31 2 32 2 35 2 36 2 37 2 38 2;
+ };
};
Have updates to the booting-without-of.txt file for
been made or proposed for the RapidIO node definition?
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file
Zhang Wei wrote:
Signed-off-by: Zhang Wei [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/mpc8641_hpcn.dts | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
index 556a9ca..1a0fce5 100644
--- a/arch/powerpc/boot/dts/mpc8641_hpcn.dts
+++ b/arch/powerpc/boot/dts/mpc8641_hpcn.dts
@@ -25,6 +25,7 @@
serial1 = serial1;
pci0 = pci0;
pci1 = pci1;
+ rapidio0 = rapidio0;
};
cpus {
@@ -499,4 +500,16 @@
0 0010;
};
};
+
+ rapidio0: [EMAIL PROTECTED] {
+ #address-cells = 2;
+ #size-cells = 2;
+ compatible = fsl,rapidio-delta;
+ reg = f80c 2;
+ ranges = 0 0 c000 0 2000;
+ interrupt-parent = mpic;
+ /* err_irq bell_outb_irq bell_inb_irq
+ msg1_tx_irq msg1_rx_irq msg2_tx_irq msg2_rx_irq */
+ interrupts = 30 2 31 2 32 2 35 2 36 2 37 2 38 2;
+ };
};
The 8641 DTS file has been converted to /dts-v1/ format now.
Please rewrite this patch with explicit hex numbers for
addresses, even if 0x0, and decimal for IRQs.
Thanks,
jdl
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 3/4] 82xx: MGCOGE support
Scott Wood wrote: +// Temporary -- will go away once kernel uses ranges for get_immrbase(). +reg = 0xf000 0x00053000; The patch to use ranges for get_immrbase() just went in, so we can drop this now. Most excellent. Time for YARDS -- Yet Another Rounds of DTS Scrubbing. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 3/3] Add device tree compatible aliases to i2c drivers
On Mon, 2008-01-28 at 08:42, Jon Smirl wrote: PowerPC device trees use a different naming convention than the Linux kernel. Provide alias names for i2c drivers in order to allow them to be loaded by device tree name. The OF_ID macro ensures that the aliases are only present in powerpc builds and separated into their own namespace. Signed-off-by: Jon Smirl [EMAIL PROTECTED] --- Hi Jon, Any chance we can have hard 70-ish column limited log messages, please? Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH] [POWERPC] 86xx: Remove unused IRQ defines
So, like, the other day Kumar Gala mumbled: 86xx uses the flat device tree for all its needs so we dont need explicit IRQ info. Its not clear why this code existed since 86xx never existed in arch/ppc. Sorry, my fault. If you Sign-off-by: that patch, a maintainer can apply it! :-) jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [patch 00/11] ps3av/3fb patches for 2.6.25
So, like, the other day Josh Boyer mumbled: There are lots of powerpc sub-trees. Kumar's, Geoff's, mine, Olof's, Grant's, Vitaly's are just the ones I can think of the top of my head. Shouldn't we just ask Paul to sync up more often rather than have Andrew track X number of trees that eventually all merge into Paul's anyway? I think that is an excellent notion. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
[PATCH] POWERPC: Convert StorCenter DTS file to /dts-v1/ format.
Signed-off-by: Jon Loeliger [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/storcenter.dts | 73 +
1 files changed, 38 insertions(+), 35 deletions(-)
diff --git a/arch/powerpc/boot/dts/storcenter.dts
b/arch/powerpc/boot/dts/storcenter.dts
index 6aa1d69..2204874 100644
--- a/arch/powerpc/boot/dts/storcenter.dts
+++ b/arch/powerpc/boot/dts/storcenter.dts
@@ -11,6 +11,8 @@
* warranty of any kind, whether express or implied.
*/
+/dts-v1/;
+
/ {
model = StorCenter;
compatible = storcenter;
@@ -30,19 +32,19 @@
PowerPC,[EMAIL PROTECTED] {
device_type = cpu;
reg = 0;
- clock-frequency = d# 2; /* Hz */
- timebase-frequency = d# 2500; /* Hz */
+ clock-frequency = 2;
+ timebase-frequency = 2500;
bus-frequency = 0;/* from bootwrapper */
- i-cache-line-size = d# 32;/* bytes */
- d-cache-line-size = d# 32;/* bytes */
- i-cache-size = 4000;
- d-cache-size = 4000;
+ i-cache-line-size = 32;
+ d-cache-line-size = 32;
+ i-cache-size = 16384;
+ d-cache-size = 16384;
};
};
memory {
device_type = memory;
- reg = 0400; /* 64MB @ 0x0 */
+ reg = 0x 0x0400; /* 64MB @ 0x0 */
};
[EMAIL PROTECTED] {
@@ -51,15 +53,15 @@
device_type = soc;
compatible = fsl,mpc8241, mpc10x;
store-gathering = 0; /* 0 == off, !0 == on */
- ranges = 0 fc00 10;
- reg = fc00 10;/* EUMB */
+ ranges = 0x0 0xfc00 0x10;
+ reg = 0xfc00 0x10;/* EUMB */
bus-frequency = 0;/* fixed by loader */
[EMAIL PROTECTED] {
#address-cells = 1;
#size-cells = 0;
compatible = fsl-i2c;
- reg = 3000 100;
+ reg = 0x3000 0x100;
interrupts = 5 2;
interrupt-parent = mpic;
@@ -73,9 +75,9 @@
cell-index = 0;
device_type = serial;
compatible = ns16550;
- reg = 4500 20;
- clock-frequency = d# 97553800; /* Hz */
- current-speed = d# 115200;
+ reg = 0x4500 0x20;
+ clock-frequency = 97553800; /* Hz */
+ current-speed = 115200;
interrupts = 9 2;
interrupt-parent = mpic;
};
@@ -84,10 +86,10 @@
cell-index = 1;
device_type = serial;
compatible = ns16550;
- reg = 4600 20;
- clock-frequency = d# 97553800; /* Hz */
- current-speed = d# 9600;
- interrupts = a 2;
+ reg = 0x4600 0x20;
+ clock-frequency = 97553800; /* Hz */
+ current-speed = 9600;
+ interrupts = 10 2;
interrupt-parent = mpic;
};
@@ -96,7 +98,7 @@
device_type = open-pic;
compatible = chrp,open-pic;
interrupt-controller;
- reg = 4 4;
+ reg = 0x4 0x4;
};
};
@@ -107,28 +109,29 @@
#interrupt-cells = 1;
device_type = pci;
compatible = mpc10x-pci;
- reg = fe80 1000;
- ranges = 0100 00 fe00 0 00c0
- 0200 0 8000 8000 0 7000;
- bus-range = 0 ff;
- clock-frequency = d# 97553800; /* Hz */
+ reg = 0xfe80 0x1000;
+ ranges = 0x0100 0x00x0 0xfe00 0x0 0x00c0
+ 0x0200 0x0 0x8000 0x8000 0x0 0x7000;
+ bus-range = 0 0xff;
+ clock-frequency = 97553800;
interrupt-parent = mpic;
- interrupt-map-mask = f800 0 0 7;
+ interrupt-map-mask = 0xf800 0 0 7;
interrupt-map =
/* IDSEL 13 - IDE */
- 6800 0 0 1 mpic 0 1
- 6800 0 0 2 mpic 0 1
- 6800 0 0 3 mpic 0 1
+ 0x6800 0 0 1 mpic 0 1
[PATCH] POWERPC: Convert all 86xx DTS files to /dts-v1/ format.
Also fixed a few minor indent problems as well.
Signed-off-by: Jon Loeliger [EMAIL PROTECTED]
---
arch/powerpc/boot/dts/mpc8610_hpcd.dts | 227 +++---
arch/powerpc/boot/dts/mpc8641_hpcn.dts | 333
2 files changed, 281 insertions(+), 279 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc8610_hpcd.dts
b/arch/powerpc/boot/dts/mpc8610_hpcd.dts
index d98715c..16c947b 100644
--- a/arch/powerpc/boot/dts/mpc8610_hpcd.dts
+++ b/arch/powerpc/boot/dts/mpc8610_hpcd.dts
@@ -8,6 +8,7 @@
* by the Free Software Foundation.
*/
+/dts-v1/;
/ {
model = MPC8610HPCD;
@@ -29,11 +30,11 @@
PowerPC,[EMAIL PROTECTED] {
device_type = cpu;
reg = 0;
- d-cache-line-size = d# 32;// bytes
- i-cache-line-size = d# 32;// bytes
- d-cache-size = 8000; // L1, 32K
- i-cache-size = 8000; // L1, 32K
- timebase-frequency = 0; // 33 MHz, from uboot
+ d-cache-line-size = 32;
+ i-cache-line-size = 32;
+ d-cache-size = 32768; // L1
+ i-cache-size = 32768; // L1
+ timebase-frequency = 0; // From uboot
bus-frequency = 0;// From uboot
clock-frequency = 0; // From uboot
};
@@ -41,7 +42,7 @@
memory {
device_type = memory;
- reg = 2000; // 512M at 0x0
+ reg = 0x 0x2000; // 512M at 0x0
};
[EMAIL PROTECTED] {
@@ -50,8 +51,8 @@
#interrupt-cells = 2;
device_type = soc;
compatible = fsl,mpc8610-immr, simple-bus;
- ranges = 0 e000 0010;
- reg = e000 1000;
+ ranges = 0x0 0xe000 0x0010;
+ reg = 0xe000 0x1000;
bus-frequency = 0;
[EMAIL PROTECTED] {
@@ -59,17 +60,17 @@
#size-cells = 0;
cell-index = 0;
compatible = fsl-i2c;
- reg = 3000 100;
- interrupts = 2b 2;
+ reg = 0x3000 0x100;
+ interrupts = 43 2;
interrupt-parent = mpic;
dfsrr;
-cs4270:[EMAIL PROTECTED] {
+ cs4270:[EMAIL PROTECTED] {
compatible = cirrus,cs4270;
-reg = 4f;
+ reg = 0x4f;
/* MCLK source is a stand-alone oscillator */
- clock-frequency = bb8000;
-};
+ clock-frequency = 12288000;
+ };
};
[EMAIL PROTECTED] {
@@ -77,8 +78,8 @@
#size-cells = 0;
cell-index = 1;
compatible = fsl-i2c;
- reg = 3100 100;
- interrupts = 2b 2;
+ reg = 0x3100 0x100;
+ interrupts = 43 2;
interrupt-parent = mpic;
dfsrr;
};
@@ -87,9 +88,9 @@
cell-index = 0;
device_type = serial;
compatible = ns16550;
- reg = 4500 100;
+ reg = 0x4500 0x100;
clock-frequency = 0;
- interrupts = 2a 2;
+ interrupts = 42 2;
interrupt-parent = mpic;
};
@@ -97,9 +98,9 @@
cell-index = 1;
device_type = serial;
compatible = ns16550;
- reg = 4600 100;
+ reg = 0x4600 0x100;
clock-frequency = 0;
- interrupts = 1c 2;
+ interrupts = 28 2;
interrupt-parent = mpic;
};
@@ -108,7 +109,7 @@
interrupt-controller;
#address-cells = 0;
#interrupt-cells = 2;
- reg = 4 4;
+ reg = 0x4 0x4;
compatible = chrp,open-pic;
device_type = open-pic;
big-endian;
@@ -116,16 +117,16 @@
[EMAIL PROTECTED] {
compatible = fsl,mpc8610-guts;
- reg = e 1000;
+ reg = 0xe
Re: [PATCH 3/4 v4] POWERPC: Add initial iomega StorCenter board port.
Stephen Rothwell wrote: Hi Jon, + +dnp = of_find_node_by_type(NULL, open-pic); +if (dnp == NULL) +return; + +prop = of_get_property(dnp, reg, size); +if (prop == NULL) +return; You need an of_node_put(dnp) before you return. Damn your eyes! Kumar, I'll send you a patch here... jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 3/4 v4] POWERPC: Add initial iomega StorCenter board port.
Kumar Gala wrote: On Jan 23, 2008, at 6:50 PM, Stephen Rothwell wrote: You need an of_node_put(dnp) before you return. Fixed up by your friendly maintainer. Kumar, I meant, I won't be sending you a patch. Thank you! jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
DTC 1.1.0 Release!
Folks, I have tagged and released a DTC 1.1.0. You may find it using git here: git://www.jdl.com/software/dtc A tarball snap-shot is also available here: http://www.jdl.com/software/dtc-1.1.0.tgz Please let me know if there are problems with it! Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH v5 0/5] device_type/compatible cleanups
Heh. `git-format-patch --stdout -5 | diffstat` doesn't work correctly. Once I've already stumbled against this, but obviously forgot. Might try: git diff --stat HEAD~4 or such! Enjoy, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 2/3 v3] Add initial iomega StorCenter board port.
Stephen Rothwell wrote: Hi Jon, On Tue, 22 Jan 2008 16:37:59 -0600 Jon Loeliger [EMAIL PROTECTED] wrote: +++ b/arch/powerpc/platforms/embedded6xx/storcenter.c +extern void _nmask_and_or_msr(unsigned long nmask, unsigned long or_val); This clearly needs to be decalred in some header file. (I know you did not introduce it.) In arch/ppc, it was declared in asm/system.h (but I don't know if that is appropriate for arch/powerpc). Maybe you could do a preceeding patch that does this and fixes the other user. I hear my Janitorial Karmic Duty calling. +static void __init storcenter_init_IRQ(void) +prop = of_get_property(dnp, reg, size); +paddr = (phys_addr_t)of_translate_address(dnp, prop); What happens of prop is NULL? Someone should fix that case too. :-) Kumar, I'll respin this trio for you. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
Re: [PATCH 2/3] Convert PowerPC MPC i2c to of_platform_driver from platform_driver
So, like, the other day Jon Smirl mumbled: Convert MPC i2c driver from a platform_driver to a of_platform_driver. Add the ability to dynamically load i2c drivers based on device tree names. Routine names were changed from fsl_ to mpc_ to make them match the file name. Common code moved to powerpc-common.* Orginal ppc driver left intact for deletion when ppc arch is removed. This seems backwards to me. I was under the impression that our trend was _toward_ Freescale and fsl names...? And aren't the drivers also already using fsl-i2c in the DTS files as called out in the b-w-o.txt too? Grumble long lines not hard-limited to 70-ish columns, yes, even in log messages... :-) jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
