Re: [PATCH v3] mpc5200: support for the MAN mpc5200 based board mucmc52
Hello Wolfram, Wolfram Sang wrote: > On Wed, Oct 07, 2009 at 08:40:37AM +0200, Heiko Schocher wrote: >> - serial Console on PSC1 >> - 64MB SDRAM >> - MTD CFI Flash >> - Ethernet FEC >> - IDE support >> >> Signed-off-by: Heiko Schocher > > Sorry for finding things incrementally, but I think there is still one issue > left. Once this is sorted out, you could add my: No problem, thanks for finding it! > Reviewed-by: Wolfram Sang OK, added, send patches soon. thanks bye Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v3] mpc5200: support for the MAN mpc5200 based board mucmc52
On Wed, Oct 7, 2009 at 3:49 AM, Wolfram Sang wrote:
> On Wed, Oct 07, 2009 at 08:40:37AM +0200, Heiko Schocher wrote:
>> - serial Console on PSC1
>> - 64MB SDRAM
>> - MTD CFI Flash
>> - Ethernet FEC
>> - IDE support
>>
>> Signed-off-by: Heiko Schocher
>
> Sorry for finding things incrementally, but I think there is still one issue
> left. Once this is sorted out, you could add my:
>
> Reviewed-by: Wolfram Sang
>
[...]
>> + soc5...@f000 {
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + compatible = "fsl,mpc5200-immr",
>> + "fsl,mpc5200b-immr";
>
> You should decide on the latter one only here.
Besides, the order is wrong. The exact version (mpc5200b) always
appears before the list of backward compatible values (the non-'b'
version). But Wolfram is right. The IMMR node of the mpc5200b is
*not* wholly backwards compatible with fsl,mpc5200-immr, so
'fsl,mpc5200-immr' should not be in the list. fsl,mpc5200- only
appears in the child nodes when the specific device truly is backwards
compatible. Compare your .dts file line-for-line with one of the
in-tree mpc5200b .dts files.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: [PATCH v3] mpc5200: support for the MAN mpc5200 based board mucmc52
On Wed, Oct 07, 2009 at 08:40:37AM +0200, Heiko Schocher wrote:
> - serial Console on PSC1
> - 64MB SDRAM
> - MTD CFI Flash
> - Ethernet FEC
> - IDE support
>
> Signed-off-by: Heiko Schocher
Sorry for finding things incrementally, but I think there is still one issue
left. Once this is sorted out, you could add my:
Reviewed-by: Wolfram Sang
> ---
>
> - based on:
> git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
>
> - checked with:
> $ ./scripts/checkpatch.pl
> 0002-mpc5200-support-for-the-MAN-mpc5200-based-board-muc.patch
> total: 0 errors, 0 warnings, 361 lines checked
>
> 0002-mpc5200-support-for-the-MAN-mpc5200-based-board-muc.patch has no obvious
> style problems and is ready for submission.
> $
>
> changes since v1:
>
> - add comments from Grant Likely
> use mpc5200_defconfig as default configuration, therefore added
> SIMPLE_GPIO support in it, because this is not selectable as a
> module.
> - add comments from Wolfram Sang
> - rebase against current next
>
> changes since v2:
> - add comment from Wolfram Sang
> remove unofficial binding
>
> arch/powerpc/boot/dts/mucmc52.dts| 346
> ++
> arch/powerpc/configs/mpc5200_defconfig |2 +-
> arch/powerpc/platforms/52xx/mpc5200_simple.c |1 +
> 3 files changed, 348 insertions(+), 1 deletions(-)
> create mode 100644 arch/powerpc/boot/dts/mucmc52.dts
>
> diff --git a/arch/powerpc/boot/dts/mucmc52.dts
> b/arch/powerpc/boot/dts/mucmc52.dts
> new file mode 100644
> index 000..3924811
> --- /dev/null
> +++ b/arch/powerpc/boot/dts/mucmc52.dts
> @@ -0,0 +1,346 @@
> +/*
> + * mucmc52 board Device Tree Source
> + *
> + * Copyright (C) 2009 DENX Software Engineering GmbH
> + * Heiko Schocher
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2 of the License, or (at your
> + * option) any later version.
> + */
> +
> +/dts-v1/;
> +
> +/ {
> + model = "manroland,mucmc52";
> + compatible = "manroland,mucmc52";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + interrupt-parent = <&mpc5200_pic>;
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + PowerPC,5...@0 {
> + device_type = "cpu";
> + reg = <0>;
> + d-cache-line-size = <32>;
> + i-cache-line-size = <32>;
> + d-cache-size = <0x4000>;// L1, 16K
> + i-cache-size = <0x4000>;// L1, 16K
> + timebase-frequency = <0>; // from bootloader
> + bus-frequency = <0>;// from bootloader
> + clock-frequency = <0>; // from bootloader
> + };
> + };
> +
> + memory {
> + device_type = "memory";
> + reg = <0x 0x0400>; // 64MB
> + };
> +
> + soc5...@f000 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "fsl,mpc5200-immr",
> + "fsl,mpc5200b-immr";
You should decide on the latter one only here.
> + ranges = <0 0xf000 0xc000>;
> + reg = <0xf000 0x0100>;
> + bus-frequency = <0>;// from bootloader
> + system-frequency = <0>; // from bootloader
> +
> + c...@200 {
> + compatible = "fsl,mpc5200b-cdm","fsl,mpc5200-cdm";
> + reg = <0x200 0x38>;
> + };
> +
> + mpc5200_pic: interrupt-control...@500 {
> + // 5200 interrupts are encoded into two levels;
> + interrupt-controller;
> + #interrupt-cells = <3>;
> + compatible = "fsl,mpc5200b-pic","fsl,mpc5200-pic";
> + reg = <0x500 0x80>;
> + interrupts = <0 0 3>;
> + };
> +
> + gpt0: ti...@600 { // GPT 0 in GPIO mode
> + compatible = "fsl,mpc5200b-gpt-gpio",
> + "fsl,mpc5200-gpt-gpio";
> + #gpio-cells = <2>;
> + reg = <0x600 0x10>;
> + interrupts = <1 9 0>;
> + gpio-controller;
> + };
> +
> + gpt1: ti...@610 { // GPT 1 in GPIO mode
> + compatible = "fsl,mpc5200b-gpt-gpio",
> + "fsl,mpc5200-gpt-gpio";
> + #gpio-cells = <2>;
> + reg = <0x610 0x10>;
> + interrupts = <1 10 0>;
> + gpio-controller;
> + };
> +
> + gpt2: ti...@620 { // GPT 2 in GPIO mode
> +
[PATCH v3] mpc5200: support for the MAN mpc5200 based board mucmc52
- serial Console on PSC1
- 64MB SDRAM
- MTD CFI Flash
- Ethernet FEC
- IDE support
Signed-off-by: Heiko Schocher
---
- based on:
git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
- checked with:
$ ./scripts/checkpatch.pl
0002-mpc5200-support-for-the-MAN-mpc5200-based-board-muc.patch
total: 0 errors, 0 warnings, 361 lines checked
0002-mpc5200-support-for-the-MAN-mpc5200-based-board-muc.patch has no obvious
style problems and is ready for submission.
$
changes since v1:
- add comments from Grant Likely
use mpc5200_defconfig as default configuration, therefore added
SIMPLE_GPIO support in it, because this is not selectable as a
module.
- add comments from Wolfram Sang
- rebase against current next
changes since v2:
- add comment from Wolfram Sang
remove unofficial binding
arch/powerpc/boot/dts/mucmc52.dts| 346 ++
arch/powerpc/configs/mpc5200_defconfig |2 +-
arch/powerpc/platforms/52xx/mpc5200_simple.c |1 +
3 files changed, 348 insertions(+), 1 deletions(-)
create mode 100644 arch/powerpc/boot/dts/mucmc52.dts
diff --git a/arch/powerpc/boot/dts/mucmc52.dts
b/arch/powerpc/boot/dts/mucmc52.dts
new file mode 100644
index 000..3924811
--- /dev/null
+++ b/arch/powerpc/boot/dts/mucmc52.dts
@@ -0,0 +1,346 @@
+/*
+ * mucmc52 board Device Tree Source
+ *
+ * Copyright (C) 2009 DENX Software Engineering GmbH
+ * Heiko Schocher
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ */
+
+/dts-v1/;
+
+/ {
+ model = "manroland,mucmc52";
+ compatible = "manroland,mucmc52";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ interrupt-parent = <&mpc5200_pic>;
+
+ cpus {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ PowerPC,5...@0 {
+ device_type = "cpu";
+ reg = <0>;
+ d-cache-line-size = <32>;
+ i-cache-line-size = <32>;
+ d-cache-size = <0x4000>;// L1, 16K
+ i-cache-size = <0x4000>;// L1, 16K
+ timebase-frequency = <0>; // from bootloader
+ bus-frequency = <0>;// from bootloader
+ clock-frequency = <0>; // from bootloader
+ };
+ };
+
+ memory {
+ device_type = "memory";
+ reg = <0x 0x0400>; // 64MB
+ };
+
+ soc5...@f000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "fsl,mpc5200-immr",
+ "fsl,mpc5200b-immr";
+ ranges = <0 0xf000 0xc000>;
+ reg = <0xf000 0x0100>;
+ bus-frequency = <0>;// from bootloader
+ system-frequency = <0>; // from bootloader
+
+ c...@200 {
+ compatible = "fsl,mpc5200b-cdm","fsl,mpc5200-cdm";
+ reg = <0x200 0x38>;
+ };
+
+ mpc5200_pic: interrupt-control...@500 {
+ // 5200 interrupts are encoded into two levels;
+ interrupt-controller;
+ #interrupt-cells = <3>;
+ compatible = "fsl,mpc5200b-pic","fsl,mpc5200-pic";
+ reg = <0x500 0x80>;
+ interrupts = <0 0 3>;
+ };
+
+ gpt0: ti...@600 { // GPT 0 in GPIO mode
+ compatible = "fsl,mpc5200b-gpt-gpio",
+ "fsl,mpc5200-gpt-gpio";
+ #gpio-cells = <2>;
+ reg = <0x600 0x10>;
+ interrupts = <1 9 0>;
+ gpio-controller;
+ };
+
+ gpt1: ti...@610 { // GPT 1 in GPIO mode
+ compatible = "fsl,mpc5200b-gpt-gpio",
+ "fsl,mpc5200-gpt-gpio";
+ #gpio-cells = <2>;
+ reg = <0x610 0x10>;
+ interrupts = <1 10 0>;
+ gpio-controller;
+ };
+
+ gpt2: ti...@620 { // GPT 2 in GPIO mode
+ compatible = "fsl,mpc5200b-gpt-gpio",
+ "fsl,mpc5200-gpt-gpio";
+ #gpio-cells = <2>;
+ reg = <0x620 0x10>;
+ interrupts = <1 11 0>;
+ gpio-controller;
+ };
+
+ gpt3: ti...@630 { // GPT 3 in GPIO mode
+ compatible = "fsl,mp
