Re: [patch 09/16] powerpc: Replace old style lock initializer

2009-11-09 Thread Benjamin Herrenschmidt 
On Mon, 2009-11-09 at 16:15 +1100, Stephen Rothwell wrote:
 Hi Thomas,
 
 On Sat, 07 Nov 2009 09:55:44 +1100 Benjamin Herrenschmidt 
 b...@kernel.crashing.org wrote:
 
  On Fri, 2009-11-06 at 22:41 +, Thomas Gleixner wrote:
   plain text document attachment
   (power-replace-old-style-lock-init.patch)
   SPIN_LOCK_UNLOCKED is deprecated. Init the lock array at runtime
   instead.
   
   Signed-off-by: Thomas Gleixner t...@linutronix.de
   Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
   Cc: linuxppc-...@ozlabs.org
   ---
  
  Looks reasonable. But iseries can be a bitch, so we do need to test it
  on monday.
 
 Tested-by: Stephen Rothwell s...@canb.auug.org.au

Thanks Stephen !

Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [patch 09/16] powerpc: Replace old style lock initializer

2009-11-08 Thread Stephen Rothwell 
Hi Thomas,

On Sat, 07 Nov 2009 09:55:44 +1100 Benjamin Herrenschmidt 
b...@kernel.crashing.org wrote:

 On Fri, 2009-11-06 at 22:41 +, Thomas Gleixner wrote:
  plain text document attachment
  (power-replace-old-style-lock-init.patch)
  SPIN_LOCK_UNLOCKED is deprecated. Init the lock array at runtime
  instead.
  
  Signed-off-by: Thomas Gleixner t...@linutronix.de
  Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
  Cc: linuxppc-...@ozlabs.org
  ---
 
 Looks reasonable. But iseries can be a bitch, so we do need to test it
 on monday.

Tested-by: Stephen Rothwell s...@canb.auug.org.au
-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/


pgp4dFj6q57e8.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [patch 09/16] powerpc: Replace old style lock initializer

2009-11-07 Thread Stephen Rothwell 
Hi Ben,

On Sat, 07 Nov 2009 09:55:44 +1100 Benjamin Herrenschmidt 
b...@kernel.crashing.org wrote:

 Looks reasonable. But iseries can be a bitch, so we do need to test it
 on monday.

It should be safe as the spinlocks cannot be access until after the
following ppc_md pointer initialisations are done (and all this happens
before the secondary CPUs are started).

But, you are right that there is nothing like actually testing with
iSeries. :-)

   void __init hpte_init_iSeries(void)
   {
  +   int i;
  +
  +   for (i = 0; i  ARRAY_SIZE(iSeries_hlocks); i++)
  +   spin_lock_init(iSeries_hlocks[i]);
  +
  ppc_md.hpte_invalidate  = iSeries_hpte_invalidate;
  ppc_md.hpte_updatepp= iSeries_hpte_updatepp;
  ppc_md.hpte_updateboltedpp = iSeries_hpte_updateboltedpp;

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/


pgpVgSxDnizhs.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev