RE: Problem with mini-PCI-E slot on P2020RDB

2011-04-15 Thread Kushwaha Prabhakar-B32579
Added Linxppc-dev

 -Original Message-
 From: Aggrwal Poonam-B10812
 Sent: Friday, April 15, 2011 11:47 AM
 To: Felix Radensky
 Cc: Kushwaha Prabhakar-B32579; leon.woestenb...@gmail.com
 Subject: FW: Problem with mini-PCI-E slot on P2020RDB
 
 Hello Felix
 
 We checked with the Board designer, we need the board fixes mentioned in
 Board errata doc on the board for this issue. Sorry for the confusion.
 
 The fixes are not present on RevC, also on some RevDs this fix also may
 be absent.
 
 
 Please let us know in case of any issues.
 
 Regards
 Poonam
 
  -Original Message-
  From: Leon Woestenberg [mailto:leon.woestenb...@gmail.com]
  Sent: Wednesday, April 13, 2011 2:52 PM
  To: Felix Radensky
  Cc: Aggrwal Poonam-B10812; linuxppc-...@ozlabs.org; Gupta
  Maneesh-B18878; Kushwaha Prabhakar-B32579
  Subject: Re: Problem with mini-PCI-E slot on P2020RDB
 
  Felix,
 
  On Tue, Apr 12, 2011 at 6:54 AM, Felix Radensky
  fe...@embedded-sol.com
  wrote:
   On 04/12/2011 07:05 AM, Aggrwal Poonam-B10812 wrote:
   As such there is no hardware fix related to this issue between RevC
   to RevD. The solution was a software patch to resolve the issue
   related to IRQ0.
  
   Are you sure ? Please take a look at Freescale document titled
   P1020E/P2020E RDB System Errata.
   There's errata CE10, IRQ0 held low. It is fixed in Rev D. Vivek
   Mahajan, who looked at the issue back in 2009, estimated that
   problem can be related to missing pull-up on IRQ0.
   This is exactly what is
   fixed in Rev D.
  
 
  That's my understanding as well.
 
  Check if R420 and R423 are populated. These are the required pull-ups.
  On Rev D they are populated. You might be able to add them yourself.
 
  Even if you have an Rev A-C PCB, this fix can already be applied; it
  was on my board! (the bottom of the board mentions the schematic
  revision)
 
  The resistors have a silkscreen designator block called X, the
  resistors are situated to the left and bottom of the silkscreen X.
  IIRC, between the flash and Px020 part.
 
  On the left side of R420 (or R423) I measured the block wave from the
  RTC, which fires the 32kHz interrupt rate on IRQ0. This fixed by the
  u- boot patch.
 
  Regards,
 
  Leon.


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: Problem with mini-PCI-E slot on P2020RDB

2011-04-15 Thread Felix Radensky

Hi Poonam,

Thanks for the confirmation.

Felix.

On 04/15/2011 09:27 AM, Kushwaha Prabhakar-B32579 wrote:

Added Linxppc-dev


-Original Message-
From: Aggrwal Poonam-B10812
Sent: Friday, April 15, 2011 11:47 AM
To: Felix Radensky
Cc: Kushwaha Prabhakar-B32579; leon.woestenb...@gmail.com
Subject: FW: Problem with mini-PCI-E slot on P2020RDB

Hello Felix

We checked with the Board designer, we need the board fixes mentioned in
Board errata doc on the board for this issue. Sorry for the confusion.

The fixes are not present on RevC, also on some RevDs this fix also may
be absent.


Please let us know in case of any issues.

Regards
Poonam


-Original Message-
From: Leon Woestenberg [mailto:leon.woestenb...@gmail.com]
Sent: Wednesday, April 13, 2011 2:52 PM
To: Felix Radensky
Cc: Aggrwal Poonam-B10812; linuxppc-...@ozlabs.org; Gupta
Maneesh-B18878; Kushwaha Prabhakar-B32579
Subject: Re: Problem with mini-PCI-E slot on P2020RDB

Felix,

On Tue, Apr 12, 2011 at 6:54 AM, Felix Radensky
fe...@embedded-sol.com
wrote:

On 04/12/2011 07:05 AM, Aggrwal Poonam-B10812 wrote:

As such there is no hardware fix related to this issue between RevC
to RevD. The solution was a software patch to resolve the issue
related to IRQ0.

Are you sure ? Please take a look at Freescale document titled
P1020E/P2020E RDB System Errata.
There's errata CE10, IRQ0 held low. It is fixed in Rev D. Vivek
Mahajan, who looked at the issue back in 2009, estimated that
problem can be related to missing pull-up on IRQ0.
This is exactly what is
fixed in Rev D.


That's my understanding as well.

Check if R420 and R423 are populated. These are the required pull-ups.
On Rev D they are populated. You might be able to add them yourself.

Even if you have an Rev A-C PCB, this fix can already be applied; it
was on my board! (the bottom of the board mentions the schematic
revision)

The resistors have a silkscreen designator block called X, the
resistors are situated to the left and bottom of the silkscreen X.
IIRC, between the flash and Px020 part.

On the left side of R420 (or R423) I measured the block wave from the
RTC, which fires the 32kHz interrupt rate on IRQ0. This fixed by the
u- boot patch.

Regards,

Leon.



___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: Problem with mini-PCI-E slot on P2020RDB

2011-04-13 Thread Leon Woestenberg
Felix,

On Tue, Apr 12, 2011 at 6:54 AM, Felix Radensky fe...@embedded-sol.com wrote:
 On 04/12/2011 07:05 AM, Aggrwal Poonam-B10812 wrote:
 As such there is no hardware fix related to this issue between RevC to
 RevD. The solution was a software patch to resolve the issue related to
 IRQ0.

 Are you sure ? Please take a look at Freescale document titled
 P1020E/P2020E RDB System Errata.
 There's errata CE10, IRQ0 held low. It is fixed in Rev D. Vivek Mahajan, who
 looked at the issue back
 in 2009, estimated that problem can be related to missing pull-up on IRQ0.
 This is exactly what is
 fixed in Rev D.


That's my understanding as well.

Check if R420 and R423 are populated. These are the required pull-ups.
On Rev D they are populated. You might be able to add them yourself.

Even if you have an Rev A-C PCB, this fix can already be applied; it
was on my board! (the bottom of the board mentions the schematic
revision)

The resistors have a silkscreen designator block called X, the
resistors are situated to the left and bottom of the silkscreen X.
IIRC, between the flash and Px020 part.

On the left side of R420 (or R423) I measured the block wave from the
RTC, which fires the 32kHz interrupt rate on IRQ0. This fixed by the
u-boot patch.

Regards,

Leon.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


RE: Problem with mini-PCI-E slot on P2020RDB

2011-04-12 Thread Kushwaha Prabhakar-B32579
Hi Felix,

 -Original Message-
 From: linuxppc-dev-bounces+priyanka.jain=freescale@lists.ozlabs.org
 [mailto:linuxppc-dev-
 bounces+priyanka.jain=freescale@lists.ozlabs.org] On Behalf Of Felix
 Radensky
 Sent: Tuesday, April 12, 2011 10:24 AM
 To: Aggrwal Poonam-B10812
 Cc: linuxppc-...@ozlabs.org; Gupta Maneesh-B18878; Kushwaha Prabhakar-
 B32579
 Subject: Re: Problem with mini-PCI-E slot on P2020RDB
 
 Hi Poonam
 
 On 04/12/2011 07:05 AM, Aggrwal Poonam-B10812 wrote:
  Hello Felix
 
  Please find some comments inline.
 
  Regards
  Poonam
 
  -Original Message-
  From: Kushwaha Prabhakar-B32579
  Sent: Tuesday, April 12, 2011 9:26 AM
  To: Aggrwal Poonam-B10812
  Subject: FW: Problem with mini-PCI-E slot on P2020RDB
 
 
 
  -Original Message-
  From: Felix Radensky [mailto:fe...@embedded-sol.com]
  Sent: Monday, April 11, 2011 7:16 PM
  To: Kushwaha Prabhakar-B32579
  Cc: Fabian Bertholm; Leon Woestenberg; linuxppc-...@ozlabs.org;
  Mahajan Vivek-B08308; Aggrwal Poonam-B10812; Gupta Maneesh-B18878
  Subject: Re: Problem with mini-PCI-E slot on P2020RDB
 
  Hi Prabhakar,
 
  On 04/11/2011 02:09 PM, Kushwaha Prabhakar-B32579 wrote:
  Hi,
 
  Yes. It wil be applicable for all revisions.
 
  Regards,
  Prabhakar
 
  I'm sure this is applicable to all revisions, but it doesn't
  necessarily makes things work. The problem I've reported back in 2009
  still exists on P2020RDB revC, even if I use the latest u-boot and
  kernel and make device tree changes that you've suggested.
  I've attached the boot log.
  As such there is no hardware fix related to this issue between RevC to
 RevD. The solution was a software patch to resolve the issue related to
 IRQ0.
 
 Are you sure ? Please take a look at Freescale document titled
 P1020E/P2020E RDB System Errata.
 There's errata CE10, IRQ0 held low. It is fixed in Rev D. Vivek Mahajan,
 who looked at the issue back in 2009, estimated that problem can be
 related to missing pull-up on IRQ0. This is exactly what is fixed in Rev
 D.
 

We are looking into it and are in discussion with design team.

We will keep you posted for the same..

--Prabhakar



___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: Problem with mini-PCI-E slot on P2020RDB

2011-04-11 Thread Fabian Bertholm
Hello Kushwaha Prabhakar,

Our impression is that there is the same issue on the P1020/P1011 RDB.
Can you confirm this?

Best Regards,
Fabe


2011/4/8 Kushwaha Prabhakar-B32579 b32...@freescale.com:


 -Original Message-
 From: Leon Woestenberg [mailto:leon.woestenb...@gmail.com]
 Sent: Thursday, April 07, 2011 10:50 PM
 To: linuxppc-...@ozlabs.org
 Cc: Kumar Gala; Mahajan Vivek-B08308; Aggrwal Poonam-B10812; Felix
 Radensky; Kushwaha Prabhakar-B32579
 Subject: Re: Problem with mini-PCI-E slot on P2020RDB

 Hello,

 On Thu, Dec 17, 2009 at 9:28 PM, Felix Radensky fe...@embedded-sol.com
 wrote:
  Kumar Gala wrote:
  On Dec 17, 2009, at 2:59 AM, Mahajan Vivek-B08308 wrote:
  Thanks a lot. If I understand you correctly, the only way I can get
  ath9k driver to work on this board using legacy interrupts is to
  wait for a hardware fix. Right ?
 
  Correct
 
  I'm confused.  What's the issue with IRQ0 on the P2020RDB?  Is it
  used for another purpose?
 
  There's a problem with IRQ0 with respect to mini-PCI-E slot. I have
  Atheros wireless card plugged into it. ath9k wireless driver for this
  card uses legacy PCI-E interrupts, and I get irq 16: nobody cared
  message when driver executes request_irq(). Vivek has come to a
  conclusion that the problem is related to incorrect IRQ0 routing for
  mini-PCI-E slot on P2020RDB.
 

 I would like to understand this issue better, as I seem to be running
 into something similar, and it puts my board design on hold.

 Can someone (from Freescale) explain what happens if a PCI Express end
 point on the mini-PCIe slot raises a legacy interrupt, and where this
 goes wrong?

 From what document or source code file can I conclude that the PCIe
 legacy interrupt is shared with IRQ0?


 I found this:

 P1020E/P2020E RDB System Errata, Last Update: 2/15/2010:
 Problem:IRQ0 held low
 Fix: Add 4.7K pull-up (to 3.3.V) for RTC_INT_N.
 See R420 in Rev D schematic.
 Add 4.7K pull-up (to 3.3.V) for MCU_INT_N.
 See R423 in Rev D schematic.



 Hello Leon,

  Yes you are right, PCIe leagacy interrupt is shared with IRQ0. For Atheros 
 issue.
  Can you please try followings, Meanwhile I will try to dig into it.
   
 http://old.nabble.com/Problem-with-mini-PCI-E-slot-on-P2020RDB-td26802038.html

 Regarding sata_sil24, Please see my e-mail on Linux-ide for correct IDSEL 
 value.
 Please first try IDSEL value mentioned in email on Linux-ide. Then try this 
 URL..

 --Prabhakar

 ___
 Linuxppc-dev mailing list
 Linuxppc-dev@lists.ozlabs.org
 https://lists.ozlabs.org/listinfo/linuxppc-dev

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


RE: Problem with mini-PCI-E slot on P2020RDB

2011-04-11 Thread Kushwaha Prabhakar-B32579
Hi Fabe,

Yes .. P1020/P1011 RDB has same issue as of P2020RDB.

It was because of some missing patches at u-boot and Linux.

U-boot patch : It is already present in open source. Please use latest code base
Linux patch : I am in process of posting in open source. Please make mentioned 
changes of IDSEL.

--Prabhakar

 -Original Message-
 From: Fabian Bertholm [mailto:fabeisag...@googlemail.com]
 Sent: Monday, April 11, 2011 1:53 PM
 To: Kushwaha Prabhakar-B32579
 Cc: Leon Woestenberg; linuxppc-...@ozlabs.org; Mahajan Vivek-B08308;
 Felix Radensky; Aggrwal Poonam-B10812; Gupta Maneesh-B18878
 Subject: Re: Problem with mini-PCI-E slot on P2020RDB
 
 Hello Kushwaha Prabhakar,
 
 Our impression is that there is the same issue on the P1020/P1011 RDB.
 Can you confirm this?
 
 Best Regards,
 Fabe
 
 
 2011/4/8 Kushwaha Prabhakar-B32579 b32...@freescale.com:
 
 
  -Original Message-
  From: Leon Woestenberg [mailto:leon.woestenb...@gmail.com]
  Sent: Thursday, April 07, 2011 10:50 PM
  To: linuxppc-...@ozlabs.org
  Cc: Kumar Gala; Mahajan Vivek-B08308; Aggrwal Poonam-B10812; Felix
  Radensky; Kushwaha Prabhakar-B32579
  Subject: Re: Problem with mini-PCI-E slot on P2020RDB
 
  Hello,
 
  On Thu, Dec 17, 2009 at 9:28 PM, Felix Radensky
  fe...@embedded-sol.com
  wrote:
   Kumar Gala wrote:
   On Dec 17, 2009, at 2:59 AM, Mahajan Vivek-B08308 wrote:
   Thanks a lot. If I understand you correctly, the only way I can
   get ath9k driver to work on this board using legacy interrupts
   is to wait for a hardware fix. Right ?
  
   Correct
  
   I'm confused.  What's the issue with IRQ0 on the P2020RDB?  Is it
   used for another purpose?
  
   There's a problem with IRQ0 with respect to mini-PCI-E slot. I have
   Atheros wireless card plugged into it. ath9k wireless driver for
   this card uses legacy PCI-E interrupts, and I get irq 16: nobody
 cared
   message when driver executes request_irq(). Vivek has come to a
   conclusion that the problem is related to incorrect IRQ0 routing
   for mini-PCI-E slot on P2020RDB.
  
 
  I would like to understand this issue better, as I seem to be running
  into something similar, and it puts my board design on hold.
 
  Can someone (from Freescale) explain what happens if a PCI Express
  end point on the mini-PCIe slot raises a legacy interrupt, and where
  this goes wrong?
 
  From what document or source code file can I conclude that the PCIe
  legacy interrupt is shared with IRQ0?
 
 
  I found this:
 
  P1020E/P2020E RDB System Errata, Last Update: 2/15/2010:
  Problem:IRQ0 held low
  Fix: Add 4.7K pull-up (to 3.3.V) for RTC_INT_N.
  See R420 in Rev D schematic.
  Add 4.7K pull-up (to 3.3.V) for MCU_INT_N.
  See R423 in Rev D schematic.
 
 
 
  Hello Leon,
 
   Yes you are right, PCIe leagacy interrupt is shared with IRQ0. For
 Atheros issue.
   Can you please try followings, Meanwhile I will try to dig into it.
 
  http://old.nabble.com/Problem-with-mini-PCI-E-slot-on-P2020RDB-td26802
  038.html
 
  Regarding sata_sil24, Please see my e-mail on Linux-ide for correct
 IDSEL value.
  Please first try IDSEL value mentioned in email on Linux-ide. Then try
 this URL..
 
  --Prabhakar
 
  ___
  Linuxppc-dev mailing list
  Linuxppc-dev@lists.ozlabs.org
  https://lists.ozlabs.org/listinfo/linuxppc-dev
 


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: Problem with mini-PCI-E slot on P2020RDB

2011-04-11 Thread Felix Radensky

Hi,

Assuming I have all patches in place, will this problem be
resolved on earlier board revisions (before rev D) ?

Felix.

On 04/11/2011 12:06 PM, Kushwaha Prabhakar-B32579 wrote:

Hi Fabe,

Yes .. P1020/P1011 RDB has same issue as of P2020RDB.

It was because of some missing patches at u-boot and Linux.

U-boot patch : It is already present in open source. Please use latest code base
Linux patch : I am in process of posting in open source. Please make mentioned 
changes of IDSEL.

--Prabhakar


-Original Message-
From: Fabian Bertholm [mailto:fabeisag...@googlemail.com]
Sent: Monday, April 11, 2011 1:53 PM
To: Kushwaha Prabhakar-B32579
Cc: Leon Woestenberg; linuxppc-...@ozlabs.org; Mahajan Vivek-B08308;
Felix Radensky; Aggrwal Poonam-B10812; Gupta Maneesh-B18878
Subject: Re: Problem with mini-PCI-E slot on P2020RDB

Hello Kushwaha Prabhakar,

Our impression is that there is the same issue on the P1020/P1011 RDB.
Can you confirm this?

Best Regards,
Fabe


2011/4/8 Kushwaha Prabhakar-B32579b32...@freescale.com:



-Original Message-
From: Leon Woestenberg [mailto:leon.woestenb...@gmail.com]
Sent: Thursday, April 07, 2011 10:50 PM
To: linuxppc-...@ozlabs.org
Cc: Kumar Gala; Mahajan Vivek-B08308; Aggrwal Poonam-B10812; Felix
Radensky; Kushwaha Prabhakar-B32579
Subject: Re: Problem with mini-PCI-E slot on P2020RDB

Hello,

On Thu, Dec 17, 2009 at 9:28 PM, Felix Radensky
fe...@embedded-sol.com
wrote:

Kumar Gala wrote:

On Dec 17, 2009, at 2:59 AM, Mahajan Vivek-B08308 wrote:

Thanks a lot. If I understand you correctly, the only way I can
get ath9k driver to work on this board using legacy interrupts
is to wait for a hardware fix. Right ?


Correct

I'm confused.  What's the issue with IRQ0 on the P2020RDB?  Is it
used for another purpose?

There's a problem with IRQ0 with respect to mini-PCI-E slot. I have
Atheros wireless card plugged into it. ath9k wireless driver for
this card uses legacy PCI-E interrupts, and I get irq 16: nobody

cared

message when driver executes request_irq(). Vivek has come to a
conclusion that the problem is related to incorrect IRQ0 routing
for mini-PCI-E slot on P2020RDB.


I would like to understand this issue better, as I seem to be running
into something similar, and it puts my board design on hold.

Can someone (from Freescale) explain what happens if a PCI Express
end point on the mini-PCIe slot raises a legacy interrupt, and where
this goes wrong?

 From what document or source code file can I conclude that the PCIe
legacy interrupt is shared with IRQ0?


I found this:

P1020E/P2020E RDB System Errata, Last Update: 2/15/2010:
Problem:IRQ0 held low
Fix: Add 4.7K pull-up (to 3.3.V) for RTC_INT_N.
See R420 in Rev D schematic.
Add 4.7K pull-up (to 3.3.V) for MCU_INT_N.
See R423 in Rev D schematic.



Hello Leon,

  Yes you are right, PCIe leagacy interrupt is shared with IRQ0. For

Atheros issue.

  Can you please try followings, Meanwhile I will try to dig into it.

http://old.nabble.com/Problem-with-mini-PCI-E-slot-on-P2020RDB-td26802
038.html

Regarding sata_sil24, Please see my e-mail on Linux-ide for correct

IDSEL value.

Please first try IDSEL value mentioned in email on Linux-ide. Then try

this URL..

--Prabhakar

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev




___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


RE: Problem with mini-PCI-E slot on P2020RDB

2011-04-11 Thread Kushwaha Prabhakar-B32579
Hi,

Yes. It wil be applicable for all revisions. 

Regards,
Prabhakar

 -Original Message-
 From: Felix Radensky [mailto:fe...@embedded-sol.com]
 Sent: Monday, April 11, 2011 2:10 PM
 To: Kushwaha Prabhakar-B32579
 Cc: Fabian Bertholm; Leon Woestenberg; linuxppc-...@ozlabs.org; Mahajan
 Vivek-B08308; Aggrwal Poonam-B10812; Gupta Maneesh-B18878
 Subject: Re: Problem with mini-PCI-E slot on P2020RDB
 
 Hi,
 
 Assuming I have all patches in place, will this problem be resolved on
 earlier board revisions (before rev D) ?
 
 Felix.
 
 On 04/11/2011 12:06 PM, Kushwaha Prabhakar-B32579 wrote:
  Hi Fabe,
 
  Yes .. P1020/P1011 RDB has same issue as of P2020RDB.
 
  It was because of some missing patches at u-boot and Linux.
 
  U-boot patch : It is already present in open source. Please use latest
  code base Linux patch : I am in process of posting in open source.
 Please make mentioned changes of IDSEL.
 
  --Prabhakar
 
  -Original Message-
  From: Fabian Bertholm [mailto:fabeisag...@googlemail.com]
  Sent: Monday, April 11, 2011 1:53 PM
  To: Kushwaha Prabhakar-B32579
  Cc: Leon Woestenberg; linuxppc-...@ozlabs.org; Mahajan Vivek-B08308;
  Felix Radensky; Aggrwal Poonam-B10812; Gupta Maneesh-B18878
  Subject: Re: Problem with mini-PCI-E slot on P2020RDB
 
  Hello Kushwaha Prabhakar,
 
  Our impression is that there is the same issue on the P1020/P1011 RDB.
  Can you confirm this?
 
  Best Regards,
  Fabe
 
 
  2011/4/8 Kushwaha Prabhakar-B32579b32...@freescale.com:
 
  -Original Message-
  From: Leon Woestenberg [mailto:leon.woestenb...@gmail.com]
  Sent: Thursday, April 07, 2011 10:50 PM
  To: linuxppc-...@ozlabs.org
  Cc: Kumar Gala; Mahajan Vivek-B08308; Aggrwal Poonam-B10812; Felix
  Radensky; Kushwaha Prabhakar-B32579
  Subject: Re: Problem with mini-PCI-E slot on P2020RDB
 
  Hello,
 
  On Thu, Dec 17, 2009 at 9:28 PM, Felix Radensky
  fe...@embedded-sol.com
  wrote:
  Kumar Gala wrote:
  On Dec 17, 2009, at 2:59 AM, Mahajan Vivek-B08308 wrote:
  Thanks a lot. If I understand you correctly, the only way I can
  get ath9k driver to work on this board using legacy interrupts
  is to wait for a hardware fix. Right ?
 
  Correct
  I'm confused.  What's the issue with IRQ0 on the P2020RDB?  Is it
  used for another purpose?
  There's a problem with IRQ0 with respect to mini-PCI-E slot. I
  have Atheros wireless card plugged into it. ath9k wireless driver
  for this card uses legacy PCI-E interrupts, and I get irq 16:
  nobody
  cared
  message when driver executes request_irq(). Vivek has come to a
  conclusion that the problem is related to incorrect IRQ0 routing
  for mini-PCI-E slot on P2020RDB.
 
  I would like to understand this issue better, as I seem to be
  running into something similar, and it puts my board design on hold.
 
  Can someone (from Freescale) explain what happens if a PCI Express
  end point on the mini-PCIe slot raises a legacy interrupt, and
  where this goes wrong?
 
   From what document or source code file can I conclude that the
  PCIe legacy interrupt is shared with IRQ0?
 
 
  I found this:
 
  P1020E/P2020E RDB System Errata, Last Update: 2/15/2010:
  Problem:IRQ0 held low
  Fix: Add 4.7K pull-up (to 3.3.V) for RTC_INT_N.
  See R420 in Rev D schematic.
  Add 4.7K pull-up (to 3.3.V) for MCU_INT_N.
  See R423 in Rev D schematic.
 
 
  Hello Leon,
 
Yes you are right, PCIe leagacy interrupt is shared with IRQ0. For
  Atheros issue.
Can you please try followings, Meanwhile I will try to dig into it.
 
  http://old.nabble.com/Problem-with-mini-PCI-E-slot-on-P2020RDB-td268
  02
  038.html
 
  Regarding sata_sil24, Please see my e-mail on Linux-ide for correct
  IDSEL value.
  Please first try IDSEL value mentioned in email on Linux-ide. Then
  try
  this URL..
  --Prabhakar
 
  ___
  Linuxppc-dev mailing list
  Linuxppc-dev@lists.ozlabs.org
  https://lists.ozlabs.org/listinfo/linuxppc-dev
 
 


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: Problem with mini-PCI-E slot on P2020RDB

2011-04-11 Thread Felix Radensky

Hi Prabhakar,

On 04/11/2011 02:09 PM, Kushwaha Prabhakar-B32579 wrote:

Hi,

Yes. It wil be applicable for all revisions.

Regards,
Prabhakar



I'm sure this is applicable to all revisions, but it doesn't necessarily
makes things work. The problem I've reported back in 2009 still
exists on P2020RDB revC, even if I use the latest u-boot and kernel
and make device tree changes that you've suggested.
I've attached the boot log.

On the other hand, on P1020RDB revD with the same kernel, ath9k
driver loads fine and interrupts are arriving. However this only works
with u-boot-2010.12. If I upgrade to  u-boot-2011.03 loading ath9k
hangs the board. I'll report this separately on u-boot mailing list.

I would summarize this problem as follows. P10xx/P20xx RDB boards
prior to revD have hardware flaw. Using mini PCI-E cards that rely on
legacy interrupts is not possible on such boards. The problem was
fixed in board revision D. To use legacy interrupts one has to modify
pci-e nodes in device tree and add interrupt-map-mask and
interrupt-map properties.

Do you agree with this analysis ?

Felix.





-Original Message-
From: Felix Radensky [mailto:fe...@embedded-sol.com]
Sent: Monday, April 11, 2011 2:10 PM
To: Kushwaha Prabhakar-B32579
Cc: Fabian Bertholm; Leon Woestenberg; linuxppc-...@ozlabs.org; Mahajan
Vivek-B08308; Aggrwal Poonam-B10812; Gupta Maneesh-B18878
Subject: Re: Problem with mini-PCI-E slot on P2020RDB

Hi,

Assuming I have all patches in place, will this problem be resolved on
earlier board revisions (before rev D) ?

Felix.

On 04/11/2011 12:06 PM, Kushwaha Prabhakar-B32579 wrote:

Hi Fabe,

Yes .. P1020/P1011 RDB has same issue as of P2020RDB.

It was because of some missing patches at u-boot and Linux.

U-boot patch : It is already present in open source. Please use latest
code base Linux patch : I am in process of posting in open source.

Please make mentioned changes of IDSEL.

--Prabhakar


-Original Message-
From: Fabian Bertholm [mailto:fabeisag...@googlemail.com]
Sent: Monday, April 11, 2011 1:53 PM
To: Kushwaha Prabhakar-B32579
Cc: Leon Woestenberg; linuxppc-...@ozlabs.org; Mahajan Vivek-B08308;
Felix Radensky; Aggrwal Poonam-B10812; Gupta Maneesh-B18878
Subject: Re: Problem with mini-PCI-E slot on P2020RDB

Hello Kushwaha Prabhakar,

Our impression is that there is the same issue on the P1020/P1011 RDB.
Can you confirm this?

Best Regards,
Fabe


2011/4/8 Kushwaha Prabhakar-B32579b32...@freescale.com:

-Original Message-
From: Leon Woestenberg [mailto:leon.woestenb...@gmail.com]
Sent: Thursday, April 07, 2011 10:50 PM
To: linuxppc-...@ozlabs.org
Cc: Kumar Gala; Mahajan Vivek-B08308; Aggrwal Poonam-B10812; Felix
Radensky; Kushwaha Prabhakar-B32579
Subject: Re: Problem with mini-PCI-E slot on P2020RDB

Hello,

On Thu, Dec 17, 2009 at 9:28 PM, Felix Radensky
fe...@embedded-sol.com
wrote:

Kumar Gala wrote:

On Dec 17, 2009, at 2:59 AM, Mahajan Vivek-B08308 wrote:

Thanks a lot. If I understand you correctly, the only way I can
get ath9k driver to work on this board using legacy interrupts
is to wait for a hardware fix. Right ?


Correct

I'm confused.  What's the issue with IRQ0 on the P2020RDB?  Is it
used for another purpose?

There's a problem with IRQ0 with respect to mini-PCI-E slot. I
have Atheros wireless card plugged into it. ath9k wireless driver
for this card uses legacy PCI-E interrupts, and I get irq 16:
nobody

cared

message when driver executes request_irq(). Vivek has come to a
conclusion that the problem is related to incorrect IRQ0 routing
for mini-PCI-E slot on P2020RDB.


I would like to understand this issue better, as I seem to be
running into something similar, and it puts my board design on hold.

Can someone (from Freescale) explain what happens if a PCI Express
end point on the mini-PCIe slot raises a legacy interrupt, and
where this goes wrong?

  From what document or source code file can I conclude that the
PCIe legacy interrupt is shared with IRQ0?


I found this:

P1020E/P2020E RDB System Errata, Last Update: 2/15/2010:
Problem:IRQ0 held low
Fix: Add 4.7K pull-up (to 3.3.V) for RTC_INT_N.
See R420 in Rev D schematic.
Add 4.7K pull-up (to 3.3.V) for MCU_INT_N.
See R423 in Rev D schematic.



Hello Leon,

   Yes you are right, PCIe leagacy interrupt is shared with IRQ0. For

Atheros issue.

   Can you please try followings, Meanwhile I will try to dig into it.

http://old.nabble.com/Problem-with-mini-PCI-E-slot-on-P2020RDB-td268
02
038.html

Regarding sata_sil24, Please see my e-mail on Linux-ide for correct

IDSEL value.

Please first try IDSEL value mentioned in email on Linux-ide. Then
try

this URL..

--Prabhakar

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev



U-Boot 2011.03 (Apr 11 2011 - 13:57:51)

CPU0:  P2020E, Version: 1.0, (0x80ea0010)
Core:  E500, Version: 4.0, (0x80211040)
Clock Configuration:
   CPU0:1200 MHz, CPU1

RE: Problem with mini-PCI-E slot on P2020RDB

2011-04-11 Thread Aggrwal Poonam-B10812
Hello Felix

Please find some comments inline.

Regards
Poonam

 -Original Message-
 From: Kushwaha Prabhakar-B32579
 Sent: Tuesday, April 12, 2011 9:26 AM
 To: Aggrwal Poonam-B10812
 Subject: FW: Problem with mini-PCI-E slot on P2020RDB
 
 
 
 -Original Message-
 From: Felix Radensky [mailto:fe...@embedded-sol.com]
 Sent: Monday, April 11, 2011 7:16 PM
 To: Kushwaha Prabhakar-B32579
 Cc: Fabian Bertholm; Leon Woestenberg; linuxppc-...@ozlabs.org; Mahajan
 Vivek-B08308; Aggrwal Poonam-B10812; Gupta Maneesh-B18878
 Subject: Re: Problem with mini-PCI-E slot on P2020RDB
 
 Hi Prabhakar,
 
 On 04/11/2011 02:09 PM, Kushwaha Prabhakar-B32579 wrote:
  Hi,
 
  Yes. It wil be applicable for all revisions.
 
  Regards,
  Prabhakar
 
 
 I'm sure this is applicable to all revisions, but it doesn't necessarily
 makes things work. The problem I've reported back in 2009 still exists on
 P2020RDB revC, even if I use the latest u-boot and kernel and make device
 tree changes that you've suggested.
 I've attached the boot log.
As such there is no hardware fix related to this issue between RevC to RevD. 
The solution was a software patch to resolve the issue related to IRQ0.
 
 On the other hand, on P1020RDB revD with the same kernel, ath9k driver
 loads fine and interrupts are arriving. However this only works with u-
 boot-2010.12.
May be you can look at 
http://old.nabble.com/Problem-with-mini-PCI-E-slot-on-P2020RDB-td26802038.html

Felix we do not have the atheros driver for 2.6.38 and the issue is only seen 
with Atheros not sata_sil. If possible can you send the driver code if possible 
so that we can try reproducing it.

Regards
Poonam 

 
 
 
 
  -Original Message-
  From: Felix Radensky [mailto:fe...@embedded-sol.com]
  Sent: Monday, April 11, 2011 2:10 PM
  To: Kushwaha Prabhakar-B32579
  Cc: Fabian Bertholm; Leon Woestenberg; linuxppc-...@ozlabs.org;
  Mahajan Vivek-B08308; Aggrwal Poonam-B10812; Gupta Maneesh-B18878
  Subject: Re: Problem with mini-PCI-E slot on P2020RDB
 
  Hi,
 
  Assuming I have all patches in place, will this problem be resolved
  on earlier board revisions (before rev D) ?
 
  Felix.
 
  On 04/11/2011 12:06 PM, Kushwaha Prabhakar-B32579 wrote:
  Hi Fabe,
 
  Yes .. P1020/P1011 RDB has same issue as of P2020RDB.
 
  It was because of some missing patches at u-boot and Linux.
 
  U-boot patch : It is already present in open source. Please use
  latest code base Linux patch : I am in process of posting in open
 source.
  Please make mentioned changes of IDSEL.
  --Prabhakar
 
  -Original Message-
  From: Fabian Bertholm [mailto:fabeisag...@googlemail.com]
  Sent: Monday, April 11, 2011 1:53 PM
  To: Kushwaha Prabhakar-B32579
  Cc: Leon Woestenberg; linuxppc-...@ozlabs.org; Mahajan
  Vivek-B08308; Felix Radensky; Aggrwal Poonam-B10812; Gupta
  Maneesh-B18878
  Subject: Re: Problem with mini-PCI-E slot on P2020RDB
 
  Hello Kushwaha Prabhakar,
 
  Our impression is that there is the same issue on the P1020/P1011
 RDB.
  Can you confirm this?
 
  Best Regards,
  Fabe
 
 
  2011/4/8 Kushwaha Prabhakar-B32579b32...@freescale.com:
  -Original Message-
  From: Leon Woestenberg [mailto:leon.woestenb...@gmail.com]
  Sent: Thursday, April 07, 2011 10:50 PM
  To: linuxppc-...@ozlabs.org
  Cc: Kumar Gala; Mahajan Vivek-B08308; Aggrwal Poonam-B10812;
  Felix Radensky; Kushwaha Prabhakar-B32579
  Subject: Re: Problem with mini-PCI-E slot on P2020RDB
 
  Hello,
 
  On Thu, Dec 17, 2009 at 9:28 PM, Felix Radensky
  fe...@embedded-sol.com
  wrote:
  Kumar Gala wrote:
  On Dec 17, 2009, at 2:59 AM, Mahajan Vivek-B08308 wrote:
  Thanks a lot. If I understand you correctly, the only way I
  can get ath9k driver to work on this board using legacy
  interrupts is to wait for a hardware fix. Right ?
 
  Correct
  I'm confused.  What's the issue with IRQ0 on the P2020RDB?  Is
  it used for another purpose?
  There's a problem with IRQ0 with respect to mini-PCI-E slot. I
  have Atheros wireless card plugged into it. ath9k wireless
  driver for this card uses legacy PCI-E interrupts, and I get irq
 16:
  nobody
  cared
  message when driver executes request_irq(). Vivek has come to a
  conclusion that the problem is related to incorrect IRQ0 routing
  for mini-PCI-E slot on P2020RDB.
 
  I would like to understand this issue better, as I seem to be
  running into something similar, and it puts my board design on
 hold.
 
  Can someone (from Freescale) explain what happens if a PCI
  Express end point on the mini-PCIe slot raises a legacy
  interrupt, and where this goes wrong?
 
From what document or source code file can I conclude that the
  PCIe legacy interrupt is shared with IRQ0?
 
 
  I found this:
 
  P1020E/P2020E RDB System Errata, Last Update: 2/15/2010:
  Problem:IRQ0 held low
  Fix: Add 4.7K pull-up (to 3.3.V) for RTC_INT_N.
  See R420 in Rev D schematic.
  Add 4.7K pull-up (to 3.3.V) for MCU_INT_N.
  See R423 in Rev D schematic.
 
 
  Hello Leon,
 
 Yes you

RE: Problem with mini-PCI-E slot on P2020RDB

2011-04-11 Thread Benjamin Herrenschmidt
On Tue, 2011-04-12 at 04:05 +, Aggrwal Poonam-B10812 wrote:
 May be you can look at
 http://old.nabble.com/Problem-with-mini-PCI-E-slot-on-P2020RDB-td26802038.html
 
 Felix we do not have the atheros driver for 2.6.38 and the issue is
 only seen with Atheros not sata_sil. If possible can you send the
 driver code if possible so that we can try reproducing it.

drivers/net/wireless/ath/* ? :-)

Cheers,
Ben.


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: Problem with mini-PCI-E slot on P2020RDB

2011-04-11 Thread Felix Radensky

Hi,

On 04/12/2011 07:35 AM, Benjamin Herrenschmidt wrote:

On Tue, 2011-04-12 at 04:05 +, Aggrwal Poonam-B10812 wrote:

May be you can look at
http://old.nabble.com/Problem-with-mini-PCI-E-slot-on-P2020RDB-td26802038.html

Felix we do not have the atheros driver for 2.6.38 and the issue is
only seen with Atheros not sata_sil. If possible can you send the
driver code if possible so that we can try reproducing it.

drivers/net/wireless/ath/* ? :-)


Yep.

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: Problem with mini-PCI-E slot on P2020RDB

2011-04-11 Thread Felix Radensky

Hi Poonam

On 04/12/2011 07:05 AM, Aggrwal Poonam-B10812 wrote:

Hello Felix

Please find some comments inline.

Regards
Poonam


-Original Message-
From: Kushwaha Prabhakar-B32579
Sent: Tuesday, April 12, 2011 9:26 AM
To: Aggrwal Poonam-B10812
Subject: FW: Problem with mini-PCI-E slot on P2020RDB



-Original Message-
From: Felix Radensky [mailto:fe...@embedded-sol.com]
Sent: Monday, April 11, 2011 7:16 PM
To: Kushwaha Prabhakar-B32579
Cc: Fabian Bertholm; Leon Woestenberg; linuxppc-...@ozlabs.org; Mahajan
Vivek-B08308; Aggrwal Poonam-B10812; Gupta Maneesh-B18878
Subject: Re: Problem with mini-PCI-E slot on P2020RDB

Hi Prabhakar,

On 04/11/2011 02:09 PM, Kushwaha Prabhakar-B32579 wrote:

Hi,

Yes. It wil be applicable for all revisions.

Regards,
Prabhakar


I'm sure this is applicable to all revisions, but it doesn't necessarily
makes things work. The problem I've reported back in 2009 still exists on
P2020RDB revC, even if I use the latest u-boot and kernel and make device
tree changes that you've suggested.
I've attached the boot log.

As such there is no hardware fix related to this issue between RevC to RevD. 
The solution was a software patch to resolve the issue related to IRQ0.


Are you sure ? Please take a look at Freescale document titled 
P1020E/P2020E RDB System Errata.
There's errata CE10, IRQ0 held low. It is fixed in Rev D. Vivek 
Mahajan, who looked at the issue back
in 2009, estimated that problem can be related to missing pull-up on 
IRQ0. This is exactly what is

fixed in Rev D.

Felix.

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: Problem with mini-PCI-E slot on P2020RDB

2011-04-07 Thread Leon Woestenberg
Hello,

On Thu, Dec 17, 2009 at 9:28 PM, Felix Radensky fe...@embedded-sol.com wrote:
 Kumar Gala wrote:
 On Dec 17, 2009, at 2:59 AM, Mahajan Vivek-B08308 wrote:
 Thanks a lot. If I understand you correctly, the only way I can get
 ath9k driver to work on this board using legacy interrupts is to wait for a
 hardware fix. Right ?

 Correct

 I'm confused.  What's the issue with IRQ0 on the P2020RDB?  Is it used for
 another purpose?

 There's a problem with IRQ0 with respect to mini-PCI-E slot. I have Atheros
 wireless card plugged
 into it. ath9k wireless driver for this card uses legacy PCI-E interrupts,
 and I get irq 16: nobody cared
 message when driver executes request_irq(). Vivek has come to a conclusion
 that the problem is
 related to incorrect IRQ0 routing for mini-PCI-E slot on P2020RDB.


I would like to understand this issue better, as I seem to be running
into something similar, and it puts my board design on hold.

Can someone (from Freescale) explain what happens if a PCI Express end
point on the mini-PCIe slot raises a legacy interrupt, and where this
goes wrong?

From what document or source code file can I conclude that the PCIe
legacy interrupt is shared with IRQ0?


I found this:

P1020E/P2020E RDB System Errata, Last Update: 2/15/2010:
Problem:IRQ0 held low
Fix: Add 4.7K pull-up (to 3.3.V) for RTC_INT_N.
See R420 in Rev D schematic.
Add 4.7K pull-up (to 3.3.V) for MCU_INT_N.
See R423 in Rev D schematic.


Regards,
-- 
Leon
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


RE: Problem with mini-PCI-E slot on P2020RDB

2011-04-07 Thread Kushwaha Prabhakar-B32579


 -Original Message-
 From: Leon Woestenberg [mailto:leon.woestenb...@gmail.com]
 Sent: Thursday, April 07, 2011 10:50 PM
 To: linuxppc-...@ozlabs.org
 Cc: Kumar Gala; Mahajan Vivek-B08308; Aggrwal Poonam-B10812; Felix
 Radensky; Kushwaha Prabhakar-B32579
 Subject: Re: Problem with mini-PCI-E slot on P2020RDB
 
 Hello,
 
 On Thu, Dec 17, 2009 at 9:28 PM, Felix Radensky fe...@embedded-sol.com
 wrote:
  Kumar Gala wrote:
  On Dec 17, 2009, at 2:59 AM, Mahajan Vivek-B08308 wrote:
  Thanks a lot. If I understand you correctly, the only way I can get
  ath9k driver to work on this board using legacy interrupts is to
  wait for a hardware fix. Right ?
 
  Correct
 
  I'm confused.  What's the issue with IRQ0 on the P2020RDB?  Is it
  used for another purpose?
 
  There's a problem with IRQ0 with respect to mini-PCI-E slot. I have
  Atheros wireless card plugged into it. ath9k wireless driver for this
  card uses legacy PCI-E interrupts, and I get irq 16: nobody cared
  message when driver executes request_irq(). Vivek has come to a
  conclusion that the problem is related to incorrect IRQ0 routing for
  mini-PCI-E slot on P2020RDB.
 
 
 I would like to understand this issue better, as I seem to be running
 into something similar, and it puts my board design on hold.
 
 Can someone (from Freescale) explain what happens if a PCI Express end
 point on the mini-PCIe slot raises a legacy interrupt, and where this
 goes wrong?
 
 From what document or source code file can I conclude that the PCIe
 legacy interrupt is shared with IRQ0?
 
 
 I found this:
 
 P1020E/P2020E RDB System Errata, Last Update: 2/15/2010:
 Problem:IRQ0 held low
 Fix: Add 4.7K pull-up (to 3.3.V) for RTC_INT_N.
 See R420 in Rev D schematic.
 Add 4.7K pull-up (to 3.3.V) for MCU_INT_N.
 See R423 in Rev D schematic.
 
 

Hello Leon,

 Yes you are right, PCIe leagacy interrupt is shared with IRQ0. For Atheros 
issue. 
 Can you please try followings, Meanwhile I will try to dig into it.
   
http://old.nabble.com/Problem-with-mini-PCI-E-slot-on-P2020RDB-td26802038.html

Regarding sata_sil24, Please see my e-mail on Linux-ide for correct IDSEL 
value. 
Please first try IDSEL value mentioned in email on Linux-ide. Then try this 
URL..

--Prabhakar

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


RE: Problem with mini-PCI-E slot on P2020RDB

2009-12-17 Thread Mahajan Vivek-B08308
 From: 
 linuxppc-dev-bounces+vivek.mahajan=freescale@lists.ozlabs.
 org 
 [mailto:linuxppc-dev-bounces+vivek.mahajan=freescale@lists
 .ozlabs.org] On Behalf Of Felix Radensky
 Sent: Thursday, December 17, 2009 12:52 PM
 
  I just noticed a MSI enable bit in 
  drivers/net/wireless/ath/ath9k/reg.h
  as under, may be we need to trun this on:-
 
  reg.h:1013:#define AR_PCIE_MSI  0x4094
  reg.h:1014:#define AR_PCIE_MSI_ENABLE   
 0x0001

 According to ath9k developers adding MSI support to the 
 driver is not trivial.
 They've tried once, it didn't work and they gave up. Any 
 chance I can use mini-PCI-E slot without MSI ?

So, even after enabling the above bit, there were no MSI 
interrupts from this card. If we look at some of the GbE 
or SATA drivers, adding MSI is not that hard. ath9k can 
be an exception. 

I reported this issue to the p2020 board designer; but 
unfortunately he is out until 1/4/10. It could be a missing 
pull-up issue at IRQ0 or some thing else, I don't know. 

 
 Thanks.
 
 Felix.

Thanks,
Vivek
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: Problem with mini-PCI-E slot on P2020RDB

2009-12-17 Thread Felix Radensky

Mahajan Vivek-B08308 wrote:
From: 
linuxppc-dev-bounces+vivek.mahajan=freescale@lists.ozlabs.
org 
[mailto:linuxppc-dev-bounces+vivek.mahajan=freescale@lists

.ozlabs.org] On Behalf Of Felix Radensky
Sent: Thursday, December 17, 2009 12:52 PM

I just noticed a MSI enable bit in 
drivers/net/wireless/ath/ath9k/reg.h

as under, may be we need to trun this on:-

reg.h:1013:#define AR_PCIE_MSI  0x4094
reg.h:1014:#define AR_PCIE_MSI_ENABLE   
  

0x0001

  
  
According to ath9k developers adding MSI support to the 
driver is not trivial.
They've tried once, it didn't work and they gave up. Any 
chance I can use mini-PCI-E slot without MSI ?



So, even after enabling the above bit, there were no MSI 
interrupts from this card. If we look at some of the GbE 
or SATA drivers, adding MSI is not that hard. ath9k can 
be an exception. 
  

Yes, I've enabled that bit, but didn't get any interrupt.
I reported this issue to the p2020 board designer; but 
unfortunately he is out until 1/4/10. It could be a missing 
pull-up issue at IRQ0 or some thing else, I don't know. 

  


Thanks a lot. If I understand you correctly, the only way I can
get ath9k driver to work on this board using legacy interrupts is
to wait for a hardware fix. Right ?

Felix.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


RE: Problem with mini-PCI-E slot on P2020RDB

2009-12-17 Thread Mahajan Vivek-B08308
 From: Felix Radensky [mailto:fe...@embedded-sol.com] 
 Sent: Thursday, December 17, 2009 2:26 PM
 
 Yes, I've enabled that bit, but didn't get any interrupt.

Thanks for trying. 

 
 Thanks a lot. If I understand you correctly, the only way I 
 can get ath9k driver to work on this board using legacy 
 interrupts is to wait for a hardware fix. Right ?

Correct

 
 Felix.
 

Thanks,
Vivek
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: Problem with mini-PCI-E slot on P2020RDB

2009-12-17 Thread Kumar Gala

On Dec 17, 2009, at 2:59 AM, Mahajan Vivek-B08308 wrote:

 
 Thanks a lot. If I understand you correctly, the only way I 
 can get ath9k driver to work on this board using legacy 
 interrupts is to wait for a hardware fix. Right ?
 
 Correct

I'm confused.  What's the issue with IRQ0 on the P2020RDB?  Is it used for 
another purpose?

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: Problem with mini-PCI-E slot on P2020RDB

2009-12-17 Thread Felix Radensky

Hi, Kumar
Kumar Gala wrote:

On Dec 17, 2009, at 2:59 AM, Mahajan Vivek-B08308 wrote:

  
Thanks a lot. If I understand you correctly, the only way I 
can get ath9k driver to work on this board using legacy 
interrupts is to wait for a hardware fix. Right ?
  

Correct



I'm confused.  What's the issue with IRQ0 on the P2020RDB?  Is it used for 
another purpose?
  


There's a problem with IRQ0 with respect to mini-PCI-E slot. I have 
Atheros wireless card plugged
into it. ath9k wireless driver for this card uses legacy PCI-E 
interrupts, and I get irq 16: nobody cared
message when driver executes request_irq(). Vivek has come to a 
conclusion that the problem is

related to incorrect IRQ0 routing for mini-PCI-E slot on P2020RDB.

Felix.

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: Problem with mini-PCI-E slot on P2020RDB

2009-12-16 Thread Felix Radensky

Hi,

Mahajan Vivek-B08308 wrote:



Hi,

I'm trying to use mini-PCI-E WLAN card on P2020RDB running 
2.6.32, but so far without success.
ath9k driver identifies the device, I can run ifconfig, 
iwconfig and hostapd on wlan0, but device is not getting any 
interrupts,  so I suspect the interrupt configuration is 
wrong. Atheros ath9k driver reports:


phy0: Atheros AR9280 MAC/BB Rev:2 AR5133 RF Rev:d0: 
mem=0xf106, irq=16


The mapping for irq 16 is:

irq: irq 1 on host /s...@ffe0/p...@4 mapped to virtual irq 16

According to /proc/interrupts:

  CPU0
 16:  0   OpenPIC   Edge  ath9k

The same problem happens if Atheros card is plugged (with 
adapter) into regular PCI-E slot.


It seems that p2020rdb device tree is missing 
interrupt-map-mask and interrupt-map properties in PCI-E nodes.


I've tried running kernel from latest FSL BSP for this board 
(based on 2.6.32-rc3). The device tree has the 
interrupt-map-mask and interrupt-map properties, and 
interrupt mapping is different:


irq: irq 0 on host /s...@ffe0/p...@4 mapped to virtual irq 16

In /proc/interrups I see
   CPU0
 16: 11   OpenPIC   Level ath9k

However, when ath9k driver is loaded I get this:

irq 16: nobody cared (try booting with the irqpoll option) 
Call Trace:
[efbefa40] [c00074b0] show_stack+0x4c/0x16c (unreliable) 
[efbefa70] [c0073970] __report_bad_irq+0x38/0xd0 [efbefa90] 
[c0073bd4] note_interrupt+0x1cc/0x22c [efbefac0] [c00747d0] 
handle_fasteoi_irq+0xf4/0x128 [efbefae0] [c0004eb8] 
do_IRQ+0xc8/0xf4 [efbefb00] [c001081c] 
ret_from_except+0x0/0x18 [efbefbc0] [] (null) 
[efbefc10] [c0004d24] do_softirq+0x60/0x64 [efbefc20] 
[c0044670] irq_exit+0x88/0xa8 [efbefc30] [c0004ebc] 
do_IRQ+0xcc/0xf4 [efbefc50] [c001081c] 
ret_from_except+0x0/0x18 [efbefd10] [c00730b4] 
__setup_irq+0x320/0x39c [efbefd30] [c0073214] 
request_threaded_irq+0xe4/0x148 [efbefd60] [f2244218] 
ath_pci_probe+0x1b0/0x3a4 [ath9k] [efbefda0] [c01c386c] 
local_pci_probe+0x24/0x34 [efbefdb0] [c01c3bc0] 
pci_device_probe+0x84/0xa8 [efbefde0] [c01e86b8] 
driver_probe_device+0xa8/0x1a8 [efbefe00] [c01e8874] 
__driver_attach+0xbc/0xc0 [efbefe20] [c01e7d88] 
bus_for_each_dev+0x70/0xac [efbefe50] [c01e84d8] 
driver_attach+0x24/0x34 [efbefe60] [c01e7504] 
bus_add_driver+0xb8/0x278 [efbefe90] [c01e8bec] 
driver_register+0x84/0x178 [efbefeb0] [c01c3e6c] 
__pci_register_driver+0x54/0xe4 [efbefed0] [f2244434] 
ath_pci_init+0x28/0x38 [ath9k] [efbefee0] [f215702c] 
ath9k_init+0x2c/0x100 [ath9k] [efbefef0] [c0001d34] 
do_one_initcall+0x3c/0x1e8 [efbeff20] [c006f9f0] 
sys_init_module+0xf8/0x220 [efbeff40] [c00101c4] 
ret_from_syscall+0x0/0x3c

handlers:
[f223badc] (ath_isr+0x0/0x1b4 [ath9k]) Disabling IRQ #16



Looks like INTA is not being routed to IRQ0 properly for this
PCIe ctlr. Try changing the interrupt-map prop for the ctlr 
at 0xffe0a000 to the following, temporarily:-


interrupt-map = 
/* IDSEL 0x0 */
 0x0 0x0 0x1 mpic 0x1 0x1
 0x0 0x0 0x2 mpic 0x2 0x1
 0x0 0x0 0x3 mpic 0x3 0x1
 0x0 0x0 0x4 mpic 0x0 0x1
  


Thanks for your help. With this change nobody cared message disappears,
but interrupts are not coming at all.

Is it a SoC problem or a board problem ?

Thanks.

Felix.

___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


RE: Problem with mini-PCI-E slot on P2020RDB

2009-12-16 Thread Mahajan Vivek-B08308
 From: Felix Radensky [mailto:fe...@embedded-sol.com] 
 Sent: Wednesday, December 16, 2009 2:56 PM
 To: Mahajan Vivek-B08308
 Cc: linuxppc-...@ozlabs.org; Aggrwal Poonam-B10812; Kumar Gala
 Subject: Re: Problem with mini-PCI-E slot on P2020RDB
 
 Hi,
 
  Looks like INTA is not being routed to IRQ0 properly for this PCIe 
  ctlr. Try changing the interrupt-map prop for the ctlr at 
 0xffe0a000 
  to the following, temporarily:-
 
  interrupt-map = 
  /* IDSEL 0x0 */
   0x0 0x0 0x1 mpic 0x1 0x1
   0x0 0x0 0x2 mpic 0x2 0x1
   0x0 0x0 0x3 mpic 0x3 0x1
   0x0 0x0 0x4 mpic 0x0 0x1

 
 Thanks for your help. With this change nobody cared message 
 disappears, but interrupts are not coming at all.
 
 Is it a SoC problem or a board problem ?

As per the p2020rm, PCIe legacy INTA is shared with IRQ0 for 
this ctlr, which is the exactly the case with other SoC's 
p2020ds, mpc8536ds, mpc8572ds. To me it seems like a board 
issue and it needs to be followed up.

I plugged in ralink rt2860 pcie wirless card in the mini-pcie 
slot of p2020rdb, which ran fine becaused it used MSI by default.
How hard is it to enable MSI in the atheros wireless driver.

 
 Thanks.
 
 Felix.
 

Thanks,
Vivek
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: Problem with mini-PCI-E slot on P2020RDB

2009-12-16 Thread Felix Radensky

Mahajan Vivek-B08308 wrote:
From: Felix Radensky [mailto:fe...@embedded-sol.com] 
Sent: Wednesday, December 16, 2009 2:56 PM

To: Mahajan Vivek-B08308
Cc: linuxppc-...@ozlabs.org; Aggrwal Poonam-B10812; Kumar Gala
Subject: Re: Problem with mini-PCI-E slot on P2020RDB

Hi,

Looks like INTA is not being routed to IRQ0 properly for this PCIe 
ctlr. Try changing the interrupt-map prop for the ctlr at 
  
0xffe0a000 


to the following, temporarily:-

interrupt-map = 
/* IDSEL 0x0 */
 0x0 0x0 0x1 mpic 0x1 0x1
 0x0 0x0 0x2 mpic 0x2 0x1
 0x0 0x0 0x3 mpic 0x3 0x1
 0x0 0x0 0x4 mpic 0x0 0x1
  
  
Thanks for your help. With this change nobody cared message 
disappears, but interrupts are not coming at all.


Is it a SoC problem or a board problem ?



As per the p2020rm, PCIe legacy INTA is shared with IRQ0 for 
this ctlr, which is the exactly the case with other SoC's 
p2020ds, mpc8536ds, mpc8572ds. To me it seems like a board 
issue and it needs to be followed up.


I plugged in ralink rt2860 pcie wirless card in the mini-pcie 
slot of p2020rdb, which ran fine becaused it used MSI by default.

How hard is it to enable MSI in the atheros wireless driver.

  


I've enabled MSI in ath9k driver, by simply adding pci_enable_msi() and
pci_disable_msi() at relevant places. The MSI interrupt is allocated.

irq: irq 0 on host /s...@ffe0/m...@41600 mapped to virtual irq 18
phy0: Atheros AR9280 MAC/BB Rev:2 AR5133 RF Rev:d0: mem=0xf216, irq=18

cat /proc/interrupts
  CPU0
18:  0   FSL-MSI   Edge  ath9k

lspci -v shows that MSI was enabled on device

But I don't get any interrupts. I've posted a question to ath9k list, 
maybe folks there

will have some ideas.

Thanks.

Felix.


___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


RE: Problem with mini-PCI-E slot on P2020RDB

2009-12-16 Thread Mahajan Vivek-B08308
 From: Felix Radensky [mailto:fe...@embedded-sol.com] 
 Sent: Wednesday, December 16, 2009 5:30 PM
  As per the p2020rm, PCIe legacy INTA is shared with IRQ0 for this 
  ctlr, which is the exactly the case with other SoC's p2020ds, 
  mpc8536ds, mpc8572ds. To me it seems like a board issue and 
 it needs 
  to be followed up.
 
  I plugged in ralink rt2860 pcie wirless card in the 
 mini-pcie slot of 
  p2020rdb, which ran fine becaused it used MSI by default.
  How hard is it to enable MSI in the atheros wireless driver.
 

 
 I've enabled MSI in ath9k driver, by simply adding 
 pci_enable_msi() and
 pci_disable_msi() at relevant places. The MSI interrupt is allocated.
 
 irq: irq 0 on host /s...@ffe0/m...@41600 mapped to virtual irq 18
 phy0: Atheros AR9280 MAC/BB Rev:2 AR5133 RF Rev:d0: 
 mem=0xf216, irq=18
 
 cat /proc/interrupts
CPU0
  18:  0   FSL-MSI   Edge  ath9k
 
 lspci -v shows that MSI was enabled on device
 
 But I don't get any interrupts. I've posted a question to 
 ath9k list, maybe folks there will have some ideas.

I just noticed a MSI enable bit in drivers/net/wireless/ath/ath9k/reg.h 
as under, may be we need to trun this on:-

reg.h:1013:#define AR_PCIE_MSI  0x4094
reg.h:1014:#define AR_PCIE_MSI_ENABLE   0x0001

 
 Thanks.
 
 Felix.
 

Thanks,
Vivek
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Re: Problem with mini-PCI-E slot on P2020RDB

2009-12-16 Thread Felix Radensky

Hi,

Mahajan Vivek-B08308 wrote:


I've enabled MSI in ath9k driver, by simply adding 
pci_enable_msi() and

pci_disable_msi() at relevant places. The MSI interrupt is allocated.

irq: irq 0 on host /s...@ffe0/m...@41600 mapped to virtual irq 18
phy0: Atheros AR9280 MAC/BB Rev:2 AR5133 RF Rev:d0: 
mem=0xf216, irq=18


cat /proc/interrupts
   CPU0
 18:  0   FSL-MSI   Edge  ath9k

lspci -v shows that MSI was enabled on device

But I don't get any interrupts. I've posted a question to 
ath9k list, maybe folks there will have some ideas.



I just noticed a MSI enable bit in drivers/net/wireless/ath/ath9k/reg.h 
as under, may be we need to trun this on:-


reg.h:1013:#define AR_PCIE_MSI  0x4094
reg.h:1014:#define AR_PCIE_MSI_ENABLE   0x0001

  
According to ath9k developers adding MSI support to the driver is not 
trivial.

They've tried once, it didn't work and they gave up. Any chance I can use
mini-PCI-E slot without MSI ?

Thanks.

Felix.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


Problem with mini-PCI-E slot on P2020RDB

2009-12-15 Thread Felix Radensky

Hi,

I'm trying to use mini-PCI-E WLAN card on P2020RDB running 2.6.32, but 
so far without success.
ath9k driver identifies the device, I can run ifconfig, iwconfig and 
hostapd on wlan0, but device is not
getting any interrupts,  so I suspect the interrupt configuration is 
wrong. Atheros ath9k driver reports:


phy0: Atheros AR9280 MAC/BB Rev:2 AR5133 RF Rev:d0: mem=0xf106, irq=16

The mapping for irq 16 is:

irq: irq 1 on host /s...@ffe0/p...@4 mapped to virtual irq 16

According to /proc/interrupts:

 CPU0
16:  0   OpenPIC   Edge  ath9k

The same problem happens if Atheros card is plugged (with adapter) into 
regular PCI-E slot.


It seems that p2020rdb device tree is missing interrupt-map-mask and 
interrupt-map properties

in PCI-E nodes.

I've tried running kernel from latest FSL BSP for this board (based on 
2.6.32-rc3). The device tree
has the interrupt-map-mask and interrupt-map properties, and interrupt 
mapping is different:


irq: irq 0 on host /s...@ffe0/p...@4 mapped to virtual irq 16

In /proc/interrups I see
  CPU0
16: 11   OpenPIC   Level ath9k

However, when ath9k driver is loaded I get this:

irq 16: nobody cared (try booting with the irqpoll option)
Call Trace:
[efbefa40] [c00074b0] show_stack+0x4c/0x16c (unreliable)
[efbefa70] [c0073970] __report_bad_irq+0x38/0xd0
[efbefa90] [c0073bd4] note_interrupt+0x1cc/0x22c
[efbefac0] [c00747d0] handle_fasteoi_irq+0xf4/0x128
[efbefae0] [c0004eb8] do_IRQ+0xc8/0xf4
[efbefb00] [c001081c] ret_from_except+0x0/0x18
[efbefbc0] [] (null)
[efbefc10] [c0004d24] do_softirq+0x60/0x64
[efbefc20] [c0044670] irq_exit+0x88/0xa8
[efbefc30] [c0004ebc] do_IRQ+0xcc/0xf4
[efbefc50] [c001081c] ret_from_except+0x0/0x18
[efbefd10] [c00730b4] __setup_irq+0x320/0x39c
[efbefd30] [c0073214] request_threaded_irq+0xe4/0x148
[efbefd60] [f2244218] ath_pci_probe+0x1b0/0x3a4 [ath9k]
[efbefda0] [c01c386c] local_pci_probe+0x24/0x34
[efbefdb0] [c01c3bc0] pci_device_probe+0x84/0xa8
[efbefde0] [c01e86b8] driver_probe_device+0xa8/0x1a8
[efbefe00] [c01e8874] __driver_attach+0xbc/0xc0
[efbefe20] [c01e7d88] bus_for_each_dev+0x70/0xac
[efbefe50] [c01e84d8] driver_attach+0x24/0x34
[efbefe60] [c01e7504] bus_add_driver+0xb8/0x278
[efbefe90] [c01e8bec] driver_register+0x84/0x178
[efbefeb0] [c01c3e6c] __pci_register_driver+0x54/0xe4
[efbefed0] [f2244434] ath_pci_init+0x28/0x38 [ath9k]
[efbefee0] [f215702c] ath9k_init+0x2c/0x100 [ath9k]
[efbefef0] [c0001d34] do_one_initcall+0x3c/0x1e8
[efbeff20] [c006f9f0] sys_init_module+0xf8/0x220
[efbeff40] [c00101c4] ret_from_syscall+0x0/0x3c
handlers:
[f223badc] (ath_isr+0x0/0x1b4 [ath9k])
Disabling IRQ #16

Atheros card plugged into regular PCI-E slot  works OK in  FSL BSP.

Any help in resolving this is much appreciated.

Thanks.

Felix.




___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev


RE: Problem with mini-PCI-E slot on P2020RDB

2009-12-15 Thread Mahajan Vivek-B08308
 -Original Message-
 From: 
 linuxppc-dev-bounces+vivek.mahajan=freescale@lists.ozlabs.
 org 
 [mailto:linuxppc-dev-bounces+vivek.mahajan=freescale@lists
.ozlabs.org] On Behalf Of Felix Radensky
 Sent: Wednesday, December 16, 2009 2:56 AM
 To: linuxppc-...@ozlabs.org; Aggrwal Poonam-B10812; Kumar Gala
 Subject: Problem with mini-PCI-E slot on P2020RDB
 
 Hi,
 
 I'm trying to use mini-PCI-E WLAN card on P2020RDB running 
 2.6.32, but so far without success.
 ath9k driver identifies the device, I can run ifconfig, 
 iwconfig and hostapd on wlan0, but device is not getting any 
 interrupts,  so I suspect the interrupt configuration is 
 wrong. Atheros ath9k driver reports:
 
 phy0: Atheros AR9280 MAC/BB Rev:2 AR5133 RF Rev:d0: 
 mem=0xf106, irq=16
 
 The mapping for irq 16 is:
 
 irq: irq 1 on host /s...@ffe0/p...@4 mapped to virtual irq 16
 
 According to /proc/interrupts:
 
   CPU0
  16:  0   OpenPIC   Edge  ath9k
 
 The same problem happens if Atheros card is plugged (with 
 adapter) into regular PCI-E slot.
 
 It seems that p2020rdb device tree is missing 
 interrupt-map-mask and interrupt-map properties in PCI-E nodes.
 
 I've tried running kernel from latest FSL BSP for this board 
 (based on 2.6.32-rc3). The device tree has the 
 interrupt-map-mask and interrupt-map properties, and 
 interrupt mapping is different:
 
 irq: irq 0 on host /s...@ffe0/p...@4 mapped to virtual irq 16
 
 In /proc/interrups I see
CPU0
  16: 11   OpenPIC   Level ath9k
 
 However, when ath9k driver is loaded I get this:
 
 irq 16: nobody cared (try booting with the irqpoll option) 
 Call Trace:
 [efbefa40] [c00074b0] show_stack+0x4c/0x16c (unreliable) 
 [efbefa70] [c0073970] __report_bad_irq+0x38/0xd0 [efbefa90] 
 [c0073bd4] note_interrupt+0x1cc/0x22c [efbefac0] [c00747d0] 
 handle_fasteoi_irq+0xf4/0x128 [efbefae0] [c0004eb8] 
 do_IRQ+0xc8/0xf4 [efbefb00] [c001081c] 
 ret_from_except+0x0/0x18 [efbefbc0] [] (null) 
 [efbefc10] [c0004d24] do_softirq+0x60/0x64 [efbefc20] 
 [c0044670] irq_exit+0x88/0xa8 [efbefc30] [c0004ebc] 
 do_IRQ+0xcc/0xf4 [efbefc50] [c001081c] 
 ret_from_except+0x0/0x18 [efbefd10] [c00730b4] 
 __setup_irq+0x320/0x39c [efbefd30] [c0073214] 
 request_threaded_irq+0xe4/0x148 [efbefd60] [f2244218] 
 ath_pci_probe+0x1b0/0x3a4 [ath9k] [efbefda0] [c01c386c] 
 local_pci_probe+0x24/0x34 [efbefdb0] [c01c3bc0] 
 pci_device_probe+0x84/0xa8 [efbefde0] [c01e86b8] 
 driver_probe_device+0xa8/0x1a8 [efbefe00] [c01e8874] 
 __driver_attach+0xbc/0xc0 [efbefe20] [c01e7d88] 
 bus_for_each_dev+0x70/0xac [efbefe50] [c01e84d8] 
 driver_attach+0x24/0x34 [efbefe60] [c01e7504] 
 bus_add_driver+0xb8/0x278 [efbefe90] [c01e8bec] 
 driver_register+0x84/0x178 [efbefeb0] [c01c3e6c] 
 __pci_register_driver+0x54/0xe4 [efbefed0] [f2244434] 
 ath_pci_init+0x28/0x38 [ath9k] [efbefee0] [f215702c] 
 ath9k_init+0x2c/0x100 [ath9k] [efbefef0] [c0001d34] 
 do_one_initcall+0x3c/0x1e8 [efbeff20] [c006f9f0] 
 sys_init_module+0xf8/0x220 [efbeff40] [c00101c4] 
 ret_from_syscall+0x0/0x3c
 handlers:
 [f223badc] (ath_isr+0x0/0x1b4 [ath9k]) Disabling IRQ #16

Looks like INTA is not being routed to IRQ0 properly for this
PCIe ctlr. Try changing the interrupt-map prop for the ctlr 
at 0xffe0a000 to the following, temporarily:-

interrupt-map = 
/* IDSEL 0x0 */
 0x0 0x0 0x1 mpic 0x1 0x1
 0x0 0x0 0x2 mpic 0x2 0x1
 0x0 0x0 0x3 mpic 0x3 0x1
 0x0 0x0 0x4 mpic 0x0 0x1
;

 
 Atheros card plugged into regular PCI-E slot  works OK in  FSL BSP.
 
 Any help in resolving this is much appreciated.
 
 Thanks.
 
 Felix.
 

Thanks,
Vivek
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev