Re: [PATCH v3 9/9] add MPC837x MDS board default device tree

2007-10-19 Thread Kumar Gala

 diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts
 b/arch/powerpc/boot/dts/mpc8377_mds.dts
 [snip]
 +  [EMAIL PROTECTED] {
 +  #address-cells = 1;
 +  #size-cells = 1;
 +  device_type = soc;
 +  ranges = 0 e000 0010;
 +  reg = e000 0200;
 +  bus-frequency = 0;
 +
 +  [EMAIL PROTECTED] {
 +  device_type = watchdog;

 Drop this device_type.

 +  compatible = mpc83xx_wdt;
 +  reg = 200 100;
 +  };
 +
 +  [EMAIL PROTECTED] {
 +  device_type = i2c;

 And this one.

 I've asked Leo to leave this one as all other fsl boards do
 this and the code depends on it.  There was some discussion
 about this but I wasn't sure if it was closed or not.

 I'm afraid not only i2c but also watchdog and spi need device_type  
 now.
 Shall we proceed removing the type check?

We are NOT changing that code until 2.6.25.

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


RE: [PATCH v3 9/9] add MPC837x MDS board default device tree

2007-10-18 Thread Li Yang-r58472
 

 -Original Message-
 From: Kumar Gala [mailto:[EMAIL PROTECTED] 
 Sent: Wednesday, October 17, 2007 9:59 PM
 To: David Gibson
 Cc: Li Yang-r58472; [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org
 Subject: Re: [PATCH v3 9/9] add MPC837x MDS board default device tree
 
 
 On Oct 14, 2007, at 7:37 PM, David Gibson wrote:
 
  On Fri, Oct 12, 2007 at 09:28:48PM +0800, Li Yang wrote:
  Signed-off-by: Li Yang [EMAIL PROTECTED]
  ---
   arch/powerpc/boot/dts/mpc8377_mds.dts |  288 +
  +
   arch/powerpc/boot/dts/mpc8378_mds.dts |  268 +
  +++
   arch/powerpc/boot/dts/mpc8379_mds.dts |  308 +
  
   3 files changed, 864 insertions(+), 0 deletions(-)  create mode 
  100644 arch/powerpc/boot/dts/mpc8377_mds.dts
   create mode 100644 arch/powerpc/boot/dts/mpc8378_mds.dts
   create mode 100644 arch/powerpc/boot/dts/mpc8379_mds.dts
 
  diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts
  b/arch/powerpc/boot/dts/mpc8377_mds.dts
  [snip]
  +  [EMAIL PROTECTED] {
  +  #address-cells = 1;
  +  #size-cells = 1;
  +  device_type = soc;
  +  ranges = 0 e000 0010;
  +  reg = e000 0200;
  +  bus-frequency = 0;
  +
  +  [EMAIL PROTECTED] {
  +  device_type = watchdog;
 
  Drop this device_type.
 
  +  compatible = mpc83xx_wdt;
  +  reg = 200 100;
  +  };
  +
  +  [EMAIL PROTECTED] {
  +  device_type = i2c;
 
  And this one.
 
 I've asked Leo to leave this one as all other fsl boards do 
 this and the code depends on it.  There was some discussion 
 about this but I wasn't sure if it was closed or not.

I'm afraid not only i2c but also watchdog and spi need device_type now.
Shall we proceed removing the type check?

- Leo
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH v3 9/9] add MPC837x MDS board default device tree

2007-10-17 Thread Kumar Gala

On Oct 14, 2007, at 7:37 PM, David Gibson wrote:

 On Fri, Oct 12, 2007 at 09:28:48PM +0800, Li Yang wrote:
 Signed-off-by: Li Yang [EMAIL PROTECTED]
 ---
  arch/powerpc/boot/dts/mpc8377_mds.dts |  288 + 
 +
  arch/powerpc/boot/dts/mpc8378_mds.dts |  268 + 
 +++
  arch/powerpc/boot/dts/mpc8379_mds.dts |  308 + 
 
  3 files changed, 864 insertions(+), 0 deletions(-)
  create mode 100644 arch/powerpc/boot/dts/mpc8377_mds.dts
  create mode 100644 arch/powerpc/boot/dts/mpc8378_mds.dts
  create mode 100644 arch/powerpc/boot/dts/mpc8379_mds.dts

 diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts
 b/arch/powerpc/boot/dts/mpc8377_mds.dts
 [snip]
 +[EMAIL PROTECTED] {
 +#address-cells = 1;
 +#size-cells = 1;
 +device_type = soc;
 +ranges = 0 e000 0010;
 +reg = e000 0200;
 +bus-frequency = 0;
 +
 +[EMAIL PROTECTED] {
 +device_type = watchdog;

 Drop this device_type.

 +compatible = mpc83xx_wdt;
 +reg = 200 100;
 +};
 +
 +[EMAIL PROTECTED] {
 +device_type = i2c;

 And this one.

I've asked Leo to leave this one as all other fsl boards do this and  
the code depends on it.  There was some discussion about this but I  
wasn't sure if it was closed or not.

 +compatible = fsl-i2c;
 +reg = 3000 100;
 +interrupts = e 8;
 +interrupt-parent =  ipic ;
 +dfsrr;
 +};
 +

- k
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev


Re: [PATCH v3 9/9] add MPC837x MDS board default device tree

2007-10-14 Thread David Gibson
On Fri, Oct 12, 2007 at 09:28:48PM +0800, Li Yang wrote:
 Signed-off-by: Li Yang [EMAIL PROTECTED]
 ---
  arch/powerpc/boot/dts/mpc8377_mds.dts |  288 ++
  arch/powerpc/boot/dts/mpc8378_mds.dts |  268 
  arch/powerpc/boot/dts/mpc8379_mds.dts |  308 
 +
  3 files changed, 864 insertions(+), 0 deletions(-)
  create mode 100644 arch/powerpc/boot/dts/mpc8377_mds.dts
  create mode 100644 arch/powerpc/boot/dts/mpc8378_mds.dts
  create mode 100644 arch/powerpc/boot/dts/mpc8379_mds.dts
 
 diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts
 b/arch/powerpc/boot/dts/mpc8377_mds.dts
[snip]
 + [EMAIL PROTECTED] {
 + #address-cells = 1;
 + #size-cells = 1;
 + device_type = soc;
 + ranges = 0 e000 0010;
 + reg = e000 0200;
 + bus-frequency = 0;
 +
 + [EMAIL PROTECTED] {
 + device_type = watchdog;

Drop this device_type.

 + compatible = mpc83xx_wdt;
 + reg = 200 100;
 + };
 +
 + [EMAIL PROTECTED] {
 + device_type = i2c;

And this one.

 + compatible = fsl-i2c;
 + reg = 3000 100;
 + interrupts = e 8;
 + interrupt-parent =  ipic ;
 + dfsrr;
 + };
 +
 + [EMAIL PROTECTED] {
 + device_type = i2c;

And here.

 + compatible = fsl-i2c;
 + reg = 3100 100;
 + interrupts = f 8;
 + interrupt-parent =  ipic ;
 + dfsrr;
 + };
 +
 + [EMAIL PROTECTED] {
 + device_type = spi;

And this one.

[snip]
 + [EMAIL PROTECTED] {
 + device_type = crypto;

And definitely this one.

 + model = SEC3;
 + compatible = talitos;
 + reg = 3 1;
 + interrupts = b 8;
 + interrupt-parent =  ipic ;
 + /* Rev. 3.0 geometry */
 + num-channels = 4;
 + channel-fifo-len = 18;
 + exec-units-mask = 09fe;
 + descriptor-types-mask = 03ab0ebf;
 + };
 +
 + [EMAIL PROTECTED] {
 + model = eSDHC;
 + compatible = fsl,esdhc;
 + reg = 2e000 1000;
 + interrupts = 2a 8;
 + interrupt-parent =  ipic ;
 + };
 +
 + [EMAIL PROTECTED] {
 + device_type = sata;

And again.


-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev