Re: [PATCH] [Powerpc V2] fix switch_slb handling of 1T ESID values

2007-10-29 Thread Stephen Rothwell 
Hi Will,

Just a trivial comment ...

On Mon, 29 Oct 2007 13:32:19 -0500 Will Schmidt [EMAIL PROTECTED] wrote:

 +static inline int esids_match(unsigned long addr1, unsigned long addr2)
 +{
 + int esid_1t_count;
 +
 + /* System is not 1T segment size capable. */
 + if (!cpu_has_feature(CPU_FTR_1T_SEGMENT))
 + return (GET_ESID(addr1) == GET_ESID(addr2));
 +
 + esid_1t_count = (((addr1SID_SHIFT_1T)!=0) + 
 ((addr2SID_SHIFT_1T)!=0));

Please use spaces around binary operators (as you have elsewhere). Even
if it pushes the line slightly over 80 characters ...

-- 
Cheers,
Stephen Rothwell[EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/


pgpLsYJ7RHmtU.pgp
Description: PGP signature
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] [Powerpc V2] fix switch_slb handling of 1T ESID values

2007-10-29 Thread Benjamin Herrenschmidt 

On Mon, 2007-10-29 at 13:32 -0500, Will Schmidt wrote:
 [Powerpc V2] fix switch_slb handling of 1T ESID values
 
 Now that we have 1TB segment size support, we need to be using the
 GET_ESID_1T macro when comparing ESID values for pc,stack, and
 unmapped_base within switch_slb().A new helper function called
 esids_match() contains the logic for deciding when to call GET_ESID
 and GET_ESID_1T.
 
 This also happens to fix a duplicate-slb-entry inspired machine-check
 exception I was seeing when trying to run java on a power6 partition.
 
 Tested on power6 and power5.
 
 Signed-Off-By:  Will Schmidt [EMAIL PROTECTED]
 ---

Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED]


___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev