Re: [Linuxwacom-devel] Cintiq: TabletPCButton = on?

2011-04-11 Thread Favux ...
Hi Jason,

It should be off for a Cintiq as far as I know.  Maybe WCM_LCD and
WCM_TPC are getting confabulated somewhere?

Favux

On Mon, Apr 11, 2011 at 1:33 PM, Jason Gerecke killert...@gmail.com wrote:
 Right now the man page indicates that TabletPCButton is 'on' for
 TabletPCs and 'off' for everything else. It appears that this option
 is also 'on' for my Cintiq 21UX. Is this just less-than-clear
 documentation, or a driver bug? I was leaning to the first (as they're
 both transparent tablets), but the default behavior under Windows
 appears to be equivalent to 'off'.

 Jason

 ---
 Day xee-nee-svsh duu-'ushtlh-ts'it;
 nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it.
 Huu-chan xuu naa~-gha.

 --
 Forrester Wave Report
 Recovery time is now measured in hours and minutes not days.
 key insights are discussed in the 2010 Forrester Wave Report as
 part of an in-depth evaluation of disaster recovery service providers.
 ___
 Linuxwacom-devel mailing list
 Linuxwacom-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


--
Forrester Wave Report - Recovery time is now measured in hours and minutes
not days. Key insights are discussed in the 2010 Forrester Wave Report as
part of an in-depth evaluation of disaster recovery service providers.
Forrester found the best-in-class provider in terms of services and vision.
Read this report now!  http://p.sf.net/sfu/ibm-webcastpromo
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel


Re: [Linuxwacom-devel] Cintiq: TabletPCButton = on?

2011-04-11 Thread Jason Gerecke
Yup, that seems to be the case. Looks like WCM_TPC is defined as
(0x200 | WCM_LCD) in an effort to ensure that the LCD feature flag
is also set. When wcmParseOptions uses TabletHasFeature to check for
Tablet PCs, LCDs are included as well.

I could remove WCM_LCD from the definition of WCM_TPC but I think the
more correct fix would actually be changing TabletHasFeature(common,
feature):

from

(((common-tablet_type)  (feature)) != 0)

to

(((common-tablet_type)  (feature)) == feature)

I'll be working on some other patches first in case anybody wants to
give some more feedback.

Jason

---
Day xee-nee-svsh duu-'ushtlh-ts'it;
nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it.
Huu-chan xuu naa~-gha.

On Mon, Apr 11, 2011 at 11:42 AM, Favux ... favux...@gmail.com wrote:
 Hi Jason,

 It should be off for a Cintiq as far as I know.  Maybe WCM_LCD and
 WCM_TPC are getting confabulated somewhere?

 Favux

 On Mon, Apr 11, 2011 at 1:33 PM, Jason Gerecke killert...@gmail.com wrote:
 Right now the man page indicates that TabletPCButton is 'on' for
 TabletPCs and 'off' for everything else. It appears that this option
 is also 'on' for my Cintiq 21UX. Is this just less-than-clear
 documentation, or a driver bug? I was leaning to the first (as they're
 both transparent tablets), but the default behavior under Windows
 appears to be equivalent to 'off'.

 Jason

 ---
 Day xee-nee-svsh duu-'ushtlh-ts'it;
 nuu-wee-ya' duu-xan' 'vm-nvshtlh-ts'it.
 Huu-chan xuu naa~-gha.



--
Forrester Wave Report - Recovery time is now measured in hours and minutes
not days. Key insights are discussed in the 2010 Forrester Wave Report as
part of an in-depth evaluation of disaster recovery service providers.
Forrester found the best-in-class provider in terms of services and vision.
Read this report now!  http://p.sf.net/sfu/ibm-webcastpromo
___
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel