Re: [Lldb-commits] [PATCH] Use accept instead of accept4 for Android.

[Vince Harron]

There are bugs in the old libs/headers.  Same toolchain.
On Jul 2, 2015 8:08 AM, "Chaoren Lin"  wrote:

> I am statically linking against API-21. There are some bugs in the old
> toolchains that can be avoided by doing this. Aside from this issue, the
> resulting binary seem to run fine on API 10 devices (and passes most of the
> test suite).
> On Jul 2, 2015 02:33, "Tamas Berghammer"  wrote:
>
>> I agree with Pavel that the toolchain shouldn't generate any source code
>> what is using a missing syscall. I checked the implementation of accept on
>> Gingerbread (API-9) and it is using the right syscall (
>> https://android.googlesource.com/platform/bionic/+/gingerbread-release/libc/arch-arm/syscalls/accept.S
>> ).
>>
>> I am not sure what is causing this issue, but one of my guess is that you
>> are statically linking against a wrong version of libc.
>>
>>
>> http://reviews.llvm.org/D10887
>>
>> EMAIL PREFERENCES
>>   http://reviews.llvm.org/settings/panel/emailpreferences/
>>
>>
>>
___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] Use accept instead of accept4 for Android.

[Pavel Labath]

Just to confirm: Which toolchain are you using to compile this? It sounds like 
the android-9 toolchain has serious problems if it produces executables that do 
not run on an android-9 device...

Also, I know that this file already has a number of #ifdefs, but this is by far 
the most complicated one. It would be good if we could bury this detail 
somewhere deep inside Host/linux or Host/android. For example, we could define 
our own Accept4 call, which normally just calls accept4, but under the right 
conditions, it would fall back to the hack you did here. Something similar to 
what we do for process_vm_readv already...


http://reviews.llvm.org/D10887

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/



___
lldb-commits mailing list
lldb-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits