[Lldb-commits] [lldb] [lldb] Disable find-module.test in case of a remote target (PR #94165)

2024-06-02 Thread Dmitry Vasilyev via lldb-commits 

https://github.com/slydiman created 
https://github.com/llvm/llvm-project/pull/94165

The target arch is `i386-pc-windows` after loading the dump. It updates to 
`i386-pc-windows-msvc` or `i386-pc-windows-gnu` in 
lldb\source\Plugins\Process\minidump\ProcessMinidump.cpp, line 218
```
GetTarget().MergeArchitecture(module->GetArchitecture());
```
But in case of the remote target (`remote-linux`) and the `Windows host` lldb 
executed the following commands at the beginning
```
platform select remote-linux
platform connect connect://:
```
and then the target arch is `i386-pc-windows-msvc` immediately after loading 
the dump. GetTarget().MergeArchitecture(module->GetArchitecture()) does not 
update it to `i386-pc-windows-gnu` when the module arch is 
`i386-pc-windows-gnu`.

>From f2064da30ae1d4dae4f04587e97ee0fdc82eb734 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev 
Date: Sun, 2 Jun 2024 21:38:12 +0400
Subject: [PATCH] [lldb] Disable find-module.test in case of a remote target

The target arch is `i386-pc-windows` after loading the dump. It updates to 
`i386-pc-windows-msvc` or `i386-pc-windows-gnu` in 
lldb\source\Plugins\Process\minidump\ProcessMinidump.cpp, line 218
```
GetTarget().MergeArchitecture(module->GetArchitecture());
```
But in case of the remote target (`remote-linux`) and the `Windows host` lldb 
executed the following commands at the beginning
```
platform select remote-linux
platform connect connect://:
```
and then the target arch is `i386-pc-windows-msvc` immediately after loading 
the dump.
GetTarget().MergeArchitecture(module->GetArchitecture()) does not update it to 
`i386-pc-windows-gnu` when the module arch is `i386-pc-windows-gnu`.
---
 lldb/test/Shell/Minidump/Windows/find-module.test | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lldb/test/Shell/Minidump/Windows/find-module.test 
b/lldb/test/Shell/Minidump/Windows/find-module.test
index 7ac2f74f8039b..b3a7ec36520f0 100644
--- a/lldb/test/Shell/Minidump/Windows/find-module.test
+++ b/lldb/test/Shell/Minidump/Windows/find-module.test
@@ -1,6 +1,8 @@
 Test that we correctly find a PE/COFF file in our executable search path, and
 use it when opening minidumps.
 
+UNSUPPORTED: remote{{.*}}
+
 RUN: yaml2obj %S/Inputs/find-module.exe.yaml -o %T/find-module.exe
 RUN: yaml2obj %S/Inputs/find-module.dmp.yaml -o %T/find-module.dmp
 RUN: %lldb -O "settings set target.exec-search-paths %T" \

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Disable find-module.test in case of a remote target (PR #94165)

2024-06-02 Thread via lldb-commits 

llvmbot wrote:




@llvm/pr-subscribers-lldb

Author: Dmitry Vasilyev (slydiman)


Changes

The target arch is `i386-pc-windows` after loading the dump. It updates to 
`i386-pc-windows-msvc` or `i386-pc-windows-gnu` in 
lldb\source\Plugins\Process\minidump\ProcessMinidump.cpp, line 218
```
GetTarget().MergeArchitecture(module->GetArchitecture());
```
But in case of the remote target (`remote-linux`) and the `Windows host` lldb 
executed the following commands at the beginning
```
platform select remote-linux
platform connect connect://:
```
and then the target arch is `i386-pc-windows-msvc` immediately after loading 
the dump. GetTarget().MergeArchitecture(module->GetArchitecture()) does not 
update it to `i386-pc-windows-gnu` when the module arch is 
`i386-pc-windows-gnu`.

---
Full diff: https://github.com/llvm/llvm-project/pull/94165.diff


1 Files Affected:

- (modified) lldb/test/Shell/Minidump/Windows/find-module.test (+2) 


``diff
diff --git a/lldb/test/Shell/Minidump/Windows/find-module.test 
b/lldb/test/Shell/Minidump/Windows/find-module.test
index 7ac2f74f8039b..b3a7ec36520f0 100644
--- a/lldb/test/Shell/Minidump/Windows/find-module.test
+++ b/lldb/test/Shell/Minidump/Windows/find-module.test
@@ -1,6 +1,8 @@
 Test that we correctly find a PE/COFF file in our executable search path, and
 use it when opening minidumps.
 
+UNSUPPORTED: remote{{.*}}
+
 RUN: yaml2obj %S/Inputs/find-module.exe.yaml -o %T/find-module.exe
 RUN: yaml2obj %S/Inputs/find-module.dmp.yaml -o %T/find-module.dmp
 RUN: %lldb -O "settings set target.exec-search-paths %T" \

``




https://github.com/llvm/llvm-project/pull/94165
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [clang][Modules] Move `ASTSourceDescriptor` into its own file (PR #67930)

2024-06-02 Thread David Stone via lldb-commits 

davidstone wrote:

Could I get someone to merge this for me if there are no other changes required?

https://github.com/llvm/llvm-project/pull/67930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixed TestEchoCommands.test running on a remote target (PR #94127)

2024-06-02 Thread Pavel Labath via lldb-commits 

labath wrote:

I'm somewhat surprised to see this. I haven't been keeping track of all of the 
latest developments, but do I understand correctly that this implies that we 
support running (all?) shell tests on a remote system?

https://github.com/llvm/llvm-project/pull/94127
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits