[Lldb-commits] [PATCH] D142241: Don't use CLANG_LIBS and LINK_COMPONENTS in lldb/tools/lldb-instr/CMakeLists.txt
jingham created this revision. jingham added reviewers: JDevlieghere, labath. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The presence of this entry causes the Xcode generator to produce two references to libLLVMSupport.a, one at the end of the list, and that causes the build to fail with a link error. The first version was pulled in when processing the CLANG_LIBS entries in the lldb/tools/lldb-instr/CMakeLists.txt. I looked around and the only places where we use LINK_COMPONENTS and CLANG_LIBS together are various lldb subdirectories that produce .a files but don't actually link anything. Anyway, this line doesn't seem to be needed for either the regular Ninja or the Xcode generator, and removing it makes the xcode build work again. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142241 Files: lldb/tools/lldb-instr/CMakeLists.txt Index: lldb/tools/lldb-instr/CMakeLists.txt === --- lldb/tools/lldb-instr/CMakeLists.txt +++ lldb/tools/lldb-instr/CMakeLists.txt @@ -11,6 +11,4 @@ clangSerialization clangTooling - LINK_COMPONENTS -Support ) Index: lldb/tools/lldb-instr/CMakeLists.txt === --- lldb/tools/lldb-instr/CMakeLists.txt +++ lldb/tools/lldb-instr/CMakeLists.txt @@ -11,6 +11,4 @@ clangSerialization clangTooling - LINK_COMPONENTS -Support ) ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D142241: Don't use CLANG_LIBS and LINK_COMPONENTS in lldb/tools/lldb-instr/CMakeLists.txt
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142241/new/ https://reviews.llvm.org/D142241 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D142241: Don't use CLANG_LIBS and LINK_COMPONENTS in lldb/tools/lldb-instr/CMakeLists.txt
This revision was automatically updated to reflect the committed changes. Closed by commit rGe12a950d90f8: Remove the LINK_COMPONENTS entry from lldb-instr CMakery (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142241/new/ https://reviews.llvm.org/D142241 Files: lldb/tools/lldb-instr/CMakeLists.txt Index: lldb/tools/lldb-instr/CMakeLists.txt === --- lldb/tools/lldb-instr/CMakeLists.txt +++ lldb/tools/lldb-instr/CMakeLists.txt @@ -11,6 +11,4 @@ clangSerialization clangTooling - LINK_COMPONENTS -Support ) Index: lldb/tools/lldb-instr/CMakeLists.txt === --- lldb/tools/lldb-instr/CMakeLists.txt +++ lldb/tools/lldb-instr/CMakeLists.txt @@ -11,6 +11,4 @@ clangSerialization clangTooling - LINK_COMPONENTS -Support ) ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D142241: Don't use CLANG_LIBS and LINK_COMPONENTS in lldb/tools/lldb-instr/CMakeLists.txt
aheejin added a comment. This broke `-sBUILD_SHARED_LIBS=ON` build: ld.lld: error: undefined symbol: llvm::errs() >>> referenced by Instrument.cpp:162 (/usr/local/google/home/aheejin/llvm-git/lldb/tools/lldb-instr/Instrument.cpp:162) >>> tools/lldb/tools/lldb-instr/CMakeFiles/lldb-instr.dir/Instrument.cpp.o:(main) ld.lld: error: undefined symbol: llvm::vfs::getRealFileSystem() >>> referenced by Instrument.cpp:171 (/usr/local/google/home/aheejin/llvm-git/lldb/tools/lldb-instr/Instrument.cpp:171) >>> tools/lldb/tools/lldb-instr/CMakeFiles/lldb-instr.dir/Instrument.cpp.o:(main) ... ... Is using `CLANG_LIBS` and `LINK_COMPONENTS Supportt` in the same file a problem? There are many files that use both: ./lldb/source/Core/CMakeLists.txt ./lldb/source/Plugins/TypeSystem/Clang/CMakeLists.txt ./lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/CMakeLists.txt ./lldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/CMakeLists.txt ./lldb/source/Plugins/ExpressionParser/Clang/CMakeLists.txt ./lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt ./lldb/source/Plugins/SymbolFile/DWARF/CMakeLists.txt ./lldb/source/Plugins/SymbolFile/NativePDB/CMakeLists.txt ./lldb/source/Plugins/SymbolFile/PDB/CMakeLists.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142241/new/ https://reviews.llvm.org/D142241 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
[Lldb-commits] [PATCH] D142241: Don't use CLANG_LIBS and LINK_COMPONENTS in lldb/tools/lldb-instr/CMakeLists.txt
aheejin added a comment. Friendly ping 😅 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142241/new/ https://reviews.llvm.org/D142241 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits