DO NOT REPLY [Bug 41980] Log4j stop updating log file- version log4j-1.2.8 and log4j-1.2.14
https://issues.apache.org/bugzilla/show_bug.cgi?id=41980 --- Comment #7 from Thorbjørn Ravn Andersen <[EMAIL PROTECTED]> 2008-08-12 04:01:46 PST --- I agree. If the contents of the log file is updated as expected then log4j is working as it should. It is up to the operating system to update metadata like the modified time of the file. Question is whether the JVM "File" can nudge Windows to update this field? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45485] Agent.java is sole dependency on jmxtools.jar with Java 5+
https://issues.apache.org/bugzilla/show_bug.cgi?id=45485 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #6 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 08:45:37 PST --- Committed last patch in rev 682879, modified to throw RuntimeException instead of Errors in rev 682998 and 683009 per discussion on log4j-dev. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43996] 1.2.15 - deadlock in Tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=43996 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||INVALID --- Comment #3 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 08:57:50 PST --- Marking as INVALID. This is a Tomcat bug, very similar to the fixed bugs 10967 and 11307. Without additional info about Tomcat version in use, it is impossible to know if this is a manifestation of those fixed bugs or a similar new bug. Since the reporter has not responded to requests for more info, it wouldn't help Tomcat to move this into their bug queue. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (LOG4J2-23) log4j 2.0 should work without an explicit configuration file
log4j 2.0 should work without an explicit configuration file Key: LOG4J2-23 URL: https://issues.apache.org/jira/browse/LOG4J2-23 Project: Log4j 2 Issue Type: Wish Components: log4j 1.2 emulation Reporter: Curt Arnold log4j 1.2 will display a warning and ignores log requests if no configuration file is found and no explicit configuration is performed. JDK 1.4 logging has a last-chance configuration file installed in the JDK. log4j 2.0 should consider delegating to JDK 1.4 logging when no configuration is available. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r685228 - in /logging/log4j/trunk/src: changes/changes.xml main/java/org/apache/log4j/Hierarchy.java site/fml/faq.fml
Author: carnold
Date: Tue Aug 12 10:03:29 2008
New Revision: 685228
URL: http://svn.apache.org/viewvc?rev=685228&view=rev
Log:
Bug 25747: more explanations when hitting WARN No appenders could be found for
logger
Modified:
logging/log4j/trunk/src/changes/changes.xml
logging/log4j/trunk/src/main/java/org/apache/log4j/Hierarchy.java
logging/log4j/trunk/src/site/fml/faq.fml
Modified: logging/log4j/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/changes/changes.xml?rev=685228&r1=685227&r2=685228&view=diff
==
--- logging/log4j/trunk/src/changes/changes.xml (original)
+++ logging/log4j/trunk/src/changes/changes.xml Tue Aug 12 10:03:29 2008
@@ -47,6 +47,7 @@
Improve warning message when log4j
is accessed after unload by Tomcat.
NullPointerException in NDC.remove
after unload by Tomcat.
Configuring triggering/rolling
policys should be supported through properties.
+ More explanations when hitting WARN
No appenders could be found for logger.
Modified: logging/log4j/trunk/src/main/java/org/apache/log4j/Hierarchy.java
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/Hierarchy.java?rev=685228&r1=685227&r2=685228&view=diff
==
--- logging/log4j/trunk/src/main/java/org/apache/log4j/Hierarchy.java (original)
+++ logging/log4j/trunk/src/main/java/org/apache/log4j/Hierarchy.java Tue Aug
12 10:03:29 2008
@@ -134,6 +134,7 @@
LogLog.warn("No appenders could be found for logger (" +
cat.getName() + ").");
LogLog.warn("Please initialize the log4j system properly.");
+ LogLog.warn("See http://logging.apache.org/log4j/1.2/faq.html#noconfig
for more info.");
this.emittedNoAppenderWarning = true;
}
}
Modified: logging/log4j/trunk/src/site/fml/faq.fml
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/site/fml/faq.fml?rev=685228&r1=685227&r2=685228&view=diff
==
--- logging/log4j/trunk/src/site/fml/faq.fml (original)
+++ logging/log4j/trunk/src/site/fml/faq.fml Tue Aug 12 10:03:29 2008
@@ -839,5 +839,22 @@
the same file path and java.io provides no mechanism to coordinate
writing
between JVM's.
+
+
+ Why do I see a warning about "No appenders found for logger" and
+ "Please configure log4j properly"?
+
+
+This occurs when the default configuration files log4j.properties
and
+log4j.xml can not be found and the application performs no
explicit configuration.
+log4j uses Thread.getContextClassLoader().getResource() to locate
the default
+configuration files and does not directly check the file system.
+Knowing the appropriate location to place log4j.properties or
log4j.xml
+requires understanding the search strategy of the class loader in
use.
+log4j does not provide a default configuration since output to the
console
+or to the file system may be prohibited in some environments.
Also see
+FAQ: Why can't log4j find my properties in a J2EE
or WAR application?.
+
+
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45527] Log4j 1.2.16 release - block this issue if a bug must be fixed in the release
https://issues.apache.org/bugzilla/show_bug.cgi?id=45527 Bug 45527 depends on bug 25747, which changed state. Bug 25747 Summary: more explanations when hitting "WARN No appenders could be found for logger" https://issues.apache.org/bugzilla/show_bug.cgi?id=25747 What|Old Value |New Value Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25747] more explanations when hitting "WARN No appenders could be found for logger"
https://issues.apache.org/bugzilla/show_bug.cgi?id=25747 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 10:03:44 PST --- Disabling logging when no configuration could be found was a explicit design issue since certain environments (such as Webapps) logging to the console is undesirable. JDK 1.4 logging has a fallback configuration file that is provided with the JDK, so it never runs into the lack of configuration problem. log4j 2.0 could possibly delegate to JDK 1.4 logging if no other configuration was found. Added issue LOG4J2-23 for that. Added a message pointing to the FAQ, but there is not much that we can easily do to display the class loader's strategy for locating resources. Committed rev 685228. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45527] Log4j 1.2.16 release - block this issue if a bug must be fixed in the release
https://issues.apache.org/bugzilla/show_bug.cgi?id=45527 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Depends on|25747, 26084, 37638, 38363, | |40246, 43313, 44157, 44308, | |44357, 44370, 44386, 44745, | |44765, 44834, 44932, 44934, | |44945, 45039, 45109, 45299 | Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #3 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 10:04:59 PST --- *** This bug has been marked as a duplicate of bug 43313 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44932] improve DailyRollingFileAppender handling of rotation errors
https://issues.apache.org/bugzilla/show_bug.cgi?id=44932 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45299] javadoc page for jdbcappender
https://issues.apache.org/bugzilla/show_bug.cgi?id=45299 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44834] SimpleSocketServer looses buffered logs, produces spurious error on exit.
https://issues.apache.org/bugzilla/show_bug.cgi?id=44834 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44945] SyslogAppender not working
https://issues.apache.org/bugzilla/show_bug.cgi?id=44945 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45039] Use Throwable.getStackTrace to obtain stack trace when JDK 1.4 or later is available
https://issues.apache.org/bugzilla/show_bug.cgi?id=45039 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43313] log4j 1.2.16 release considerations and discussion
https://issues.apache.org/bugzilla/show_bug.cgi?id=43313 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | --- Comment #7 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 10:04:59 PST --- *** Bug 45527 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 40246] HierarchyDynamicMBean missing unregister MBean
https://issues.apache.org/bugzilla/show_bug.cgi?id=40246 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 26084] Log Event detail panel does not show special characters
https://issues.apache.org/bugzilla/show_bug.cgi?id=26084 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 25747] more explanations when hitting "WARN No appenders could be found for logger"
https://issues.apache.org/bugzilla/show_bug.cgi?id=25747 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44370] MANIFEST.MF broken in log4j-1.2.15.jar
https://issues.apache.org/bugzilla/show_bug.cgi?id=44370 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44745] AsyncAppender fails on changing Throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=44745 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44934] add helper method to DailyRollingFileAppender to generate schedule file name
https://issues.apache.org/bugzilla/show_bug.cgi?id=44934 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45109] SMTPAppender uses wrong property for mail server
https://issues.apache.org/bugzilla/show_bug.cgi?id=45109 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44308] [Patch] JMX component for managing Logger configurations
https://issues.apache.org/bugzilla/show_bug.cgi?id=44308 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44386] NTEventLogAppender.dll for windows 64
https://issues.apache.org/bugzilla/show_bug.cgi?id=44386 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44765] SyslogAppender should not attempt to remove inital tabs from stack trace lines
https://issues.apache.org/bugzilla/show_bug.cgi?id=44765 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44157] InterruptedIOException ignored by log4j
https://issues.apache.org/bugzilla/show_bug.cgi?id=44157 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 37638] logging doesn't fall back with FallbackErrorHandler if PRIMARY appender is used by multiple loggers
https://issues.apache.org/bugzilla/show_bug.cgi?id=37638 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44357] List of property keys
https://issues.apache.org/bugzilla/show_bug.cgi?id=44357 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38363] SecurityException during log output
https://issues.apache.org/bugzilla/show_bug.cgi?id=38363 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|45527 | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45352] Documentation: Please update the Catalog URL for the SNMPTrapAppender
https://issues.apache.org/bugzilla/show_bug.cgi?id=45352 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 10:26:18 PST --- Updated URL in web page source in rev 685229, staged site in rev 685235. Production site updated. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45368] new log.isDebugEnabled() like method checking whether category and at least one appender are enabled for DEBUG level
https://issues.apache.org/bugzilla/show_bug.cgi?id=45368 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Comment #2 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 10:36:35 PST --- I appreciate the patch, but it doesn't seem generally useful enough to justify the changes to the log4j API at this point in the release cycle. Adding as a wish list item to log4j 2.0 (https://issues.apache.org/jira/browse/LOG4J2-24). -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (LOG4J2-24) Have an API method that does a deeper evaluation than Logger.isDebugEnabled() of whether logging will occur
Have an API method that does a deeper evaluation than Logger.isDebugEnabled() of whether logging will occur --- Key: LOG4J2-24 URL: https://issues.apache.org/jira/browse/LOG4J2-24 Project: Log4j 2 Issue Type: Wish Reporter: Curt Arnold See https://issues.apache.org/bugzilla/show_bug.cgi?id=45368 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 45344] mvn eclipse:eclipse should suggest another url for downloading jms artifact
https://issues.apache.org/bugzilla/show_bug.cgi?id=45344 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Comment #2 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 10:39:05 PST --- That URL is provided by the pom provided for javax.jms in the Maven repository. Any change should be taken up with the Maven repository team. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r685299 - /logging/log4j/trunk/src/site/fml/faq.fml
Author: carnold
Date: Tue Aug 12 13:27:20 2008
New Revision: 685299
URL: http://svn.apache.org/viewvc?rev=685299&view=rev
Log:
Bug 43313: Forgot logger arg to LogMF.debug
Modified:
logging/log4j/trunk/src/site/fml/faq.fml
Modified: logging/log4j/trunk/src/site/fml/faq.fml
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/site/fml/faq.fml?rev=685299&r1=685298&r2=685299&view=diff
==
--- logging/log4j/trunk/src/site/fml/faq.fml (original)
+++ logging/log4j/trunk/src/site/fml/faq.fml Tue Aug 12 13:27:20 2008
@@ -300,7 +300,7 @@
or using LogMF from the extras companion write
-LogMF.debug("Entry number: {0} is {1}", i, entry[i]);
+LogMF.debug(logger, "Entry number: {0} is {1}", i, entry[i]);
This way you will not incur the cost of parameter
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r685300 - in /logging/log4j/trunk/src: changes/changes.xml main/java/org/apache/log4j/spi/LocationInfo.java
Author: carnold
Date: Tue Aug 12 13:27:58 2008
New Revision: 685300
URL: http://svn.apache.org/viewvc?rev=685300&view=rev
Log:
Bug 45039: Use Throwable.getStackTrace for location on JDK 1.4 and later
Modified:
logging/log4j/trunk/src/changes/changes.xml
logging/log4j/trunk/src/main/java/org/apache/log4j/spi/LocationInfo.java
Modified: logging/log4j/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/changes/changes.xml?rev=685300&r1=685299&r2=685300&view=diff
==
--- logging/log4j/trunk/src/changes/changes.xml (original)
+++ logging/log4j/trunk/src/changes/changes.xml Tue Aug 12 13:27:58 2008
@@ -48,6 +48,7 @@
NullPointerException in NDC.remove
after unload by Tomcat.
Configuring triggering/rolling
policys should be supported through properties.
More explanations when hitting WARN
No appenders could be found for logger.
+ Use Throwable.getStackTrace to
obtain location when running on JDK 1.4 or later.
Modified:
logging/log4j/trunk/src/main/java/org/apache/log4j/spi/LocationInfo.java
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/spi/LocationInfo.java?rev=685300&r1=685299&r2=685300&view=diff
==
--- logging/log4j/trunk/src/main/java/org/apache/log4j/spi/LocationInfo.java
(original)
+++ logging/log4j/trunk/src/main/java/org/apache/log4j/spi/LocationInfo.java
Tue Aug 12 13:27:58 2008
@@ -19,10 +19,12 @@
package org.apache.log4j.spi;
-import java.io.StringWriter;
-import java.io.PrintWriter;
-import org.apache.log4j.helpers.LogLog;
import org.apache.log4j.Layout;
+import org.apache.log4j.helpers.LogLog;
+
+import java.io.PrintWriter;
+import java.io.StringWriter;
+import java.lang.reflect.Method;
/**
The internal representation of caller location information.
@@ -56,6 +58,13 @@
private static StringWriter sw = new StringWriter();
private static PrintWriter pw = new PrintWriter(sw);
+ private static Method getStackTraceMethod;
+ private static Method getClassNameMethod;
+ private static Method getMethodNameMethod;
+ private static Method getFileNameMethod;
+ private static Method getLineNumberMethod;
+
+
/**
When location information is not available the constant
NA is returned. Current value of this string
@@ -82,6 +91,17 @@
} catch(Throwable e) {
// nothing to do
}
+ try {
+ Class[] noArgs = null;
+ getStackTraceMethod = Throwable.class.getMethod("getStackTrace",
noArgs);
+ Class stackTraceElementClass =
Class.forName("java.lang.StackTraceElement");
+ getClassNameMethod =
stackTraceElementClass.getMethod("getClassName", noArgs);
+ getMethodNameMethod =
stackTraceElementClass.getMethod("getMethodName", noArgs);
+ getFileNameMethod = stackTraceElementClass.getMethod("getFileName",
noArgs);
+ getLineNumberMethod =
stackTraceElementClass.getMethod("getLineNumber", noArgs);
+ } catch(Exception ex) {
+ LogLog.debug("LocationInfo will use pre-JDK 1.4 methods to determine
location.");
+ }
}
/**
@@ -101,11 +121,48 @@
However, we can also deal with JIT compilers that "lose" the
location information, especially between the parentheses.
+@param t throwable used to determine location, may be null.
+@param fqnOfCallingClass class name of first class considered part of
+ the logging framework. Location will be site that calls a method
on this class.
*/
public LocationInfo(Throwable t, String fqnOfCallingClass) {
if(t == null || fqnOfCallingClass == null)
return;
+ if (getLineNumberMethod != null) {
+ try {
+ boolean hitCaller = false;
+ Object[] noArgs = null;
+ Object[] elements = (Object[]) getStackTraceMethod.invoke(t,
noArgs);
+ for(int i = 0; i < elements.length; i++) {
+ String thisClass =
String.valueOf(getClassNameMethod.invoke(elements[i], noArgs));
+ boolean isCaller = thisClass.equals(fqnOfCallingClass);
+ if (hitCaller) {
+ if(!isCaller) {
+ className = thisClass;
+ methodName = (String)
getMethodNameMethod.invoke(elements[i], noArgs);
+ fileName = (String)
getFileNameMethod.invoke(elements[i], noArgs);
+ if (fileName == null) {
+ fileName = NA;
+ }
+ int line = ((Integer)
getLineNumberMethod.invoke(elements[i], noArgs)).intValue();
+ if (line < 0) {
+ lineNumber = NA;
+ } else {
+
DO NOT REPLY [Bug 45039] Use Throwable.getStackTrace to obtain stack trace when JDK 1.4 or later is available
https://issues.apache.org/bugzilla/show_bug.cgi?id=45039 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 13:28:23 PST --- Committed rev 685300. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r685304 - in /logging/log4j/trunk/src: changes/changes.xml main/java/org/apache/log4j/AsyncAppender.java
Author: carnold
Date: Tue Aug 12 13:33:32 2008
New Revision: 685304
URL: http://svn.apache.org/viewvc?rev=685304&view=rev
Log:
Bug 44745: AsyncAppender fails on changing Throwable
Modified:
logging/log4j/trunk/src/changes/changes.xml
logging/log4j/trunk/src/main/java/org/apache/log4j/AsyncAppender.java
Modified: logging/log4j/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/changes/changes.xml?rev=685304&r1=685303&r2=685304&view=diff
==
--- logging/log4j/trunk/src/changes/changes.xml (original)
+++ logging/log4j/trunk/src/changes/changes.xml Tue Aug 12 13:33:32 2008
@@ -49,6 +49,7 @@
Configuring triggering/rolling
policys should be supported through properties.
More explanations when hitting WARN
No appenders could be found for logger.
Use Throwable.getStackTrace to
obtain location when running on JDK 1.4 or later.
+ AsyncAppender fails on changing
Throwable.
Modified: logging/log4j/trunk/src/main/java/org/apache/log4j/AsyncAppender.java
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/AsyncAppender.java?rev=685304&r1=685303&r2=685304&view=diff
==
--- logging/log4j/trunk/src/main/java/org/apache/log4j/AsyncAppender.java
(original)
+++ logging/log4j/trunk/src/main/java/org/apache/log4j/AsyncAppender.java Tue
Aug 12 13:33:32 2008
@@ -159,6 +159,7 @@
event.getLocationInformation();
}
event.getRenderedMessage();
+event.getThrowableStrRep();
synchronized (buffer) {
while (true) {
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44745] AsyncAppender fails on changing Throwable
https://issues.apache.org/bugzilla/show_bug.cgi?id=44745 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 13:33:54 PST --- Committed rev 685304. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r685308 - in /logging/log4j/trunk/src: changes/changes.xml main/java/org/apache/log4j/xml/DOMConfigurator.java
Author: carnold
Date: Tue Aug 12 13:46:09 2008
New Revision: 685308
URL: http://svn.apache.org/viewvc?rev=685308&view=rev
Log:
Bug 44899: Extra NPE error message when using missing appender class with
DOMConfigurator
Modified:
logging/log4j/trunk/src/changes/changes.xml
logging/log4j/trunk/src/main/java/org/apache/log4j/xml/DOMConfigurator.java
Modified: logging/log4j/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/changes/changes.xml?rev=685308&r1=685307&r2=685308&view=diff
==
--- logging/log4j/trunk/src/changes/changes.xml (original)
+++ logging/log4j/trunk/src/changes/changes.xml Tue Aug 12 13:46:09 2008
@@ -50,6 +50,7 @@
More explanations when hitting WARN
No appenders could be found for logger.
Use Throwable.getStackTrace to
obtain location when running on JDK 1.4 or later.
AsyncAppender fails on changing
Throwable.
+ Extra NPE error message when using
missing appender class with DOMConfigurator.
Modified:
logging/log4j/trunk/src/main/java/org/apache/log4j/xml/DOMConfigurator.java
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/xml/DOMConfigurator.java?rev=685308&r1=685307&r2=685308&view=diff
==
--- logging/log4j/trunk/src/main/java/org/apache/log4j/xml/DOMConfigurator.java
(original)
+++ logging/log4j/trunk/src/main/java/org/apache/log4j/xml/DOMConfigurator.java
Tue Aug 12 13:46:09 2008
@@ -167,9 +167,11 @@
LogLog.error("No appender named ["+appenderName+"] could be found.");
return null;
} else {
- appender = parseAppender(element);
- appenderBag.put(appenderName, appender);
- return appender;
+ appender = parseAppender(element);
+ if (appender != null) {
+appenderBag.put(appenderName, appender);
+ }
+return appender;
}
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r685312 - in /logging/log4j/companions/extras/trunk/src: changes/changes.xml main/java/org/apache/log4j/extras/DOMConfigurator.java
Author: carnold
Date: Tue Aug 12 13:50:29 2008
New Revision: 685312
URL: http://svn.apache.org/viewvc?rev=685312&view=rev
Log:
Bug 44899: Extra NPE error message when using missing appender class with
DOMConfigurator
Modified:
logging/log4j/companions/extras/trunk/src/changes/changes.xml
logging/log4j/companions/extras/trunk/src/main/java/org/apache/log4j/extras/DOMConfigurator.java
Modified: logging/log4j/companions/extras/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/logging/log4j/companions/extras/trunk/src/changes/changes.xml?rev=685312&r1=685311&r2=685312&view=diff
==
--- logging/log4j/companions/extras/trunk/src/changes/changes.xml (original)
+++ logging/log4j/companions/extras/trunk/src/changes/changes.xml Tue Aug 12
13:50:29 2008
@@ -22,6 +22,7 @@
Mangled
source-repository.html
+ Extra NPE error message when using
missing appender class with DOMConfigurator.
Modified:
logging/log4j/companions/extras/trunk/src/main/java/org/apache/log4j/extras/DOMConfigurator.java
URL:
http://svn.apache.org/viewvc/logging/log4j/companions/extras/trunk/src/main/java/org/apache/log4j/extras/DOMConfigurator.java?rev=685312&r1=685311&r2=685312&view=diff
==
---
logging/log4j/companions/extras/trunk/src/main/java/org/apache/log4j/extras/DOMConfigurator.java
(original)
+++
logging/log4j/companions/extras/trunk/src/main/java/org/apache/log4j/extras/DOMConfigurator.java
Tue Aug 12 13:50:29 2008
@@ -150,9 +150,11 @@
LogLog.error("No appender named ["+appenderName+"] could be found.");
return null;
} else {
- appender = parseAppender(element);
- appenderBag.put(appenderName, appender);
- return appender;
+ appender = parseAppender(element);
+if (appender != null) {
+appenderBag.put(appenderName, appender);
+}
+return appender;
}
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44899] DOMConfigurator.findAppenderByName causes Nullpointer
https://issues.apache.org/bugzilla/show_bug.cgi?id=44899 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 13:51:11 PST --- Committed rev 685308 in trunk, 685312 for extras. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43867] NOPLoggerRepository error during shutdown
https://issues.apache.org/bugzilla/show_bug.cgi?id=43867 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r685316 - in /logging/log4j/trunk/src: changes/changes.xml main/java/org/apache/log4j/varia/NullAppender.java
Author: carnold
Date: Tue Aug 12 14:02:38 2008
New Revision: 685316
URL: http://svn.apache.org/viewvc?rev=685316&view=rev
Log:
Bug 44555: org.apache.log4j.varia.NullAppender lacks static accessor to static
instance
Modified:
logging/log4j/trunk/src/changes/changes.xml
logging/log4j/trunk/src/main/java/org/apache/log4j/varia/NullAppender.java
Modified: logging/log4j/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/changes/changes.xml?rev=685316&r1=685315&r2=685316&view=diff
==
--- logging/log4j/trunk/src/changes/changes.xml (original)
+++ logging/log4j/trunk/src/changes/changes.xml Tue Aug 12 14:02:38 2008
@@ -51,6 +51,7 @@
Use Throwable.getStackTrace to
obtain location when running on JDK 1.4 or later.
AsyncAppender fails on changing
Throwable.
Extra NPE error message when using
missing appender class with DOMConfigurator.
+ org.apache.log4j.varia.NullAppender
lacks static accessor to static instance.
Modified:
logging/log4j/trunk/src/main/java/org/apache/log4j/varia/NullAppender.java
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/varia/NullAppender.java?rev=685316&r1=685315&r2=685316&view=diff
==
--- logging/log4j/trunk/src/main/java/org/apache/log4j/varia/NullAppender.java
(original)
+++ logging/log4j/trunk/src/main/java/org/apache/log4j/varia/NullAppender.java
Tue Aug 12 14:02:38 2008
@@ -41,11 +41,20 @@
/**
* Whenever you can, use this method to retreive an instance instead
* of instantiating a new one with new.
+ * @deprecated Use getNullAppender instead. getInstance should have been
static.
* */
public NullAppender getInstance() {
return instance;
}
+/**
+ * Whenever you can, use this method to retreive an instance instead
+ * of instantiating a new one with new.
+ * */
+ public static NullAppender getNullAppender() {
+ return instance;
+ }
+
public void close() {
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44555] com.apache.log4j.varia.NullAppender lack static accessor to static instance
https://issues.apache.org/bugzilla/show_bug.cgi?id=44555 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 14:04:14 PST --- Changing getInstance() from a member method to a static method would be an API change. There is the unlikely possibility that someone overloaded the method and would not take kindly to the change. I added a static getNullAppender() method and marked getInstance() as deprecated. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44765] SyslogAppender should not attempt to remove inital tabs from stack trace lines
https://issues.apache.org/bugzilla/show_bug.cgi?id=44765
Curt Arnold <[EMAIL PROTECTED]> changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution||INVALID
--- Comment #3 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 14:42:43 PST ---
Tab characters are prohibited in the MESSAGE section of the packet (see
http://www.ietf.org/rfc/rfc3164.txt?number=3164) along with all other
non-printable characters.
The code fragment that is suggested to be changed does not appear in the
current SVN HEAD (and as far back as the fix for bug 40502) as I can tell. The
current code is:
String[] s = event.getThrowableStrRep();
if (s != null) {
for(int i = 0; i < s.length; i++) {
if (s[i].startsWith("\t")) {
sqw.write(hdr+TAB+s[i].substring(1));
} else {
sqw.write(hdr+s[i]);
}
}
}
This should replace any leading tab in the stack trace with the value of
SyslogAppender.TAB (which is initialized at four spaces).
The current code does not address cases where non-printable characters appear
in other positions, but it does appear to do the best possible when the stack
trace starts with a single tab character (which is a common in mainstream
JVM's). As far as I can tell, the behavior described in the bug report should
not occur with the current SVN head, and I'm going to mark the bug as INVALID.
If I've misunderstood, please reopen after testing with the SVN HEAD and
providing a patch against the current SVN HEAD.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 43849] getName on Appender returns null
https://issues.apache.org/bugzilla/show_bug.cgi?id=43849 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #1 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 14:47:51 PST --- Committed change to Javadoc in rev 685331. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r685331 - in /logging/log4j/trunk/src: changes/changes.xml main/java/org/apache/log4j/Appender.java main/java/org/apache/log4j/AppenderSkeleton.java
Author: carnold Date: Tue Aug 12 14:47:30 2008 New Revision: 685331 URL: http://svn.apache.org/viewvc?rev=685331&view=rev Log: Bug 43849: Javadoc for Appender.getName implies return value will be unique and not null. Modified: logging/log4j/trunk/src/changes/changes.xml logging/log4j/trunk/src/main/java/org/apache/log4j/Appender.java logging/log4j/trunk/src/main/java/org/apache/log4j/AppenderSkeleton.java Modified: logging/log4j/trunk/src/changes/changes.xml URL: http://svn.apache.org/viewvc/logging/log4j/trunk/src/changes/changes.xml?rev=685331&r1=685330&r2=685331&view=diff == --- logging/log4j/trunk/src/changes/changes.xml (original) +++ logging/log4j/trunk/src/changes/changes.xml Tue Aug 12 14:47:30 2008 @@ -52,6 +52,7 @@ AsyncAppender fails on changing Throwable. Extra NPE error message when using missing appender class with DOMConfigurator. org.apache.log4j.varia.NullAppender lacks static accessor to static instance. + Javadoc for Appender.getName implies that the return value will be unique and not null. Modified: logging/log4j/trunk/src/main/java/org/apache/log4j/Appender.java URL: http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/Appender.java?rev=685331&r1=685330&r2=685331&view=diff == --- logging/log4j/trunk/src/main/java/org/apache/log4j/Appender.java (original) +++ logging/log4j/trunk/src/main/java/org/apache/log4j/Appender.java Tue Aug 12 14:47:30 2008 @@ -74,8 +74,8 @@ /** - Get the name of this appender. The name uniquely identifies the - appender. */ + Get the name of this appender. + @return name, may be null.*/ public String getName(); Modified: logging/log4j/trunk/src/main/java/org/apache/log4j/AppenderSkeleton.java URL: http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/AppenderSkeleton.java?rev=685331&r1=685330&r2=685331&view=diff == --- logging/log4j/trunk/src/main/java/org/apache/log4j/AppenderSkeleton.java (original) +++ logging/log4j/trunk/src/main/java/org/apache/log4j/AppenderSkeleton.java Tue Aug 12 14:47:30 2008 @@ -189,7 +189,8 @@ /** - Returns the name of this FileAppender. + Returns the name of this appender. + @return name, may be null. */ public final - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
svn commit: r685338 - in /logging/log4j/trunk: src/changes/changes.xml src/main/java/org/apache/log4j/DailyRollingFileAppender.java tests/src/java/org/apache/log4j/DRFATestCase.java
Author: carnold
Date: Tue Aug 12 15:04:51 2008
New Revision: 685338
URL: http://svn.apache.org/viewvc?rev=685338&view=rev
Log:
Bug 40888: Weekly rotation problem in Europe
Modified:
logging/log4j/trunk/src/changes/changes.xml
logging/log4j/trunk/src/main/java/org/apache/log4j/DailyRollingFileAppender.java
logging/log4j/trunk/tests/src/java/org/apache/log4j/DRFATestCase.java
Modified: logging/log4j/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/changes/changes.xml?rev=685338&r1=685337&r2=685338&view=diff
==
--- logging/log4j/trunk/src/changes/changes.xml (original)
+++ logging/log4j/trunk/src/changes/changes.xml Tue Aug 12 15:04:51 2008
@@ -53,6 +53,7 @@
Extra NPE error message when using
missing appender class with DOMConfigurator.
org.apache.log4j.varia.NullAppender
lacks static accessor to static instance.
Javadoc for Appender.getName implies
that the return value will be unique and not null.
+ Weekly rotation problem in
Europe.
Modified:
logging/log4j/trunk/src/main/java/org/apache/log4j/DailyRollingFileAppender.java
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/DailyRollingFileAppender.java?rev=685338&r1=685337&r2=685338&view=diff
==
---
logging/log4j/trunk/src/main/java/org/apache/log4j/DailyRollingFileAppender.java
(original)
+++
logging/log4j/trunk/src/main/java/org/apache/log4j/DailyRollingFileAppender.java
Tue Aug 12 15:04:51 2008
@@ -270,7 +270,7 @@
// GMT (the epoch).
int computeCheckPeriod() {
-RollingCalendar rollingCalendar = new RollingCalendar(gmtTimeZone,
Locale.ENGLISH);
+RollingCalendar rollingCalendar = new RollingCalendar(gmtTimeZone,
Locale.getDefault());
// set sate to 1970-01-01 00:00:00 GMT
Date epoch = new Date(0);
if(datePattern != null) {
Modified: logging/log4j/trunk/tests/src/java/org/apache/log4j/DRFATestCase.java
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/tests/src/java/org/apache/log4j/DRFATestCase.java?rev=685338&r1=685337&r2=685338&view=diff
==
--- logging/log4j/trunk/tests/src/java/org/apache/log4j/DRFATestCase.java
(original)
+++ logging/log4j/trunk/tests/src/java/org/apache/log4j/DRFATestCase.java Tue
Aug 12 15:04:51 2008
@@ -502,5 +502,16 @@
"witness/drfa_blockedRollover.log"));
}
+/** Check that the computed rollover period for a pattern containing a
week as the finest unit is set to be
+ * a week. Due to a locale mismatch this was incorrect in non-English
locales. See bug 40888.
+ *
+ */
+public void testWeeklyRollover() {
+DailyRollingFileAppender drfa = new DailyRollingFileAppender();
+ drfa.setDatePattern("'.'-ww");
+ int checkPeriod = drfa.computeCheckPeriod();
+ assertEquals(DailyRollingFileAppender.TOP_OF_WEEK, checkPeriod);
+}
+
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 40888] Weekly rotation problem in Europe
https://issues.apache.org/bugzilla/show_bug.cgi?id=40888 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||FIXED --- Comment #5 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 15:06:25 PST --- Committed slightly different change in 685338. Attached patches changed the signature of RollingCalendar which is not private so would be considered a breaking API change. Was simpler just to pass Locale.getDefault() instead of Locale.ENGLISH in the call to new RollingCalendar. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 40350] DailyRollingFileAppender should not write Layout header on resume
https://issues.apache.org/bugzilla/show_bug.cgi?id=40350 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #1 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 15:19:52 PST --- Marking as duplicate of 34651 though the appear to ask for conflicting things. *** This bug has been marked as a duplicate of bug 34651 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34651] allow for a header on top of every rolled file
https://issues.apache.org/bugzilla/show_bug.cgi?id=34651 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #1 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 15:19:52 PST --- *** Bug 40350 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 40349] RollingFileAppenders do not getFooter() from Layout
https://issues.apache.org/bugzilla/show_bug.cgi?id=40349 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #2 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 15:22:48 PST --- Marking as duplicate of 34651. All header and footer enhancements should be considered together and likely only in org.apache.log4j.rolling.RFA and not in the earlier org.apache.log4j.RFA and DRFA. *** This bug has been marked as a duplicate of bug 34651 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34651] allow for a header on top of every rolled file
https://issues.apache.org/bugzilla/show_bug.cgi?id=34651 --- Comment #2 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 15:22:48 PST --- *** Bug 40349 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 34651] allow for a header on top of every rolled file
https://issues.apache.org/bugzilla/show_bug.cgi?id=34651 --- Comment #3 from quartz <[EMAIL PROTECTED]> 2008-08-12 19:02:11 PST --- Just a warning for developers, there seems to be a set header and set footer on some appenders, but although these methods exist, they do not perform the required task. Meanwhile, it is not always a matter of writing the header when the appender opens, and the footer when the appender closes. It is sometimes a matter of producing a file that has only 1 header and/or only 1 footer. This means the appender must open and read the file before being ready for appending it. Overall, there is the following desired features: -inject a header when appender is opening -inject a header when file is opening -inject a footer when appender is closing -inject a footer when file is closing (with the garanty that there wouldn't be any further appending) Therefore I suggest the following distinct attribute: a) file header b) session header c) session footer d) file footer Implementation of b) and c) are trivial. For the implementation of a), it is not really time consuming to read the beginning of the file to detect the existence of the file header. It could be only to test if file is of length>0, unless you can find any reason not to implement it this way first. After all the appender could be using a tight binary format, with a header of 1 byte! For the implementation of d), it is possibly a performance tax to read the file to discover if a footer exists (not to mention the difficulty to prove the end of the file is a footer and not data), in order to remove it and append over there. The behavior in presence of an existing footer could be left to the implementor of the header/footer-able-appender subclass: -never append an existing file and always roll to another file -test for perfect equality between intended footer and existing tail part of file -etc... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38363] SecurityException during log output
https://issues.apache.org/bugzilla/show_bug.cgi?id=38363 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #4 from Curt Arnold <[EMAIL PROTECTED]> 2008-08-12 22:01:03 PST --- Adding a try block around callAppenders could have performance implications. Also, in a perfect world, you would not want the failure of one appender to cause the rest to fail, so if you were going to do that, you'd want to do in within callAppenders. The implicit appender contract is that Appenders don't let anything percolate out of their append method. The RFAs are particular prone to to SecurityExceptions due to their file renaming. However, it probably would be best just to fix this in org.apache.log4j.rolling.RFA in the extras and not in DRFA and RFA since there are known problems in them that are fixed in o.a.l.r.RFA and they offer no functionality not in o.a.l.r.RFA. However, if someone wants to submit a patch against o.a.l.RFA and DRFA that is fairly clean, I would not object. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 44867] DailyRollingFileAppender: log4j: inconsistency in generating logs
https://issues.apache.org/bugzilla/show_bug.cgi?id=44867 Curt Arnold <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution||WONTFIX -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
log4j 1.2.16 release plan
I'd like to address the following bugs and then get an RC1 for log4j 1.2.16 out https://issues.apache.org/bugzilla/show_bug.cgi?id=37638 https://issues.apache.org/bugzilla/show_bug.cgi?id=44157 https://issues.apache.org/bugzilla/show_bug.cgi?id=44386 https://issues.apache.org/bugzilla/show_bug.cgi?id=38363 Making NTEventLogAppender usable in both Win32 and Win64 while not dying a horrible death if the old DLL is found is probably up to me. However, if anyone wants to work on the others and submit a patch, please feel free. If there are any other bugs that should be addressed, please provide a patch or at least an analysis to the bug and let the list know your feelings. As far as I can tell (Bugzilla doesn't seem to allow you to query), there isn't an open bug with a supplied patch. Please do not include bugs that apply to extras, receivers or chainsaw. Just concerned with bugs that affect log4j 1.2 itself. I've thinking it is likely that we may run into problems with the geronimo artifacts on earlier JVM's. May have to hack the pom.xml and rebuild to get compatible bytecode. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
