Re: svn commit: r909868 - in /logging/log4j/trunk: src/changes/ src/main/java/org/apache/log4j/ src/main/java/org/apache/log4j/helpers/ tests/src/java/org/apache/log4j/ tests/witness/
On 14/02/2010 7:05 AM, Curt Arnold wrote: On Feb 13, 2010, at 3:58 PM, Ceki Gülcü wrote: Isn't the write method in PrudentWriter (see [1]) a copy-and-paste of code safeWrite() method in logback's FileAppender (see [2])? [1] http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/helpers/PrudentWriter.java?revision=909868&view=markup&pathrev=909918 [2] http://github.com/ceki/logback/blob/master/logback-core/src/main/java/ch/qos/logback/core/FileAppender.java http://issues.apache.org/bugzilla/show_bug.cgi?id=48704 > The process that I followed was to examine to the logback code to > determine what prudent mode was, which I then described as part of the > bug report and then implemented from the description. The fragments > are similar since there aren't that many ways to get a lock on a > channel, reposition the channel to the end of the file, write a > string, and release a lock. What a load of horse crap. The prudent mode feature in logback was requested by a paying customer. It took me a week, working full-time, to bring the code and its accompanying battery of tests to its current state. You got a there in a few hours and proceeded to resolve 5 other log4j bugs all in the same evening. You must be a genius. While it is probably not possible to refactor the locking code to make it clearer, it took me several iterations to get there. More to the point, it relies on the fact that the channel.size() operation *always* returns the correct file size. Now, given that the size() method in java.io.File class can return *inaccurate* results for several *seconds* after the cessation of all I/O activity on a given file, it is completely non-obvious and frankly quite miraculous that my locking code should work at all. Contrary to your claim, one can have confidence that the locking code actually works only after performing a large battery of tests. Logback ships with several hundred lines of code testing the locking code in prudent mode, which I happened to execute for several days before gaining confidence in its reliability. In contrast, your commit does not come with any tests at all. You picked the wrong logback feature to rip off. You can persists in denying the obvious or come to your senses. I suggest you privately contact the board or maybe Ralph Goers who is quite knowledgeable about these matters to get counseling about the seriousness of your predicament. You are also in violation of sections 4 and 5 of the ICLA document you signed as an Apache committer. The Apache foundation is unlikely to condone your personal copyright infringement implicating the foundation. Before this matter gets out of hand with regrettable consequences, I expect you to: 1) immediately revert commit 909868 2) post a public apology to this list and promise to refrain from similar copyright infringement in the future. -- Ceki Gülcü - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
Re: svn commit: r909868 - in /logging/log4j/trunk: src/changes/ src/main/java/org/apache/log4j/ src/main/java/org/apache/log4j/helpers/ tests/src/java/org/apache/log4j/ tests/witness/
Ceki Gülcü skrev: > The process that I followed was to examine to the logback code to > determine what prudent mode was, which I then described as part of the > bug report and then implemented from the description. The fragments > are similar since there aren't that many ways to get a lock on a > channel, reposition the channel to the end of the file, write a > string, and release a lock. What a load of horse crap. The prudent mode feature in logback was requested by a paying customer. It took me a week, working full-time, to bring the code and its accompanying battery of tests to its current state. You got a there in a few hours and proceeded to resolve 5 other log4j bugs all in the same evening. You must be a genius. From what I see in the code the actual method implementing this facility is less than 20 lines of code. I fully understand that these lines of code may have been extremely hard to get right. The question here is then - if the code wasn't copy-pasted but understood and then described in wording in the bug as Curt said, and the implementation done from the description in the bug, wouldn't this be perfectly fine? Since the code base around the method in question basically has the same heritage - you might even call it a backport from log4j version 2 to log4j version 1.2, it would to me seem quite reasonable to expect that the resulting code would be similar. -- Thorbjørn Ravn Andersen "...plus... Tubular Bells!" - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
Bug report for Log4j [2010/02/14]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |13099|Opn|Nor|2002-09-27|DOMConfigurator ignores category factory setting | |17887|Opn|Maj|2003-03-11|RollingFileAppender does not work for 10 threads | |20395|Inf|Enh|2003-06-01|PreparedStatementAppender Enhancement | |23329|New|Enh|2003-09-22| element in XML config should support reso| |26084|Inf|Nor|2004-01-13|Log Event detail panel does not show special chara| |27363|Inf|Enh|2004-03-02|JNI based SyslogAppender | |27367|Inf|Enh|2004-03-02|NetSendAppender | |29244|Inf|Nor|2004-05-27|Preserve XML content in log messages when using XM| |29305|New|Nor|2004-05-30|Chainsaw doesn't see locationinfo from XMLSocketRe| |30055|New|Nor|2004-07-12|Problem with registering Appenders with the same n| |30407|Inf|Maj|2004-07-30|Externally rolled file problem| |30888|New|Maj|2004-08-27|Chainsaw mixes files in same panel| |30892|New|Min|2004-08-27|Log files cannot be closed| |31089|New|Nor|2004-09-07|Does not accept ISO8601 dates in focus field | |31178|Inf|Cri|2004-09-11|Exception using Chainsaw for simple debugging | |31179|Ass|Enh|2004-09-11|Implement Chainsaw as Eclipse stand-alone applicat| |33278|New|Min|2005-01-27|NPE thrown durring daily log file rollover| |33493|Inf|Enh|2005-02-10|contribution to log4j: servlet diagnostic context | |34440|New|Nor|2005-04-13|sandbox:IMAppender - comma-seperated recipient lis| |34491|Ver|Nor|2005-04-18|Missing include in build.jms target results in mis| |34651|New|Enh|2005-04-27|allow for a header on top of every rolled file| |34738|Inf|Nor|2005-05-04|Chainsaw does not remember what Columns are select| |34945|Inf|Nor|2005-05-17|ThrowableInformation has dubious Stack Trace extra| |34974|Inf|Cri|2005-05-19|Exception when running a Pluglet | |35239|Inf|Nor|2005-06-06|NullPointerException when saving displayed events | |35563|Inf|Enh|2005-06-30|Syslog appender parametrability | |35996|Inf|Enh|2005-08-03|Add support for ant-like in log4j.xml | |36435|New|Enh|2005-08-31|Log4J RollingFileAppender under OpenVMS does not f| |36654|Inf|Min|2005-09-14|Provide better error messages for "Please initiali| |36789|Inf|Nor|2005-09-23|Empty control flow statement in org.apache.log4j.l| |37349|Ass|Nor|2005-11-03|DBAppender not working with jTDS driver | |37638|New|Nor|2005-11-25|logging doesn't fall back with FallbackErrorHandle| |37734|Inf|Nor|2005-12-01|Customize Event ID and Event Category with NTEVent| |38363|Ass|Nor|2006-01-24|SecurityException during log output | |38394|Ver|Enh|2006-01-26|PropertySetter fails to print stacktrace if error | |38395|Ver|Reg|2006-01-26|Unable to set threshold on appender via config fil| |38406|Ver|Nor|2006-01-26|jdk1.4 dependencies in log4j 1.3 alpha| |38513|New|Nor|2006-02-05|[PATCH] Suggested unit test for JMSAppender | |38582|Ass|Nor|2006-02-08|Chainsaw does not include Receiver JavaDoc in dist| |38590|Inf|Nor|2006-02-09|no space on device fails another instance | |38883|Opn|Nor|2006-03-07|LogFilePatternReceiver fails to process multi-line| |39690|Inf|Cri|2006-05-31|Initialization fail in J2EE Environment | |39691|Ass|Nor|2006-05-31|DBAppender doesn't log long events| |40068|New|Nor|2006-07-18|Add support for attach-on-demand API to chainsaw | |40124|New|Min|2006-07-27|startup (JWS) does not initialize ignored elements| |40251|Opn|Min|2006-08-14|Hard coded JMX domain name for MBean instances| |40382|Inf|Maj|2006-09-01|Sysappender hangs during boot time on HP | |40385|Inf|Maj|2006-09-01|SocketServer cannot find config file when passed a| |40472|New|Nor|2006-09-11|SettingsManager calls loadSettings with global set| |40533|New|Nor|2006-09-18|Chainsaw not showing all logging statements | |40570|Inf|Blk|2006-09-21|RollingFileAppender does not rollover when the fil| |40611|New|Trv|2006-09-27
svn commit: r910149 - /logging/log4j/trunk/pom.xml
Author: carnold Date: Mon Feb 15 01:31:39 2010 New Revision: 910149 URL: http://svn.apache.org/viewvc?rev=910149&view=rev Log: Bug 43282: Tweak OSGi package info Modified: logging/log4j/trunk/pom.xml Modified: logging/log4j/trunk/pom.xml URL: http://svn.apache.org/viewvc/logging/log4j/trunk/pom.xml?rev=910149&r1=910148&r2=910149&view=diff == --- logging/log4j/trunk/pom.xml (original) +++ logging/log4j/trunk/pom.xml Mon Feb 15 01:31:39 2010 @@ -408,6 +408,9 @@ javax.mail.*;resolution:=optional, javax.management;resolution:=optional, javax.naming;resolution:=optional, +com.sun.jdmk.comm;resolution:=optional, +com.ibm.uvm.tools;resolution:=optional, +javax.swing.*;resolution:=optional, * http://logging.apache.org/log4j/1.2 - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
svn commit: r910151 - in /logging/log4j/trunk: src/changes/ src/main/java/org/apache/log4j/ src/main/java/org/apache/log4j/helpers/ tests/src/java/org/apache/log4j/ tests/witness/
Author: carnold
Date: Mon Feb 15 01:45:20 2010
New Revision: 910151
URL: http://svn.apache.org/viewvc?rev=910151&view=rev
Log:
Bug 48704: Reverting commits 909868,909918 to defer issue post 1.2.16
Modified:
logging/log4j/trunk/src/changes/changes.xml
logging/log4j/trunk/src/main/java/org/apache/log4j/FileAppender.java
logging/log4j/trunk/src/main/java/org/apache/log4j/helpers/PrudentWriter.java
logging/log4j/trunk/tests/src/java/org/apache/log4j/FileAppenderTest.java
logging/log4j/trunk/tests/src/java/org/apache/log4j/MinimumTestCase.java
logging/log4j/trunk/tests/witness/prudent
Modified: logging/log4j/trunk/src/changes/changes.xml
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/changes/changes.xml?rev=910151&r1=910150&r2=910151&view=diff
==
--- logging/log4j/trunk/src/changes/changes.xml (original)
+++ logging/log4j/trunk/src/changes/changes.xml Mon Feb 15 01:45:20 2010
@@ -94,7 +94,6 @@
Typo ("two three goals") in log4j
FAQ
Unit tests fail for system dates
after 2009-12-31
Download page does not have link to
KEYS file
- Add purient mode to
FileAppender.
Modified: logging/log4j/trunk/src/main/java/org/apache/log4j/FileAppender.java
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/FileAppender.java?rev=910151&r1=910150&r2=910151&view=diff
==
--- logging/log4j/trunk/src/main/java/org/apache/log4j/FileAppender.java
(original)
+++ logging/log4j/trunk/src/main/java/org/apache/log4j/FileAppender.java Mon
Feb 15 01:45:20 2010
@@ -65,12 +65,6 @@
* Determines the size of IO buffer be. Default is 8K.
*/
protected int bufferSize = 8*1024;
-
- /**
- * Determines whether "prudent" mode used.
- * @since 1.2.16
- */
- private boolean prudent = false;
/**
@@ -265,44 +259,6 @@
void setBufferSize(int bufferSize) {
this.bufferSize = bufferSize;
}
-
- /**
- * Determines if the FileAppender should attempt to use
- * java.nio.FileChannel.lock to gain exclusive access
- * to the file during write operations. The effectiveness
- * and performance impact is JVM and operating system dependent.
- * Avoiding concurrent writes to the same file by appenders
- * and streams either within or outside a single JVM
- * is recommended.
- *
- * Prudent mode requires JDK 1.4 or later.
- *
- * @return true if prudent mode is enabled.
- * @since 1.2.16
- */
- public final boolean isPrudent() {
- return prudent;
- }
-
- /**
- * Sets if the FileAppender should attempt to use
- * java.nio.FileChannel.lock to gain exclusive access
- * to the file during write operations. The effectiveness
- * and performance impact is JVM and operating system dependent.
- * Avoiding concurrent writes to the same file by appenders
- * and streams either within or outside a single JVM
- * is recommended.
- *
- * Prudent mode requires JDK 1.4 or later.
- *
- * @param value true to enable prudent mode on next call to
- * activateOptions or setFile.
- *
- * @since 1.2.16
- */
- public void setPrudent(final boolean value) {
- prudent = value;
- }
/**
Sets and opens the file where the log output will
@@ -355,9 +311,7 @@
}
}
Writer fw = createWriter(ostream);
-if (prudent) {
- fw = new org.apache.log4j.helpers.PrudentWriter(fw, ostream);
-} else if(bufferedIO) {
+if(bufferedIO) {
fw = new BufferedWriter(fw, bufferSize);
}
this.setQWForFiles(fw);
Modified:
logging/log4j/trunk/src/main/java/org/apache/log4j/helpers/PrudentWriter.java
URL:
http://svn.apache.org/viewvc/logging/log4j/trunk/src/main/java/org/apache/log4j/helpers/PrudentWriter.java?rev=910151&r1=910150&r2=910151&view=diff
==
---
logging/log4j/trunk/src/main/java/org/apache/log4j/helpers/PrudentWriter.java
(original)
+++
logging/log4j/trunk/src/main/java/org/apache/log4j/helpers/PrudentWriter.java
Mon Feb 15 01:45:20 2010
@@ -1,74 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specifi
svn commit: r910152 - in /logging/log4j/trunk: BUILD-INFO.txt src/changes/changes.xml
Author: carnold Date: Mon Feb 15 01:46:54 2010 New Revision: 910152 URL: http://svn.apache.org/viewvc?rev=910152&view=rev Log: Bug 43313: Post release date back, update BUILD-INFO.txt Modified: logging/log4j/trunk/BUILD-INFO.txt logging/log4j/trunk/src/changes/changes.xml Modified: logging/log4j/trunk/BUILD-INFO.txt URL: http://svn.apache.org/viewvc/logging/log4j/trunk/BUILD-INFO.txt?rev=910152&r1=910151&r2=910152&view=diff == --- logging/log4j/trunk/BUILD-INFO.txt (original) +++ logging/log4j/trunk/BUILD-INFO.txt Mon Feb 15 01:46:54 2010 @@ -24,53 +24,68 @@ either to verify that the release is reproducable or to prepare a hot-fix. -Install VMWare Player or Workstation appropriate for machine. +Apache log4j 1.2.16 was prepared using Ubuntu 8.04 LTS in a virtual machine environment. -Download Ubuntu-6.06-1 desktop from http://www.vmware.com/vmtn/appliances/directory/ubuntu.html +If ssh'ing into a remote instance for release preparation, +use "ssh -Y" to tunnel XWindows to the local machine. -Launch Ubuntu 6.06-1 in VMWare Player (user name and password are ubuntu) -Launch Synaptics Package Manager (System > Administration > Synaptic Package Manager), -select all available repositories (Settings > Repositories), press Reload button -to update list of available packages. Select the following packages for installation: -Subversion, mingw32, sun-java6-jdk, xemacs21. Press Apply to install. Exit Synaptics. +Preparation of environment: -Download Maven-2.0.7 from http://maven.apache.org -Download JMX 1.2.1 Reference Implementation from - http://java.sun.com/products/JavaManagement/download.html -Download JMS 1.1 from http://java.sun.com/products/jms/docs.html -Unzip all in ~ +1. Install Sun Java 6: + +$> sudo sed 's/universe/universe multiverse/' -i /etc/apt/sources.list +$> sudo apt-get update && sudo apt-get -y update +$> sudo apt-get install sun-java6-jdk +$> sudo update-java-alternatives -s java-6-sun +$> export JAVA_HOME=/usr/lib/jvm/java-6-sun + +2. Install Maven 2, Subversion, mingw and xemacs21: + +$> sudo apt-get maven2 subversion mingw xemacs21 + +3. Copy Win32 version of jni_md.h for NTEventLogAppender.dll + +c:\>cd "\Program Files\Java\jdk_1.6.0_16\include\win32 +c:\>scp jni_md.h usern...@hostname: + +$> export JNI_WIN32_INCLUDE_DIR=/home/username + +4. Create a local ssh key to enable "deployment" of +site back to the local machine using scp. + +$> ssh-keygen +$> cd ~/.ssh +$> cat id_rsa.pub >> authorized_keys +$> ssh localhost +$> exit -Copy include/win32/jni_md.h from a Windows JDK to ~ From a command prompt: $ export SVN_EDITOR=xemacs -$ export JAVA_HOME=/usr/lib/jvm/java-6-sun -$ export PATH=$JAVA_HOME/bin:/home/ubuntu/maven-2.0.7/bin:$PATH -$ export JNI_WIN32_INCLUDE_DIR=/home/ubuntu -$ svn co https://svn.apache.org/repos/asf/logging/log4j/tags/v1_2_15 log4j -$ mvn install:install-file -DgroupId=com.sun.jdmk -DartifactId=jmxtools \ - -Dversion=1.2.1 -Dpackaging=jar -Dfile=~/jmx-1_2_1-bin/lib/jmxtools.jar -$ mvn install:install-file -DgroupId=com.sun.jmx -DartifactId=jmxri \ - -Dversion=1.2.1 -Dpackaging=jar -Dfile=~/jmx-1_2_1-bin/lib/jmxri.jar -$ mvn install:install-file -DgroupId=javax.jms -DartifactId=jms \ - -Dversion=1.1 -Dpackaging=jar -Dfile=~/jms1.1/lib/jms.jar -$ cd log4j +$ svn co https://svn.apache.org/repos/asf/logging/log4j/tags/v1_2_16 +$ cd v1_2_16 $ mvn site assembly:assembly If you intended to deploy jars to the repo or update the site, -you need to copy your private keys for people.apache.org -over to ~/.ssh and update ~/maven-2.0.7/conf/settings.xml -to specify user name and key location. +you need to set up ssh to use private keys to access people.apache.org +and create or modify ~/.m2/settings.xml to specify user name and key location. +http://maven.apache.org/SETTINGS/1.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.0.0 + http://maven.apache.org/xsd/settings-1.0.0.xsd";> + logging.repo USERNAME for people.apache.org - /home/ubuntu/.ssh/id_rsa + /home/username/.ssh/id_rsa + + You should test your ssh connection to people.apache.org and localhost before attempting a deployment like: @@ -78,12 +93,29 @@ $ ssh -l USERNAME people.apache.org $ ssh localhost -release:perform has been running into http://jira.codehaus.org/browse/MRELEASE-273. -Release was attempted to be prepared with: - -$ mvn release:perform -DconnectionUrl=scm:svn:https://svn.apache.org/repos/asf/logging/log4j/tags/v1_2_15_rc6 +The release artifacts were originally built by: -but it may have been necessary to specify a -Dgoals=".." to avoid the bug. If so, -any final build notes will be added to bug 40951. +$> svn co http://svn.apache.org/repos/asf/logging/log4j/trunk log4j +$> cd log4j
svn commit: r910156 - in /logging/log4j/trunk: build.xml pom.xml
Author: carnold Date: Mon Feb 15 02:15:29 2010 New Revision: 910156 URL: http://svn.apache.org/viewvc?rev=910156&view=rev Log: Bug 43313: Minor build tweaks Modified: logging/log4j/trunk/build.xml logging/log4j/trunk/pom.xml Modified: logging/log4j/trunk/build.xml URL: http://svn.apache.org/viewvc/logging/log4j/trunk/build.xml?rev=910156&r1=910155&r2=910156&view=diff == --- logging/log4j/trunk/build.xml (original) +++ logging/log4j/trunk/build.xml Mon Feb 15 02:15:29 2010 @@ -741,6 +741,7 @@ + Modified: logging/log4j/trunk/pom.xml URL: http://svn.apache.org/viewvc/logging/log4j/trunk/pom.xml?rev=910156&r1=910155&r2=910156&view=diff == --- logging/log4j/trunk/pom.xml (original) +++ logging/log4j/trunk/pom.xml Mon Feb 15 02:15:29 2010 @@ -360,7 +360,7 @@ typically after deploy so this places it last. --> - test site-deploy assembly:attached deploy + package site-deploy assembly:attached deploy - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
svn commit: r910161 - /logging/log4j/trunk/BUILD-INFO.txt
Author: carnold Date: Mon Feb 15 04:35:56 2010 New Revision: 910161 URL: http://svn.apache.org/viewvc?rev=910161&view=rev Log: Switch to using LiveCD Modified: logging/log4j/trunk/BUILD-INFO.txt Modified: logging/log4j/trunk/BUILD-INFO.txt URL: http://svn.apache.org/viewvc/logging/log4j/trunk/BUILD-INFO.txt?rev=910161&r1=910160&r2=910161&view=diff == --- logging/log4j/trunk/BUILD-INFO.txt (original) +++ logging/log4j/trunk/BUILD-INFO.txt Mon Feb 15 04:35:56 2010 @@ -24,10 +24,7 @@ either to verify that the release is reproducable or to prepare a hot-fix. -Apache log4j 1.2.16 was prepared using Ubuntu 8.04 LTS in a virtual machine environment. - -If ssh'ing into a remote instance for release preparation, -use "ssh -Y" to tunnel XWindows to the local machine. +Apache log4j 1.2.16 was prepared using a Ubuntu 8.04 LTS Live CD. Preparation of environment: @@ -42,7 +39,7 @@ 2. Install Maven 2, Subversion, mingw and xemacs21: -$> sudo apt-get maven2 subversion mingw xemacs21 +$> sudo apt-get install maven2 subversion mingw32 xemacs21 3. Copy Win32 version of jni_md.h for NTEventLogAppender.dll @@ -51,8 +48,8 @@ $> export JNI_WIN32_INCLUDE_DIR=/home/username -4. Create a local ssh key to enable "deployment" of -site back to the local machine using scp. +4. Create a local ssh key with no passphrase to enable +"deployment" of site back to the local machine using scp. $> ssh-keygen $> cd ~/.ssh - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
svn commit: r910164 - /logging/log4j/trunk/BUILD-INFO.txt
Author: carnold Date: Mon Feb 15 06:10:27 2010 New Revision: 910164 URL: http://svn.apache.org/viewvc?rev=910164&view=rev Log: Bug 43313: Tweaking build info Modified: logging/log4j/trunk/BUILD-INFO.txt Modified: logging/log4j/trunk/BUILD-INFO.txt URL: http://svn.apache.org/viewvc/logging/log4j/trunk/BUILD-INFO.txt?rev=910164&r1=910163&r2=910164&view=diff == --- logging/log4j/trunk/BUILD-INFO.txt (original) +++ logging/log4j/trunk/BUILD-INFO.txt Mon Feb 15 06:10:27 2010 @@ -24,22 +24,22 @@ either to verify that the release is reproducable or to prepare a hot-fix. -Apache log4j 1.2.16 was prepared using a Ubuntu 8.04 LTS Live CD. +Apache log4j 1.2.16 was prepared using Ubuntu 9.10. Preparation of environment: 1. Install Sun Java 6: -$> sudo sed 's/universe/universe multiverse/' -i /etc/apt/sources.list +$> sudo sed 's/restricted/restricted universe multiverse/' -i /etc/apt/sources.list $> sudo apt-get update && sudo apt-get -y update $> sudo apt-get install sun-java6-jdk $> sudo update-java-alternatives -s java-6-sun $> export JAVA_HOME=/usr/lib/jvm/java-6-sun -2. Install Maven 2, Subversion, mingw and xemacs21: +2. Install Maven 2, Subversion, mingw and xemacs21, openssh-server: -$> sudo apt-get install maven2 subversion mingw32 xemacs21 +$> sudo apt-get install maven2 subversion mingw32 xemacs21 openssh-server 3. Copy Win32 version of jni_md.h for NTEventLogAppender.dll - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
Re: svn commit: r909868 - in /logging/log4j/trunk: src/changes/ src/main/java/org/apache/log4j/ src/main/java/org/apache/log4j/helpers/ tests/src/java/org/apache/log4j/ tests/witness/
I'm not on the legal affairs committee, the board or the logging PMC so my opinion here is just that. I haven't looked recently at how prudent mode is implemented (although my experience with file system locking tells me that no matter how good it is it will fail on some systems) or what was done to implement it in log4j. It doesn't really matter. As I understand it Ceki is still on the logging PMC. Although he didn't explicitly state it, I take his statement below as a veto. http://www.apache.org/foundation/voting.html clearly indicates that the code needs to be removed until the veto is resolved. I would also suggest that Ceki needs to be careful in not vetoing things simply because they are already in Logback as there is a potential conflict of interest here. If Curt's account is indeed true then I'm not convinced he did anything wrong, although a review of the code might persuade me. There is nothing necessarily wrong with looking at some code, learning something from it, and then writing code independently, but you can't just take the code and modify it a bit. The difficult part with this is that if the code in question is small and there are a limited number of ways of doing something then everything might look like a copyright violation even if it isn't. Wikipedia, at http://en.wikipedia.org/wiki/Copyright_infringement, provides a good discussion of the issue. Again though, given Apache's rules on vetoing I don't think all this even matters in this case. Somehow the code needs to be reverted and then reimplemented. Curt's analysis in the Jira issue, and even providing more detail about what nio methods to use, would easily be sufficient to insure that there is no copyright problem. I am also concerned by Ceki's observation that there are insufficient tests in log4j to test the added feature, not from a copyright point of view but as a general rule. How do you know the code in question even works? If I was on the PMC I would veto a code commit of a new feature that had no tests. Ralph On Feb 14, 2010, at 10:18 AM, Ceki Gülcü wrote: > > You picked the wrong logback feature to rip off. > > You can persists in denying the obvious or come to your senses. I > suggest you privately contact the board or maybe Ralph Goers who is > quite knowledgeable about these matters to get counseling about the > seriousness of your predicament. You are also in violation of sections > 4 and 5 of the ICLA document you signed as an Apache committer. The > Apache foundation is unlikely to condone your personal copyright > infringement implicating the foundation. > > Before this matter gets out of hand with regrettable consequences, I > expect you to: > > 1) immediately revert commit 909868 > > 2) post a public apology to this list and promise to refrain from > similar copyright infringement in the future. > > -- > Ceki Gülcü > > > - > To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org > For additional commands, e-mail: log4j-dev-h...@logging.apache.org > - To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
